| {"language": "Python", "id": 139, "repo_owner": "burnash", "repo_name": "gspread", "head_branch": "simplify-get-records", "workflow_name": "lint_python", "workflow_filename": "main.yaml", "workflow_path": ".github/workflows/main.yaml", "contributor": "burnash", "sha_fail": "483a1db177fd4c33b68d122640c32034d5dbb8ae", "sha_success": "74980b8fba2d73c8446a2664103c52a9c914a4ca", "workflow": "name: lint_python\non:\n push:\n branches:\n - \"**\" # run all branches\n tags-ignore:\n - \"*\" # ignore all tags, release.yaml will trigger the CI\n pull_request: # run on all pull requests\n\nconcurrency:\n cancel-in-progress: true\n group: group-${{ github.ref_name }}\n\njobs:\n lint_python:\n runs-on: ubuntu-latest\n strategy:\n fail-fast: false\n matrix:\n python: [\"3.8\", \"3.9\", \"3.10\", \"3.11\", \"3.x\"]\n steps:\n - uses: actions/checkout@v4\n - uses: actions/setup-python@v5\n with:\n python-version: ${{ matrix.python }}\n - run: pip install -U pip\n - run: pip install -U bandit mypy pyupgrade safety tox setuptools\n - run: bandit --recursive --skip B105,B110,B311,B605,B607 --exclude ./.tox .\n if: ${{ matrix.python >= '3.8' }}\n - run: tox -e lint\n - run: tox -e py\n - run: shopt -s globstar && pyupgrade --py3-only **/*.py # --py36-plus\n - run: safety check -i 42559 -i 62044 # pip <= 20.1.1, we upgrade it just above\n - run: tox -e build\n - run: tox -e doc\n", "logs": [{"step_name": "lint_python (3.8)/7_Run tox -e lint.txt", "log": "##[group]Run tox -e lint\n\u001b[36;1mtox -e lint\u001b[0m\nshell: /usr/bin/bash -e {0}\nenv:\n pythonLocation: /opt/hostedtoolcache/Python/3.8.18/x64\n PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.8.18/x64/lib/pkgconfig\n Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.8.18/x64\n Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.8.18/x64\n Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.8.18/x64\n LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.18/x64/lib\n##[endgroup]\nlint: install_deps> python -I -m pip install -r lint-requirements.txt\n.pkg: install_requires> python -I -m pip install 'flit_core<4,>=3.2'\n.pkg: _optional_hooks> python /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n.pkg: get_requires_for_build_sdist> python /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n.pkg: build_sdist> python /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pyproject_api/_backend.py True flit_core.buildapi\nlint: install_package_deps> python -I -m pip install StrEnum==0.4.15 'google-auth-oauthlib>=0.4.1' 'google-auth>=1.12.0'\nlint: install_package> python -I -m pip install --force-reinstall --no-deps /home/runner/work/gspread/gspread/.tox/.pkg/dist/gspread-6.0.0.tar.gz\nlint: commands[0]> black --check --diff --extend-exclude ./env .\n--- /home/runner/work/gspread/gspread/gspread/worksheet.py\t2023-12-29 18:49:11.002645 +0000\n+++ /home/runner/work/gspread/gspread/gspread/worksheet.py\t2023-12-29 18:49:38.759397 +0000\n@@ -517,13 +517,14 @@\n \n if expected_headers is None:\n # all headers must be unique\n header_row_is_unique = len(keys) == len(set(keys))\n if not header_row_is_unique:\n- raise GSpreadException(\"the header row in the worksheet is not unique\"\n- \"try passing 'expected_headers' to get_all_records\"\n- )\n+ raise GSpreadException(\n+ \"the header row in the worksheet is not unique\"\n+ \"try passing 'expected_headers' to get_all_records\"\n+ )\n else:\n # all expected headers must be unique\n expected_headers_are_unique = len(expected_headers) == len(\n set(expected_headers)\n )\nwould reformat /home/runner/work/gspread/gspread/gspread/worksheet.py\n\nOh no! \ud83d\udca5 \ud83d\udc94 \ud83d\udca5\n1 file would be reformatted, 17 files would be left unchanged.\nlint: exit 1 (1.18 seconds) /home/runner/work/gspread/gspread> black --check --diff --extend-exclude ./env . pid=1934\n.pkg: _exit> python /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n lint: FAIL code 1 (11.96=setup[10.78]+cmd[1.18] seconds)\n evaluation failed :( (12.11 seconds)\n##[error]Process completed with exit code 1.\n"}, {"step_name": "lint_python (3.9)/7_Run tox -e lint.txt", "log": "##[group]Run tox -e lint\n\u001b[36;1mtox -e lint\u001b[0m\nshell: /usr/bin/bash -e {0}\nenv:\n pythonLocation: /opt/hostedtoolcache/Python/3.9.18/x64\n PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.9.18/x64/lib/pkgconfig\n Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64\n Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64\n Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64\n LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.18/x64/lib\n##[endgroup]\nlint: install_deps> python -I -m pip install -r lint-requirements.txt\n.pkg: install_requires> python -I -m pip install 'flit_core<4,>=3.2'\n.pkg: _optional_hooks> python /opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n.pkg: get_requires_for_build_sdist> python /opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n.pkg: build_sdist> python /opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/pyproject_api/_backend.py True flit_core.buildapi\nlint: install_package_deps> python -I -m pip install StrEnum==0.4.15 'google-auth-oauthlib>=0.4.1' 'google-auth>=1.12.0'\nlint: install_package> python -I -m pip install --force-reinstall --no-deps /home/runner/work/gspread/gspread/.tox/.pkg/dist/gspread-6.0.0.tar.gz\nlint: commands[0]> black --check --diff --extend-exclude ./env .\n--- /home/runner/work/gspread/gspread/gspread/worksheet.py\t2023-12-29 18:49:12.019448 +0000\n+++ /home/runner/work/gspread/gspread/gspread/worksheet.py\t2023-12-29 18:49:43.591179 +0000\n@@ -517,13 +517,14 @@\n \n if expected_headers is None:\n # all headers must be unique\n header_row_is_unique = len(keys) == len(set(keys))\nwould reformat /home/runner/work/gspread/gspread/gspread/worksheet.py\n if not header_row_is_unique:\n- raise GSpreadException(\"the header row in the worksheet is not unique\"\n- \"try passing 'expected_headers' to get_all_records\"\n- )\n+ raise GSpreadException(\n+ \"the header row in the worksheet is not unique\"\n+ \"try passing 'expected_headers' to get_all_records\"\n+ )\n else:\n # all expected headers must be unique\n expected_headers_are_unique = len(expected_headers) == len(\n set(expected_headers)\n )\n\nOh no! \ud83d\udca5 \ud83d\udc94 \ud83d\udca5\n1 file would be reformatted, 17 files would be left unchanged.\nlint: exit 1 (1.31 seconds) /home/runner/work/gspread/gspread> black --check --diff --extend-exclude ./env . pid=1903\n.pkg: _exit> python /opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n lint: FAIL code 1 (12.96=setup[11.66]+cmd[1.31] seconds)\n evaluation failed :( (13.20 seconds)\n##[error]Process completed with exit code 1.\n"}, {"step_name": "lint_python (3.10)/7_Run tox -e lint.txt", "log": "##[group]Run tox -e lint\n\u001b[36;1mtox -e lint\u001b[0m\nshell: /usr/bin/bash -e {0}\nenv:\n pythonLocation: /opt/hostedtoolcache/Python/3.10.13/x64\n PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.13/x64/lib/pkgconfig\n Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64\n Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64\n Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64\n LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.13/x64/lib\n##[endgroup]\nlint: install_deps> python -I -m pip install -r lint-requirements.txt\n.pkg: install_requires> python -I -m pip install 'flit_core<4,>=3.2'\n.pkg: _optional_hooks> python /opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n.pkg: get_requires_for_build_sdist> python /opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n.pkg: build_sdist> python /opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/pyproject_api/_backend.py True flit_core.buildapi\nlint: install_package_deps> python -I -m pip install StrEnum==0.4.15 'google-auth-oauthlib>=0.4.1' 'google-auth>=1.12.0'\nlint: install_package> python -I -m pip install --force-reinstall --no-deps /home/runner/work/gspread/gspread/.tox/.pkg/dist/gspread-6.0.0.tar.gz\nlint: commands[0]> black --check --diff --extend-exclude ./env .\n--- /home/runner/work/gspread/gspread/gspread/worksheet.py\t2023-12-29 18:49:10.826736 +0000\n+++ /home/runner/work/gspread/gspread/gspread/worksheet.py\t2023-12-29 18:49:40.023159 +0000\n@@ -517,13 +517,14 @@\n \n if expected_headers is None:\n # all headers must be unique\n header_row_is_unique = len(keys) == len(set(keys))\n if not header_row_is_unique:\n- raise GSpreadException(\"the header row in the worksheet is not unique\"\n- \"try passing 'expected_headers' to get_all_records\"\n- )\n+ raise GSpreadException(\n+ \"the header row in the worksheet is not unique\"\n+ \"try passing 'expected_headers' to get_all_records\"\n+ )\n else:\n # all expected headers must be unique\n expected_headers_are_unique = len(expected_headers) == len(\n set(expected_headers)\n )\nwould reformat /home/runner/work/gspread/gspread/gspread/worksheet.py\n\nOh no! \ud83d\udca5 \ud83d\udc94 \ud83d\udca5\n1 file would be reformatted, 17 files would be left unchanged.\nlint: exit 1 (1.43 seconds) /home/runner/work/gspread/gspread> black --check --diff --extend-exclude ./env . pid=1907\n.pkg: _exit> python /opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n lint: FAIL code 1 (13.37=setup[11.94]+cmd[1.43] seconds)\n evaluation failed :( (13.62 seconds)\n##[error]Process completed with exit code 1.\n"}, {"step_name": "lint_python (3.11)/7_Run tox -e lint.txt", "log": "##[group]Run tox -e lint\n\u001b[36;1mtox -e lint\u001b[0m\nshell: /usr/bin/bash -e {0}\nenv:\n pythonLocation: /opt/hostedtoolcache/Python/3.11.7/x64\n PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.7/x64/lib/pkgconfig\n Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.7/x64\n Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.7/x64\n Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.7/x64\n LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.7/x64/lib\n##[endgroup]\nlint: install_deps> python -I -m pip install -r lint-requirements.txt\n.pkg: install_requires> python -I -m pip install 'flit_core<4,>=3.2'\n.pkg: _optional_hooks> python /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n.pkg: get_requires_for_build_sdist> python /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n.pkg: build_sdist> python /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pyproject_api/_backend.py True flit_core.buildapi\nlint: install_package_deps> python -I -m pip install StrEnum==0.4.15 'google-auth-oauthlib>=0.4.1' 'google-auth>=1.12.0'\nlint: install_package> python -I -m pip install --force-reinstall --no-deps /home/runner/work/gspread/gspread/.tox/.pkg/dist/gspread-6.0.0.tar.gz\nlint: commands[0]> black --check --diff --extend-exclude ./env .\n--- /home/runner/work/gspread/gspread/gspread/worksheet.py\t2023-12-29 18:49:12.077791 +0000\n+++ /home/runner/work/gspread/gspread/gspread/worksheet.py\t2023-12-29 18:49:39.355057 +0000\n@@ -517,13 +517,14 @@\nwould reformat /home/runner/work/gspread/gspread/gspread/worksheet.py\n \n if expected_headers is None:\n # all headers must be unique\n header_row_is_unique = len(keys) == len(set(keys))\n if not header_row_is_unique:\n- raise GSpreadException(\"the header row in the worksheet is not unique\"\n- \"try passing 'expected_headers' to get_all_records\"\n- )\n+ raise GSpreadException(\n+ \"the header row in the worksheet is not unique\"\n+ \"try passing 'expected_headers' to get_all_records\"\n+ )\n else:\n # all expected headers must be unique\n expected_headers_are_unique = len(expected_headers) == len(\n set(expected_headers)\n )\n\nOh no! \ud83d\udca5 \ud83d\udc94 \ud83d\udca5\n1 file would be reformatted, 17 files would be left unchanged.\nlint: exit 1 (1.19 seconds) /home/runner/work/gspread/gspread> black --check --diff --extend-exclude ./env . pid=1935\n.pkg: _exit> python /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n lint: FAIL code 1 (12.92=setup[11.72]+cmd[1.19] seconds)\n evaluation failed :( (12.98 seconds)\n##[error]Process completed with exit code 1.\n"}, {"step_name": "lint_python (3.x)/7_Run tox -e lint.txt", "log": "##[group]Run tox -e lint\n\u001b[36;1mtox -e lint\u001b[0m\nshell: /usr/bin/bash -e {0}\nenv:\n pythonLocation: /opt/hostedtoolcache/Python/3.12.1/x64\n PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.1/x64/lib/pkgconfig\n Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.1/x64\n Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.1/x64\n Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.1/x64\n LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.1/x64/lib\n##[endgroup]\nlint: install_deps> python -I -m pip install -r lint-requirements.txt\n.pkg: install_requires> python -I -m pip install 'flit_core<4,>=3.2'\n.pkg: _optional_hooks> python /opt/hostedtoolcache/Python/3.12.1/x64/lib/python3.12/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n.pkg: get_requires_for_build_sdist> python /opt/hostedtoolcache/Python/3.12.1/x64/lib/python3.12/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n.pkg: build_sdist> python /opt/hostedtoolcache/Python/3.12.1/x64/lib/python3.12/site-packages/pyproject_api/_backend.py True flit_core.buildapi\nlint: install_package_deps> python -I -m pip install StrEnum==0.4.15 'google-auth-oauthlib>=0.4.1' 'google-auth>=1.12.0'\nlint: install_package> python -I -m pip install --force-reinstall --no-deps /home/runner/work/gspread/gspread/.tox/.pkg/dist/gspread-6.0.0.tar.gz\nlint: commands[0]> black --check --diff --extend-exclude ./env .\n--- /home/runner/work/gspread/gspread/gspread/worksheet.py\t2023-12-29 18:49:11.804783 +0000\n+++ /home/runner/work/gspread/gspread/gspread/worksheet.py\t2023-12-29 18:49:49.027795 +0000\n@@ -517,13 +517,14 @@\n \n if expected_headers is None:\n # all headers must be unique\n header_row_is_unique = len(keys) == len(set(keys))\n if not header_row_is_unique:\n- raise GSpreadException(\"the header row in the worksheet is not unique\"\n- \"try passing 'expected_headers' to get_all_records\"\n- )\n+ raise GSpreadException(\n+ \"the header row in the worksheet is not unique\"\n+ \"try passing 'expected_headers' to get_all_records\"\n+ )\n else:\n # all expected headers must be unique\n expected_headers_are_unique = len(expected_headers) == len(\n set(expected_headers)\n )\nwould reformat /home/runner/work/gspread/gspread/gspread/worksheet.py\n\nOh no! \ud83d\udca5 \ud83d\udc94 \ud83d\udca5\n1 file would be reformatted, 17 files would be left unchanged.\nlint: exit 1 (2.35 seconds) /home/runner/work/gspread/gspread> black --check --diff --extend-exclude ./env . pid=1932\n.pkg: _exit> python /opt/hostedtoolcache/Python/3.12.1/x64/lib/python3.12/site-packages/pyproject_api/_backend.py True flit_core.buildapi\n lint: FAIL code 1 (15.07=setup[12.72]+cmd[2.35] seconds)\n evaluation failed :( (15.37 seconds)\n##[error]Process completed with exit code 1.\n"}], "diff": "diff --git a/gspread/worksheet.py b/gspread/worksheet.py\nindex d6268ea..8b4f551 100644\n--- a/gspread/worksheet.py\n+++ b/gspread/worksheet.py\n@@ -519,9 +519,10 @@ class Worksheet:\n # all headers must be unique\n header_row_is_unique = len(keys) == len(set(keys))\n if not header_row_is_unique:\n- raise GSpreadException(\"the header row in the worksheet is not unique\"\n- \"try passing 'expected_headers' to get_all_records\"\n- )\n+ raise GSpreadException(\n+ \"the header row in the worksheet is not unique\"\n+ \"try passing 'expected_headers' to get_all_records\"\n+ )\n else:\n # all expected headers must be unique\n expected_headers_are_unique = len(expected_headers) == len(\n", "difficulty": 0, "changed_files": ["gspread/worksheet.py"], "commit_link": "https://github.com/burnash/gspread/tree/483a1db177fd4c33b68d122640c32034d5dbb8ae"} |