| {"language": "Python", "id": 44, "repo_owner": "fortra", "repo_name": "impacket", "head_branch": "configurable_socks_address", "workflow_name": "Build and test Impacket", "workflow_filename": "build_and_test.yml", "workflow_path": ".github/workflows/build_and_test.yml", "contributor": "rtpt-erikgeiser", "sha_fail": "655e964d0122833acd1f34aca8844e3db3dc5583", "sha_success": "72df5fb660a36f0638a004aeb139995434a5f585", "workflow": "# GitHub Action workflow to build and run Impacket's tests\n#\n\nname: Build and test Impacket\n\non: [push, pull_request]\n\nenv:\n DOCKER_TAG: impacket:latests\n\njobs:\n lint:\n name: Check syntax errors and warnings\n runs-on: ubuntu-latest\n if:\n github.event_name == 'push' || github.event.pull_request.head.repo.full_name !=\n github.repository\n\n steps:\n - name: Checkout Impacket\n uses: actions/checkout@v3\n\n - name: Setup Python 3.8\n uses: actions/setup-python@v4\n with:\n python-version: 3.8\n\n - name: Install Python dependencies\n run: |\n python -m pip install flake8\n\n - name: Check syntax errors\n run: |\n flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics\n\n - name: Check PEP8 warnings\n run: |\n flake8 . --count --ignore=E1,E2,E3,E501,W291,W293 --exit-zero --max-complexity=65 --max-line-length=127 --statistics\n\n test:\n name: Run unit tests and build wheel\n needs: lint\n runs-on: ${{ matrix.os }}\n if:\n github.event_name == 'push' || github.event.pull_request.head.repo.full_name !=\n github.repository\n\n strategy:\n fail-fast: false\n matrix:\n python-version: [\"3.7\", \"3.8\", \"3.9\", \"3.10\"]\n experimental: [false]\n os: [ubuntu-latest]\n include:\n - python-version: \"3.6\"\n experimental: false\n os: ubuntu-20.04\n - python-version: \"3.11-dev\"\n experimental: true\n os: ubuntu-latest\n continue-on-error: ${{ matrix.experimental }}\n\n steps:\n - name: Checkout Impacket\n uses: actions/checkout@v3\n\n - name: Setup Python ${{ matrix.python-version }}\n uses: actions/setup-python@v4\n with:\n python-version: ${{ matrix.python-version }}\n\n - name: Install Python dependencies\n run: |\n python -m pip install --upgrade pip wheel\n python -m pip install tox tox-gh-actions -r requirements.txt -r requirements-test.txt\n\n - name: Run unit tests\n run: |\n tox -- -m 'not remote'\n\n - name: Build wheel artifact\n run: |\n python setup.py bdist_wheel\n\n docker:\n name: Build docker image\n needs: lint\n runs-on: ubuntu-latest\n if:\n github.event_name == 'push' || github.event.pull_request.head.repo.full_name !=\n github.repository\n\n continue-on-error: true\n steps:\n - name: Checkout Impacket\n uses: actions/checkout@v3\n\n - name: Build docker image\n run: |\n docker build -t ${{ env.DOCKER_TAG }} .\n", "logs": [{"step_name": "Check syntax errors and warnings/5_Check syntax errors.txt", "log": "##[group]Run flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics\n\u001b[36;1mflake8 . --count --select=E9,F63,F7,F82 --show-source --statistics\u001b[0m\nshell: /usr/bin/bash -e {0}\nenv:\n DOCKER_TAG: impacket:latests\n pythonLocation: /opt/hostedtoolcache/Python/3.8.18/x64\n PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.8.18/x64/lib/pkgconfig\n Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.8.18/x64\n Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.8.18/x64\n Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.8.18/x64\n LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.18/x64/lib\n##[endgroup]\n./impacket/examples/ntlmrelayx/servers/socksserver.py:463:18: E999 SyntaxError: non-default argument follows default argument\n def __init__(self, server_address=('127.0.0.1', 1080), handler_class=SocksRequestHandler, api_port):\n ^\n1 E999 SyntaxError: non-default argument follows default argument\n1\n##[error]Process completed with exit code 1.\n"}], "diff": "diff --git a/impacket/examples/ntlmrelayx/servers/socksserver.py b/impacket/examples/ntlmrelayx/servers/socksserver.py\nindex 53f8cd5b..43bf6c63 100644\n--- a/impacket/examples/ntlmrelayx/servers/socksserver.py\n+++ b/impacket/examples/ntlmrelayx/servers/socksserver.py\n@@ -460,7 +460,7 @@ class SocksRequestHandler(socketserver.BaseRequestHandler):\n \n \n class SOCKS(socketserver.ThreadingMixIn, socketserver.TCPServer):\n- def __init__(self, server_address=('127.0.0.1', 1080), handler_class=SocksRequestHandler, api_port):\n+ def __init__(self, server_address=('127.0.0.1', 1080), handler_class=SocksRequestHandler, api_port=9090):\n LOG.info('SOCKS proxy started. Listening on %s:%d', server_address[0], server_address[1])\n \n self.activeRelays = {}\n", "difficulty": 3, "changed_files": ["impacket/examples/ntlmrelayx/servers/socksserver.py"], "commit_link": "https://github.com/fortra/impacket/tree/655e964d0122833acd1f34aca8844e3db3dc5583"} |