<story><title>A study of Google&apos;s code review tooling (Critique)</title><url>https://engineercodex.substack.com/p/how-google-takes-the-pain-out-of</url></story><parent_chain><item><author>dontreact</author><text>I generally like the tool.&lt;p&gt;When your code review tool is really nice one unexpected negative is that it can create a culture of nitpicking. Sometimes it’s not worth arguing over small details like variable naming but the tool makes it really easy for things to head in that direction.&lt;p&gt;Sometimes variable naming isn’t a small detail. But sometimes it is and it’s a waste of everyone’s time to argue about it.</text></item></parent_chain><comment><author>ayberk</author><text>I don&amp;#x27;t know if it&amp;#x27;s the tool honestly. I&amp;#x27;ve recently switched teams and I&amp;#x27;m in the process of getting java readability. The whole experience so far has been much worse than getting my C++ readability. I even get &amp;quot;nit&amp;quot; comments on the code I haven&amp;#x27;t changed. I have had multiple comments where reviewer basically &amp;quot;preferred&amp;quot; one style over another. It&amp;#x27;s been still mostly helpful, but I&amp;#x27;ve had my share of frustration.&lt;p&gt;C++ readability was a much, much better experience. All the comments were about actually making the code better, eg, &amp;quot;use THIS_MACRO() instead of THAT_MACRO(), because go&amp;#x2F;...&amp;quot;.&lt;p&gt;I guess I think it&amp;#x27;s much more about the reviewer, and based on my anecdotal experience, the language :)</text></comment>
<story><title>A study of Google&apos;s code review tooling (Critique)</title><url>https://engineercodex.substack.com/p/how-google-takes-the-pain-out-of</url></story><parent_chain><item><author>dontreact</author><text>I generally like the tool.&lt;p&gt;When your code review tool is really nice one unexpected negative is that it can create a culture of nitpicking. Sometimes it’s not worth arguing over small details like variable naming but the tool makes it really easy for things to head in that direction.&lt;p&gt;Sometimes variable naming isn’t a small detail. But sometimes it is and it’s a waste of everyone’s time to argue about it.</text></item></parent_chain><comment><author>TheBlight</author><text>Excessive subjective feedback can be soul-crushing.</text></comment>