2015/04/21/#juju-dev.txt

=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
=== kadams54 is now known as kadams54-away
=== kadams54 is now known as kadams54-away
[03:24] <menn0> thumper, cherylj: http://reviews.vapour.ws/r/1457/
[03:25]  * thumper looks
[03:26] <menn0> thumper: next PR will hook up bufferedLogWriter to the logsender worker and get these running inside the unit and machine agents
[03:26]  * thumper nods
=== kadams54 is now known as kadams54-away
[04:16] <menn0> thumper: chat?
[04:16] <thumper> menn0: sure
[04:16] <menn0> thumper: which hangout?
[04:16] <thumper> meh
[04:16] <thumper> standup
[04:16] <menn0> kk
[07:22] <mattyw> morning all
[07:26] <dimitern> morning
[07:26] <dimitern> dooferlad, happy birthday! :)
[07:26] <dooferlad> dimitern: :-)
[08:04] <TheMue> morning o/
[08:05] <TheMue> dooferlad: oh, what do I see? happy birthday!
[08:06] <TheMue> wow, April is always special, 5 to 6 birthdays per week, including our little daughter
[09:58] <mattyw> gsamfira, ping?
[10:02] <gsamfira>  mattyw: pong\
[10:03] <mattyw> gsamfira, hey there - was good seeing you last week, couple of questions...
[10:03] <gsamfira> mattyw: it was :D. Hope to do it son again :D
[10:03] <gsamfira> mattyw: sure thing, shoot
[10:04] <mattyw> gsamfira, 1. In one of the cloudbase talks there was a mention of common problems in unit tests, and one of them was "The process cannot access the file because it is being used by another process". And there was a statement about the pattern that usually leads to it. Can you remember what that was?
[10:04] <gsamfira> yup
[10:04] <gsamfira> its opening a file for writing, defering the close and then movinf the file
[10:04] <gsamfira> :)
[10:05] <gsamfira> something like fd, err := os.Open("file"); defer fd.close; os.Move(fd.Name(), "/tmp/bla")
[10:05] <gsamfira> that usually blows up on windows
[10:06] <gsamfira> mattyw: simple way to get around it is to simply close the file before trying to delete or move it
[10:06] <mattyw> gsamfira, ok cool, I'll see if I can fix some of those this week
[10:07] <mattyw> gsamfira, question 2. Have you ever considered making a chocolately package for juju?
[10:07] <gsamfira> mattyw: huh...good idea :D
[10:07] <mattyw> gsamfira, I'll add that to my list as well :)
[10:08] <mattyw> gsamfira, no more questions for now :)
[10:09] <gsamfira> mattyw: there are some tests that try to do cleanup by simply doing a defer os.Remove("target"). Those can be replaced with defer func() { fd.Close(); os.Remove(fd.Name())}()
[10:09] <gsamfira> if those are the ones you plan to fix
[10:09] <gsamfira> then that would drasticly reduce the leftovers in $env:TMP
[10:09] <gsamfira> :D
[10:10] <mattyw> gsamfira, there are a number in apiserver that fail that way I think so I was hoping to make time to take a look at those this week
[10:11] <gsamfira> mattyw: hmm. This must have happened in some recent commit. I did a merge on friday that fixed tests on windows again :)
[10:11] <mattyw> gsamfira, ah - I have a branch from friday morning, I'll check again
[10:13] <gsamfira> mattyw: https://github.com/juju/juju/commit/34313b849aee8cfed333df1d02ccdb7e0cc32f58 <-- this should pass :)\
=== kadams54 is now known as kadams54-away
=== kadams54 is now known as kadams54-away
[12:11] <mattyw> gsamfira, yep, tests look good :)
[12:11] <mattyw> (I ran them ages ago but totally forgot)
[12:12] <gsamfira> mattyw: sweet! now we need to make them less flaky and finally run them in parallel to the ubuntu ones in the CI :P
[12:12] <mattyw> gsamfira, is mgz taking that on?
[12:12] <gsamfira> mattyw: yup. And we will help wherever we can :)
[12:12] <jam> dimitern: reviewed your patch
[12:17] <dimitern> jam, thanks!
[12:23] <mup> Bug #1446608 was opened: agent panic on MAAS network with uppercase characters <cloud-installer> <landscape> <juju-core:New> <https://launchpad.net/bugs/1446608>
=== kadams54-away is now known as kadams54
[13:26] <mgz> mattyw: I sent mail about windows tests - there are a couple of metering suite failures that aren't immediately obvious to me
[13:26] <mattyw> mgz, I just saw that - thanks very much. I'll take a look at those now
[13:27] <mattyw> mgz, this on master?
[13:27] <mgz> mattyw: yup, windows tests on master only
[13:28] <mattyw> mgz, I'll take a look at the meterstatus one
[13:28] <mattyw> mgz, the rest we need someone who knows more
[13:28] <mgz> mattyw: yeah, I got 'em
[13:35] <mup> Bug #1394755 changed: juju ensure-availability should be able to target existing machines <cloud-installer> <ha> <landscape> <juju-core:Fix Released by natefinch> <juju-core 1.23:Fix Released by natefinch> <https://launchpad.net/bugs/1394755>
[13:35] <mup> Bug #1430340 changed: Failing to create tempdir in tests on windows <test-failure> <windows> <juju-core:Fix Released by gabriel-samfira> <https://launchpad.net/bugs/1430340>
[13:35] <mup> Bug #1432652 changed: upgrade_test.go: TestLoginsDuringUpgrade failing due to "upgrade in progress" <ci> <ppc64el> <test-failure> <unit-tests> <juju-core:Fix Released by menno.smits> <https://launchpad.net/bugs/1432652>
[13:35] <mup> Bug #1435152 changed: Can't deploy local charm in non-server environment <juju-core:Fix Released by waigani> <juju-core 1.23:Fix Released by waigani> <https://launchpad.net/bugs/1435152>
[13:35] <mup> Bug #1438683 changed: Containers stuck allocating, interface not up <add-machine> <cloud-installer> <landscape> <maas-provider> <network> <juju-core:Fix Released by mfoord> <juju-core 1.23:Fix Released by mfoord> <juju-core trunk:Fix Released by mfoord> <https://launchpad.net/bugs/1438683>
[13:35] <mup> Bug #1439364 changed: error in logs: environment does not support networking <logging> <network> <juju-core:Fix Released by mfoord> <juju-core 1.23:Fix Released by mfoord> <https://launchpad.net/bugs/1439364>
[13:35] <mup> Bug #1439447 changed: tools download in cloud-init should not go through http[s]_proxy <cloud-installer> <landscape> <juju-core:Fix Released by cherylj> <juju-core 1.23:Fix Released by cherylj> <https://launchpad.net/bugs/1439447>
[13:36] <mup> Bug #1443440 changed: 1.23-beta4 sporadically fails autotests <local-provider> <mongodb> <systemd> <ubuntu-engineering> <vivid> <juju-core:Fix Released by menno.smits> <juju-core 1.23:Fix Released by menno.smits> <https://launchpad.net/bugs/1443440>
[13:36] <mup> Bug #1443541 changed: juju 1.23b4 vivid panic: runtime error: invalid memory address or nil pointer dereference <openstack> <uosci> <juju-core:Fix Released by ericsnowcurrently> <juju-core 1.23:Fix Released by ericsnowcurrently> <https://launchpad.net/bugs/1443541>
[13:36] <mup> Bug #1443904 changed: Apache-licensed code has been borrowed with violation of license requirements <packaging> <tech-debt> <juju-core:Fix Released by wallyworld> <juju-core 1.23:Fix Released by wallyworld> <https://launchpad.net/bugs/1443904>
[13:41] <sinzui> dimitern, how goes the container addressability feature flag?
[13:42] <dimitern> sinzui, it's being tested - so far, so good
[13:42] <sinzui> :)
[13:42] <dimitern> sinzui, I'll most likely land it in a couple of hours - I have a review and a few things to fix first
[13:43] <sinzui> dimitern, understood. I am going to turn off CI so that it doesn't start testing something ahead of you.
[13:43] <dimitern> thanks sinzui
[13:48] <mup> Bug #1426461 changed: Some service.Service methods should return an error <tech-debt> <juju-core:Fix Released by ericsnowcurrently> <https://launchpad.net/bugs/1426461>
[13:48] <mup> Bug #1446662 was opened: Vivid bootstrap and destroy-environment intermittently fails <bootstrap> <destroy-environment> <golang> <vivid> <juju-core:In Progress by gz> <juju-core 1.23:Fix Committed by gz> <https://launchpad.net/bugs/1446662>
=== urulama_ is now known as urulama
[14:12] <mup> Bug #1351099 changed: WARNING juju.worker.uniter.charm git_deployer.go:200 no current staging repo <cloud-installer> <landscape> <logging> <usability> <juju-core:Fix Released by davidpbritton> <https://launchpad.net/bugs/1351099>
[14:12] <mup> Bug #1414424 changed: envStateCollection FindId and RemveId don't filter on env-uuid field <juju-core:Fix Released by waigani> <https://launchpad.net/bugs/1414424>
[14:12] <mup> Bug #1422791 changed: DestroyEnvironment does not remove entry from envusers <destroy-environment> <users> <juju-core:Fix Released by waigani> <https://launchpad.net/bugs/1422791>
[15:02] <cherylj> Hey core team, join the bootstack / core call if you can.
[15:03] <cherylj> cmars, dimitern, TheMue ^^
[15:03] <TheMue> cherylj: yup
[15:03] <dimitern> cherylj, I won't manage, sorry :/
[15:17] <TheMue> cherylj: hmmmpf, do you see me moving? FF says it's freezed
[15:17] <cherylj> TheMue: Yes, I do
[15:17] <TheMue> cherylj: fine, and I can at least hear you
[16:00] <lazyPower> o/ I have a question about the enhanced service-status code thats coming... will we get something on the node itself like "unit-get status" to determine the overall status of the service being deployed? or are we relying on hook context to determine the status as we have in the past.
[16:21] <alexisb> lazyPower, can you send a note to fwereade
[16:21] <lazyPower> will do
[16:31] <alexisb> I need a volunteer for this bug: https://bugs.launchpad.net/juju-core/+bug/1441826
[16:31] <mup> Bug #1441826: deployer and quickstart are broken in 1.24-alpha1 <api> <ci> <deployer> <quickstart> <regression> <juju-ci-tools:Triaged> <juju-core:Triaged> <https://launchpad.net/bugs/1441826>
[17:33] <mup> Bug #1444354 changed: juju backups includes previous backups in saved file <backup-restore> <juju-core:Fix Released> <https://launchpad.net/bugs/1444354>
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
=== JoshStrobl is now known as Josh|MakingFood
=== kadams54 is now known as kadams54-away
=== Josh|MakingFood is now known as JoshStrobl
[19:41] <sinzui> cmars: juju-ci is failing because git.apache.org/thrift does not exist. I think I need to force this test to pass or not vote so that we can release 1.23.1
[19:44] <alexisb> sinzui, cmars is out
[19:44] <alexisb> force the non vote
[19:45] <sinzui> alexisb, looks like bad server on their side. I cannot get it either.
=== kadams54-away is now known as kadams54
[19:53] <stokachu> what's the recommended way to pull the current api state? i used to use juju.NewConnFromName
[19:54] <stokachu> it looks like NewAPIClient and NewAPIRoot gives me access to the api state, is that the new recommended way?
[19:54] <stokachu> api state + api client
[20:42] <alexisb> stokachu, sorry missed your questions earlier
[20:43] <alexisb> stokachu, can you send your question to juju-dev mailing list
[20:43] <alexisb> stokachu, we still have many folks out on swap days
[20:51] <stokachu> alexisb: ah ok, its not urgent just some exploritory work im doing in the juju internals
[21:01] <lazyPower> o/ can someone point me in the right direction as to what i'm doing incorrectly thats spawning 'no unit id'
[21:01] <lazyPower> http://paste.ubuntu.com/10863354/
[21:04] <alexisb> thumper, ericsnow, perrito666 others who might be online ^^^
[21:05] <lazyPower> the intention is getting/sending variables out of band of the hook context in which its intended. "such as i have networking config updated, and i need to transmit over the networking relationship between hosts"
[21:07] <ericsnow> lazyPower: relation-get -r <rel id> <key> <unit id>
[21:07] <ericsnow> lazyPower: looks like you are missing the unit ID
[21:08] <lazyPower> root@juju-lazyp-canonistack-machine-9:/var/lib/juju/agents/unit-docker-0/charm# relation-get private-address -r 19 flannel-docker/0
[21:08] <lazyPower> 10.55.61.185
[21:08] <lazyPower> oi
[21:08] <lazyPower> ok i see *why* it has to be scoped that way though, so far i've only relation-set out of band. Thanks for the rundown ericsnow
[21:09] <ericsnow> lazyPower: np :)
[21:15] <mup> Bug #1446857 was opened: MeterStatusWatcher tests fail on windows test slave <ci> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1446857>
=== kadams54 is now known as kadams54-away
[21:45] <mup> Bug #1446871 was opened: Unit hooks fail on windows if PATH is uppercase <ci> <hooks> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1446871>
[21:52] <sinzui> xwwt, alexisb and canonistack hates us. I will make the one failing non-voting because we have other tests in the substrate that passed an hour ago
[22:05] <alexisb> wallyworld_, thumper can someone review williams pull request from earlier today
[22:05] <wallyworld_> ok, will do soon
[22:06] <alexisb> wallyworld_, anastasiamac is up for all call reviewer, but I would like william to have what he needs in the morning
[22:06] <alexisb> wallyworld_, thanks
[22:06] <wallyworld_> sure, np
=== kadams54-away is now known as kadams54
[22:37] <xwwt> sinzui: ty for the update on that
[22:38] <sinzui> xwwt, we have a bless, I am waiting for all the assets to arrive to queue the release
[22:38] <xwwt> sinzui: cool.  ty for sticking with this
[22:39] <mup> Bug #1446885 was opened: Skipped cmd/jujud/agent/upgrade_test.go tests on windows <skipped-test> <test-failure> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1446885>
=== kadams54 is now known as kadams54-away
[22:48] <sinzui> wallyworld_, thumper : do either of you have a minute to review http://reviews.vapour.ws/r/1464/
[22:48] <wallyworld_> sure
[22:48] <wallyworld_> sinzui: +1
[22:50] <mgz> ocr: http://reviews.vapour.ws/r/1463
[23:06] <sinzui> mgz: I have ci paused. I can wait a few hours for your current branch
[23:07] <mgz> sinzui: for trunk? sounds good, I have one more test script change to work around a bunch of uniter failures
[23:08] <sinzui> mgz, yes trunk. I don't want to test 1.23 again given how unwell joyent, aws, and canonistack at this hour
[23:56] <wallyworld_> thumper: i've updated http://reviews.vapour.ws/r/1440 if you could take another look that would be great