|
=== asac_ is now known as asac |
|
[01:18] <[reed]> fta: a ton of Mozilla people hate Hg |
|
[01:18] <[reed]> if something else came along that was better |
|
[01:18] <[reed]> we'd totally switch |
|
[01:19] <fta> i'm surprised you didn't jump on git. what was it ? win support ? |
|
[01:20] <[reed]> yeah, win support |
|
[01:21] <fta> it seems it improved a lot recently |
|
[06:05] <gnomefreak> anyone around yet? |
|
[06:20] <gnomefreak> Jazzva: do we really need to package chatzilla since you packaged the other extension thar is pretty much same (as far as i can tell) |
|
[09:02] <XioNoX> hi ! |
|
[09:20] <XioNoX> asac ? |
|
[09:23] <asac> hi XioNoX |
|
[09:25] <XioNoX> good weekend ? |
|
[09:25] <asac> yep |
|
[09:26] <asac> went to an island where a friend is living now ;) |
|
[09:29] <XioNoX> nice |
|
[09:29] <XioNoX> what is the program for today ? |
|
[09:29] <XioNoX> :D |
|
[09:35] <asac> i didnt work anything out yet |
|
[09:35] <asac> did you think about what i ment? |
|
[09:36] <asac> like activating the menu entry when we the event comes from current selected tab? |
|
[09:38] <XioNoX> I've think about it |
|
[09:39] <XioNoX> but I don't really understand it |
|
[09:39] <XioNoX> :) |
|
[09:42] <XioNoX> this : <asac> XioNoX: sure. ... remind me that i wanted to tell you something about that |
|
[09:42] <XioNoX> <asac> XioNoX: once you implemented that events from the current active tab automatically active the menu ? |
|
[09:42] <asac> XioNoX: right. so i already said what I wanted to tell you |
|
[09:42] <asac> the last line should make it clear |
|
[10:00] <XioNoX> seem to work |
|
[10:00] <XioNoX> :) |
|
[10:01] <asac> cool |
|
[10:01] <asac> so where are we now? |
|
[10:01] <asac> XioNoX: we have a working menu entry? |
|
[10:02] <asac> that - once clicked - can gather the current mime types? |
|
[10:02] <asac> and open the "plugin wizard" with those plugin infos? |
|
[10:02] <XioNoX> not yet |
|
[10:02] <XioNoX> but soon :) |
|
[10:02] <asac> XioNoX: i think getpluginInfo is nice, but its not reall what we want |
|
[10:02] <asac> from the mime-type perspective |
|
[10:02] <XioNoX> ? |
|
[10:02] <asac> e.g. now we get _all_ mime-types the plugin supports |
|
[10:03] <asac> but what we want is just the mime-type that the content of the website uses |
|
[10:03] <XioNoX> but if there are many different mimetypes ? |
|
[10:04] <asac> XioNoX: what do you mean? |
|
[10:04] <asac> XioNoX: the idea is to gather the mime-types used on the tab |
|
[10:04] <XioNoX> I agree |
|
[10:04] <asac> not the mime-types supported by all plugins used on the tab |
|
[10:05] <asac> with getPluginInfo we do the latter |
|
[10:05] <XioNoX> I don't get it |
|
[10:06] <asac> what in particular isnt clear? |
|
[10:06] <XioNoX> <asac> XioNoX: the idea is to gather the mime-types used on the tab |
|
[10:07] <XioNoX> it is what we do, no ? |
|
[10:07] <asac> no |
|
[10:07] <asac> you use getPluginInfo |
|
[10:07] <asac> which gives you all mime-types supported |
|
[10:07] <asac> look at about:plugins |
|
[10:07] <asac> when you look at that page in firefox you see that every plugin can support many mime-types |
|
[10:08] <XioNoX> ok |
|
[10:08] <asac> not 100% sure |
|
[10:08] <asac> XioNoX: have you tried a page with just flash on? |
|
[10:08] <asac> is there still the "director" mime-type? |
|
[10:08] <XioNoX> but getPluginInfo return mimetype of content who are not supported |
|
[10:08] <asac> if so, getPluginInfo is wrong |
|
[10:08] <asac> he? |
|
[10:08] <XioNoX> no no |
|
[10:08] <asac> "not supported"? |
|
[10:08] <XioNoX> yes |
|
[10:09] <XioNoX> if you don't have flashplugin installed |
|
[10:09] <XioNoX> and you go on youtube |
|
[10:09] <XioNoX> he will give you he mimetype of flash stuff |
|
[10:10] <XioNoX> youtube return only flash |
|
[10:10] <XioNoX> mimetype |
|
[10:12] <asac> yes |
|
[10:12] <asac> and since getPluginInfo also gives you the "director" mime-type |
|
[10:13] <asac> we would ask the user to select alternatives for a mime-type he doesnt care about |
|
[10:16] <XioNoX> but it is because director is present on the page |
|
[10:16] <XioNoX> if you go on youtube the only mimtype present is flash stuff |
|
[10:22] <XioNoX> director mimetype is because there are director content on the adobe testpage |
|
[10:29] <XioNoX> the point is I'm not sure that the "plugin wizard" can handle many différent mimetypes |
|
[10:29] <XioNoX> if there are different content on the page |
|
[10:35] <asac> XioNoX: ah... cool |
|
[10:36] <asac> XioNoX: so next is to open the plugin finder wizard (the old and rotten one) with the mimeInfo Array |
|
[10:36] <XioNoX> rotten? |
|
[10:36] <asac> XioNoX: scratch that |
|
[10:36] <XioNoX> ok |
|
[10:36] <asac> the original pluginfinderwizard that is currently implemented in ubufox |
|
[10:38] <asac> Jazzva: i wanted to upload nspluginwrapper to intrepid |
|
[10:40] <Jazzva> asac, ok... I think there's still the problem with popping-out of nsviewer |
|
[10:40] <Jazzva> but maybe that's just me ;). |
|
[10:40] <Jazzva> but, it's there in the older version too, so I don't think we will have a real regression |
|
[10:44] <Jazzva> I'm having troubles with threads in the school project. Some of them are still sleeping, even after they should be woken up :). |
|
[11:05] <gnomefreak> anyone else have issues with the latest kernel "-5" (file system is read only?) also lose the system beep? |
|
[11:06] <gnomefreak> which in turn makes it impossible to configure X so now there is no X with -5 |
|
[11:09] <asac> Jazzva: threads are easy to deadlock ;) |
|
[11:09] <asac> gnomefreak: hmm ... i had issues with file-system |
|
[11:09] <asac> gnomefreak: but that was just for one boot |
|
[11:09] <asac> since then its working |
|
[11:11] <Jazzva> gnomefreak, related to chatzilla... I hadn't get snowl to work, when I was packaging it... neither from package, nor from xpi |
|
[11:11] <Jazzva> asac, apparently :) |
|
[11:11] <gnomefreak> asac: ah i only tried one boot the second boot i got a ncurses screen with repair, boot, config X and one other dont remember |
|
[11:12] <asac> Jazzva: threads in Java, python, C? |
|
[11:12] <gnomefreak> Jazzva: ah ok. and is chatzilla gonna be a special build since it is in a java dir and due to XUL? |
|
[11:12] <asac> Jazzva: does snowl have native components? |
|
[11:13] <Jazzva> asac, Java... |
|
[11:13] <Jazzva> asac, native components? |
|
[11:13] <gnomefreak> i would assume its same set up as chatzilla |
|
[11:13] <gnomefreak> or atleast close |
|
[11:14] <Jazzva> asac, actually, I'm still investigating why it blocks. The receive in that socket works great, and the send just started blocking for some reason... |
|
[11:15] <gnomefreak> i will look for source for chatzilla today but i have a feeling the XUL is gonna cause this to be something where XPI.TEMPLATE |
|
[11:15] <gnomefreak> doesnt work |
|
[11:15] <gnomefreak> sound juicer needs a kick in arse |
|
[11:20] <asac> Jazzva: why do you want to do threads? |
|
[11:20] <asac> Jazzva: native components == components/*.so files exist |
|
[11:21] <Jazzva> asac, well, I need a thread for that listens for new connections, and then threads that will do the communication with clients and workstations (thats on server-side)... something like that |
|
[11:22] <Jazzva> s/for that/that/ |
|
[11:23] <Jazzva> asac, seems that snowl doesn't have native components |
|
[11:28] <asac> Jazzva: the modern way of doing this is using nio |
|
[11:28] <asac> e.g. non-blocking IO |
|
[11:28] <asac> for that you dont need threads |
|
[11:28] <Jazzva> will read a bit about that :) |
|
[11:30] <asac> Jazzva: anyway. what you need to do if you want to do multiple threads |
|
[11:31] <asac> is implement a work queue that the clients poll on and where the server puts the work received from the clients |
|
[11:31] <asac> in that way you shouldnt dead lock |
|
[11:33] <asac> e.g. new Client() { public void run() { while(workQueue.isntDead()) { Work work = workQueue.nextWork(mytimeoutinms); } } |
|
[11:33] <asac> e.g. new Client() { public void run() { while(workQueue.isntDead()) { Work work = workQueue.nextWork(mytimeoutinms); processWork(work); } } |
|
[11:33] <asac> ;) |
|
[11:33] <asac> well actually ;) |
|
[11:34] <asac> e.g. new Runnable() { public void run() { while(workQueue.isntDead()) { Work work = workQueue.nextWork(mytimeoutinms); sendWorkToClient(work, client); } } |
|
[11:34] <asac> and then Thread t = new Thread(runnable); t.start(); |
|
[11:35] <asac> workQueue needs to be a threadsafe mutex obviously |
|
[11:35] <Jazzva> right... but now that's not a problem :) |
|
[11:36] <Jazzva> server thread regularly checks for new messages from client and it fetches them fine... |
|
[11:36] <Jazzva> the problem is when I try to send a message from that thread... that's when everything locks... and I got another idea now :) |
|
[11:36] <asac> well s/client/workstation/ |
|
[11:37] <asac> Jazzva: from which thread are you trying to send? |
|
[11:37] <asac> maybe your "send" method is synchronized and when that send blocks everything else is waiting for it? |
|
[11:38] <Jazzva> hmm... let me see... might be... i was experimenting with wait()/notify() and maybe I forgot to remove synchronized, when I found out where I need to use wait() and notify() |
|
[11:39] <Jazzva> that actually might be the problem... but then I don't know how to solve it :) |
|
[11:40] <Jazzva> I made my SocketCommunicator class that has methods for sending/receiving strings/Objects, and I kept getting NullPointerExceptions when I tried to send as soon as I started the server, because the SocketCommunicator still wasn't initialized |
|
[11:40] <Jazzva> s/wasn't initialized/didn't finish initialization/ |
|
[11:40] <Jazzva> hmm... let's se |
|
[11:40] <Jazzva> see |
|
[11:41] <asac> Jazzva: you should use preexisting thread safe work queues |
|
[11:41] <asac> instead of reinventing and trying to implement a mutex on your own |
|
[11:41] <asac> though its fun to actually do it ;) |
|
[11:42] <asac> Jazzva: the code snippet about is basically the "work dispatcher" code that should work |
|
[11:42] <asac> the server socket will be read from another thread, which puts new Work(....) into that work queue |
|
[11:43] <Jazzva> I think the thread where it reads/writes from/to socket is the problematic one :) |
|
[11:43] <Jazzva> let's see if it will work now |
|
[11:44] <asac> sounds shaky |
|
[11:45] <asac> Jazzva: personally i would use a tiny embedded http server |
|
[11:45] <asac> err, servlet engine |
|
[11:45] <Jazzva> I'm still not that much expirienced :) |
|
[11:45] <asac> jetty ;) |
|
[11:45] <asac> you can start that and implement the "job accept code" in a servlet then |
|
[11:46] <Jazzva> jetty? |
|
[11:46] <asac> but well |
|
[11:46] <asac> Jazzva: http://docs.codehaus.org/display/JETTY/Embedding+Jetty |
|
[11:47] <asac> http://www.mortbay.org/jetty-6/ |
|
[11:47] <asac> but well. maybe the idea of that school project is to learn about how to use socket on the low-level ;) |
|
[11:47] <asac> not sure |
|
[11:48] <Jazzva> maybe... :) |
|
[11:48] <Jazzva> I suppose it would be, since they thought us with using threads and sockets and the rest... |
|
[11:50] <Jazzva> asac, synchronized was the problem... |
|
[11:51] <Jazzva> But I'm still not sure why it was messing up... all the initialization is done in the constructor, so it shouldn't call a method, until a constructor is done. by that time, all attributes should be initialized, but I still got null pointers for some... |
|
[11:52] <Jazzva> ah no... I was stupid :) |
|
[11:53] <Jazzva> The problem wasn't there... It was in the sendMsg method, that was always sending to fixed client (for testing purposes), but didn't check if the client exists... |
|
[11:53] <Jazzva> Thanks for the help :) |
|
[11:53] <Jazzva> Once I put up that check no more null pointers |
|
[11:54] <gnomefreak> if using .xpi i unpack it but do i push bleh.xpi to .upstream branch? |
|
[11:54] <Jazzva> gnomefreak, no... you should just push the source of the unpacked xpi |
|
[11:54] <gnomefreak> ok thought so |
|
[11:54] <gnomefreak> Jazzva: thanks |
|
[11:55] <gnomefreak> i will see what i can do with chatzilla than |
|
[11:57] <Jazzva> no problem :) |
|
[12:00] <asac> Jazzva: just removing synchronized will probably cause concurrency issues |
|
[12:00] <asac> Jazzva: you ned to use thread safe work queue ;) |
|
[12:01] <Jazzva> but this is just for sending/receiving. each thread has it's own socket communicator, so there shouldn't be problems :) |
|
[12:01] <Jazzva> each thread has it's own input and output streams, so that should be fine... right? |
|
[12:04] <gnomefreak> what does -d do for cvs? cvs --help dpesnt well help |
|
[12:04] <Jazzva> -d cvs_root_directory |
|
[12:04] <Jazzva> Use cvs_root_directory as the root directory pathname of the repository. Overrides the setting of the $CVSROOT environment variable. See node `Repository' in the CVS manual. |
|
[12:04] <Jazzva> that's what man cvs says |
|
[12:05] <Jazzva> gnomefreak ^ |
|
[12:05] <gnomefreak> its telling me i didnt set the CVSROOT environment variable. and i did with CVSROOT=:pserver:[email protected]:/cvsroot |
|
[12:05] <asac> Jazzva: well ... but how do you get the input to the output stream? |
|
[12:05] <asac> there should be some inter-thread boundary which you need to pass using proper synchronization |
|
[12:05] <asac> in almost all cases. |
|
[12:05] <asac> (because you onlyhave one serversocket thread and multiple client socket threads) |
|
[12:05] <asac> hmm |
|
[12:07] <Jazzva> hmm.. probably. I didn't think of that... |
|
[12:07] <Jazzva> I thought of sending clientId before message when I start testing with multiple clients |
|
[12:10] <Jazzva> I assumed that serverSocket.accept() returns a Socket and that some underlying code will take care that it sends to the right client on the other side, and not to all of them :) |
|
[12:14] <Jazzva> i'll assume it really does that. If it fails in multi-client environment, I'll start sending client ID before message :) |
|
[12:18] <gnomefreak> should i remove CVS dir before pushing or even CVS in any dir |
|
[12:21] <Jazzva> I think you should... |
|
[12:22] <Jazzva> those are just used for cvs management, not for the extension |
|
[12:22] <Jazzva> gnomefreak ^ |
|
[12:23] <gnomefreak> Jazzva: ok thanks |
|
[12:23] <gnomefreak> makes life easier |
|
[12:24] <Jazzva> np :) |
|
[12:34] <gnomefreak> shhhhhh dont tell anyone but im kind of liking doing extensions |
|
[12:35] <Jazzva> hehe :)... you have my full support |
|
[12:40] <gnomefreak> ok will work the dirty part of these in a few |
|
[12:41] <rbu> asac: hey there |
|
[12:42] <rbu> asac: so i've been trying your NM07 branch, you're pretty much syncing against upstream at this point, right? |
|
[12:42] <rbu> asac: i have had one problem in general, you probably did not stumble upon that yet |
|
[12:44] <rbu> asac: NetworkManager-0.7.0_pre/system-settings/src/org.freedesktop.NetworkManagerSystemSettings.service.in is too long of a filename, tar ignores it (at make dist) |
|
[12:47] <asac> rbu: hmm ... sounds wierd |
|
[12:47] <asac> rbu: i am synching regularly |
|
[12:47] <asac> rbu: which branch are you tracking |
|
[12:47] <asac> ? |
|
[12:47] <asac> main.eni |
|
[12:47] <asac> ? |
|
[12:47] <rbu> asac: yep |
|
[12:47] <rbu> asac: well, it's not a problem in your branch |
|
[12:47] <asac> rbu: the packages i built work |
|
[12:48] <rbu> asac: yeah, i know. you do bzr export or something? |
|
[12:48] <asac> yes. i dont want the autotools files anyway as i recreate them during package built |
|
[12:48] <rbu> asac: i'm editing configure.in to add a '_pre' at the version number, which makes the directory name longer |
|
[12:48] <asac> rbu: well. i doubt that the problem is the 4 more letters |
|
[12:49] <asac> probably there is something hardcoded somewhere which makes the tarball forget about that service file |
|
[12:49] <rbu> asac: it is! tar in dump mode only allows 99 characters in path |
|
[12:49] <asac> rbu: how do you edit configure.in? |
|
[12:50] <rbu> asac: well, edit the "AC_INIT(NetworkManager, 0.7.0", ./autogen.sh and make dist |
|
[12:51] <asac> rbu: how can tar be dumber than tar cvzf? |
|
[12:51] <asac> http://paste.ubuntu.com/38478/ |
|
[12:51] <rbu> asac: http://rafb.net/p/1azELZ79.html |
|
[12:51] <asac> that path must be much longer as it prefixes Development/ubuntu/network-manager/ ... |
|
[12:51] <asac> and it works as you can see in the paste |
|
[12:52] <rbu> asac: mind the last two lines |
|
[12:52] <gnomefreak> asac: have you heard of anyone other than Matt G being email bombed yet? |
|
[12:52] <asac> rbu: yeah |
|
[12:52] <asac> rbu: strange. looks like a problem in make dist then |
|
[12:53] <rbu> asac: yeah, it is. i wonder if i should ignore it and not change the name, or bug upstream to shorten the filename |
|
[12:54] <asac> rbu: use bzr export ;) |
|
[12:54] <asac> well ... but that doesnt add you the autotools things |
|
[12:54] <asac> not sure |
|
[12:55] <asac> i dont read anything of the 99 constraint in manpage of tar |
|
[12:56] <asac> is it automake that complains about that? maybe they check for 99 because BSD tar cannot do more? |
|
[12:58] <rbu> asac: it is tar that complains, but it is automake that tells tar to use "o" |
|
[12:59] <rbu> --old-archive ... like --format=v7; -o exhibits this behavior when creating an archive (deprecated behavior) |
|
[12:59] <rbu> hmm.. telling it to use a newer tar format works |
|
[12:59] <rbu> yay |
|
[13:00] <rbu> asac: as here http://www.cygwin.com/ml/automake/2004-11/msg00118.html |
|
[13:03] <asac> argh |
|
[13:04] <asac> what a pain |
|
[13:04] <asac> not my problem :) |
|
[13:04] <asac> rbu: i think you could just repack the "normal" make dist thing |
|
[13:04] <asac> and rename the top level dir |
|
[13:04] <asac> once upstream hits the 99 char boundary, they will probabyl think what to do |
|
[13:05] <asac> if you want, you can send an email to networkmanager-list of course |
|
[13:05] <rbu> asac: all hacks! i'll prepare that one line patch and send it upstream |
|
[13:06] <asac> yep |
|
[13:06] <asac> breave |
|
[13:06] <asac> brave ;) |
|
[13:07] <rbu> asac: why? bad experience with accepting patches? |
|
[13:08] <rbu> asac: otherwise, i'll harrass you to apply it in your branch :-P |
|
[13:09] <asac> no |
|
[13:09] <asac> go upstream |
|
[13:10] <asac> brave == appreciated ;) |
|
[13:22] <gnomefreak> Jazzva: what version is the following |
|
[13:22] <gnomefreak> # 12/03/01, ChatZilla 0.8.5, <[email protected]> |
|
[13:22] <gnomefreak> Shipped with 0.9.7. |
|
[13:23] <rbu> asac: mail is out, i'll go on testing then |
|
[13:24] <asac> good |
|
[13:24] <asac> XioNoX: managed to open plugin finder wizard? |
|
[13:25] <gnomefreak> there seems to be a 0.9.83 as well but the above came from upstream changelog |
|
[13:26] <XioNoX> yes |
|
[13:26] <XioNoX> asac |
|
[13:26] <Jazzva> gnomefreak, paste it somewhere.. |
|
[13:26] <asac> XioNoX: rock ;) |
|
[13:26] <asac> XioNoX: please commit it as an intermediate checkpoint ;) |
|
[13:26] <XioNoX> but there are a problem :( |
|
[13:26] <asac> what is it? |
|
[13:26] <XioNoX> 2problems |
|
[13:27] <XioNoX> if there are many mimetypes, the progressbar get stuck... |
|
[13:27] <asac> huh? |
|
[13:27] <asac> which progressbar? |
|
[13:27] <gnomefreak> Jazzva: ok http://pastebin.mozilla.org/519226 and 0.9.83 is mentioned at http://www.hacksrus.com/~ginda/chatzilla/ |
|
[13:27] <XioNoX> of the plugin finder |
|
[13:27] <gnomefreak> 0.9.83 isnt from CVS nor can be gotten from it |
|
[13:28] <XioNoX> secondly, it don't save the mimetypes in the tab |
|
[13:28] <XioNoX> weird, because it was working before |
|
[13:28] <gnomefreak> ah its a nightly build |
|
[13:28] <Jazzva> gnomefreak, use 0.8.5 |
|
[13:28] <gnomefreak> Jazzva: ok thanks |
|
[13:29] <Jazzva> In the previous changelog entry it said "Shipped with Mozilla 0.9.4, 0.9.5, and 0.9.6", so I suppose that's what 0.9.7 means |
|
[13:29] <Jazzva> np :) |
|
[13:29] <gnomefreak> thats what i pushed it as but just needed to make sure |
|
[13:30] <Jazzva> gnomefreak, did you download from cvs or a xpi file? |
|
[13:31] <asac> XioNoX: ok maybe the broken progressbar is because of the empty mime-type array? |
|
[13:31] <asac> (which probably is an untested special case) |
|
[13:32] <Jazzva> gnomefreak, on that site you can download chatzilla 0.9.83. maybe you downloaded from old cvs? (just a thought) |
|
[13:33] <XioNoX> maybe |
|
[13:35] <XioNoX> asac, normally there are only the mimetype in the array ? |
|
[13:37] <gnomefreak> Jazzva: it seems CVS wasnt updated |
|
[13:37] <gnomefreak> so i guess .xpi it is |
|
[13:37] <Jazzva> maybe... if it's really 0.8.5, then it's really old |
|
[13:37] <Jazzva> (and I was confused why they mention mozilla 0.9.7 :)) |
|
[13:37] <gnomefreak> me too |
|
[13:38] <asac> XioNoX: no. its an array of pluginInfo iirc |
|
[13:38] <asac> XioNoX: look in the pluginfinder wizard code |
|
[13:38] <asac> (e.g. what does it do witih the window argument) |
|
[13:38] <asac> maybe you also are missing another window argument |
|
[13:38] <asac> maybe error console spits out anything |
|
[13:38] <XioNoX> no missing window argument |
|
[13:38] <XioNoX> error console didn't work |
|
[13:39] <XioNoX> how do you see the error if there are an error in the error console ? :) |
|
[13:39] <asac> err ... cant parse that. |
|
[13:43] <XioNoX> :) |
|
[13:43] <asac> rephrase? |
|
[13:44] <XioNoX> nevermind |
|
[13:48] <asac> XioNoX: window.arguments[0].plugins[item] |
|
[13:48] <asac> thats the element that we need to set ;) |
|
[13:48] <asac> (i guess you figured that) |
|
[13:48] <XioNoX> I think I've find my error |
|
[13:49] <XioNoX> I'me doing : var pluginInfo = getPluginInfo(aEvent.target); |
|
[13:49] <XioNoX> pluginsArray[pluginInfo.mimetype] = pluginInfo; |
|
[13:49] <XioNoX> and then extracting the mymetype form the array |
|
[13:49] <XioNoX> and then putting it in another array |
|
[13:50] <asac> ok |
|
[13:50] <asac> isnt pluginsArray the array that needs to be accessible through window.arguments[0].plugins ? |
|
[13:50] <XioNoX> cool |
|
[13:50] <XioNoX> it works |
|
[13:51] <asac> ;) |
|
[13:51] <asac> yay. |
|
[13:51] <asac> commit it as a milestone :) |
|
[13:51] <XioNoX> but window.arguments[0].plugins can't be an array of array |
|
[13:51] <asac> XioNoX: after that commit, maybe you could do some code cleanup? |
|
[13:52] <XioNoX> if it is like house cleanup, i'll not like it |
|
[13:52] <asac> e.g. like using the proper case for variables (e.g. not .PluginUsed, but .pluginUsed), making indentation consistent and also removing any commented code that was added for testing? |
|
[13:52] <fta> bug 244366 |
|
[13:52] <ubottu> Launchpad bug 244366 in cairo "cairo fails to build against fontconfig 2.6.0-1ubuntu2" [Undecided,Fix released] https://launchpad.net/bugs/244366 |
|
[13:52] <asac> XioNoX: yeah. but dirty code is just ugly :( |
|
[13:52] <gnomefreak> is flock in our repos? |
|
[13:52] <fta> in my ppa only |
|
[13:52] <gnomefreak> ah that would be why |
|
[13:52] <XioNoX> asac, I agree, i'm just kidding ;) |
|
[13:53] <fta> problem ? |
|
[13:53] <gnomefreak> fta: no just working out depends |
|
[13:53] <XioNoX> asac, cleanup before or after the push ? |
|
[13:54] <asac> XioNoX: first push |
|
[13:54] <asac> XioNoX: then do a cleanup commit |
|
[13:54] <asac> test that and push ;) |
|
[13:54] <XioNoX> okay ! |
|
[13:55] <fta> asac, i proposed a branch merge 3 days ago using the lp feature. it's easy to use. https://code.edge.launchpad.net/~fta/apport/apport/+merge/758 |
|
[13:55] <asac> yep |
|
[13:56] <asac> fta: maybe ask pitti whether he got a mail. problem is that the merge request mail might not go out if the user explicitly selected mail from that branch before the feature landed |
|
[13:56] <fta> yet, it didn't get any attention |
|
[13:57] <fta> seems he's not here right now |
|
[13:57] <XioNoX> pushed |
|
[13:59] <asac> fta: hmm. pitti is usually super-responsive |
|
[13:59] <asac> (i dont know anyone who better follows up on his tasks then him) |
|
[13:59] <gnomefreak> would be nice if they included a License somewhere either on website or in package :( |
|
[14:00] <asac> fta: maybe he is on holiday ... or travelling is my guess |
|
[14:00] <asac> and over weekend doesnt really count for "getting" attention |
|
[14:01] <coolbhavi> asac, hello |
|
[14:02] <coolbhavi> asac, https://bugs.edge.launchpad.net/ubuntu/+source/diggler/+bug/254614 |
|
[14:02] <ubottu> Launchpad bug 254614 in diggler "Please merge diggler 0.9-16 (universe) from Debian unstable (main)." [Wishlist,Incomplete] |
|
[14:04] <asac> ? |
|
[14:06] <XioNoX> asac, just one thing, how can I replace the onclick='"" of the menuitem ? because even if it is gray I can clic on it |
|
[14:07] <asac> XioNoX: huh? how do you grey it? |
|
[14:07] <XioNoX> disabled="true" |
|
[14:08] <asac> XioNoX: well. i think you should us a proper command |
|
[14:08] <asac> and not onclick |
|
[14:08] <asac> XioNoX: maybe use "oncommand=..:" |
|
[14:08] <asac> that might work as well |
|
[14:08] <asac> (not 100% sure though) |
|
[14:08] <coolbhavi> asac, you told to discuss in this channel about the dependencies |
|
[14:09] <XioNoX> ok |
|
[14:17] <XioNoX> asac, important question, chat text (or image) can I put in the statusbar ? |
|
[14:18] <XioNoX> err what text |
|
[14:19] <asac> XioNoX: try the puzzle piece |
|
[14:19] <asac> (image) |
|
[14:20] <XioNoX> where it is ? |
|
[14:20] <asac> not sure ;) |
|
[14:20] <asac> XioNoX: just use something for now ... we replace it later |
|
[14:20] <XioNoX> ok |
|
[14:21] <XioNoX> np |
|
[14:21] <XioNoX> http://pastebin.mozilla.org/519258 |
|
[14:21] <XioNoX> anything to change ? |
|
[14:26] <asac> XioNoX: maybe make tabSelected a prototype function as well (for consistency) ... and use a different var name for "stuffy" :-P |
|
[14:26] <asac> otherwise that file looks quite clean |
|
[14:26] <XioNoX> ok |
|
[14:26] <asac> XioNoX: consider to write a short instruction on top of the file (e.g. whats the idea) |
|
[14:26] <asac> just two or three sentences |
|
[14:26] <asac> but not high prio |
|
[14:26] <asac> add license header please |
|
[14:26] <XioNoX> the xul ? the js ? |
|
[14:26] <asac> look at other files |
|
[14:27] <XioNoX> the commit ? |
|
[14:27] <asac> XioNoX: the file you pasted was .js, right? |
|
[14:27] <asac> XioNoX: the .xul/xml files need proper cleanup as well |
|
[14:27] <XioNoX> yes |
|
[14:27] <asac> ;) |
|
[14:27] <asac> please paste them as well |
|
[14:29] <XioNoX> ok |
|
[14:32] <gnomefreak> is anyone on irc.mozilla.org by chanec? |
|
[14:32] <gnomefreak> chance* |
|
[14:33] <asac> yes |
|
[14:33] <asac> gnomefreak: why? |
|
[14:33] <gnomefreak> asac: i need upstream contact for chatzilla |
|
[14:33] <asac> who is that? |
|
[14:33] <gnomefreak> it says "i'm" but not who |
|
[14:34] <asac> do you have his nick? |
|
[14:34] <gnomefreak> the sites dont tell me neither |
|
[14:34] <gnomefreak> asac: nope just "I'm" |
|
[14:34] <asac> isnt the name for chatzilla guy on AMO? |
|
[14:34] <asac> Gijs Kruitbosch, Robert Ginda, Samuel Sieb, James Ross |
|
[14:34] <asac> https://addons.mozilla.org/en-US/firefox/addon/16 |
|
[14:34] <gnomefreak> asac: http://pastebin.mozilla.org/519261 |
|
[14:34] <asac> are named there |
|
[14:35] <gnomefreak> asac: just as contributers |
|
[14:35] <XioNoX> http://pastebin.mozilla.org/519260 |
|
[14:35] <asac> gnomefreak: ok. go to that channel and ask ;) |
|
[14:35] <gnomefreak> list all of them as upsteam contact? |
|
[14:35] <asac> gnomefreak: if you have emails. you can also list active IRC channels as upstream project |
|
[14:35] <asac> err contact |
|
[14:36] <asac> XioNoX: i prefer to break long xml lines in multiple lines, by attribute name |
|
[14:36] <asac> e.g. |
|
[14:36] <XioNoX> ok |
|
[14:36] <asac> <test attr1="attr" |
|
[14:36] <asac> attr2="attr2 |
|
[14:36] <asac> hmm |
|
[14:36] <asac> attr2="attr2 |
|
[14:36] <asac> attr3="attr3" |
|
[14:36] <asac> attr4="attr4"> |
|
[14:36] <XioNoX> for each attribute ? |
|
[14:36] <asac> yes. |
|
[14:36] <XioNoX> or just here put the oncommand on a new line ? |
|
[14:37] <asac> especially when there are long attributes like "code" |
|
[14:37] <asac> i like a new line per-attribute |
|
[14:37] <asac> but both are ok |
|
[14:37] <asac> you can also go for the "< 80 chars" width approach |
|
[14:37] <asac> XioNoX: does the oncommand thing work? |
|
[14:38] <XioNoX> yes |
|
[14:38] <asac> good crack |
|
[14:38] <asac> how about the .xbl? |
|
[14:38] <asac> XioNoX: err .... label="aaaa" |
|
[14:38] <asac> why that? |
|
[14:39] <asac> why actually a complete new panel? |
|
[14:39] <asac> isnt an img enough? |
|
[14:39] <asac> (sorry, for my ignorance, maybe your approach is right, but please check that it is and that we do the minimal thing) |
|
[14:40] <asac> ok looks to be right |
|
[14:41] <asac> firebug and greasemonkey do it that way too |
|
[14:41] <asac> nice |
|
[14:45] <XioNoX> maybe you prefer "b" ? :D |
|
[14:45] <asac> b? |
|
[14:46] <asac> do we need a label at all? |
|
[14:46] <asac> XioNoX: ? |
|
[14:47] <XioNoX> for the moment I don't have any image |
|
[14:47] <XioNoX> so it is just to see it for the moment |
|
[14:49] <asac> XioNoX: use something ;) |
|
[14:49] <XioNoX> I need to add a licence block ? |
|
[14:49] <asac> XioNoX: yes. |
|
[14:49] <XioNoX> asac ? |
|
[14:49] <asac> XioNoX: the same license we use in the other files |
|
[14:51] <XioNoX> - The Original Code is distro-mods. |
|
[14:51] <XioNoX> - |
|
[14:51] <XioNoX> - The Initial Developer of the Original Code is |
|
[14:51] <XioNoX> - Canonical Ltd. |
|
[14:51] <XioNoX> - Portions created by the Initial Developer are Copyright (C) 2007 |
|
[14:51] <XioNoX> - the Initial Developer. All Rights Reserved. |
|
[14:54] <XioNoX> http://pastebin.mozilla.org/519264 fot he .js file |
|
[14:54] <XioNoX> what should i write on it ? |
|
[14:56] <asac> XioNoX: look at other files we created as new |
|
[14:56] <asac> replace me with you there |
|
[14:56] <asac> the file you are looking at was copied from mozilla source ... thus the other contributor |
|
[15:00] <XioNoX> I remove all the : * The Original Code is Plugin Finder Service. |
|
[15:00] <XioNoX> * |
|
[15:00] <XioNoX> * The Initial Developer of the Original Code is |
|
[15:00] <XioNoX> * IBM Corporation. |
|
[15:00] <XioNoX> * Portions created by the IBM Corporation are Copyright (C) 2004 |
|
[15:00] <XioNoX> * IBM Corporation. All Rights Reserved. |
|
[15:00] <XioNoX> form the JS ? |
|
[15:01] <asac> XioNoX: he? |
|
[15:01] <asac> no |
|
[15:01] <asac> look at other files that were not copied from upstream sources |
|
[15:01] <asac> content/overlay.js |
|
[15:01] <gnomefreak> Jazzva: shoudl i be using "firefox-chatzilla"? im thinking no since it supports sonbird, flock, firefox, seamonkey |
|
[15:02] <XioNoX> I remplace it by that : * The Original Code is distro-mods. |
|
[15:02] <XioNoX> * |
|
[15:02] <XioNoX> * The Initial Developer of the Original Code is |
|
[15:02] <XioNoX> * Canonical Ltd. |
|
[15:02] <XioNoX> * Portions created by the Initial Developer are Copyright (C) 2007 |
|
[15:02] <XioNoX> * the Initial Developer. All Rights Reserved. ? |
|
[15:03] <asac> yes ... but do s/distro-mods/ubufox/ :) |
|
[15:03] <asac> and the year |
|
[15:03] <asac> you could also change the initial developer, but since i worked quite a bit on that as well, maybe Canonical Ltd. is ok. your choice |
|
[15:04] <XioNoX> I'll let it :) |
|
[15:04] <asac> XioNoX: do the same for the .xml and xul file |
|
[15:07] <XioNoX> ok, done |
|
[15:07] <asac> good |
|
[15:07] <asac> pushed? |
|
[15:07] <XioNoX> just about the "aaaa", what should i do ? |
|
[15:07] <asac> use some picture instead |
|
[15:08] <XioNoX> ok |
|
[15:09] <asac> XioNoX: use: |
|
[15:10] <XioNoX> chrome://mozapps/skin/plugins/pluginGeneric.png |
|
[15:10] <asac> XioNoX: chrome://mozapps/skin/plugins/pluginGeneric-16.png |
|
[15:10] <asac> that one |
|
[15:10] <asac> yes |
|
[15:11] <asac> good XioNoX ;) |
|
[15:11] <asac> XioNoX: i have another side-task (fixing bugs on other features you already implemented) :) |
|
[15:12] <asac> XioNoX: but since you are quite expert now ;) ... it shouldnt be hard |
|
[15:12] <rbu> asac: oh, and the most recent docs/libnm-glib changes broke make dist completely |
|
[15:12] <asac> XioNoX: the restart notification doesnt pop-up in _all_ tabs ;) |
|
[15:12] <asac> XioNoX: i think you know how to do that properly now? |
|
[15:12] <XioNoX> i'll figure this out |
|
[15:12] <asac> rbu: you mean the main.eni push i did today? |
|
[15:12] <rbu> asac: yep |
|
[15:12] <XioNoX> but first I put the icon in the statusbar |
|
[15:13] <asac> XioNoX: i think you can do that when you feel blocked on the other feature |
|
[15:13] <asac> (the alternative plugin feature) |
|
[15:13] <asac> should be easy food ;) |
|
[15:13] <asac> yep ... do that ;) |
|
[15:14] <gnomefreak> asac: you asked me to merge my firegpg branch with ~dev branch and cant due to a new package. what would you like me to do with bug 227945? is this something you will do if not what should i do to continue with it |
|
[15:14] <ubottu> Launchpad bug 227945 in firegpg "[needs packaging] Please package FireGPG extension for Firefox " [Wishlist,Triaged] https://launchpad.net/bugs/227945 |
|
[15:14] <asac> gnomefreak: you think all is lost for firefox-3.0 bug count? |
|
[15:14] <gnomefreak> asac: what do you mean? |
|
[15:15] <asac> gnomefreak: how many open bugs do we have against firefox-3.0? |
|
[15:15] <gnomefreak> asac: oh hell i dont know i havent checked email in maybe 4-5 days |
|
[15:15] <asac> gnomefreak: so the firegpg branches are ready? |
|
[15:15] <gnomefreak> asac: yep |
|
[15:15] <gnomefreak> builds and installs and works |
|
[15:16] <gnomefreak> when i get done with chatzilla today/tomorrow i will look at bug count |
|
[15:16] <asac> thanks |
|
[15:16] <gnomefreak> np |
|
[15:16] <gnomefreak> take me forever to do things is becaue wrist cant handle alot atm |
|
[15:17] <asac> sure |
|
[15:18] <asac> brave still |
|
[15:19] <XioNoX> asac, done |
|
[15:19] <asac> XioNoX: pushed? |
|
[15:19] <XioNoX> yes |
|
[15:19] <asac> cool |
|
[15:19] <asac> ill pull that in a minute |
|
[15:19] <XioNoX> pull ? |
|
[15:19] <asac> which revision? |
|
[15:19] <XioNoX> 100 |
|
[15:19] <asac> XioNoX: bzr pull (update branch) |
|
[15:19] <XioNoX> ok |
|
[15:20] <asac> got it |
|
[15:20] <asac> lets see |
|
[15:20] <XioNoX> I should get the notificationbar stuff from bazaar, or it haven't changed since this time ? |
|
[15:23] <asac> XioNoX: not sure :) ... its your branch. i cannot write to it ;) |
|
[15:23] <asac> so it probably hasnt changed |
|
[15:23] <asac> (maybe you forget to push though ;)) |
|
[15:23] <asac> XioNoX: the alternate thing works greta |
|
[15:23] <asac> rock |
|
[15:23] <XioNoX> cool |
|
[15:24] <asac> XioNoX: one comment: "Get alternatives" -> "Manage Plugins Used ..." |
|
[15:24] <XioNoX> ? |
|
[15:24] <asac> XioNoX: the menu entry |
|
[15:24] <asac> ;) |
|
[15:24] <asac> XioNoX: and maybe put that to the View menu |
|
[15:25] <XioNoX> I keep the 3 dots ? |
|
[15:26] <asac> XioNoX: for now ... i just asked our usability guy for input |
|
[15:26] <asac> XioNoX: so maybe wait a bit until i have input from him |
|
[15:27] <XioNoX> ok, no problem |
|
[15:31] <rbu> asac: seems i messed up. it works, but you have to build the whole baby before running make dist. well... |
|
[15:32] <asac> rbu: ouch |
|
[15:33] <asac> rbu: just sh autogen.sh isnt enough? |
|
[15:33] <rbu> asac: the libnm-glib documentation must be built, and for some obscure reason, that needs libnm-glib compiled |
|
[15:34] <rbu> asac: is your branch an exact copy of NM upstream right now, or do you carry any patches in there? |
|
[15:35] <asac> rbu: i carry the "eni/ifupdown" system-settings changes |
|
[15:35] <asac> thats all |
|
[15:35] <asac> you can do a simple bzr diff |
|
[15:37] <rbu> asac: i'm not fluent in bzr yet, i only got pull to work :-P |
|
[15:39] <fta> leaving for sports, wish me no rain |
|
[15:40] <asac> fta: enjoy |
|
[15:45] <Jazzva> gnomefreak, sorry... I was off for a while. Sure, go with chatzilla. I think that we have set that up before to not use "mozilla-" or "firefox-" and similar in extensions' names. |
|
[15:47] <gnomefreak> Jazzva: thats was i thought thanks |
|
[15:47] <Jazzva> :) |
|
[15:47] <gnomefreak> be back |
|
[15:53] <asac> rbu: bzr diff -r2752.1.686 |
|
[15:54] <asac> rbu: (if you have the latest main.eni) |
|
[15:58] <rbu> ahh, now i actually get how those log messages are structured |
|
[15:58] <asac> rbu: yep. the upstream branch is still in the mani.eni branc |
|
[15:58] <asac> just with a certain revision ;) |
|
[15:58] <asac> you can even extract the unmodified upstream branch by bzr branch -r2752.1.686 path/to/main.eni |
|
[16:02] <rbu> asac: is "network-manager.07.eni" your local branch nick? |
|
[16:03] <asac> rbu: yes |
|
[16:03] <asac> its == main.eni |
|
[16:11] * asac break |
|
[16:22] <XioNoX> asac, apperently it is 1 notificationbox per tab, and not for the whole firefox. People recomand me to use the same box than the one who notify that a download is over |
|
[16:32] <asac> XioNoX: right. |
|
[16:32] <asac> XioNoX: thus, you need to iterate through all windows + all tabs |
|
[16:32] <asac> XioNoX: and display the notification everywhere |
|
[16:32] <asac> ;) |
|
[16:32] <asac> XioNoX: err, i dont want to use a dialog (e.g. download is over) |
|
[16:32] <asac> cant remember how the download thing looks like though |
|
[16:33] <XioNoX> http://xulfr.org/wiki/RessourcesLibs/Alerts |
|
[16:33] <asac> XioNoX: no. thats a temporary notification |
|
[16:33] <asac> XioNoX: we want something where the user can click on |
|
[16:33] <asac> to do the actual restart |
|
[16:34] <XioNoX> ok |
|
[16:34] <asac> i think displaying the current notificationbox is the right thing to do ... we just have to do it for all tabs |
|
[16:34] <asac> shouldnt be that hard |
|
[16:34] <XioNoX> all the gurus from xulfr sayd that it is not possible or very difficult :( |
|
[16:35] <asac> XioNoX: hah ... that should make it even more tempting to show that they are wrong :) |
|
[16:35] <asac> XioNoX: you should be able to iterate through all tabs |
|
[16:35] <XioNoX> or maybe create an overlay |
|
[16:36] <XioNoX> and isplaying over the tabs |
|
[16:36] <asac> XioNoX: that would be another alternative ... but i'd suggest that you try to iterate through all tabs and display a notification box everywhere there |
|
[16:37] <XioNoX> how ? do you have an idea ? |
|
[16:38] <asac> XioNoX: well ... you already know how to access the selectedtab right? |
|
[16:38] <asac> there should be an array field or something with all tabds |
|
[16:38] <asac> then get the browser from each tab and get the notificationbox from there ... that should make it appear everywhere |
|
[16:38] <asac> (i hope |
|
[16:38] <asac> ) |
|
[16:38] <XioNoX> http://developer.mozilla.org/en/docs/Code_snippets:Tabbed_browse |
|
[16:39] <XioNoX> http://developer.mozilla.org/en/docs/Code_snippets:Tabbed_browser |
|
[16:39] <asac> http://developer.mozilla.org/en/docs/XUL:tabbrowser |
|
[16:39] <XioNoX> I'll read again this page |
|
[16:39] <asac> thats the api of tabbrowser |
|
[16:39] <asac> (api is always more complete than examples) |
|
[16:39] <asac> XioNoX: it has a nodelist: "browsers" |
|
[16:39] <asac> investigate in that direction |
|
[16:40] <sebner> asac: so, checked wmnetselector? |
|
[16:40] <asac> sebner: i looked at it, yes. |
|
[16:40] <asac> sebner: give me bug id again :) |
|
[16:40] <sebner> asac: well I just asked if I can edit the manpage directly ^^ |
|
[16:41] <asac> sebner: ah. if there is no patchsystem, then yes. just remember to accribically document that in changelog |
|
[16:41] <asac> e.g. name the file touche, why it was touched and how it was touched |
|
[16:41] <asac> its more important to properly document things in changelog if there is no patchsystem |
|
[16:41] <sebner> asac: sure! thanks :) (anyway we should remove it from the archive :P) |
|
[16:42] <asac> adding a patchsystem will only cause merge pain in future |
|
[16:42] <asac> sebner: why .... doesnt it work anymore? |
|
[16:43] <sebner> asac: 2001 is untrue :P |
|
[16:44] <asac> ehe |
|
[16:44] <asac> maybe it just means that its stable ;) |
|
[16:44] <asac> aka mature |
|
[16:46] <sebner> wb asac |
|
[16:46] <sebner> stable is untrue :P |
|
[16:46] <asac> hehe ;) |
|
[16:46] <asac> sebner: let me know when you have finished the change ;) |
|
[16:46] <asac> sebner: ah ... when you change something that makes it unusable for iceweasel/iceape, better remove them from suggests |
|
[16:46] <asac> (i think i remember that this was one of these cases here) |
|
[16:47] <rbu> asac: dan accepted the tar/automake patch |
|
[16:47] <asac> rbu: jup. just saw that ;) |
|
[16:47] <asac> rbu: good |
|
[16:47] <rbu> asac: you actually read all on that list? |
|
[16:48] <asac> rbu: yes. |
|
[16:48] <asac> it gets directly to my inbox even ;) |
|
[16:48] <asac> (low traffic) |
|
[16:48] <rbu> asac: bad filtering |
|
[16:48] <asac> why ... inbox is only place i know that i will see ;) |
|
[16:48] <asac> everything is just "when I have time" |
|
[16:48] <rbu> asac: are we talking commit list or the networkmanager-list ? |
|
[16:48] <bdrung> asac: htmlvalidator is platform depending firefox plugin (needs c and c++ libs). i have split the binary package into one platform depending and one platform independ. does xpi.mk support that? |
|
[16:49] <asac> which becomes rare everyday |
|
[16:49] <asac> bdrung: it supports that: the only requirement is that the BUILD_COMMAND produces and .xpi |
|
[16:49] <asac> so you can couple a build system + xpi.mk |
|
[16:49] <asac> of course only if you use the upstream sources |
|
[16:49] <asac> (which you did) |
|
[16:50] <asac> only think i'd like to see is having this in a bzr branch |
|
[16:50] <asac> with .upstream being the sources |
|
[16:51] <asac> bdrung: if you commit to work on this, we can also upload the extension as is ... however, that doesnt count as long-term scalable, because only extensions packaged in bzr will be covered by the mozillateam large-scale maintenance approach |
|
[16:52] <bdrung> asac: i will upload the sources in a bzr branch after the upstream author decided which license he want to use |
|
[16:53] <asac> bdrung: huh? |
|
[16:53] <asac> bdrung: so we dont have a definite license atm? |
|
[16:53] <asac> that certainly blocks any upload to ubuntu |
|
[16:53] <bdrung> yes |
|
[16:54] <asac> bdrung: ok. please state that in the htmlvalidator bug ... right on top |
|
[16:54] <asac> bdrung: did you get any feedback from upstream yet? |
|
[16:54] <bdrung> i am in contact with the author and hopefully we have the license at the end of the week |
|
[16:54] <asac> bdrung: cool. what license is he thinking off? |
|
[16:55] <asac> bdrung: if oyu are unsure if its ok, feel free to CC me on mail exchange |
|
[16:55] <bdrung> asac: should i mail you the mails? |
|
[16:56] <asac> bdrung: nope ... just give me a summary |
|
[16:56] <asac> ;) |
|
[16:56] <asac> of course forwarding those mails woulndt hurt |
|
[16:56] <bdrung> asac: he wrote: "In short, I would like to give access to the code, free usage (of it), ccess to the code, but do not allow any fork of the code (I wrote) without any agreement first." |
|
[16:57] <asac> bdrung: thats non-free and not suitable for ubuntu |
|
[16:57] <bdrung> asac: i wrote back that all free license permits forking and pointed him to the dfsg |
|
[16:57] <asac> bdrung: maybe forwrad the mails |
|
[16:57] <asac> bdrung: yep |
|
[17:01] <XioNoX> asac, I'm trying this : http://developer.mozilla.org/en/docs/Code_snippets:Tabbed_browser#Enumerating_tabs |
|
[17:02] <XioNoX> for the moment I can have as many notification as opend tab |
|
[17:02] <XioNoX> but on the same tab :D |
|
[17:02] <asac> XioNoX: how do you display the notification? |
|
[17:02] <asac> XioNoX: maybe post code ;) |
|
[17:02] <XioNoX> notificationBox.appendNotification(restartNotificationLabel, 'notification-restart',"", notificationBox.PRIORITY_WARNING_LOW, buttons); |
|
[17:03] <asac> how do you get notificationBox |
|
[17:03] <asac> ? |
|
[17:04] <XioNoX> http://pastebin.mozilla.org/519323 |
|
[17:04] <XioNoX> I think I have something to do with var notificationBox = gBrowser.getNotificationBox(); |
|
[17:04] <XioNoX> and the "b" of the loop |
|
[17:05] <asac> XioNoX: yes. obviuosly you will use the same notificationbOX right now |
|
[17:05] <asac> try to get thatfrom the individual browser |
|
[17:05] <asac> e.g. b |
|
[17:05] <asac> and rename that variable |
|
[17:06] <asac> one letter variables are more evil than assembler |
|
[17:06] <asac> unless the loop is really tiny ;) |
|
[17:06] <XioNoX> i've done a little bit of assembler :) |
|
[17:06] <XioNoX> I go back home |
|
[17:07] <XioNoX> i'll check this from there |
|
[17:07] <XioNoX> c u |
|
[17:07] <asac> XioNoX: cu |
|
[17:07] <asac> save trip back |
|
[17:09] <sebner> asac: what do you mean with "unusable" ? I just added the 2 thinks to suggests and I'll edit the manpage |
|
[17:10] <bdrung> asac: mail forwarded to you |
|
[17:17] <asac> sebner: sure. just though the package wouldnt work out of the box with iceweasel anymore |
|
[17:17] <asac> if it does its ok to keep it in suggests |
|
[17:24] <sebner> asac: kk, thanks for the help =) |
|
[17:29] <asac> welcome |
|
[17:56] <XioNoX> back |
|
[18:02] <asac> hi |
|
[18:03] <asac> :) |
|
[18:08] <XioNoX> asac, in your mind I should put allmost everything of function showRestartNotification() in the loop ? |
|
[18:10] <asac> XioNoX: sorry. i cant remember how showRestartNotification looks like ... you mean the function in the current branch? |
|
[18:11] <XioNoX> yes |
|
[18:11] <XioNoX> I've send you a pastebin |
|
[18:12] <asac> ok |
|
[18:12] <asac> think igot it |
|
[18:12] <XioNoX> and this loop : http://developer.mozilla.org/en/docs/Code_snippets:Tabbed_browser#Enumerating_tabs |
|
[18:12] <asac> XioNoX: the string bundle things can stay where they are |
|
[18:12] <XioNoX> ans what will happen if the user close all his tab an open new one ? |
|
[18:12] <asac> XioNoX: the rest probably needs to be reshuffeld to exist within the look |
|
[18:12] <XioNoX> I need to had a "load" event |
|
[18:12] <XioNoX> no ? |
|
[18:13] <asac> using the browser of the tab as the base for everything |
|
[18:13] <asac> no .. i dont think so |
|
[18:13] <asac> lets look at that once you have fixed the multi-tab case |
|
[18:15] <XioNoX> ok |
|
[18:16] <sebner> asac: bug #258540 :) |
|
[18:16] <ubottu> Launchpad bug 258540 in wmnetselect "Merge wmnetselect 0.85-6 from Debian(Unstable)" [Undecided,Confirmed] https://launchpad.net/bugs/258540 |
|
[18:19] <asac> sebner: uploaded |
|
[18:19] <XioNoX> asac : http://pastebin.mozilla.org/519365 |
|
[18:19] <sebner> asac: ah cool, thx :) |
|
[18:20] <asac> XioNoX: look good ... if it works, please fix the indentation |
|
[18:21] <asac> XioNoX: ... _and_ remove commented code :) |
|
[18:21] <asac> we use bzr to keep the original code ;) |
|
[18:21] <XioNoX> don't work |
|
[18:21] <asac> what happens=? |
|
[18:22] <XioNoX> nothing |
|
[18:22] <XioNoX> and no error log |
|
[18:23] <asac> XioNoX: most likely a not catched exception? |
|
[18:23] <asac> browser.length -> probably doesnt work |
|
[18:23] <asac> hmm ... it should |
|
[18:24] <asac> XioNoX: try to debug it ;) |
|
[18:25] <asac> XioNoX: do oyu have javascript.options.strict and javascript.options.showInConsole enabled? |
|
[18:25] <XioNoX> the problem come from : var notificationBox = gBrowser.getNotificationBox(); |
|
[18:25] <asac> in about:config |
|
[18:25] <XioNoX> i've try to put var notificationBox = b.getNotificationBox(); |
|
[18:25] <asac> you mean b.getNotificationBox() ? |
|
[18:25] <XioNoX> where b = gBrowser.getBrowserAtIndex(i); |
|
[18:25] <asac> XioNoX: is b.getNotificationBox defined at all (try to alert that) |
|
[18:27] <XioNoX> Erreur : b.getNotificationBox is not a function |
|
[18:28] <asac> XioNoX: see ;) |
|
[18:28] <XioNoX> what can i doo ? |
|
[18:29] <asac> XioNoX: what you can try is to step up in the dom hierarchy (through .parentNode) until you reach an element with the name "notificationbox" |
|
[18:29] <asac> that should be your notificationBox |
|
[18:31] <asac> XioNoX: ok getNotificationBox is a function defined in tabbrowser.xml |
|
[18:31] <XioNoX> ok |
|
[18:32] <asac> XioNoX: so use the tabbrowser.getNotificatoinBox(b) |
|
[18:32] <asac> XioNoX: try that please |
|
[18:32] <asac> XioNoX: if you look at the implementation in tabbrowser.xml you will see why it works |
|
[18:33] <XioNoX> Erreur : tabbrowser is not defined |
|
[18:34] <asac> XioNoX: well. you need to use the right variable ;) |
|
[18:34] <asac> i just outlined how it should work ;) |
|
[18:34] <XioNoX> what do you call tabbrowser ? |
|
[18:34] <XioNoX> gBrowser.browsers? |
|
[18:35] <asac> XioNoX: you will find out ... you already used tabbrowser before |
|
[18:35] <asac> and with some thinking you will remember which variable as that function implemented ;) |
|
[18:38] <XioNoX> neither gBrowser of window.gBrowser works |
|
[18:40] <asac> XioNoX: gBrowser has a getNotificationBox function right? |
|
[18:41] <asac> check that with alert |
|
[18:43] <XioNoX> hahahaha |
|
[18:44] <XioNoX> hum no |
|
[18:44] <XioNoX> it was'nt funny |
|
[18:44] <XioNoX> j've write : |
|
[18:44] <XioNoX> getNotificatoinBox |
|
[18:44] <XioNoX> my copy/past suck |
|
[18:44] <XioNoX> :D |
|
[18:44] <asac> XioNoX: :) |
|
[18:44] <XioNoX> it works |
|
[18:44] <asac> XioNoX: try to understand what you are doing ;) |
|
[18:45] <asac> typing is one way :-D |
|
[18:45] <XioNoX> i do |
|
[18:45] <asac> never be lazy ;) |
|
[18:45] <asac> XioNoX: sure ... i know |
|
[18:45] <asac> XioNoX: i just wanted to nag you |
|
[18:45] <XioNoX> i haven't type it |
|
[18:45] <XioNoX> it is the gnome copy/past who switch chars :o |
|
[18:46] <XioNoX> now, if we open a new tab, it don't have the notification bar |
|
[18:47] <asac> XioNoX: you mean if you open a new tab _after_ the notification was displayed? |
|
[18:47] <XioNoX> yes |
|
[18:47] <asac> XioNoX: I'd think that the timeout still kicks in |
|
[18:47] <asac> XioNoX: so the loop should catch that case |
|
[18:47] <asac> e.g. if no restart-notification is added it will add that once the next time out happens |
|
[18:48] <asac> if that doesnt happen its a bug in our code most likely |
|
[18:50] <XioNoX> I have to do a new sudo touch /var/lib/update-notifier/user.d/firefox-3.0-restart-required |
|
[18:50] <asac> XioNoX: why is that the case? |
|
[18:50] <XioNoX> i don't know :D |
|
[18:50] <asac> do you understand it code wise? |
|
[18:50] <asac> try to figure that |
|
[18:51] <asac> XioNoX: maybe your timeout only runs once? |
|
[18:51] <asac> well. |
|
[18:51] <XioNoX> no it is a setInterval("checkUpdate()", 10000); |
|
[18:51] <asac> XioNoX: right. but why doenst checkUpdate kick in? |
|
[18:52] <XioNoX> that is the question |
|
[18:52] <asac> it should _always_ kick in when the profile timestamp is lower than the notifier one |
|
[18:55] <asac> XioNoX: try to save the "intervalID" to a global variable |
|
[18:55] <asac> e.g. intervalID = setInterval("checkUpdate()", 10000); |
|
[18:55] <XioNoX> I don't know why but now the timestamp of profile dir seem to update |
|
[18:55] <asac> maybe it gets garbage collected |
|
[18:56] <XioNoX> maybe a log thing |
|
[18:57] <XioNoX> because in a 10 second period, sometime it update, sometime not |
|
[18:57] <asac> XioNoX: ? |
|
[18:58] <asac> XioNoX: try to save the intervalID to a global variable please |
|
[18:58] <asac> XioNoX: and if the intervalID is set, then dont setInterval |
|
[18:58] <XioNoX> I don't understand why |
|
[18:58] <asac> (in this way we will prevent that this thing runs concurrently (which might cause confusion) |
|
[18:58] <XioNoX> the probleme come from : checkUpdate() |
|
[18:58] <asac> XioNoX: http://developer.mozilla.org/en/docs/DOM:window.setInterval |
|
[18:59] <asac> XioNoX: also ... why use "checkUpdate()" ... instead of just window.setInterval(checkUpdate, 1000); |
|
[18:59] <asac> ? |
|
[18:59] <asac> http://developer.mozilla.org/en/docs/Adding_preferences_to_an_extension |
|
[19:00] <XioNoX> because it was working with () |
|
[19:00] <asac> XioNoX: true ... that shouldnt matter |
|
[19:00] <asac> just remember the intervalID globally |
|
[19:00] <asac> and dont setup a new interval when that is set |
|
[19:01] <XioNoX> ? |
|
[19:01] <asac> not sure what other words i can choose |
|
[19:01] <asac> global variables in javascript should be something you should know ... otherwise look it up ;) |
|
[19:02] <XioNoX> So i just put : function scheduleCheckForUpdate() |
|
[19:02] <XioNoX> { |
|
[19:02] <XioNoX> intervalID = setInterval("checkUpdate()", 10000); |
|
[19:02] <XioNoX> } |
|
[19:02] <XioNoX> ? |
|
[19:02] <XioNoX> that still work the same way |
|
[19:03] <XioNoX> but the profile directory timestamp keep updating |
|
[19:03] <asac> XioNoX: the profile directory timestamp keeps updating? |
|
[19:03] <asac> hmm |
|
[19:04] <asac> XioNoX: the idea for the global variable thing was likE: |
|
[19:04] <asac> http://paste.ubuntu.com/38556/ |
|
[19:06] <XioNoX> can the catch(e) { |
|
[19:06] <XioNoX> Components.utils.reportError(e); update the timestamp ? |
|
[19:07] <asac> XioNoX: no ... the profile directory timestamp appears to be really updated regularly |
|
[19:07] <asac> XioNoX: lets use [ProfD]/lock file |
|
[19:07] <asac> as a time stamp base |
|
[19:07] <asac> that isnt updated from what i can tell |
|
[19:07] <asac> or is it? |
|
[19:08] <asac> XioNoX: give it a try please |
|
[19:08] <XioNoX> touch [ProfD]/lock |
|
[19:08] <asac> XioNoX: he? |
|
[19:09] <asac> please try to read the file url |
|
[19:09] <XioNoX> and then use it as profile dir timestamp ? |
|
[19:09] <asac> XioNoX: no |
|
[19:09] <asac> use the lock file in the profile dir |
|
[19:09] <asac> as the dateProDir |
|
[19:09] <XioNoX> ho he already exist ? |
|
[19:09] <asac> (of course rename the variable accoridngly) |
|
[19:10] <asac> dont touch it ... just use it as "startupTime" ... so we can check whether firefox was restarted before update-notifier existed |
|
[19:17] <XioNoX> there are no lock file |
|
[19:18] <XioNoX> in my profD |
|
[19:18] <asac> huh? |
|
[19:18] <asac> XioNoX: $ ls -l /home/asac/.mozilla/firefox/8bil8cfx.default/lock |
|
[19:18] <asac> lrwxrwxrwx 1 asac asac 16 2008-08-18 20:06 /home/asac/.mozilla/firefox/8bil8cfx.default/lock -> 127.0.1.1:+15555 |
|
[19:19] <XioNoX> hum |
|
[19:19] <XioNoX> checking the bad profile |
|
[19:19] <XioNoX> ... |
|
[19:20] <XioNoX> after the proDir.append("lock"); I get a [xpconnect wrapped nsIFile] |
|
[19:21] <XioNoX> but the var dateProDir = proDir.lastModifiedTime; give me an error |
|
[19:22] <asac> XioNoX: what error? |
|
[19:23] <XioNoX> Erreur : uncaught exception: [Exception... "Component returned failure code: 0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST) [nsIFile.lastModifiedTime]" nsresult: "0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST)" location: "JS frame :: chrome://ubufox/content/updateRestart.js :: checkUpdate :: line 44" data: no] |
|
[19:23] <asac> XioNoX: yeah. most likely because its a socket link ;) |
|
[19:24] <asac> XioNoX: ok ... plan B :) |
|
[19:24] <asac> XioNoX: use localstore.rdf ;) |
|
[19:24] <XioNoX> socket link ? |
|
[19:24] <XioNoX> ? |
|
[19:24] <XioNoX> you never stop working ? |
|
[19:24] <asac> hehe |
|
[19:24] <asac> well ... not today ;) |
|
[19:25] <asac> i want to upload a new NM ;) ... and since you are making progress i thought i might make sense to stay here ;) |
|
[19:26] <XioNoX> NM ? |
|
[19:26] <asac> network-manager ;) |
|
[19:26] <XioNoX> What new in this one ? |
|
[19:26] <sebner> asac: do you know when the real release is comming out? |
|
[19:26] <asac> lots of fixes |
|
[19:27] <asac> sebner: no ... we stabilize on our own |
|
[19:27] <asac> ;) |
|
[19:27] <asac> i currently work as if they never release ;) |
|
[19:27] <XioNoX> fun |
|
[19:27] <sebner> asac: thumbs up :) |
|
[19:28] <XioNoX> asac, I will stop for today, (unless you (really) want to continue) |
|
[19:30] <asac> XioNoX: push what you have so far. we can do the fine tuning and the cleanups tomorrow ;) |
|
[19:30] <XioNoX> ok, good for me |
|
[19:31] <asac> hehe |
|
[19:33] <XioNoX> bzr push lp:~xionox/ubufox/restart.notifier |
|
[19:33] <XioNoX> bzr: ERROR: Cannot lock LockDir(http://bazaar.launchpad.net/%7Exionox/ubufox/restart.notifier/.bzr/repository/lock): Transport operation not possible: http does not support mkdir() |
|
[19:34] <XioNoX> Pushed up to revision 105 |
|
[19:37] <asac> thanks |
|
[19:37] <asac> XioNoX: urgh |
|
[19:38] <asac> you need tosetup your .bazaar.conf properly |
|
[19:38] <XioNoX> ? |
|
[19:38] <XioNoX> what ? |
|
[19:38] <asac> $ cat /home/asac/.bazaar/bazaar.conf |
|
[19:38] <asac> [DEFAULT] |
|
[19:38] <asac> email = Alexander Sack <[email protected]> |
|
[19:38] <asac> build-dir = /tmp/build |
|
[19:38] <asac> launchpad_username = asac |
|
[19:38] <asac> launchpad_username |
|
[19:38] <asac> err ... did the push work? |
|
[19:38] <XioNoX> [DEFAULT] |
|
[19:38] <XioNoX> email = XioNoX <[email protected]> |
|
[19:39] <XioNoX> yes, i've just use the long url |
|
[19:39] <XioNoX> wherease the lp: one |
|
[19:42] <asac> XioNoX: works great with localstore.rdf (for me) |
|
[19:42] <asac> not sure if htere is something not working |
|
[19:43] <asac> but i have two windows with lots of tabs and notification is displayed everywhere |
|
[19:43] <asac> when opening a new tab it takes a bit, and then notificaiton appears as well |
|
[19:43] <asac> well done! |
|
[19:43] <asac> lets see if the localstore.rdf doesnt reappear |
|
[19:43] <XioNoX> I don't understand |
|
[19:43] <XioNoX> It work or not ? |
|
[19:44] <asac> it works |
|
[19:44] <asac> with localstore.rdf |
|
[19:45] <asac> XioNoX: please apply this patch for me: |
|
[19:45] <asac> http://paste.ubuntu.com/38567/ |
|
[19:45] <asac> and push ;) |
|
[19:45] <asac> then we are almost done |
|
[19:49] <XioNoX> Pushed up to revision 106. |
|
[19:52] <asac> thx |
|
[19:52] <asac> XioNoX: ok i am off for today. thanks a lot |
|
[19:53] <asac> the restart feature appears to be done ;) |
|
[19:53] <XioNoX> thanks you ! |
|
[19:53] <asac> (maybe code cleanup, but i havent looked) |
|
[19:53] <XioNoX> licences header |
|
[19:53] <asac> XioNoX: yes, please |
|
[19:54] <XioNoX> tomorrow morning |
|
[19:54] <asac> yup. |
|
[19:54] <XioNoX> what is planed for tomorrow ? |
|
[19:54] <asac> XioNoX: i also see that proDir.append("localstore.rdf"); is indented in the wrong fashion |
|
[19:54] <XioNoX> do you have news from mconor ? |
|
[19:54] <XioNoX> ok |
|
[19:54] <asac> XioNoX: we are trying something great ;) |
|
[19:55] <asac> nope |
|
[19:55] <XioNoX> ok |
|
[19:55] <XioNoX> do you know people who manage ubuntu's server ? |
|
[19:56] <asac> XioNoX: which server? |
|
[19:57] <asac> or the ubuntu-server distro? |
|
[19:57] <asac> i should know them ;) |
|
[19:57] <XioNoX> no, people who manage the canonical's servers |
|
[19:57] <asac> whats the problem? |
|
[19:58] <XioNoX> Looking for my next internship :D |
|
[19:58] <XioNoX> for 2 months in may/june |
|
[19:58] <asac> XioNoX: you want an admin internship? |
|
[19:58] <XioNoX> In networking/ administration |
|
[19:58] <XioNoX> I'm doing a network school |
|
[19:59] <XioNoX> and I like netwok |
|
[19:59] <asac> XioNoX: work on network-manager ;) |
|
[19:59] <asac> hehe |
|
[19:59] <asac> ill ask if we do something like internship at all. |
|
[19:59] <XioNoX> ok |
|
[19:59] <XioNoX> so I'm looking for contact to help me to find a good internship |
|
[20:00] <asac> we are working in a highly distributed environment, so in lots of areas a classical internship isnt really possible |
|
[20:00] <XioNoX> but canonnical have an office |
|
[20:00] <asac> they have ... thats why i have to ask ;) |
|
[20:00] <XioNoX> and there are at least a team who manage serversand network |
|
[20:00] <asac> there is ... yeah. |
|
[20:01] <XioNoX> and mozilla put a high level |
|
[20:01] <XioNoX> now i'm interesting only by company who do opensource :) |
|
[20:01] <asac> for network things that shouldnt really matter |
|
[20:01] <XioNoX> and abroad :D |
|
[20:01] <asac> e.g. you might need a company that uses opensource for networking |
|
[20:02] <XioNoX> all proposition are welcome |
|
[20:02] <XioNoX> :) |
|
[20:02] <asac> sure ... ill ask if we do something like that. not sure if the requirements would be really lower though. |
|
[20:02] <XioNoX> not sure if the requirements would be really lower though.? |
|
[20:03] <asac> lower than with mozilla |
|
[20:03] <XioNoX> not requirement, by high level, I mean very good conditions, schedule, interest, etc... |
|
[20:04] <XioNoX> But I'm a lot better in networking than programming :D |
|
[20:04] <asac> ah. |
|
[20:04] <asac> XioNoX: maybe more experienced ... but better ... hard to measure that ;) |
|
[20:05] <XioNoX> yeah, sure |
|
[20:05] <XioNoX> :) |
|
[20:05] <XioNoX> I can send my resume if needed |
|
[20:07] <XioNoX> or if you know people in such company :) |
|
[20:12] <XioNoX> asac ? |
|
[20:13] <asac> heh? |
|
[20:13] <asac> all fine. ill ask ... more i cant do |
|
[20:13] <asac> but not today ;) |
|
[20:14] <XioNoX> it is'nt urgent |
|
[20:14] <XioNoX> but thanks ;) |
|
[20:14] <asac> yeah. thats what i figured ;) |
|
[20:15] <XioNoX> see you tomorrow ;) |
|
[20:15] <asac> cu |
|
[20:15] <asac> i am off as well ... will lurk later whats going on |
|
[23:26] <fta> checking for XulRunner 1.9+ support... checking for XULRUNNER... yes |
|
[23:26] <fta> Fatal: XulRunner enabled, but XULRUNNER_HOME is empty! |
|
[23:26] <fta> make: *** [config.status] Error 1 |
|
[23:26] <fta> asac, ^^ that's the new liferea |
|
[23:27] <fta> asac, http://paste.ubuntu.com/38620/ |
|
|