=== kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away === kadams54 is now known as kadams54-away [03:24] thumper, cherylj: http://reviews.vapour.ws/r/1457/ [03:25] * thumper looks [03:26] thumper: next PR will hook up bufferedLogWriter to the logsender worker and get these running inside the unit and machine agents [03:26] * thumper nods === kadams54 is now known as kadams54-away [04:16] thumper: chat? [04:16] menn0: sure [04:16] thumper: which hangout? [04:16] meh [04:16] standup [04:16] kk [07:22] morning all [07:26] morning [07:26] dooferlad, happy birthday! :) [07:26] dimitern: :-) [08:04] morning o/ [08:05] dooferlad: oh, what do I see? happy birthday! [08:06] wow, April is always special, 5 to 6 birthdays per week, including our little daughter [09:58] gsamfira, ping? [10:02] mattyw: pong\ [10:03] gsamfira, hey there - was good seeing you last week, couple of questions... [10:03] mattyw: it was :D. Hope to do it son again :D [10:03] mattyw: sure thing, shoot [10:04] gsamfira, 1. In one of the cloudbase talks there was a mention of common problems in unit tests, and one of them was "The process cannot access the file because it is being used by another process". And there was a statement about the pattern that usually leads to it. Can you remember what that was? [10:04] yup [10:04] its opening a file for writing, defering the close and then movinf the file [10:04] :) [10:05] something like fd, err := os.Open("file"); defer fd.close; os.Move(fd.Name(), "/tmp/bla") [10:05] that usually blows up on windows [10:06] mattyw: simple way to get around it is to simply close the file before trying to delete or move it [10:06] gsamfira, ok cool, I'll see if I can fix some of those this week [10:07] gsamfira, question 2. Have you ever considered making a chocolately package for juju? [10:07] mattyw: huh...good idea :D [10:07] gsamfira, I'll add that to my list as well :) [10:08] gsamfira, no more questions for now :) [10:09] mattyw: there are some tests that try to do cleanup by simply doing a defer os.Remove("target"). Those can be replaced with defer func() { fd.Close(); os.Remove(fd.Name())}() [10:09] if those are the ones you plan to fix [10:09] then that would drasticly reduce the leftovers in $env:TMP [10:09] :D [10:10] gsamfira, there are a number in apiserver that fail that way I think so I was hoping to make time to take a look at those this week [10:11] mattyw: hmm. This must have happened in some recent commit. I did a merge on friday that fixed tests on windows again :) [10:11] gsamfira, ah - I have a branch from friday morning, I'll check again [10:13] mattyw: https://github.com/juju/juju/commit/34313b849aee8cfed333df1d02ccdb7e0cc32f58 <-- this should pass :)\ === kadams54 is now known as kadams54-away === kadams54 is now known as kadams54-away [12:11] gsamfira, yep, tests look good :) [12:11] (I ran them ages ago but totally forgot) [12:12] mattyw: sweet! now we need to make them less flaky and finally run them in parallel to the ubuntu ones in the CI :P [12:12] gsamfira, is mgz taking that on? [12:12] mattyw: yup. And we will help wherever we can :) [12:12] dimitern: reviewed your patch [12:17] jam, thanks! [12:23] Bug #1446608 was opened: agent panic on MAAS network with uppercase characters

=== kadams54-away is now known as kadams54 [13:26] mattyw: I sent mail about windows tests - there are a couple of metering suite failures that aren't immediately obvious to me [13:26] mgz, I just saw that - thanks very much. I'll take a look at those now [13:27] mgz, this on master? [13:27] mattyw: yup, windows tests on master only [13:28] mgz, I'll take a look at the meterstatus one [13:28] mgz, the rest we need someone who knows more [13:28] mattyw: yeah, I got 'em [13:35] Bug #1394755 changed: juju ensure-availability should be able to target existing machines

[13:35] Bug #1430340 changed: Failing to create tempdir in tests on windows

[13:35] Bug #1432652 changed: upgrade_test.go: TestLoginsDuringUpgrade failing due to "upgrade in progress"

[13:35] Bug #1435152 changed: Can't deploy local charm in non-server environment

[13:35] Bug #1438683 changed: Containers stuck allocating, interface not up

[13:35] Bug #1439364 changed: error in logs: environment does not support networking

[13:35] Bug #1439447 changed: tools download in cloud-init should not go through http[s]_proxy

[13:36] Bug #1443440 changed: 1.23-beta4 sporadically fails autotests

[13:36] Bug #1443541 changed: juju 1.23b4 vivid panic: runtime error: invalid memory address or nil pointer dereference

[13:36] Bug #1443904 changed: Apache-licensed code has been borrowed with violation of license requirements

[13:41] dimitern, how goes the container addressability feature flag? [13:42] sinzui, it's being tested - so far, so good [13:42] :) [13:42] sinzui, I'll most likely land it in a couple of hours - I have a review and a few things to fix first [13:43] dimitern, understood. I am going to turn off CI so that it doesn't start testing something ahead of you. [13:43] thanks sinzui [13:48] Bug #1426461 changed: Some service.Service methods should return an error

[13:48] Bug #1446662 was opened: Vivid bootstrap and destroy-environment intermittently fails

=== urulama_ is now known as urulama [14:12] Bug #1351099 changed: WARNING juju.worker.uniter.charm git_deployer.go:200 no current staging repo

[14:12] Bug #1414424 changed: envStateCollection FindId and RemveId don't filter on env-uuid field [14:12] Bug #1422791 changed: DestroyEnvironment does not remove entry from envusers

[15:02] Hey core team, join the bootstack / core call if you can. [15:03] cmars, dimitern, TheMue ^^ [15:03] cherylj: yup [15:03] cherylj, I won't manage, sorry :/ [15:17] cherylj: hmmmpf, do you see me moving? FF says it's freezed [15:17] TheMue: Yes, I do [15:17] cherylj: fine, and I can at least hear you [16:00] o/ I have a question about the enhanced service-status code thats coming... will we get something on the node itself like "unit-get status" to determine the overall status of the service being deployed? or are we relying on hook context to determine the status as we have in the past. [16:21] lazyPower, can you send a note to fwereade [16:21] will do [16:31] I need a volunteer for this bug: https://bugs.launchpad.net/juju-core/+bug/1441826 [16:31] Bug #1441826: deployer and quickstart are broken in 1.24-alpha1

[17:33] Bug #1444354 changed: juju backups includes previous backups in saved file

=== kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === JoshStrobl is now known as Josh|MakingFood === kadams54 is now known as kadams54-away === Josh|MakingFood is now known as JoshStrobl [19:41] cmars: juju-ci is failing because git.apache.org/thrift does not exist. I think I need to force this test to pass or not vote so that we can release 1.23.1 [19:44] sinzui, cmars is out [19:44] force the non vote [19:45] alexisb, looks like bad server on their side. I cannot get it either. === kadams54-away is now known as kadams54 [19:53] what's the recommended way to pull the current api state? i used to use juju.NewConnFromName [19:54] it looks like NewAPIClient and NewAPIRoot gives me access to the api state, is that the new recommended way? [19:54] api state + api client [20:42] stokachu, sorry missed your questions earlier [20:43] stokachu, can you send your question to juju-dev mailing list [20:43] stokachu, we still have many folks out on swap days [20:51] alexisb: ah ok, its not urgent just some exploritory work im doing in the juju internals [21:01] o/ can someone point me in the right direction as to what i'm doing incorrectly thats spawning 'no unit id' [21:01] http://paste.ubuntu.com/10863354/ [21:04] thumper, ericsnow, perrito666 others who might be online ^^^ [21:05] the intention is getting/sending variables out of band of the hook context in which its intended. "such as i have networking config updated, and i need to transmit over the networking relationship between hosts" [21:07] lazyPower: relation-get -r [21:07] lazyPower: looks like you are missing the unit ID [21:08] root@juju-lazyp-canonistack-machine-9:/var/lib/juju/agents/unit-docker-0/charm# relation-get private-address -r 19 flannel-docker/0 [21:08] 10.55.61.185 [21:08] oi [21:08] ok i see *why* it has to be scoped that way though, so far i've only relation-set out of band. Thanks for the rundown ericsnow [21:09] lazyPower: np :) [21:15] Bug #1446857 was opened: MeterStatusWatcher tests fail on windows test slave

=== kadams54 is now known as kadams54-away [21:45] Bug #1446871 was opened: Unit hooks fail on windows if PATH is uppercase

[21:52] xwwt, alexisb and canonistack hates us. I will make the one failing non-voting because we have other tests in the substrate that passed an hour ago [22:05] wallyworld_, thumper can someone review williams pull request from earlier today [22:05] ok, will do soon [22:06] wallyworld_, anastasiamac is up for all call reviewer, but I would like william to have what he needs in the morning [22:06] wallyworld_, thanks [22:06] sure, np === kadams54-away is now known as kadams54 [22:37] sinzui: ty for the update on that [22:38] xwwt, we have a bless, I am waiting for all the assets to arrive to queue the release [22:38] sinzui: cool. ty for sticking with this [22:39] Bug #1446885 was opened: Skipped cmd/jujud/agent/upgrade_test.go tests on windows

=== kadams54 is now known as kadams54-away [22:48] wallyworld_, thumper : do either of you have a minute to review http://reviews.vapour.ws/r/1464/ [22:48] sure [22:48] sinzui: +1 [22:50] ocr: http://reviews.vapour.ws/r/1463 [23:06] mgz: I have ci paused. I can wait a few hours for your current branch [23:07] sinzui: for trunk? sounds good, I have one more test script change to work around a bunch of uniter failures [23:08] mgz, yes trunk. I don't want to test 1.23 again given how unwell joyent, aws, and canonistack at this hour [23:56] thumper: i've updated http://reviews.vapour.ws/r/1440 if you could take another look that would be great