=== Conan_Kudo is now known as Pharaoh_Atem [05:14] morning [06:26] super trivial PR https://github.com/snapcore/snapd/pull/7057 [06:30] good morning [06:30] zyga: hey [06:30] zyga: super simple PR to start your day ^^ [06:30] already +1 [06:30] zyga: thanks! [06:31] mborzecki: I merged the master version of https://github.com/snapcore/snapd/pull/7056 a second ago [06:31] zyga: yay ;) [06:32] should I just merge the 2.40 backport? [06:33] zyga: did mvo look at it yet? [06:33] at the original yes +1 [06:33] the backport is the same for 2.40 branch [06:33] nobody looked at the backport [06:33] but it's just cherry-pick of a range [06:42] zyga: looks like nothing was missed there [06:46] mvo: hey === mborzecki_ is now known as mborzecki [06:56] mvo: hey, 2.40 backport of base migration is merged [06:56] mvo: as is the master version [06:57] brb [06:59] hey mborzecki and zyga [07:00] zyga: excellent === pstolowski|afk is now known as pstolowski [07:13] morning [07:18] pstolowski: hey [07:18] hey pstolowski [07:20] re [07:22] zyga: re 7053> I updated the description, feel free to update as you want, just wanted to do a draft to give an idea what I had in mind with my comment [07:22] mvo: sure, I'll look shortly, just making a commit message [07:22] zyga: no rush [07:30] mvo: this is what we discussed on Monday https://github.com/snapcore/snapd/pull/7058 [07:30] mvo: not sure if you want it in 2.40 - but at least now it is up and we can discuss it [07:31] sounds it needs a jdstrand review anyway [07:32] also I heard the motivation but not the details of what it entails [07:33] pedronis: this is based on the discussions in lyon and montreal, jamie was +1 on this [07:33] pedronis: how should I proceed on that? [07:34] may recollection of lyon wasn't so clear that jamie was +1 [07:34] my [07:34] we need a meeting with him next to go over the consequences of this again [07:35] *next week [07:35] pedronis: we discussed this more in montreal [07:35] ah, right, he's off this week [07:35] I was not there [07:35] so, I fear, you'll have to bear with me [07:35] sure no worries :) [07:36] I can setup a meeting, early next week? [07:36] yes [07:37] gustavo as well? [07:38] mvo: not in the first meeting, he was mostly +1 in lyon [07:38] cool [07:38] zyga, pedronis meeting setup [07:39] thank you! [07:39] (and now even added conferencing - oh I wish there was a way to make this default) [07:41] that one caught me out in Montreal - I'm using a mainline kernel for Microsoft Surface out of tree patches [07:42] I've filed a PR on the linux-surface repo to hopefully add the required bits for their kernel to support snaps out of the box on Ubuntu [07:43] I think the bit missing was the apparmor patch for "legacy network" stuff (apparmor uses the feature flag "network" as opposed to their new "network_v8") [07:46] diddledan: thanks, that's interesting [07:46] specifically apparmor in mainline exposes network_v8 not network. the patch re-adds network so Apparmor exposes both feature flags [07:47] this is the patch that Apparmor carries out of tree: https://gitlab.com/apparmor/apparmor/commit/aa42e338600ab6b5a1368dc5c4920974192adfd1 [07:49] diddledan: I'll discuss this with jdstrand when he is back [07:49] cool [08:14] https://forum.snapcraft.io/t/proposal-to-change-the-channels-display-of-snap-info/12134 [08:40] no wonder you all were quiet :-) [08:48] Chipaca: how do you mean? [08:48] mvo: irc client had quietly disconnected [08:49] or quietly never connected? [08:49] Chipaca: haha - now it makes sense :) [08:55] "accident" my foot! [09:01] diddledan: I'll have you know I have no IRC clients in my foot. [09:02] diddledan: I'll have you know I have no *IRC* clients in my foot. [09:02] diddledan: I'll have you know I have no IRC *clients* in my foot. [09:02] diddledan: I'll have you know I have no IRC clients *in* my foot. [09:02] diddledan: I'll have you know I have no IRC clients in *my* foot. [09:02] diddledan: I'll have you know I have no IRC clients in my *foot*. [09:02] * Chipaca stops before doing combinations [09:02] you have other clients in your foot? [09:04] I can't comment [09:15] * zyga is sleepy [09:15] zyga: amen [09:15] my watch reckons i got 5h of sleep [09:15] i think it's about right [09:17] you merged some things fairly late, I saw [09:17] and then rebased the followup [09:17] which was fun [09:17] and then did the bi-weekly supermarket shop while waiting for spread [09:18] amazon linux is sad :-( [09:19] # github.com/snapcore/snapd/cmd/snap [09:19] src/github.com/snapcore/snapd/cmd/snap/cmd_info.go:93:13: undefined: strings.Builder [09:19] error: Bad exit status from /var/tmp/rpm-tmp.wKuf9u (%build) [09:19] hmmmmm [09:19] Chipaca: too old go [09:19] cannot use strings.Builder yet [09:20] * zyga takes a 15 minute break [09:20] why aren't the unit tests catching this :-( [09:20] … because they're run on 1.10 [09:21] why are we running the unit tests on 1.10? [09:21] I thought all our downstreams now are on go-1.10 is this not the case? if so we need to go back to 1.9 there :/ [09:22] I thought so as well [09:23] Chipaca: which os was this on? [09:23] amazon? [09:23] zOMGon [09:23] https://api.travis-ci.org/v3/job/553521524/log.txt [09:24] it's on 1.9.4 apparently [09:24] we run on 1.10 because fmt changed I think [09:25] mborzecki might remember the exact reason [09:25] hm hm? [09:25] BuildRequires: %{?go_compiler:compiler(go-compiler)}%{!?go_compiler:golang >= 1.9} [09:25] we're just asking for 1.9 in amazon [09:25] wait that's fedora spec [09:25] :-| [09:25] we can run the static tests on 1.10 [09:25] and the unit on 1.9 ? [09:26] mborzecki: it seems #6799 was premature [09:26] ancient linux [09:26] hm let me check something [09:27] pedronis: mborzecki: I'll push a pr to bump it down to 1.9 unless mborzecki finds something interesting :-) [09:27] Chipaca: I remember we had a reason [09:27] but I don't think it applied to all tests [09:28] pedronis: yeah, there's a pr from jdstrand mentioning 1.10 [09:28] but it's ok [09:28] it uses something that's there from 1.7 [09:28] user.LookupGroup [09:29] anyway my vague recollection is that go fmt output changed at some point [09:30] i can easily split static and unit tests [09:31] pedronis: gofmt too, though it's 1.11 i belive that broke it [09:32] heh so centos gets a newer golang than amazon linux 2 now? [09:38] centos 7 via epel - 1.11, amzn2 via amazon core repo 1.9 :/ [09:38] Chipaca: so, switching back to 1.9? [09:39] ye [09:40] mborzecki: https://bugzilla.redhat.com/show_bug.cgi?id=1726382 do you understand what this is about? [09:42] zyga: doesn't make any sense [09:43] preliminary results of optimization of connects wrt setup-profiles, with lxd snap that connects 4 interface: old snapd - https://paste.ubuntu.com/p/5ZVNkBxVqQ/ ; new snapd - https://paste.ubuntu.com/p/F69TGbWWtg/ ; almost 3x faster (sum of connect+final setup profiles timings) [09:43] \o/ [09:44] pstolowski: try something beefier, like vlc [09:44] zyga: i'll check what's going on there [09:44] pstolowski: just to show off :-) [09:44] :D [09:44] good idea [09:46] pstolowski: woah, thats sooo nice [09:46] yeah, install of lxd snap feels much faster now [09:47] and this is what we had in the past before, cough cough, interface hooks [09:47] heh [09:58] pstolowski: are you moving setting up profiles to one call to setup-profiles after the connects ? [10:00] pedronis: yes, final setup-profiles after connects (but before connect-plug|slot hooks). existing setup-profiles after link-snap remains untouched. [10:01] pedronis: have you seen https://forum.snapcraft.io/t/bug-1809708-allow-snaps-to-query-interface-connection-status-directly-from-snapd/9147?u=chipaca ? [10:01] pstolowski: ok, it's important to know because the plan was to drop setup-profiles [10:01] when is merged with link-snap [10:01] we need that anyway [10:01] pedronis: hmm wrt what Chipaca was about to do? [10:01] but it's orthogonal issue [10:01] but we need to know if we need to merge the logic into the other as well [10:02] but keep it around otherwise [10:02] pstolowski: yes, Chipaca's work [10:02] right [10:03] Chipaca: we have had similar requests already, I think it's in our backlog but not scheduled, needs also a final design [10:08] vlc installation: 4300ms vs 1600ms (connects+setup profiles only) [10:10] that's on a vm [10:14] zyga: added needinfo from the reporter, things seem to work fine on my end [10:14] thanks [10:16] mvo: I created https://forum.snapcraft.io/t/injecting-snapd-tools-into-base-snaps-and-keeping-them-up-to-date/12139 [10:17] Chipaca: https://github.com/snapcore/snapd/pull/7060 is failing unit tests due to build ID [10:18] Chipaca: so the details are coming back a bit, iirc 1.10+ adds Go BuildID by default [10:19] earlier versions would only get it iff built with external linker that was configured to add it (didn't we have question about that regarding gentoo in the forums?) [10:19] * zyga spawns a pair of spread runs and goes to make coffee [10:24] mborzecki: another fedora fun https://bugzilla.redhat.com/show_bug.cgi?id=1675023 [10:26] zyga: golang-github-gosexy-gettext? haha [10:27] zyga: i'd like to see people behind corporate filters trying to access github page of that package [10:27] yeah [10:27] https://www.tomshardware.com/news/india-shakti-cpu-processors-sdk-risc-v,39781.html <- maybe more risc v boards soon? [10:29] mborzecki: an easy & lazy fix would be to tag the build id checking tests as not-short [10:32] zyga: we don't use gosexy-gettext anymore, do we? [10:32] mvo: but I am the package maintainer [10:33] need to do something about it [10:33] zyga: oh, ok [10:34] RISC-V is intriguing. I'm curious how soon we'll see someone try to make a workstation with one [10:36] I kinda think though that x86(64) is too entrenched for consumer migration in any meaningful numbers [10:36] in terms of IoT though I can see it breaking through [10:37] Chipaca: i think the problem is actually osutil dropping the need for import C more than go version switch, that's just a side effect [10:37] diddledan: what is the talos workstation [10:38] that's powerpc IIRC [10:38] power9? [10:38] ah, yes [10:38] sorry [10:38] power8 [10:38] it's suffering an off-by-one ;-p [10:39] same [10:42] hmm, i'm going to go lie down for a bit [10:43] * Chipaca not improving with time [10:46] * zyga has coffee now [10:48] mvo: let me know when you have a chance to look at https://forum.snapcraft.io/t/injecting-snapd-tools-into-base-snaps-and-keeping-them-up-to-date/12139 [11:00] zyga: I'll have to look at it too [11:00] thank you [11:01] pedronis: any more ideas are welcome, this captures what we discussed during the call on monday [11:02] interesting [11:02] perhaps there is an easier way to fix it that we did not think about [11:05] mvo, pedronis: long overdue - https://forum.snapcraft.io/t/snap-debug-timings/12141 [11:06] I made some small typos/formatting changes [11:06] mainly commas [11:06] will ask Graham for proof-reading as well when he is back [11:06] zyga: thanks, re-reading myself again [11:07] 56455ms - Save data of snap "lxd" in automatic snapshot set #1 [11:07] yuk [11:12] zyga: yes, I have a look once I am finished with my current uc20 part [11:12] https://forum.snapcraft.io/t/segmentation-fault-running-snapcraft-on-arch-linux/12142/2 hm python3 segfaulting on arch [11:12] mvo: super, thank yuo [11:12] *you [11:16] * pstolowski lunch [11:34] Chipaca: there is something strange in the diff of 6878, it seems to be adding back (again) maybePrintType etc ? [11:34] some merge artifact? [11:43] pedronis: merge artifact indeed [11:43] pedronis: I'll clean it up, and address your other points [11:44] pedronis: indeed at some point i forgot we meant health to be multi-line in info [11:44] Chipaca: I don't have a strong opinion about not-verbose, but for verbose it should be [11:44] for some reason i thought git would do a proper job of merging things given I started from the thing that then caused conflicts everywhere [11:59] cmatsuoka: I hope I will have the updated recovery dir layout ready by the standup, mostly fyi, fighting with the last small issues [11:59] Chipaca, just switch to bzr [12:00] mvo: great, I'm running some tests to check the stability issues with the updated core20 snap [12:01] cmatsuoka: thank you [12:01] cmatsuoka: is it updated already? iirc I just proposed a pr. anyway we can talk after my lunch :) [12:02] mvo: not updated, I'm building it locally [12:04] ogra: alias git='bzr --rotated-90-degrees --extra-complicated --zippy' [12:05] haha [12:06] (so true) [12:07] is glibc locale archive a memory dump of structures? [12:07] mvo: but my build just failed, this snap seems to be a bit tricky to build === ricab is now known as ricab|ricab [12:28] * zyga goes for lunch [12:34] pedronis: wrt health's position in the struct, it seemed like the sensible place to put it, looking at the types of the things [12:34] Chipaca: I shall look at the full struct then [12:35] pedronis: txs [12:41] hey mvo, could you add me to the SU meeting invite? I don't have it on my calendar yet [12:54] I'm online but having lunch with family at the seaside [12:54] and sending updates to spread.zygoon.pl [12:54] over that uncapped LTE [12:56] morning zyga [12:56] hey ijohnson :) [12:57] ijohnson: I'm semi afk but I can read updates once in a while [12:57] ijohnson: sure, done [12:58] mvo: and perhaps the github team, if not done already [12:58] zyga: ok, np. did you see my post at https://forum.snapcraft.io/t/mount-namespace-walkthrough-wip/12127 ? it's still a wip but I've gotten most of the way through snap-confine at least [12:58] ijohnson: I did not, queued [12:58] zyga: I think I did that, hope added to all the right places :) [12:58] the only thing I'm still missing I think is spread access [12:58] looks good [12:59] I will read the details and comment [12:59] great, thanks [12:59] mvo: got it thanks! [12:59] ijohnson: I'm trying to build a new flow, with snap-boostrap-ns, reusing snap-update-ns, where C does less stuff and snap-update-ns has only one entry point that is stricter than now (from snapd) [12:59] yay [13:00] zyga: I need to dig in a bit more, but the whole preinit_array thing with cgo I've seen done in pure go with a docker package called re-exec [13:00] (for bootstrap.c in snap-update-ns) [13:00] ijohnson: one motivation is to remove C from snap-update-ns as well [13:00] ijohnson: anyway, that's for later, I'm just sharing thoughts [13:00] ijohnson: the goal is to streamline snap-update-ns and remove C as much as we can [13:02] ijohnson: the new binaries would be easier to understand than the multi-purpose one we currently have [13:02] * zyga focuses on the food now [13:03] ogra@pi4:~ $ grep ^NAME /etc/os-release [13:03] NAME="Raspbian GNU/Linux" [13:03] ogra@pi4:~ $ snapcraft --version [13:03] snapcraft, version 3.6 [13:04] :D [13:05] oh ... something is broken ! [13:05] ogra@pi4:~ $ sudo snap install lxd [13:05] [sudo] Passwort für ogra: [13:05] Warning: /snap/bin was not found in your $PATH. If you've not restarted your session since you [13:05] ... [13:05] ogra@pi4:~ $ echo $PATH [13:06] /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/games:/usr/games:/snap/bin [13:06] ... [13:06] thast definitely a flashe positive [13:06] *false [13:06] ogra: nice [13:06] ogra: sudo [13:06] ogra: sudo changes PATH [13:06] is debian different here ? [13:07] i have never seen that on ubuntu [13:07] ogra@pi4:~ $ sudo echo $PATH [13:07] /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/games:/usr/games:/snap/bin [13:07] yes [13:07] sudo -s [13:07] echo $PATH [13:08] otherwise PATH is expanded by the non-root shell [13:08] ah, right [13:08] yeah [13:08] now i wish i had a u-boot tree :( i want core ! [13:09] how does it boot? [13:09] rpi firmware boots a kernel.img directly [13:10] (and nop initrd at all as far as i can see) [13:10] *no [13:11] (like all other pi's essentially ... ) [13:11] ogra: that's interesting [13:12] whats interesting about it ? it is the same bootprocess they use since day one [13:12] and as usual we have to wait for a u-boot port before we can move on with core [13:12] i'm sure something will show up within the next weeks [13:13] ogra: but you can have an initrd, right? [13:13] you can hack one into config.txt yeah [13:14] there is an option for defining one [13:14] and that firmware is still closed-source, right? [13:14] yup ... it the graphics driver [13:14] *it's [13:15] the pi boots by first firing up the GPU ... the GPU then turns on the arm SoC [13:15] thats why you for example dont really need an extra graphics driver at all ... just some userspace libs [13:16] they interface dircetly with the GPU driver/bootloader blob [13:16] *directly [13:18] ogra@pi4:~ $ free -m|grep ^Mem [13:18] Mem: 3906 105 3299 8 500 3668 [13:18] ogra: sudo -i should work too [13:18] i like that one :) === mborzecki_ is now known as mborzecki [13:19] mborzecki_, yeah, i was just not aware that debians sudo is different to ours ... i'm used to sudo not making a mess out of my env :) [13:19] ogra: fedora's sudo does the same [13:19] yep ... i bet suse's too [13:20] (or upstream FWIW ... but if you are used to userfriendlyness it is confusing :) ) [13:23] Chipaca: maybe we could just skip a test in osutil for go < 1.10 and mock buildid in api and system-key tests? [13:24] Chipaca: unless there's a way to pass build flags to go test via //go:, though I'm no aware of anything like that [13:26] mborzecki: go test -tags=yadda and then //+build yadda [13:27] Chipaca: right, we'd need to update run-checks for that hmm === ricab|ricab is now known as ricab [13:36] Chipaca: move the test to separate file with //+build go1.10 so that we don't need to guess the format of runtime.Version()? :) [13:36] mborzecki: I closed the PR, instead. That also worked. [13:36] * Chipaca takes practicality to a new level [13:37] Chipaca: haha ;) ok, i can look into that [13:37] mborzecki: oh, i can too [13:37] but it needed more work and i didn't have the bandwidth to look so i closed it before wasting people's time [13:37] mborzecki: how full is your plate? [13:39] Chipaca: gadget updates & random ramblings, but I can look into working around that 1.9 quirk [13:41] pulseaudio -k a day keeps the insanity at bay [13:50] geez ... this snapshot default feature is very annoying [13:54] maybe we should ask the user the first time? [13:57] either that or make it opt in [13:58] snap remove --keep-data ... or whatnot [13:58] it really depends on the size of the data, but yes the current UX is not great in some cases [13:58] ^C should still stop the removal and let you try again with --purge [13:59] i just installed snapcraft on this pi4 raspbian install ... forgot about the fact that this now needs multipass ... so the forst snapcraft run downloads multipass ... this then fails after creating a VM image for 10-20min ... [13:59] i then uninstall multipass (and snapcraft since it is uselass in that setup) ... and snapd keeps the rotten multipass VM image around [13:59] Chipaca: does it work atm? [13:59] I mean ^C [14:00] i could ^C out of it and it complained with an error [14:00] ogra@pi4:~/linux-generic-allwinner $ sudo snap remove multipass [14:00] Save data of snap "multipass" in automatic snapshot set #1 |error: cannot perform the following tasks: [14:00] - Save data of snap "multipass" in automatic snapshot set #1 (tar failed: context canceled) [14:00] ogra@pi4:~/linux-generic-allwinner $ [14:00] thats what i got with ^C ... [14:01] still, the experience is quite a mess [14:01] and indeed multipass is still around ... [14:01] snap help doesnt really talk about how to not have a snapshot taken on remove ... it only tells about how to manage snapshots [14:02] (i guess the info i'd be looking for is in the details of snap remove's help) [14:02] pedronis: it should [14:03] and yes abort is never pretty to see [14:03] mvo: got a lead on python3 segfaulting on arch [14:03] hrm ... [14:03] and snap remove help doesnt mention --purge at all [14:03] ogra: then you don't have a new enough snapd [14:03] ogra: disable it globally, instead [14:04] ogra: https://docs.snapcraft.io/system-options#heading--snapshots-automatic-retention [14:04] mvo: when i drop mymachines from /etc/nsswitch.conf it does not segfault anymore [14:05] mborzecki: time to top sharing /etc/ [14:05] and provide crafted view [14:05] but then classic snaps are ... complex to say the least [14:05] Chipaca, i'm finding my way around (and wont keep that raspbian anyway) ... but i'm trying to take this experimant like a snap-illiterate user ... and now i'm already sitting here with a mess :P [14:07] btw ... i have 2.39.3 according to snap version [14:07] $ sudo snap remove --purge multipass [14:07] error: unknown flag `purge' [14:08] $ snap version|grep snapd [14:08] snapd 2.39.3 [14:08] should that not have --purge already ? [14:09] that's an mvo question, i always get lost [14:09] heh [14:10] my snapd here has purge, but it also has set-health and 'snap info' shows health information [14:10] ¯\_(ツ)_/¯ [14:11] zyga: mvo: left a note https://forum.snapcraft.io/t/segmentation-fault-running-snapcraft-on-arch-linux/12142/6 [14:12] mmm [14:20] mborzecki: thank you [14:28] stgraber, https://paste.ubuntu.com/p/XGmFsskzHK/ ... lxd on raspbian ... do you think we could quieten the errors ? they look scary [14:28] (it seems to run find otherwise ... but if the errors ate "ignored" we could as well not show them at all) [14:28] *fine [14:29] those messages come from the linker, not much we can do about it [14:29] hmm, k [14:29] also we're not seeing those on other arm platforms, so that suggests there's something odd with raspbian [14:29] thats buster fwiw ... perhaps too new ? [15:11] ogra, stgraber: I see the same linker messages on stretch raspbian for a long time (since at least last year) so I don't think it's buster specific [15:20] ah ... its my first direct debian contact in years [15:21] (well, not true, i used armbian for 1h or so a while ago ... but not significant enough to notice issues) [15:42] cachio: so I tried again, I'm not getting it to fail where I would expect, I'm getting this, notice the PAM errors [15:42] cachio: https://paste.ubuntu.com/p/FX25MJhHWz/ [15:44] cachio: I can push my test changes to the PR if it helps, or somewhere else [15:50] Chipaca: I looked at the struct [15:52] pedronis: wdyt? [15:53] pedronis: ah ok [15:53] pedronis: and type? [15:54] asked there [15:54] going afk now for a bit [15:54] ijohnson: https://forum.snapcraft.io/t/injecting-snapd-tools-into-base-snaps-and-keeping-them-up-to-date/12139/2 [15:58] Chipaca: type can stay first field [15:59] answered also in the PR [16:03] cachio: I pushed my debugging tweaks (on top of my PR) here: https://github.com/pedronis/snappy/commit/9ef3d3b6cd8cd775110472346e5a00e9ecb729da === pstolowski is now known as pstolowski|afk [16:25] pedronis: (for later) - I played a bit in image.go, I wonder if something along the lines of http://paste.ubuntu.com/p/TFtXTX9FPz/ makes sense? [16:25] http://paste.ubuntu.com/p/TFtXTX9FP [16:25] pedronis: no rush, I have dinner now and we can talk later/tomorrow [16:56] pedronis, nice, taking a look now [17:03] pedronis, the tweaks seem to be well [17:03] are you creating a PR with those? [17:26] cachio: they might be good, but if I try your repeat it doesn't die on the exit 1 [17:26] but at other places [17:26] which confuses me [17:26] pedronis, it is branking on snap pack? [17:27] mvo: what about seed.yaml in that code? [17:27] it doesn't exist in the new world [17:32] cachio: it seems to be breaking at random points, sometimes [17:32] but maybe is just spread not getting the full log back [17:32] but I would expect to not break before the install [17:32] but it seems to [17:35] pedronis, ok, I am testing the this [17:36]