[00:03] pfanelli: might have more luck on the mailing list [00:11] bob2: thx. I got this channel off of the bzr web site. I also checked for answers on LP. Do you know how to subscribe to the mailing list? (this is probably a stupid ? :) ). Also, I was gonna' ask a question on LP. Do you think i should also do this? [00:12] pfanelli: https://lists.ubuntu.com/mailman/listinfo/bazaar - dunno about lp [00:13] bob2: heh, i just looked up the mailing list on the bzr site (duh - my bad, lol) thanks! [00:14] pfanelli: no worries === salgado is now known as salgado-afk [00:24] * igc offline for an hour or so while travelling [01:12] I've just submitted 3 of Robert's approved patches to PQM, given that he's offline today. [01:14] is there any chance of the 30+ patches currently in BB landing before 1.13? === Wowbagger is now known as UdontKnow [01:47] jelmer: I just got a "Could not determine revno for ... because its ancestry shows a ghost at ..." error, thoughts? [01:47] while trying to commit to a svn branch [01:47] jelmer: of all of them landing? I'd estimate that at near 0. [01:48] jelmer: there's a good chance that some of them will, though... [01:48] Perhaps even most? [02:03] is there a location alias for the "checkout of" branch? [02:07] spiv: thanks [02:22] anyone seen any integration with Visual Studio and Bazaar? [02:24] I see this https://launchpad.net/bzr-visualstudio but it doesnt seen active [02:40] * igc is back online [02:48] jam, if you're still around, the groupcompress tests are failing [02:49] I think I know the fix but I'm not sure ... [02:49] add "start = entry.start" around line 236 in groupcompress.py? [02:58] spiv: ping [03:00] hi lifeless [03:05] jfroy, please file a bug [03:05] will do if I see it again [03:05] spiv, most would be nice [03:06] I wiped the cache and tried the operation again (a commit), and it worked [03:06] jfroy, it's not reproducible? [03:06] (well, also made a clean checkout) [03:06] I haven't seen the same error again yet [03:06] poolie: hi [03:06] I always try a "wipe cache, get a clean checkout" while tracking bzr-svn top of tree. [03:07] It's not unreasonable for changes to invalidate existing branches or the cache [03:07] jfroy, unless there is a bug that's been fixed no changes should be invalidating existing branches/cache [03:08] jfroy, was this the same branch we fixed a bug in yesterday? [03:10] yes I believe so [03:10] actually no [03:10] well, yes and no :p [03:10] same subversion branch [03:11] but much older local branch (my actual daily work branch) [03:13] lifeless: pong [03:19] spiv: about to send in a tags fix [03:19] lifeless: hooray. ratchet improvement? :) [03:19] spiv: surprisingly, not yet. 4 verbs in and still equilibrium [03:20] lifeless: I'd love a review of my fetch with search patch (http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C20090306005950.GD7819%40steerpike.home.puzzling.org%3E) [03:20] lifeless: huh, odd. What's the current culprit? [03:21] spiv: tags [03:21] so get_parent_ was equilibrium [03:21] ten tags - first _should_merge, [03:21] but .tags needed real [03:22] then branch._transport needed real [03:22] which is what I'm working on at the moment [03:22] oh, open_branchV2 is in there too, to get the format [03:32] spiv: also there is an oddity on decod of responses [03:32] spiv: '' -> () [03:33] igc: something like that. I think I fixed it in a different branch by using 'entry.start' in place of 'start', but either should be fine [03:33] spiv: or more clearly, ('',) [03:33] spiv: and, ratchet -> 11 [03:38] i'm about to travel, and i have a small class projec that i'm using bzr to track on my deskop, i'm the only 'developer' and it's not public anywhere. i'd like to move the working tree to my laptop while i travel... can i simply copy the directory over? or is there better way? [03:38] sure just [03:38] on your laptop, [03:38] bzr branch bzr+ssh://desktop/~/what/ever [03:38] oh, and make a repo in the right place on your laptop first [03:38] jam: yeah, it looked like start was being set in the if branch but not the else branch [03:39] 'make a repo' meaning a directory for it to live in, i assume [03:40] lifeless: I fixed some bugs in your get_parent branch to be able to land it, btw [03:40] spiv: ok, I'll pull now [03:40] lifeless: where you were passing 'foo' rather than ('foo',) as a response [03:40] jam: the unclear bit was knowing what start ought to be set to - and entry.start looked a likely option :-) [03:41] hackedhead: i mean, in your home directory, do [03:41] bzr init-repo myproject [03:41] lifeless: you had some tests and code that had (x) rather than (x,), happily other tests noticed :) [03:41] igc: yeah, inside that if, entry.start is set to start [03:41] or whatever name you want to use [03:41] spiv: yes, I've just been cleaning that up here too [03:41] this will make a directory to hold all your branches [03:41] it is outside the if that already has it [03:42] jam: another minor quibble, the groupcompress branch had a heap of bzr tags in it referencing missing revisions [03:42] jam: I'm not sure if they're gone know but my concern was how they got there [03:42] igc: root cause: pull not propogating tags [03:43] poolie: okay, and when i get back i can do a merge from the desktop, using ssh again, in the other direction? [03:43] yes, or just push to the desktop [03:43] oh, right, okay [03:43] presumably no other work will have happened there while you're away [03:43] so just a push will do [03:43] yes. =] [03:43] hth [03:43] yeah,much, ty [03:43] lifeless: I'm not sure I understand - why would a 'bzr-0.15' tag exist in the groupcompress repo at all? [03:43] you're welcome [03:44] igc: oh, that? blame jam :P [03:44] o/ [03:44] maybe the orginal branch shared a repo with bzr.dev or something? [03:45] funny, I don't remember ever trying to merge my jam-integration branch into groupcompress [03:45] I honestly don't have any idea why the tags would have spread to GC [03:46] maybe I did a 'bzr merge' with a bad path once? [03:46] igc: It shares a repo, but it shouldn't have shared a branch [03:52] spiv: [03:52] [BzrDir.open, BzrDir.open_branchV2, BzrDir.find_repositoryV3, Branch.get_stacked_on_url, Branch.last_revision_info, BzrDir.cloning_metadir, Repository.get_parent_map, Repository.get_stream, Branch.get_parent, Branch.get_tags_bytes, Branch.get_tags_bytes] [03:52] spiv: clear as day now. [03:53] spiv: also note: VFS-free! [03:53] spiv: I'm going to ignore the duplicate call [for now] [03:53] spiv: as caching coherency requires a little care, and this is already somewhat better [03:55] lifeless, jam, this branch was originally going to set the format to 1.9-rich-root [03:55] to get it over with [03:55] poolie: which branch [03:55] to set the default format for 1.13 to 1.9 [03:56] i'm inclined now to stick with plain 1.9 [03:56] works for me [03:57] spiv: reviewing your patch about fetch paramaters [04:02] lifeless: nice [04:03] spiv: so, I want to combine the first three calls [04:04] spiv: with a lock_read() we could optimistically ask for the next two or even three [04:04] lifeless: a lock_read on which object? [04:04] spiv: Branch [04:05] Hmm. If we opened branches read-locked, then get_stacked_on_url and last_revision_info are obvious things to fetch. [04:05] yes [04:05] but api clarity does still matter :) [04:06] Right. [04:06] Branch.open().unlock().lock_write() blows [04:06] There is definitely some friction with the current API here. [04:06] poolie: I wouldn't do rr [04:06] given the 5-hour conversion times [04:06] I could buy into Branch.open_read_locked() [04:06] lifeless: me too [04:07] me three [04:07] jam, ok [04:07] wait for something like CHK, which gives a real benefit [04:11] spiv: reviewed [04:12] spiv: in short; some smoke tests for the new capabilities; and some naming changes [04:12] spiv: also please review my tags patch :) [04:12] lifeless/spiv: changing the default format to 1.9 bumps test_branch_from_trivial_branch_streaming_acceptance to 18 [04:12] poolie: tsk! [04:12] putting just a number there makes it hard to see what actually was added [04:13] poolie: yes, thats true. OTOH its very easy to work with for us [04:13] poolie: when some of the ratches are still > 100 [04:13] yes that's the tradeoff [04:13] i know i know [04:13] :) [04:13] been there too [04:15] spiv: oh bah, ignore the self.debug() call I left in [04:16] lifeless: was already reviewing :) [04:16] poolie: it stays at 11 for me [04:17] spiv: K, I'll wait for your feedback and remove the debug call at the same time [04:18] poolie: I see: [04:18] [BzrDir.open, BzrDir.open_branchV2, BzrDir.find_repositoryV3, Branch.get_stacked_on_url, Branch.last_revision_info, BzrDir.cloning_metadir, Repository.get_parent_map, Repository.get_stream, Branch.get_parent, Branch.get_tags_bytes, Branch.get_tags_bytes] [04:18] poolie: however, I do see an increase in blackbox.test_branch.TestSmartServerBranching.test_branch_from_trivial_branch_to_same_server_branch_acceptance, which is from 65 to 66 [04:21] lifeless: http://pastebin.ubuntu.com/127042/ [04:22] lifeless: reviewed [04:23] poolie: yeah, most of those will be tags [04:23] poolie: print self.hpss_calls[8].stack [04:23] i guess it's also reading the stacking control file [04:23] poolie: will show you the cause [04:25] that's nice [04:25] well it's http://pastebin.ubuntu.com/127042/ [04:25] meh [04:25] format_string = transport.get(".bzr/branch-format").read() [04:26] poolie: right, but look higher :) [04:27] poolie: _ensure_real is generally a symptom [04:27] you'll find something like merge_tags_if_needed [04:27] sure, of get_parent [04:27] or get_parent :) [04:27] get_parent as landed though [04:28] just recently? [04:28] today [04:28] Yes, a couple of hours ago. [04:28] so maybe that didn't reduce the rpc count, but it did eliminate vfs access here? [04:29] Right. [04:29] yes get_parent_map was no improvements in round trips, but one less cause of vfs [04:29] the next patch removes the last cause [04:29] lifeless: s/get_parent_map/get_parent/ :) [04:29] bah yes [04:30] Perhaps it should be called get_parent_location to reduce confusion? Not that the wire API is the same as bzrlib's API... [04:30] spiv: see thursday's chat:) [04:30] spiv: _run_with.. should show the transform [04:30] ? [04:30] on staying on the main game? [04:30] at a guess [04:31] poolie: no, about verb names [04:31] lifeless: oh, _run_with... was self-explanatory to me :) [04:31] spiv: I can't tell if I need a lambda or not [04:31] spiv: for instance [04:32] lifeless: please feel free to extend the docstring; the transform for the given example is just "return _run_with_write_locked_target(callable, *args, **kwargs)" [04:32] (what if _transport is only defined in the lock_written state? for instance) [04:32] Typically if a function takes *args/**kwargs then lambdas are unneccessary. [04:34] ok so that one's still failing after merging bzr.dev... [04:35] because now tags() is forcing a real repository... [04:37] poolie: so the problem is that _ensure_real of a BzrBranch7 is one VFS call more expensive than of Branch6? [04:37] spiv: your cloning_metadir looks odd [04:37] spiv: sometimes you return a tuple [04:37] i think so [04:37] spiv: sometimes you return a string, for branch_name [04:37] spiv: is this deliberate? [04:37] lifeless: do I? Hmm. [04:37] that would be consistent with it having to read its stacking url over the vfs [04:37] lifeless: IIRC I meant to always return a tuple. [04:38] lifeless: ugh, so I do. [04:38] spiv: adjusting [04:38] therefore i think it's correct for that count to go up by 1 given the level of technology in this branch [04:38] lifeless: thanks. [04:38] spiv: and letting pqm handle the fallout [04:39] poolie: what's odd to me is that 1.6 has stacking URLs too... [04:39] spiv: current default is 0.92 [04:39] Oh, ok. [04:39] In that case, it all makes perfect sense :) [04:40] poolie: http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C1236311834.10834.1.camel%40lifeless-64%3E [04:40] poolie: given that lifeless is about to land get_tags_bytes, which should get rid of the VFS from that case, a temporary +1 bump sounds ok to me. [04:40] poolie: ^ is about to land [04:40] poolie: and it will conflict on that line [04:40] poolie: but as lifeless says maybe just merging in that branch will be easier? [04:42] k, i'll look at some other failures first [04:45] poolie: so the other acceptance test in test_branch.py *will* go up for 1.9 as default, with my branch [04:45] poolie: and thats fine [04:54] (65->66 for me - you have +1 on that change) [05:05] i wish, again, we printed stack traces as soon as they occurred... [05:08] is it bad if "bzr check" says "2 inconsistent parents"? [05:08] on the repo where it says that, i can't push changes in [05:08] i made that repo with "git-fast-export | bzr fast-import", and it seems to work fine locally, but not in branches i've made off it... [05:09] seb_kuzminsky: it may be a bzr-fastimport bug then [05:09] seb_kuzminsky: ideally someone would run bzr reconcile on that repo [05:10] * seb_kuzminsky reads about reconcile [05:10] lifeless or spiv, one of you might want http://bundlebuggy.aaronbentley.com/project/bzr/request/%3Ce01316480903052104k63c85898t88ed90dcccdc7715%40mail.gmail.com%3E [05:10] also spiv is http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C20090126072506.GA30864%40steerpike.home.puzzling.org%3E now obsolete? [05:11] "Reconciliation complete." [05:11] bzr check is clean now :-) [05:13] but it still doesnt work :-( [05:14] poolie: not obsolete, but it does need another look to figure out how it should interact with vila's http network activity [05:14] i removed ran reconcile on the "master" repo, removed the remote branch, re-branched to the remote machine, committed on the remote machine, and tried to push [05:14] bzr: ERROR: Revision {set([('null:',)])} not present in "KnitVersionedFiles(_KnitGraphIndex(CombinedGraphIndex(, )), )". [05:14] both repos are 1.9-rich-root, in case that matters [05:14] both 'check' clean [05:15] seb_kuzminsky: which version of bzr? I think this bug was fixed in bzr.dev about a week ago. [05:15] "1.13dev" on the remote machine [05:15] "1.12" on the master server [05:15] upgrade the server? [05:16] remote is on the bzr intrepid ppa [05:16] seb_kuzminsky: upgrade the 1.12 to bzr.dev if you can, IIRC [05:16] server is intrepid's 1.12-1~bazaar1~intrepid1 [05:20] spiv: do i need the nightly ppa? or is beta good enough? [05:20] looks like i need beta [05:20] s/beta/nightly/ [05:20] seb_kuzminsky: nightly, I think. [05:21] seb_kuzminsky: https://launchpad.net/bugs/317654 is the bug, btw [05:21] Ubuntu bug 317654 in bzr "error about null revision not present pushing to server" [High,Fix committed] [05:22] seb_kuzminsky: also, you may be able to workaround it by using sftp:// rather than bzr+ssh:// [05:22] hmm [05:23] yes, sftp:// pushed successfully [05:23] but it didnt run the hooks (bzr-email, bzrbuildbot) [05:23] Yeah. [05:23] those only run with ssh, right? [05:23] That's right. [05:24] ok [05:24] * seb_kuzminsky adds bzr-nightly-ppa to sources.list.d/bzr.list [05:25] spiv: I've just forwarded you a pqm failure [05:25] lifeless: ok [05:25] spiv: I'd like to ask a favour [05:26] spiv: land my http://people.ubuntu.com/~robertc/baz2.0/integration branch [05:26] lifeless: ok [05:26] spiv: its likely that ^^^^[log from bzrlib.tests.branch_implementations.test_hooks.TestOpen.test_open(RemoteBranchFormat-default)] is one of several failures with hooks [05:27] * spiv nods [05:27] so running hooks.* RemoteBranchFormat should flush them out [05:28] I *think* at a glace that the branch is being opened remotely in more cases === jfroy_ is now known as jfroy [05:28] so trivially adjusting may be sufficient [05:29] server is on 4083 (latest in bzr.dev), remote machine is on 4058 [05:29] remote still can't push, same error [05:30] upgrading remote to 4083 now [05:30] seb_kuzminsky: remote needs to be at least 4061 [05:31] seb_kuzminsky: "missed it by *that* much" ;) [05:31] heh [05:31] that's what i get for hopping off of the nightlies and down to the boring old stuff in the "release" ppa ;-) [05:32] seb_kuzminsky: also, the network protocol is in a fair bit of flux in bzr.dev atm. So until 1.13rc1 is out, you may need to keep client and server on the same version of bzr.dev to avoid weird smart server failures. [05:32] ok thanks for the heads up [05:32] (but on the plus side it ought to be noticeably faster) [05:33] ooh, thanks! [05:33] seb_kuzminsky: if you *do* get weird failures though, please let us know :) [05:33] oh you'll know [05:34] ;-) [05:34] :) [05:35] looks like it worked [05:35] seb_kuzminsky: great [05:35] aw yea [05:35] thanks spiv! [05:36] yeah that's all working just fine :-) [05:36] yay, thanks again! [05:36] ok i'll be back when it breaks next time ;-) [05:37] seb_kuzminsky: good :) [05:42] lifeless: the three calls are [server] open_branchV2, [client] open, [server] get_stacked_on_url [05:42] spiv: right, [05:42] open_branch didn't open the branch [05:43] Right. [06:11] spiv: I need to go [06:11] spiv: good luck with the branch [06:11] lifeless: not a problem [06:11] lifeless: happy travels [06:15] yes bye lifeless [06:25] spiv, i have a failure now in test_clone_unstackable_branch_preserves_stackable_repo_format [06:26] because RemoteBranchFormat, at least in the version of trunk that i've merged, claims not to support stacking [06:26] whereas with this change it will [06:26] does this ring any bells? [06:28] poolie: hmm [06:30] poolie: that does ring some bells, in that a recent landing touched that code. [06:30] i think in general robert was going to make tags be handled by making teh format depend on the particular branch [06:30] not sure that's a great idea [06:30] at the moment it says it always supports tags [06:30] so i'm going to make it consistent with that and hope :) [06:30] poolie: but IIRC the change was that it was going to rely on the underlying format to decide [06:31] Right, that's what Robert's patch for tags does. [06:31] (make the format of the branch handle it) [06:31] Not sure what the overlap with tags and stacking is here though? [06:37] well, they're both capabilities that are determined by the real on disk format === mike is now known as indy34 [08:01] So now that the 'authors' revision property has been added, 'author' is no longer written, right? Isn't that bad for backwards compatibility with older clients? [08:01] I mean, it's not a big deal, but still. [08:05] * igc dinner [08:06] i thought that we changed it to write out only the additonal authors? [08:06] but you should raise that on the list? [08:13] jelmer: You mean LP's email notifications? I don't know. I know they work for lp:~jelmer/bzr-svn/0.5-mirrored. [08:15] poolie: regarding the repository acquisition policies, yes, it is a bit weird. [08:16] spiv, i'm going to try to move it [08:16] poolie: lifeless lands some changes to allow Branch.clone and others to accept a repository_policy kwarg [08:16] For similar reasons. [08:22] hm i remember seeing that but i can't find the mail [08:28] ah ok [08:28] so, i'd like to clean it up but it's not all that bad [08:29] we always create a bzrdir there before we think about stacking [08:29] poolie: You thought it was changed to what? [08:30] but it doesn't really matter because there's only one relevant bzrdir format, and we can choose to make a different branch format before the branch is created [08:30] i'd say it's not great though [08:30] Oh, it only uses 'authors' when multiple authors were passed. That's not so bad, then. [08:30] Peng_, i thought the issue had been taken into account [08:31] Wait, never mind. [08:31] poolie: ISTM commit only sets 'authors' now. [08:41] beuno: Will Loggerhead try to perform syntax highlighting on gigantic files? IIRC, Mercurial limited it to smallish files. [08:56] spiv if you're still here [08:56] or anyone really [08:56] these likes look backward to me [08:56] 233 require_stacking = True [08:56] 234 result._format.require_stacking() [08:56] uups [08:57] 232 if not require_stacking and repository_policy._require_stacking: [08:57] 233 require_stacking = True [08:57] 234 result._format.require_stacking() [08:57] oh i see === montywi|zzz is now known as montywi|talk [09:20] poolie: Mailing list message sent, fwiw. [09:38] hey, anyone have any idea why all of a sudden, I can do a bzr up but not a bzr st (permission denied) [09:38] what's in the traceback in ~/.bzr.log? [09:39] one sec [09:42] poolie: nothing sinister [09:42] http://rafb.net/p/EMHVs538.html [09:42] and an strace sees it trying to find files, but getting ENOENTs back [09:42] but it says permission denied? [09:42] yep [09:42] how strange [09:42] how about bzr -Derror st [09:43] running selftest . [09:43] huh? [09:43] one sec [09:45] poolie: http://rafb.net/p/qMF0NF83.html [09:47] ok [09:47] this is probably because there's a directory in your working tree that you can't read [09:48] try just ls -laR [09:48] ah, gnupg [09:48] http://rafb.net/p/6yTDaq68.html [09:49] yep [09:50] o_O [09:50] also, bug 338653 [09:50] Launchpad bug 338653 in bzr "OSError is printed without a useful filename" [Medium,Confirmed] https://launchpad.net/bugs/338653 [09:50] the permissions are set to the user though [09:50] ah, no execute on the directory [09:51] ok, now getting "no handlers found for logger "bzr" [09:51] with which version? [09:51] 1.12 [09:51] (on intrepid) [09:54] thanks for the help mpool [10:20] vila: do you have some time to give CHKInventory some test love? [10:21] I think we need tests across both Inventory & CHKInventory for *all* the read-only APIs [10:21] the mutation APIs need to be tested separately of course [10:23] we then need to test all of the above for each of the serializer combinations, e.g. chk16, chk255 [10:23] Damn mutants! They're everywhere! Oh, wait... [10:24] vila: what do you think? [11:03] Blimey, DVCS 4tw [11:03] svn working copy of 4 branches : 713 MB on disk [11:03] bzr checkouts, plus the full history of the entire project : 484 MB total [11:54] awilkins: Eh. svn's lack of working copy compression FTL. They could do better than 484 MB if they wanted to. [11:59] Yeah, and the 17,840 files vs 5,864 isn't too hot either [12:32] Gnnnnargh my frickin mother-in-law has put all the cardboard in the recycling bin even though there is a fricking sign on the lid that says not to [12:32] Now I'll have to empty the fricking thing out or get fined or something [12:32] * awilkins is sorry for the noise [12:33] I thought cardboard was recyclable o.O [12:34] are you sure the sign says not to put that in there? [12:34] Yes, there is a separate pickup for cardboard/paper [12:34] ah [12:34] This is the plastic/cans bin [12:34] ahhhh, I get it [12:35] * Toksyuryel 's place just has one bin for all the recycling, heh [12:35] * awilkins wonders if they take organic waste, like dismembered^W old meat. [12:41] nah, those go to the soylent green facility :P [12:54] hiya [12:57] so, has anyone thought about getting something like darcs's patch algebra for bzr? Darcs is absolutely neat in that branches sort of magically fall out of related changes, and that you can freely change past patches in non-conflicting ways, but the UI they add to it that tries to pass for a VCS is unbelievably shitty [12:59] hard to do something like that in bzr where each revision has it's parents (the history forms a graph), so the order can't be changed [12:59] I guess, that was also a question of "how very hard would it be to do?" [13:00] because the patch algebra has some really cool consequences (at least as long as you don't get into exponential time corner cases :) [13:00] by hard I meant impossible :) [13:01] like the fact that darcs is the only VCS that gets merges right where a series of patches reverts changes textually, but not semantically [13:01] the patch theory is based on the fact that you can manupulate the order of patches, which in bzr you can't [13:02] I know, so bzr would have to be hacked quite badly. I supposed as much. But would it really be completely impossible to allow reordering them? [13:03] using the DAG model bzr uses, yes [13:03] darcs has ordering too. It just has rules for generating a new order from the old one [13:04] history in the DAG model is immutable, every state (=revision) strictly depends on everything that happened before [13:04] if you change one piece, everything breaks [13:04] so what is the model darcs uses? As far as I understand things, it's DAG + algebra for generating new, semantically equivalent DAGs [13:05] the main difference is that it's main object are patches [13:05] oh [13:05] in bzr it's states (revisions) [13:06] the fact that data are delta compressed is just implementation detail [13:06] hmm [13:06] you can see it as if you had one full directory of files for each revision [13:07] yeah, I get that [13:14] Another question: is it possible to discard old revisions before a specified revision? I split a tree and I want to get rid of the revisions before the split. [13:17] just a few lines above I explained that something like that is not possible :) [13:18] hehe [13:18] you can make a new branch, without the revisions [13:18] but the revisions you want to keep will not be identical, they will just look similar [13:18] oops! [13:19] So how would I do that? [13:20] I don't know of any straightforward way, unfornatunatelly [13:21] is there any way to get from python api revisions where single file was changed ? [13:21] Oh well. I suppose I can manually create a new repo with the files as they were at the time of the split. [13:22] pigmej: yes [13:23] log.find_touching_revisions() [13:24] Tak: hmmm [13:24] I wouldn't use log for that, but on the other hand I don't know what's the currently used API for that [13:24] log is for whole branch ? [13:24] I'm sure it can be done by walking the revision tree if you prefer [13:25] pigmej: it also accepts a file id [13:25] Tak: it can be done without walking the whole tree, every file has it's own tree stored [13:26] I just don't know the current API [13:26] What the? My Loggerhead instance is freaking out. "built revision graph cache: 3762.8832850456238 secs", and it's out of idle workers. [13:26] It's good to know that condition doesn't melt my VPS. :) [13:26] becouse i'm afraid that checking whole tree will be wrong idea ( becouse of performance ) [13:27] It doesn't want to shut down, either, but that hardly makes it worse... :P [13:29] hey, i want to check out a PPA in launchpad with olive. What url do i have to use for "branch"? [13:30] lp:bzr-gtk [13:30] oh wait, PPA? [13:30] do you want to install olive from PPA or get the developmnent branch of olive? [13:31] no i want to modify a package in an PPA using olive. Isn't that possible? [13:31] not sure if I understand, sorry [13:32] PPA is a way to build ubuntu packages, it has nothing to do with olive [13:32] Hmm in docs I find only logs method... [13:33] ah okay thanks luks [13:44] the fastest way to get revision message ( commit message ) [13:44] revtree=repo.revision_tree(rev_id) [13:44] revision=revtree.inventory [13:44] revision.message ? [13:49] repo.get_revision(rev_id).message [13:49] or get_revisions if you need more of them [13:50] calling get_revision multiple times is way slower than get_revisions [13:53] D'oh, I think I killed Loggerhead at the exact time when it started killing the hung threads itself. === jelmer_ is now known as Guest87629 [13:58] luks: thanks [13:58] i need to call it more than one time [14:23] jelmer: I've upgraded bzr to the latest released and also the bzr-svn [14:23] but still my svn password is not cached [14:23] I checkout the repository directly with bzr, not svn [14:23] mattions: Did you force svn to cache the password? [14:23] can be that the problem? [14:24] I run svn ls [14:24] but it doesn't ask for the password [14:24] is it correct? [14:24] mattions, ah, you only need passwords for committing? [14:25] yeah [14:25] mattions: So I guess you would have to do a commit with svn first [14:26] but the problem is the directory is not a working copy of svn [14:26] mattions: That's a workaround unfortunately [14:26] ok, so you suggest [14:26] wipe out everything [14:26] mattions: There's a bug in bzr itself that makes it doesn't support password caching [14:26] checkout with svn [14:26] mattions, no, just make a temporary checkout with svn and do a commit therre [14:27] mattions, then remove that temporary svn checkout [14:27] and everything should work [14:27] or right, I'll give a go [14:29] no, it doesn't work [14:29] it is normal that ask the password 4 times? [14:43] Hi, I try to download with this command "bzr branch lp:bpierre-config-vim .vim" and I get this error message "You have not informed bzr of your launchpad login. If you are attempting a [14:43] write operation and it fails, run "bzr launchpad-login YOUR_ID" and try again. [14:43] bzr: ERROR: Target directory ".vim" already exists." [14:44] someone can explain me what does it mean, please ? [14:44] msoulot: Try backing up your current vim configuration: mv .vim .vim-backup [14:46] ok thanks but what this sentence means "You have not informed bzr of your launchpad login. If you are attempting a write operation and it fails, run "bzr launchpad-login YOUR_ID" and try again." [14:46] msoulot: If you have a Launchpad ID, you have register it with bzr doing: bzr launchpad-login [14:47] It probably comes up because you're branching from lp: [14:48] mattions, sorry [14:48] mattions, doing a "svn commit" in a svn working copy didn't work? [14:48] Or it didn't cache the password? [14:49] I got an account on launchpad and i tried "bzr launchpad-login msoulot@gmail.com" and i got this error message "bzr: ERROR: The user name msoulot@gmail.com is not registered on Launchpad." [14:49] do more recent versions of bzr-svn support externs? === montywi|talk is now known as montywi [14:49] Tak: no - it technically can't [14:49] Tak, since bzr doesn't support externs [14:50] ever? [14:50] jelmer: it didn't cache the password [14:50] it worked [14:50] mattions, do you maybe have you svn set up to not cache passwords? [14:52] well, how I can discover that? [14:52] ~/.subversion/config IIRC [14:52] with gnoem svn the password is cached [14:52] ah [14:52] we may not be loading that yet for bzr-svn [14:53] default is yes [14:54] so yes is able to cache that [14:54] actually bzr ask me the password 4 times when I do a commit [14:54] 2 times when I do an update [14:55] so I should fix subvertpy/bzr-svn to also use the gnome keyring svn auth provider [14:55] but here I am using another subversion [14:56] not GNOME related [14:56] I never tried to use bzr with GNOME svn [14:56] you're using svn 1.6? [14:58] mattions, so bzr asks for a password when updating and svn does not? [14:58] yes [14:58] svn 1.5.1 [15:00] mattions: Can you access the root of the svn repository without a password? [15:01] no, I need to authenticate to access the svn [15:01] is not public [15:03] hmm, so the password *is* cached by svn but not found by bzr? [15:06] exactly [15:07] another interg ont eh temporary checkout if I use bzr to update or commit [15:07] the password is not requested [15:09] hey ... does anyone know of an (unofficial) debian package for baz-import ? [15:10] isn't baz-import in bzrtools? [15:10] seems to be omitted :-( [15:11] are you sure? because I see it in http://packages.debian.org/sid/all/bzrtools/filelist [15:11] ops, I've seen the sentence I wrote before is a little bit mispelled [15:11] msoulot: Use your LP username (like in https://launchpad.net/~username), not your email address. [15:11] I wanted to say that from the temp checkout the password is not requested for the update or the commit [15:13] huh ... I guess that's what I get for using experimental :-( [15:14] ... but pybaz is apparantly not available anymore anyway? [15:14] * SamB doesn't use experimental for much, just a package here and there [15:14] mattions, can you check where the password is cached? [15:15] luks, SamDB: It's no longer in bzrtools [15:15] was removed recently [15:15] well, it is in 1.5 :) [15:15] luks, yes, aaron split it out [15:15] and (sane) debian has 1.5 [15:15] squeeze won't [15:16] mattions, I would expect ~/.subversion/auth [15:16] yes is there [15:17] mattions, what version of subvertpy are you using? [15:18] (0, 6, 1) [15:22] jelmer: on synaptic the package (python-subversion) shows up as 1.5.1dsfg1-1ubuntu [15:22] mattions, python-subversion is not used by bzr-svn [15:22] and not the same thing as subertpy [15:22] try looking at the bzr-svn package in synaptic? [15:22] then go from there? [15:23] I installed bzr from the PPa [15:24] but if I search for the subvertpy I can't find the package [15:24] hello everyone. [15:24] hmm, bzr-svn used to depend on python-subersion [15:24] mattions, python-subvertpy [15:24] SamB, no longer as of 0.4.10 [15:24] I installed bzr-gtk on ubuntu 8.10 from the default repository. Do I need to logoff and login to use nautilus-bzr? [15:24] jelmer: that's odd [15:24] 0.4.10-2 seems to ... [15:25] SamB, maybe 0.4.11 [15:27] jelmer: 0.6.1-1~ppa1~intrepid1 [15:28] mattions, Hmm, no idea then sorry [15:28] gtg [15:28] k, no probl [15:32] jelmer: it looks like the BzrTools wiki page needs to be updated to point at the new home of baz-import [15:33] (since a number of other pages link there in connection with baz-import) [15:34] hmm, what I'd *really* like is support for foreign tla/baz branches [15:34] I actually want to look at emacs' history including merges without having to use tla *shudder* === montywi is now known as montywi|food === montywi|food is now known as montywi|weekend [16:27] is there a nice way to do git-style branch-switching ? [16:27] SamB: There's the switch command [16:28] Works best in a checkout of a branch in a no-trees repository [16:28] (lightweight for preference) [16:28] huh. [16:28] It will locate siblings so you can do [16:28] bzr switch foo # my repo contains foo and bar and I am in a checkout of bar [16:29] It doesn't have the "branches hidden inside your clone" thing [16:29] This is a point of contention for some. [16:29] I myself don't mind it but think it would silence many critics if there was a way of supporting either method [16:31] is there a howto somewhere? [16:36] Off the top of my head, I can't recall. It goes.... i) make a no trees repo (with bzr init-repo) ii) branch something you are interested in into it iii) make a branch for a feature iv) use bzr co --lightweight to grab a working tree of it v) switch that at will === ubott2 is now known as ubottu [16:46] what bzr app includes bzr-handle-patch? I'm guessing what ever one it is causes my context menu to have "open" on top(nothing ever opens and than have "open with"(is all i want to use open for) [16:47] ah bzr-gtk [17:01] peculiar! the wiki is making empty elements instead of using or ... [17:09] Goes anyone know where the error at http://paste.ubuntu.com/127303/ could be from? [17:10] A proxy? The web server? === gorozco is now known as p4tux [17:35] awilkins: I made a wikipage at http://bazaar-vcs.org/GitStyleBranches -- I wonder if the HOWTO I desire will magically appear ? [18:13] here is the command and output. it should not try to grab upstream tarball since i already have it. looked in changelog nad it is how it should be. http://pastebin.mozilla.org/631007 [18:13] hi [18:14] can I make a stacked branch when branching from a branch stored in a shared repository? [18:15] ignas: Sure? [18:16] Peng_: then why am I getting [18:16] Source format does not support stacking, using format: '1.6' [18:16] Packs 5 (adds stacking support, requires bzr 1.6) [18:16] while on the server i am getting: bzr: ERROR: The branch format Bazaar-NG meta directory, format 1 is already at the most recent format. [18:16] Does it still work? [18:16] And when are you getting that error? When you try to "bzr upgrade"? That's because the default format is pack-0.92. 1.6 is newer. [18:17] I don't know about stacking, so I can't help much. Does the source repository have to support it? [18:17] oh, so if I want the newer format I must upgrade to the newer format explicitly? [18:18] something is weird, both the stacked branching and lightweight checkout (i am doing it through http) are trying to download the full repository [18:18] and i don't really want to have to do that (it's 70 megabytes) [18:21] I doubt it will download the entire repository, but it will have to download quite a bit of it to pull out all of the data it needs. === bac is now known as bac_afk [18:29] Peng_: kind of annoying, as that bit is like 20 megabytes, but it's downloading it at 30 kb/s, while checking out does 70mb at 200kb/s so I kind of don [18:30] don't know what I am gaining ;) [18:48] ok, seriously, bzr co --lightweight took 6 minutes and takes up 18 mb, bzr co took 5 minutes and takes up 51 mb (got 200kb max download speed) [18:49] seems like lightweight checkouts are of any use only if you are very very bandwith constrained, and will do only 1 checkout ever [18:50] if you want to get a branch of the same project too - shared repository will be both more space and bandwith and time efficient than 2 lightweight checkouts... [18:51] What about "bzr branch --stacked"? [18:52] 1.) Like I said, I don't know much about lightweight checkouts or stacking. 2.) This really sounds atypical. What version of bzr are you using? It's probably been improved (especially in the release coming up next). [18:52] it is doing at least as much work as lightweight, but I don't want to spend the 6 minutes to find out for sure [18:52] bzr 1.12 [18:52] and my project has a looong history [18:52] Huh. [18:53] Well, I'm surprised, but I don't have anything else to add. [18:53] it's quite sad, but I am not surprised [18:53] Erm, how did you count how much bandwidth was used? [18:53] bzr has a progress bar that shows how much was downloaded [18:54] also du -sh matches that number [18:54] for a lightweight checkout at least [18:54] mostly matches ;) === Mez_ is now known as Mez [19:31] To any developers available, will Bazaar be participating in Google Summer of Code? === bac_afk is now known as bac [20:25] Any bazaar developer launchpad team members online? I volunteered to be the manager for 1.13 and I need a developer to push the changes into PQM [20:31] whoa, there seems to be some issue with adding large files in bzr.dev [20:31] I just added a 166 MB file to a branch, and Python shot upward of 1 GB of real memory before completing === _thumper_ is now known as thumper [21:26] morning igc [21:26] hello [21:28] hi poolie [21:29] I'm a bit surprised to see you around on your weekend [21:29] trying to get the 1.9 patch finished? [21:29] hi jam, poolie [21:29] and to help bob tanner [21:29] i have to go out so i don't know if i can finish it today :/ [21:29] igc: I responded to a couple of your bbc patches [21:29] jam: thanks very much for working on the chk-map bug. I'm testing it now [21:30] i was kinda hoping someone would look at the traceback and say "oh, obviously you just need x" :-) [21:30] I also have a proposed patch which might help your performance [21:30] as InventoryDirectory.children() didn't seem to be using _entries_cache properly. [21:30] poolie: well I did see you return unconditionally true for Remote* [21:30] which seemed a bit fishy to me [21:31] it was previously unconditionally false :/ [21:31] since that class inherited the default [21:31] that seems so strange though [21:31] judging by the test name [21:32] it looks like we should be using an old-format [21:32] and have it not try to stack *at all* [21:32] and it is checking, and naturally failing [21:32] did we get rid of a 'clone_on_transport' implementation? [21:34] jam: so I got two patches with the same name - one at 7.20 and one at 7.23 (it's 7.34 now) [21:34] igc: one is against bzr.dev [21:34] the other against brisbane-core [21:35] jam: do I just apply the last one then? [21:35] mailman thoughtfully noticed that the first patch was 800k+ [21:35] igc: yeah [21:35] to brisbane-core? [21:35] they are the same content [21:35] ok [21:35] (bazaar@ rejected my first post as being too big) [21:40] jam, yep, in trunk RemoteBranch definitely always says it doesn't stack [21:42] poolie: So _ensure_real() seems the right trick, but in the end, I think that would require doing "bzr branch lp:XX lp:YY" for it to ever come into play [21:43] i think this test is actually branching one remote branch to another [21:43] hm [21:43] i guess it would be better to avoid ensure_real and to use the network name, if we know it, to find the equivalent local format object and then ask that [21:44] poolie: isn't that what _custom_format is about? [21:44] Anyway, to get things *landed* I would go with _ensure_real() [21:44] rather than spending a lot of time, the day of an RC [21:44] Or set it back to False if that doesn't cause other problems [21:45] poolie: ah you know what... that sort of makes sense. We are testing that if the source format is too old, we don't try to stack. [21:45] And then it is layering RemoteBranch on top of that [21:45] and by changing False => True [21:45] it is now trying to stack, even though the real format doesn't support it [21:45] and thus the test is failing [21:51] you're talking about test_clone_ignores_policy_for_unsupported_formats? [21:51] poolie: that is the test you showed was failing, yet [21:51] yes [21:52] anyone working on a fix for the md5/sha Deprecation Warnings /w python 2.6 in jaunty? [21:53] fta: I thought vila had a fix for that a while back [21:54] fta: specifically, I see code like:http://paste.ubuntu.com/127469/ [21:54] It may just be that the version in Jaunty is older than that patch [21:54] fta: what version is there? [21:54] (It could also be that there is other code that is importing md5/sha1 that we missed) [21:54] !info bzr jaunty [21:54] bzr (source: bzr): easy to use distributed version control system. In component main, is optional. Version 1.12-1build1 (jaunty), package size 5077 kB, installed size 17328 kB [21:54] bzr --version [21:55] I would have thought 1.12 had that... :( [21:55] there are a couple of them with similar failures [21:55] but all i think to do with the intersection of policy with old formats [21:55] hm, i should have checked what that test does in trunk [21:55] maybe it just skips [21:55] ah ok, i see now what you meant about ensure_real [21:55] possibly it should fall back to ensure_real if it doesn't know the custom_format [21:55] fta: though I also saw some discussion about things like bzr-pqm causing the problem [21:55] but the thing is this is called on the format, not the branch [21:55] and that just required another jaunty update [21:55] because it was an old python package [21:56] poolie: so punt and just continue to return False [21:56] fta, i have a bug about it in python-crypto [21:56] RC is *today* anyway :) [21:56] jam, i'll try it [21:56] if it actually works its fine but i think i had more failures that way [21:58] jam: your patches have improved things a lot thanks [21:58] igc: /cheer [21:58] If the directory cache helps [21:58] go ahead and land it [21:58] I just wanted someone to actually run the code before I did [21:59] jam: *but* we're still slow - 1m6s vs 40s for gc-chk255 vs 1.9 over 1k revision in wordpress [21:59] igc: If you are having to call iter_entries() [21:59] then you are going to probably be slower [21:59] why do you need to read the whole inventory? [21:59] that's with all your patches ad my iter_non_root_entries() which is still a big win [21:59] (That kind of code is what got us into trouble in the first place) [22:00] well, the inventory layer is now ok [22:00] The time is evenly spread around chkmap.apply_delta [22:01] igc: If you want, you can try setting _FAST = True in groupcompress.py [22:01] And see how much that effects things [22:01] jam: tell me about parent_id_basename_to_file_id is a good idea [22:01] jam: I see you're planning to make it non-optional [22:02] igc: it is already non optional [22:02] all formats have it [22:02] --dev3 was the only one that didn't [22:02] and robert and I agreed it could just go [22:02] thinking out loud, do we really need it for 1000s of historical revisions or could we generate it the first time it was required? [22:02] igc: it changes only when you have a rename/add/delete [22:02] so for 1000s of revisions, you get 10 changes [22:02] not a lot of overhead [22:03] jam: well every revision has one of those doesn't it? [22:03] igc: every revision has one, but they are all the *same* [22:03] jam: how does it speed lookups? [22:03] the root chk pointer doesn't change [22:03] unless the tree shape changes [22:03] (rename/add/delete) [22:04] igc: for a specific example, the python 40k revisions, has about 300k entries in id_to_entry, but only 12,000 in parent_id... [22:05] igc: it speeds up mapping "path" => file_id [22:05] id_to_entry is purely file_id => entry [22:05] so you have to find an entry [22:05] then load its parent [22:05] jam, ok, changing it back to return false from supports_stacking seems to be making things pass [22:05] fingers crossed [22:05] etc [22:05] probably by just not running those tests :/ [22:05] More importantly, to go from a parent to its children [22:06] you have to iterate the *whole* inventory [22:06] poolie: no, it says "clone ignores stacking" [22:06] and it passes [22:06] poolie: because you said it doesn't support stacking [22:06] thus we ignore the stacking policy [22:06] jam: path2id for CHKInventory is currently a copy of the code in Inventory? [22:06] ok so not literally TestSkipped [22:06] but it's not testing the real case which is that the remote branch may in fact be stacked [22:07] igc: The issue is *specifically* InventoryDirectory.children() [22:07] if you look at the code path I "removed" [22:07] it walked the whole inventory [22:07] looking for "entry.parent_id == self.file_id" [22:07] because we don't have that info stored any other way [22:07] without the parent_id_basename_to_file_id map [22:08] poolie: I don't know what other tests you are looking at, but the one you posted as failing [22:08] isn't doing that [22:08] I'm sure there are others that probably fit what you describe [22:08] and I think it would be great to address them in 1.14 :) [22:09] jam: ok - children lookup certainly needs to be fast [22:09] jam: I'll land your chkinventory-children patch now [22:21] igc: I keep forgetting to ask... How's the weather in brisbane? [22:22] hi [22:22] I'm getting some warnings about md5 and sha python modules, I thought you would like to know [22:23] jam: absolutely beautiful right now [22:23] that modules are deprecated (the warning says that) and you should use 'hashlib' now [22:23] poolie: I just tried to update the BrisbaneCore page with some ideas about "major blockers". I don't know that I got everything, and it probably isn't fully polished. But that is what I've thought of so far [22:24] Turl: there seem to be some issues with the python-crypto package in Jaunty [22:24] which we depend on [22:24] hopefully that will get resolved soon [22:24] igc: What's the temp? (So I know what clothes to pack) [22:25] jam: looks like there's some rain on the way but otherwise nice: http://www.bom.gov.au/products/IDQ10095.shtml [22:25] ok jam, I thought I would let you know about this :) [22:25] igc: I should also mention that jelmer found brisbane-core to be *vastly* faster for bzr-svn converting OOo. Something like 30hrs to do a full conversion, versus 30hrs for the first 10k revisions. [22:26] Turl: thanks. It is a known issue, though I haven't personally followed closely. [22:26] great [22:27] np jam [22:27] that was bug 337073 [22:27] Launchpad bug 337073 in python-crypto "python-crypto uses sha module that's deprecated in python2.6" [Medium,Confirmed] https://launchpad.net/bugs/337073 [22:27] am: I saw that result from jelmer - it's very promising [22:27] jam: ^^^ [22:27] igc, poolie: have a good day. I'm done for now. I may sign on later tonight just to do a quick review before I leave tomorrow, but no guarantees [22:27] igc: so that brings back the question of why you ever have to deal with the whole inventory. [22:28] igc: I should also mention that "time bzr fast-export" of my mysql-525 stuff was down around 1 minute. which is == git fast-export on the same data [22:28] igc: that said, "time bzr repository-details" which extracts everything to fultexts, and analyzes chk pages [22:28] is 15s [22:28] so there is still some room [22:28] (just extracting the texts, with no sha sums, etc, is around 6s) [22:28] jam: yes, fast-export seems pretty good and I've done zero profiling/tuning on it [22:28] Is there someway to turn off ensure_config_dir() ? [22:28] ensure_config_dir_exists() [22:29] jam: I'm only dealing with the whole inventory when loading texts. I'll see what the latest repo code does there [22:29] jam, ok, have a good night [22:29] i have to go and run some errands [22:30] that test is still failing [22:30] i may poke at it later but it may miss at least rc1 as i expect bob will do that soon [22:31] we're working on a server that submits to a bazaar repo. It runs as apache. [22:31] When we run this: work_tree.smart_add([self.path]) It tries to create a .bazaar directory in apache's home dir. [22:31] jam: _install_revision still walks the whole inventory via iter_entries() [22:32] jam: fast-import uses a parameterized version of that code [22:32] igc: consider how InterDifferingSerializer does it [22:32] which is able to use _make_delta etc and not need full inventories [22:32] I don't know what you need, I just know that if you have to walk the whole inventory [22:32] things will be slow [22:32] so we need to think if there is a way around it [22:34] jam: right. I'm not sure whether jelmer was going via repo.install_revisions() or not [22:35] if he was, he would have hit the iter_entries() speed issue that existed until just now? [22:37] igc: no, I'm not using repo.install_revisions() [22:38] igc, I'm using add_revision(), create_by_apply_delta() and directly accessing the texts VFs [22:42] jelmer: so IIUIC, install_revisions() is walking the inventory to build the per-file-graph? Are you doing that some smarter way? [22:43] igc: bzr-svn stores the per-file graph [22:43] and for non-round-tripped revisions, subversion provides the necessary data [22:44] so the OOo conversion to development5 only works if bzr-svn is used? [22:48] igc: Not sure I understand [22:49] jelmer: ping [22:49] igc: The conversion doesn't require round-tripped-revisions or anything, it works with a vanilla OOo SVN repo [22:49] rocky, pong [22:50] jelmer: i decided in an effort to force myself to understand things more i would rewrite get_history() for BzrFileNode in TracBzr (ti's currently what's breaking on bzr 1.12 anyways) ... and i've getting a better understanding such that i can populate the log view properly... [22:51] but my revision identifiers are nasty ... they are branchpath,fileid [22:51] and in the trac log view that looks horrible [22:51] rocky, branchpath,revid? [22:51] sorry yes [22:51] the branch path is fairly long, and the revision_id is huge [22:52] so it really messes up the log view display [22:52] is there a more sane way to reference a rev? [22:54] jelmer: I'm trying to work out how you converted the OOo repo so quickly to development5-subtree format [22:55] jelmer: fast-export is currently slower on the new formats [22:55] s/export/import/ [22:55] igc, ah [22:55] igc, yes, bzr-svn would be required for the improved performance [22:55] rocky, path,revno? === UdontKnow is now known as UdrunKnow [22:56] what's the diff between a revno and a revision_id ? [22:56] igc, I was also using an improved version of brisbane-core, with another patch [22:56] rocky, a revno is smoething like "2" [22:56] rocky, a revision id is something like "jelmer@samba-org-20083424782362386-0fjksdhgfkjsdh" === UdrunKnow is now known as uDrunkNow [22:58] jelmer: right, i understand that they look different but what i mean is what limits one versus the other... why have a revno and a revid ? [22:59] rocky, revno is more human readable [22:59] rocky, it's only unique to a particular branch though [22:59] revid is used internally in Bazaar and globally unique [23:00] also, revno's are sortable [23:00] so revno 42 is always older than revno 43 [23:00] so revid's are meant to be actual uuid's ? [23:01] rocky, they are globally unique but not like RFC4122 [23:01] define "global" :)\ [23:02] rocky, e.g. bzr-svn uses the UUID of the svn repository and the revision number of the subversion commit for the bzr revid [23:02] rocky, global as in the same revid is supposed to always point at the same revision [23:02] independent of what branch or repository it is in [23:03] rocky, e.g. try running "bzr log --show-ids" in one of your branches [23:03] ah cool [23:13] jelmer: ok, in any event, the log view works now and doing diff between revs on log view works and clicking on a rev link works... bt clicking on a changeset link doesn't yet work [23:14] cool [23:15] jelmer: here's a question... in a branch, does revno *have* to start with 1 and is it guaranteed not to skip revno's ? [23:15] rocky, there are functions in bzr for looking up the revno [23:15] rocky, ideally you should be using those rather than calculating them yourself [23:16] that would also do caching when it's available [23:16] i'm only asking because i found code inside bzrlib that is adding up it's revno's by itself ;) [23:16] in bzrlib.log [23:16] they can also get quite complex if they're not on the mainline [23:17] the whole dotted revno thing right? [23:17] yeah [23:45] igc: This is all the more reason to move this logic into a Importer object in bzrlib :-) [23:50] jelmer: Agreed! Once I get this version working fast, I'll do that. Next week's sprint will be a good time to talk to lifeless and jam about it