[00:32] woohoooo inbox zero [00:39] mwhudson, grats [00:50] is there any chance we could get rid of the 'no new merge proposal while one is outstanding' limit of code reviews? [00:51] I'm having to lie to the system at the moment [00:53] lifeless, perhaps... [00:54] so my work flow is [00:54] lifeless, what are you trying to do? [00:54] hack on a branch a lot [00:54] send of bits to be reviewed when I stop [00:54] like this morning, did an hour on the test suite [00:54] sent it off [00:54] code-reviews complained at me that there was a MP already open [00:54] so I go to that MP https://code.edge.launchpad.net/~lifeless/bzr/test-speed/+merge/10720 [00:55] tell it its merged (its not, just approved) [00:55] http://pqm.bazaar-vcs.org/ is busy merging it [00:55] then send in my new mp [00:55] https://code.edge.launchpad.net/~lifeless/bzr/test-speed/+merge/10775 [00:55] I see. [00:56] sounds not entirely dissimilar to a race condition [00:56] with BB we just said 'send -r -2..' [00:58] hmm. [00:58] putting the constraint on branches, rather than on, say, revision ids, seems to be the mistake here. [01:00] I think its fluid [01:01] but yes, thats part of the thing driving the issue [01:02] If I were to put it as a use case, it would be: 'a cherry pick merge submission sent while an earlier submission on the same branch is active should be accepted and shown separately' [01:02] hmm [01:02] two scenarios actually [01:02] the second is [01:02] 'a merge subission sent while an earlier submission on the same branch is active adds to that (or resubmits automatically?) rather than being rejected' [01:15] jml: ^ what to do with this [01:16] lifeless, sorry, the phone rang... [01:16] brain occupied at present :) [01:22] jml: yes, I agree, I mentally think of merge proposals as being for revisions not branches (as branches can change, but the diffs (and reviews!) don't automatically change with them). [01:22] Diffs will start changing soon, won't they? [01:22] wgrant: yes [01:22] * mwhudson lunches [01:22] spiv: the followon changes can either be an extension (fixups) or new (different change) [01:22] jml: and I've also wanted what I think lifeless is asking for here, to be able to file a series of merge proposals off one branch. [01:23] I'd be wary of keying too closely into revision id [01:23] lifeless: agreed. [01:23] spiv: uick call? [01:23] lifeless: sure [01:24] I'd be happy for LP to make it obvious that there are more revs since the diff was generated, for instance. [01:24] And for LP to make it easy to refile for the new revs. [01:26] is this the right irc channel for mailing list administration? [01:26] it's close enough :) [01:27] jml, my loco is having problems with it's list :( [01:27] we can't access it [01:32] what's actually happening? [01:34] binarymutant: Aren't LoCo mailing lists on lists.ubuntu.com? [01:34] Launchpad has nothing to do with lists.ubuntu.com. [01:34] ty for the info wgrant :) [01:35] Maybe #canonical-sysadmin, but I'm not sure. [01:35] Or #ubuntu-locoteams. [01:35] thank you === gary-out is now known as gary_poster [02:30] * mwhudson reappears [02:31] spm: hello [02:31] mwhudson: heyo [02:32] spm: can i get you to run some queries? [02:32] mwhudson: only if you use the magic word [02:33] spm: select count(*) from codeimport where git_repo_url like '%sourceforge%'; [02:33] spm: please [02:33] bzt. wrong. word is "NOW!!!!" :-) [02:33] :) [02:50] sinzui, you around? [02:50] I am [03:47] Does anybody else find 3.0 text to be very squished? It's all a lot closer together and less readable than 2.0. [03:50] wgrant, it's hard for me to say, since Firefox 3.5 seems to have different font behaviour to Firefox 3 [03:50] got a couple of URLs to compare and contrast? [03:53] jml: Look at the comment at https://code.edge.launchpad.net/~wgrant/launchpad/structural-subscription-security/+merge/10776/comments/28159/+reply. But it affects non-monospaced text as well. [03:53] * wgrant finds a good example. [03:56] (does anybody want to land that branch for me, since gary_poster's concerns are unfounded and he's gone?) [03:57] wgrant: sure [04:01] mwhudson: Thanks. [04:05] mwhudson, oh, and not having the actual failures in the buildbot failure emails :) [04:06] kfogel, hello [04:06] jml: hey [04:06] and in other news, if people could stop pushing over non lefthand parents to lp-dev-utils trunk... [04:07] mwhudson: ? [04:07] mwhudson: I noticed that going on in lazr.restful a lot. [04:07] kfogel: revno's of lp:lp-dev-utils are a bit useless [04:07] because people merge their branches by merging from trunk, then pushing over trunk [04:08] It also results in "Merge from trunk" commits down the LHS of trunk. [04:08] right [04:08] mwhudson: it's hard for most people to remain that conscious of the ins and outs of their vc system, I think. [04:09] mwhudson, I don't recall doing that, but my sincere apologies if I did [04:09] jml: i don't think it was you [04:25] * mwhudson lays down the law on the mailing list [04:27] mwhudson: did you get the query run to see how many git imports from sourceforge we have? [04:27] thumper: yes [04:27] thumper: there were 11, i think i fixed all of them [04:27] mwhudson: cool [04:27] well, we had some where someone had requested the new form already [04:34] fscking bzrtools [04:35] phew. all read. [04:36] now I need to incorporate the "Build Branch to Archive" thread into the spec [04:53] wgrant: seeing as you were asking earlier: https://dev.launchpad.net/BuildEngineer [04:53] wgrant: right ho, I'm on it. [04:54] jtv: Thanks. [04:55] wgrant: good thing we're in similar timezones! [04:56] jtv: Indeed! [04:57] jtv: oh i meant to ask, have you been using staging codehosting over the last two weeks? [04:57] mwhudson: no [04:57] why? [04:57] (It can't be much longer than two weeks, but I'm sure it's been two) [04:58] jtv: because you were trying to use it when i left, and i was trying to fix it [04:58] wgrant: btw, do you have a commit message for https://code.edge.launchpad.net/~wgrant/launchpad/structural-subscription-security/+merge/10776? ? [04:58] (sorry got horribly distracted) [04:59] mwhudson: thanks for asking... there were some more problems, but those were clear from production logs so we could fix, cherrypick, and see that the problem was gone. [04:59] mwhudson: I don't. Feel free to make something up, or convince me to. [04:59] jtv: the answer i was hoping for was "yes, we used staging codehosting a lot and it all worked fine" [04:59] wgrant: does that latest revision fix both failures? [04:59] mwhudson: sorry to disappoint! [04:59] jtv: It does. [05:00] wgrant: great, I'll send it back in [05:00] nice little three-way series of conversations here... [05:00] wgrant: "move structural subscription security checking into the model code" ? [05:00] mwhudson, wgrant: a thing I'd like (and might do myself), is write a simple script to make an ec2test submission given only the merge proposal URL. [05:00] mwhudson: Sounds fine! [05:00] jtv: Thanks. [05:01] jml: That would be good. [05:01] And public ec2test even better. [05:04] mwhudson: Thanks for making that page public. [05:15] mwhudson, do you want me to file bugs for any of the things I mentioned earlier re pain points? [05:15] jml: yes please [05:25] jtv, mwhudson: Are both my branches happily ec2testing? [05:25] * jtv checks [05:26] * wgrant is about to vanish for a couple of hours. [05:26] wgrant: not detached yet, but still working [05:26] heh " [05:26] Moving to launchpad since lp-devel-infra project is deprecated. [05:26] " [05:26] https://bugs.edge.launchpad.net/launchpad-foundations/+bug/106936 [05:26] Bug #106936: daily review mails [05:27] jml: Bah. Sounds like it needs reviving. [05:27] wgrant: the one i'm doing is [05:27] jtv, mwhudson: Great, thanks. [05:27] wgrant: it's not detached yet, but nearly there [05:28] wgrant: mine just detached [05:28] mwhudson: race you! [05:30] mwhudson, I've updated the BE wiki page with links to tags, and have moved a few bugs to be b-i tagged [05:30] jml: thank you [05:30] mwhudson, I've probably let some junk through [05:54] mwhudson, and now I've filed a large number of b-i bugs [05:54] jml: if only you could subscribe to a tag [05:55] * mwhudson is reading buildbot code, please send chocolate [05:55] * thumper sends mwhudson chocolate [06:29] wgrant: Jesus loves you, but He doesn't seem to care for your branch much. Got the same failures. Did you push? The test run was on 9235, not 9238, and that was right off the LP branch not off my copy. [06:31] jtv: Huh. [06:31] * wgrant checks LP. [06:31] jtv: I see 9238 on LP. [06:31] jtv: Maybe you caught it before it was mirrored. [06:32] wgrant: hm, maybe... Was some time after you pinged me though. :( [06:32] Strange. [06:32] I'll just try again. [06:32] Thanks. [06:34] wgrant: ha! That was an old email. The new one is still running. [06:34] jtv: Ahhh. That makes more sense. [06:40] \o/ [06:40] finally!!! [06:40] got person-product active reviews working [06:40] * thumper goes back to the old failing pagetest [06:46] some reviewer is going to hate me [06:46] * thumper wanks the 2000 line review limit back [06:46] oops [06:47] typo [06:47] hahaha. [06:47] damn muscle memory [06:47] my branch is getting bigish [06:47] * wgrant just got a 1400 line refactor branch down to 800ish. [06:48] Meant replaying the revisions doing bzr mvs slightly differently, though :( [06:48] this branch fixes activereviews for people, and adds project, source package, distro source package and person product active reviews [06:48] Impressive. [06:48] well [06:49] most of the new ones were pretty simple === Ursinha is now known as Ursinha-afk [06:49] most of the work is done in branch collection [06:49] one of jml's great ideas [07:06] mwhudson, have you eod'd? [07:07] thekorn: grats [07:08] meh [07:08] thumper: grats [07:30] jml: more or less [07:30] mwhudson, ok. [08:08] lifeless: for [08:08] ? [08:10] 15:48 < thumper> this branch fixes activereviews for people, and adds project, source package, distro source package and person product active reviews [08:10] anyone here use dchroot a lot? [08:10] lifeless: ah, ok :) [08:11] I have this problem where I constantly have to manually update my /etc/resolv.conf [08:11] hmm [08:11] jml: I have been known to [08:11] jml: the one in the chroot? [08:11] lifeless, right. [08:12] what updates your external resolv.conf [08:12] whatever that is, hook into that and write to your chroots [08:13] NetworkManager [08:13] hmm. [08:20] jml: welcome to the house of fun [08:20] la-de-la-de-da [08:22] :) [08:28] good morning [08:29] hi [08:31] adeuring, I've just started getting errors like these whenever I run any tests: [08:31] There were 1 imports of names not appearing in the __all__. [08:31] You should not import export_destructor_operation from lazr.restful.declarations: [08:31] canonical.launchpad.interfaces.hwdb [08:31] adeuring, know anything about it? [08:32] jml: version mismatch? [08:32] jml: I'm thinking a change to lazr.restful that you don't have yet, to make that public. [08:33] lifeless, lazr.restful is managed in buildout, and my buildout is up-to-date. [08:34] which doesn't preclude a mismatch in some version controlled config file, of course. [08:43] jml: as lifeless said: you are using an lod version of lazr.restful. I I landed a lazr.restful branch that includes export_destrutcor_operation in __all__ [08:43] s/lod/old/ [08:44] I've just seen lp-dev-utils mentioned for the first time on list. Is that something intrinsically Canonical-internal, or should it be public but isn't? [08:47] ok, so it's _not_ in buildout [08:47] adeuring, thanks [08:47] maxb, it's in the process of being made public [08:48] maxb, some stuff will be kept private [09:16] bigjools, hi [09:16] morning! [09:16] Morning peoples. [09:16] gmb, good morning [09:17] bigjools, I've got a bunch of stuff I'd like to chat with you about [09:18] jml: sure thing [09:18] bigjools, but I'm not sure I have brain left today [09:19] jml: what time will you be back in your morning? [09:19] staging does not let me do QA ... ;( [09:20] it times out [09:20] bigjools, UTC 21:30 [09:20] * henninge is amazed what a little complaining can achieve ... ;) [09:21] jml: heh, not sure *I'll* have brain left then. Tell you what, I'll see how I feel tonight else I can get up early tomorrow [09:22] Morning [09:23] * jml tries anyway [09:23] I have a note that says ProductSeries.sourcepackages is buggy. [09:23] I now want to slap myself for making notes like that. [09:23] :) [09:23] * bigjools looks [09:23] mrevell, g'day [09:24] jml: my eyes are bleeding looking at it, and it's only 8 lines [09:24] it's not that bad :) [09:25] actually that reminds me. [09:26] I have a branch that extracts out verify_acl's logic that works, modulo some easily-fixed error message differences [09:26] there's still some more stuff I need to do on top of that, but it's a nice milestone. [09:27] fab [09:27] and it turns out that eyeblood stains wash out of carpet really easily [09:27] bigjools, you said I should ask you on IRC why branches are associated with distro and not sourcepackage in breadcrumbs [09:28] jml: indeed, and if only I could remember what I was thinking when I wrote that [09:28] bigjools, ok. you can get back to me then :) [09:29] bigjools, I was looking at the package navigation thread today (first time since I got back from leave) -- how's all that going? [09:29] jml: somewhat underwhelmingly [09:29] some pages I wanted to trash were apparently important to some people [09:30] right, I saw you mention that you wanted to get a longer list of use-cases. [09:31] right now I am going for the tactic of improving the pages we said we would and then coming back later with the removal questions [09:31] bigjools, good plan. [09:31] jml: so for the breadcrumbs, what are the relative pros and cons [09:32] bigjools, sourcepackage is more consistent with the way product branches work [09:33] bigjools, and it's more consistent with the code [09:33] bigjools, but I don't find either of these to be compelling [09:34] Hmm. So, maybe pasting a huuuuuge list into an iharness session wasn't the best idea I've ever had. [09:34] bigjools, you can also navigate from the sourcepackage to distro, distroseries, and distributionsourcepackage more easily [09:34] hi... when a branch is created how do i make the branch private? [09:34] (btw, lets rename SourcePackage) [09:35] fuck yes [09:35] jml: so, the breadcrumbs would look like -> Ubuntu/Karmic/source/branch ? [09:36] bigjools, visually? I would have guessed "Ubuntu" -> "source in karmic" -> branch [09:36] yeah [09:36] one page that is under my heavy removal scrutiny is the SourcePackage page [09:37] bigjools, currently it's Ubuntu -> 9.10 -> "hotwire" package [09:37] and I don't want that to block on anything branch-related if it comes to it [09:37] oh yeah there's a little debate about what to write for a distroseries title [09:38] in my DSP page I use series.title. it doesn't include the vesion, maybe it should [09:38] bigjools, removing the SourcePackage page would probably not be a good thing for branches [09:39] jml: it's a useless page :( go look at one [09:39] bigjools, https://code.edge.launchpad.net/ubuntu/karmic/+source/hotwire [09:39] jml: how would one navigate to that page usually? [09:40] bigjools, it's reached by the Code tab from a source package branch [09:40] I wonder if I can add links to it in the new DSP page? (example here: https://dogfood.launchpad.net/ubuntu/+source/amarok) [09:40] bigjools, have you seen https://code.edge.launchpad.net/ubuntu/+source/hotwire [09:41] yes [09:41] good. [09:42] bigjools, one of the rationales for linking branches to SourcePackages instead of DistributionSourcePackages was so that there'd be a relevant listing of branches in each cycle of Ubuntu development [09:42] bigjools, maybe we can achieve this without a SourcePackage page [09:42] yep [09:42] bigjools, but it needs at least a little thought. [09:43] one of the problems with the package navigation is that there's waaaay too many pages with info spread all over them [09:44] it does need more thought [09:44] we should get together with Curtis [09:46] bigjools, indeed [09:47] jml: coming to Europe soon? you must be due, you haven't been here for a week :) [09:47] bigjools, haha [09:50] * jml has to go now [09:50] g'night all [09:51] jml: g'night, and I think +1 for your suggestion on breadcrumbs [09:51] cool. [10:08] wgrant: Jesus feels a lot better about your branch now than I thought earlier. It's landed. [10:08] jtv: Did you have some trigger for when I became unaway? [10:09] Because I got that message about a second after my screen reattached. [10:11] wgrant: once Jesus gets involved, all bets are off. [10:12] (Have I pissed off enough people today yet?) [10:12] jtv: Heh. [10:12] jtv: Thanks for the landing. [10:12] mrevell: will you be able to do this? https://bugs.edge.launchpad.net/soyuz/+bug/392239 [10:12] Bug #392239: [PPA] "Read about uploading" link doesn't go to the anchor bookmark #Uploading [10:13] * mrevell looks [10:14] bigjools: yes, no problem [10:14] mrevell: super thanks [10:14] wgrant: no worries... the next task is Q/A. [10:14] mwhudson: What happened to my other branch? [10:15] gmb, can I get you to Q/A wgrant's export-bug-nominations branch? [10:15] jtv: Sure; I can take a look in about half an hour if that's okay. [10:15] gmb: that'd be swell, thanks. [10:17] jtv: We don't wait for edge? [10:17] wgrant: for actually performing Q/A, yes, you. But gmb is having his first look in half an hour. [10:18] jtv: OK. === carlos_ is now known as carlos [10:52] jtv, wgrant: So, which branch is it I need to look at? [10:52] well, branch / commit / bug/ item on the QA page [10:53] gmb: lp:~wgrant/launchpad/export-bug-nominations will need QA when it shows up on edge. [10:53] Ok. [10:57] gmb: thanks. [11:06] Morning, all. [11:16] hey deryck === mrevell is now known as mrevell-lunch [12:29] wgrant: did you get someone to merge your structural-subscription-security branch? [12:32] gary_poster: mwhudson started an ec2test of it several hours ago, and another of my branches started around the same time landed 2.5 hours ago, so I think something went wrong. [12:33] wgrant: ok. yeah, I see your other one. probably should wait for feedback to you from Michael then. [12:34] gary_poster: Yep, I'll hopefully find something out tomorrow. [12:34] ok cool [12:35] I'll note that Michael tried to land the branch on the MP so anyone following along there knows we aren't ignoring you ;-) [12:36] Thanks. [12:52] I am going to shoot the next person who uses regular expressions in a test >:( [12:59] bigjools: You just wait until you start using renormalizer to get traceback tests working on 2.5... === matsubara-afk is now known as matsubara === mrevell-lunch is now known as mrevell === al-maisan_ is now known as al-maisan === cprov-afk is now known as cprov [15:35] barry, can you help me with a python problem? [15:35] i'm getting a metaclass conflict even though i'm pretty sure all my classes have the same metaclass [15:39] here's the code that's causing the problem [15:39] https://pastebin.canonical.com/21549/ [15:39] i pass the result of make_configuration_superclass into make_configuration and get the error when it tries to use the superclass as a superclass of a new class [15:39] but i'm using type() everywhere, and __metaclass__ = type in all affected files [15:41] * barry looks [15:43] leonardr: do you have a full traceback as well as the offending code? [15:43] barry, sure [15:43] leonardr: or maybe better, a branch [15:44] barry, i'll push the branch [15:44] give me just a minute to clean up [15:44] no worries, i'll be here :) [15:45] actually, maybe i can just make it simpler and destroy the problem that way [15:50] stub, Chex, gary_poster, rockstar, bigjools, henninge_, sinzui, intellectronica, Ursinha-afk: meeting in 10 min @ #launchpad-meeting [15:51] s/meeting/LP production meeting/ [15:51] barry: can you stand in for me in the LP product meeting ^ [15:52] matsubara: thanks for the reminder [15:52] matsubara, sinzui sure === Ursinha-afk is now known as Ursinha [16:01] henninge_, meeting [16:01] actually now danilos attends the production meeting, right? === henninge_ is now known as henninge [16:10] matsubara: at least today, I am about to leave [16:10] henninge, ok. danilos showed up. thanks! === deryck is now known as deryck[lunch] [17:05] danilos: Any idea why this would fail this way? Is order important? http://pastebin.ubuntu.com/260413/ [17:06] leonardr: good to see you figured it out [17:07] abentley: it's a recent commit by jtv, I'd have to take a closer look [17:08] barry, thanks for your potential help [17:10] leonardr: i'm always potentially helpful. sadly, the converse is often true too :) [17:22] abentley: can you fix the problem using assertContentEquals and that should be fine (if you are submitting something to pqm) [17:23] danilos: checking it now... [17:24] abentley: every other test works with only one so it's not a problem right now, but if this works for you, please email jtv@canonical.com (CCing me) mentioning what you had to do, and then the two of us can figure out what's the best way forward [17:26] danilos: self.assertContentEquals isn't defined, and I'm not sure what you mean. [17:27] danilos: Found it: assertContentEqual [17:28] danilos: This does work for me. I'll include it in the branch I land. [17:29] abentley: thanks, please do still email jtv@ and danilo@ with this; thanks and sorry for it causing a problem like this! === beuno is now known as beuno-lunch === salgado is now known as salgado-lunch === deryck[lunch] is now known as deryck === salgado-lunch is now known as salgado === matsubara is now known as matsubara-lunch [18:23] hi bigjools [18:31] night all [18:35] are people seeing failures in lib/lp/app/browser/tests/menu.txt ? [18:35] i just got failures from ec2 and i don't think it has anything to do with my changes [18:36] intellectronica, I just saw a landing that changed something there === beuno-lunch is now known as beuno [19:07] intellectronica: barry has a testfix branch running now [19:08] bac: cool, thanks === matsubara-lunch is now known as matsubara [19:24] beuno: ping [19:24] intellectronica, bac that should already be landed in devel [19:25] barry, hi [19:25] beuno: i have a quick u/i-ish question for you related to bug 51735 [19:25] barry: it has indeed. i got the failure from a branch i sent to ec2 (number of hours it takes to run the full test suite) earlier [19:25] Bug #51735: top level distros page could be improved [19:25] intellectronica: the joys of a long test suite [19:26] barry, sure, what's up? === Ursinha is now known as Ursinha-afk [19:26] beuno: at the bottom of that bug report sinzui suggests changing the way the read-only asterisk is displayed, but that also (i think) subtly changes the semantics of that star [19:26] beuno: right now the ui says about that footnote: * Read-only distribution. Can be browsed in Launchpad, but not altered or managed, and its information might be out of date. [19:27] beuno: but with sinzui's suggested change it really means "does not use Launchpad in any way" [19:27] barry: it does change it. if you read the code, we have a hack in it [19:27] sinzui: yep, i've seen that [19:28] * beuno looks at the bug [19:48] so, has anyone tried LP on karmic? [19:48] will I be shooting myself in the foot (again) if I upgrade my work laptop as well [19:48] ? [19:49] beuno: not yet, though i did install karmic on a vm last night. haven't tried building lp on it yet === beuno changed the topic of #launchpad-dev to: Launchpad Development Channel | Week 4 of 2.2.8 | https://dev.launchpad.net/ | Please use #launchpad for support. | https://launchpad.net/~launchpad-dev | Get it: https://dev.launchpad.net/Getting | http://people.canonical.com/~herb/ | http://paste.ubuntu.com/ | 3.0 goal is to convert all templates: http://people.canonical.com/~beuno/conversions.html [19:50] barry, I think we don't have the deps in the PPA for karmic [19:50] actually, it seems we do [19:50] I'll bite === EdwinGrubbs is now known as Edwin-lunch [21:13] wgrant: that ec2test run hung, it seems :( === Ursinha-afk is now known as Ursinha [21:29] sinzui: are you around? [21:30] I am [21:30] ok, just checking [21:30] 1 hour [21:30] thumper: I am on vacation [21:30] sinzui: then why are you around? [21:31] Do you want to talk about pygtk hacking? [21:31] sinzui: so our call is off? [21:31] not really [21:31] sorry [21:31] I'll grab rockstar then :) [21:33] thumper, hi [21:34] gary_poster: hello [21:34] mwhudson: hiya :-) [21:35] gary_poster: so do you remember what the problem was with the force build button when you turned it on? [21:35]