It seems clear that most research suggests that drinking milk is more likely to decrease the risk of osteoporosis despite the fact that some of its constituents if consumed in excessive amounts may have a negative impact on BMD.
Smoking tobaccowould  most likely have a negative impact on the ability of an individual to succeed at physical activities because it it decreases stamina and cardiovascular efficiency.