Giving students a complete set of study resources This is a hypothetical question, as I am not currently in a teaching position :)

I am currently making flash cards for Japanese on Quizlet, a flash card service (website &amp; app). The flash cards are for vocabulary, grammar, and additional notes that I have made for edge cases that would be expounded upon in later courses.

Personally, if an instructor had given me the material I am currently working on at the start of the semester, I would have used it to my advantage throughout the course, and it would have saved me about 8 hours of preparing the material myself. Yet, I have a feeling that it could be detrimental to some students, especially in particular subjects. That said, I see no problem in the case of foreign language courses, where the most important thing is active application of what was learned - you have to study vocabulary and grammar before you can use it in class, thus giving students a set of flash cards for such topics would not influence their application of the language.

I am wondering: were I in the position of instructor for the course, would it be pedagogically detrimental, or even inappropriate, for me to make such resources and give them to students? Would it depend on the time of the semester when I gave them the resources (e.g. would it be best to give them what I prepared only after all the material has been covered)? Would it depend on the subject?
It sounds helpful, not detrimental. NB, whatever materials you curate and provide will never be "complete" by any objective standard. Consider a textbook: it may be written to address a particular course design, and focus on the main topics relevant to that course, but it cannot make other study resources useless.

The major factor here is how much work you want to put into creating those resources, not what their easy availability would do to impressionable students.