Re: Bug #3024 still trivial, still applies, still not in svn :-( Hi Johann,

On Mon, 2007-04-30 at 13:31 +0200, Johann Hanne wrote:
> On Monday 30 April 2007 09:18, Jelmer Vernooij wrote:
> > Hi Johann,
> >
> > Johann Hanne wrote:
> > > I just tested 3.0.25rc3 and found out, that bug #3024 is still in.
> > > Moreover, the proposed patch still applies and it still fixes the bug.
> > > I'm getting a little desperate on this. What's the problem? I'd do
> > > anything I can to get it applied?!
> >
> > That patch doesn't look right. If winbindd_fill_pwent returns non-zero,
> > then user_list_ndx won't be incremented and since it will always be
> > incremented by at most 1 every time the loop is run, it's basically the
> > same as writing:
> >
> > while(1) {
> I don't think so. Even if user_list_ndx gets never incremented due to 
> winbindd_fill_pwent() errors,
> --
>                         /* No more domains */
> 
>                         if (!ent)
>                                 break;
> --
> will jump out of the loop as soon as all users have been received.
Sure, but that would also happen with while(1) {. My point is, I don't
think the condition in while() will ever be false so it has the same
effect as while(1).

Cheers,

Jelmer

-- 
Jelmer Vernooij  - http://samba.org/~jelmer/
