RE: [PATCH] RE: Change 32238: "Bake" the values of PERL_REVISION, PERL_VERSION and PERL_SUBVERSION Jan Dubois wrote:
> On Wed, 07 Nov 2007, Nicholas Clark wrote:
>> Change 32238 by nicholas@nicholas-saigo on 2007/11/07 23:58:06
> 
> This:
> 
>> +#if defined(PERL_GLOBAL_STRUCT)
>> +PERLVARI(Gglobal_struct_size,	U16,	sizeof(struct
perl_vars))
>> +#endif
> 
> means we also need that:
> 
> --- makedef.pl.~1~	Wed Nov  7 18:40:01 2007
> +++ makedef.pl	Wed Nov  7 18:40:01 2007
> @@ -895,6 +895,12 @@
>  		    )];
>  }
> 
> +unless ($define{'PERL_GLOBAL_STRUCT'}) {
> +    skip_symbols [qw(
> +		    PL_global_struct_size
> +		    )];
> +}
> +
>  unless ($define{'PERL_GLOBAL_STRUCT_PRIVATE'}) {
>      skip_symbols [qw(
>  		    PL_my_cxt_keys
> End of Patch.

I still get two unresolved externals with your patch. The following
fixes them for me, but I don't know if it's correct:

==== //depot/perl/makedef.pl#225 - c:\\p5p\\bleadperl\\makedef.pl ====
@@ -891,6 +891,19 @@
 		    )];
 }
 
+unless ($define{'MULTIPLICITY'}) {
+    skip_symbols [qw(
+		    PL_interpreter_size
+		    PL_interpreter_size_5_10_0
+		    )];
+}
+
+unless ($define{'PERL_GLOBAL_STRUCT'}) {
+    skip_symbols [qw(
+		    PL_global_struct_size
+		    )];
+}
+
 unless ($define{'PERL_GLOBAL_STRUCT_PRIVATE'}) {
     skip_symbols [qw(
 		    PL_my_cxt_keys
End of Patch.



