greg ward lsnognqkknnbnwqhgmailcom im trying fix ticket 126 changeset 493 backporting fix slightly patched 076 installation superficially works stop build button appears page builder hitting stop build stops currently running build step slave marches pointlessly next step builder grovel around web interface stopping successive build step turn aborted whole builder annoying intentional behaviour reopen ticket 126 greg returnpath xoriginalto jllocalhost deliveredto user7gvcceaschallengecc received radishjmasonorg localhost 127001 radishjmasonorg postfix esmtp id e4b2f32ce5 mon 19 nov 2007 000628 0000 gmt xspamvirus xspamcheckerversion spamassassin 330r574664 20070911 somanfdntechcom xspamrelaysexternal ip6635250225 rdnslistsoutboundsourceforgenet helolistsoutboundsourceforgenet bysomanfdntechcom ident envfrom intl0 id6bb28268eeb auth msa0 ip103194 rdnssc8sflist2newbsourceforgenet helosc8sflist2newsourceforgenet bysc8sfspam2sourceforgenet ident envfrom intl0 id99982fa91 auth msa0 ip103192 rdnssc8sfmx2bsourceforgenet helomailsourceforgenet bysc8sflist2newsourceforgenet ident envfrom intl0 id1itu3l00009a9z auth msa0 ip62391392 rdns21393962revgaolandnet helokualalumpurlrdeepitafr bymailsourceforgenet ident envfrom intl0 id1itu3q0003a0ht auth msa0 xspamstatus score39 required50 testsawlbayes_00 dkim_policy_signsomercvd_in_dnswl_lowspf_pass shortcircuitno autolearnham version330r574664 xspamrelaysinternal xspamrelaysuntrusted ip6635250225 rdnslistsoutboundsourceforgenet helolistsoutboundsourceforgenet bysomanfdntechcom ident envfrom intl0 id6bb28268eeb auth msa0 ip103194 rdnssc8sflist2newbsourceforgenet helosc8sflist2newsourceforgenet bysc8sfspam2sourceforgenet ident envfrom intl0 id99982fa91 auth msa0 ip103192 rdnssc8sfmx2bsourceforgenet helomailsourceforgenet bysc8sflist2newsourceforgenet ident envfrom intl0 id1itu3l00009a9z auth msa0 ip62391392 rdns21393962revgaolandnet helokualalumpurlrdeepitafr bymailsourceforgenet ident envfrom intl0 id1itu3q0003a0ht auth msa0 xspamrelaystrusted xspamlevel xspamrbl 127004 6635250206 127091 10 mailsourceforgenet xoriginalto user7gvcceaschallengecc deliveredto jlmailfdntechcom received localhost 127001 radishjmasonorg imap fetchmail632 singledrop mon 19 nov 2007 000628 0000 gmt received listsoutboundsourceforgenet listsoutboundsourceforgenet 6635250225 somanfdntechcom postfix esmtp id 6bb28268eeb sun 18 nov 2007 180005 0600 cst received sc8sflist2newsourceforgenet sc8sflist2newbsourceforgenet 103194 sc8sfspam2sourceforgenet postfix esmtp id 99982fa91 sun 18 nov 2007 160000 0800 pst received sc8sfmx2bsourceforgenet 103192 helomailsourceforgenet sc8sflist2newsourceforgenet esmtp exim 443 id 1itu3l00009a9z stfrkmttqdjejlistssourceforgenet sun 18 nov 2007 155951 0800 received 21393962revgaolandnet 62391392 helokualalumpurlrdeepitafr mailsourceforgenet esmtps tlsv1aes256sha256 exim 444 id 1itu3q0003a0ht stfrkmttqdjejlistssourceforgenet sun 18 nov 2007 155957 0800 received sigoure kualalumpurlrdeepitafr local exim 463 envelopefrom id 1itu3e0006li9d mon 19 nov 2007 005944 0100 benoit sigoure stfrkmttqdjejlistssourceforgenet date mon 19 nov 2007 005942 0100 messageid 1195430384217433gitsendemailtsunalrdeepitafr xmailer gitsendemail 1535 inreplyto 1195430384217432gitsendemailtsunalrdeepitafr references 1195430384217431gitsendemailtsunalrdeepitafr 7121310514766407nfyjnjgvfqlsyigvnlrdeepitafr cc lsxsyplghnfpualotharcom subject buildbotdevel patch v2 1012 allow patches submitted web interface xbeenthere stfrkmttqdjejlistssourceforgenet xmailmanversion 218 precedence list listid listunsubscribe listarchive listpost listhelp listsubscribe mimeversion 10 contenttype textplain charsetusascii contenttransferencoding 7bit sender lthqpadsdeattktclthqlistssourceforgenet errorsto lthqpadsdeattktclthqlistssourceforgenet user authentication used allow forcestop builds users also attach patch force build request buildbotsourcestamppy sourcestamp__init__ enhance documentation make_force_build_form add fields upload patch specify patchlevel buildbotstatuswebbuilderpy statusresourcebuilderforce handle new fields form allow patches authenticated users signedoffby benoit sigoure buildbotsourcestamppy 3 buildbotstatuswebbasepy 17 buildbotstatuswebbuilderpy 30 3 files changed 41 insertions 9 deletions diff git abuildbotsourcestamppy bbuildbotsourcestamppy index 69d3c30a388014 100644 abuildbotsourcestamppy bbuildbotsourcestamppy 127 128 class sourcestamputilcomparablemixin none build head revision given branch revisionrev patchspeclevel diff changesnone checkout rev apply patch source cpatch ppatchlevel useloginpassword form_type methodpost enctypemultipartformdata form_attach make_rowbuild patch make_rowpatch level else form_attach form_type data force build fill following fields click force build button forceurl click force build button forceurl form_type return data make_name_login_password_formuseloginpassword make_rowreason build 976 1097 def make_force_build_formforceurl useloginpassword make_rowrevision build form_attach n colormap diff git abuildbotstatuswebbuilderpy bbuildbotstatuswebbuilderpy index e028c9d900a33f 100644 abuildbotstatuswebbuilderpy bbuildbotstatuswebbuilderpy 12812 12826 class statusresourcebuilderhtmlresource onelinemixin reason reqargsgetcomments 0 branch reqargsgetbranch 0 revision reqargsgetrevision 0 patch reqargsgetpatch 0 patch patch_level reqargsgetplevel 10 try patch_level intpatch_level except valueerror todo tell web user request invalid return redirect patch patch_level patch has_patch yes else has_patch patch none r webpage force build button pressed sn name reason logmsgweb forcebuild builder branchs revisions user selfbuilder_statusgetname branch revision name r webpage force build button pressed patch sn name reason has_patch logmsgweb forcebuild builder branchs revisions user patch selfbuilder_statusgetname branch revision name has_patch selfbuilder_control todo tell web user request denied 1446 15810 class statusresourcebuilderhtmlresource onelinemixin selfauthuserreq todo tell web user request denied return redirect else patch logmsguser authenticated discarding patch patch none keep weird stuff branch revision strings todo centralize somewhere 1647 1827 class statusresourcebuilderhtmlresource onelinemixin buildbotchangeschangeschange instance doesnt really fit use case requires list changed files tedious compute stage sourcestampbranchbranch revisionrevision sourcestampbranchbranch revisionrevision patchpatch req buildrequestr selfbuilder_statusgetname try selfbuilder_controlrequestbuildsoonreq 1535756gc887a fri 08 aug 2008 071200 0500 buildbotdevel stop build stops current build step