Re: [perl #43148] [TODO] Rename rpath hash element to be more general (config/init/hints/darwin.pm) Paul Cochrane wrote:
> # New Ticket Created by  Paul Cochrane 
> # Please include the string:  [perl #43148]
> # in the subject line of all future correspondence about this issue. 
> # 
> 
> 
> In the file:  config/init/hints/darwin.pm there is the todo item:
> 
> # This variable needs renaming to be more general
> # XXX ugly hack for rpath_lib in config/inter/libparrot.pm
> 
> which occurs just before definition of the 'rpath' hash element of the
> Config::Data object for Darwin.  The variable needs to be renamed (an
> appropriate name needs to be found first) and the ugly hack for
> rpath_lib needs to be implemented more nicely.  The link to
> config/inter/libparrot.pm is unclear and should be clarified.

Here are the locations in which I found 'rpath' by itself or as a 
significant part of another variable:

config/init/defaults.pm:159:        rpath         => '',
config/init/hints/darwin.pm:52:        # XXX ugly hack for rpath_lib in 
config/inter/libparrot.pm
config/init/hints/darwin.pm:53:        rpath            => "-L",
config/init/hints/dragonflybsd.pm:20:        rpath                   => 
'-Wl,-R',
config/init/hints/freebsd.pm:34:        rpath => '-Wl,-R',
config/init/hints/linux.pm:83:        rpath          => '-Wl,-rpath=',
config/inter/libparrot.pm:53:        rpath_blib => ( $parrot_is_shared 
&& $conf->data->get('rpath') )
config/inter/libparrot.pm:54:        ? $conf->data->get('rpath')
config_lib.pasm:266:	set P0["rpath"], "-L"
config_lib.pasm:267:	set P0["rpath_blib"], ""
lib/Parrot/Test.pm:834:            my $libparrot_shared = 
"$PConfig{rpath_blib} -L$PConfig{blib_dir} -lparrot";
tools/dev/src-t.sh:43:RPATH=$(./parrot parrot-config rpath)

'rpath' sounds pretty general to me (if not particularly 
self-documenting).  Is there really a significant bang for the buck to 
changing it?  (Or, different way of asking same question:  If that 
comment weren't there, would we care?)

kid51

