Re: [PATCH 1/4] Make sure groups[0] is the effective gid on FreeBSD. On Thu, 2007-06-07 at 21:31 -0700, Jeremy Allison wrote:
> On Thu, Jun 07, 2007 at 08:35:29PM -0700, James Peach wrote:
> > On BSD systems, the first gid passed to setgroups(2) should be the  
> > effective
> > gid. Make sure we grow the groups list when switching credentials to  
> > guarantee
> > this (as far as possible).
> 
> Sorry, I hate this and won't accept it.
> 
> I want to see the *BSD brokenness split out as
> far as possible as a sepeate set of #ifdefs
> from the working code so I can see *exactly*
> what you're doing here.

I have to agree - not even having read the patch, but from my memory of
this area in the past.  We have 'fixed FreeBSD' and broken Linux on this
before. Let's keep the madness restricted. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.                  http://redhat.com
