Recently we have a new developer in our team. We are getting him up to speed and he is picking it all up quite fast, but a new developer means new (foreign) coding styles and ways to solve things.It feels kinda petty to start whining about coding styles at the first three classes he codes, but how forgiving are you guys when dealing with new developers? Do you let them muddle on, and point it out later? Or do you wield the scepter of intolerance immediately?When do you draw the line, or if not, why not?P.S. New guy, if you read this: you are doing great, keep up the good work ;)Edit:I've accepted the most up-voted answer, as most answers share the same message: Be nice, but tell them asap!
How forgiving do you need to be on new employees?
employment;coding style
As a relatively new employee at my current company (less than 6 months), I'll just point out that I always prefer to be told of things like this ASAP rather than later. If I don't know that I'm doing something wrong, I'm going to continue doing it wrong and it's going to probably cause more work for others involved in the project. I don't want my team leader to have to code-review everything I write just so that he can make sure I'm following the proper formatting guidelines.If you point out the inconsistencies with the style guide in a polite and reasonable manner, I don't think you'll hurt anybody's feelings. I know I certainly don't take criticism of that nature personally as long as it's presented in a way that isn't blatantly offensive. Be understanding of the fact that transition is tough - and make sure your employees can tell that you're understanding - but don't just ignore it altogether. I'm sure I speak for most new hires when I say that we want to contribute to the team the right way, but sometimes we just fall into old habits in the beginning (or forget more nuanced style restrictions).So in a nutshell: I'd say be positive, but don't look the other way. Most new guys really want to learn, so there's no reason not to take the opportunity to teach!