We have a concept that all code in a Pull Request into master should be production ready. This makes sense and is a fair statement in my opinion.The idea here being that once you create the PR, you are stating that you would have put this into master, but would like some reviewers to simply 'concur' with you and spot anything you happen to miss.As we are only human, we make mistakes and hope that other reviewers might find items that unit tests could not find - spelling mistakes, incorrect javadocs etc.BUT, is a Pull Request the place where we should be providing some level of assistance/training to developers and if so, to what level?Each time you push new changes, reviewers have to re review your changes, which takes from their development time and causes re reviewing changes.So, how much training is expected, should be allowed, in Pull Requests?Part of me feels it varies from juniors to seniors. However I also feel that it should not be the place for finding vast amounts of issues - even for juniors.Is anyone else struggling with trying to get developers to achieve the goal of My pull request ought to be production ready?
Are pull requests the place for training juniors
agile;pull requests
No. Pull requests are not the place for training. Your team has the right idea. A PR means I think it's good to go. Can I get a 2nd set of eyes on this in case I missed something. I'm human after all. And I suspect that's exactly what your apprentice is doing. They honestly think it's good to go. Here's an extreme idea (pun intended). Pair Program with the apprentice who's giving you the heartburn. As a more senior team member, it's your job to lift them up and get them to productive. 