Datasets:

miesnerjacob

/

github-issues

like 0

https://api.github.com/repos/huggingface/datasets/issues/3768

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3768/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3768/comments

https://api.github.com/repos/huggingface/datasets/issues/3768/events

https://github.com/huggingface/datasets/pull/3768

PR_kwDODunzps4zPobl

Fix HfFileSystem docstring

open

MEMBER

https://api.github.com/repos/huggingface/datasets/issues/3768/timeline

https://api.github.com/repos/huggingface/datasets/issues/3767

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3767/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3767/comments

https://api.github.com/repos/huggingface/datasets/issues/3767/events

https://github.com/huggingface/datasets/pull/3767

PR_kwDODunzps4zPahh

Expose method and fix param

open

CONTRIBUTOR

A fix + expose a new method, following https://github.com/huggingface/datasets/pull/3670

https://api.github.com/repos/huggingface/datasets/issues/3767/timeline

https://api.github.com/repos/huggingface/datasets/issues/3766

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3766/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3766/comments

https://api.github.com/repos/huggingface/datasets/issues/3766/events

https://github.com/huggingface/datasets/pull/3766

PR_kwDODunzps4zOujH

Fix head_qa data URL

closed

MEMBER

Fix #3758.

https://api.github.com/repos/huggingface/datasets/issues/3766/timeline

https://api.github.com/repos/huggingface/datasets/issues/3765

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3765/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3765/comments

https://api.github.com/repos/huggingface/datasets/issues/3765/events

https://github.com/huggingface/datasets/pull/3765

PR_kwDODunzps4zMdIL

Update URL for tagging app

closed

MEMBER

This PR updates the URL for the tagging app to be the one on Spaces.

https://api.github.com/repos/huggingface/datasets/issues/3765/timeline

https://api.github.com/repos/huggingface/datasets/issues/3764

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3764/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3764/comments

https://api.github.com/repos/huggingface/datasets/issues/3764/events

https://github.com/huggingface/datasets/issues/3764

I_kwDODunzps5EQPJq

!

closed

NONE

## Dataset viewer issue for '*name of the dataset*' **Link:** *link to the dataset viewer page* *short description of the issue* Am I the one who added this dataset ? Yes-No

https://api.github.com/repos/huggingface/datasets/issues/3764/timeline

https://api.github.com/repos/huggingface/datasets/issues/3763

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3763/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3763/comments

https://api.github.com/repos/huggingface/datasets/issues/3763/events

https://github.com/huggingface/datasets/issues/3763

I_kwDODunzps5EQNZm

It's not possible download `20200501.pt` dataset

closed

NONE

## Describe the bug The dataset `20200501.pt` is broken. The available datasets: https://dumps.wikimedia.org/ptwiki/ ## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("wikipedia", "20200501.pt", beam_runner='DirectRunner') ``` ## Expected results I expect to download the dataset locally. ## Actual results ``` >>> from datasets import load_dataset >>> dataset = load_dataset("wikipedia", "20200501.pt", beam_runner='DirectRunner') Downloading and preparing dataset wikipedia/20200501.pt to /home/jvanz/.cache/huggingface/datasets/wikipedia/20200501.pt/1.0.0/009f923d9b6dd00c00c8cdc7f408f2b47f45dd4f5fb7982a21f9448f4afbe475... /home/jvanz/anaconda3/envs/tf-gpu/lib/python3.9/site-packages/apache_beam/__init__.py:79: UserWarning: This version of Apache Beam has not been sufficiently tested on Python 3.9. You may encounter bugs or missing features. warnings.warn( 0%| | 0/1 [00:00<?, ?it/s] Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/jvanz/anaconda3/envs/tf-gpu/lib/python3.9/site-packages/datasets/load.py", line 1702, in load_dataset builder_instance.download_and_prepare( File "/home/jvanz/anaconda3/envs/tf-gpu/lib/python3.9/site-packages/datasets/builder.py", line 594, in download_and_prepare self._download_and_prepare( File "/home/jvanz/anaconda3/envs/tf-gpu/lib/python3.9/site-packages/datasets/builder.py", line 1245, in _download_and_prepare super()._download_and_prepare( File "/home/jvanz/anaconda3/envs/tf-gpu/lib/python3.9/site-packages/datasets/builder.py", line 661, in _download_and_prepare split_generators = self._split_generators(dl_manager, **split_generators_kwargs) File "/home/jvanz/.cache/huggingface/modules/datasets_modules/datasets/wikipedia/009f923d9b6dd00c00c8cdc7f408f2b47f45dd4f5fb7982a21f9448f4afbe475/wikipedia.py", line 420, in _split_generators downloaded_files = dl_manager.download_and_extract({"info": info_url}) File "/home/jvanz/anaconda3/envs/tf-gpu/lib/python3.9/site-packages/datasets/utils/download_manager.py", line 307, in download_and_extract return self.extract(self.download(url_or_urls)) File "/home/jvanz/anaconda3/envs/tf-gpu/lib/python3.9/site-packages/datasets/utils/download_manager.py", line 195, in download downloaded_path_or_paths = map_nested( File "/home/jvanz/anaconda3/envs/tf-gpu/lib/python3.9/site-packages/datasets/utils/py_utils.py", line 260, in map_nested mapped = [ File "/home/jvanz/anaconda3/envs/tf-gpu/lib/python3.9/site-packages/datasets/utils/py_utils.py", line 261, in <listcomp> _single_map_nested((function, obj, types, None, True)) File "/home/jvanz/anaconda3/envs/tf-gpu/lib/python3.9/site-packages/datasets/utils/py_utils.py", line 196, in _single_map_nested return function(data_struct) File "/home/jvanz/anaconda3/envs/tf-gpu/lib/python3.9/site-packages/datasets/utils/download_manager.py", line 216, in _download return cached_path(url_or_filename, download_config=download_config) File "/home/jvanz/anaconda3/envs/tf-gpu/lib/python3.9/site-packages/datasets/utils/file_utils.py", line 298, in cached_path output_path = get_from_cache( File "/home/jvanz/anaconda3/envs/tf-gpu/lib/python3.9/site-packages/datasets/utils/file_utils.py", line 612, in get_from_cache raise FileNotFoundError(f"Couldn't find file at {url}") FileNotFoundError: Couldn't find file at https://dumps.wikimedia.org/ptwiki/20200501/dumpstatus.json ``` ## Environment info ``` - `datasets` version: 1.18.3 - Platform: Linux-5.3.18-150300.59.49-default-x86_64-with-glibc2.31 - Python version: 3.9.7 - PyArrow version: 6.0.1 ```

https://api.github.com/repos/huggingface/datasets/issues/3763/timeline

https://api.github.com/repos/huggingface/datasets/issues/3762

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3762/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3762/comments

https://api.github.com/repos/huggingface/datasets/issues/3762/events

https://github.com/huggingface/datasets/issues/3762

I_kwDODunzps5EPQSV

`Dataset.class_encode` should support custom class names

closed

CONTRIBUTOR

I can make a PR, just wanted approval before starting. **Is your feature request related to a problem? Please describe.** It is often the case that classes are not ordered in alphabetical order. Current `class_encode_column` sort the classes before indexing. https://github.com/huggingface/datasets/blob/master/src/datasets/arrow_dataset.py#L1235 **Describe the solution you'd like** I would like to add a **optional** parameter `class_names` to `class_encode_column` that would be used for the mapping instead of sorting the unique values. **Describe alternatives you've considered** One can use map instead. I find it harder to read. ```python CLASS_NAMES = ['apple', 'orange', 'potato'] ds = ds.map(lambda item: CLASS_NAMES.index(item[label_column])) # Proposition ds = ds.class_encode_column(label_column, CLASS_NAMES) ``` **Additional context** I can make the PR if this feature is accepted.

https://api.github.com/repos/huggingface/datasets/issues/3762/timeline

https://api.github.com/repos/huggingface/datasets/issues/3761

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3761/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3761/comments

https://api.github.com/repos/huggingface/datasets/issues/3761/events

https://github.com/huggingface/datasets/issues/3761

I_kwDODunzps5EPLru

Know your data for HF hub

closed

NONE

**Is your feature request related to a problem? Please describe.** Would be great to see be able to understand datasets with the goal of improving data quality, and helping mitigate fairness and bias issues. **Describe the solution you'd like** Something like https://knowyourdata.withgoogle.com/ for HF hub

https://api.github.com/repos/huggingface/datasets/issues/3761/timeline

https://api.github.com/repos/huggingface/datasets/issues/3760

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3760/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3760/comments

https://api.github.com/repos/huggingface/datasets/issues/3760/events

https://github.com/huggingface/datasets/issues/3760

I_kwDODunzps5EPFTO

Unable to view the Gradio flagged call back dataset

closed

NONE

## Dataset viewer issue for '*savtadepth-flags*' **Link:** *[savtadepth-flags](https://huggingface.co/datasets/kingabzpro/savtadepth-flags)* *with the Gradio 2.8.1 the dataset viers stopped working. I tried to add values manually but its not working. The dataset is also not showing the link with the app https://huggingface.co/spaces/kingabzpro/savtadepth.* Am I the one who added this dataset ? Yes

https://api.github.com/repos/huggingface/datasets/issues/3760/timeline

https://api.github.com/repos/huggingface/datasets/issues/3759

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3759/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3759/comments

https://api.github.com/repos/huggingface/datasets/issues/3759/events

https://github.com/huggingface/datasets/pull/3759

PR_kwDODunzps4zGhQu

Rename GenerateMode to DownloadMode

open

MEMBER

This PR: - Renames `GenerateMode` to `DownloadMode` - Implements `DeprecatedEnum` - Deprecates `GenerateMode` Close #769.

https://api.github.com/repos/huggingface/datasets/issues/3759/timeline

https://api.github.com/repos/huggingface/datasets/issues/3758

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3758/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3758/comments

https://api.github.com/repos/huggingface/datasets/issues/3758/events

https://github.com/huggingface/datasets/issues/3758

I_kwDODunzps5EJmL5

head_qa file missing

closed

CONTRIBUTOR

## Describe the bug A file for the `head_qa` dataset is missing (https://drive.google.com/u/0/uc?export=download&id=1a_95N5zQQoUCq8IBNVZgziHbeM-QxG2t/HEAD_EN/train_HEAD_EN.json) ## Steps to reproduce the bug ```python >>> from datasets import load_dataset >>> load_dataset("head_qa", name="en") ``` ## Expected results The dataset should be loaded ## Actual results ``` Downloading and preparing dataset head_qa/en (download: 75.69 MiB, generated: 2.69 MiB, post-processed: Unknown size, total: 78.38 MiB) to /home/slesage/.cache/huggingface/datasets/head_qa/en/1.1.0/583ab408e8baf54aab378c93715fadc4d8aa51b393e27c3484a877e2ac0278e9... Downloading data: 2.21kB [00:00, 2.05MB/s] Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/slesage/hf/datasets-preview-backend/.venv/lib/python3.9/site-packages/datasets/load.py", line 1729, in load_dataset builder_instance.download_and_prepare( File "/home/slesage/hf/datasets-preview-backend/.venv/lib/python3.9/site-packages/datasets/builder.py", line 594, in download_and_prepare self._download_and_prepare( File "/home/slesage/hf/datasets-preview-backend/.venv/lib/python3.9/site-packages/datasets/builder.py", line 665, in _download_and_prepare verify_checksums( File "/home/slesage/hf/datasets-preview-backend/.venv/lib/python3.9/site-packages/datasets/utils/info_utils.py", line 40, in verify_checksums raise NonMatchingChecksumError(error_msg + str(bad_urls)) datasets.utils.info_utils.NonMatchingChecksumError: Checksums didn't match for dataset source files: ['https://drive.google.com/u/0/uc?export=download&id=1a_95N5zQQoUCq8IBNVZgziHbeM-QxG2t'] ``` ## Environment info - `datasets` version: 1.18.4.dev0 - Platform: Linux-5.11.0-1028-aws-x86_64-with-glibc2.31 - Python version: 3.9.6 - PyArrow version: 6.0.1

https://api.github.com/repos/huggingface/datasets/issues/3758/timeline

https://api.github.com/repos/huggingface/datasets/issues/3757

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3757/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3757/comments

https://api.github.com/repos/huggingface/datasets/issues/3757/events

https://github.com/huggingface/datasets/pull/3757

PR_kwDODunzps4zGK7p

Add perplexity to metrics

open

NONE

Adding perplexity metric This code differs from the code in [this](https://huggingface.co/docs/transformers/perplexity) HF blog post because the blogpost code fails in at least the following circumstances: - returns nans whenever the stride = 1 - hits a runtime error when the stride is significantly larger than the max model length (e.g. if max_model_length = 512 and stride = 1024) Note that: - As it is, it only works for causal models. Pseudoperplexity can be added later as another metric to work with masked language models. - It takes in a list of strings so that it can be dataset independent. This does mean that it doesn't currently batch inputs, and is therefore relatively slow. - It overwrites the metrics compute() function for a specific perplexity compute() function. This is because the current general metrics compute() function requires model-generated predictions, which doesn't make sense in the context of perplexity

https://api.github.com/repos/huggingface/datasets/issues/3757/timeline

https://api.github.com/repos/huggingface/datasets/issues/3756

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3756/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3756/comments

https://api.github.com/repos/huggingface/datasets/issues/3756/events

https://github.com/huggingface/datasets/issues/3756

I_kwDODunzps5EJPlh

Images get decoded when using `map()` with `input_columns` argument on a dataset

open

NONE

## Describe the bug The `datasets.features.Image` feature class decodes image data by default. Expectedly, when indexing a dataset or using the `map()` method, images are returned as PIL Image instances. However, when calling `map()` and setting a specific data column with the `input_columns` argument, the image data is passed as raw byte representation to the mapping function. ## Steps to reproduce the bug ```python from datasets import load_dataset from torchvision import transforms from PIL.Image import Image dataset = load_dataset('mnist', split='train') def transform_all_columns(example): # example['image'] is encoded as PIL Image assert isinstance(example['image'], Image) return example def transform_image_column(image): # image is decoded here and represented as raw bytes assert isinstance(image, Image) return image # single-sample dataset for debugging purposes dev = dataset.select([0]) dev.map(transform_all_columns) dev.map(transform_image_column, input_columns='image') ``` ## Expected results Image data should be passed in decoded form, i.e. as PIL Image objects to the mapping function unless the `decode` attribute on the image feature is set to `False`. ## Actual results The mapping function receives images as raw byte data. ## Environment info - `datasets` version: 1.18.3 - Platform: Linux-5.11.0-49-generic-x86_64-with-glibc2.32 - Python version: 3.8.0b4 - PyArrow version: 7.0.0

https://api.github.com/repos/huggingface/datasets/issues/3756/timeline

https://api.github.com/repos/huggingface/datasets/issues/3755

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3755/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3755/comments

https://api.github.com/repos/huggingface/datasets/issues/3755/events

https://github.com/huggingface/datasets/issues/3755

I_kwDODunzps5EIUyB

Cannot preview dataset

closed

NONE

## Dataset viewer issue for '*rubrix/news*' **Link:https://huggingface.co/datasets/rubrix/news** *link to the dataset viewer page* Cannot see the dataset preview: ``` Status code: 400 Exception: Status400Error Message: Not found. Cache is waiting to be refreshed. ``` Am I the one who added this dataset ? No

https://api.github.com/repos/huggingface/datasets/issues/3755/timeline

https://api.github.com/repos/huggingface/datasets/issues/3754

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3754/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3754/comments

https://api.github.com/repos/huggingface/datasets/issues/3754/events

https://github.com/huggingface/datasets/issues/3754

I_kwDODunzps5EHxCI

Overflowing indices in `select`

closed

MEMBER

## Describe the bug The `Dataset.select` function seems to accept indices that are larger than the dataset size and seems to effectively use `index %len(ds)`. ## Steps to reproduce the bug ```python from datasets import Dataset ds = Dataset.from_dict({"test": [1,2,3]}) ds = ds.select(range(5)) print(ds) print() print(ds["test"]) ``` Result: ```python Dataset({ features: ['test'], num_rows: 5 }) [1, 2, 3, 1, 2] ``` This behaviour is not documented and can lead to unexpected behaviour when for example taking a sample larger than the dataset and thus creating a lot of duplicates. ## Expected results It think this should throw an error or at least a very big warning: ```python IndexError: Invalid key: 5 is out of bounds for size 3 ``` ## Environment info - `datasets` version: 1.18.3 - Platform: macOS-12.0.1-x86_64-i386-64bit - Python version: 3.9.10 - PyArrow version: 7.0.0

https://api.github.com/repos/huggingface/datasets/issues/3754/timeline

https://api.github.com/repos/huggingface/datasets/issues/3753

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3753/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3753/comments

https://api.github.com/repos/huggingface/datasets/issues/3753/events

https://github.com/huggingface/datasets/issues/3753

I_kwDODunzps5EHhEY

Expanding streaming capabilities

open

MEMBER

Some ideas for a few features that could be useful when working with large datasets in streaming mode. ## `filter` for `IterableDataset` Adding filtering to streaming datasets would be useful in several scenarios: - filter a dataset with many languages for a subset of languages - filter a dataset for specific licenses - other custom logic to get a subset The only way to achieve this at the moment is I think through writing a custom loading script and implementing filters there. ## `IterableDataset` to `Dataset` conversion In combination with the above filter a functionality to "play" the whole stream would be useful. The motivation is that often one might filter the dataset to get a manageable size for experimentation. In that case streaming mode is no longer necessary as the filtered dataset is small enough and it would be useful to be able to play through the whole stream to create a normal `Dataset` with all its benefits. ```python ds = load_dataset("some_large_dataset", streaming=True) ds_filter = ds.filter(lambda x: x["lang"]="fr") ds_filter = ds_filter.stream() # here the `IterableDataset` is converted to a `Dataset` ``` Naturally, this could be expanded with `stream(n=1000)` which creates a `Dataset` with the first `n` elements similar to `take`. ## Stream to the Hub While streaming allows to use a dataset as is without saving the whole dataset on the local machine it is currently not possible to process a dataset and add it to the hub. The only way to do this is by downloading the full dataset and saving the processed dataset again before pushing them to the hub. The API could looks something like: ```python ds = load_dataset("some_large_dataset", streaming=True) ds_filter = ds.filter(some_filter_func) ds_processed = ds_filter.map(some_processing_func) ds_processed.push_to_hub("new_better_dataset", batch_size=100_000) ``` Under the hood this could be done by processing and aggregating `batch_size` elements and then pushing that batch as a single file to the hub. With this functionality one could process and create TB scale datasets while only requiring size of `batch_size` local disk space. cc @lhoestq @albertvillanova

https://api.github.com/repos/huggingface/datasets/issues/3753/timeline

https://api.github.com/repos/huggingface/datasets/issues/3752

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3752/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3752/comments

https://api.github.com/repos/huggingface/datasets/issues/3752/events

https://github.com/huggingface/datasets/pull/3752

PR_kwDODunzps4zD1D9

Update metadata JSON for cats_vs_dogs dataset

closed

MEMBER

Note that the number of examples in the train split was already fixed in the dataset card. Fix #3750.

https://api.github.com/repos/huggingface/datasets/issues/3752/timeline

https://api.github.com/repos/huggingface/datasets/issues/3751

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3751/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3751/comments

https://api.github.com/repos/huggingface/datasets/issues/3751/events

https://github.com/huggingface/datasets/pull/3751

PR_kwDODunzps4zDw9_

Fix typo in train split name

closed

MEMBER

In the README guide (and consequently in many datasets) there was a typo in the train split name: ``` | Tain | Valid | Test | ``` This PR: - fixes the typo in the train split name - fixes the column alignment of the split tables in the README guide and in all datasets.

https://api.github.com/repos/huggingface/datasets/issues/3751/timeline

https://api.github.com/repos/huggingface/datasets/issues/3750

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3750/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3750/comments

https://api.github.com/repos/huggingface/datasets/issues/3750/events

https://github.com/huggingface/datasets/issues/3750

I_kwDODunzps5EF8SL

`NonMatchingSplitsSizesError` for cats_vs_dogs dataset

closed

MEMBER

## Describe the bug Cannot download cats_vs_dogs dataset due to `NonMatchingSplitsSizesError`. ## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("cats_vs_dogs") ``` ## Expected results Loading is successful. ## Actual results ``` NonMatchingSplitsSizesError: [{'expected': SplitInfo(name='train', num_bytes=7503250, num_examples=23422, dataset_name='cats_vs_dogs'), 'recorded': SplitInfo(name='train', num_bytes=7262410, num_examples=23410, dataset_name='cats_vs_dogs')}] ``` ## Environment info Reproduced on a fresh [Colab notebook](https://colab.research.google.com/drive/13GTvrSJbBGvL2ybDdXCBZwATd6FOkMub?usp=sharing). ## Additional Context Originally reported in https://github.com/huggingface/transformers/issues/15698. cc @mariosasko

https://api.github.com/repos/huggingface/datasets/issues/3750/timeline

https://api.github.com/repos/huggingface/datasets/issues/3749

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3749/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3749/comments

https://api.github.com/repos/huggingface/datasets/issues/3749/events

https://github.com/huggingface/datasets/pull/3749

PR_kwDODunzps4zCKqg

Add tqdm arguments

open

NONE

In this PR, tqdm arguments can be passed to the map() function and such, in order to be more flexible.

https://api.github.com/repos/huggingface/datasets/issues/3749/timeline

https://api.github.com/repos/huggingface/datasets/issues/3748

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3748/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3748/comments

https://api.github.com/repos/huggingface/datasets/issues/3748/events

https://github.com/huggingface/datasets/pull/3748

PR_kwDODunzps4zCEyM

Add tqdm arguments

closed

NONE

In this PR, there are two changes. 1. It is able to show the progress bar by adding the length of the iterator. 2. Pass in tqdm_kwargs so that can enable more feasibility for the control of tqdm library.

https://api.github.com/repos/huggingface/datasets/issues/3748/timeline

https://api.github.com/repos/huggingface/datasets/issues/3747

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3747/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3747/comments

https://api.github.com/repos/huggingface/datasets/issues/3747/events

https://github.com/huggingface/datasets/issues/3747

I_kwDODunzps5EDMoW

Passing invalid subset should throw an error

open

CONTRIBUTOR

## Describe the bug Only some datasets have a subset (as in `load_dataset(name, subset)`). If you pass an invalid subset, an error should be thrown. ## Steps to reproduce the bug ```python import datasets datasets.load_dataset('rotten_tomatoes', 'asdfasdfa') ``` ## Expected results This should break, since `'asdfasdfa'` isn't a subset of the `rotten_tomatoes` dataset. ## Actual results This API call silently succeeds.

https://api.github.com/repos/huggingface/datasets/issues/3747/timeline

https://api.github.com/repos/huggingface/datasets/issues/3746

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3746/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3746/comments

https://api.github.com/repos/huggingface/datasets/issues/3746/events

https://github.com/huggingface/datasets/pull/3746

PR_kwDODunzps4zAS-C

Use the same seed to shuffle shards and metadata in streaming mode

open

MEMBER

When shuffling in streaming mode, those two entangled lists are shuffled independently. In this PR I changed this to shuffle the lists of same length with the exact same seed, in order for the files and metadata to still be aligned. ```python gen_kwargs = { "files": [os.path.join(data_dir, filename) for filename in all_files], "metadata_files": [all_metadata[filename] for filename in all_files], } ``` IMO this is important to avoid big but silent issues. Fix https://github.com/huggingface/datasets/issues/3744

https://api.github.com/repos/huggingface/datasets/issues/3746/timeline

https://api.github.com/repos/huggingface/datasets/issues/3745

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3745/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3745/comments

https://api.github.com/repos/huggingface/datasets/issues/3745/events

https://github.com/huggingface/datasets/pull/3745

PR_kwDODunzps4y__m2

Add mIoU metric

open

NONE

This PR adds the mean Intersection-over-Union metric to the library, useful for tasks like semantic segmentation. It is entirely based on mmseg's [implementation](https://github.com/open-mmlab/mmsegmentation/blob/master/mmseg/core/evaluation/metrics.py). I've removed any PyTorch dependency, and rely on Numpy only.

https://api.github.com/repos/huggingface/datasets/issues/3745/timeline

https://api.github.com/repos/huggingface/datasets/issues/3744

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3744/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3744/comments

https://api.github.com/repos/huggingface/datasets/issues/3744/events

https://github.com/huggingface/datasets/issues/3744

I_kwDODunzps5ECVCt

Better shards shuffling in streaming mode

open

MEMBER

Sometimes a dataset script has a `_split_generators` that returns several files as well as the corresponding metadata of each file. It often happens that they end up in two separate lists in the `gen_kwargs`: ```python gen_kwargs = { "files": [os.path.join(data_dir, filename) for filename in all_files], "metadata_files": [all_metadata[filename] for filename in all_files], } ``` It happened for Multilingual Spoken Words for example in #3666 However currently **the two lists are shuffled independently** when shuffling the shards in streaming mode. This leads to `_generate_examples` not having the right metadata for each file. To prevent this issue I suggest that we always shuffle lists of the same length the exact same way to avoid such a big but silent issue. cc @polinaeterna

https://api.github.com/repos/huggingface/datasets/issues/3744/timeline

https://api.github.com/repos/huggingface/datasets/issues/3743

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3743/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3743/comments

https://api.github.com/repos/huggingface/datasets/issues/3743/events

https://github.com/huggingface/datasets/pull/3743

PR_kwDODunzps4y-2Do

initial monash time series forecasting repository

open

CONTRIBUTOR

https://api.github.com/repos/huggingface/datasets/issues/3743/timeline

https://api.github.com/repos/huggingface/datasets/issues/3742

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3742/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3742/comments

https://api.github.com/repos/huggingface/datasets/issues/3742/events

https://github.com/huggingface/datasets/pull/3742

PR_kwDODunzps4y-1v5

Fix ValueError message formatting in int2str

closed

CONTRIBUTOR

Hi! I bumped into this particular `ValueError` during my work (because an instance of `np.int64` was passed instead of regular Python `int`), and so I had to `print(type(values))` myself. Apparently, it's just the missing `f` to make message an f-string. It ain't much for a contribution, but it's honest work. Hope it spares someone else a few seconds in the future 😃

https://api.github.com/repos/huggingface/datasets/issues/3742/timeline

https://api.github.com/repos/huggingface/datasets/issues/3741

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3741/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3741/comments

https://api.github.com/repos/huggingface/datasets/issues/3741/events

https://github.com/huggingface/datasets/pull/3741

PR_kwDODunzps4y-syt

Rm sphinx doc

closed

NONE

Checklist - [x] Update circle ci yaml - [x] Delete sphinx static & python files in docs dir - [x] Update readme in docs dir - [ ] Update docs config in setup.py

https://api.github.com/repos/huggingface/datasets/issues/3741/timeline

https://api.github.com/repos/huggingface/datasets/issues/3740

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3740/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3740/comments

https://api.github.com/repos/huggingface/datasets/issues/3740/events

https://github.com/huggingface/datasets/pull/3740

PR_kwDODunzps4y9XAP

Support streaming for pubmed

closed

CONTRIBUTOR

This PR makes some minor changes to the `pubmed` dataset to allow for `streaming=True`. Fixes #3739. Basically, I followed the C4 dataset which works in streaming mode as an example, and made the following changes: * Change URL prefix from `ftp://` to `https://` * Explicilty `open` the filename and pass the XML contents to `etree.fromstring(xml_str)` The Github diff tool makes it look like the changes are larger than they are, sorry about that. I tested locally and the `pubmed` dataset now works in both normal and streaming modes. There is some overhead at the start of each shard in streaming mode as building the XML tree online is quite slow (each pubmed .xml.gz file is ~20MB), but the overhead gets amortized over all the samples in the shard. On my laptop with a single CPU worker I am able to stream at about ~600 samples/s.

https://api.github.com/repos/huggingface/datasets/issues/3740/timeline

https://api.github.com/repos/huggingface/datasets/issues/3739

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3739/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3739/comments

https://api.github.com/repos/huggingface/datasets/issues/3739/events

https://github.com/huggingface/datasets/issues/3739

I_kwDODunzps5D-Arl

Pubmed dataset does not work in streaming mode

closed

CONTRIBUTOR

## Describe the bug Trying to use the `pubmed` dataset with `streaming=True` fails. ## Steps to reproduce the bug ```python import datasets pubmed_train = datasets.load_dataset('pubmed', split='train', streaming=True) print (next(iter(pubmed_train))) ``` ## Expected results I would expect to see the first training sample from the pubmed dataset. ## Actual results ``` Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Users/abhinav/Documents/mosaicml/mosaicml_venv/lib/python3.8/site-packages/datasets/iterable_dataset.py", line 367, in __iter__ for key, example in self._iter(): File "/Users/abhinav/Documents/mosaicml/mosaicml_venv/lib/python3.8/site-packages/datasets/iterable_dataset.py", line 364, in _iter yield from ex_iterable File "/Users/abhinav/Documents/mosaicml/mosaicml_venv/lib/python3.8/site-packages/datasets/iterable_dataset.py", line 79, in __iter__ for key, example in self.generate_examples_fn(**self.kwargs): File "/Users/abhinav/.cache/huggingface/modules/datasets_modules/datasets/pubmed/9715addf10c42a7877a2149ae0c5f2fddabefc775cd1bd9b03ac3f012b86ce46/pubmed.py", line 373, in _generate_examples tree = etree.parse(filename) File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/xml/etree/ElementTree.py", line 1202, in parse tree.parse(source, parser) File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/xml/etree/ElementTree.py", line 584, in parse source = open(source, "rb") FileNotFoundError: [Errno 2] No such file or directory: 'gzip://pubmed21n0001.xml::ftp://ftp.ncbi.nlm.nih.gov/pubmed/baseline/pubmed21n0001.xml.gz' ``` ## Environment info <!-- You can run the command `datasets-cli env` and copy-and-paste its output below. --> - `datasets` version: 1.18.2 - Platform: macOS-11.4-x86_64-i386-64bit - Python version: 3.8.2 - PyArrow version: 6.0.0 ## Comments The error looks like an issue with `open` vs. `xopen` inside the `xml` package. It looks like it's trying to open the remote source URL, which has been edited with prefix `gzip://...`. Maybe there can be an explicit `xopen` before passing the raw data to `etree`, something like: ```python # Before tree = etree.parse(filename) root = tree.getroot() # After with xopen(filename) as f: data_str = f.read() root = etree.fromstring(data_str) ```

https://api.github.com/repos/huggingface/datasets/issues/3739/timeline

https://api.github.com/repos/huggingface/datasets/issues/3738

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3738/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3738/comments

https://api.github.com/repos/huggingface/datasets/issues/3738/events

https://github.com/huggingface/datasets/issues/3738

I_kwDODunzps5D9Yad

For data-only datasets, streaming and non-streaming don't behave the same

open

CONTRIBUTOR

See https://huggingface.co/datasets/huggingface/transformers-metadata: it only contains two JSON files. In streaming mode, the files are concatenated, and thus the rows might be dictionaries with different keys: ```python import datasets as ds iterable_dataset = ds.load_dataset("huggingface/transformers-metadata", split="train", streaming=True); rows = list(iterable_dataset.take(100)) rows[0] # {'model_type': 'albert', 'pytorch': True, 'tensorflow': True, 'flax': True, 'processor': 'AutoTokenizer'} rows[99] # {'model_class': 'BartModel', 'pipeline_tag': 'feature-extraction', 'auto_class': 'AutoModel'} ``` In normal mode, an exception is thrown: ```python import datasets as ds dataset = ds.load_dataset("huggingface/transformers-metadata", split="train"); ``` ``` ValueError: Couldn't cast model_class: string pipeline_tag: string auto_class: string to {'model_type': Value(dtype='string', id=None), 'pytorch': Value(dtype='bool', id=None), 'tensorflow': Value(dtype='bool', id=None), 'flax': Value(dtype='bool', id=None), 'processor': Value(dtype='string', id=None)} because column names don't match ```

https://api.github.com/repos/huggingface/datasets/issues/3738/timeline

https://api.github.com/repos/huggingface/datasets/issues/3737

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3737/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3737/comments

https://api.github.com/repos/huggingface/datasets/issues/3737/events

https://github.com/huggingface/datasets/pull/3737

PR_kwDODunzps4y7uFf

Make RedCaps streamable

closed

CONTRIBUTOR

Make RedCaps streamable. @lhoestq Using `data/redcaps_v1.0_annotations.zip` as a download URL gives an error locally when running `datasets-cli test` (will investigate this another time)

https://api.github.com/repos/huggingface/datasets/issues/3737/timeline

https://api.github.com/repos/huggingface/datasets/issues/3736

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3736/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3736/comments

https://api.github.com/repos/huggingface/datasets/issues/3736/events

https://github.com/huggingface/datasets/pull/3736

PR_kwDODunzps4y7rMR

Local paths in common voice

open

MEMBER

Continuation of https://github.com/huggingface/datasets/pull/3664: - pass the `streaming` parameter to _split_generator - update @anton-l's code to use this parameter for `common_voice` - add a comment to explain why we use `download_and_extract` in non-streaming and `iter_archive` in streaming Now the `common_voice` dataset has a local path back in `ds["path"]`, and this field is `None` in streaming mode. cc @patrickvonplaten @anton-l @albertvillanova

https://api.github.com/repos/huggingface/datasets/issues/3736/timeline

https://api.github.com/repos/huggingface/datasets/issues/3735

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3735/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3735/comments

https://api.github.com/repos/huggingface/datasets/issues/3735/events

https://github.com/huggingface/datasets/issues/3735

I_kwDODunzps5D9FxT

Performance of `datasets` at scale

open

MEMBER

# Performance of `datasets` at 1TB scale ## What is this? During the processing of a large dataset I monitored the performance of the `datasets` library to see if there are any bottlenecks. The insights of this analysis could guide the decision making to improve the performance of the library. ## Dataset The dataset is a 1.1TB extract from GitHub with 120M code files and is stored as 5000 `.json.gz` files. The goal of the preprocessing is to remove duplicates and filter files based on their stats. While the calculating of the hashes for deduplication and stats for filtering can be parallelized the filtering itself is run with a single process. After processing the files are pushed to the hub. ## Machine The experiment was run on a `m1` machine on GCP with 96 CPU cores and 1.3TB RAM. ## Performance breakdown - Loading the data **3.5h** (_30sec_ from cache) - **1h57min** single core loading (not sure what is going on here, corresponds to second progress bar) - **1h10min** multi core json reading - **20min** remaining time before and after the two main processes mentioned above - Process the data **2h** (_20min_ from cache) - **20min** Getting reading for processing - **40min** Hashing and files stats (96 workers) - **58min** Deduplication filtering (single worker) - Save parquet files **5h** - Saving 1000 parquet files (16 workers) - Push to hub **37min** - **34min** git add - **3min** git push (several hours with `Repository.git_push()`) ## Conclusion It appears that loading and saving the data is the main bottleneck at that scale (**8.5h**) whereas processing (**2h**) and pushing the data to the hub (**0.5h**) is relatively fast. To optimize the performance at this scale it would make sense to consider such an end-to-end example and target the bottlenecks which seem to be loading from and saving to disk. The processing itself seems to run relatively fast. ## Notes - map operation on a 1TB dataset with 96 workers requires >1TB RAM - map operation does not maintain 100% CPU utilization with 96 workers - sometimes when the script crashes all the data files have a corresponding `*.lock` file in the data folder (or multiple e.g. `*.lock.lock` when it happened a several times). This causes the cache **not** to be triggered (which is significant at that scale) - i guess because there are new data files - parallelizing `to_parquet` decreased the saving time from 17h to 5h, however adding more workers at this point had almost no effect. not sure if this is: a) a bug in my parallelization logic, b) i/o limit to load data form disk to memory or c) i/o limit to write from memory to disk. - Using `Repository.git_push()` was much slower than using command line `git-lfs` - 10-20MB/s vs. 300MB/s! The `Dataset.push_to_hub()` function is even slower as it only uploads one file at a time with only a few MB/s, whereas `Repository.git_push()` pushes files in parallel (each at a similar speed). cc @lhoestq @julien-c @LysandreJik @SBrandeis

https://api.github.com/repos/huggingface/datasets/issues/3735/timeline

https://api.github.com/repos/huggingface/datasets/issues/3734

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3734/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3734/comments

https://api.github.com/repos/huggingface/datasets/issues/3734/events

https://github.com/huggingface/datasets/pull/3734

PR_kwDODunzps4y7ZU2

Fix bugs in NewsQA dataset

closed

MEMBER

Fix #3733.

https://api.github.com/repos/huggingface/datasets/issues/3734/timeline

https://api.github.com/repos/huggingface/datasets/issues/3733

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3733/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3733/comments

https://api.github.com/repos/huggingface/datasets/issues/3733/events

https://github.com/huggingface/datasets/issues/3733

I_kwDODunzps5D8zFy

Bugs in NewsQA dataset

closed

MEMBER

## Describe the bug NewsQA dataset has the following bugs: - the field `validated_answers` is an exact copy of the field `answers` but with the addition of `'count': [0]` to each dict - the field `badQuestion` does not appear in `answers` nor `validated_answers` ## Steps to reproduce the bug By inspecting the dataset script we can see that: - the parsing of `validated_answers` is a copy-paste of the one for `answers` - the `badQuestion` field is ignored in the parsing of both `answers` and `validated_answers`

https://api.github.com/repos/huggingface/datasets/issues/3733/timeline

https://api.github.com/repos/huggingface/datasets/issues/3732

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3732/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3732/comments

https://api.github.com/repos/huggingface/datasets/issues/3732/events

https://github.com/huggingface/datasets/pull/3732

PR_kwDODunzps4y7PTU

Support streaming in size estimation function in `push_to_hub`

closed

CONTRIBUTOR

This PR adds the streamable version of `os.path.getsize` (`fsspec` can return `None`, so we fall back to `fs.open` to make it more robust) to account for possible streamable paths in the nested `extra_nbytes_visitor` function inside `push_to_hub`.

https://api.github.com/repos/huggingface/datasets/issues/3732/timeline

https://api.github.com/repos/huggingface/datasets/issues/3731

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3731/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3731/comments

https://api.github.com/repos/huggingface/datasets/issues/3731/events

https://github.com/huggingface/datasets/pull/3731

PR_kwDODunzps4y5-hi

Fix Multi-News dataset metadata and card

closed

MEMBER

Fix #3730.

https://api.github.com/repos/huggingface/datasets/issues/3731/timeline

https://api.github.com/repos/huggingface/datasets/issues/3730

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3730/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3730/comments

https://api.github.com/repos/huggingface/datasets/issues/3730/events

https://github.com/huggingface/datasets/issues/3730

I_kwDODunzps5D7BYN

Checksum Error when loading multi-news dataset

closed

NONE

## Describe the bug When using the load_dataset function from datasets module to load the Multi-News dataset, does not load the dataset but throws Checksum Error instead. ## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("multi_news") ``` ## Expected results Should download and load Multi-News dataset. ## Actual results Throws the following error and cannot load data successfully: ``` NonMatchingChecksumError: Checksums didn't match for dataset source files: ['https://drive.google.com/uc?export=download&id=1vRY2wM6rlOZrf9exGTm5pXj5ExlVwJ0C'] ``` Could this issue please be looked at? Thanks!

https://api.github.com/repos/huggingface/datasets/issues/3730/timeline

https://api.github.com/repos/huggingface/datasets/issues/3729

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3729/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3729/comments

https://api.github.com/repos/huggingface/datasets/issues/3729/events

https://github.com/huggingface/datasets/issues/3729

I_kwDODunzps5D6dcq

load_dataset Error reading

open

NONE

## Describe the bug when I use load_dataset to read a txt file I find that the number of the samples is incorrect ## Steps to reproduce the bug ``` fr = open('train.txt','r',encoding='utf-8').readlines() print(len(fr)) # 1199637 datasets = load_dataset('text', data_files={'train': ['train.txt']}, streaming=False) print(len(datasets['train'])) # 1199649 ``` I also use command line operation to verify it ``` $ wc -l train.txt 1199637 train.txt ``` ## Expected results please fix that issue ## Environment info <!-- You can run the command `datasets-cli env` and copy-and-paste its output below. --> - `datasets` version: 1.8.3 - Platform:windows&linux - Python version:3.7 - PyArrow version:6.0.1

https://api.github.com/repos/huggingface/datasets/issues/3729/timeline

https://api.github.com/repos/huggingface/datasets/issues/3728

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3728/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3728/comments

https://api.github.com/repos/huggingface/datasets/issues/3728/events

https://github.com/huggingface/datasets/issues/3728

I_kwDODunzps5D6GS-

VoxPopuli

closed

MEMBER

## Adding a Dataset - **Name:** VoxPopuli - **Description:** A Large-Scale Multilingual Speech Corpus - **Paper:** https://arxiv.org/pdf/2101.00390.pdf - **Data:** https://github.com/facebookresearch/voxpopuli - **Motivation:** one of the largest (if not the largest) multilingual speech corpus: 400K hours of multilingual unlabeled speech + 17k hours of labeled speech Instructions to add a new dataset can be found [here](https://github.com/huggingface/datasets/blob/master/ADD_NEW_DATASET.md). 👀 @kahne @Molugan

https://api.github.com/repos/huggingface/datasets/issues/3728/timeline

https://api.github.com/repos/huggingface/datasets/issues/3727

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3727/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3727/comments

https://api.github.com/repos/huggingface/datasets/issues/3727/events

https://github.com/huggingface/datasets/pull/3727

PR_kwDODunzps4y34JN

Patch all module attributes in its namespace

closed

MEMBER

When patching module attributes, only those defined in its `__all__` variable were considered by default (only falling back to `__dict__` if `__all__` was None). However those are only a subset of all the module attributes in its namespace (`__dict__` variable). This PR fixes the problem of modules that have non-None `__all__` variable, but try to access an attribute present in `__dict__` (and not in `__all__`). For example, `pandas` has attribute `__version__` only present in `__dict__`. - Before version 1.4, pandas `__all__` was None, thus all attributes in `__dict__` were patched - From version 1.4, pandas `__all__` is not None, thus attributes in `__dict__` not present in `__all__` are ignored Fix #3724. CC: @severo @lvwerra

https://api.github.com/repos/huggingface/datasets/issues/3727/timeline

https://api.github.com/repos/huggingface/datasets/issues/3726

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3726/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3726/comments

https://api.github.com/repos/huggingface/datasets/issues/3726/events

https://github.com/huggingface/datasets/pull/3726

PR_kwDODunzps4y3iSv

Use config pandas version in CSV dataset builder

closed

MEMBER

Fix #3724.

https://api.github.com/repos/huggingface/datasets/issues/3726/timeline

https://api.github.com/repos/huggingface/datasets/issues/3725

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3725/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3725/comments

https://api.github.com/repos/huggingface/datasets/issues/3725/events

https://github.com/huggingface/datasets/pull/3725

PR_kwDODunzps4y3bOG

Pin pandas to avoid bug in streaming mode

closed

MEMBER

Temporarily pin pandas version to avoid bug in streaming mode (patching no longer works). Related to #3724.

https://api.github.com/repos/huggingface/datasets/issues/3725/timeline

https://api.github.com/repos/huggingface/datasets/issues/3724

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3724/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3724/comments

https://api.github.com/repos/huggingface/datasets/issues/3724/events

https://github.com/huggingface/datasets/issues/3724

I_kwDODunzps5D4SGh

Bug while streaming CSV dataset with pandas 1.4

closed

MEMBER

## Describe the bug If we upgrade to pandas `1.4`, the patching of the pandas module is no longer working ``` AttributeError: '_PatchedModuleObj' object has no attribute '__version__' ``` ## Steps to reproduce the bug ``` pip install pandas==1.4 ``` ```python from datasets import load_dataset ds = load_dataset("lvwerra/red-wine", split="train", streaming=True) item = next(iter(ds)) item ```

https://api.github.com/repos/huggingface/datasets/issues/3724/timeline

https://api.github.com/repos/huggingface/datasets/issues/3723

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3723/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3723/comments

https://api.github.com/repos/huggingface/datasets/issues/3723/events

https://github.com/huggingface/datasets/pull/3723

PR_kwDODunzps4y3RuI

Fix flatten of complex feature types

open

CONTRIBUTOR

Fix `flatten` for the following feature types: Image/Audio, Translation, and TranslationVariableLanguages. Inspired by `cast`/`table_cast`, I've introduced a `table_flatten` function to handle the Image/Audio types. CC: @SBrandeis Fix #3686.

https://api.github.com/repos/huggingface/datasets/issues/3723/timeline

https://api.github.com/repos/huggingface/datasets/issues/3722

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3722/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3722/comments

https://api.github.com/repos/huggingface/datasets/issues/3722/events

https://github.com/huggingface/datasets/pull/3722

PR_kwDODunzps4y3NrP

added electricity load diagram dataset

closed

CONTRIBUTOR

Initial Electricity Load Diagram time series dataset.

https://api.github.com/repos/huggingface/datasets/issues/3722/timeline

https://api.github.com/repos/huggingface/datasets/issues/3721

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3721/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3721/comments

https://api.github.com/repos/huggingface/datasets/issues/3721/events

https://github.com/huggingface/datasets/pull/3721

PR_kwDODunzps4yzXCd

Multi-GPU support for `FaissIndex`

open

NONE

Per #3716 , current implementation does not take into consideration that `faiss` can run on multiple GPUs. In this commit, I provided multi-GPU support for `FaissIndex` by modifying the device management in `IndexableMixin.add_faiss_index` and `FaissIndex.load`. Now users are able to pass in 1. a positive integer (as usual) to use 1 GPU 2. a negative integer `-1` to use all GPUs 3. a list of integers e.g. `[0, 1]` to run only on those GPUs 4. Of course, passing in nothing still runs on CPU. This closes: #3716

https://api.github.com/repos/huggingface/datasets/issues/3721/timeline

https://api.github.com/repos/huggingface/datasets/issues/3720

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3720/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3720/comments

https://api.github.com/repos/huggingface/datasets/issues/3720/events

https://github.com/huggingface/datasets/issues/3720

I_kwDODunzps5DzXA4

Builder Configuration Update Required on Common Voice Dataset

open

NONE

Missing language in Common Voice dataset **Link:** https://huggingface.co/datasets/common_voice I tried to call the Urdu dataset using `load_dataset("common_voice", "ur", split="train+validation")` but couldn't due to builder configuration not found. I checked the source file here for the languages support: https://github.com/huggingface/datasets/blob/master/datasets/common_voice/common_voice.py and Urdu isn't included there. I assume a quick update will fix the issue as Urdu speech is now available at the Common Voice dataset. Am I the one who added this dataset? No

https://api.github.com/repos/huggingface/datasets/issues/3720/timeline

https://api.github.com/repos/huggingface/datasets/issues/3719

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3719/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3719/comments

https://api.github.com/repos/huggingface/datasets/issues/3719/events

https://github.com/huggingface/datasets/pull/3719

PR_kwDODunzps4yyFv7

Check if indices values in `Dataset.select` are within bounds

closed

CONTRIBUTOR

Fix #3707 Instead of reusing `_check_valid_index_key` from `datasets.formatting`, I defined a new function to provide a more meaningful error message.

https://api.github.com/repos/huggingface/datasets/issues/3719/timeline

https://api.github.com/repos/huggingface/datasets/issues/3718

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3718/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3718/comments

https://api.github.com/repos/huggingface/datasets/issues/3718/events

https://github.com/huggingface/datasets/pull/3718

PR_kwDODunzps4yx8r2

Fix Evidence Infer Treatment dataset

closed

MEMBER

This PR: - fixes a bug in the script, by removing an unnamed column with the row index: fix KeyError - fix the metadata JSON, by adding both configurations (1.1 and 2.0): fix ExpectedMoreDownloadedFiles - updates the dataset card Fix #3515.

https://api.github.com/repos/huggingface/datasets/issues/3718/timeline

https://api.github.com/repos/huggingface/datasets/issues/3717

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3717/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3717/comments

https://api.github.com/repos/huggingface/datasets/issues/3717/events

https://github.com/huggingface/datasets/issues/3717

I_kwDODunzps5DyAkn

wrong condition in `Features ClassLabel encode_example`

closed

NONE

## Describe the bug The `encode_example` function in *features.py* seems to have a wrong condition. ```python if not -1 <= example_data < self.num_classes: raise ValueError(f"Class label {example_data:d} greater than configured num_classes {self.num_classes}") ``` ## Expected results The `not - 1` condition change the result of the condition. For instance, if `example_data` equals 4 and ` self.num_classes` equals 4 too, `example_data < self.num_classes` will give `False` as expected . But if i add the `not - 1` condition, `not -1 <= example_data < self.num_classes` will give `True` and raise an exception. ## Environment info - `datasets` version: 1.18.3 - Python version: 3.8.10 - PyArrow version: 7.00

https://api.github.com/repos/huggingface/datasets/issues/3717/timeline

https://api.github.com/repos/huggingface/datasets/issues/3716

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3716/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3716/comments

https://api.github.com/repos/huggingface/datasets/issues/3716/events

https://github.com/huggingface/datasets/issues/3716

I_kwDODunzps5Dwqp0

`FaissIndex` to support multiple GPU and `custom_index`

open

NONE

**Is your feature request related to a problem? Please describe.** Currently, because `device` is of the type `int | None`, to leverage `faiss-gpu`'s multi-gpu support, you need to create a `custom_index`. However, if using a `custom_index` created by e.g. `faiss.index_cpu_to_all_gpus`, then `FaissIndex.save` does not work properly because it checks the device id (which is an int, so no multiple GPUs). **Describe the solution you'd like** I would like `FaissIndex` to support multiple GPUs, by passing in a list to `add_faiss_index`. **Describe alternatives you've considered** Alternatively, I would like it to at least provide a warning cause it wasn't the behavior that I expected. **Additional context** Relavent source code here: https://github.com/huggingface/datasets/blob/6ed6ac9448311930557810383d2cfd4fe6aae269/src/datasets/search.py#L340-L349 Device management needs changing to support multiple GPUs, probably by `isinstance` calls. I can provide a PR if you like :) Thanks for reading!

https://api.github.com/repos/huggingface/datasets/issues/3716/timeline

https://api.github.com/repos/huggingface/datasets/issues/3715

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3715/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3715/comments

https://api.github.com/repos/huggingface/datasets/issues/3715/events

https://github.com/huggingface/datasets/pull/3715

PR_kwDODunzps4yuKJj

Fix problems in msr_sqa

open

NONE

The last version has many problems, 1) Errors in table load-in. Split by a single comma instead of using pandas is wrong. 2) id reduplicated in _generate_examples function. 3) Missing information of history questions which make it hard to use. I fix it refer to https://github.com/HKUNLP/UnifiedSKG. And we test it to perform normally.

https://api.github.com/repos/huggingface/datasets/issues/3715/timeline

https://api.github.com/repos/huggingface/datasets/issues/3714

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3714/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3714/comments

https://api.github.com/repos/huggingface/datasets/issues/3714/events

https://github.com/huggingface/datasets/issues/3714

I_kwDODunzps5Dt5g6

tatoeba_mt: File not found error and key error

closed

NONE

## Dataset viewer issue for 'tatoeba_mt' **Link:** https://huggingface.co/datasets/Helsinki-NLP/tatoeba_mt My data loader script does not seem to work. The files are part of the local repository but cannot be found. An example where it should work is the subset for "afr-eng". Another problem is that I do not have validation data for all subsets and I don't know how to properly check whether validation exists in the configuration before I try to download it. An example is the subset for "afr-deu". Am I the one who added this dataset ? Yes

https://api.github.com/repos/huggingface/datasets/issues/3714/timeline

https://api.github.com/repos/huggingface/datasets/issues/3713

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3713/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3713/comments

https://api.github.com/repos/huggingface/datasets/issues/3713/events

https://github.com/huggingface/datasets/pull/3713

PR_kwDODunzps4yso6D

Rm sphinx doc

closed

NONE

Checklist - [x] Update circle ci yaml - [x] Delete sphinx static & python files in docs dir - [x] Update readme in docs dir - [ ] Update docs config in setup.py

https://api.github.com/repos/huggingface/datasets/issues/3713/timeline

https://api.github.com/repos/huggingface/datasets/issues/3712

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3712/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3712/comments

https://api.github.com/repos/huggingface/datasets/issues/3712/events

https://github.com/huggingface/datasets/pull/3712

PR_kwDODunzps4ynVYy

Fix the error of msr_sqa dataset

closed

NONE

Fix the error of _load_table_data function in msr_sqa dataset, it is wrong to use comma to split each row.

https://api.github.com/repos/huggingface/datasets/issues/3712/timeline

https://api.github.com/repos/huggingface/datasets/issues/3711

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3711/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3711/comments

https://api.github.com/repos/huggingface/datasets/issues/3711/events

https://github.com/huggingface/datasets/pull/3711

PR_kwDODunzps4ymmlK

Fix the error of _load_table_data function in msr_sqa dataset

closed

NONE

The _load_table_data function from the last version is wrong, it is wrong to use comma to split each row.

https://api.github.com/repos/huggingface/datasets/issues/3711/timeline

https://api.github.com/repos/huggingface/datasets/issues/3710

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3710/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3710/comments

https://api.github.com/repos/huggingface/datasets/issues/3710/events

https://github.com/huggingface/datasets/pull/3710

PR_kwDODunzps4ymQMQ

Fix CI code quality issue

closed

MEMBER

Fix CI code quality issue introduced by #3695.

https://api.github.com/repos/huggingface/datasets/issues/3710/timeline

https://api.github.com/repos/huggingface/datasets/issues/3709

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3709/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3709/comments

https://api.github.com/repos/huggingface/datasets/issues/3709/events

https://github.com/huggingface/datasets/pull/3709

PR_kwDODunzps4yi0J4

Set base path to hub url for canonical datasets

closed

MEMBER

This should allow canonical datasets to use relative paths to download data files from the Hub cc @polinaeterna this will be useful if we have audio datasets that are canonical and for which you'd like to host data files

https://api.github.com/repos/huggingface/datasets/issues/3709/timeline

https://api.github.com/repos/huggingface/datasets/issues/3708

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3708/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3708/comments

https://api.github.com/repos/huggingface/datasets/issues/3708/events

https://github.com/huggingface/datasets/issues/3708

I_kwDODunzps5Dh7nS

Loading JSON gets stuck with many workers/threads

open

MEMBER

## Describe the bug Loading a JSON dataset with `load_dataset` can get stuck when running on a machine with many CPUs. This is especially an issue when loading a large dataset on a large machine. ## Steps to reproduce the bug I originally created the following script to reproduce the issue: ```python from datasets import load_dataset from multiprocessing import Process from tqdm import tqdm import datasets from transformers import set_seed def run_tasks_in_parallel(tasks, ds_list): for _ in tqdm(range(1000)): print('new batch') running_tasks = [Process(target=task, args=(ds, i)) for i, (task, ds) in enumerate(zip(tasks, ds_list))] for running_task in running_tasks: running_task.start() for running_task in running_tasks: running_task.join() def get_dataset(): dataset_name = 'transformersbook/codeparrot' ds = load_dataset(dataset_name+'-train', split="train", streaming=True) ds = ds.shuffle(buffer_size=1000, seed=1) return iter(ds) def get_next_element(ds, process_id, N=10000): for _ in range(N): _ = next(ds)['content'] print(f'process {process_id} done') return set_seed(1) datasets.utils.logging.set_verbosity_debug() n_processes = 8 tasks = [get_next_element for _ in range(n_processes)] args = [get_dataset() for _ in range(n_processes)] run_tasks_in_parallel(tasks, args) ``` Today I noticed that it can happen when running it on a single process on a machine with many cores without streaming. So just `load_dataset("transformersbook/codeparrot-train")` alone might cause the issue after waiting long enough or trying many times. It's a slightly random process which makes it especially hard to track down. When I encountered it today it had already processed 17GB of data (the size of the cache folder when it got stuck) before getting stuck. Here's my current understanding of the error. As far as I can tell it happens in the following block: https://github.com/huggingface/datasets/blob/be701e9e89ab38022612c7263edc015bc7feaff9/src/datasets/packaged_modules/json/json.py#L119-L139 When the try on line 121 fails and the `block_size` is increased it can happen that it can't read the JSON again and gets stuck indefinitely. A hint that points in that direction is that increasing the `chunksize` argument decreases the chance of getting stuck and vice versa. Maybe it is an issue with a lock on the file that is not properly released. ## Expected results Read a JSON before the end of the universe. ## Actual results Read a JSON not before the end of the universe. ## Environment info <!-- You can run the command `datasets-cli env` and copy-and-paste its output below. --> - `datasets` version: 1.18.3 - Platform: Linux-4.19.0-18-cloud-amd64-x86_64-with-glibc2.28 - Python version: 3.9.10 - PyArrow version: 7.0.0 @lhoestq we dicsussed this a while ago. @albertvillanova we discussed this today :)

https://api.github.com/repos/huggingface/datasets/issues/3708/timeline

https://api.github.com/repos/huggingface/datasets/issues/3707

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3707/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3707/comments

https://api.github.com/repos/huggingface/datasets/issues/3707/events

https://github.com/huggingface/datasets/issues/3707

I_kwDODunzps5DhEUP

`.select`: unexpected behavior with `indices`

closed

NONE

## Describe the bug The `.select` method will not throw when sending `indices` bigger than the dataset length; `indices` will be wrapped instead. This behavior is not documented anywhere, and is not intuitive. ## Steps to reproduce the bug ```python from datasets import Dataset ds = Dataset.from_dict({"text": ["d", "e", "f"], "label": [4, 5, 6]}) res1 = ds.select([1, 2, 3])['text'] res2 = ds.select([1000])['text'] ``` ## Expected results Both results should throw an `Error`. ## Actual results `res1` will give `['e', 'f', 'd']` `res2` will give `['e']` ## Environment info Bug found from this environment: - `datasets` version: 1.16.1 - Platform: macOS-10.16-x86_64-i386-64bit - Python version: 3.8.7 - PyArrow version: 6.0.1 It was also replicated on `master`.

https://api.github.com/repos/huggingface/datasets/issues/3707/timeline

https://api.github.com/repos/huggingface/datasets/issues/3706

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3706/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3706/comments

https://api.github.com/repos/huggingface/datasets/issues/3706/events

https://github.com/huggingface/datasets/issues/3706

I_kwDODunzps5DfEn6

Unable to load dataset 'big_patent'

closed

NONE

## Describe the bug Unable to load the "big_patent" dataset ## Steps to reproduce the bug ```python load_dataset('big_patent', 'd', 'validation') ``` ## Expected results Download big_patents' validation split from the 'd' subset ## Getting an error saying: {FileNotFoundError}Local file ..\huggingface\datasets\downloads\6159313604f4f2c01e7d1cac52139343b6c07f73f6de348d09be6213478455c5\bigPatentData\train.tar.gz doesn't exist ## Environment info <!-- You can run the command `datasets-cli env` and copy-and-paste its output below. --> - `datasets` version:1.18.3 - Platform: Windows - Python version:3.8 - PyArrow version:7.0.0

https://api.github.com/repos/huggingface/datasets/issues/3706/timeline

https://api.github.com/repos/huggingface/datasets/issues/3705

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3705/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3705/comments

https://api.github.com/repos/huggingface/datasets/issues/3705/events

https://github.com/huggingface/datasets/pull/3705

PR_kwDODunzps4yfhyj

Raise informative error when loading a save_to_disk dataset

closed

MEMBER

People recurrently report error when trying to load a dataset (using `load_dataset`) that was previously saved using `save_to_disk`. This PR raises an informative error message telling them they should use `load_from_disk` instead. Close #3700.

https://api.github.com/repos/huggingface/datasets/issues/3705/timeline

https://api.github.com/repos/huggingface/datasets/issues/3704

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3704/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3704/comments

https://api.github.com/repos/huggingface/datasets/issues/3704/events

https://github.com/huggingface/datasets/issues/3704

I_kwDODunzps5DeZmH

OSCAR-2109 datasets are misaligned and truncated

closed

NONE

## Describe the bug The `oscar-corpus/OSCAR-2109` data appears to be misaligned and truncated by the dataset builder for subsets that contain more than one part and for cases where the texts contain non-unix newlines. ## Steps to reproduce the bug A few examples, although I'm not sure how deterministic the particular (mis)alignment is in various configurations: ```python from datasets import load_dataset dataset = load_dataset("oscar-corpus/OSCAR-2109", "deduplicated_fi", split="train", use_auth_token=True) entry = dataset[0] # entry["text"] is from fi_part_3.txt.gz # entry["meta"] is from fi_meta_part_2.jsonl.gz dataset = load_dataset("oscar-corpus/OSCAR-2109", "deduplicated_no", split="train", use_auth_token=True) entry = dataset[900000] # entry["text"] is from no_part_3.txt.gz and contains a blank line # entry["meta"] is from no_meta_part_1.jsonl.gz dataset = load_dataset("oscar-corpus/OSCAR-2109", "deduplicated_mk", split="train", streaming=True, use_auth_token=True) # 9088 texts in the dataset are empty ``` For `deduplicated_fi`, all exported raw texts from the dataset are 17GB rather than 20GB as reported in the data splits overview table. The token count with `wc -w` for the raw texts is 2,067,556,874 rather than the expected 2,357,264,196 from the data splits table. For `deduplicated_no` all exported raw texts contain 624,040,887 rather than the expected 776,354,517 tokens. For `deduplicated_mk` it is 122,236,936 rather than 134,544,934 tokens. I'm not expecting the `wc -w` counts to line up exactly with the data splits table, but for comparison the `wc -w` count for `deduplicated_mk` on the raw texts is 134,545,424. ## Issues * The meta / text files are not paired correctly when loading, so the extracted texts do not have the right offsets, the metadata is not associated with the correct text, and the text files may not be processed to the end or may be processed beyond the end (empty texts). * The line count offset is not reset per file so the texts aren't aligned to the right offsets in any parts beyond the first part, leading to truncation when in effect blank lines are not skipped. * Non-unix newline characters are treated as newlines when reading the text files while the metadata only counts unix newlines for its line offsets, leading to further misalignments between the metadata and the extracted texts, and which also results in truncation. ## Expected results All texts from the OSCAR release are extracted according to the metadata and aligned with the correct metadata. ## Fixes Not necessarily the exact fixes/checks you may want to use (I didn't test all languages or do any cross-platform testing, I'm not sure all the details are compatible with streaming), however to highlight the issues: ```diff diff --git a/OSCAR-2109.py b/OSCAR-2109.py index bbac1076..5eee8de7 100644 --- a/OSCAR-2109.py +++ b/OSCAR-2109.py @@ -20,6 +20,7 @@ import collections import gzip import json +import os import datasets @@ -387,9 +388,20 @@ class Oscar2109(datasets.GeneratorBasedBuilder): with open(checksum_file, encoding="utf-8") as f: data_filenames = [line.split()[1] for line in f if line] data_urls = [self.config.base_data_path + data_filename for data_filename in data_filenames] - text_files = dl_manager.download([url for url in data_urls if url.endswith(".txt.gz")]) - metadata_files = dl_manager.download([url for url in data_urls if url.endswith(".jsonl.gz")]) + # sort filenames so corresponding parts are aligned + text_files = sorted(dl_manager.download([url for url in data_urls if url.endswith(".txt.gz")])) + metadata_files = sorted(dl_manager.download([url for url in data_urls if url.endswith(".jsonl.gz")])) + assert len(text_files) == len(metadata_files) metadata_and_text_files = list(zip(metadata_files, text_files)) + for meta_path, text_path in metadata_and_text_files: + # check that meta/text part numbers are the same + if "part" in os.path.basename(text_path): + assert ( + os.path.basename(text_path).replace(".txt.gz", "").split("_")[-1] + == os.path.basename(meta_path).replace(".jsonl.gz", "").split("_")[-1] + ) + else: + assert len(metadata_and_text_files) == 1 return [ datasets.SplitGenerator(name=datasets.Split.TRAIN, gen_kwargs={"metadata_and_text_files": metadata_and_text_files}), ] @@ -397,10 +409,14 @@ class Oscar2109(datasets.GeneratorBasedBuilder): def _generate_examples(self, metadata_and_text_files): """This function returns the examples in the raw (text) form by iterating on all the files.""" id_ = 0 - offset = 0 for meta_path, text_path in metadata_and_text_files: + # line offsets are per text file + offset = 0 logger.info("generating examples from = %s", text_path) - with gzip.open(open(text_path, "rb"), "rt", encoding="utf-8") as text_f: + # some texts contain non-Unix newlines that should not be + # interpreted as line breaks for the line counts in the metadata + # with readline() + with gzip.open(open(text_path, "rb"), "rt", encoding="utf-8", newline="\n") as text_f: with gzip.open(open(meta_path, "rb"), "rt", encoding="utf-8") as meta_f: for line in meta_f: # read meta @@ -411,7 +427,12 @@ class Oscar2109(datasets.GeneratorBasedBuilder): offset += 1 text_f.readline() # read text - text = "".join([text_f.readline() for _ in range(meta["nb_sentences"])]).rstrip() + text_lines = [text_f.readline() for _ in range(meta["nb_sentences"])] + # all lines contain text (no blank lines or EOF) + assert all(text_lines) + assert "\n" not in text_lines offset += meta["nb_sentences"] + # only strip the trailing newline + text = "".join(text_lines).rstrip("\n") yield id_, {"id": id_, "text": text, "meta": meta} id_ += 1 ``` I've tested this with a number of smaller deduplicated languages with 1-20 parts and the resulting datasets looked correct in terms of word count and size when compared to the data splits table and raw texts, and the text/metadata alignments were correct in all my spot checks. However, there are many many languages I didn't test and I'm not sure that there aren't any texts containing blank lines in the corpus, for instance. For the cases I tested, the assertions related to blank lines and EOF made it easier to verify that the text and metadata were aligned as intended, since there would be little chance of spurious alignments of variable-length texts across so much data.

https://api.github.com/repos/huggingface/datasets/issues/3704/timeline

https://api.github.com/repos/huggingface/datasets/issues/3703

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3703/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3703/comments

https://api.github.com/repos/huggingface/datasets/issues/3703/events

https://github.com/huggingface/datasets/issues/3703

I_kwDODunzps5DdykU

ImportError: To be able to use this metric, you need to install the following dependencies['seqeval'] using 'pip install seqeval' for instance'

open

NONE

hi : I want to use the seqeval indicator because of direct load_ When metric ('seqeval '), it will prompt that the network connection fails. So I downloaded the seqeval Py to load locally. Loading code: metric = load_ metric(path='mymetric/seqeval/seqeval.py') But tips: Traceback (most recent call last): File "/home/ubuntu/Python3.6_project/zyf_project/transformers/examples/pytorch/token-classification/run_ner.py", line 604, in <module> main() File "/home/ubuntu/Python3.6_project/zyf_project/transformers/examples/pytorch/token-classification/run_ner.py", line 481, in main metric = load_metric(path='mymetric/seqeval/seqeval.py') File "/home/ubuntu/Python3.6_project/zyf_project/transformers_venv_0209/lib/python3.7/site-packages/datasets/load.py", line 610, in load_metric dataset=False, File "/home/ubuntu/Python3.6_project/zyf_project/transformers_venv_0209/lib/python3.7/site-packages/datasets/load.py", line 450, in prepare_module f"To be able to use this {module_type}, you need to install the following dependencies" ImportError: To be able to use this metric, you need to install the following dependencies['seqeval'] using 'pip install seqeval' for instance' **What should I do? Please help me, thank you**

https://api.github.com/repos/huggingface/datasets/issues/3703/timeline

https://api.github.com/repos/huggingface/datasets/issues/3702

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3702/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3702/comments

https://api.github.com/repos/huggingface/datasets/issues/3702/events

https://github.com/huggingface/datasets/pull/3702

PR_kwDODunzps4yahKc

Update the address to use https

open

NONE

The http address doesn't work anymore

https://api.github.com/repos/huggingface/datasets/issues/3702/timeline

https://api.github.com/repos/huggingface/datasets/issues/3701

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3701/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3701/comments

https://api.github.com/repos/huggingface/datasets/issues/3701/events

https://github.com/huggingface/datasets/pull/3701

PR_kwDODunzps4yZ8Dw

Pin ElasticSearch

closed

MEMBER

Until we manage to support ES 8.0, I'm setting the version to `<8.0.0` Currently we're getting this error on 8.0: ```python ValueError: Either 'hosts' or 'cloud_id' must be specified ``` When instantiating a `Elasticsearch()` object

https://api.github.com/repos/huggingface/datasets/issues/3701/timeline

https://api.github.com/repos/huggingface/datasets/issues/3700

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3700/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3700/comments

https://api.github.com/repos/huggingface/datasets/issues/3700/events

https://github.com/huggingface/datasets/issues/3700

I_kwDODunzps5DXkjQ

Unable to load a dataset

closed

NONE

## Describe the bug Unable to load a dataset from Huggingface that I have just saved. ## Steps to reproduce the bug On Google colab `! pip install datasets ` `from datasets import load_dataset` `my_path = "wiki_dataset"` `dataset = load_dataset('wikipedia', "20200501.fr")` `dataset.save_to_disk(my_path)` `dataset = load_dataset(my_path)` ## Expected results Loading the dataset ## Actual results ValueError: Couldn't cast _data_files: list<item: struct<filename: string>> child 0, item: struct<filename: string> child 0, filename: string _fingerprint: string _format_columns: null _format_kwargs: struct<> _format_type: null _indexes: struct<> _output_all_columns: bool _split: string to {'builder_name': Value(dtype='string', id=None), 'citation': Value(dtype='string', id=None), 'config_name': Value(dtype='string', id=None), 'dataset_size': Value(dtype='int64', id=None), 'description': Value(dtype='string', id=None), 'download_checksums': {}, 'download_size': Value(dtype='int64', id=None), 'features': {'title': {'dtype': Value(dtype='string', id=None), 'id': Value(dtype='null', id=None), '_type': Value(dtype='string', id=None)}, 'text': {'dtype': Value(dtype='string', id=None), 'id': Value(dtype='null', id=None), '_type': Value(dtype='string', id=None)}}, 'homepage': Value(dtype='string', id=None), 'license': Value(dtype='string', id=None), 'post_processed': Value(dtype='null', id=None), 'post_processing_size': Value(dtype='null', id=None), 'size_in_bytes': Value(dtype='int64', id=None), 'splits': {'train': {'name': Value(dtype='string', id=None), 'num_bytes': Value(dtype='int64', id=None), 'num_examples': Value(dtype='int64', id=None), 'dataset_name': Value(dtype='string', id=None)}}, 'supervised_keys': Value(dtype='null', id=None), 'task_templates': Value(dtype='null', id=None), 'version': {'version_str': Value(dtype='string', id=None), 'description': Value(dtype='string', id=None), 'major': Value(dtype='int64', id=None), 'minor': Value(dtype='int64', id=None), 'patch': Value(dtype='int64', id=None)}} because column names don't match ## Environment info - `datasets` version: 1.18.3 - Platform: Linux-5.4.144+-x86_64-with-Ubuntu-18.04-bionic - Python version: 3.7.12 - PyArrow version: 6.0.1

https://api.github.com/repos/huggingface/datasets/issues/3700/timeline

https://api.github.com/repos/huggingface/datasets/issues/3699

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3699/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3699/comments

https://api.github.com/repos/huggingface/datasets/issues/3699/events

https://github.com/huggingface/datasets/pull/3699

PR_kwDODunzps4yY49I

Add dev-only config to Natural Questions dataset

closed

MEMBER

As suggested by @lhoestq and @thomwolf, a new config has been added to Natural Questions dataset, so that only dev split can be downloaded. Fix #413.

https://api.github.com/repos/huggingface/datasets/issues/3699/timeline

https://api.github.com/repos/huggingface/datasets/issues/3698

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3698/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3698/comments

https://api.github.com/repos/huggingface/datasets/issues/3698/events

https://github.com/huggingface/datasets/pull/3698

PR_kwDODunzps4yXtyQ

Add finetune-data CodeFill

open

NONE

https://api.github.com/repos/huggingface/datasets/issues/3698/timeline

https://api.github.com/repos/huggingface/datasets/issues/3697

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3697/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3697/comments

https://api.github.com/repos/huggingface/datasets/issues/3697/events

https://github.com/huggingface/datasets/pull/3697

PR_kwDODunzps4yXeXo

Add code-fill datasets for pretraining/finetuning/evaluating

open

NONE

https://api.github.com/repos/huggingface/datasets/issues/3697/timeline

https://api.github.com/repos/huggingface/datasets/issues/3696

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3696/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3696/comments

https://api.github.com/repos/huggingface/datasets/issues/3696/events

https://github.com/huggingface/datasets/pull/3696

PR_kwDODunzps4yXXgH

Force unique keys in newsqa dataset

closed

MEMBER

Currently, it may raise `DuplicatedKeysError`. Fix #3630.

https://api.github.com/repos/huggingface/datasets/issues/3696/timeline

https://api.github.com/repos/huggingface/datasets/issues/3695

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3695/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3695/comments

https://api.github.com/repos/huggingface/datasets/issues/3695/events

https://github.com/huggingface/datasets/pull/3695

PR_kwDODunzps4yXP44

Fix ClassLabel to/from dict when passed names_file

closed

MEMBER

Currently, `names_file` is a field of the data class `ClassLabel`, thus appearing when transforming it to dict (when saving infos). Afterwards, when trying to read it from infos, it conflicts with the other field `names`. This PR, removes `names_file` as a field of the data class `ClassLabel`. - it is only used at instantiation to generate the `labels` field Fix #3631.

https://api.github.com/repos/huggingface/datasets/issues/3695/timeline

https://api.github.com/repos/huggingface/datasets/issues/3693

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/3693/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/3693/comments

https://api.github.com/repos/huggingface/datasets/issues/3693/events

https://github.com/huggingface/datasets/pull/3693

PR_kwDODunzps4yTTcQ

Standardize to `Example::`

closed