Q:

Initializing BitmapSource with array of pixels

I am trying to marshal a native image data structure to BitmapSource.
Here's the native struct:
struct Bitmap_8Bit
        {
        public:
            unsigned char* data;
            int stride;
            int rows;
            int cols;
            int nChannels; //either 1 or 3. in case of three the order of the channels is BGR
        };

And here's my marshaling function:
template<>
        inline
            System::Windows::Media::Imaging::BitmapSource^ marshal_as<System::Windows::Media::Imaging::BitmapSource^, Bitmap_8Bit>(const Bitmap_8Bit& nativeBitmap)
        {
            System::Windows::Media::PixelFormat format = System::Windows::Media::PixelFormats::Default;
            System::Windows::Media::Imaging::BitmapPalette^ palette = nullptr;
            if (nativeBitmap.nChannels == 1)
            {
                format = System::Windows::Media::PixelFormats::Gray8;
                palette = System::Windows::Media::Imaging::BitmapPalettes::Gray256;
            }
            else if (nativeBitmap.nChannels == 3)
            {
                format = System::Windows::Media::PixelFormats::Bgr24;
                palette = System::Windows::Media::Imaging::BitmapPalettes::Halftone256;
            }
            else
            {
                throw gcnew System::InvalidOperationException("Unsupported number of channels " + nativeBitmap.nChannels);
            }

            //copy data
            int pixelDataLength = nativeBitmap.rows*nativeBitmap.stride;
            System::IntPtr source = System::IntPtr(nativeBitmap.data);

            cli::array<unsigned char>^ buffer = gcnew cli::array<unsigned char>(pixelDataLength);
            System::Runtime::InteropServices::Marshal::Copy(source, buffer, 0, pixelDataLength);

             System::Windows::Media::Imaging::BitmapSource^ managedBitmap = 
                 System::Windows::Media::Imaging::BitmapSource::Create(nativeBitmap.cols, nativeBitmap.rows, 
                 96, 96, 
                 format, palette, 
                 buffer, nativeBitmap.stride);

            return managedBitmap;
        }

I am testing my function on a simple single channel case:
BSII::IP::Bitmap_8Bit native;
native.cols = 8;
native.rows = 4;
native.nChannels = 1;
native.stride = 8;
int dataLength = native.stride * native.rows;
native.data = new unsigned char[dataLength];

unsigned char gray = 0;
for (int i = 0; i < native.rows; ++i)
{
    for (int j = 0; j < native.cols; ++j)
    {
        native.data[native.stride*i + j] = gray;
        gray += 10;
    }
}

System::Windows::Media::Imaging::BitmapSource^ managed = msclr::interop::marshal_as<System::Windows::Media::Imaging::BitmapSource^>(native);

System::IO::FileStream^ stream = gcnew System::IO::FileStream("c:\\workspace\\temp\\managed.bmp", System::IO::FileMode::Create);
System::Windows::Media::Imaging::BmpBitmapEncoder^ encoder = gcnew System::Windows::Media::Imaging::BmpBitmapEncoder();
System::Windows::Media::Imaging::BitmapFrame^ bitmapFrame = System::Windows::Media::Imaging::BitmapFrame::Create(managed);
encoder->Frames->Add(bitmapFrame);
encoder->Save(stream);
stream->Close();

This doesn't work. When I debug it I see that the buffer array has the correct values inside, but when I save the BitmapSource to an image, it doesn't look the way it's supposed to.    
I also tried using nullptr for palette instead of Grey256 or Halftone256 and it didn't work either.
I think I am  missing something in the usage of BitmapSource. Any ideas?
Thanks,
Dina

A:

Use PngBitmapEncoder instead of BmpBitmapEncoder. BmpBitmapEncoder deforms the image.
With PngBitmapEncoder the example works normally.
Also for performance reasons try using:
BitmapSource.Create(Int32, Int32, Double, Double, PixelFormat, BitmapPalette, 
    IntPtr, Int32, Int32) 

instead of 
BitmapSource.Create(Int32, Int32, Double, Double, PixelFormat, BitmapPalette, 
    Array, Int32)

