meg HF staff commited on
Commit
fa57f05
1 Parent(s): 1358bcc

Minimal edit for directory structure assumption.

Browse files

The code appears to assume a certain directory structure, where only files (not another directory) will be found.
Suggesting adding a check so that only files will be retrieved.
However, I would write this function differently in a few ways -- do let me know if you'd prefer a larger suggestion on this!

Files changed (1) hide show
  1. src/populate.py +1 -1
src/populate.py CHANGED
@@ -39,7 +39,7 @@ def get_evaluation_queue_df(save_path: str, cols: list) -> list[pd.DataFrame]:
39
  all_evals.append(data)
40
  elif ".md" not in entry:
41
  # this is a folder
42
- sub_entries = [e for e in os.listdir(f"{save_path}/{entry}") if not e.startswith(".")]
43
  for sub_entry in sub_entries:
44
  file_path = os.path.join(save_path, entry, sub_entry)
45
  with open(file_path) as fp:
 
39
  all_evals.append(data)
40
  elif ".md" not in entry:
41
  # this is a folder
42
+ sub_entries = [e for e in os.listdir(f"{save_path}/{entry}") if os.isfile(e) and not e.startswith(".")]
43
  for sub_entry in sub_entries:
44
  file_path = os.path.join(save_path, entry, sub_entry)
45
  with open(file_path) as fp: