Makes Model Cards optional

src/scripts/update_all_request_files.py

@@ -32,36 +32,37 @@ def update_models(file_path, models):
             still_on_hub, error, model_config = is_model_on_hub(
                 model_name=model_id, revision=data.get("revision"), trust_remote_code=True, test_tokenizer=False, token=H4_TOKEN
             )
-            # If the model doesn't have a model card or a license, we consider it's deleted
-            if still_on_hub:
-                try:
-                    if check_model_card(model_id)[0] is False:
-                        still_on_hub = False
-                except Exception:
-                    still_on_hub = False
             data['still_on_hub'] = still_on_hub
 
-            #  Check if the model is a merge
-            is_merge_from_metadata = False
-            is_moe_from_metadata = False
+            tags = []
+
             if still_on_hub:
-                model_card = ModelCard.load(model_id)
-
-                # Storing the model metadata
-                tags = []
-                if model_card.data.tags:
-                    is_merge_from_metadata = "merge" in model_card.data.tags
-                    is_moe_from_metadata = "moe" in model_card.data.tags
-                merge_keywords = ["mergekit", "merged model", "merge model", "merging"]
-                # If the model is a merge but not saying it in the metadata, we flag it
-                is_merge_from_model_card = any(keyword in model_card.text.lower() for keyword in merge_keywords)
-                if is_merge_from_model_card or is_merge_from_metadata:
-                    tags.append("merge")
-                    if not is_merge_from_metadata:
-                        tags.append("flagged:undisclosed_merge")
+                model = model_id
+                modelcard_OK, error_msg = check_model_card(model)
+                model_card = None
+                if modelcard_OK:
+                    model_card = ModelCard.load(model)
+                
+                is_merge_from_metadata = False
+                is_moe_from_metadata = False
+                is_merge_from_model_card = False
+                is_moe_from_model_card = False
+
+                # Storing the model tags
                 moe_keywords = ["moe", "mixture of experts", "mixtral"]
-                is_moe_from_model_card = any(keyword in model_card.text.lower() for keyword in moe_keywords)
-                is_moe_from_name = "moe" in model_id.lower().replace("/", "-").replace("_", "-").split("-")
+                if modelcard_OK:
+                    if model_card.data.tags:
+                        is_merge_from_metadata = "merge" in model_card.data.tags
+                        is_moe_from_metadata = "moe" in model_card.data.tags
+                    merge_keywords = ["mergekit", "merged model", "merge model", "merging"]
+                    # If the model is a merge but not saying it in the metadata, we flag it
+                    is_merge_from_model_card = any(keyword in model_card.text.lower() for keyword in merge_keywords)
+                    if is_merge_from_model_card or is_merge_from_metadata:
+                        tags.append("merge")
+                        if not is_merge_from_metadata:
+                            tags.append("flagged:undisclosed_merge")
+                    is_moe_from_model_card = any(keyword in model_card.text.lower() for keyword in moe_keywords)    
+                is_moe_from_name = "moe" in model.lower().replace("/", "-").replace("_", "-").split("-")
                 if is_moe_from_model_card or is_moe_from_name or is_moe_from_metadata:
                     tags.append("moe")
                     if not is_moe_from_metadata:

src/submission/submit.py

@@ -94,30 +94,34 @@ def add_new_eval(
     try:
         license = model_info.cardData["license"]
     except Exception:
-        return styled_error("Please select a license for your model")
+        license = None
+        #return styled_error("Please select a license for your model")
 
     modelcard_OK, error_msg = check_model_card(model)
-    if not modelcard_OK:
-        return styled_error(error_msg)
+    model_card = None
+    if modelcard_OK:
+        model_card = ModelCard.load(model)
     
     is_merge_from_metadata = False
     is_moe_from_metadata = False
-    model_card = ModelCard.load(model)
+    is_merge_from_model_card = False
+    is_moe_from_model_card = False
 
     # Storing the model tags
     tags = []
-    if model_card.data.tags:
-        is_merge_from_metadata = "merge" in model_card.data.tags
-        is_moe_from_metadata = "moe" in model_card.data.tags
-    merge_keywords = ["mergekit", "merged model", "merge model", "merging"]
-    # If the model is a merge but not saying it in the metadata, we flag it
-    is_merge_from_model_card = any(keyword in model_card.text.lower() for keyword in merge_keywords)
-    if is_merge_from_model_card or is_merge_from_metadata:
-        tags.append("merge")
-        if not is_merge_from_metadata:
-            tags.append("flagged:undisclosed_merge")
     moe_keywords = ["moe", "mixture of experts", "mixtral"]
-    is_moe_from_model_card = any(keyword in model_card.text.lower() for keyword in moe_keywords)
+    if modelcard_OK:
+        if model_card.data.tags:
+            is_merge_from_metadata = "merge" in model_card.data.tags
+            is_moe_from_metadata = "moe" in model_card.data.tags
+        merge_keywords = ["mergekit", "merged model", "merge model", "merging"]
+        # If the model is a merge but not saying it in the metadata, we flag it
+        is_merge_from_model_card = any(keyword in model_card.text.lower() for keyword in merge_keywords)
+        if is_merge_from_model_card or is_merge_from_metadata:
+            tags.append("merge")
+            if not is_merge_from_metadata:
+                tags.append("flagged:undisclosed_merge")
+        is_moe_from_model_card = any(keyword in model_card.text.lower() for keyword in moe_keywords)    
     is_moe_from_name = "moe" in model.lower().replace("/", "-").replace("_", "-").split("-")
     if is_moe_from_model_card or is_moe_from_name or is_moe_from_metadata:
         tags.append("moe")