Datasets:

DanielPFlorian

/

Transformers-Github-Issues

like 0

{ "login": "arda1906", "id": 157398066, "node_id": "U_kgDOCWG0Mg", "avatar_url": "https://avatars.githubusercontent.com/u/157398066?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arda1906", "html_url": "https://github.com/arda1906", "followers_url": "https://api.github.com/users/arda1906/followers", "following_url": "https://api.github.com/users/arda1906/following{/other_user}", "gists_url": "https://api.github.com/users/arda1906/gists{/gist_id}", "starred_url": "https://api.github.com/users/arda1906/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arda1906/subscriptions", "organizations_url": "https://api.github.com/users/arda1906/orgs", "repos_url": "https://api.github.com/users/arda1906/repos", "events_url": "https://api.github.com/users/arda1906/events{/privacy}", "received_events_url": "https://api.github.com/users/arda1906/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @arda1906, thanks for raising an issue!\r\n\r\nWithout more information about the error i.e. what does it mean to \"not work\" and what is the expected behaviour? we won't be able to help you. \r\n\r\nFrom the snippet, it's not entirely clear how the code is being run, but there are two separate commands which should be entered on separate lines or cells\r\n\r\n```py\r\nfrom huggingface_hub import notebook_login\r\n\r\nnotebook_login()\r\n```", "hi,I am giving details\r\n> I am trying this code to train the model\r\n\r\n>```python\r\n>trainer = Trainer(model=model,args=training_args,\r\n compute_metrics=compute_metrics,\r\n train_dataset=emotion_encoded[\"train\"],\r\n eval_dataset=emotion_encoded[\"validation\"],\r\n tokenizer=tokenizer)\r\ntrainer.train()\r\n\r\n>and I am facing this error:\r\n>LocalTokenNotFoundError: Token is required (`token=True`), but no token found. You need to provide a token or be logged in to Hugging Face with `huggingface-cli login` or `huggingface_hub.login`. See https://huggingface.co/settings/tokens.\r\n>I have thought to apply the my token in the jupyter notebook like this:\r\n>```\r\n> ```python\r\n> from huggingface_hub import notebook_login\r\n> \r\n> notebook_login()\r\n>\r\n> ```\r\n>help me please:(\r\n", "Hi @arda1906, are you running the notebook login cells before calling Trainer? Are you passing in a token to the interactive text box that appears when running notebook_login? ", "> Hi @arda1906, are you running the notebook login cells before calling Trainer? Are you passing in a token to the interactive text box that appears when running notebook_login?\r\n\r\n\r\n" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29161/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "oh-gnues-iohc", "id": 79557937, "node_id": "MDQ6VXNlcjc5NTU3OTM3", "avatar_url": "https://avatars.githubusercontent.com/u/79557937?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oh-gnues-iohc", "html_url": "https://github.com/oh-gnues-iohc", "followers_url": "https://api.github.com/users/oh-gnues-iohc/followers", "following_url": "https://api.github.com/users/oh-gnues-iohc/following{/other_user}", "gists_url": "https://api.github.com/users/oh-gnues-iohc/gists{/gist_id}", "starred_url": "https://api.github.com/users/oh-gnues-iohc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oh-gnues-iohc/subscriptions", "organizations_url": "https://api.github.com/users/oh-gnues-iohc/orgs", "repos_url": "https://api.github.com/users/oh-gnues-iohc/repos", "events_url": "https://api.github.com/users/oh-gnues-iohc/events{/privacy}", "received_events_url": "https://api.github.com/users/oh-gnues-iohc/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29160/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29160", "html_url": "https://github.com/huggingface/transformers/pull/29160", "diff_url": "https://github.com/huggingface/transformers/pull/29160.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29160.patch", "merged_at": null }

{ "login": "Ki-Seki", "id": 60967965, "node_id": "MDQ6VXNlcjYwOTY3OTY1", "avatar_url": "https://avatars.githubusercontent.com/u/60967965?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Ki-Seki", "html_url": "https://github.com/Ki-Seki", "followers_url": "https://api.github.com/users/Ki-Seki/followers", "following_url": "https://api.github.com/users/Ki-Seki/following{/other_user}", "gists_url": "https://api.github.com/users/Ki-Seki/gists{/gist_id}", "starred_url": "https://api.github.com/users/Ki-Seki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Ki-Seki/subscriptions", "organizations_url": "https://api.github.com/users/Ki-Seki/orgs", "repos_url": "https://api.github.com/users/Ki-Seki/repos", "events_url": "https://api.github.com/users/Ki-Seki/events{/privacy}", "received_events_url": "https://api.github.com/users/Ki-Seki/received_events", "type": "User", "site_admin": false }

[ { "id": 2392046359, "node_id": "MDU6TGFiZWwyMzkyMDQ2MzU5", "url": "https://api.github.com/repos/huggingface/transformers/labels/Good%20Second%20Issue", "name": "Good Second Issue", "color": "dd935a", "default": false, "description": "Issues that are more difficult to do than \"Good First\" issues - give it a try if you want!" } ]

[]

[ "Hey! Thanks for opening an issue. \r\nFew things first. You are using a custom / local checkpoint with trust remote code. \r\n\r\nFast is not erroring out when you feed OOV, while slow is and it is indeed inconsistent. Would you like to open a PR for a fix? 🤗 ", "Yes, I'll try that. Thank you for your reply!" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29159/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "alanwaketan", "id": 8573935, "node_id": "MDQ6VXNlcjg1NzM5MzU=", "avatar_url": "https://avatars.githubusercontent.com/u/8573935?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alanwaketan", "html_url": "https://github.com/alanwaketan", "followers_url": "https://api.github.com/users/alanwaketan/followers", "following_url": "https://api.github.com/users/alanwaketan/following{/other_user}", "gists_url": "https://api.github.com/users/alanwaketan/gists{/gist_id}", "starred_url": "https://api.github.com/users/alanwaketan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alanwaketan/subscriptions", "organizations_url": "https://api.github.com/users/alanwaketan/orgs", "repos_url": "https://api.github.com/users/alanwaketan/repos", "events_url": "https://api.github.com/users/alanwaketan/events{/privacy}", "received_events_url": "https://api.github.com/users/alanwaketan/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29158/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29158", "html_url": "https://github.com/huggingface/transformers/pull/29158", "diff_url": "https://github.com/huggingface/transformers/pull/29158.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29158.patch", "merged_at": null }

{ "login": "dhruvmullick", "id": 7004024, "node_id": "MDQ6VXNlcjcwMDQwMjQ=", "avatar_url": "https://avatars.githubusercontent.com/u/7004024?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dhruvmullick", "html_url": "https://github.com/dhruvmullick", "followers_url": "https://api.github.com/users/dhruvmullick/followers", "following_url": "https://api.github.com/users/dhruvmullick/following{/other_user}", "gists_url": "https://api.github.com/users/dhruvmullick/gists{/gist_id}", "starred_url": "https://api.github.com/users/dhruvmullick/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dhruvmullick/subscriptions", "organizations_url": "https://api.github.com/users/dhruvmullick/orgs", "repos_url": "https://api.github.com/users/dhruvmullick/repos", "events_url": "https://api.github.com/users/dhruvmullick/events{/privacy}", "received_events_url": "https://api.github.com/users/dhruvmullick/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29157/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ddevaul", "id": 71190628, "node_id": "MDQ6VXNlcjcxMTkwNjI4", "avatar_url": "https://avatars.githubusercontent.com/u/71190628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddevaul", "html_url": "https://github.com/ddevaul", "followers_url": "https://api.github.com/users/ddevaul/followers", "following_url": "https://api.github.com/users/ddevaul/following{/other_user}", "gists_url": "https://api.github.com/users/ddevaul/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddevaul/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddevaul/subscriptions", "organizations_url": "https://api.github.com/users/ddevaul/orgs", "repos_url": "https://api.github.com/users/ddevaul/repos", "events_url": "https://api.github.com/users/ddevaul/events{/privacy}", "received_events_url": "https://api.github.com/users/ddevaul/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @ddevaul, what is the purpose of this PR? \r\n" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29156/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29156", "html_url": "https://github.com/huggingface/transformers/pull/29156", "diff_url": "https://github.com/huggingface/transformers/pull/29156.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29156.patch", "merged_at": null }

{ "login": "loadams", "id": 114770087, "node_id": "U_kgDOBtdApw", "avatar_url": "https://avatars.githubusercontent.com/u/114770087?v=4", "gravatar_id": "", "url": "https://api.github.com/users/loadams", "html_url": "https://github.com/loadams", "followers_url": "https://api.github.com/users/loadams/followers", "following_url": "https://api.github.com/users/loadams/following{/other_user}", "gists_url": "https://api.github.com/users/loadams/gists{/gist_id}", "starred_url": "https://api.github.com/users/loadams/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/loadams/subscriptions", "organizations_url": "https://api.github.com/users/loadams/orgs", "repos_url": "https://api.github.com/users/loadams/repos", "events_url": "https://api.github.com/users/loadams/events{/privacy}", "received_events_url": "https://api.github.com/users/loadams/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29155/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "loadams", "id": 114770087, "node_id": "U_kgDOBtdApw", "avatar_url": "https://avatars.githubusercontent.com/u/114770087?v=4", "gravatar_id": "", "url": "https://api.github.com/users/loadams", "html_url": "https://github.com/loadams", "followers_url": "https://api.github.com/users/loadams/followers", "following_url": "https://api.github.com/users/loadams/following{/other_user}", "gists_url": "https://api.github.com/users/loadams/gists{/gist_id}", "starred_url": "https://api.github.com/users/loadams/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/loadams/subscriptions", "organizations_url": "https://api.github.com/users/loadams/orgs", "repos_url": "https://api.github.com/users/loadams/repos", "events_url": "https://api.github.com/users/loadams/events{/privacy}", "received_events_url": "https://api.github.com/users/loadams/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29154). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29154/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29154", "html_url": "https://github.com/huggingface/transformers/pull/29154", "diff_url": "https://github.com/huggingface/transformers/pull/29154.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29154.patch", "merged_at": null }

{ "login": "RonanKMcGovern", "id": 78278410, "node_id": "MDQ6VXNlcjc4Mjc4NDEw", "avatar_url": "https://avatars.githubusercontent.com/u/78278410?v=4", "gravatar_id": "", "url": "https://api.github.com/users/RonanKMcGovern", "html_url": "https://github.com/RonanKMcGovern", "followers_url": "https://api.github.com/users/RonanKMcGovern/followers", "following_url": "https://api.github.com/users/RonanKMcGovern/following{/other_user}", "gists_url": "https://api.github.com/users/RonanKMcGovern/gists{/gist_id}", "starred_url": "https://api.github.com/users/RonanKMcGovern/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RonanKMcGovern/subscriptions", "organizations_url": "https://api.github.com/users/RonanKMcGovern/orgs", "repos_url": "https://api.github.com/users/RonanKMcGovern/repos", "events_url": "https://api.github.com/users/RonanKMcGovern/events{/privacy}", "received_events_url": "https://api.github.com/users/RonanKMcGovern/received_events", "type": "User", "site_admin": false }

[ { "id": 2648621985, "node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1", "url": "https://api.github.com/repos/huggingface/transformers/labels/Feature%20request", "name": "Feature request", "color": "FBCA04", "default": false, "description": "Request for a new feature" } ]

[]

[ "cc @younesbelkada @pacman100 ", "Hi @RonanKMcGovern ! \r\nThanks for the feature request! There is already an ongoing work from @BenjaminBossan to add DoRA in PEFT: https://github.com/huggingface/peft/pull/1474", "Closing as there is a PR underway.", "OK thank you @RonanKMcGovern !" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29153/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "amyeroberts", "id": 22614925, "node_id": "MDQ6VXNlcjIyNjE0OTI1", "avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4", "gravatar_id": "", "url": "https://api.github.com/users/amyeroberts", "html_url": "https://github.com/amyeroberts", "followers_url": "https://api.github.com/users/amyeroberts/followers", "following_url": "https://api.github.com/users/amyeroberts/following{/other_user}", "gists_url": "https://api.github.com/users/amyeroberts/gists{/gist_id}", "starred_url": "https://api.github.com/users/amyeroberts/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/amyeroberts/subscriptions", "organizations_url": "https://api.github.com/users/amyeroberts/orgs", "repos_url": "https://api.github.com/users/amyeroberts/repos", "events_url": "https://api.github.com/users/amyeroberts/events{/privacy}", "received_events_url": "https://api.github.com/users/amyeroberts/received_events", "type": "User", "site_admin": false }

[]

[]

[ "cc @Rocketknight1 ", "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29152). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29152/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29152", "html_url": "https://github.com/huggingface/transformers/pull/29152", "diff_url": "https://github.com/huggingface/transformers/pull/29152.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29152.patch", "merged_at": null }

{ "login": "fxmarty", "id": 9808326, "node_id": "MDQ6VXNlcjk4MDgzMjY=", "avatar_url": "https://avatars.githubusercontent.com/u/9808326?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fxmarty", "html_url": "https://github.com/fxmarty", "followers_url": "https://api.github.com/users/fxmarty/followers", "following_url": "https://api.github.com/users/fxmarty/following{/other_user}", "gists_url": "https://api.github.com/users/fxmarty/gists{/gist_id}", "starred_url": "https://api.github.com/users/fxmarty/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fxmarty/subscriptions", "organizations_url": "https://api.github.com/users/fxmarty/orgs", "repos_url": "https://api.github.com/users/fxmarty/repos", "events_url": "https://api.github.com/users/fxmarty/events{/privacy}", "received_events_url": "https://api.github.com/users/fxmarty/received_events", "type": "User", "site_admin": false }

[]

[]

[ "cc @gante ", "@fxmarty this is the same problem as we have in TF and Flax. There, we nudged users to use the `pad_to_multiple_of` argument in the tokenizer, which I believe solves the problem 🤗 \r\n\r\nHow do you suggest us to let users know about this feature, other than docs?" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29151/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "El-chapo-007", "id": 125077963, "node_id": "U_kgDOB3SJyw", "avatar_url": "https://avatars.githubusercontent.com/u/125077963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/El-chapo-007", "html_url": "https://github.com/El-chapo-007", "followers_url": "https://api.github.com/users/El-chapo-007/followers", "following_url": "https://api.github.com/users/El-chapo-007/following{/other_user}", "gists_url": "https://api.github.com/users/El-chapo-007/gists{/gist_id}", "starred_url": "https://api.github.com/users/El-chapo-007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/El-chapo-007/subscriptions", "organizations_url": "https://api.github.com/users/El-chapo-007/orgs", "repos_url": "https://api.github.com/users/El-chapo-007/repos", "events_url": "https://api.github.com/users/El-chapo-007/events{/privacy}", "received_events_url": "https://api.github.com/users/El-chapo-007/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @El-chapo-007, thanks for opening this issue! \r\n\r\nGlad to hear that your journey has been mostly successful 🤗 \r\n\r\nHave you seen our documentation page about adding custom models? This should contain all the info and example code needed to get started: https://huggingface.co/docs/transformers/custom_models\r\n\r\nLet us know if anything does work! ", "could you please add a Jupiter notebook template, as it would be alot more helpful as most of the other parts the hugging face team has put as a tutorial to better familirize with enviornment .....\r\nAnd also my custom architecture projects feed forward layer to the multiple of d_model,\r\nas other models project it back to same dimension it just up_project and i have tested several other models but this model yeilds order of magnitude more performance with respect to number of parameters,hence i can deploy it on edge devices ..\r\n\r\nBut the issue as far as i know i don't have to use lm head liner layer but hugging face library automatically put we call a certain class for example AutoModelForCausalLM....\r\n\r\nSince my model dimensions are same but in final liner layer how can I project it to multiple of d_model to final linear layer ...\r\n", "also there is a bit confusion on https://huggingface.co/docs/transformers/custom_models \r\nvs https://huggingface.co/docs/transformers/add_new_model", "Hi @El-chapo-007, \r\n\r\nWe can definitely think about adding a jupyter notebook. In the meantime, you should be able to run the code snippets in the documentation in cells in your own notebook.\r\n\r\nI'm not sure I understand your question about modifying the models. However, this is a question best placed in our [forums](https://discuss.huggingface.co/). We try to reserve the github issues for feature requests and bug reports.\r\n\r\nRegarding the documentation pages: \r\n* https://huggingface.co/docs/transformers/add_new_model outlines how to add a model into the transformers repo\r\n* https://huggingface.co/docs/transformers/custom_models outlines how to add a model on the hub\r\n", "thanks alot" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29150/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "site_admin": false }

[]

{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "site_admin": false }

[ { "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "site_admin": false } ]

[ "@zucchini-nlp FYI. We shouldn't fix this now, as it requires significant manual labor to update all models. After the static cache sprint we should have a look at this :)" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29149/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29148). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29148/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29148", "html_url": "https://github.com/huggingface/transformers/pull/29148", "diff_url": "https://github.com/huggingface/transformers/pull/29148.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29148.patch", "merged_at": null }

{ "login": "fepegar", "id": 12688084, "node_id": "MDQ6VXNlcjEyNjg4MDg0", "avatar_url": "https://avatars.githubusercontent.com/u/12688084?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fepegar", "html_url": "https://github.com/fepegar", "followers_url": "https://api.github.com/users/fepegar/followers", "following_url": "https://api.github.com/users/fepegar/following{/other_user}", "gists_url": "https://api.github.com/users/fepegar/gists{/gist_id}", "starred_url": "https://api.github.com/users/fepegar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fepegar/subscriptions", "organizations_url": "https://api.github.com/users/fepegar/orgs", "repos_url": "https://api.github.com/users/fepegar/repos", "events_url": "https://api.github.com/users/fepegar/events{/privacy}", "received_events_url": "https://api.github.com/users/fepegar/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for reviewing, @amyeroberts!" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29147/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29147", "html_url": "https://github.com/huggingface/transformers/pull/29147", "diff_url": "https://github.com/huggingface/transformers/pull/29147.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29147.patch", "merged_at": 1708450319000 }

{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29146). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29146/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29146", "html_url": "https://github.com/huggingface/transformers/pull/29146", "diff_url": "https://github.com/huggingface/transformers/pull/29146.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29146.patch", "merged_at": 1708445871000 }

{ "login": "KaifAhmad1", "id": 98801504, "node_id": "U_kgDOBeOXYA", "avatar_url": "https://avatars.githubusercontent.com/u/98801504?v=4", "gravatar_id": "", "url": "https://api.github.com/users/KaifAhmad1", "html_url": "https://github.com/KaifAhmad1", "followers_url": "https://api.github.com/users/KaifAhmad1/followers", "following_url": "https://api.github.com/users/KaifAhmad1/following{/other_user}", "gists_url": "https://api.github.com/users/KaifAhmad1/gists{/gist_id}", "starred_url": "https://api.github.com/users/KaifAhmad1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KaifAhmad1/subscriptions", "organizations_url": "https://api.github.com/users/KaifAhmad1/orgs", "repos_url": "https://api.github.com/users/KaifAhmad1/repos", "events_url": "https://api.github.com/users/KaifAhmad1/events{/privacy}", "received_events_url": "https://api.github.com/users/KaifAhmad1/received_events", "type": "User", "site_admin": false }

[ { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29145/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kallewoof", "id": 250224, "node_id": "MDQ6VXNlcjI1MDIyNA==", "avatar_url": "https://avatars.githubusercontent.com/u/250224?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kallewoof", "html_url": "https://github.com/kallewoof", "followers_url": "https://api.github.com/users/kallewoof/followers", "following_url": "https://api.github.com/users/kallewoof/following{/other_user}", "gists_url": "https://api.github.com/users/kallewoof/gists{/gist_id}", "starred_url": "https://api.github.com/users/kallewoof/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kallewoof/subscriptions", "organizations_url": "https://api.github.com/users/kallewoof/orgs", "repos_url": "https://api.github.com/users/kallewoof/repos", "events_url": "https://api.github.com/users/kallewoof/events{/privacy}", "received_events_url": "https://api.github.com/users/kallewoof/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29144/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29144", "html_url": "https://github.com/huggingface/transformers/pull/29144", "diff_url": "https://github.com/huggingface/transformers/pull/29144.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29144.patch", "merged_at": null }

{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29143). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29143/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29143", "html_url": "https://github.com/huggingface/transformers/pull/29143", "diff_url": "https://github.com/huggingface/transformers/pull/29143.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29143.patch", "merged_at": null }

{ "login": "BlackSamorez", "id": 16901341, "node_id": "MDQ6VXNlcjE2OTAxMzQx", "avatar_url": "https://avatars.githubusercontent.com/u/16901341?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BlackSamorez", "html_url": "https://github.com/BlackSamorez", "followers_url": "https://api.github.com/users/BlackSamorez/followers", "following_url": "https://api.github.com/users/BlackSamorez/following{/other_user}", "gists_url": "https://api.github.com/users/BlackSamorez/gists{/gist_id}", "starred_url": "https://api.github.com/users/BlackSamorez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BlackSamorez/subscriptions", "organizations_url": "https://api.github.com/users/BlackSamorez/orgs", "repos_url": "https://api.github.com/users/BlackSamorez/repos", "events_url": "https://api.github.com/users/BlackSamorez/events{/privacy}", "received_events_url": "https://api.github.com/users/BlackSamorez/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29142). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29142/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29142", "html_url": "https://github.com/huggingface/transformers/pull/29142", "diff_url": "https://github.com/huggingface/transformers/pull/29142.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29142.patch", "merged_at": null }

{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29141). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29141/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29141", "html_url": "https://github.com/huggingface/transformers/pull/29141", "diff_url": "https://github.com/huggingface/transformers/pull/29141.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29141.patch", "merged_at": 1708435896000 }

{ "login": "fepegar", "id": 12688084, "node_id": "MDQ6VXNlcjEyNjg4MDg0", "avatar_url": "https://avatars.githubusercontent.com/u/12688084?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fepegar", "html_url": "https://github.com/fepegar", "followers_url": "https://api.github.com/users/fepegar/followers", "following_url": "https://api.github.com/users/fepegar/following{/other_user}", "gists_url": "https://api.github.com/users/fepegar/gists{/gist_id}", "starred_url": "https://api.github.com/users/fepegar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fepegar/subscriptions", "organizations_url": "https://api.github.com/users/fepegar/orgs", "repos_url": "https://api.github.com/users/fepegar/repos", "events_url": "https://api.github.com/users/fepegar/events{/privacy}", "received_events_url": "https://api.github.com/users/fepegar/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hey, thanks for the issue! I've checked out your branch, from what I'm seeing tests are passing on your fix, would you mind opening a PR? \r\nAlso, since this will affect training, do you have a script that compares both in a training scenario? AFAIK current integration tests for Dinov2 are not in a training setting.", "Hi @molbap. Thanks for your response! I've created\r\n- #29147.\r\n\r\nThe high-level effects of these changes would take quite a lot of work to measure, but here's a little snippet:\r\n\r\n```python\r\n>>> import torch\r\n>>> from transformers import Dinov2Model\r\n>>> \r\n>>> torch.set_grad_enabled(False)\r\n>>> torch.manual_seed(0)\r\n>>> \r\n>>> model = Dinov2Model.from_pretrained(\"facebook/dinov2-base\", drop_path_rate=0.3)\r\n>>> model.train()\r\n>>> \r\n>>> x = torch.rand(1, 3, 224, 224)\r\n>>> out_1 = model(x)\r\n>>> out_2 = model(x)\r\n>>> torch.all(out_1.last_hidden_state == out_2.last_hidden_state)\r\n```\r\n\r\nThe output is `tensor(True)` in `main`, indicating that the depth is deterministic because the drop path rate is not being used, where it's `tensor(False)` in my branch due to stochastic depth being properly enabled." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29140/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "vapemaster-kz", "id": 65128133, "node_id": "MDQ6VXNlcjY1MTI4MTMz", "avatar_url": "https://avatars.githubusercontent.com/u/65128133?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vapemaster-kz", "html_url": "https://github.com/vapemaster-kz", "followers_url": "https://api.github.com/users/vapemaster-kz/followers", "following_url": "https://api.github.com/users/vapemaster-kz/following{/other_user}", "gists_url": "https://api.github.com/users/vapemaster-kz/gists{/gist_id}", "starred_url": "https://api.github.com/users/vapemaster-kz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vapemaster-kz/subscriptions", "organizations_url": "https://api.github.com/users/vapemaster-kz/orgs", "repos_url": "https://api.github.com/users/vapemaster-kz/repos", "events_url": "https://api.github.com/users/vapemaster-kz/events{/privacy}", "received_events_url": "https://api.github.com/users/vapemaster-kz/received_events", "type": "User", "site_admin": false }

[]

[]

[ "cc @ylacombe " ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29139/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29138/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29138", "html_url": "https://github.com/huggingface/transformers/pull/29138", "diff_url": "https://github.com/huggingface/transformers/pull/29138.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29138.patch", "merged_at": null }

{ "login": "Jeronymous", "id": 22522728, "node_id": "MDQ6VXNlcjIyNTIyNzI4", "avatar_url": "https://avatars.githubusercontent.com/u/22522728?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Jeronymous", "html_url": "https://github.com/Jeronymous", "followers_url": "https://api.github.com/users/Jeronymous/followers", "following_url": "https://api.github.com/users/Jeronymous/following{/other_user}", "gists_url": "https://api.github.com/users/Jeronymous/gists{/gist_id}", "starred_url": "https://api.github.com/users/Jeronymous/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Jeronymous/subscriptions", "organizations_url": "https://api.github.com/users/Jeronymous/orgs", "repos_url": "https://api.github.com/users/Jeronymous/repos", "events_url": "https://api.github.com/users/Jeronymous/events{/privacy}", "received_events_url": "https://api.github.com/users/Jeronymous/received_events", "type": "User", "site_admin": false }

[]

[]

[ "cc @ArthurZucker ", "Hey! Thanks for reporting. \r\n`tokenizer.Load(self.vocab_file)` seems to be the issue here. If you check the repo it does not have the `tokenizer.model` .\r\nYou should raise the issue there! \r\n", "Thanks @ArthurZucker 👍 " ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29137/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29136). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "@amyeroberts #29109 seems to have fixed most of the issue (this test does compare batched vs unbatched generation under the hood, which the PR linked above fixes)\r\n\r\nThe root issue about this and other tests being non-deterministic tests persists, though :) I'm going to close the PR and move the discussion to slack at a future time :)" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29136/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29136", "html_url": "https://github.com/huggingface/transformers/pull/29136", "diff_url": "https://github.com/huggingface/transformers/pull/29136.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29136.patch", "merged_at": null }

{ "login": "amyeroberts", "id": 22614925, "node_id": "MDQ6VXNlcjIyNjE0OTI1", "avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4", "gravatar_id": "", "url": "https://api.github.com/users/amyeroberts", "html_url": "https://github.com/amyeroberts", "followers_url": "https://api.github.com/users/amyeroberts/followers", "following_url": "https://api.github.com/users/amyeroberts/following{/other_user}", "gists_url": "https://api.github.com/users/amyeroberts/gists{/gist_id}", "starred_url": "https://api.github.com/users/amyeroberts/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/amyeroberts/subscriptions", "organizations_url": "https://api.github.com/users/amyeroberts/orgs", "repos_url": "https://api.github.com/users/amyeroberts/repos", "events_url": "https://api.github.com/users/amyeroberts/events{/privacy}", "received_events_url": "https://api.github.com/users/amyeroberts/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29135). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Sounds good, thanks for taking care of this!" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29135/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29135", "html_url": "https://github.com/huggingface/transformers/pull/29135", "diff_url": "https://github.com/huggingface/transformers/pull/29135.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29135.patch", "merged_at": 1708430807000 }

{ "login": "regisss", "id": 15324346, "node_id": "MDQ6VXNlcjE1MzI0MzQ2", "avatar_url": "https://avatars.githubusercontent.com/u/15324346?v=4", "gravatar_id": "", "url": "https://api.github.com/users/regisss", "html_url": "https://github.com/regisss", "followers_url": "https://api.github.com/users/regisss/followers", "following_url": "https://api.github.com/users/regisss/following{/other_user}", "gists_url": "https://api.github.com/users/regisss/gists{/gist_id}", "starred_url": "https://api.github.com/users/regisss/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/regisss/subscriptions", "organizations_url": "https://api.github.com/users/regisss/orgs", "repos_url": "https://api.github.com/users/regisss/repos", "events_url": "https://api.github.com/users/regisss/events{/privacy}", "received_events_url": "https://api.github.com/users/regisss/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29134). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29134/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29134", "html_url": "https://github.com/huggingface/transformers/pull/29134", "diff_url": "https://github.com/huggingface/transformers/pull/29134.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29134.patch", "merged_at": null }

{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29133). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "I'll make sure of that before merging! Testing now!", "```bash\r\nFAILED tests/models/deformable_detr/test_modeling_deformable_detr.py::DeformableDetrModelIntegrationTests::test_inference_object_detection_head - AssertionError: False is not true\r\nFAILED tests/models/deformable_detr/test_modeling_deformable_detr.py::DeformableDetrModelIntegrationTests::test_inference_object_detection_head_equivalence_cpu_gpu - AssertionError: assert False\r\nFAILED tests/models/deformable_detr/test_modeling_deformable_detr.py::DeformableDetrModelIntegrationTests::test_inference_object_detection_head_with_box_refine_two_stage - AssertionError: False is not true\r\n```\r\nfailing. Logits do no match, failing on main as well\r\n\r\n```bash \r\nFAILED tests/models/deta/test_modeling_deta.py::DetaModelIntegrationTests::test_inference_object_detection_head - AssertionError: False is not true\r\nFAILED tests/models/deta/test_modeling_deta.py::DetaModelIntegrationTests::test_inference_object_detection_head_swin_backbone - AssertionError: False is not true\r\n```\r\nfailing as well on main. Merging\r\n\r\nYoso is alright" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29133/reactions", "total_count": 3, "+1": 0, "-1": 0, "laugh": 0, "hooray": 3, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29133", "html_url": "https://github.com/huggingface/transformers/pull/29133", "diff_url": "https://github.com/huggingface/transformers/pull/29133.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29133.patch", "merged_at": 1708429139000 }

{ "login": "cook9019", "id": 141466977, "node_id": "U_kgDOCG6dYQ", "avatar_url": "https://avatars.githubusercontent.com/u/141466977?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cook9019", "html_url": "https://github.com/cook9019", "followers_url": "https://api.github.com/users/cook9019/followers", "following_url": "https://api.github.com/users/cook9019/following{/other_user}", "gists_url": "https://api.github.com/users/cook9019/gists{/gist_id}", "starred_url": "https://api.github.com/users/cook9019/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cook9019/subscriptions", "organizations_url": "https://api.github.com/users/cook9019/orgs", "repos_url": "https://api.github.com/users/cook9019/repos", "events_url": "https://api.github.com/users/cook9019/events{/privacy}", "received_events_url": "https://api.github.com/users/cook9019/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29132/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "mosheber", "id": 22236370, "node_id": "MDQ6VXNlcjIyMjM2Mzcw", "avatar_url": "https://avatars.githubusercontent.com/u/22236370?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mosheber", "html_url": "https://github.com/mosheber", "followers_url": "https://api.github.com/users/mosheber/followers", "following_url": "https://api.github.com/users/mosheber/following{/other_user}", "gists_url": "https://api.github.com/users/mosheber/gists{/gist_id}", "starred_url": "https://api.github.com/users/mosheber/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mosheber/subscriptions", "organizations_url": "https://api.github.com/users/mosheber/orgs", "repos_url": "https://api.github.com/users/mosheber/repos", "events_url": "https://api.github.com/users/mosheber/events{/privacy}", "received_events_url": "https://api.github.com/users/mosheber/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29131/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29131", "html_url": "https://github.com/huggingface/transformers/pull/29131", "diff_url": "https://github.com/huggingface/transformers/pull/29131.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29131.patch", "merged_at": null }

{ "login": "NielsRogge", "id": 48327001, "node_id": "MDQ6VXNlcjQ4MzI3MDAx", "avatar_url": "https://avatars.githubusercontent.com/u/48327001?v=4", "gravatar_id": "", "url": "https://api.github.com/users/NielsRogge", "html_url": "https://github.com/NielsRogge", "followers_url": "https://api.github.com/users/NielsRogge/followers", "following_url": "https://api.github.com/users/NielsRogge/following{/other_user}", "gists_url": "https://api.github.com/users/NielsRogge/gists{/gist_id}", "starred_url": "https://api.github.com/users/NielsRogge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/NielsRogge/subscriptions", "organizations_url": "https://api.github.com/users/NielsRogge/orgs", "repos_url": "https://api.github.com/users/NielsRogge/repos", "events_url": "https://api.github.com/users/NielsRogge/events{/privacy}", "received_events_url": "https://api.github.com/users/NielsRogge/received_events", "type": "User", "site_admin": false }

[ { "id": 1862634478, "node_id": "MDU6TGFiZWwxODYyNjM0NDc4", "url": "https://api.github.com/repos/huggingface/transformers/labels/Should%20Fix", "name": "Should Fix", "color": "FF0000", "default": false, "description": "This has been identified as a bug and should be fixed." }, { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29130/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ghost", "id": 10137, "node_id": "MDQ6VXNlcjEwMTM3", "avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ghost", "html_url": "https://github.com/ghost", "followers_url": "https://api.github.com/users/ghost/followers", "following_url": "https://api.github.com/users/ghost/following{/other_user}", "gists_url": "https://api.github.com/users/ghost/gists{/gist_id}", "starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ghost/subscriptions", "organizations_url": "https://api.github.com/users/ghost/orgs", "repos_url": "https://api.github.com/users/ghost/repos", "events_url": "https://api.github.com/users/ghost/events{/privacy}", "received_events_url": "https://api.github.com/users/ghost/received_events", "type": "User", "site_admin": false }

[ { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]

[]

[ "Not that expert but I suggest you can try bettertransformer for extreme speed up. （ In my knowledge that flash-attn is mainly focused on kv cache which is not exist on Bert-like model in most cases. )", "> Not that expert but I suggest you can try bettertransformer for extreme speed up. （ In my knowledge that flash-attn is mainly focused on kv cache which is not exist on Bert-like model in most cases. )\r\n\r\nmosaic bert is based on flash attention. ", "Hi @rahul-k01, \r\n\r\nPlease make sure to only tag a limited set of relevant people when opening an issue - everyone is very busy and if this was done on all issues we wouldn't be able to meaningfully address our notifications. \r\n\r\nFlashAttention isn't implemented yet for BERT. There's an open issue where you can track which models have it added and on-going work: #26350. At the moment, it seems @filippo82 is working on the addition for BERT. ", "> Hi @rahul-k01,\r\n> \r\n> Please make sure to only tag a limited set of relevant people when opening an issue - everyone is very busy and if this was done on all issues we wouldn't be able to meaningfully address our notifications.\r\n> \r\n> FlashAttention isn't implemented yet for BERT. There's an open issue where you can track which models have it added and on-going work: #26350. At the moment, it seems @filippo82 is working on the addition for BERT.\r\n\r\nThanks for your response\r\n" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29129/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Aisuko", "id": 8053949, "node_id": "MDQ6VXNlcjgwNTM5NDk=", "avatar_url": "https://avatars.githubusercontent.com/u/8053949?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Aisuko", "html_url": "https://github.com/Aisuko", "followers_url": "https://api.github.com/users/Aisuko/followers", "following_url": "https://api.github.com/users/Aisuko/following{/other_user}", "gists_url": "https://api.github.com/users/Aisuko/gists{/gist_id}", "starred_url": "https://api.github.com/users/Aisuko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Aisuko/subscriptions", "organizations_url": "https://api.github.com/users/Aisuko/orgs", "repos_url": "https://api.github.com/users/Aisuko/repos", "events_url": "https://api.github.com/users/Aisuko/events{/privacy}", "received_events_url": "https://api.github.com/users/Aisuko/received_events", "type": "User", "site_admin": false }

[]

[]

[ "cc @ArthurZucker @younesbelkada ", "Hey @Aisuko, could you provide a **minimal** reproducer ? That would help use! \r\nAlso note that the `generation parameters` issues can probably be safely ignored. The missing keys is however a bit more problematic! \r\nMight be tied weights that are not tied properly, is `tie_word_embeddings` used ? ", "Hi, guys. Thanks for your quick response.\r\n\r\nThe minimal code see below, the code only including the steps of processing data and training. And we cat get same result from it. https://www.kaggle.com/code/aisuko/minimal-reproducer-for-issue-29128/notebook\r\n\r\nThe embedding process without using `tie_word_embeddings` parameter.\r\n\r\n\r\n## libraries\r\n\r\n```\r\n!pip install transformers==4.37.2\r\n!pip install datasets==2.17.0\r\n!pip install evaluate==0.4.1\r\n!pip install rouge-score==0.1.2\r\n```\r\n\r\n## Code\r\n```\r\n# Import libraries\r\nimport os\r\nimport re\r\nimport nltk\r\nimport pandas as pd\r\nimport numpy as np\r\nimport warnings\r\nfrom datasets import Dataset\r\nfrom datasets import load_metric\r\nfrom transformers import BartTokenizer, BartForConditionalGeneration\r\nfrom transformers import BartForConditionalGeneration\r\nfrom transformers import DataCollatorForSeq2Seq\r\nfrom transformers import Seq2SeqTrainingArguments, Seq2SeqTrainer\r\n\r\nos.environ['MODEL']='facebook/bart-large-xsum'\r\nos.environ[\"WANDB_NAME\"] = \"ft-facebook-bart-large-xsum-on-samsum\"\r\n\r\nwarnings.filterwarnings('ignore')\r\n\r\n# Loading and preprocessing data from https://www.kaggle.com/datasets/nileshmalode1/samsum-dataset-text-summarization\r\ntrain=pd.read_csv('/kaggle/input/samsum-dataset-text-summarization/samsum-train.csv')\r\ntest=pd.read_csv('/kaggle/input/samsum-dataset-text-summarization/samsum-test.csv')\r\nval=pd.read_csv('/kaggle/input/samsum-dataset-text-summarization/samsum-validation.csv')\r\n\r\ndef clean_tags(text):\r\n clean=re.compile('<.*?>') # compiling tags\r\n clean=re.sub(clean, '', text) # replacing tags text by an empty string\r\n \r\n # removing empty dialogues\r\n clean='\\n'.join([line for line in clean.split('\\n') if not re.match('.*:\\s*$', line)])\r\n return clean\r\n\r\ndef clean_df(df, cols):\r\n for col in cols:\r\n df[col]=df[col].fillna('').apply(clean_tags)\r\n return df\r\n\r\ntrain=clean_df(train, ['dialogue','summary'])\r\ntest=clean_df(test, ['dialogue', 'summary'])\r\nval=clean_df(val, ['dialogue', 'summary'])\r\n\r\ntrain_ds=Dataset.from_pandas(train)\r\ntest_ds=Dataset.from_pandas(test)\r\nval_ds=Dataset.from_pandas(val)\r\n\r\n# Tokenizer\r\ntokenizer=BartTokenizer.from_pretrained(os.getenv('MODEL'))\r\n\r\ndef preprocess_func(example):\r\n # Iterating over every `dialogue` in the datset and saving them as input to the model\r\n inputs=[doc for doc in example['dialogue']]\r\n # we use tokenizer convert the input dialogues into tokens that can be easily understood by the BART model.\r\n # The truncation=True parameter ensures that all dialogues have a maximum number of 1024 tokens, as defined by the `max_length` parameter\r\n model_inputs=tokenizer(inputs, max_length=1024, truncation=True)\r\n \r\n # Setup the tokenizer for targets\r\n with tokenizer.as_target_tokenizer():\r\n # we tokenizes the target variable, which is our summaries. And we expect summaries to be a much shorter text than that of dialogues max_length=128\r\n labels=tokenizer(example['summary'], max_length=128, truncation=True)\r\n \r\n # we adding the tokenized labels to the preprocessed dataset, alongside the tokenized inputs.\r\n model_inputs['labels']=labels['input_ids']\r\n return model_inputs\r\n\r\n\r\ntokenized_train= train_ds.map(preprocess_func, batched=True, remove_columns=['id', 'dialogue', 'summary'])\r\ntokenized_test=test_ds.map(preprocess_func, batched=True, remove_columns=['id', 'dialogue', 'summary'])\r\ntokenized_val=val_ds.map(preprocess_func, batched=True, remove_columns=['id', 'dialogue', 'summary'])\r\n\r\n# Loading the model\r\nmodel=BartForConditionalGeneration.from_pretrained(os.getenv('MODEL'))\r\n\r\n# Loading DataCollator\r\ndata_collator= DataCollatorForSeq2Seq(tokenizer=tokenizer, model=model)\r\n\r\n# Customizing metrics\r\nmetric=load_metric('rouge')\r\n\r\nnltk.download('punkt') # this divides a text into a list of sentences\r\n\r\ndef compute_metrics(eval_pred):\r\n predictions, labels=eval_pred # obtaining predictions and true labels\r\n \r\n # decoding predictions\r\n decoded_preds=tokenizer.batch_decode(predictions, skip_special_tokens=True)\r\n \r\n # obtaining the true labels tokens, while eliminating any possible masked token (i.e: label=-100)\r\n labels=np.where(labels!=-100, labels, tokenizer.pad_token_id)\r\n decoded_labels=tokenizer.batch_decode(labels, skip_special_tokens=True)\r\n \r\n # rouge expects a newline after each sentence\r\n decoded_preds=['\\n'.join(nltk.sent_tokenize(pred.strip())) for pred in decoded_preds]\r\n decoded_labels=['\\n'.join(nltk.sent_tokenize(label.strip())) for label in decoded_labels]\r\n \r\n # computing rouge score\r\n result=metric.compute(predictions=decoded_preds, references=decoded_labels, use_stemmer=True)\r\n result={key: value.mid.fmeasure*100 for key, value in result.items()} # extracting some results\r\n \r\n # add mean-genrated length\r\n prediction_lens=[np.count_nonzero(pred!=tokenizer.pad_token_id) for pred in predictions]\r\n result['gen_len']=np.mean(prediction_lens)\r\n return {k: round(v,4) for k,v in result.items()}\r\n\r\n\r\n# Training\r\ntraining_args=Seq2SeqTrainingArguments(\r\n output_dir=os.getenv('WANDB_NAME'),\r\n evaluation_strategy='epoch',\r\n save_strategy='epoch',\r\n load_best_model_at_end=True,\r\n metric_for_best_model='eval_loss',\r\n seed=42,\r\n learning_rate=2e-5,\r\n max_steps=100,\r\n per_device_train_batch_size=4,\r\n per_device_eval_batch_size=4,\r\n gradient_accumulation_steps=4,\r\n weight_decay=0.01,\r\n save_total_limit=2,\r\n num_train_epochs=1, # only for testing\r\n predict_with_generate=True,\r\n fp16=True,\r\n report_to='none',\r\n)\r\n\r\ntrainer=Seq2SeqTrainer(\r\n model=model,\r\n args=training_args,\r\n train_dataset=tokenized_train,\r\n eval_dataset=tokenized_test,\r\n tokenizer=tokenizer,\r\n data_collator=data_collator,\r\n compute_metrics=compute_metrics\r\n)\r\n\r\ntrainer.train()\r\n```" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29128/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Sushaanth-Suresh-Kumar", "id": 123300765, "node_id": "U_kgDOB1lrnQ", "avatar_url": "https://avatars.githubusercontent.com/u/123300765?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Sushaanth-Suresh-Kumar", "html_url": "https://github.com/Sushaanth-Suresh-Kumar", "followers_url": "https://api.github.com/users/Sushaanth-Suresh-Kumar/followers", "following_url": "https://api.github.com/users/Sushaanth-Suresh-Kumar/following{/other_user}", "gists_url": "https://api.github.com/users/Sushaanth-Suresh-Kumar/gists{/gist_id}", "starred_url": "https://api.github.com/users/Sushaanth-Suresh-Kumar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Sushaanth-Suresh-Kumar/subscriptions", "organizations_url": "https://api.github.com/users/Sushaanth-Suresh-Kumar/orgs", "repos_url": "https://api.github.com/users/Sushaanth-Suresh-Kumar/repos", "events_url": "https://api.github.com/users/Sushaanth-Suresh-Kumar/events{/privacy}", "received_events_url": "https://api.github.com/users/Sushaanth-Suresh-Kumar/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Would you like to open a PR to improve the error? 🤗 ", "Sure" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29127/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "lucasjinreal", "id": 21303438, "node_id": "MDQ6VXNlcjIxMzAzNDM4", "avatar_url": "https://avatars.githubusercontent.com/u/21303438?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lucasjinreal", "html_url": "https://github.com/lucasjinreal", "followers_url": "https://api.github.com/users/lucasjinreal/followers", "following_url": "https://api.github.com/users/lucasjinreal/following{/other_user}", "gists_url": "https://api.github.com/users/lucasjinreal/gists{/gist_id}", "starred_url": "https://api.github.com/users/lucasjinreal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lucasjinreal/subscriptions", "organizations_url": "https://api.github.com/users/lucasjinreal/orgs", "repos_url": "https://api.github.com/users/lucasjinreal/repos", "events_url": "https://api.github.com/users/lucasjinreal/events{/privacy}", "received_events_url": "https://api.github.com/users/lucasjinreal/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @lucasjinreal, \r\n\r\nWithout a code sample to replicate, information about the running environment or more information about the error - including full trackback - there isn't much we can do to help you here." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29126/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "parambharat", "id": 12809212, "node_id": "MDQ6VXNlcjEyODA5MjEy", "avatar_url": "https://avatars.githubusercontent.com/u/12809212?v=4", "gravatar_id": "", "url": "https://api.github.com/users/parambharat", "html_url": "https://github.com/parambharat", "followers_url": "https://api.github.com/users/parambharat/followers", "following_url": "https://api.github.com/users/parambharat/following{/other_user}", "gists_url": "https://api.github.com/users/parambharat/gists{/gist_id}", "starred_url": "https://api.github.com/users/parambharat/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/parambharat/subscriptions", "organizations_url": "https://api.github.com/users/parambharat/orgs", "repos_url": "https://api.github.com/users/parambharat/repos", "events_url": "https://api.github.com/users/parambharat/events{/privacy}", "received_events_url": "https://api.github.com/users/parambharat/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29125/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29125", "html_url": "https://github.com/huggingface/transformers/pull/29125", "diff_url": "https://github.com/huggingface/transformers/pull/29125.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29125.patch", "merged_at": null }

{ "login": "robertgshaw2-neuralmagic", "id": 114415538, "node_id": "U_kgDOBtHXsg", "avatar_url": "https://avatars.githubusercontent.com/u/114415538?v=4", "gravatar_id": "", "url": "https://api.github.com/users/robertgshaw2-neuralmagic", "html_url": "https://github.com/robertgshaw2-neuralmagic", "followers_url": "https://api.github.com/users/robertgshaw2-neuralmagic/followers", "following_url": "https://api.github.com/users/robertgshaw2-neuralmagic/following{/other_user}", "gists_url": "https://api.github.com/users/robertgshaw2-neuralmagic/gists{/gist_id}", "starred_url": "https://api.github.com/users/robertgshaw2-neuralmagic/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/robertgshaw2-neuralmagic/subscriptions", "organizations_url": "https://api.github.com/users/robertgshaw2-neuralmagic/orgs", "repos_url": "https://api.github.com/users/robertgshaw2-neuralmagic/repos", "events_url": "https://api.github.com/users/robertgshaw2-neuralmagic/events{/privacy}", "received_events_url": "https://api.github.com/users/robertgshaw2-neuralmagic/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29124/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29124", "html_url": "https://github.com/huggingface/transformers/pull/29124", "diff_url": "https://github.com/huggingface/transformers/pull/29124.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29124.patch", "merged_at": null }

{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29123). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29123/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29123", "html_url": "https://github.com/huggingface/transformers/pull/29123", "diff_url": "https://github.com/huggingface/transformers/pull/29123.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29123.patch", "merged_at": null }

{ "login": "younesbelkada", "id": 49240599, "node_id": "MDQ6VXNlcjQ5MjQwNTk5", "avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4", "gravatar_id": "", "url": "https://api.github.com/users/younesbelkada", "html_url": "https://github.com/younesbelkada", "followers_url": "https://api.github.com/users/younesbelkada/followers", "following_url": "https://api.github.com/users/younesbelkada/following{/other_user}", "gists_url": "https://api.github.com/users/younesbelkada/gists{/gist_id}", "starred_url": "https://api.github.com/users/younesbelkada/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/younesbelkada/subscriptions", "organizations_url": "https://api.github.com/users/younesbelkada/orgs", "repos_url": "https://api.github.com/users/younesbelkada/repos", "events_url": "https://api.github.com/users/younesbelkada/events{/privacy}", "received_events_url": "https://api.github.com/users/younesbelkada/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29122). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29122/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29122", "html_url": "https://github.com/huggingface/transformers/pull/29122", "diff_url": "https://github.com/huggingface/transformers/pull/29122.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29122.patch", "merged_at": 1708423875000 }

{ "login": "javilonso", "id": 31996659, "node_id": "MDQ6VXNlcjMxOTk2NjU5", "avatar_url": "https://avatars.githubusercontent.com/u/31996659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/javilonso", "html_url": "https://github.com/javilonso", "followers_url": "https://api.github.com/users/javilonso/followers", "following_url": "https://api.github.com/users/javilonso/following{/other_user}", "gists_url": "https://api.github.com/users/javilonso/gists{/gist_id}", "starred_url": "https://api.github.com/users/javilonso/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/javilonso/subscriptions", "organizations_url": "https://api.github.com/users/javilonso/orgs", "repos_url": "https://api.github.com/users/javilonso/repos", "events_url": "https://api.github.com/users/javilonso/events{/privacy}", "received_events_url": "https://api.github.com/users/javilonso/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @javilonso ! \r\nI quickly tried on transformers main: \r\n```python\r\nfrom transformers import pipeline\r\n\r\nunmasker = pipeline('fill-mask', model='distilbert-base-uncased')\r\nunmasker(\"Hello I'm a [MASK] model.\")\r\n```\r\nBut I did not managed to repro, can you share a snippet to reproduce the issue?\r\nI also tried:\r\n```python\r\nfrom transformers import DistilBertTokenizer, DistilBertModel\r\n\r\ntokenizer = DistilBertTokenizer.from_pretrained('distilbert-base-uncased')\r\nmodel = DistilBertModel.from_pretrained(\"distilbert-base-uncased\")\r\ntext = \"Replace me by any text you'd like.\"\r\n\r\nencoded_input = tokenizer(text, return_tensors='pt')\r\noutput = model(**encoded_input)\r\n```\r\nCan you also try on transformers main?", "Hi, I am also facing the same issue, the code @younesbelkada gave works well on my system. However, I get\r\n `AttributeError: DistilBertModel' object has no attribute '_use_flash_attention_2` \r\nwhen running my prediction with my finetuned distilbert model. I am also running transformers 4.37.2. It works fine on 4.35.2.\r\n\r\nThe error happens when trying to perform the prediction with a local copy of the model:\r\n```python\r\ninputs = tokenizer.encode(text, return_tensors=\"pt\").to(device)\r\nlogits = model(inputs).logits\r\n```\r\n\r\nThis is how I loaded the tokenizer:\r\n```python\r\ntokenizer = AutoTokenizer.from_pretrained(\r\n'models/tokenizer', add_prefix_space=True)\r\n```\r\n\r\nI am also loading a saved local copy of the model here:\r\n```python\r\nmodel = torch.load(model_name, map_location=torch.device(device))\r\n```\r\n\r\nHope the information provided is enough! Thanks in advance.\r\n ", "This issue does not seem to occur when I finetune my model again on transformers 4.38.0.\nI guess the solution would be to update the transformers package." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29121/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jlamypoirier", "id": 18523627, "node_id": "MDQ6VXNlcjE4NTIzNjI3", "avatar_url": "https://avatars.githubusercontent.com/u/18523627?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jlamypoirier", "html_url": "https://github.com/jlamypoirier", "followers_url": "https://api.github.com/users/jlamypoirier/followers", "following_url": "https://api.github.com/users/jlamypoirier/following{/other_user}", "gists_url": "https://api.github.com/users/jlamypoirier/gists{/gist_id}", "starred_url": "https://api.github.com/users/jlamypoirier/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jlamypoirier/subscriptions", "organizations_url": "https://api.github.com/users/jlamypoirier/orgs", "repos_url": "https://api.github.com/users/jlamypoirier/repos", "events_url": "https://api.github.com/users/jlamypoirier/events{/privacy}", "received_events_url": "https://api.github.com/users/jlamypoirier/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29120/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29120", "html_url": "https://github.com/huggingface/transformers/pull/29120", "diff_url": "https://github.com/huggingface/transformers/pull/29120.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29120.patch", "merged_at": null }

{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29119). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29119/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29119", "html_url": "https://github.com/huggingface/transformers/pull/29119", "diff_url": "https://github.com/huggingface/transformers/pull/29119.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29119.patch", "merged_at": 1708428871000 }

{ "login": "hackyon", "id": 1557853, "node_id": "MDQ6VXNlcjE1NTc4NTM=", "avatar_url": "https://avatars.githubusercontent.com/u/1557853?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hackyon", "html_url": "https://github.com/hackyon", "followers_url": "https://api.github.com/users/hackyon/followers", "following_url": "https://api.github.com/users/hackyon/following{/other_user}", "gists_url": "https://api.github.com/users/hackyon/gists{/gist_id}", "starred_url": "https://api.github.com/users/hackyon/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hackyon/subscriptions", "organizations_url": "https://api.github.com/users/hackyon/orgs", "repos_url": "https://api.github.com/users/hackyon/repos", "events_url": "https://api.github.com/users/hackyon/events{/privacy}", "received_events_url": "https://api.github.com/users/hackyon/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hello @amyeroberts,\r\n\r\nI came up this PR to simply ignores all the failing tests for test_save_load_low_cpu_mem_usage(). This change should be safe as it only touches tests.\r\n\r\nThis should help unblock any PRs from being merged, while we work on getting tie_weights() into some of these models with #29024.\r\n\r\nI leave it up to you to decide this is worth merging.\r\n\r\nThanks! 🙏", "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29118). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "@hackyon Thanks for opening this and all of your work on adding this feature to our models! \r\n\r\nWe're going to revert #28948 and then add it back after the next release, which should happen tomorrow. \r\n\r\nUnfortunately, our test suite doesn't seem to be correctly picking up all of the necessary tests. I know you've run a check against all models but we want to be confident that everything is in a good and stable state before the release. \r\n\r\nWe can then combine the work in #29024 with all models having similar changes which address the current review comments. ", "Sounds good, thanks for taking care of this.\r\n\r\nOnce this rollback goes in, I can come up with a single PR that covers everything all in one. " ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29118/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29118", "html_url": "https://github.com/huggingface/transformers/pull/29118", "diff_url": "https://github.com/huggingface/transformers/pull/29118.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29118.patch", "merged_at": null }

{ "login": "kno10", "id": 3997899, "node_id": "MDQ6VXNlcjM5OTc4OTk=", "avatar_url": "https://avatars.githubusercontent.com/u/3997899?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kno10", "html_url": "https://github.com/kno10", "followers_url": "https://api.github.com/users/kno10/followers", "following_url": "https://api.github.com/users/kno10/following{/other_user}", "gists_url": "https://api.github.com/users/kno10/gists{/gist_id}", "starred_url": "https://api.github.com/users/kno10/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kno10/subscriptions", "organizations_url": "https://api.github.com/users/kno10/orgs", "repos_url": "https://api.github.com/users/kno10/repos", "events_url": "https://api.github.com/users/kno10/events{/privacy}", "received_events_url": "https://api.github.com/users/kno10/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29117). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29117/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29117", "html_url": "https://github.com/huggingface/transformers/pull/29117", "diff_url": "https://github.com/huggingface/transformers/pull/29117.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29117.patch", "merged_at": 1708392288000 }

{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29116). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Yep, should be unrelated to stopping criteria but I will check ", "@gante , I found what was the reason for tests to fail. It was flaky, so I just did an empty commit here. Now it's all green :)\r\n\r\nAlso, I tried to fix the flaky test, the PR for it is [here](https://github.com/huggingface/transformers/pull/29138) . I would love to get you review on that", "I support this - I'll make sure not to merge #28932 until this is in. After this is merged, I'll rebase and then modify my PR to also return a per-sample vector.", "@amyeroberts \r\n1. I ran all the slow tests, everything is fine.\r\n2. In this PR the stopping criterias will only give all true or all false. Since the main goal was to adapt to #28932 which can stop some sequences and not others, I believe it's better to add the test there. " ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29116/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29116", "html_url": "https://github.com/huggingface/transformers/pull/29116", "diff_url": "https://github.com/huggingface/transformers/pull/29116.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29116.patch", "merged_at": null }

{ "login": "jlamprou", "id": 41962910, "node_id": "MDQ6VXNlcjQxOTYyOTEw", "avatar_url": "https://avatars.githubusercontent.com/u/41962910?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jlamprou", "html_url": "https://github.com/jlamprou", "followers_url": "https://api.github.com/users/jlamprou/followers", "following_url": "https://api.github.com/users/jlamprou/following{/other_user}", "gists_url": "https://api.github.com/users/jlamprou/gists{/gist_id}", "starred_url": "https://api.github.com/users/jlamprou/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jlamprou/subscriptions", "organizations_url": "https://api.github.com/users/jlamprou/orgs", "repos_url": "https://api.github.com/users/jlamprou/repos", "events_url": "https://api.github.com/users/jlamprou/events{/privacy}", "received_events_url": "https://api.github.com/users/jlamprou/received_events", "type": "User", "site_admin": false }

[]

[]

[ "> Hey! Thanks for contributing. As there are no released checkpoints for sequence classification, we usually try to:\r\n> \r\n> 1. Open an issue with the feature request\r\n> \r\n> 2. If the issue has strong support from the community (usually around 10 likes for example) the add support for it 🤗\r\n> \r\n> \r\n> In this case you are the first user to request this new class! 🤗\r\n\r\nHi, I'm working on Classification checkpoint, it will be available once the training is done.", "@ArthurZucker @younesbelkada, I would also like your opinion about the usage of Z and Aux Loss on the Sequence Classification task. By my understanding Z loss is designed to improve the training stability of large language models and Mixture-of-Experts (MoE) models and the Aux loss for Multi-task learning and Regularization. ETA-50minutes for trained checkpoint on MNLI using the [run_glue.py](https://github.com/huggingface/transformers/blob/main/examples/pytorch/text-classification/run_glue.py).", "A trained checkpoint on SST2 [here](https://huggingface.co/glamprou/switch-base-8-sst2) and MNLI [here](https://huggingface.co/glamprou/switch-base-8-mnli)" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29115/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29115", "html_url": "https://github.com/huggingface/transformers/pull/29115", "diff_url": "https://github.com/huggingface/transformers/pull/29115.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29115.patch", "merged_at": null }

{ "login": "fxmarty", "id": 9808326, "node_id": "MDQ6VXNlcjk4MDgzMjY=", "avatar_url": "https://avatars.githubusercontent.com/u/9808326?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fxmarty", "html_url": "https://github.com/fxmarty", "followers_url": "https://api.github.com/users/fxmarty/followers", "following_url": "https://api.github.com/users/fxmarty/following{/other_user}", "gists_url": "https://api.github.com/users/fxmarty/gists{/gist_id}", "starred_url": "https://api.github.com/users/fxmarty/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fxmarty/subscriptions", "organizations_url": "https://api.github.com/users/fxmarty/orgs", "repos_url": "https://api.github.com/users/fxmarty/repos", "events_url": "https://api.github.com/users/fxmarty/events{/privacy}", "received_events_url": "https://api.github.com/users/fxmarty/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29114). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "@ArthurZucker @gante @LysandreJik This PR fixes many issues with the current `torch.compile` + static cache + generate implementation, as follow.\r\n\r\n## 1. Always keep the same stride for inputs in the decode phase\r\n\r\n`generate` apparently does not use directly the [`next_tokens`](https://github.com/huggingface/transformers/blob/1c81132e80478e278681686fe44dfec793d5dee9/src/transformers/generation/utils.py#L2440) variable as the next `input_ids`. Instead, the `next_tokens` are concatenated with previous tokens, and then [sliced](https://github.com/huggingface/transformers/blob/1c81132e80478e278681686fe44dfec793d5dee9/src/transformers/models/llama/modeling_llama.py#L1266), which results in the input tensors having different stride while having the same shape:\r\n\r\n```\r\n------------- loop forward in generate 0\r\nmodel_inputs input ids shape torch.Size([2, 7])\r\nmodel_inputs input ids stride (7, 1)\r\nmodel_inputs position_ids shape torch.Size([2, 7])\r\nmodel_inputs position_ids stride (7, 1)\r\n------------- loop forward in generate 1\r\nmodel_inputs input ids shape torch.Size([2, 1])\r\nmodel_inputs input ids stride (8, 1)\r\nmodel_inputs position_ids shape torch.Size([2, 1])\r\nmodel_inputs position_ids stride (8, 1)\r\n------------- loop forward in generate 2\r\nmodel_inputs input ids shape torch.Size([2, 1])\r\nmodel_inputs input ids stride (9, 1)\r\nmodel_inputs position_ids shape torch.Size([2, 1])\r\nmodel_inputs position_ids stride (9, 1)\r\n------------- loop forward in generate 3\r\nmodel_inputs input ids shape torch.Size([2, 1])\r\nmodel_inputs input ids stride (10, 1)\r\nmodel_inputs position_ids shape torch.Size([2, 1])\r\nmodel_inputs position_ids stride (10, 1)\r\n------------- loop forward in generate 4\r\netc.\r\n```\r\n\r\nThis is bad because with torch.compile there are guards on the stride of the inputs, and thus recompilation is triggered in the decode phase while this is really not necessary.\r\n\r\n```\r\nV0220 17:27:08.283680 140705660285312 torch/_dynamo/guards.py:1381] Recompiling function forward in /home/felix/transformers/src/transformers/models/llama/modeling_llama.py:1127\r\nV0220 17:27:08.283680 140705660285312 torch/_dynamo/guards.py:1381] triggered by the following guard failure(s):\r\nV0220 17:27:08.283680 140705660285312 torch/_dynamo/guards.py:1381] - tensor 'L['input_ids']' stride mismatch at index 0. expected 7, actual 8\r\n\r\n```\r\n&\r\n```\r\nV0220 17:27:12.636874 140705660285312 torch/_dynamo/guards.py:1381] Recompiling function torch_dynamo_resume_in_forward_at_989 in /home/felix/transformers/src/transformers/models/llama/modeling_llama.py:989\r\nV0220 17:27:12.636874 140705660285312 torch/_dynamo/guards.py:1381] triggered by the following guard failure(s):\r\nV0220 17:27:12.636874 140705660285312 torch/_dynamo/guards.py:1381] - tensor 'L['position_ids']' stride mismatch at index 0. expected 7, actual 8\r\n```\r\n\r\n## 2. Do not compile `_update_causal_mask`\r\n\r\n[`_update_causal_mask`](https://github.com/huggingface/transformers/blob/1c81132e80478e278681686fe44dfec793d5dee9/src/transformers/models/llama/modeling_llama.py#L1081) uses the input `attention_mask` length in its code. I believe this results in an FX `placehoder` being a SymInt,\r\n\r\n```\r\nV0220 11:30:30.341809 140023118176640 torch/_dynamo/output_graph.py:1084] [2/1] ===== __compiled_fn_12 =====\r\nV0220 11:30:30.341809 140023118176640 torch/_dynamo/output_graph.py:1084] [2/1] /home/felix/miniconda3/envs/fx/lib/python3.9/site-packages/torch/fx/_lazy_graph_module.py class GraphModule(torch.nn.Module):\r\nV0220 11:30:30.341809 140023118176640 torch/_dynamo/output_graph.py:1084] [2/1] def forward(self, s0 : torch.SymInt, L_attention_mask_ : torch.Tensor):\r\nV0220 11:30:30.341809 140023118176640 torch/_dynamo/output_graph.py:1084] [2/1] l_attention_mask_ = L_attention_mask_\r\n```\r\n\r\nwhich retriggers CUDAGraph capture for every decode step:\r\n```\r\nI0220 11:30:57.881897 140023118176640 torch/_inductor/cudagraph_trees.py:375] recording cudagraph tree for symint key 13\r\nI0220 11:30:57.902060 140023118176640 torch/_inductor/cudagraph_trees.py:375] recording cudagraph tree for symint key 14\r\nI0220 11:30:57.922157 140023118176640 torch/_inductor/cudagraph_trees.py:375] recording cudagraph tree for symint key 15\r\nI0220 11:30:57.942382 140023118176640 torch/_inductor/cudagraph_trees.py:375] recording cudagraph tree for symint key 16\r\nI0220 11:30:57.962995 140023118176640 torch/_inductor/cudagraph_trees.py:375] recording cudagraph tree for symint key 17\r\nI0220 11:30:57.983414 140023118176640 torch/_inductor/cudagraph_trees.py:375] recording cudagraph tree for symint key 18\r\nI0220 11:30:58.004108 140023118176640 torch/_inductor/cudagraph_trees.py:375] recording cudagraph tree for symint key 19\r\nI0220 11:30:58.024602 140023118176640 torch/_inductor/cudagraph_trees.py:375] recording cudagraph tree for symint key 20\r\nI0220 11:30:58.045034 140023118176640 torch/_inductor/cudagraph_trees.py:375] recording cudagraph tree for symint key 21\r\nI0220 11:30:58.065743 140023118176640 torch/_inductor/cudagraph_trees.py:375] recording cudagraph tree for symint key 22\r\nI0220 11:30:58.086160 140023118176640 torch/_inductor/cudagraph_trees.py:375] recording cudagraph tree for symint key 23\r\nI0220 11:30:58.106957 140023118176640 torch/_inductor/cudagraph_trees.py:375] recording cudagraph tree for symint key 24\r\nI0220 11:30:58.127666 140023118176640 torch/_inductor/cudagraph_trees.py:375] recording cudagraph tree for symint key 25\r\n```\r\n\r\nThis is very slow. We avoid capturing `_update_causal_mask` with `@torch.compiler.disable`, which fixes the issue (no more cuda graph capture after the very first decode step).\r\n\r\n## 3. Avoid using a stateful int `seen_tokens` (PyTorch bug)\r\n\r\nOn main, `StaticCache`'s [`seen_tokens`](https://github.com/huggingface/transformers/blob/main/src/transformers/cache_utils.py#L394) is bugged **only when using torch.compile** prior. Convince yourself with:\r\n\r\n```python\r\nfrom transformers import AutoTokenizer, AutoModelForCausalLM, GenerationConfig\r\nimport torch\r\nfrom transformers.cache_utils import StaticCache\r\n\r\ntokenizer = AutoTokenizer.from_pretrained(\r\n \"NousResearch/Llama-2-7b-chat-hf\", padding_side=\"left\", pad_token=\"<s>\"\r\n)\r\n\r\nwith torch.device(\"cuda\"):\r\n model = AutoModelForCausalLM.from_pretrained(\r\n \"NousResearch/Llama-2-7b-chat-hf\",\r\n torch_dtype=torch.float16,\r\n attn_implementation=\"sdpa\",\r\n )\r\n\r\ninputs = tokenizer(\r\n [\"I would\", \"Today I am in Paris and\"], padding=True, return_tensors=\"pt\"\r\n).to(model.device)\r\n\r\nnew_tokens = 10\r\ngen_config = GenerationConfig(\r\n max_new_tokens=new_tokens,\r\n min_new_tokens=new_tokens,\r\n use_cache=True,\r\n pad_token_id=tokenizer.pad_token_id,\r\n num_beams=1,\r\n do_sample=False,\r\n eos_token_id=None, # This is required for min_new_tokens to actually have an effect.\r\n)\r\nmodel.generation_config.eos_token_id = None # greedy_search falls back on this eos_token_id that we need to set to None as well for min_new_tokens to have an effect.\r\n\r\ngen_out = model.generate(**inputs, generation_config=gen_config)\r\n\r\ndecoded = tokenizer.batch_decode(gen_out, skip_special_tokens=True)\r\n\r\nprint(\"decoded\", decoded)\r\n\r\nprint(\"compiling...\")\r\n\r\nmodel.forward = torch.compile(model.forward, mode=\"reduce-overhead\")\r\nprint(\"Finished compile call\")\r\n\r\n# warmup\r\ngen_out = model.generate(**inputs, generation_config=gen_config, cache_implementation=\"static\")\r\n\r\nprint(\"\\n\\n\\n\\n\\n\\n----- second call\")\r\ngen_out = model.generate(**inputs, generation_config=gen_config, cache_implementation=\"static\")\r\n\r\ndecoded = tokenizer.batch_decode(gen_out, skip_special_tokens=True)\r\n\r\nprint(\"decoded static\", decoded)\r\n```\r\n\r\nwhich yields\r\n\r\n\r\n\r\nUsing a `torch.Tensor` updated in-place instead of `int` fixes the bug, however we then hit what I believe to be a torch.compile bug where subclasses are added after the `torch.compile` call (in the `_setup_cache`). Even with the above fix, there is still a bug where `seen_tokens` is not properly updated. By making sure `_setup_cache` is called **BEFORE** `torch.compile`, this issue disappears. However this required an API change, so disreguarding this approach.\r\n\r\nInstead, **remove `seen_tokens` altogether from StaticCache.**\r\n\r\n## Results\r\n\r\nOn `main` (ee3af60be0d21044692211d97dfd858aa3e4b418):\r\n\r\n```\r\n-------------- STATIC CACHE\r\ncompiling...\r\ntorch.compile call: 703.207 ms\r\n/home/felix/miniconda3/envs/fx/lib/python3.9/site-packages/torch/_inductor/compile_fx.py:148: UserWarning: TensorFloat32 tensor cores for float32 matrix multiplication available but not enabled. Consider setting `torch.set_float32_matmul_precision('high')` for better performance.\r\n warnings.warn(\r\n\r\n- 0-th `generate` call latency per token (new_tokens=20): 10591.283 ms\r\n\r\n- 1-th `generate` call latency per token (new_tokens=20): 3284.225 ms\r\n\r\n- 2-th `generate` call latency per token (new_tokens=20): 132.769 ms\r\n\r\n- 3-th `generate` call latency per token (new_tokens=20): 11.211 ms\r\n\r\n- 4-th `generate` call latency per token (new_tokens=20): 11.160 ms\r\ndecoded static ['I would like to know how to get a copy of my medical records from my primary care physician.\\n', 'Today I am in Paris and I am feeling very grateful for this opportunity to explore this beautiful city. I have always wanted to visit']\r\n```\r\n\r\nOn this branch (0c03b7d45d7948363a6ece0e921b21f8c4e78286):\r\n```\r\n-------------- STATIC CACHE\r\ncompiling...\r\ntorch.compile call: 729.943 ms\r\n/home/felix/miniconda3/envs/fx/lib/python3.9/site-packages/torch/_inductor/compile_fx.py:148: UserWarning: TensorFloat32 tensor cores for float32 matrix multiplication available but not enabled. Consider setting `torch.set_float32_matmul_precision('high')` for better performance.\r\n warnings.warn(\r\n\r\n- 0-th `generate` call latency per token (new_tokens=20): 4121.241 ms\r\n\r\n- 1-th `generate` call latency per token (new_tokens=20): 239.070 ms\r\n\r\n- 2-th `generate` call latency per token (new_tokens=20): 11.592 ms\r\n\r\n- 3-th `generate` call latency per token (new_tokens=20): 11.602 ms\r\n\r\n- 4-th `generate` call latency per token (new_tokens=20): 11.618 ms\r\ndecoded static ['I would like to know how to get a copy of my medical records from my primary care physician.\\n', 'Today I am in Paris and I am feeling very grateful for this opportunity to explore this beautiful city. I have always wanted to visit']\r\n```", "```python \r\ntorch._dynamo.exc.Unsupported: 'inline in skipfiles: LlamaModel._update_causal_mask | _fn /home/arthur/miniconda3/envs/py39/lib/python3.9/site-packages/torch/_dynamo/eval_frame.py, skipped according skipfiles.SKIP_DIRS'\r\n```\r\nfailing on torch2.2 let's wait a tad bit (that was full graph!)", "Leaving this open for now, as we would like to avoid `@torch.compiler.disable` and keep compatibility with `fullgraph=True`.\r\n\r\nThere is likely a bug in PyTorch where CUDA graphs are rerecorded while they should not, so we can't simply remove `@torch.compiler.disable`.", "@fxmarty btw, I am [working on PR](https://github.com/huggingface/transformers/pull/29005) that has some of the changes that you added here (such as resetting the cache after generate), we might get merge conflicts :) ", "Thank you @gante, awesome! Yes, I think there needs to be an alignment at some point between all different archs, it's getting a bit complex with all the different approaches.\r\n\r\nAt the end of the day after discussing with @ArthurZucker, merging but not cherry picking in the release. I removed the `@torch.compiler.disable` decorator for the reason above.\r\n\r\nI believe there is a bug in PyTorch where cuda graphs are somehow rerecorded in the second pass.\r\n```\r\n- 0-th `generate` call latency per token (new_tokens=100): 744.209 ms\r\n\r\n- 1-th `generate` call latency per token (new_tokens=100): 1773.975 ms\r\n\r\n- 2-th `generate` call latency per token (new_tokens=100): 11.069 ms\r\n\r\n- 3-th `generate` call latency per token (new_tokens=100): 11.042 ms\r\n\r\n- 4-th `generate` call latency per token (new_tokens=100): 11.035 ms\r\ndecoded static [\"I would like to know how to get a copy of my medical records from my primary care physician.\\nI would like to know how to get a copy of my medical records from my primary care physician.\\nGetting a copy of your medical records from your primary care physician can be a straightforward process, but it's important to follow the proper steps to ensure you receive a complete and accurate copy of your records. Here are the general steps you can take:\\n\\n1. Contact your\", \"Today I am in Paris and I am feeling very grateful for this opportunity to explore this beautiful city. I have always wanted to visit Paris and now I am finally here, and it is even more beautiful than I imagined. The Eiffel Tower is stunning, the Louvre is incredible, and the food is delicious. I am soaking up every moment and making the most of my time here. I can't wait to see what the rest of the trip has in store for me. #grateful\"]\r\n```", "^ reference for this https://github.com/pytorch/pytorch/issues/120309" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29114/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 1 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29114", "html_url": "https://github.com/huggingface/transformers/pull/29114", "diff_url": "https://github.com/huggingface/transformers/pull/29114.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29114.patch", "merged_at": null }

{ "login": "nikhilajoshy", "id": 37141775, "node_id": "MDQ6VXNlcjM3MTQxNzc1", "avatar_url": "https://avatars.githubusercontent.com/u/37141775?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nikhilajoshy", "html_url": "https://github.com/nikhilajoshy", "followers_url": "https://api.github.com/users/nikhilajoshy/followers", "following_url": "https://api.github.com/users/nikhilajoshy/following{/other_user}", "gists_url": "https://api.github.com/users/nikhilajoshy/gists{/gist_id}", "starred_url": "https://api.github.com/users/nikhilajoshy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nikhilajoshy/subscriptions", "organizations_url": "https://api.github.com/users/nikhilajoshy/orgs", "repos_url": "https://api.github.com/users/nikhilajoshy/repos", "events_url": "https://api.github.com/users/nikhilajoshy/events{/privacy}", "received_events_url": "https://api.github.com/users/nikhilajoshy/received_events", "type": "User", "site_admin": false }

[]

{ "login": "kashif", "id": 8100, "node_id": "MDQ6VXNlcjgxMDA=", "avatar_url": "https://avatars.githubusercontent.com/u/8100?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kashif", "html_url": "https://github.com/kashif", "followers_url": "https://api.github.com/users/kashif/followers", "following_url": "https://api.github.com/users/kashif/following{/other_user}", "gists_url": "https://api.github.com/users/kashif/gists{/gist_id}", "starred_url": "https://api.github.com/users/kashif/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kashif/subscriptions", "organizations_url": "https://api.github.com/users/kashif/orgs", "repos_url": "https://api.github.com/users/kashif/repos", "events_url": "https://api.github.com/users/kashif/events{/privacy}", "received_events_url": "https://api.github.com/users/kashif/received_events", "type": "User", "site_admin": false }

[ { "login": "kashif", "id": 8100, "node_id": "MDQ6VXNlcjgxMDA=", "avatar_url": "https://avatars.githubusercontent.com/u/8100?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kashif", "html_url": "https://github.com/kashif", "followers_url": "https://api.github.com/users/kashif/followers", "following_url": "https://api.github.com/users/kashif/following{/other_user}", "gists_url": "https://api.github.com/users/kashif/gists{/gist_id}", "starred_url": "https://api.github.com/users/kashif/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kashif/subscriptions", "organizations_url": "https://api.github.com/users/kashif/orgs", "repos_url": "https://api.github.com/users/kashif/repos", "events_url": "https://api.github.com/users/kashif/events{/privacy}", "received_events_url": "https://api.github.com/users/kashif/received_events", "type": "User", "site_admin": false } ]

[ "cc @kashif @NielsRogge ", "@nikhilajoshy can you kindly paste in some more verbose error?", "@kashif \r\n```\r\noutputs = model(\r\n ^^^^^^\r\n File \"/home/nikhila/encdec_venv/lib/python3.11/site-packages/torch/nn/modules/module.py\", line 1511, in _wrapped_call_impl\r\n return self._call_impl(*args, **kwargs)\r\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n File \"/home/nikhila/encdec_venv/lib/python3.11/site-packages/torch/nn/modules/module.py\", line 1520, in _call_impl\r\n return forward_call(*args, **kwargs)\r\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n File \"/home/nikhila/encdec_venv/lib/python3.11/site-packages/transformers/models/time_series_transformer/modeling_time_series_transformer.py\", line 1384, in forward\r\n transformer_inputs, loc, scale, static_feat = self.create_network_inputs(\r\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n File \"/home/nikhila/encdec_venv/lib/python3.11/site-packages/transformers/models/time_series_transformer/modeling_time_series_transformer.py\", line 1304, in create_network_inputs\r\n lagged_sequence = self.get_lagged_subsequences(sequence=inputs, subsequences_length=subsequences_length)\r\n```" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29113/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "LysandreJik", "id": 30755778, "node_id": "MDQ6VXNlcjMwNzU1Nzc4", "avatar_url": "https://avatars.githubusercontent.com/u/30755778?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LysandreJik", "html_url": "https://github.com/LysandreJik", "followers_url": "https://api.github.com/users/LysandreJik/followers", "following_url": "https://api.github.com/users/LysandreJik/following{/other_user}", "gists_url": "https://api.github.com/users/LysandreJik/gists{/gist_id}", "starred_url": "https://api.github.com/users/LysandreJik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LysandreJik/subscriptions", "organizations_url": "https://api.github.com/users/LysandreJik/orgs", "repos_url": "https://api.github.com/users/LysandreJik/repos", "events_url": "https://api.github.com/users/LysandreJik/events{/privacy}", "received_events_url": "https://api.github.com/users/LysandreJik/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Before this ungodly PR gets merged, I need to check that every checkpoint referenced here behaves the same once its pretrained map has been removed. \r\n\r\nI'll link the PRs open as a result in this comment.\r\n\r\n🟣: merged\r\n🟢: open\r\n🔴: closed\r\n🟡: not open yet\r\n\r\n## Repos with PRs opened\r\n\r\n### ALBERT\r\n🟣 [albert/albert-base-v1#2](https://huggingface.co/albert/albert-base-v1/discussions/2)\r\n🟣 [albert/albert-base-v2#6](https://huggingface.co/albert/albert-base-v2/discussions/6)\r\n🟣 [albert/albert-large-v1#2](https://huggingface.co/albert/albert-large-v1/discussions/2)\r\n🟣 [albert/albert-large-v2#3](https://huggingface.co/albert/albert-large-v2/discussions/3)\r\n🟣 [albert/albert-xlarge-v1#2](https://huggingface.co/albert/albert-xlarge-v1/discussions/2)\r\n🟣 [albert/albert-xlarge-v2#2](https://huggingface.co/albert/albert-xlarge-v2/discussions/2)\r\n🟣 [albert/albert-xxlarge-v1#3](https://huggingface.co/albert/albert-xxlarge-v1/discussions/3)\r\n🟣 [albert/albert-xxlarge-v2#3](https://huggingface.co/albert/albert-xxlarge-v2/discussions/3)\r\n\r\n### BERT\r\n\r\n🟣 [google-bert/bert-base-cased#10](https://huggingface.co/google-bert/bert-base-cased/discussions/10)\r\n🟣 [google-bert/bert-base-cased-finetuned-mrpc#2](https://huggingface.co/google-bert/bert-base-cased-finetuned-mrpc/discussions/2)\r\n🟣 [google-bert/bert-base-chinese#16](https://huggingface.co/google-bert/bert-base-chinese/discussions/16)\r\n🟣 [google-bert/bert-base-german-cased#5](https://huggingface.co/google-bert/bert-base-german-cased/discussions/5)\r\n🟣 [google-bert/bert-base-german-dbmdz-cased#4](https://huggingface.co/google-bert/bert-base-german-dbmdz-cased/discussions/4)\r\n🟣 [google-bert/bert-base-german-dbmdz-uncased#4](https://huggingface.co/google-bert/bert-base-german-dbmdz-uncased/discussions/4)\r\n🟣 [google-bert/bert-base-multilingual-cased#5](https://huggingface.co/google-bert/bert-base-multilingual-cased/discussions/5)\r\n🟣 [google-bert/bert-base-multilingual-uncased#5](https://huggingface.co/google-bert/bert-base-multilingual-uncased/discussions/5)\r\n🟣 [google-bert/bert-base-uncased#62](https://huggingface.co/google-bert/bert-base-uncased/discussions/62)\r\n🟣 [google-bert/bert-large-cased#3](https://huggingface.co/google-bert/bert-large-cased/discussions/3)\r\n🟣 [google-bert/bert-large-cased-whole-word-masking#2](https://huggingface.co/google-bert/bert-large-cased-whole-word-masking/discussions/2)\r\n🟣 [google-bert/bert-large-cased-whole-word-masking-finetuned-squad#2](https://huggingface.co/google-bert/bert-large-cased-whole-word-masking-finetuned-squad/discussions/2)\r\n🟣 [google-bert/bert-large-uncased#3](https://huggingface.co/google-bert/bert-large-uncased/discussions/3)\r\n🟣 [google-bert/bert-large-uncased-whole-word-masking#3](https://huggingface.co/google-bert/bert-large-uncased-whole-word-masking/discussions/3)\r\n🟣 [google-bert/bert-large-uncased-whole-word-masking-finetuned-squad#4](https://huggingface.co/google-bert/bert-large-uncased-whole-word-masking-finetuned-squad/discussions/4)\r\n\r\n### CamemBERT\r\n\r\n🟢 [almanach/camembert-base#7](https://huggingface.co/almanach/camembert-base/discussions/7)\r\n\r\n### CTRL\r\n\r\n🟣 [Salesforce/ctrl#4](https://huggingface.co/Salesforce/ctrl/discussions/4)\r\n\r\n### DistilBERT\r\n\r\n🟣 [distilbert/distilgpt2#11](https://huggingface.co/distilbert/distilgpt2/discussions/11)\r\n🟣 [distilbert/distilroberta-base#4](https://huggingface.co/distilbert/distilroberta-base/discussions/4)\r\n\r\n### GPT-2\r\n\r\n🟣 [openai-community/gpt2#80](https://huggingface.co/openai-community/gpt2/discussions/80)\r\n🟣 [openai-community/gpt2-large#7](https://huggingface.co/openai-community/gpt2-large/discussions/7)\r\n🟣 [openai-community/gpt2-medium#13](https://huggingface.co/openai-community/gpt2-medium/discussions/13)\r\n🟣 [openai-community/gpt2-xl#9](https://huggingface.co/openai-community/gpt2-xl/discussions/9)\r\n\r\n### OpenAI GPT\r\n\r\n🟣 [openai-community/openai-gpt#6](https://huggingface.co/openai-community/openai-gpt/discussions/6)\r\n\r\n### RoBERTa\r\n\r\n🟣 [FacebookAI/roberta-base#12](https://huggingface.co/FacebookAI/roberta-base/discussions/12)\r\n🟣 [openai-community/roberta-base-openai-detector#17](https://huggingface.co/openai-community/roberta-base-openai-detector/discussions/17)\r\n🟣 [FacebookAI/roberta-large#6](https://huggingface.co/FacebookAI/roberta-large/discussions/6)\r\n🟣 [FacebookAI/roberta-large-mnli#8](https://huggingface.co/FacebookAI/roberta-large-mnli/discussions/8)\r\n🟣 [openai-community/roberta-large-openai-detector#5](https://huggingface.co/openai-community/roberta-large-openai-detector/discussions/5)\r\n🟣 [FacebookAI/xlm-roberta-base#27](https://huggingface.co/FacebookAI/xlm-roberta-base/discussions/27)\r\n🟣 [FacebookAI/xlm-roberta-large#17](https://huggingface.co/FacebookAI/xlm-roberta-large/discussions/17)\r\n🟣 [FacebookAI/xlm-roberta-large-finetuned-conll02-dutch#3](https://huggingface.co/FacebookAI/xlm-roberta-large-finetuned-conll02-dutch/discussions/3)\r\n🟣 [FacebookAI/xlm-roberta-large-finetuned-conll02-spanish#3](https://huggingface.co/FacebookAI/xlm-roberta-large-finetuned-conll02-spanish/discussions/3)\r\n🟣 [FacebookAI/xlm-roberta-large-finetuned-conll03-english#11](https://huggingface.co/FacebookAI/xlm-roberta-large-finetuned-conll03-english/discussions/11)\r\n🟣 [FacebookAI/xlm-roberta-large-finetuned-conll03-german#4](https://huggingface.co/FacebookAI/xlm-roberta-large-finetuned-conll03-german/discussions/4)\r\n\r\n## Non-canonical models\r\n\r\n🟢 [facebook/m2m100_418M#16](https://huggingface.co/facebook/m2m100_418M/discussions/16)\r\n🟢 [openai/clip-vit-base-patch32#13](https://huggingface.co/openai/clip-vit-base-patch32/discussions/13)\r\n🟢 [google/bigbird-roberta-large#2](https://huggingface.co/google/bigbird-roberta-large/discussions/2)\r\n🟢 [google/bigbird-base-trivia-itc#2](https://huggingface.co/google/bigbird-base-trivia-itc/discussions/2)\r\n🟢 [google/rembert#2](https://huggingface.co/google/rembert/discussions/2)\r\n🟢 [YituTech/conv-bert-base#4](https://huggingface.co/YituTech/conv-bert-base/discussions/4)\r\n🟢 [YituTech/conv-bert-medium-small#2](https://huggingface.co/YituTech/conv-bert-medium-small/discussions/2)\r\n🟢 [YituTech/conv-bert-small#2](https://huggingface.co/YituTech/conv-bert-small/discussions/2)\r\n🔴 [facebook/wav2vec2-lv-60-espeak-cv-ft#5](https://huggingface.co/facebook/wav2vec2-lv-60-espeak-cv-ft/discussions/5)\r\n🟢 [facebook/blenderbot_small-90M#5](https://huggingface.co/facebook/blenderbot_small-90M/discussions/5)\r\n🟢 [funnel-transformer/small#2](https://huggingface.co/funnel-transformer/small/discussions/2)\r\n🟢 [funnel-transformer/small-base#2](https://huggingface.co/funnel-transformer/small-base/discussions/2)\r\n🟢 [funnel-transformer/medium#2](https://huggingface.co/funnel-transformer/medium/discussions/2)\r\n🟢 [funnel-transformer/medium-base#1](https://huggingface.co/funnel-transformer/medium-base/discussions/1)\r\n🟢 [funnel-transformer/intermediate#2](https://huggingface.co/funnel-transformer/intermediate/discussions/2)\r\n🟢 [funnel-transformer/intermediate-base#2](https://huggingface.co/funnel-transformer/intermediate-base/discussions/2)\r\n🟢 [funnel-transformer/large#3](https://huggingface.co/funnel-transformer/large/discussions/3)\r\n🟢 [funnel-transformer/large-base#1](https://huggingface.co/funnel-transformer/large-base/discussions/1)\r\n🟢 [funnel-transformer/xlarge#2](https://huggingface.co/funnel-transformer/xlarge/discussions/2)\r\n🟢 [funnel-transformer/xlarge-base#2](https://huggingface.co/funnel-transformer/xlarge-base/discussions/2)\r\n🟡 [flaubert/flaubert_small_cased#2](https://huggingface.co/flaubert/flaubert_small_cased/discussions/2)\r\n🟡 [flaubert/flaubert_base_uncased#2](https://huggingface.co/flaubert/flaubert_base_uncased/discussions/2)\r\n🟡 [flaubert/flaubert_base_cased#2](https://huggingface.co/flaubert/flaubert_base_cased/discussions/2)\r\n🟡 [flaubert/flaubert_large_cased#2](https://huggingface.co/flaubert/flaubert_large_cased/discussions/2)\r\n🟢 [google/realm-cc-news-pretrained-embedder#1](https://huggingface.co/google/realm-cc-news-pretrained-embedder/discussions/1)\r\n🟢 [google/realm-cc-news-pretrained-encoder#1](https://huggingface.co/google/realm-cc-news-pretrained-encoder/discussions/1)\r\n🟢 [google/realm-cc-news-pretrained-scorer#1](https://huggingface.co/google/realm-cc-news-pretrained-scorer/discussions/1)\r\n🟢 [google/realm-cc-news-pretrained-openqa#1](https://huggingface.co/google/realm-cc-news-pretrained-openqa/discussions/1)\r\n🟢 [google/realm-orqa-nq-openqa#1](https://huggingface.co/google/realm-orqa-nq-openqa/discussions/1)\r\n🟢 [google/realm-orqa-nq-reader#1](https://huggingface.co/google/realm-orqa-nq-reader/discussions/1)\r\n🟢 [google/realm-orqa-wq-openqa#1](https://huggingface.co/google/realm-orqa-wq-openqa/discussions/1)\r\n🟢 [google/realm-orqa-wq-reader#1](https://huggingface.co/google/realm-orqa-wq-reader/discussions/1)\r\n🟢 [google/fnet-base#1](https://huggingface.co/google/fnet-base/discussions/1)\r\n🟢 [google/fnet-large#1](https://huggingface.co/google/fnet-large/discussions/1)\r\n🟢 [microsoft/mpnet-base#4](https://huggingface.co/microsoft/mpnet-base/discussions/4)\r\n🟢 [google/reformer-crime-and-punishment#2](https://huggingface.co/google/reformer-crime-and-punishment/discussions/2)\r\n🟢 [facebook/s2t-wav2vec2-large-en-de#3](https://huggingface.co/facebook/s2t-wav2vec2-large-en-de/discussions/3)\r\n🟢 [allenai/longformer-base-4096#6](https://huggingface.co/allenai/longformer-base-4096/discussions/6)\r\n🟢 [allenai/longformer-large-4096#3](https://huggingface.co/allenai/longformer-large-4096/discussions/3)\r\n🟢 [allenai/longformer-large-4096-finetuned-triviaqa#4](https://huggingface.co/allenai/longformer-large-4096-finetuned-triviaqa/discussions/4)\r\n🟢 [allenai/longformer-base-4096-extra.pos.embd.only#2](https://huggingface.co/allenai/longformer-base-4096-extra.pos.embd.only/discussions/2)\r\n🟢 [allenai/longformer-large-4096-extra.pos.embd.only#2](https://huggingface.co/allenai/longformer-large-4096-extra.pos.embd.only/discussions/2)\r\n🟢 [cl-tohoku/bert-base-japanese#2](https://huggingface.co/tohoku-nlp/bert-base-japanese/discussions/2)\r\n🟢 [cl-tohoku/bert-base-japanese-whole-word-masking#3](https://huggingface.co/tohoku-nlp/bert-base-japanese-whole-word-masking/discussions/3)\r\n🟢 [cl-tohoku/bert-base-japanese-char#2](https://huggingface.co/tohoku-nlp/bert-base-japanese-char/discussions/2)\r\n🟢 [cl-tohoku/bert-base-japanese-char-whole-word-masking#2](https://huggingface.co/tohoku-nlp/bert-base-japanese-char-whole-word-masking/discussions/2)\r\n🟢 [google/electra-small-generator#4](https://huggingface.co/google/electra-small-generator/discussions/4)\r\n🟢 [google/electra-base-generator#2](https://huggingface.co/google/electra-base-generator/discussions/2)\r\n🟢 [google/electra-large-generator#2](https://huggingface.co/google/electra-large-generator/discussions/2)\r\n🟢 [google/electra-small-discriminator#1](https://huggingface.co/google/electra-small-discriminator/discussions/1)\r\n🟢 [google/electra-base-discriminator#3](https://huggingface.co/google/electra-base-discriminator/discussions/3)\r\n🟢 [google/electra-large-discriminator#1](https://huggingface.co/google/electra-large-discriminator/discussions/1)\r\n🟢 [microsoft/layoutlmv2-base-uncased#5](https://huggingface.co/microsoft/layoutlmv2-base-uncased/discussions/5)\r\n🟢 [microsoft/layoutlmv2-large-uncased#3](https://huggingface.co/microsoft/layoutlmv2-large-uncased/discussions/3)\r\n🟢 [microsoft/deberta-v2-xlarge#3](https://huggingface.co/microsoft/deberta-v2-xlarge/discussions/3)\r\n🟢 [microsoft/deberta-v2-xxlarge#4](https://huggingface.co/microsoft/deberta-v2-xxlarge/discussions/4)\r\n🟣 [microsoft/deberta-v2-xlarge-mnli#2](https://huggingface.co/microsoft/deberta-v2-xlarge-mnli/discussions/2)\r\n🟢 [microsoft/deberta-v2-xxlarge-mnli#2](https://huggingface.co/microsoft/deberta-v2-xxlarge-mnli/discussions/2)\r\n🟢 [vinai/bartpho-syllable#3](https://huggingface.co/vinai/bartpho-syllable/discussions/3)\r\n🟢 [Helsinki-NLP/opus-mt-en-de#6](https://huggingface.co/Helsinki-NLP/opus-mt-en-de/discussions/6)\r\n🟢 [facebook/bart-base#4](https://huggingface.co/facebook/bart-base/discussions/4)\r\n🟢 [facebook/bart-large-cnn#71](https://huggingface.co/facebook/bart-large-cnn/discussions/71)\r\n🟢 [yjernite/bart_eli5#2](https://huggingface.co/yjernite/bart_eli5/discussions/2)\r\n🟢 [microsoft/layoutlm-base-uncased#3](https://huggingface.co/microsoft/layoutlm-base-uncased/discussions/3)\r\n🟢 [microsoft/layoutlm-large-uncased#1](https://huggingface.co/microsoft/layoutlm-large-uncased/discussions/1)\r\n🟢 [junnyu/roformer_chinese_char_small#1](https://huggingface.co/junnyu/roformer_chinese_char_small/discussions/1)\r\n🟢 [junnyu/roformer_chinese_char_base#1](https://huggingface.co/junnyu/roformer_chinese_char_base/discussions/1)\r\n🟢 [junnyu/roformer_small_discriminator#2](https://huggingface.co/junnyu/roformer_small_discriminator/discussions/2)\r\n🟢 [junnyu/roformer_small_generator#2](https://huggingface.co/junnyu/roformer_small_generator/discussions/2)\r\n🟢 [uclanlp/plbart-base#6](https://huggingface.co/uclanlp/plbart-base/discussions/6)\r\n🟢 [uclanlp/plbart-c-cpp-defect-detection#4](https://huggingface.co/uclanlp/plbart-c-cpp-defect-detection/discussions/4)\r\n🟢 [uclanlp/plbart-cs-java#1](https://huggingface.co/uclanlp/plbart-cs-java/discussions/1)\r\n🟢 [uclanlp/plbart-en_XX-java#2](https://huggingface.co/uclanlp/plbart-en_XX-java/discussions/2)\r\n🟢 [uclanlp/plbart-go-en_XX#1](https://huggingface.co/uclanlp/plbart-go-en_XX/discussions/1)\r\n🟢 [uclanlp/plbart-java-clone-detection#2](https://huggingface.co/uclanlp/plbart-java-clone-detection/discussions/2)\r\n🟢 [uclanlp/plbart-java-cs#3](https://huggingface.co/uclanlp/plbart-java-cs/discussions/3)\r\n🟢 [uclanlp/plbart-java-en_XX#2](https://huggingface.co/uclanlp/plbart-java-en_XX/discussions/2)\r\n🟢 [uclanlp/plbart-javascript-en_XX#2](https://huggingface.co/uclanlp/plbart-javascript-en_XX/discussions/2)\r\n🟢 [uclanlp/plbart-php-en_XX#2](https://huggingface.co/uclanlp/plbart-php-en_XX/discussions/2)\r\n🟢 [uclanlp/plbart-python-en_XX#2](https://huggingface.co/uclanlp/plbart-python-en_XX/discussions/2)\r\n🟢 [uclanlp/plbart-refine-java-medium#1](https://huggingface.co/uclanlp/plbart-refine-java-medium/discussions/1)\r\n🟢 [uclanlp/plbart-refine-java-small#2](https://huggingface.co/uclanlp/plbart-refine-java-small/discussions/2)\r\n🟢 [uclanlp/plbart-ruby-en_XX#1](https://huggingface.co/uclanlp/plbart-ruby-en_XX/discussions/1)\r\n🟢 [openbmb/cpm-ant-10b#2](https://huggingface.co/openbmb/cpm-ant-10b/discussions/2)\r\n🟢 [microsoft/deberta-base#5](https://huggingface.co/microsoft/deberta-base/discussions/5)\r\n🟢 [microsoft/deberta-large#4](https://huggingface.co/microsoft/deberta-large/discussions/4)\r\n🟢 [microsoft/deberta-xlarge#2](https://huggingface.co/microsoft/deberta-xlarge/discussions/2)\r\n🟢 [microsoft/deberta-base-mnli#1](https://huggingface.co/microsoft/deberta-base-mnli/discussions/1)\r\n🟢 [microsoft/deberta-large-mnli#1](https://huggingface.co/microsoft/deberta-large-mnli/discussions/1)\r\n🟢 [microsoft/deberta-xlarge-mnli#5](https://huggingface.co/microsoft/deberta-xlarge-mnli/discussions/5)\r\n🟢 [vinai/bertweet-base#5](https://huggingface.co/vinai/bertweet-base/discussions/5)\r\n🟢 [AI-Sweden-Models/gpt-sw3-126m#5](https://huggingface.co/AI-Sweden-Models/gpt-sw3-126m/discussions/5)\r\n🟢 [AI-Sweden-Models/gpt-sw3-356m#4](https://huggingface.co/AI-Sweden-Models/gpt-sw3-356m/discussions/4)\r\n🟢 [AI-Sweden-Models/gpt-sw3-1.3b#4](https://huggingface.co/AI-Sweden-Models/gpt-sw3-1.3b/discussions/4)\r\n🟢 [AI-Sweden-Models/gpt-sw3-6.7b#5](https://huggingface.co/AI-Sweden-Models/gpt-sw3-6.7b/discussions/5)\r\n🟢 [AI-Sweden-Models/gpt-sw3-6.7b-v2#4](https://huggingface.co/AI-Sweden-Models/gpt-sw3-6.7b-v2/discussions/4)\r\n🟢 [AI-Sweden-Models/gpt-sw3-20b#6](https://huggingface.co/AI-Sweden-Models/gpt-sw3-20b/discussions/6)\r\n🟣 [AI-Sweden-Models/gpt-sw3-40b#4](https://huggingface.co/AI-Sweden-Models/gpt-sw3-40b/discussions/4)\r\n🟢 [facebook/mbart-large-50-one-to-many-mmt#7](https://huggingface.co/facebook/mbart-large-50-one-to-many-mmt/discussions/7)\r\n🟢 [facebook/xglm-564M#7](https://huggingface.co/facebook/xglm-564M/discussions/7)\r\n🟢 [facebook/blenderbot-3B#7](https://huggingface.co/facebook/blenderbot-3B/discussions/7)\r\n🟢 [microsoft/prophetnet-large-uncased#2](https://huggingface.co/microsoft/prophetnet-large-uncased/discussions/2)\r\n🟢 [microsoft/xprophetnet-large-wiki100-cased#1](https://huggingface.co/microsoft/xprophetnet-large-wiki100-cased/discussions/1)\r\n🟢 [squeezebert/squeezebert-uncased#3](https://huggingface.co/squeezebert/squeezebert-uncased/discussions/3)\r\n🟢 [squeezebert/squeezebert-mnli#2](https://huggingface.co/squeezebert/squeezebert-mnli/discussions/2)\r\n🟢 [squeezebert/squeezebert-mnli-headless#2](https://huggingface.co/squeezebert/squeezebert-mnli-headless/discussions/2)\r\n🟢 [abeja/gpt-neox-japanese-2.7b#5](https://huggingface.co/abeja/gpt-neox-japanese-2.7b/discussions/5)\r\n🟢 [microsoft/biogpt#26](https://huggingface.co/microsoft/biogpt/discussions/26)\r\n🔴 [facebook/wav2vec2-base-960h#11](https://huggingface.co/facebook/wav2vec2-base-960h/discussions/11)\r\n🟣 [moussaKam/mbarthez#2](https://huggingface.co/moussaKam/mbarthez/discussions/2)\r\n🟣 [moussaKam/barthez#3](https://huggingface.co/moussaKam/barthez/discussions/3)\r\n🟣 [moussaKam/barthez-orangesum-title#2](https://huggingface.co/moussaKam/barthez-orangesum-title/discussions/2)\r\n🟢 [vinai/phobert-base#5](https://huggingface.co/vinai/phobert-base/discussions/5)\r\n🟢 [vinai/phobert-large#2](https://huggingface.co/vinai/phobert-large/discussions/2)\r\n🟢 [facebook/mbart-large-en-ro#3](https://huggingface.co/facebook/mbart-large-en-ro/discussions/3)\r\n🟢 [facebook/mbart-large-cc25#5](https://huggingface.co/facebook/mbart-large-cc25/discussions/5)\r\n", "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29112). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29112/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29112", "html_url": "https://github.com/huggingface/transformers/pull/29112", "diff_url": "https://github.com/huggingface/transformers/pull/29112.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29112.patch", "merged_at": null }

{ "login": "sedrick-keh-tri", "id": 133716510, "node_id": "U_kgDOB_haHg", "avatar_url": "https://avatars.githubusercontent.com/u/133716510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sedrick-keh-tri", "html_url": "https://github.com/sedrick-keh-tri", "followers_url": "https://api.github.com/users/sedrick-keh-tri/followers", "following_url": "https://api.github.com/users/sedrick-keh-tri/following{/other_user}", "gists_url": "https://api.github.com/users/sedrick-keh-tri/gists{/gist_id}", "starred_url": "https://api.github.com/users/sedrick-keh-tri/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sedrick-keh-tri/subscriptions", "organizations_url": "https://api.github.com/users/sedrick-keh-tri/orgs", "repos_url": "https://api.github.com/users/sedrick-keh-tri/repos", "events_url": "https://api.github.com/users/sedrick-keh-tri/events{/privacy}", "received_events_url": "https://api.github.com/users/sedrick-keh-tri/received_events", "type": "User", "site_admin": false }

[]

[]

[ "cc @ArthurZucker ", "Hey! THanks for opening an issue. The problem is that you are using `trust_remote_code=True` and thus the `https://huggingface.co/RWKV/v5-Eagle-7B-HF/blob/main/tokenization_rwkv_world.py` file is used. The code is not on transformers yet! \r\n\r\nUse the tokenizer from #29095 should fix this already 🤗 " ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29111/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "amyeroberts", "id": 22614925, "node_id": "MDQ6VXNlcjIyNjE0OTI1", "avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4", "gravatar_id": "", "url": "https://api.github.com/users/amyeroberts", "html_url": "https://github.com/amyeroberts", "followers_url": "https://api.github.com/users/amyeroberts/followers", "following_url": "https://api.github.com/users/amyeroberts/following{/other_user}", "gists_url": "https://api.github.com/users/amyeroberts/gists{/gist_id}", "starred_url": "https://api.github.com/users/amyeroberts/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/amyeroberts/subscriptions", "organizations_url": "https://api.github.com/users/amyeroberts/orgs", "repos_url": "https://api.github.com/users/amyeroberts/repos", "events_url": "https://api.github.com/users/amyeroberts/events{/privacy}", "received_events_url": "https://api.github.com/users/amyeroberts/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29110). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "I also in favor of reverting the original PR #28948 - if that PR is not something urgent to be in `main`. Adding this many of skip is already a heavy burden, then clean it up later is another one.\r\n\r\n(The test fetcher is indeed not ideal, but there is a trade-off and we can decide how to improve it.)\r\n\r\nHowever, I am OK for this PR to be merged if we decide so - the job is already done (the time is spent) anyway.", "@ydshieh @ArthurZucker I agree, let's revert for now. \r\n\r\nThe main reason is I don't trust the testing suite at the moment. @hackyon opened another, more complete PR to address the failing models #29118 which believe were retrieved from explicitly testing `test_save_load_low_cpu_mem_usage` for all models. Importantly, there were more models covered there than this PR addresses - highlighting lack of coverage and failing tests not being run. \r\n\r\nHowever, because we're just about to release, let's err on the side of caution. " ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29110/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29110", "html_url": "https://github.com/huggingface/transformers/pull/29110", "diff_url": "https://github.com/huggingface/transformers/pull/29110.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29110.patch", "merged_at": null }

{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29109). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "I'll have to run the benchmark on the A100 to make sure everything is alright but otherwise should be good ", "Alright, no significant slow downs so 🟢 but I can't do naive Dynamic generation with the same script as before: \r\nProbably because I gave ` position_ids = torch.arange(seq_length, device=device)` and they are not unsqueezed\r\n\r\n```python3\r\n File \"/home/arthur/transformers/../static-kv-cache/clean_bench.py\", line 147, in <module>\r\n outputs = model(input_ids, past_key_values=past_key_values,position_ids=position_ids,cache_position=cache_position, return_dict=False, use_cache = True)\r\n File \"/home/arthur/miniconda3/envs/py310/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1536, in _wrapped_call_impl\r\n return self._call_impl(*args, **kwargs)\r\n File \"/home/arthur/miniconda3/envs/py310/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1545, in _call_impl\r\n return forward_call(*args, **kwargs)\r\n File \"/home/arthur/transformers/src/transformers/models/llama/modeling_llama.py\", line 1155, in forward\r\n outputs = self.model(\r\n File \"/home/arthur/miniconda3/envs/py310/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1536, in _wrapped_call_impl\r\n return self._call_impl(*args, **kwargs)\r\n File \"/home/arthur/miniconda3/envs/py310/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1545, in _call_impl\r\n return forward_call(*args, **kwargs)\r\n File \"/home/arthur/transformers/src/transformers/models/llama/modeling_llama.py\", line 995, in forward\r\n layer_outputs = decoder_layer(\r\n File \"/home/arthur/miniconda3/envs/py310/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1536, in _wrapped_call_impl\r\n return self._call_impl(*args, **kwargs)\r\n File \"/home/arthur/miniconda3/envs/py310/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1545, in _call_impl\r\n return forward_call(*args, **kwargs)\r\n File \"/home/arthur/transformers/src/transformers/models/llama/modeling_llama.py\", line 721, in forward\r\n hidden_states, self_attn_weights, present_key_value = self.self_attn(\r\n File \"/home/arthur/miniconda3/envs/py310/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1536, in _wrapped_call_impl\r\n return self._call_impl(*args, **kwargs)\r\n File \"/home/arthur/miniconda3/envs/py310/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1545, in _call_impl\r\n return forward_call(*args, **kwargs)\r\n File \"/home/arthur/transformers/src/transformers/models/llama/modeling_llama.py\", line 628, in forward\r\n cos, sin = self.rotary_emb(value_states, position_ids, seq_len=None)\r\n File \"/home/arthur/miniconda3/envs/py310/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1536, in _wrapped_call_impl\r\n return self._call_impl(*args, **kwargs)\r\n File \"/home/arthur/miniconda3/envs/py310/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1545, in _call_impl\r\n return forward_call(*args, **kwargs)\r\n File \"/home/arthur/transformers/src/transformers/models/llama/modeling_llama.py\", line 107, in forward\r\n position_ids[:, None, :].float()\r\nIndexError: too many indices for tensor of dimension 1\r\n```", "@ArthurZucker regarding the benchmark error: position ids should be a 2D tensor, just like the input ids :D I also had to adapt it on my end", "Alright if passing a 1d before was erroring out! ", "@gante thanks a lot for this" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29109/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29109", "html_url": "https://github.com/huggingface/transformers/pull/29109", "diff_url": "https://github.com/huggingface/transformers/pull/29109.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29109.patch", "merged_at": 1708424597000 }

{ "login": "hackyon", "id": 1557853, "node_id": "MDQ6VXNlcjE1NTc4NTM=", "avatar_url": "https://avatars.githubusercontent.com/u/1557853?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hackyon", "html_url": "https://github.com/hackyon", "followers_url": "https://api.github.com/users/hackyon/followers", "following_url": "https://api.github.com/users/hackyon/following{/other_user}", "gists_url": "https://api.github.com/users/hackyon/gists{/gist_id}", "starred_url": "https://api.github.com/users/hackyon/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hackyon/subscriptions", "organizations_url": "https://api.github.com/users/hackyon/orgs", "repos_url": "https://api.github.com/users/hackyon/repos", "events_url": "https://api.github.com/users/hackyon/events{/privacy}", "received_events_url": "https://api.github.com/users/hackyon/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hey @gugarosa @ArthurZucker @younesbelkada 👋\r\n\r\nI'm looking for more places to add support for SDPA and figured Phi-2 could be a good one. \r\n\r\nBeen reading up on the issues regarding attention overflow for Phi-2 (#28673, #28488), and I think SPDA would probably be affected by it as well (if it chooses the FA kernels). So, this issue is dependent on #28673.\r\n\r\nI think we should at least issue a warning in SDPA attention if the flash attention is available and dtype == float16 or autocast dtype == float16 (not sure if SDPA will try to autocast to fp16 under the hood). ", "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29108). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Thanks for the review!\r\n\r\nSounds good, marking this for ready. Let me know if/when there's any follow-up work and I'd happy to take a stab at it.", "Yup, all the common model and integration tests pass:\r\n\r\n```\r\nPASSED tests/models/phi/test_modeling_phi.py::PhiModelTest::test_eager_matches_sdpa_generate\r\nPASSED tests/models/phi/test_modeling_phi.py::PhiModelTest::test_eager_matches_sdpa_inference_0_float16\r\nPASSED tests/models/phi/test_modeling_phi.py::PhiModelTest::test_eager_matches_sdpa_inference_1_bfloat16\r\nPASSED tests/models/phi/test_modeling_phi.py::PhiModelTest::test_eager_matches_sdpa_inference_2_float32\r\n...\r\nPASSED tests/models/phi/test_modeling_phi.py::PhiIntegrationTest::test_model_phi_1_5_logits\r\nPASSED tests/models/phi/test_modeling_phi.py::PhiIntegrationTest::test_model_phi_1_logits\r\nPASSED tests/models/phi/test_modeling_phi.py::PhiIntegrationTest::test_model_phi_2_logits\r\nPASSED tests/models/phi/test_modeling_phi.py::PhiIntegrationTest::test_phi_2_generation\r\n```", "Just ran `RUN_SLOW=1 pytest tests/models/phi`:\r\n```python \r\n_______________________________________________ PhiModelTest.test_eager_matches_sdpa_inference_1_bfloat16 ________________________________________________\r\n\r\na = (<tests.models.phi.test_modeling_phi.PhiModelTest testMethod=test_eager_matches_sdpa_inference_1_bfloat16>,), kw = {}\r\n\r\n @wraps(func)\r\n def standalone_func(*a, **kw):\r\n> return func(*(a + p.args), **p.kwargs, **kw)\r\n\r\n../miniconda3/envs/py39/lib/python3.9/site-packages/parameterized/parameterized.py:620: \r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ \r\ntests/test_modeling_common.py:3698: in test_eager_matches_sdpa_inference\r\n self.assertTrue(len(fail_cases) == 0, \"\\n\".join(fail_cases))\r\nE AssertionError: False is not true : padding_side=left, use_mask=False, batch_size=5, enable_kernels=True: mean relative difference: 1.154e-02, torch atol = 0.01, torch rtol = 0.03\r\nE padding_side=left, use_mask=True, batch_size=5, enable_kernels=True: mean relative difference: 1.129e-02, torch atol = 0.01, torch rtol = 0.03\r\nE padding_side=right, use_mask=False, batch_size=5, enable_kernels=True: mean relative difference: 1.154e-02, torch atol = 0.01, torch rtol = 0.03\r\nE padding_side=right, use_mask=True, batch_size=5, enable_kernels=True: mean relative difference: 1.129e-02, torch atol = 0.01, torch rtol = 0.03\r\n````\r\nI think it is acceptable", "Thanks @hackyon 😉 ", "Thanks!\r\n\r\nI just ran the PhiModelTest again on my server again and it still passes, so it seems like a config issue :/ I'm running these tests/benchmarks on Paperspace ml-in-a-box instance with A100 GPUs. \r\n\r\nLet me know if you have recommendations on any better setup/config to use.", "No worries might be flaky as well 1e-2 is alright I think I have torch nightly as well " ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29108/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29108", "html_url": "https://github.com/huggingface/transformers/pull/29108", "diff_url": "https://github.com/huggingface/transformers/pull/29108.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29108.patch", "merged_at": 1708435992000 }

{ "login": "nikhilajoshy", "id": 37141775, "node_id": "MDQ6VXNlcjM3MTQxNzc1", "avatar_url": "https://avatars.githubusercontent.com/u/37141775?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nikhilajoshy", "html_url": "https://github.com/nikhilajoshy", "followers_url": "https://api.github.com/users/nikhilajoshy/followers", "following_url": "https://api.github.com/users/nikhilajoshy/following{/other_user}", "gists_url": "https://api.github.com/users/nikhilajoshy/gists{/gist_id}", "starred_url": "https://api.github.com/users/nikhilajoshy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nikhilajoshy/subscriptions", "organizations_url": "https://api.github.com/users/nikhilajoshy/orgs", "repos_url": "https://api.github.com/users/nikhilajoshy/repos", "events_url": "https://api.github.com/users/nikhilajoshy/events{/privacy}", "received_events_url": "https://api.github.com/users/nikhilajoshy/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @nikhilajoshy, thanks for raising an issue! \r\n\r\nThis is a question best placed in our [forums](https://discuss.huggingface.co/). We try to reserve the github issues for feature requests and bug reports." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29107/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "eaidova", "id": 29454499, "node_id": "MDQ6VXNlcjI5NDU0NDk5", "avatar_url": "https://avatars.githubusercontent.com/u/29454499?v=4", "gravatar_id": "", "url": "https://api.github.com/users/eaidova", "html_url": "https://github.com/eaidova", "followers_url": "https://api.github.com/users/eaidova/followers", "following_url": "https://api.github.com/users/eaidova/following{/other_user}", "gists_url": "https://api.github.com/users/eaidova/gists{/gist_id}", "starred_url": "https://api.github.com/users/eaidova/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/eaidova/subscriptions", "organizations_url": "https://api.github.com/users/eaidova/orgs", "repos_url": "https://api.github.com/users/eaidova/repos", "events_url": "https://api.github.com/users/eaidova/events{/privacy}", "received_events_url": "https://api.github.com/users/eaidova/received_events", "type": "User", "site_admin": false }

[]

[]

[ "cc @fxmarty ", "> Looks alright but we need to add an integration test iMO :)\r\n\r\nadded", "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29106). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29106/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29106", "html_url": "https://github.com/huggingface/transformers/pull/29106", "diff_url": "https://github.com/huggingface/transformers/pull/29106.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29106.patch", "merged_at": null }

{ "login": "LysandreJik", "id": 30755778, "node_id": "MDQ6VXNlcjMwNzU1Nzc4", "avatar_url": "https://avatars.githubusercontent.com/u/30755778?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LysandreJik", "html_url": "https://github.com/LysandreJik", "followers_url": "https://api.github.com/users/LysandreJik/followers", "following_url": "https://api.github.com/users/LysandreJik/following{/other_user}", "gists_url": "https://api.github.com/users/LysandreJik/gists{/gist_id}", "starred_url": "https://api.github.com/users/LysandreJik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LysandreJik/subscriptions", "organizations_url": "https://api.github.com/users/LysandreJik/orgs", "repos_url": "https://api.github.com/users/LysandreJik/repos", "events_url": "https://api.github.com/users/LysandreJik/events{/privacy}", "received_events_url": "https://api.github.com/users/LysandreJik/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29105). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29105/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29105", "html_url": "https://github.com/huggingface/transformers/pull/29105", "diff_url": "https://github.com/huggingface/transformers/pull/29105.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29105.patch", "merged_at": 1708345405000 }

{ "login": "gisturiz", "id": 48292332, "node_id": "MDQ6VXNlcjQ4MjkyMzMy", "avatar_url": "https://avatars.githubusercontent.com/u/48292332?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gisturiz", "html_url": "https://github.com/gisturiz", "followers_url": "https://api.github.com/users/gisturiz/followers", "following_url": "https://api.github.com/users/gisturiz/following{/other_user}", "gists_url": "https://api.github.com/users/gisturiz/gists{/gist_id}", "starred_url": "https://api.github.com/users/gisturiz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gisturiz/subscriptions", "organizations_url": "https://api.github.com/users/gisturiz/orgs", "repos_url": "https://api.github.com/users/gisturiz/repos", "events_url": "https://api.github.com/users/gisturiz/events{/privacy}", "received_events_url": "https://api.github.com/users/gisturiz/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29104). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29104/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29104", "html_url": "https://github.com/huggingface/transformers/pull/29104", "diff_url": "https://github.com/huggingface/transformers/pull/29104.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29104.patch", "merged_at": 1708449195000 }

{ "login": "LinWeizheDragon", "id": 33350454, "node_id": "MDQ6VXNlcjMzMzUwNDU0", "avatar_url": "https://avatars.githubusercontent.com/u/33350454?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LinWeizheDragon", "html_url": "https://github.com/LinWeizheDragon", "followers_url": "https://api.github.com/users/LinWeizheDragon/followers", "following_url": "https://api.github.com/users/LinWeizheDragon/following{/other_user}", "gists_url": "https://api.github.com/users/LinWeizheDragon/gists{/gist_id}", "starred_url": "https://api.github.com/users/LinWeizheDragon/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LinWeizheDragon/subscriptions", "organizations_url": "https://api.github.com/users/LinWeizheDragon/orgs", "repos_url": "https://api.github.com/users/LinWeizheDragon/repos", "events_url": "https://api.github.com/users/LinWeizheDragon/events{/privacy}", "received_events_url": "https://api.github.com/users/LinWeizheDragon/received_events", "type": "User", "site_admin": false }

[ { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29103/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "sadra-barikbin", "id": 22097587, "node_id": "MDQ6VXNlcjIyMDk3NTg3", "avatar_url": "https://avatars.githubusercontent.com/u/22097587?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sadra-barikbin", "html_url": "https://github.com/sadra-barikbin", "followers_url": "https://api.github.com/users/sadra-barikbin/followers", "following_url": "https://api.github.com/users/sadra-barikbin/following{/other_user}", "gists_url": "https://api.github.com/users/sadra-barikbin/gists{/gist_id}", "starred_url": "https://api.github.com/users/sadra-barikbin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sadra-barikbin/subscriptions", "organizations_url": "https://api.github.com/users/sadra-barikbin/orgs", "repos_url": "https://api.github.com/users/sadra-barikbin/repos", "events_url": "https://api.github.com/users/sadra-barikbin/events{/privacy}", "received_events_url": "https://api.github.com/users/sadra-barikbin/received_events", "type": "User", "site_admin": false }

[]

[]

[ "One more thing. We have `False` for default value of `clean_up_tokenization_spaces` argument in `TextGenerationPipeline`'s docstring:\r\nhttps://github.com/huggingface/transformers/blob/593230f0a1150ea9c0477b9d859f25daf73c8c33/src/transformers/pipelines/text_generation.py#L207-L208\r\n\r\nbut its default value in `TextGenerationPipeline::postprocess` is `True`:\r\nhttps://github.com/huggingface/transformers/blob/593230f0a1150ea9c0477b9d859f25daf73c8c33/src/transformers/pipelines/text_generation.py#L336", "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29102). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "@sadra-barikbin Good spot! Could you add a fix for the docstring in this PR too?", "The pipelines in `text2text_generation.py` class have `clean_up_tokenization_spaces=False` as default. This has been the desired behavior?", "@sadra-barikbin Yes, I believe so. Changing the default behaviour would be a breaking change, so we should keep as-is" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29102/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29102", "html_url": "https://github.com/huggingface/transformers/pull/29102", "diff_url": "https://github.com/huggingface/transformers/pull/29102.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29102.patch", "merged_at": 1708368629000 }

{ "login": "BlackSamorez", "id": 16901341, "node_id": "MDQ6VXNlcjE2OTAxMzQx", "avatar_url": "https://avatars.githubusercontent.com/u/16901341?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BlackSamorez", "html_url": "https://github.com/BlackSamorez", "followers_url": "https://api.github.com/users/BlackSamorez/followers", "following_url": "https://api.github.com/users/BlackSamorez/following{/other_user}", "gists_url": "https://api.github.com/users/BlackSamorez/gists{/gist_id}", "starred_url": "https://api.github.com/users/BlackSamorez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BlackSamorez/subscriptions", "organizations_url": "https://api.github.com/users/BlackSamorez/orgs", "repos_url": "https://api.github.com/users/BlackSamorez/repos", "events_url": "https://api.github.com/users/BlackSamorez/events{/privacy}", "received_events_url": "https://api.github.com/users/BlackSamorez/received_events", "type": "User", "site_admin": false }

[]

[]

[ "cc @Rocketknight1 ", "Hi @BlackSamorez, this issue has been reported already at #28919. We're working on a fix right now! I'm going to close this issue as a duplicate." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29101/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "KaifAhmad1", "id": 98801504, "node_id": "U_kgDOBeOXYA", "avatar_url": "https://avatars.githubusercontent.com/u/98801504?v=4", "gravatar_id": "", "url": "https://api.github.com/users/KaifAhmad1", "html_url": "https://github.com/KaifAhmad1", "followers_url": "https://api.github.com/users/KaifAhmad1/followers", "following_url": "https://api.github.com/users/KaifAhmad1/following{/other_user}", "gists_url": "https://api.github.com/users/KaifAhmad1/gists{/gist_id}", "starred_url": "https://api.github.com/users/KaifAhmad1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KaifAhmad1/subscriptions", "organizations_url": "https://api.github.com/users/KaifAhmad1/orgs", "repos_url": "https://api.github.com/users/KaifAhmad1/repos", "events_url": "https://api.github.com/users/KaifAhmad1/events{/privacy}", "received_events_url": "https://api.github.com/users/KaifAhmad1/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @KaifAhmad1, thanks for opening an issue! \r\n\r\nPlease make sure to provide a minimal code reproducer and information about the bug encountered, including the full error traceback when reporting an issue.\r\n\r\nIf the error is coming from `bitsandbytes` there isn't anything the transformers team can do. ", "Hey, @amyeroberts \r\nI have tagged this issue with bitsandbytes maintainers according to transformers documentation \r\n@SunMarc @younesbelkada \r\n\r\nbitsandbytes = 0.42.0\r\npip = 24.0\r\npython = 3.10.10\r\ncuda = 12.1\r\nOS = windows 11 x64 \r\n\r\n\r\n``` Python \r\nimport torch\r\nfrom torch import cuda, bfloat16\r\nimport transformers\r\nmodel_id = 'microsoft/phi-2'\r\ndevice = f'cuda:{cuda.current_device()}' if cuda.is_available() else 'cpu'\r\n\r\n# begin initializing HF items, you need an access token\r\nmodel_config = transformers.AutoConfig.from_pretrained(\r\n model_id,\r\n use_auth_token=hf_auth,\r\n trust_remote_code=True\r\n)\r\n\r\n# BnB Configuration\r\nbnb_config = transformers.BitsAndBytesConfig(\r\n load_in_4bit=True,\r\n bnb_4bit_quant_type='nf4',\r\n bnb_4bit_use_double_quant=True,\r\n bnb_4bit_compute_dtype=bfloat16\r\n)\r\n\r\nmodel = transformers.AutoModelForCausalLM.from_pretrained(\r\n model_id,\r\n trust_remote_code=True,\r\n config=model_config,\r\n device_map='auto',\r\n use_auth_token=hf_auth,\r\n quantization_config=bnb_config,\r\n low_cpu_mem_usage=True\r\n)\r\n\r\n# How model looks like:\r\nmodel.eval()\r\n\r\n\r\nfrom langchain.chains import GraphCypherQAChain\r\nfrom langchain.graphs import Neo4jGraph\r\n \r\n\r\nfrom langchain.chains.base import Chain\r\nfrom langchain.chains.llm import LLMChain\r\nfrom langchain.chat_models import ChatOpenAI\r\nfrom langchain.chains.question_answering.stuff_prompt import CHAT_PROMPT\r\nfrom langchain.callbacks.manager import CallbackManagerForChainRun\r\nfrom typing import Any, Dict, List\r\nfrom pydantic import Field\r\n\r\n\r\n\r\nvector_search = \"\"\"\r\nWITH \r\nk, e) yield node, score\r\nRETURN node.text AS result\r\nORDER BY score DESC\r\nLIMIT 3\r\n\"\"\"\r\n\r\nprint(graph.schema)\r\n\r\nclass Neo4jVectorChain(Chain):\r\n graph: Neo4jGraph = Field(exclude=True)\r\n input_key: str = \"query\"\r\n output_key: str = \"result\"\r\n embeddings: HuggingFaceBgeEmbeddings = HuggingFaceBgeEmbeddings()\r\n qa_chain: LLMChain = LLMChain(llm=llm, prompt=CHAT_PROMPT)\r\n\r\n @property\r\n def input_keys(self) -> List[str]:\r\n return [self.input_key]\r\n\r\n @property\r\n def output_keys(self) -> List[str]:\r\n _output_keys = [self.output_key]\r\n return _output_keys\r\n\r\n def _call(self, inputs: Dict[str, str], run_manager, k=3) -> Dict[str, Any]:\r\n question = inputs[self.input_key]\r\n embedding = self.embeddings.embed_query(question)\r\n\r\n context = self.graph.query(vector_search, {'embedding': embedding, 'k': 3})\r\n context = [el['result'] for el in context]\r\n\r\n result = self.qa_chain({\"question\": question, \"context\": context})\r\n final_result = result[self.qa_chain.output_key]\r\n return {self.output_key: final_result}\r\n\r\nchain = Neo4jVectorChain(graph=graph, embeddings=embeddings, verbose=True)\r\n\r\ngraph_result = chain.run(\"How can we enhance the specificity and efficiency of CRISPR/Cas9 gene-editing technology to minimize off-target effects and increase its potential for therapeutic applications?\")\r\n\r\n\r\n\r\n```\r\n\r\n```\r\n> Entering new Neo4jVectorChain chain...\r\n/usr/local/lib/python3.10/dist-packages/langchain_core/_api/deprecation.py:117: LangChainDeprecationWarning: The function `__call__` was deprecated in LangChain 0.1.0 and will be removed in 0.2.0. Use invoke instead.\r\n warn_deprecated(\r\n/usr/local/lib/python3.10/dist-packages/transformers/generation/configuration_utils.py:392: UserWarning: `do_sample` is set to `False`. However, `temperature` is set to `0.3` -- this flag is only used in sample-based generation modes. You should set `do_sample=True` or unset `temperature`.\r\n warnings.warn(\r\nSetting `pad_token_id` to `eos_token_id`:50256 for open-end generation.\r\nFP4 quantization state not initialized. Please call .cuda() or .to(device) on the LinearFP4 layer first.\r\n---------------------------------------------------------------------------\r\nAssertionError Traceback (most recent call last)\r\n[<ipython-input-42-4ff3ab735a16>](https://localhost:8080/#) in <cell line: 1>()\r\n----> 1 graph_result = chain.run(\"How can we enhance the specificity and efficiency of CRISPR/Cas9 gene-editing technology to minimize off-target effects and increase its potential for therapeutic applications?\")\r\n\r\n49 frames\r\n[/usr/local/lib/python3.10/dist-packages/bitsandbytes/autograd/_functions.py](https://localhost:8080/#) in matmul_4bit(A, B, quant_state, out, bias)\r\n 564 \r\n 565 def matmul_4bit(A: tensor, B: tensor, quant_state: F.QuantState, out: tensor = None, bias=None):\r\n--> 566 assert quant_state is not None\r\n 567 if A.numel() == A.shape[-1] and A.requires_grad == False:\r\n 568 if A.shape[-1] % quant_state.blocksize != 0:\r\n\r\nAssertionError:\r\n```", "Hi @KaifAhmad1 \r\nThanks very much for the issue ! \r\nYou are using the trust_remote_code model that we don't maintain, can you try out phi-2 without `trust_remote_code` ? I think 4bit should work out of the box with the non-trust_remote_code model" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29100/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "YouliangHUANG", "id": 56789071, "node_id": "MDQ6VXNlcjU2Nzg5MDcx", "avatar_url": "https://avatars.githubusercontent.com/u/56789071?v=4", "gravatar_id": "", "url": "https://api.github.com/users/YouliangHUANG", "html_url": "https://github.com/YouliangHUANG", "followers_url": "https://api.github.com/users/YouliangHUANG/followers", "following_url": "https://api.github.com/users/YouliangHUANG/following{/other_user}", "gists_url": "https://api.github.com/users/YouliangHUANG/gists{/gist_id}", "starred_url": "https://api.github.com/users/YouliangHUANG/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/YouliangHUANG/subscriptions", "organizations_url": "https://api.github.com/users/YouliangHUANG/orgs", "repos_url": "https://api.github.com/users/YouliangHUANG/repos", "events_url": "https://api.github.com/users/YouliangHUANG/events{/privacy}", "received_events_url": "https://api.github.com/users/YouliangHUANG/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29099/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29099", "html_url": "https://github.com/huggingface/transformers/pull/29099", "diff_url": "https://github.com/huggingface/transformers/pull/29099.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29099.patch", "merged_at": null }

{ "login": "lucasjinreal", "id": 21303438, "node_id": "MDQ6VXNlcjIxMzAzNDM4", "avatar_url": "https://avatars.githubusercontent.com/u/21303438?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lucasjinreal", "html_url": "https://github.com/lucasjinreal", "followers_url": "https://api.github.com/users/lucasjinreal/followers", "following_url": "https://api.github.com/users/lucasjinreal/following{/other_user}", "gists_url": "https://api.github.com/users/lucasjinreal/gists{/gist_id}", "starred_url": "https://api.github.com/users/lucasjinreal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lucasjinreal/subscriptions", "organizations_url": "https://api.github.com/users/lucasjinreal/orgs", "repos_url": "https://api.github.com/users/lucasjinreal/repos", "events_url": "https://api.github.com/users/lucasjinreal/events{/privacy}", "received_events_url": "https://api.github.com/users/lucasjinreal/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @lucasjinreal, thanks for opening an issue! \r\n\r\nPlease make sure to follow the [issue template](https://github.com/huggingface/transformers/blob/main/.github/ISSUE_TEMPLATE/bug-report.yml) and provide: \r\n* A minimal code reproducer\r\n* All relevant error information including the full error traceback\r\n* The running environment: run `transformers-cli env` in the terminal and copy-paste the output\r\n\r\n" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29098/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29097). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "We still have failing for `test_save_load_low_cpu_mem_usage` which are already on `main`.\r\n\r\nOn this PR, the accelerate is `0.27.2` and on `main`, the CI uses `accelerate` main. So I don't think the change of this PR (on the `accelerate` part address the issue)\r\n\r\n@amyeroberts mentions she has already some work on solving `test_save_load_low_cpu_mem_usage` .\r\n\r\n@ArthurZucker mentions he don't want to use `accelerate main` on our CI.\r\n\r\nSo let's keep this PR as it is despite there is `test_save_load_low_cpu_mem_usage` failing, if @amyeroberts agrees.\r\n\r\ncc @muellerzr ", "p.s. `test_beam_search_low_memory` also happens for which I don't see on `main` CI.", "@ydshieh Do we know the original reasons for using accelerate main rather than the stable release in the CI? ", "@ydshieh Just to confirm - changing the accelerate version here would mean that `test_save_load_low_cpu_mem_usage` starts to fail despite the fixes on `main`. Or that there's still failures on `main`? ", "@amyeroberts I didn't know the fix of `test_save_load_low_cpu_mem_usage ` is already on `main`.\r\n\r\nHowever, that fix is merged 4 days ago, right? But last night's run \r\n\r\nhttps://app.circleci.com/pipelines/github/huggingface/transformers/84737/workflows/c2fc5312-c0bf-4620-b523-74c1a99b0d1b/jobs/1096153/tests\r\n\r\nhaving those failures.\r\n\r\nSo it's not this PR introducing this again. (i.e. those failures are still on `main` after the fix).\r\n\r\n\r\n", "I propose to revert the changes regarding accelerate in this PR (as it didn't fix the issue).\r\n\r\nIf eventually everyone agrees with @ArthurZucker, we can open another PR to use `released accelerate` for CI - but this is not the scope of this PR (and I don't want to mix the 2 different stuff in a single PR).", "@ydshieh OK, what I suggest for the moment is skipping all the models where this fails at the moment. \r\n\r\nSeparate from this PR, I think there's a issue with our test fetcher. There's been quite a few PRs recently where the whole CI has been green and then after merging into main, another PR which touches related (but different) code suddenly starts to have CI failures. These tests are one example. Two other cases would be: \r\n* Failures coming from the static cache PR\r\n* Failures in coming from [processing fix for detr](https://github.com/huggingface/transformers/issues/28530) which later triggered [errors in a different PR](https://github.com/huggingface/transformers/pull/28312).", "> If eventually everyone agrees with @ArthurZucker, we can open another PR to use released accelerate for CI - but this is not the scope of this PR (and I don't want to mix the 2 different stuff in a single PR).\r\n\r\nI'm pro splitting and pro having stable accelerate for PR's CI and `main` accelerate on a nightly run", "Will take a look over the test fetcher. But remember that test fetcher have some design decision (by great @sgugger ) to balance the coverage as well as the speed of CI, so the situation described is not surprising (at least to me since I faced it a few times already and some fix were already done).\r\n\r\n(One related PR but not exact is #28816)", "Regarding skipping all the models where this fails at the moment, I will leave it to anyone that is so motivated to beat me, otherwise I can do it in about 9 hours.\r\n\r\nFor now, I will just wait the CI of this PR and merge it.", "Thanks both 🤗 " ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29097/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 1, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29097", "html_url": "https://github.com/huggingface/transformers/pull/29097", "diff_url": "https://github.com/huggingface/transformers/pull/29097.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29097.patch", "merged_at": 1708351724000 }

{ "login": "seanswyi", "id": 20367759, "node_id": "MDQ6VXNlcjIwMzY3NzU5", "avatar_url": "https://avatars.githubusercontent.com/u/20367759?v=4", "gravatar_id": "", "url": "https://api.github.com/users/seanswyi", "html_url": "https://github.com/seanswyi", "followers_url": "https://api.github.com/users/seanswyi/followers", "following_url": "https://api.github.com/users/seanswyi/following{/other_user}", "gists_url": "https://api.github.com/users/seanswyi/gists{/gist_id}", "starred_url": "https://api.github.com/users/seanswyi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/seanswyi/subscriptions", "organizations_url": "https://api.github.com/users/seanswyi/orgs", "repos_url": "https://api.github.com/users/seanswyi/repos", "events_url": "https://api.github.com/users/seanswyi/events{/privacy}", "received_events_url": "https://api.github.com/users/seanswyi/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@seanswyi For the failing tests, these are unrelated and a known issue happening on our CI. We're currently working on a fix for it and will let you know asap once it's merged and you can rebase to get the CI green", "@amyeroberts No worries, thanks for the heads up!", "@seanswyi The failing tests should now be resolved. Could you try rebasing on `main`? ", "@amyeroberts Just checked that the test pass. Thanks again for the heads up!", "@seanswyi I think something funny has happened with the history in this PR - the diff is now showing changes coming from other unrelated commits, which are also now in the commit history. Did you force push after rebasing? This is necessary as rebasing is effectively rewriting the history", "@amyeroberts Ah, you're right. And no, I don't believe I did a force push, just a regular push. I'll rebase and fix this now." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29096/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29096", "html_url": "https://github.com/huggingface/transformers/pull/29096", "diff_url": "https://github.com/huggingface/transformers/pull/29096.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29096.patch", "merged_at": null }

{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29095). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Not sure if this is the appropriate place to post this, but I've been running into some issues when using the tokenizer `AutoTokenizer.from_pretrained(\"RWKV/v5-Eagle-7B-HF\")` and I was told to forward my message here. Wondering if this is a feature or a bug? \r\n\r\nOriginal issue https://github.com/BlinkDL/RWKV-LM/issues/224\r\n", "😅 could you open a seperate issue and ping me there?! 🤗 ", "Gotcha, starting a separate issue makes sense. Thanks! https://github.com/huggingface/transformers/issues/29111" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29095/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29095", "html_url": "https://github.com/huggingface/transformers/pull/29095", "diff_url": "https://github.com/huggingface/transformers/pull/29095.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29095.patch", "merged_at": null }

{ "login": "TXacs", "id": 60869411, "node_id": "MDQ6VXNlcjYwODY5NDEx", "avatar_url": "https://avatars.githubusercontent.com/u/60869411?v=4", "gravatar_id": "", "url": "https://api.github.com/users/TXacs", "html_url": "https://github.com/TXacs", "followers_url": "https://api.github.com/users/TXacs/followers", "following_url": "https://api.github.com/users/TXacs/following{/other_user}", "gists_url": "https://api.github.com/users/TXacs/gists{/gist_id}", "starred_url": "https://api.github.com/users/TXacs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TXacs/subscriptions", "organizations_url": "https://api.github.com/users/TXacs/orgs", "repos_url": "https://api.github.com/users/TXacs/repos", "events_url": "https://api.github.com/users/TXacs/events{/privacy}", "received_events_url": "https://api.github.com/users/TXacs/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @TXacs, thanks for raising this issue! \r\n\r\nYou need to pass in `input_names` to `symbolic_trace`:\r\n\r\n```py\r\nfrom config import load_config\r\n\r\nfrom transformers import (\r\n AltCLIPModel,\r\n AltCLIPConfig,\r\n)\r\nfrom transformers.utils.fx import symbolic_trace\r\n\r\ndef main():\r\n config_kwarg = load_config(\"altclip\")\r\n config = AltCLIPConfig(\r\n **config_kwarg\r\n )\r\n\r\n # create model\r\n model = AltCLIPModel(config)\r\n\r\n traced_model = symbolic_trace(model, ['input_ids', 'pixel_values'])\r\n\r\nif __name__ == \"__main__\":\r\n main()\r\n```", "> Hi @TXacs, thanks for raising this issue!\r\n> \r\n> You need to pass in `input_names` to `symbolic_trace`:\r\n> \r\n> ```python\r\n> from config import load_config\r\n> \r\n> from transformers import (\r\n> AltCLIPModel,\r\n> AltCLIPConfig,\r\n> )\r\n> from transformers.utils.fx import symbolic_trace\r\n> \r\n> def main():\r\n> config_kwarg = load_config(\"altclip\")\r\n> config = AltCLIPConfig(\r\n> **config_kwarg\r\n> )\r\n> \r\n> # create model\r\n> model = AltCLIPModel(config)\r\n> \r\n> traced_model = symbolic_trace(model, ['input_ids', 'pixel_values'])\r\n> \r\n> if __name__ == \"__main__\":\r\n> main()\r\n> ```\r\n\r\nThanks a lot! It solved." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29094/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "dipta007", "id": 13894030, "node_id": "MDQ6VXNlcjEzODk0MDMw", "avatar_url": "https://avatars.githubusercontent.com/u/13894030?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dipta007", "html_url": "https://github.com/dipta007", "followers_url": "https://api.github.com/users/dipta007/followers", "following_url": "https://api.github.com/users/dipta007/following{/other_user}", "gists_url": "https://api.github.com/users/dipta007/gists{/gist_id}", "starred_url": "https://api.github.com/users/dipta007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dipta007/subscriptions", "organizations_url": "https://api.github.com/users/dipta007/orgs", "repos_url": "https://api.github.com/users/dipta007/repos", "events_url": "https://api.github.com/users/dipta007/events{/privacy}", "received_events_url": "https://api.github.com/users/dipta007/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@dipta007 ,hi! This [PR](https://github.com/huggingface/transformers/pull/28994) fixed it", "@dipta007 as @zucchini-nlp wrote, if you add `!pip install --upgrade git+https://github.com/huggingface/transformers.git` on top of your notebook it will work 🤗 ", "Thanks" ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29093/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "younesbelkada", "id": 49240599, "node_id": "MDQ6VXNlcjQ5MjQwNTk5", "avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4", "gravatar_id": "", "url": "https://api.github.com/users/younesbelkada", "html_url": "https://github.com/younesbelkada", "followers_url": "https://api.github.com/users/younesbelkada/followers", "following_url": "https://api.github.com/users/younesbelkada/following{/other_user}", "gists_url": "https://api.github.com/users/younesbelkada/gists{/gist_id}", "starred_url": "https://api.github.com/users/younesbelkada/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/younesbelkada/subscriptions", "organizations_url": "https://api.github.com/users/younesbelkada/orgs", "repos_url": "https://api.github.com/users/younesbelkada/repos", "events_url": "https://api.github.com/users/younesbelkada/events{/privacy}", "received_events_url": "https://api.github.com/users/younesbelkada/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29092). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29092/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29092", "html_url": "https://github.com/huggingface/transformers/pull/29092", "diff_url": "https://github.com/huggingface/transformers/pull/29092.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29092.patch", "merged_at": 1708335552000 }

{ "login": "davies-w", "id": 6550854, "node_id": "MDQ6VXNlcjY1NTA4NTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/6550854?v=4", "gravatar_id": "", "url": "https://api.github.com/users/davies-w", "html_url": "https://github.com/davies-w", "followers_url": "https://api.github.com/users/davies-w/followers", "following_url": "https://api.github.com/users/davies-w/following{/other_user}", "gists_url": "https://api.github.com/users/davies-w/gists{/gist_id}", "starred_url": "https://api.github.com/users/davies-w/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/davies-w/subscriptions", "organizations_url": "https://api.github.com/users/davies-w/orgs", "repos_url": "https://api.github.com/users/davies-w/repos", "events_url": "https://api.github.com/users/davies-w/events{/privacy}", "received_events_url": "https://api.github.com/users/davies-w/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29091). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29091/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29091", "html_url": "https://github.com/huggingface/transformers/pull/29091", "diff_url": "https://github.com/huggingface/transformers/pull/29091.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29091.patch", "merged_at": 1708337758000 }

{ "login": "hackyon", "id": 1557853, "node_id": "MDQ6VXNlcjE1NTc4NTM=", "avatar_url": "https://avatars.githubusercontent.com/u/1557853?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hackyon", "html_url": "https://github.com/hackyon", "followers_url": "https://api.github.com/users/hackyon/followers", "following_url": "https://api.github.com/users/hackyon/following{/other_user}", "gists_url": "https://api.github.com/users/hackyon/gists{/gist_id}", "starred_url": "https://api.github.com/users/hackyon/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hackyon/subscriptions", "organizations_url": "https://api.github.com/users/hackyon/orgs", "repos_url": "https://api.github.com/users/hackyon/repos", "events_url": "https://api.github.com/users/hackyon/events{/privacy}", "received_events_url": "https://api.github.com/users/hackyon/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29090/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29090", "html_url": "https://github.com/huggingface/transformers/pull/29090", "diff_url": "https://github.com/huggingface/transformers/pull/29090.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29090.patch", "merged_at": null }

{ "login": "jakubhejhal", "id": 97042178, "node_id": "U_kgDOBci_Ag", "avatar_url": "https://avatars.githubusercontent.com/u/97042178?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jakubhejhal", "html_url": "https://github.com/jakubhejhal", "followers_url": "https://api.github.com/users/jakubhejhal/followers", "following_url": "https://api.github.com/users/jakubhejhal/following{/other_user}", "gists_url": "https://api.github.com/users/jakubhejhal/gists{/gist_id}", "starred_url": "https://api.github.com/users/jakubhejhal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jakubhejhal/subscriptions", "organizations_url": "https://api.github.com/users/jakubhejhal/orgs", "repos_url": "https://api.github.com/users/jakubhejhal/repos", "events_url": "https://api.github.com/users/jakubhejhal/events{/privacy}", "received_events_url": "https://api.github.com/users/jakubhejhal/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi, thanks for raising an issue! \r\n\r\nThis is a question best placed in our [forums](https://discuss.huggingface.co/). We try to reserve the github issues for feature requests and bug reports." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29089/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Whenning42", "id": 8920171, "node_id": "MDQ6VXNlcjg5MjAxNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/8920171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Whenning42", "html_url": "https://github.com/Whenning42", "followers_url": "https://api.github.com/users/Whenning42/followers", "following_url": "https://api.github.com/users/Whenning42/following{/other_user}", "gists_url": "https://api.github.com/users/Whenning42/gists{/gist_id}", "starred_url": "https://api.github.com/users/Whenning42/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Whenning42/subscriptions", "organizations_url": "https://api.github.com/users/Whenning42/orgs", "repos_url": "https://api.github.com/users/Whenning42/repos", "events_url": "https://api.github.com/users/Whenning42/events{/privacy}", "received_events_url": "https://api.github.com/users/Whenning42/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @Whenning42, thanks for opening this PR! \r\n\r\nCould you share what the effect is of removing the `real_checkpoint` argument? Does the disclaimer disappear? " ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29088/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29088", "html_url": "https://github.com/huggingface/transformers/pull/29088", "diff_url": "https://github.com/huggingface/transformers/pull/29088.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29088.patch", "merged_at": null }

{ "login": "LeonardoEmili", "id": 36575651, "node_id": "MDQ6VXNlcjM2NTc1NjUx", "avatar_url": "https://avatars.githubusercontent.com/u/36575651?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LeonardoEmili", "html_url": "https://github.com/LeonardoEmili", "followers_url": "https://api.github.com/users/LeonardoEmili/followers", "following_url": "https://api.github.com/users/LeonardoEmili/following{/other_user}", "gists_url": "https://api.github.com/users/LeonardoEmili/gists{/gist_id}", "starred_url": "https://api.github.com/users/LeonardoEmili/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LeonardoEmili/subscriptions", "organizations_url": "https://api.github.com/users/LeonardoEmili/orgs", "repos_url": "https://api.github.com/users/LeonardoEmili/repos", "events_url": "https://api.github.com/users/LeonardoEmili/events{/privacy}", "received_events_url": "https://api.github.com/users/LeonardoEmili/received_events", "type": "User", "site_admin": false }

[]

[]

[ "When running inference you should set `model .config.output_router_logits=False`", "Thanks @ArthurZucker, I believe it is a bit hard to spot the correct behaviour from the [docs](https://huggingface.co/docs/transformers/main/model_doc/mixtral#transformers.MixtralModel.forward.output_router_logits) so I was wondering if it is always the case that inference requires turning off the config and if so maybe it should be enforced when `model.eval()` is called?", "Actually this should be enforced when call `prepare_inputs_for_generation`! Would you like to open a PR for mixtral ? ", "Sounds good, I'll happily take care of it @ArthurZucker.\r\n\r\nJust to make sure do you think it's better raising an assertion when mixtral is used in inference with that configuration or rather raising a warning and ignoring it (even if the user set it to True)? I believe at that stage the first option should be preferred and the second scenario should be handled earlier (maybe when setting the model in inference mode?).", "No I think we should always set it, this is the expected api for `output_attention` for example. 🤗 " ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29087/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "AI4Harmony", "id": 160417616, "node_id": "U_kgDOCY_HUA", "avatar_url": "https://avatars.githubusercontent.com/u/160417616?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AI4Harmony", "html_url": "https://github.com/AI4Harmony", "followers_url": "https://api.github.com/users/AI4Harmony/followers", "following_url": "https://api.github.com/users/AI4Harmony/following{/other_user}", "gists_url": "https://api.github.com/users/AI4Harmony/gists{/gist_id}", "starred_url": "https://api.github.com/users/AI4Harmony/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AI4Harmony/subscriptions", "organizations_url": "https://api.github.com/users/AI4Harmony/orgs", "repos_url": "https://api.github.com/users/AI4Harmony/repos", "events_url": "https://api.github.com/users/AI4Harmony/events{/privacy}", "received_events_url": "https://api.github.com/users/AI4Harmony/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29086). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29086/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29086", "html_url": "https://github.com/huggingface/transformers/pull/29086", "diff_url": "https://github.com/huggingface/transformers/pull/29086.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29086.patch", "merged_at": null }

{ "login": "Hvanderwilk", "id": 15908112, "node_id": "MDQ6VXNlcjE1OTA4MTEy", "avatar_url": "https://avatars.githubusercontent.com/u/15908112?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Hvanderwilk", "html_url": "https://github.com/Hvanderwilk", "followers_url": "https://api.github.com/users/Hvanderwilk/followers", "following_url": "https://api.github.com/users/Hvanderwilk/following{/other_user}", "gists_url": "https://api.github.com/users/Hvanderwilk/gists{/gist_id}", "starred_url": "https://api.github.com/users/Hvanderwilk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Hvanderwilk/subscriptions", "organizations_url": "https://api.github.com/users/Hvanderwilk/orgs", "repos_url": "https://api.github.com/users/Hvanderwilk/repos", "events_url": "https://api.github.com/users/Hvanderwilk/events{/privacy}", "received_events_url": "https://api.github.com/users/Hvanderwilk/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29085/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29085", "html_url": "https://github.com/huggingface/transformers/pull/29085", "diff_url": "https://github.com/huggingface/transformers/pull/29085.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29085.patch", "merged_at": null }

{ "login": "NielsRogge", "id": 48327001, "node_id": "MDQ6VXNlcjQ4MzI3MDAx", "avatar_url": "https://avatars.githubusercontent.com/u/48327001?v=4", "gravatar_id": "", "url": "https://api.github.com/users/NielsRogge", "html_url": "https://github.com/NielsRogge", "followers_url": "https://api.github.com/users/NielsRogge/followers", "following_url": "https://api.github.com/users/NielsRogge/following{/other_user}", "gists_url": "https://api.github.com/users/NielsRogge/gists{/gist_id}", "starred_url": "https://api.github.com/users/NielsRogge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/NielsRogge/subscriptions", "organizations_url": "https://api.github.com/users/NielsRogge/orgs", "repos_url": "https://api.github.com/users/NielsRogge/repos", "events_url": "https://api.github.com/users/NielsRogge/events{/privacy}", "received_events_url": "https://api.github.com/users/NielsRogge/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_29084). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]

{ "url": "https://api.github.com/repos/huggingface/transformers/issues/29084/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/29084", "html_url": "https://github.com/huggingface/transformers/pull/29084", "diff_url": "https://github.com/huggingface/transformers/pull/29084.diff", "patch_url": "https://github.com/huggingface/transformers/pull/29084.patch", "merged_at": null }