added saudinewsnet
{'login': 'abdulelahsm', 'id': 28743265, 'node_id': 'MDQ6VXNlcjI4NzQzMjY1', 'avatar_url': 'https://avatars.githubusercontent.com/u/28743265?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/abdulelahsm', 'html_url': 'https://github.com/abdulelahsm', 'followers_url': 'https://api.github.com/users/abdulelahsm/followers', 'following_url': 'https://api.github.com/users/abdulelahsm/following{/other_user}', 'gists_url': 'https://api.github.com/users/abdulelahsm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/abdulelahsm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/abdulelahsm/subscriptions', 'organizations_url': 'https://api.github.com/users/abdulelahsm/orgs', 'repos_url': 'https://api.github.com/users/abdulelahsm/repos', 'events_url': 'https://api.github.com/users/abdulelahsm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/abdulelahsm/received_events', 'type': 'User', 'site_admin': False}
[]
[]
['Hi @abdulelahsm - This is an interesting dataset! But there are multiple issues with the PR. Some of them are listed below: \r\n-  default builder config is not defined. There should be atleast one builder config \r\n- URL is incorrectly constructed so the data files are not being downloaded \r\n- dataset_info.json file was not created\r\n\r\nPlease have a look at some existing merged datasets to get a reference on building the data loader. If you are still stuck, reach out. \r\n'
 '@skyprince999 I totally agree. Thx for the feedback!'
 "Hi @abdulelahsm ! Thanks for adding this one :) \r\nyou don't actually have to add builder configurations if you don't need them. It's fine as it is now\r\n\r\nAnd as @skyprince999 noticed, the current URLs don't work. to download files.\r\nYou can use this one for example for the first batch instead:\r\nhttps://github.com/parallelfold/SaudiNewsNet/raw/master/dataset/2015-07-21.zip\r\n\r\nFeel free to ping me if you have questions or if you're ready for a review :) "
 '@lhoestq Hey, I tried using the first batch instead, the data was downloaded but I got this error, not sure why it can\'t find the path?\r\n\r\nfor content, I ran ``` "./datasets/saudinewsnet/test.py"```\r\n\r\nwhich is a local test I\'m running for the dataset, it contains the following code\r\n\r\n```\r\nfrom datasets import load_dataset\r\n\r\ndata = load_dataset("./datasets/saudinewsnet", split= "train")\r\n\r\nprint(data)\r\n\r\nprint(data[1])\r\n```\r\n\r\nthis is the error I got \r\n\r\n```\r\n2020-12-18 21:45:39.403908: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library \'libcudart.so.10.1\'; dlerror: libcudart.so.10.1: cannot open shared object file: No such file or directory\r\n2020-12-18 21:45:39.403953: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.\r\nUsing custom data configuration default\r\nDownloading and preparing dataset saudi_news_net/default (download: Unknown size, generated: Unknown size, post-processed: Unknown size, total: Unknown size) to /home/mesfas/.cache/huggingface/datasets/saudi_news_net/default/0.0.0/62ece5ef0a991415352d4b1efac681d75b5b3404064fd4f6a1d659499dab18f4...\r\nDownloading: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 3.42M/3.42M [00:03<00:00, 1.03MB/s]\r\nTraceback (most recent call last):\r\n  File "/home/mesfas/opensource/datasets/src/datasets/builder.py", line 604, in _download_and_prepare\r\n    self._prepare_split(split_generator, **prepare_split_kwargs)\r\n  File "/home/mesfas/opensource/datasets/src/datasets/builder.py", line 902, in _prepare_split\r\n    for key, record in utils.tqdm(\r\n  File "/home/mesfas/environments/ar_res_reviews/lib/python3.8/site-packages/tqdm/std.py", line 1133, in __iter__\r\n    for obj in iterable:\r\n  File "/home/mesfas/.cache/huggingface/modules/datasets_modules/datasets/saudinewsnet/62ece5ef0a991415352d4b1efac681d75b5b3404064fd4f6a1d659499dab18f4/saudinewsnet.py", line 108, in _generate_examples\r\n    with open(filepath, encoding="utf-8").read() as f:\r\nIsADirectoryError: [Errno 21] Is a directory: \'/home/mesfas/.cache/huggingface/datasets/downloads/extracted/314fd983aa07d3dada9429911a805270c3285f48759d3584a1343c2d86260765\'\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n  File "./datasets/saudinewsnet/test.py", line 3, in <module>\r\n    data = load_dataset("./datasets/saudinewsnet", split= "train")\r\n  File "/home/mesfas/opensource/datasets/src/datasets/load.py", line 607, in load_dataset\r\n    builder_instance.download_and_prepare(\r\n  File "/home/mesfas/opensource/datasets/src/datasets/builder.py", line 526, in download_and_prepare\r\n    self._download_and_prepare(\r\n  File "/home/mesfas/opensource/datasets/src/datasets/builder.py", line 606, in _download_and_prepare\r\n    raise OSError(\r\nOSError: Cannot find data file. \r\nOriginal error:\r\n[Errno 21] Is a directory: \'/home/mesfas/.cache/huggingface/datasets/downloads/extracted/314fd983aa07d3dada9429911a805270c3285f48759d3584a1343c2d86260765\'\r\n```\r\n\r\n\r\nthis is the split code \r\n\r\n```\r\n    def _split_generators(self, dl_manager):\r\n        """Returns SplitGenerators."""\r\n        my_urls = _URL\r\n        datadir = dl_manager.download_and_extract(my_urls)\r\n        return [\r\n            datasets.SplitGenerator(\r\n                name=datasets.Split.TRAIN,\r\n                # These kwargs will be passed to _generate_examples\r\n                gen_kwargs={\r\n                    "filepath": datadir,\r\n                    "split": "train"\r\n                },\r\n            ),\r\n        ]\r\n```\r\nand this is how I\'m generating the examples\r\n\r\n```\r\n    def _generate_examples(self, filepath, split):\r\n        \r\n        #logging.info("generating examples from = %s", filepath)\r\n        with open(filepath, encoding="utf-8") as f:\r\n            articles = json.load(f)\r\n            for article in articles:\r\n                title = article.get("title", "").strip()\r\n                source = article.get("source", "").strip()\r\n                date = article.get("date_extracted", "").strip()\r\n                link = article.get("url", "").strip()\r\n                author = article.get("author", "").strip()\r\n                content = article.get("content", "").strip()\r\n\r\n                yield id_, {\r\n                    "title": title,\r\n                    "source": source,\r\n                    "date": date,\r\n                    "link": link,\r\n                    "author": author,\r\n                    "content": content\r\n                }\r\n```'
 'What\'s `_URL` ?\r\n\r\nIt looks like you are downloading an archive.\r\nTherefore you may need to get to the file path using `filepath = os.path.join(datadir, "actual_file_name_inside_the_downloaded_archive")`'
 '@lhoestq you were 100% right. Thank you. All fixed' '@lhoestq ping!'
 '@lhoestq  added the remaining 17 batches and modified the readme.md to reflect that + resolved the camel case comment'
 'merging since the CI is fixed on master']
{'url': 'https://api.github.com/repos/huggingface/datasets/pulls/1564', 'html_url': 'https://github.com/huggingface/datasets/pull/1564', 'diff_url': 'https://github.com/huggingface/datasets/pull/1564.diff', 'patch_url': 'https://github.com/huggingface/datasets/pull/1564.patch', 'merged_at': datetime.datetime(2020, 12, 22, 9, 51, 4)}
I'm having issues in creating the dummy data. I'm still investigating how to fix it. I'll close the PR if I couldn't find a solution
{'url': 'https://api.github.com/repos/huggingface/datasets/issues/1564/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}