<commit_before>---
title: Mastering Code Review With GitLab
author:
author_twitter:
categories: concepts
image_title: '/images/code.png'
description: Code review shouldn't be a burden; it should make your team better and faster so you can keep delivering new features on time.  
cta_button_text: 'Join our <strong>Code Review</strong> webcast live!'
cta_button_link: ''
---

How exactly you want to conduct your code review is up to your team-how you share knowledge and best practices between contributors, how you solve problems and divide your workload, and even how you bond might vary significantly from how our teams do so. 

But whatever your team’s rhythm, we expect you face similar pressure to ship new features. Our code review tools were built with the aim of enhancing your review process, taking you from idea to production while setting new personal records for code delivery and quality.  

<!-- more -->

## Demo

In this video, Discussion Lead <NAME> walks through our typical process. 

<iframe src="https://drive.google.com/file/d/0BwXthOgZCRQQWXVIM3dwZThXd2M/preview" width="640" height="480"></iframe>

## Typical Flow

Excellent code depends on rigorous review. At GitLab, every change is reviewed using this flow:

* A developer makes a change in their feature branch and tests it. When they’re happy they push, and make a merge request.
* The developer assigns the merge request to a reviewer, who looks at it and makes line and design level comments as appropriate. When the reviewer is finished, they assign it back to the author. 
* The author addresses the comments. This stage can go around for a while, but once both are happy, one assigns to a final reviewer who can merge.
* The final reviewer follows the same process again. The author again addresses any comments, either by changing the code or by responding with their own comments.
* Once the final reviewer is happy and the build is green, they will merge.

## The GitLab Advantage

Our intuitive discussion tools allow everyone to contribute, and make it easy to follow along with macro- or micro-level conversations, even down to individual lines of code. 

* Resolve conflicts within the UI, rather than going into the command line. This saves you time and distraction by avoiding context-switching. 
* [Watch](https://about.gitlab.com/gitlab-ci/) the build progress through each stage before deployment. This ensures you will never ship broken code, and lets you merge with confidence. 
* [View](https://about.gitlab.com/features/review-apps/) a review app, which allows the reviewer to see the code as it would look if merged. This is the key advantage for less technical team members, because they don’t need to check out the code locally or run the repositories themselves; they can just view the outcome of the change. 


<p class="alert alert-orange" style="background-color: rgba(252,163,38,.3); border-color: rgba(252,163,38,.3); color: rgb(226,67,41) !important; text-align: center;">Catch our webcast &nbsp;&nbsp;<i class="fa fa-gitlab" style="color:rgb(107,79,187); font-size:.85em" aria-hidden="true"></i> &nbsp;&nbsp;<strong>Catch our webcast </strong> &nbsp;&nbsp;<i class="fa fa-gitlab" style="color:rgb(107,79,187); font-size:.85em" aria-hidden="true"></i> &nbsp;&nbsp;on March 14th. <a style="color: rgb(107,79,187);" href="https://page.gitlab.com/20170301_continuouseverything.html">Register here</a>!</p>

_Tweet us [@GitLab](https://twitter.com/gitlab), check out our [job openings](https://about.gitlab.com/jobs/), or add your questions and suggestions to our [issue tracker](https://gitlab.com/gitlab-org/gitlab-ce/issues)!_<commit_msg>remove last section<commit_after>---
title: Mastering Code Review With GitLab
author:
author_twitter:
categories: concepts
image_title: '/images/code.png'
description: Code review shouldn't be a burden; it should make your team better and faster so you can keep delivering new features on time.  
cta_button_text: 'Join our <strong>Code Review</strong> webcast live!'
cta_button_link: ''
---

How exactly you want to conduct your code review is up to your team-how you share knowledge and best practices between contributors, how you solve problems and divide your workload, and even how you bond might vary significantly from how our teams do so. 

But whatever your team’s rhythm, we expect you face similar pressure to ship new features. Our code review tools were built with the aim of enhancing your review process, taking you from idea to production while setting new personal records for code delivery and quality.  

<!-- more -->

## Demo

In this video, Discussion Lead <NAME> walks through our typical process. 

<iframe src="https://drive.google.com/file/d/0BwXthOgZCRQQWXVIM3dwZThXd2M/preview" width="640" height="480"></iframe>

## Typical Flow

Excellent code depends on rigorous review. At GitLab, every change is reviewed using this flow:

* A developer makes a change in their feature branch and tests it. When they’re happy they push, and make a merge request.
* The developer assigns the merge request to a reviewer, who looks at it and makes line and design level comments as appropriate. When the reviewer is finished, they assign it back to the author. 
* The author addresses the comments. This stage can go around for a while, but once both are happy, one assigns to a final reviewer who can merge.
* The final reviewer follows the same process again. The author again addresses any comments, either by changing the code or by responding with their own comments.
* Once the final reviewer is happy and the build is green, they will merge.


<p class="alert alert-orange" style="background-color: rgba(252,163,38,.3); border-color: rgba(252,163,38,.3); color: rgb(226,67,41) !important; text-align: center;">Catch our webcast &nbsp;&nbsp;<i class="fa fa-gitlab" style="color:rgb(107,79,187); font-size:.85em" aria-hidden="true"></i> &nbsp;&nbsp;<strong>Catch our webcast </strong> &nbsp;&nbsp;<i class="fa fa-gitlab" style="color:rgb(107,79,187); font-size:.85em" aria-hidden="true"></i> &nbsp;&nbsp;on March 14th. <a style="color: rgb(107,79,187);" href="https://page.gitlab.com/20170301_continuouseverything.html">Register here</a>!</p>

_Tweet us [@GitLab](https://twitter.com/gitlab), check out our [job openings](https://about.gitlab.com/jobs/), or add your questions and suggestions to our [issue tracker](https://gitlab.com/gitlab-org/gitlab-ce/issues)!_
{'fraction_non_alphanumeric': 0.0947940947940948, 'fraction_numerical': 0.022377622377622378, 'mean_word_length': 4.94275161588181, 'pattern_counts': {'":': 0, '<': 35, '<?xml version=': 0, '>': 35, 'https://': 12, 'lorem ipsum': 0, 'www.': 0, 'xml': 0}, 'pii_count': 0, 'substrings_counts': 0, 'word_list_counts': {'cursed_substrings.json': 0, 'profanity_word_list.json': 0, 'sexual_word_list.json': 0, 'zh_pornsignals.json': 0}}
{'dir': 'git-commits-cleaned', 'id': '2769110', 'n_tokens_mistral': 1897, 'n_tokens_neox': 1719, 'n_words': 821}