<commit_before>package org.jimmutable.storage;


import org.jimmutable.core.objects.common.Kind;
import org.jimmutable.core.objects.common.ObjectId;
import org.jimmutable.core.serialization.Format;
/**
 *
 * @author andrew.towe
 * This class is designed to help us with object storage. All things that can be stored will be a child of this class.
 *
 */

public abstract class Storable
{
	abstract public Kind getSimpleKind();
	abstract public ObjectId getSimpleObjectId();
	abstract public String serialize(Format format);
	public StorageKey createStorageKey()
	{
		return new StorageKey(getSimpleKind(), getSimpleObjectId(), "xml");
	}
}
<commit_msg>Code review<commit_after>package org.jimmutable.storage;


import org.jimmutable.core.objects.common.Kind;
import org.jimmutable.core.objects.common.ObjectId;
import org.jimmutable.core.serialization.Format;
/**
 *
 * @author andrew.towe
 * This class is designed to help us with object storage. All things that can be stored will be a child of this class.
 *
 */

public abstract class Storable
{
	// CODE REVIEW: These methods need javadoc
	
	abstract public Kind getSimpleKind();
	abstract public ObjectId getSimpleObjectId();
	abstract public String serialize(Format format);
	
	// Code review: space this out (I did it for you)
	
	public StorageKey createStorageKey()
	{
		return new StorageKey(getSimpleKind(), getSimpleObjectId(), "xml"); // CODE REVEIW: The third paramater should be StorageKeyExtension, not a string. Since it will be used so much, I suggest creating a static private final StorageKeyExtension XML = new StorageKeyExtension("xml"); in StorageKeyExtension
	}
}

{'fraction_non_alphanumeric': 0.08791208791208792, 'fraction_numerical': 0.0, 'mean_word_length': 4.89568345323741, 'pattern_counts': {'":': 0, '<': 3, '<?xml version=': 0, '>': 3, 'https://': 0, 'lorem ipsum': 0, 'www.': 0, 'xml': 3}, 'pii_count': 0, 'substrings_counts': 0, 'word_list_counts': {'cursed_substrings.json': 0, 'profanity_word_list.json': 0, 'sexual_word_list.json': 0, 'zh_pornsignals.json': 0}}
{'dir': 'git-commits-cleaned', 'id': '2887212', 'n_tokens_mistral': 470, 'n_tokens_neox': 463, 'n_words': 164}