<commit_before>import SPELLS from 'common/SPELLS';
import CoreAbilities from 'Parser/Core/Modules/Abilities';
import ISSUE_IMPORTANCE from 'Parser/Core/ISSUE_IMPORTANCE';

/* eslint-disable no-unused-vars */

class Abilities extends CoreAbilities {
  static ABILITIES = [
    ...CoreAbilities.ABILITIES,
    {
      spell: SPELLS.VANISH,
      category: Abilities.SPELL_CATEGORIES.COOLDOWNS,
      getCooldown: haste => 90,
      //Vanish is often delayed.
      recommendedCastEfficiency: 0.90,
    },
    {
      spell: SPELLS.SHADOW_BLADES, // TODO: Reduced by Convergence of Fates
      category: Abilities.SPELL_CATEGORIES.COOLDOWNS,
      getCooldown: haste => 180,
      recommendedCastEfficiency: 1.0,
    },
    {
      spell: SPELLS.SYMBOLS_OF_DEATH,
      category: Abilities.SPELL_CATEGORIES.ROTATIONAL,
      getCooldown: (haste, combatant) => (30 - (combatant.hasBuff(SPELLS.SUB_ROGUE_T20_2SET_BONUS.id) ? 5 : 0)), 
      recommendedCastEfficiency: 0.95,
      importance: ISSUE_IMPORTANCE.MAJOR,
      extraSuggestion: "This is the most important rotational ability, try to allways use it on cooldown.",      
    },
    {
      spell: SPELLS.SHADOW_DANCE,
      category: Abilities.SPELL_CATEGORIES.ROTATIONAL,
      getCooldown: haste => 60, // TODO: Reduced by a passive.
      charges: 2,
      recommendedCastEfficiency: 1,
    },
    {
      spell: SPELLS.GOREMAWS_BITE,
      category: Abilities.SPELL_CATEGORIES.COOLDOWNS,
      getCooldown: haste => 60,
      recommendedCastEfficiency: 0.9,
    },   
    //No recomendations 
    {      
      spell: SPELLS.DEATH_FROM_ABOVE_TALENT,
      category: Abilities.SPELL_CATEGORIES.ROTATIONAL,
      // Real cooldown is 20 seconds. But this should be used only with Symbols. 
      // TODO: Track sepratly!
      getCooldown: haste => 20,
      noSuggestion: true,<commit_msg>code review corrections<commit_after>import SPELLS from 'common/SPELLS';
import CoreAbilities from 'Parser/Core/Modules/Abilities';
import ISSUE_IMPORTANCE from 'Parser/Core/ISSUE_IMPORTANCE';

/* eslint-disable no-unused-vars */

class Abilities extends CoreAbilities {
  static ABILITIES = [
    ...CoreAbilities.ABILITIES,
    {
      spell: SPELLS.VANISH,
      category: Abilities.SPELL_CATEGORIES.COOLDOWNS,
      getCooldown: haste => 90,
      //Vanish is often delayed.
      recommendedCastEfficiency: 0.90,
    },
    {
      spell: SPELLS.SHADOW_BLADES, // TODO: Reduced by Convergence of Fates
      category: Abilities.SPELL_CATEGORIES.COOLDOWNS,
      getCooldown: haste => 180,
      recommendedCastEfficiency: 1.0,
      extraSuggestion: "In most cases should be used on cooldown", 
    },
    {
      spell: SPELLS.SYMBOLS_OF_DEATH,
      category: Abilities.SPELL_CATEGORIES.ROTATIONAL,
      getCooldown: (haste, combatant) => (30 - (combatant.hasBuff(SPELLS.SUB_ROGUE_T20_2SET_BONUS.id) ? 5 : 0)), 
      recommendedCastEfficiency: 0.95,
      importance: ISSUE_IMPORTANCE.MAJOR,
      extraSuggestion: "This is the most important rotational ability, try to always use it on cooldown.",      
    },
    {
      spell: SPELLS.SHADOW_DANCE,
      category: Abilities.SPELL_CATEGORIES.ROTATIONAL,
      getCooldown: haste => 60, // TODO: Reduced by a passive
      charges: 2,
      noSuggestion: true,
    },
    {
      spell: SPELLS.GOREMAWS_BITE,
      category: Abilities.SPELL_CATEGORIES.COOLDOWNS,
      getCooldown: haste => 60,
      recommendedCastEfficiency: 0.9,
    },   
    //No recomendations 
    {      
      spell: SPELLS.DEATH_FROM_ABOVE_TALENT,
      category: Abilities.SPELL_CATEGORIES.ROTATIONAL,
      // TODO: Track sepratly!
      // This should be used only with Symbols. 
      getCooldown: haste => 20,
      noSuggestion: true,
{'fraction_non_alphanumeric': 0.09562181036798281, 'fraction_numerical': 0.016384636046199302, 'mean_word_length': 2.899476439790576, 'pattern_counts': {'":': 0, '<': 3, '<?xml version=': 0, '>': 15, 'https://': 0, 'lorem ipsum': 0, 'www.': 0, 'xml': 0}, 'pii_count': 0, 'substrings_counts': 0, 'word_list_counts': {'cursed_substrings.json': 0, 'profanity_word_list.json': 0, 'sexual_word_list.json': 0, 'zh_pornsignals.json': 0}}
{'dir': 'git-commits-cleaned', 'id': '1787670', 'n_tokens_mistral': 1394, 'n_tokens_neox': 1315, 'n_words': 266}