Datasets:

akumoth

/

peewee-issues

like 0

{ "login": "goir", "id": 586209, "node_id": "MDQ6VXNlcjU4NjIwOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/586209?v=4", "gravatar_id": "", "url": "https://api.github.com/users/goir", "html_url": "https://github.com/goir", "followers_url": "https://api.github.com/users/goir/followers", "following_url": "https://api.github.com/users/goir/following{/other_user}", "gists_url": "https://api.github.com/users/goir/gists{/gist_id}", "starred_url": "https://api.github.com/users/goir/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/goir/subscriptions", "organizations_url": "https://api.github.com/users/goir/orgs", "repos_url": "https://api.github.com/users/goir/repos", "events_url": "https://api.github.com/users/goir/events{/privacy}", "received_events_url": "https://api.github.com/users/goir/received_events", "type": "User", "site_admin": false }

[]

[]

[ "SQLite will store timezone info, but I'm not sure what facilities it provides for sorting when you've got a mixture of timezones (without involving various date functions). You'll probably want to read up on it here: https://www.sqlite.org/lang_datefunc.html -- It might be more convenient to convert to UTC in your application before passing ot the database.\n\nThat said, it does seem like peewee should handle the timezone. For now you can subclass the `DateTimeField` and override the formats class attribute.\n\nI'll look into a fix.\n", "I agree, its not really an issue, more a feature request to have a timezone aware datetime field.\n", "I don't believe I will implement this. If you want to register your own adapter at the driver level, or if you want to implement your own TZ-aware sqlite datetime-field, then I think that'd be the best course. A general purpose solution, though, I'm going to pass on.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/914/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ck196", "id": 1131215, "node_id": "MDQ6VXNlcjExMzEyMTU=", "avatar_url": "https://avatars.githubusercontent.com/u/1131215?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ck196", "html_url": "https://github.com/ck196", "followers_url": "https://api.github.com/users/ck196/followers", "following_url": "https://api.github.com/users/ck196/following{/other_user}", "gists_url": "https://api.github.com/users/ck196/gists{/gist_id}", "starred_url": "https://api.github.com/users/ck196/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ck196/subscriptions", "organizations_url": "https://api.github.com/users/ck196/orgs", "repos_url": "https://api.github.com/users/ck196/repos", "events_url": "https://api.github.com/users/ck196/events{/privacy}", "received_events_url": "https://api.github.com/users/ck196/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Please fix the formatting of code.\n", "Sorry, i've updated code formatting.\n", "To fix this I believe if you explicitly select the Video ID column you'll be set:\n\n``` python\nvideo = Video.select(Video.id).where(Video.name == 'v5.mp4')\nquery = Relationship.delete().where(Relationship.video == video)\nprint query\n```\n\nOutputs:\n\n``` sql\nDELETE FROM \"relationship\" \nWHERE (\"video_id\" = (\n SELECT \"t1\".\"id\" \n FROM \"video\" AS t1 \n WHERE (\"t1\".\"name\" = ?) \n ORDER BY \"t1\".\"add_date\" DESC\n))\n```\n\nIf you've already got the query from somewhere else and want to modify the SELECT clause, you can do:\n\n``` python\nquery = Relationship.delete().where(Relationship.video == video.select(Video.id))\n```\n\n---\n\nAn unrelated suggestion:\n\nNever ever ever specify a default ordering for your models. It's a code smell and I regret building it into Peewee's API (the idea comes from Django originally, and the Django community seems to feel the same way about it). If you want a default ordering that's easily accessible, just do something like:\n\n``` python\nclass Video(BaseModel):\n # ... fields ...\n\n @classmethod\n def all(cls):\n return cls.select().order_by(cls.add_date.desc())\n\n# ------ elsewhere in your code ------ #\n\nvideos = Video.all()\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/913/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jet10000", "id": 2258120, "node_id": "MDQ6VXNlcjIyNTgxMjA=", "avatar_url": "https://avatars.githubusercontent.com/u/2258120?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jet10000", "html_url": "https://github.com/jet10000", "followers_url": "https://api.github.com/users/jet10000/followers", "following_url": "https://api.github.com/users/jet10000/following{/other_user}", "gists_url": "https://api.github.com/users/jet10000/gists{/gist_id}", "starred_url": "https://api.github.com/users/jet10000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jet10000/subscriptions", "organizations_url": "https://api.github.com/users/jet10000/orgs", "repos_url": "https://api.github.com/users/jet10000/repos", "events_url": "https://api.github.com/users/jet10000/events{/privacy}", "received_events_url": "https://api.github.com/users/jet10000/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Peewee should work with any Python DB-API 2.0 driver. It looks like work has started on adding one for cockroachdb:\n\nhttps://github.com/cockroachdb/cockroach-python/pull/12\n\nAfter that, follow the instructions here to integrate with Peewee:\n\nhttp://docs.peewee-orm.com/en/latest/peewee/database.html#adding-a-new-database-driver\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/912/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ahessert", "id": 10226899, "node_id": "MDQ6VXNlcjEwMjI2ODk5", "avatar_url": "https://avatars.githubusercontent.com/u/10226899?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ahessert", "html_url": "https://github.com/ahessert", "followers_url": "https://api.github.com/users/ahessert/followers", "following_url": "https://api.github.com/users/ahessert/following{/other_user}", "gists_url": "https://api.github.com/users/ahessert/gists{/gist_id}", "starred_url": "https://api.github.com/users/ahessert/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ahessert/subscriptions", "organizations_url": "https://api.github.com/users/ahessert/orgs", "repos_url": "https://api.github.com/users/ahessert/repos", "events_url": "https://api.github.com/users/ahessert/events{/privacy}", "received_events_url": "https://api.github.com/users/ahessert/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/911/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/911", "html_url": "https://github.com/coleifer/peewee/pull/911", "diff_url": "https://github.com/coleifer/peewee/pull/911.diff", "patch_url": "https://github.com/coleifer/peewee/pull/911.patch", "merged_at": "2016-04-12T21:35:33" }

{ "login": "daoiqi", "id": 2141872, "node_id": "MDQ6VXNlcjIxNDE4NzI=", "avatar_url": "https://avatars.githubusercontent.com/u/2141872?v=4", "gravatar_id": "", "url": "https://api.github.com/users/daoiqi", "html_url": "https://github.com/daoiqi", "followers_url": "https://api.github.com/users/daoiqi/followers", "following_url": "https://api.github.com/users/daoiqi/following{/other_user}", "gists_url": "https://api.github.com/users/daoiqi/gists{/gist_id}", "starred_url": "https://api.github.com/users/daoiqi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/daoiqi/subscriptions", "organizations_url": "https://api.github.com/users/daoiqi/orgs", "repos_url": "https://api.github.com/users/daoiqi/repos", "events_url": "https://api.github.com/users/daoiqi/events{/privacy}", "received_events_url": "https://api.github.com/users/daoiqi/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Yes, try wrapping your select in an atomic block:\n\n``` python\nwith database.atomic():\n a = TVm.select()...\n```\n", "``` python\nwhile True:\n uuid = '8d443fb7-3e30-4149-bb32-89ee5532eddc'\n a = TVm.select().where(\n TVm.uuid == uuid)\n for x in a:\n print x.createTime, x.mem\n database.commit() # it will get realtime data.\n time.sleep(5)\n```\n", "Yes. You can also enable commit on all selects:\n\ndatabase.commit_select = True\n", "see https://github.com/coleifer/peewee/commit/6087199320a3ad8968add5d50f6c3a047767afdd\n\nI use 2.7.3 so every select not commit. upgrade to 2.8.0 to fix it. thanks.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/910/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Dongin", "id": 4242860, "node_id": "MDQ6VXNlcjQyNDI4NjA=", "avatar_url": "https://avatars.githubusercontent.com/u/4242860?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Dongin", "html_url": "https://github.com/Dongin", "followers_url": "https://api.github.com/users/Dongin/followers", "following_url": "https://api.github.com/users/Dongin/following{/other_user}", "gists_url": "https://api.github.com/users/Dongin/gists{/gist_id}", "starred_url": "https://api.github.com/users/Dongin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Dongin/subscriptions", "organizations_url": "https://api.github.com/users/Dongin/orgs", "repos_url": "https://api.github.com/users/Dongin/repos", "events_url": "https://api.github.com/users/Dongin/events{/privacy}", "received_events_url": "https://api.github.com/users/Dongin/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Correct, because peewee is not magical, it will not magically retrieve a value that was created by the database server.\n\nYou look to be using MySQL, which AFAIK does not support INSERT ... RETURNING. So you will need to re-fetch the record or alternatively create the timestamp in Python and send it to the server.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/909/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "aaronwp", "id": 1002418, "node_id": "MDQ6VXNlcjEwMDI0MTg=", "avatar_url": "https://avatars.githubusercontent.com/u/1002418?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aaronwp", "html_url": "https://github.com/aaronwp", "followers_url": "https://api.github.com/users/aaronwp/followers", "following_url": "https://api.github.com/users/aaronwp/following{/other_user}", "gists_url": "https://api.github.com/users/aaronwp/gists{/gist_id}", "starred_url": "https://api.github.com/users/aaronwp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aaronwp/subscriptions", "organizations_url": "https://api.github.com/users/aaronwp/orgs", "repos_url": "https://api.github.com/users/aaronwp/repos", "events_url": "https://api.github.com/users/aaronwp/events{/privacy}", "received_events_url": "https://api.github.com/users/aaronwp/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hmm, but `tuple` does have `len`...\n\n``` python\nIn [1]: x = (1,2,3)\n\nIn [2]: len(x)\nOut[2]: 3\n```\n", "See my sample code below. For some reason I was thinking it was just a documentation issue, but perhaps it's a bug...? \n\n```\nmysql_db = PooledMySQLDatabase('dbname',\n host=os.environ['DB_HOST'],\n user=os.environ['DB_USER'],\n passwd=os.environ['DB_PASS'],\n max_connections=32,\n stale_timeout=300) # 5 minutes.\n\nmysql_read_db = PooledMySQLDatabase('dbname',\n host=os.environ['DB_READ_HOST'],\n user=os.environ['DB_USER'],\n passwd=os.environ['DB_PASS'],\n max_connections=32,\n stale_timeout=300) # 5 minutes.\n\ndef _db_close(exc):\n databases = [mysql_db,mysql_read_db]\n for database in databases:\n if not database.is_closed():\n database.close() \n\nclass BaseModel(ReadSlaveModel):\n class Meta:\n database = mysql_db\n read_slaves = [mysql_read_db] // <--- if (mysql_read_db) then i get error. \n\n```\n", "A tuple with only one item needs a trailing comma.\n\n(db,)\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/908/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/908", "html_url": "https://github.com/coleifer/peewee/pull/908", "diff_url": "https://github.com/coleifer/peewee/pull/908.diff", "patch_url": "https://github.com/coleifer/peewee/pull/908.patch", "merged_at": null }

{ "login": "charleschen", "id": 698190, "node_id": "MDQ6VXNlcjY5ODE5MA==", "avatar_url": "https://avatars.githubusercontent.com/u/698190?v=4", "gravatar_id": "", "url": "https://api.github.com/users/charleschen", "html_url": "https://github.com/charleschen", "followers_url": "https://api.github.com/users/charleschen/followers", "following_url": "https://api.github.com/users/charleschen/following{/other_user}", "gists_url": "https://api.github.com/users/charleschen/gists{/gist_id}", "starred_url": "https://api.github.com/users/charleschen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/charleschen/subscriptions", "organizations_url": "https://api.github.com/users/charleschen/orgs", "repos_url": "https://api.github.com/users/charleschen/repos", "events_url": "https://api.github.com/users/charleschen/events{/privacy}", "received_events_url": "https://api.github.com/users/charleschen/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Not sure what happened...It doesn't look to have been in any release, so I guess I just spaced out. It will be included in the next release to pypi, which should be in the upcoming week or two.\n", "thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/907/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "nomorepanic", "id": 9201926, "node_id": "MDQ6VXNlcjkyMDE5MjY=", "avatar_url": "https://avatars.githubusercontent.com/u/9201926?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nomorepanic", "html_url": "https://github.com/nomorepanic", "followers_url": "https://api.github.com/users/nomorepanic/followers", "following_url": "https://api.github.com/users/nomorepanic/following{/other_user}", "gists_url": "https://api.github.com/users/nomorepanic/gists{/gist_id}", "starred_url": "https://api.github.com/users/nomorepanic/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nomorepanic/subscriptions", "organizations_url": "https://api.github.com/users/nomorepanic/orgs", "repos_url": "https://api.github.com/users/nomorepanic/repos", "events_url": "https://api.github.com/users/nomorepanic/events{/privacy}", "received_events_url": "https://api.github.com/users/nomorepanic/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Pushed a testcase... It passed locally on py2.7 with sqlite, so we'll see what's up.\n", "I found what's happening. My model has a nullable 'delete' field and that overwrites the delete method. \nThank you for prompt reply but it was my distraction :)\n\nYou could consider renaming the delete method to _delete, but I do not know whether this would make sense with peewee.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/906/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "lixxu", "id": 264487, "node_id": "MDQ6VXNlcjI2NDQ4Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/264487?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lixxu", "html_url": "https://github.com/lixxu", "followers_url": "https://api.github.com/users/lixxu/followers", "following_url": "https://api.github.com/users/lixxu/following{/other_user}", "gists_url": "https://api.github.com/users/lixxu/gists{/gist_id}", "starred_url": "https://api.github.com/users/lixxu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lixxu/subscriptions", "organizations_url": "https://api.github.com/users/lixxu/orgs", "repos_url": "https://api.github.com/users/lixxu/repos", "events_url": "https://api.github.com/users/lixxu/events{/privacy}", "received_events_url": "https://api.github.com/users/lixxu/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you for this!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/905/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/905", "html_url": "https://github.com/coleifer/peewee/pull/905", "diff_url": "https://github.com/coleifer/peewee/pull/905.diff", "patch_url": "https://github.com/coleifer/peewee/pull/905.patch", "merged_at": "2016-04-07T18:47:17" }

{ "login": "kammala", "id": 4599701, "node_id": "MDQ6VXNlcjQ1OTk3MDE=", "avatar_url": "https://avatars.githubusercontent.com/u/4599701?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kammala", "html_url": "https://github.com/kammala", "followers_url": "https://api.github.com/users/kammala/followers", "following_url": "https://api.github.com/users/kammala/following{/other_user}", "gists_url": "https://api.github.com/users/kammala/gists{/gist_id}", "starred_url": "https://api.github.com/users/kammala/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kammala/subscriptions", "organizations_url": "https://api.github.com/users/kammala/orgs", "repos_url": "https://api.github.com/users/kammala/repos", "events_url": "https://api.github.com/users/kammala/events{/privacy}", "received_events_url": "https://api.github.com/users/kammala/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Nice pull request, and nice catch. Thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/904/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/904", "html_url": "https://github.com/coleifer/peewee/pull/904", "diff_url": "https://github.com/coleifer/peewee/pull/904.diff", "patch_url": "https://github.com/coleifer/peewee/pull/904.patch", "merged_at": "2016-04-03T02:39:53" }

{ "login": "smilledge", "id": 1536407, "node_id": "MDQ6VXNlcjE1MzY0MDc=", "avatar_url": "https://avatars.githubusercontent.com/u/1536407?v=4", "gravatar_id": "", "url": "https://api.github.com/users/smilledge", "html_url": "https://github.com/smilledge", "followers_url": "https://api.github.com/users/smilledge/followers", "following_url": "https://api.github.com/users/smilledge/following{/other_user}", "gists_url": "https://api.github.com/users/smilledge/gists{/gist_id}", "starred_url": "https://api.github.com/users/smilledge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/smilledge/subscriptions", "organizations_url": "https://api.github.com/users/smilledge/orgs", "repos_url": "https://api.github.com/users/smilledge/repos", "events_url": "https://api.github.com/users/smilledge/events{/privacy}", "received_events_url": "https://api.github.com/users/smilledge/received_events", "type": "User", "site_admin": false }

[]

[]

[ "It's named Generic Foreign Keys. Check the Playhouse docs.\nOn Apr 2, 2016 2:07 PM, \"Sam Milledge\" [email protected] wrote:\n\n> Does peewee support polymorphic relationships?\n> \n> Would be awesome to have something similar to what is provided by Laravel\n> and Rails:\n> https://laravel.com/docs/5.1/eloquent-relationships#polymorphic-relations\n> \n> http://guides.rubyonrails.org/association_basics.html#polymorphic-associations\n> \n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly or view it on GitHub\n> https://github.com/coleifer/peewee/issues/903\n", "Didn't see that, thanks!\n", "Thanks @arikfr ! @smilledge feel free to reply if you have follow-up questions.\n", "I've made a simple generic foreign key implementation: https://gist.github.com/wonderbeyond/0e1f402b7595e0b4f9f653260fed029c#file-index-md" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/903/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "mivade", "id": 2805515, "node_id": "MDQ6VXNlcjI4MDU1MTU=", "avatar_url": "https://avatars.githubusercontent.com/u/2805515?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mivade", "html_url": "https://github.com/mivade", "followers_url": "https://api.github.com/users/mivade/followers", "following_url": "https://api.github.com/users/mivade/following{/other_user}", "gists_url": "https://api.github.com/users/mivade/gists{/gist_id}", "starred_url": "https://api.github.com/users/mivade/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mivade/subscriptions", "organizations_url": "https://api.github.com/users/mivade/orgs", "repos_url": "https://api.github.com/users/mivade/repos", "events_url": "https://api.github.com/users/mivade/events{/privacy}", "received_events_url": "https://api.github.com/users/mivade/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm a bit at a loss. Can you tell me what `table.model._meta.primary_key` returns? As well as `table._meta.fields`. Thanks!\n", "Basically it looks like your table has a composite primary key, and when asked for `table.model._meta.primary_key.field_names`, it's returning a list of lists?\n", "Hm, that could be, although I don't quite understand why. I'll post the requested information tomorrow when I again have access to the real data as in the original issue.\n\nIn the meantime, I have an offline testing version which only uses a subset of the keys in the dict above. On my own computer running Postgres 9.4, there are no problems. So I am not sure if that is somehow related to using fewer keys/columns or if there is a version-specific bug.\n", "Is there an `id` column present in any of the data you're loading?\n", "I'm tempted to think this is just a data issue, but until you can get me the output (and even better the actual row data) when it crashes that'd be great.\n", "There is no explicit `id` column; only the columns given above in the form of keys exist. The table also does not exist prior to the `table.insert` call.\n", "I was able to resolve this problem by dropping the table which had been created prior to trying to write (but was empty) and letting peewee handle the table creation itself. However, before doing this, I checked the output of `table.model_class._meta.primary_key` and `table.model_class._meta.fields`. Using `sqlite:///:memory:`, on the first run, I get:\n\n```\nprimary key\n<peewee.PrimaryKeyField object at 0x7f64787617b8>\nfields\n{'id': <peewee.PrimaryKeyField object at 0x7f64787617b8>}\n```\n\nand after the initial insert:\n\n```\nprimary key\n<peewee.PrimaryKeyField object at 0x7fa7322206a0>\nfields\n{'beat1_lb_mon': <peewee.FloatField object at 0x7fa7322140b8>,\n 'beat1_lb_status': <peewee.IntegerField object at 0x7fa7322141d0>,\n 'beat1_signal': <peewee.FloatField object at 0x7fa732220fd0>,\n 'beat1_signalaux': <peewee.FloatField object at 0x7fa732220c18>,\n 'beat1_waveplate': <peewee.FloatField object at 0x7fa732220cf8>,\n 'beat2_lb_mon': <peewee.FloatField object at 0x7fa732214160>,\n 'beat2_lb_status': <peewee.IntegerField object at 0x7fa7322207b8>,\n 'beat2_signal': <peewee.FloatField object at 0x7fa732214748>,\n 'beat2_signalaux': <peewee.FloatField object at 0x7fa7322143c8>,\n 'counter0_freq': <peewee.FloatField object at 0x7fa732214198>,\n 'counter0_freqref': <peewee.FloatField object at 0x7fa732220ef0>,\n 'counter1_freq': <peewee.FloatField object at 0x7fa732220da0>,\n 'counter1_freqref': <peewee.FloatField object at 0x7fa7322147b8>,\n 'counter2_freq': <peewee.FloatField object at 0x7fa732220f28>,\n 'counter2_signal': <peewee.FloatField object at 0x7fa732220e48>,\n 'counter3_freq': <peewee.FloatField object at 0x7fa732214208>,\n 'counter3_signal': <peewee.FloatField object at 0x7fa732214048>,\n 'counter_channels': <peewee.IntegerField object at 0x7fa732220f60>,\n 'counter_gatetime': <peewee.FloatField object at 0x7fa732220eb8>,\n 'cw1_freq': <peewee.FloatField object at 0x7fa732220e10>,\n 'cw2_freq': <peewee.FloatField object at 0x7fa732220828>,\n 'id': <peewee.PrimaryKeyField object at 0x7fa7322206a0>,\n 'laser_mldet_ac': <peewee.FloatField object at 0x7fa732214400>,\n 'laser_mldet_dc': <peewee.FloatField object at 0x7fa732220b70>,\n 'lb1_mon': <peewee.FloatField object at 0x7fa732214390>,\n 'lb1_status': <peewee.IntegerField object at 0x7fa732220b00>,\n 'lb2_mon': <peewee.FloatField object at 0x7fa732214278>,\n 'lb2_status': <peewee.IntegerField object at 0x7fa732214358>,\n 'lb3_mon': <peewee.FloatField object at 0x7fa732220ac8>,\n 'lb3_status': <peewee.IntegerField object at 0x7fa732220dd8>,\n 'lb4_mon': <peewee.FloatField object at 0x7fa732214320>,\n 'lb4_status': <peewee.IntegerField object at 0x7fa732220ba8>,\n 'lb5_mon': <peewee.FloatField object at 0x7fa732214080>,\n 'lb5_status': <peewee.IntegerField object at 0x7fa732220c88>,\n 'lb6_mon': <peewee.FloatField object at 0x7fa732214438>,\n 'lb6_status': <peewee.IntegerField object at 0x7fa732220d68>,\n 'offset_freq': <peewee.FloatField object at 0x7fa732220cc0>,\n 'offset_freqref': <peewee.FloatField object at 0x7fa732220f98>,\n 'offset_signal': <peewee.FloatField object at 0x7fa732220b38>,\n 'offset_stage': <peewee.FloatField object at 0x7fa732220e80>,\n 'reprate_freq': <peewee.FloatField object at 0x7fa732220c50>,\n 'reprate_freqref': <peewee.FloatField object at 0x7fa732214128>,\n 'reprate_stage': <peewee.FloatField object at 0x7fa732220748>,\n 'syncro_adc_channel2': <peewee.FloatField object at 0x7fa732214240>,\n 'system_latency': <peewee.FloatField object at 0x7fa732214780>,\n 'system_locked': <peewee.IntegerField object at 0x7fa7322142b0>,\n 'system_locked_for': <peewee.FloatField object at 0x7fa7322140f0>,\n 'system_plo_ok': <peewee.IntegerField object at 0x7fa7322142e8>,\n 'timestamp': <peewee.FloatField object at 0x7fa732220d30>}\n```\n\nWith Postgres, prior to the insert (where it crashes):\n\n```\nprimary key\n<peewee.PrimaryKeyField object at 0x7f4afa8afb00>\nfields\n{'id': <peewee.PrimaryKeyField object at 0x7f4afa8afb00>}\n```\n\nIs there any other testing you can suggest to help figure out why this fails when the empty table exists?\n", "No idea, other than that the table perhaps is missing a primary key?\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/902/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "josefdlange", "id": 1062835, "node_id": "MDQ6VXNlcjEwNjI4MzU=", "avatar_url": "https://avatars.githubusercontent.com/u/1062835?v=4", "gravatar_id": "", "url": "https://api.github.com/users/josefdlange", "html_url": "https://github.com/josefdlange", "followers_url": "https://api.github.com/users/josefdlange/followers", "following_url": "https://api.github.com/users/josefdlange/following{/other_user}", "gists_url": "https://api.github.com/users/josefdlange/gists{/gist_id}", "starred_url": "https://api.github.com/users/josefdlange/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/josefdlange/subscriptions", "organizations_url": "https://api.github.com/users/josefdlange/orgs", "repos_url": "https://api.github.com/users/josefdlange/repos", "events_url": "https://api.github.com/users/josefdlange/events{/privacy}", "received_events_url": "https://api.github.com/users/josefdlange/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Indeed, for that you will need to probably consult the postgres manual for the correct SQL. Peewee handles most things, but this is one of the ones it doesn't.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/901/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "maaaks", "id": 3010238, "node_id": "MDQ6VXNlcjMwMTAyMzg=", "avatar_url": "https://avatars.githubusercontent.com/u/3010238?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maaaks", "html_url": "https://github.com/maaaks", "followers_url": "https://api.github.com/users/maaaks/followers", "following_url": "https://api.github.com/users/maaaks/following{/other_user}", "gists_url": "https://api.github.com/users/maaaks/gists{/gist_id}", "starred_url": "https://api.github.com/users/maaaks/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maaaks/subscriptions", "organizations_url": "https://api.github.com/users/maaaks/orgs", "repos_url": "https://api.github.com/users/maaaks/repos", "events_url": "https://api.github.com/users/maaaks/events{/privacy}", "received_events_url": "https://api.github.com/users/maaaks/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Your example foreign key definition doesn't make much sense...why would the foreign key be called \"child\" when it points at a Parent? I'm just going to assume this is a meaningless example...\n\nAt any rate, you can always just do:\n\n``` python\nclass Category(Model):\n parent = ForeignKeyField(\"self\", related_name=\"children_backref\")\n\n @property\n def children(self):\n return self.children_backref.order_by(Category.name)\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/900/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "frnhr", "id": 1173748, "node_id": "MDQ6VXNlcjExNzM3NDg=", "avatar_url": "https://avatars.githubusercontent.com/u/1173748?v=4", "gravatar_id": "", "url": "https://api.github.com/users/frnhr", "html_url": "https://github.com/frnhr", "followers_url": "https://api.github.com/users/frnhr/followers", "following_url": "https://api.github.com/users/frnhr/following{/other_user}", "gists_url": "https://api.github.com/users/frnhr/gists{/gist_id}", "starred_url": "https://api.github.com/users/frnhr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/frnhr/subscriptions", "organizations_url": "https://api.github.com/users/frnhr/orgs", "repos_url": "https://api.github.com/users/frnhr/repos", "events_url": "https://api.github.com/users/frnhr/events{/privacy}", "received_events_url": "https://api.github.com/users/frnhr/received_events", "type": "User", "site_admin": false }

[]

[]

[ "http://docs.peewee-orm.com/en/latest/peewee/models.html#circular-foreign-key-dependencies\n\nIf you read through that section, you'll see towards the end that you need to explicitly create the foreign key constraint:\n\n> After initializing the deferred relation, the foreign key fields are now correctly set up. There is one more quirk to watch out for, though. When you call create_table we will again encounter the same issue. For this reason peewee will not automatically create a foreign key constraint for any deferred foreign keys.\n> \n> Here is how to create the tables:\n\n``` python\n# Foreign key constraint from User -> Tweet will NOT be created because the\n# Tweet table does not exist yet. `favorite_tweet` will just be a regular\n# integer field:\nUser.create_table()\n\n# Foreign key constraint from Tweet -> User will be created normally.\nTweet.create_table()\n\n# Now that both tables exist, we can create the foreign key from User -> Tweet:\n# NOTE: this will not work in SQLite!\ndb.create_foreign_key(User, User.favorite_tweet)\n```\n\n---\n\nIn your example, for one I think you copy/pasted wrong and the model below `User` should be \"PostThatsDeferred\", but more to the point: there's no reason for using a deferred relation. You can just write:\n\n``` python\nclass PostNotDeferred(BaseModel):\n title = CharField()\n\nclass PostThatsDeferred(BaseModel):\n title = CharField()\n\nclass User(BaseModel):\n username = CharField()\n post_not_deferred = ForeignKeyField(PostNotDeferred, null=True)\n post_thats_deferred = ForeignKeyField(PostThatsDeferred, null=True)\n```\n", "Thanks for your reply! It solved my problem.\n\nI wasn't reading carefully that particular section of the docs because I don't have a circular dependency in the db. Instead, one module is imported late and that's why I'm using `DeferredRelation`.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/899/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "KrisSiegel", "id": 1885826, "node_id": "MDQ6VXNlcjE4ODU4MjY=", "avatar_url": "https://avatars.githubusercontent.com/u/1885826?v=4", "gravatar_id": "", "url": "https://api.github.com/users/KrisSiegel", "html_url": "https://github.com/KrisSiegel", "followers_url": "https://api.github.com/users/KrisSiegel/followers", "following_url": "https://api.github.com/users/KrisSiegel/following{/other_user}", "gists_url": "https://api.github.com/users/KrisSiegel/gists{/gist_id}", "starred_url": "https://api.github.com/users/KrisSiegel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KrisSiegel/subscriptions", "organizations_url": "https://api.github.com/users/KrisSiegel/orgs", "repos_url": "https://api.github.com/users/KrisSiegel/repos", "events_url": "https://api.github.com/users/KrisSiegel/events{/privacy}", "received_events_url": "https://api.github.com/users/KrisSiegel/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Yep, it's possible.\n\ne.g.:\n\n``` python\nSomeModel.select(fn.COALESCE(SomeModel.field_a, SomeModel.field_b).alias('the_value))\n```\n", "Thanks, didn't see that in the documentation anywhere.\n", "It's described here:\n\nhttp://docs.peewee-orm.com/en/latest/peewee/querying.html#sql-functions-subqueries-and-raw-expressions\n", "That doesn't actually mention coalesce only that you can _\"use arbitrary SQL functions\"_ but how do I know which functions are supported through PeeWee? Or do they _only_ map directly back to the database I have setup? For instance not every DB has ISNULL.\n\nIf the documentation was a little more clear either way it would be helpful. I think it would be nice to list all functions available across all databases versus what's available for individual ones. Or at least the verified working through PeeWee functions.\n", "Literally the third sentence:\n\n> To use arbitrary SQL functions, use the special fn() object to construct queries:\n\nYou can call literally any function, whether it exists or not. It's just syntactic sugar, read the code to get an understanding of how it works. You can nest calls to functions, you can do whatever.\n\n> I think it would be nice to list all functions available across all databases versus what's available for individual ones.\n\nThat's stupid. Why would I do that? Read your database documentation, no sense in duplicating it.\n", "> Literally the third sentence:\n\nYou and I both made reference to that passage and it doesn't address my specific statement so I'm not sure what you gain by reiterating a point we've both talked about. Regardless...\n\n> That's stupid. Why would I do that?\n\nSo my comment already addressed the why. But if you think the suggestion is stupid I can't tell if you just ignored my 'whys' or you want other 'whys' without addressing my original ones. Regardless this doesn't sound like a productive conversation so no need to continue it.\n", "The word _arbitrary_ means _any_ in the sentence I referenced. Meaning there's no need to duplicate other database vendors documentation since Peewee can call literally any function. The `fn` object creates a `Function` instance that the query compiler turns into a function call in SQL. Peewee doesn't have to know any more than that.\n", "@KrisSiegel \n\n> I think it would be nice to list all functions available across all databases versus what's available for individual ones.\n\nWhat about [personal functions](http://www.postgresql.org/docs/9.5/static/sql-createfunction.html)? ;-)\n", "FWIW I got here by googling \"peewee coalesce\". I started developing using Peewee without reading the docs end-to-end, so this issue helped me.", "@skatenerd, interestingly, we're just exactly a month apart in using this issue to figure out how to use a `COALESCE` in Peewee." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/898/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "maaaks", "id": 3010238, "node_id": "MDQ6VXNlcjMwMTAyMzg=", "avatar_url": "https://avatars.githubusercontent.com/u/3010238?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maaaks", "html_url": "https://github.com/maaaks", "followers_url": "https://api.github.com/users/maaaks/followers", "following_url": "https://api.github.com/users/maaaks/following{/other_user}", "gists_url": "https://api.github.com/users/maaaks/gists{/gist_id}", "starred_url": "https://api.github.com/users/maaaks/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maaaks/subscriptions", "organizations_url": "https://api.github.com/users/maaaks/orgs", "repos_url": "https://api.github.com/users/maaaks/repos", "events_url": "https://api.github.com/users/maaaks/events{/privacy}", "received_events_url": "https://api.github.com/users/maaaks/received_events", "type": "User", "site_admin": false }

[]

[]

[ "As far as I understand, [`generate_column_map()`](https://github.com/coleifer/peewee/blob/65dbfc5b3b406278df15d55bd48dbfc4ab6f7d6f/peewee.py#L2205) generates a list containing every field in every model mentioned in `select()`, in the same order as they are defined in classes. Can I consider this a defined behavior? If yes, does it mean that I can just inherit from `RawQuery` and somehow force it to use the [`AggregateQueryResultWrapper`](https://github.com/coleifer/peewee/blob/65dbfc5b3b406278df15d55bd48dbfc4ab6f7d6f/peewee.py#L2316) in order to use results of my own query, and that I _do not need_ to use some specific table aliases?\n", "No, it doesn't work because `AggregateQueryResultWrapper` also needs `_selects` and `_joins` fields which exist only in `SelectQuery` (and `RawQuery` is not a `SelectQuery`). :-(\n", "By the way, is there any way to add a custom field to a model in `RawQuery`? E.g. field named `level`, for walking through a recursive result.\n", "`RawQuery` does not support any fancy related-instance juju. It will simply patch all attributes returned by the cursor onto the model instance (or the dictionary or tuple if you're using .dicts() or .tuples()). There is not enough information available to peewee to generate the graph of joined models reliably.\n\nYou can, of course, write a wrapper that does the transformations you want.\n\nAlternatively you can use the regular SelectQuery type of query, which supports traversing the model graph to reconstruct joined instances.\n\nYes, you can add whatever attributes you want with both RawQuery and SelectQuery.\n\nFor example:\n\n``` python\nclass User(Model):\n username = CharField()\n\nusers = User.select(User.username, fn.LOWER(User.username).alias('all_lower_username'))\nfor user in users:\n print user.all_lower_username\n\nusers = User.raw('SELECT username, LOWER(username) AS all_lower_username FROM user')\n# same as above.\n```\n", "Please respond if the above did not address your question and I'll re-open to discuss further.\n", "> ``` sql\n> python = User.raw('SELECT username, LOWER(username) AS all_lower_username FROM user')\n> ```\n\nI don't understand where will the `all_lower_username` go here? Will it become available as `user.all_lower_username` or something?\n", "Yes, user.all_lower_username\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/897/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "asztalosdani", "id": 9664767, "node_id": "MDQ6VXNlcjk2NjQ3Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/9664767?v=4", "gravatar_id": "", "url": "https://api.github.com/users/asztalosdani", "html_url": "https://github.com/asztalosdani", "followers_url": "https://api.github.com/users/asztalosdani/followers", "following_url": "https://api.github.com/users/asztalosdani/following{/other_user}", "gists_url": "https://api.github.com/users/asztalosdani/gists{/gist_id}", "starred_url": "https://api.github.com/users/asztalosdani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/asztalosdani/subscriptions", "organizations_url": "https://api.github.com/users/asztalosdani/orgs", "repos_url": "https://api.github.com/users/asztalosdani/repos", "events_url": "https://api.github.com/users/asztalosdani/events{/privacy}", "received_events_url": "https://api.github.com/users/asztalosdani/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Actually, `PostgresqlDatabase` does call commit after every select query. How are you declaring / instantiating your database? What type of app is this?\n", "It's a QT app, working in Maya, connecting to DB to select the project, then the asset you will work on.\nPostgresqlDatabase was instanciated with autocommit=False. I changed it to True, now it seems to work.\nBut why is the select run in transaction?\n", "> was instanciated with autocommit=False\n\nThis.\n\nUnless you really understand Peewee's transaction management ID suggest using autocommit=True and using the provided `atomic` decorator/context manager when you want explicit transactions.\n", "But why is the select run in transaction?\r\n\r\n@coleifer can you answer this question?", "The `SELECT` is \"run in a transaction\" because queries are always run in transactions, it's just that in autocommit mode those transactions are only 1 query long. In \"autocommit\" there's a commit() after each query to avoid leaving open, idle transactions. See #806 and #727 for a little more background.\r\n\r\nI understand your question, but also bear in mind that when you're not within the scope of an explicit `atomic()` or `transaction()` block, then essentially each individual query you execute is going to be in its own transaction." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/896/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "maaaks", "id": 3010238, "node_id": "MDQ6VXNlcjMwMTAyMzg=", "avatar_url": "https://avatars.githubusercontent.com/u/3010238?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maaaks", "html_url": "https://github.com/maaaks", "followers_url": "https://api.github.com/users/maaaks/followers", "following_url": "https://api.github.com/users/maaaks/following{/other_user}", "gists_url": "https://api.github.com/users/maaaks/gists{/gist_id}", "starred_url": "https://api.github.com/users/maaaks/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maaaks/subscriptions", "organizations_url": "https://api.github.com/users/maaaks/orgs", "repos_url": "https://api.github.com/users/maaaks/repos", "events_url": "https://api.github.com/users/maaaks/events{/privacy}", "received_events_url": "https://api.github.com/users/maaaks/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Fixed, thanks for reporting.\n", "For what it's worth you can always set the actual foreign key field to an integer ID:\n\n``` python\nmodel.relatedmodel = 1\n```\n", "This is great. It always seemed odd to me to assign an integer to an attribute that really should be an object.\n\nDoes this change also allow creating and querying via the same identifiers? e.g.\n\n`Foo(relatedmodel_id=1)`\n\nor\n\n`Foo.select().where(Foo.relatedmodel_id == 1)`\n", "At the moment creation is supported, but for querying you will still need to use the foreign key field itself. And honestly, I don't think I'll change it.\n", "Ok thanks.\n\nSomewhat related: Is there any reason accessing a non-existent field doesn't issue an error/warning. I've spent a decent amount of time tracking down issues that end up being due to using an incorrect field name, e.g.:\n\n``` python\n# Incorrect\nUser.select().where(User.city_id == 1) # This looks valid to me, but will result in the wrong query (with no error/warning)\nUser.create(city_id=1) # This one works as of 2.8.1, but previously I'd end up scratching my head over why the city_id field wasn't getting set\n```\n", "That should raise an exception, I will reopen.\n", "Cool. Thanks! And just to clarify, the second case can still occur with other values, e.g.\n\n``` python\n# These \"work\", but I would expect an exception\nuser = User.create(non_existent_field=44)\nuser = User(non_existent_field=235)\n```\n", "I actually decided to go ahead and support querying on the `xxx_id` field.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/895/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "gitttt", "id": 9463528, "node_id": "MDQ6VXNlcjk0NjM1Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/9463528?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gitttt", "html_url": "https://github.com/gitttt", "followers_url": "https://api.github.com/users/gitttt/followers", "following_url": "https://api.github.com/users/gitttt/following{/other_user}", "gists_url": "https://api.github.com/users/gitttt/gists{/gist_id}", "starred_url": "https://api.github.com/users/gitttt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gitttt/subscriptions", "organizations_url": "https://api.github.com/users/gitttt/orgs", "repos_url": "https://api.github.com/users/gitttt/repos", "events_url": "https://api.github.com/users/gitttt/events{/privacy}", "received_events_url": "https://api.github.com/users/gitttt/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Wow, I'm not sure how to advise you, I'd suggest consulting the MySQL documentation and if that doesn't help, seeing about reaching out on whatever support channels they have...or StackOverflow?\n\nIf you want to do a LONGBLOB field in peewee, you'll need to add a custom field type for it as blob fields correspond to plain old \"BLOB\" columns in MySQL. Your code would look like:\n\n``` python\nclass LongBlobField(BlobField):\n db_field = 'longblob'\n\ndb = MySQLDatabase('my_db', fields={'longblob': 'LONGBLOB'})\n```\n\nYou might also consider storing the blobs externally on the filesystem -- some databases aren't optimized for storing massive values in every row.\n\nRegarding postgres, again you should consult their docs.\n", "Thanks for the code snipped. Seems to work nicely for me.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/894/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "lneoe", "id": 2282449, "node_id": "MDQ6VXNlcjIyODI0NDk=", "avatar_url": "https://avatars.githubusercontent.com/u/2282449?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lneoe", "html_url": "https://github.com/lneoe", "followers_url": "https://api.github.com/users/lneoe/followers", "following_url": "https://api.github.com/users/lneoe/following{/other_user}", "gists_url": "https://api.github.com/users/lneoe/gists{/gist_id}", "starred_url": "https://api.github.com/users/lneoe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lneoe/subscriptions", "organizations_url": "https://api.github.com/users/lneoe/orgs", "repos_url": "https://api.github.com/users/lneoe/repos", "events_url": "https://api.github.com/users/lneoe/events{/privacy}", "received_events_url": "https://api.github.com/users/lneoe/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks, I've committed equivalent patch with a testcase. I appreciate this fix!!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/893/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/893", "html_url": "https://github.com/coleifer/peewee/pull/893", "diff_url": "https://github.com/coleifer/peewee/pull/893.diff", "patch_url": "https://github.com/coleifer/peewee/pull/893.patch", "merged_at": null }

{ "login": "Neotric", "id": 17950579, "node_id": "MDQ6VXNlcjE3OTUwNTc5", "avatar_url": "https://avatars.githubusercontent.com/u/17950579?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Neotric", "html_url": "https://github.com/Neotric", "followers_url": "https://api.github.com/users/Neotric/followers", "following_url": "https://api.github.com/users/Neotric/following{/other_user}", "gists_url": "https://api.github.com/users/Neotric/gists{/gist_id}", "starred_url": "https://api.github.com/users/Neotric/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Neotric/subscriptions", "organizations_url": "https://api.github.com/users/Neotric/orgs", "repos_url": "https://api.github.com/users/Neotric/repos", "events_url": "https://api.github.com/users/Neotric/events{/privacy}", "received_events_url": "https://api.github.com/users/Neotric/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I am positive there is a bug in your code somewhere. I'd suggest posting on stackoverflow and INCLUDE YOUR MODEL DEFINITION and code you're using to create the table. That'll help get the problem fixed the fastest.\n\nThis page is for tracking bugs with peewee and creating tables is covered extensively by tests.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/892/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kiddten", "id": 9250239, "node_id": "MDQ6VXNlcjkyNTAyMzk=", "avatar_url": "https://avatars.githubusercontent.com/u/9250239?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kiddten", "html_url": "https://github.com/kiddten", "followers_url": "https://api.github.com/users/kiddten/followers", "following_url": "https://api.github.com/users/kiddten/following{/other_user}", "gists_url": "https://api.github.com/users/kiddten/gists{/gist_id}", "starred_url": "https://api.github.com/users/kiddten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kiddten/subscriptions", "organizations_url": "https://api.github.com/users/kiddten/orgs", "repos_url": "https://api.github.com/users/kiddten/repos", "events_url": "https://api.github.com/users/kiddten/events{/privacy}", "received_events_url": "https://api.github.com/users/kiddten/received_events", "type": "User", "site_admin": false }

[]

[]

[ "No, it's not better. It's just that you think it's better.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/891/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kramer65", "id": 596581, "node_id": "MDQ6VXNlcjU5NjU4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/596581?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kramer65", "html_url": "https://github.com/kramer65", "followers_url": "https://api.github.com/users/kramer65/followers", "following_url": "https://api.github.com/users/kramer65/following{/other_user}", "gists_url": "https://api.github.com/users/kramer65/gists{/gist_id}", "starred_url": "https://api.github.com/users/kramer65/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kramer65/subscriptions", "organizations_url": "https://api.github.com/users/kramer65/orgs", "repos_url": "https://api.github.com/users/kramer65/repos", "events_url": "https://api.github.com/users/kramer65/events{/privacy}", "received_events_url": "https://api.github.com/users/kramer65/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This is neat, but I think it would be more appropriate as a separate library. There are quite a few opinions in this code, and I prefer to keep the playhouse stuff a bit more generic than this module.\n\nBe happy to add a link in the docs if you end up releasing it as a library.\n", "@coleifer \n\nThanks for your response. releasing it as a separate lib would be fine as well. \n\nRegarding the \"opinions\" in this code, I would really appreciate _your_ opinions and remarks for improvement on this code. Are there any areas that can be changed which could make the usage of this code more intuitive/pythonic for programmers? \n\nAll tips are welcome!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/890/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "fraba", "id": 4167193, "node_id": "MDQ6VXNlcjQxNjcxOTM=", "avatar_url": "https://avatars.githubusercontent.com/u/4167193?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fraba", "html_url": "https://github.com/fraba", "followers_url": "https://api.github.com/users/fraba/followers", "following_url": "https://api.github.com/users/fraba/following{/other_user}", "gists_url": "https://api.github.com/users/fraba/gists{/gist_id}", "starred_url": "https://api.github.com/users/fraba/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fraba/subscriptions", "organizations_url": "https://api.github.com/users/fraba/orgs", "repos_url": "https://api.github.com/users/fraba/repos", "events_url": "https://api.github.com/users/fraba/events{/privacy}", "received_events_url": "https://api.github.com/users/fraba/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This error is coming from the MySQL driver so I suspect that peewee isn't the issue... But.\n\nDoes peewee need to run any special queries before the create table query?\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/889/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "maaaks", "id": 3010238, "node_id": "MDQ6VXNlcjMwMTAyMzg=", "avatar_url": "https://avatars.githubusercontent.com/u/3010238?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maaaks", "html_url": "https://github.com/maaaks", "followers_url": "https://api.github.com/users/maaaks/followers", "following_url": "https://api.github.com/users/maaaks/following{/other_user}", "gists_url": "https://api.github.com/users/maaaks/gists{/gist_id}", "starred_url": "https://api.github.com/users/maaaks/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maaaks/subscriptions", "organizations_url": "https://api.github.com/users/maaaks/orgs", "repos_url": "https://api.github.com/users/maaaks/repos", "events_url": "https://api.github.com/users/maaaks/events{/privacy}", "received_events_url": "https://api.github.com/users/maaaks/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You have a couple options, as described in the docs:\n\nhttp://docs.peewee-orm.com/en/latest/peewee/querying.html#avoiding-n-1-queries\n\nUse prefetch (my recommendation). This will run 4 queries (one for each table). Duplicates are not fetched, so there is no de-duping required.\n\n``` python\nhosted = HostedSite.select().where(HostedSite.domain == domain)\npages = HostedSitePage.select().order_by(HostedSitePage.order_num)\nsites = prefetch(hosted, pages, HostedSitePageToType, ObjectType)\nsite = sites.first()\n\nprint site.domain\n# The backref here is whatever the default backref is + '_prefetch':\nfor page in site.pages_prefetch:\n print ' - ' + page.title\n for page_to_type in page.hostedsitepagetotype_set_prefetch:\n print ' - ' + page_to_type.object_type.table_name\n```\n\nUse `aggregate_rows()`. This requires de-duping in Python. Check the [docs here](http://docs.peewee-orm.com/en/latest/peewee/querying.html#using-aggregate-rows) and scroll down to read the \"Some things to consider when using aggregate_rows():\" section.\n\n``` python\n# Note that we specify ordering for the first 3 tables. This is necessary due to the way\n# \"aggregate_rows\" progressively de-dupes data.\nsites = (HostedSite\n .select(HostedSite, HostedSitePage, HostedSitePageToType, ObjectType)\n .join(HostedSitePage, join_type=JOIN_LEFT_OUTER)\n .join(HostedSitePageToType, join_type=JOIN_LEFT_OUTER)\n .join(ObjectType, join_type=JOIN_LEFT_OUTER)\n .where(HostedSite.domain == domain)\n .order_by(HostedSite.domain, HostedSitePage.order_num, HostedSitePageToType.page))\nsite = sites.first()\n\nprint site.domain\n# Use the normal backref names.\nfor page in site.pages:\n print ' - ' + page.title\n for page_to_type in page.hostedsitepagetotype_set:\n print ' - ' + page_to_type.object_type.table_name\n```\n", "Thank you, `aggregate_rows()` seems to work.\n\nBtw, my `HostedSitePageToType` is a «through» table for the `ManyToManyField`. And it seems to be impossible to load this relationship eagerly.\n\n``` python\nHostedSitePage_Deferred = DeferredRelation()\n\nclass HostedSitePageToType(BaseModel):\n class Meta:\n db_table = \"hosted_site_page_to_type\"\n primary_key = False\n\n page = ForeignKeyField(HostedSitePage_Deferred)\n type = ForeignKeyField(ObjectType)\n\nclass HostedSitePage(BaseModel):\n class Meta:\n db_table = \"hosted_site_page\"\n\n id = PrimaryKeyField()\n path = CharField()\n title = CharField()\n text = TextField()\n order_num = IntegerField()\n\n site = ForeignKeyField(HostedSite, related_name=\"pages\")\n \"\"\" :type : HostedSite \"\"\"\n\n object_types = ManyToManyField(ObjectType, through_model=HostedSitePageToType)\n \"\"\" :type : List[ObjectType] \"\"\"\n\nHostedSitePage_Deferred.set_model(HostedSitePage)\n```\n\n> AttributeError: 'bool' object has no attribute 'name'\n", "Ohh... Now I tried to do the whole thing without `ManyToManyField`, and as far as I understand, Peewee doesn't support tables with `primary_key = False` id they are not the «through» tables?\n", "Yeah, everything works!\nSo, I stopped using `ManyToManyField`, instead I manually join table for the relationship.\n\n``` python\nclass HostedSitePage(BaseModel):\n class Meta:\n db_table = \"hosted_site_page\"\n\n id = PrimaryKeyField()\n path = CharField()\n title = CharField()\n text = TextField()\n order_num = IntegerField()\n\n site = ForeignKeyField(HostedSite, related_name=\"pages\")\n\n def object_types(self) -> List[ObjectType]:\n return [ptt.type for ptt in self._pagetotype_rels]\n\nclass HostedSitePageToType(BaseModel):\n class Meta:\n db_table = \"hosted_site_page_to_type\"\n primary_key = CompositeKey('page', 'type')\n\n page = ForeignKeyField(HostedSitePage, related_name=\"_pagetotype_rels\")\n type = ForeignKeyField(ObjectType)\n```\n", "You really should measure the performance of aggregate_rows vs prefetch....in every test I've done prefetch was faster. Aggregate rows can end up duplicating a ton of data, so if your db is on a network that's a lot of traffic.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/888/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "indoorwise", "id": 8873448, "node_id": "MDQ6VXNlcjg4NzM0NDg=", "avatar_url": "https://avatars.githubusercontent.com/u/8873448?v=4", "gravatar_id": "", "url": "https://api.github.com/users/indoorwise", "html_url": "https://github.com/indoorwise", "followers_url": "https://api.github.com/users/indoorwise/followers", "following_url": "https://api.github.com/users/indoorwise/following{/other_user}", "gists_url": "https://api.github.com/users/indoorwise/gists{/gist_id}", "starred_url": "https://api.github.com/users/indoorwise/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/indoorwise/subscriptions", "organizations_url": "https://api.github.com/users/indoorwise/orgs", "repos_url": "https://api.github.com/users/indoorwise/repos", "events_url": "https://api.github.com/users/indoorwise/events{/privacy}", "received_events_url": "https://api.github.com/users/indoorwise/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I am not sure, but my guess is no. If you want some inspiration about implementing Peewee with event loops, check out https://github.com/05bit/peewee-async/blob/master/peewee_async.py\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/887/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tarot231", "id": 17806922, "node_id": "MDQ6VXNlcjE3ODA2OTIy", "avatar_url": "https://avatars.githubusercontent.com/u/17806922?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tarot231", "html_url": "https://github.com/tarot231", "followers_url": "https://api.github.com/users/tarot231/followers", "following_url": "https://api.github.com/users/tarot231/following{/other_user}", "gists_url": "https://api.github.com/users/tarot231/gists{/gist_id}", "starred_url": "https://api.github.com/users/tarot231/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tarot231/subscriptions", "organizations_url": "https://api.github.com/users/tarot231/orgs", "repos_url": "https://api.github.com/users/tarot231/repos", "events_url": "https://api.github.com/users/tarot231/events{/privacy}", "received_events_url": "https://api.github.com/users/tarot231/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you, fixed.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/886/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "alexpantyukhin", "id": 6513121, "node_id": "MDQ6VXNlcjY1MTMxMjE=", "avatar_url": "https://avatars.githubusercontent.com/u/6513121?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alexpantyukhin", "html_url": "https://github.com/alexpantyukhin", "followers_url": "https://api.github.com/users/alexpantyukhin/followers", "following_url": "https://api.github.com/users/alexpantyukhin/following{/other_user}", "gists_url": "https://api.github.com/users/alexpantyukhin/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexpantyukhin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexpantyukhin/subscriptions", "organizations_url": "https://api.github.com/users/alexpantyukhin/orgs", "repos_url": "https://api.github.com/users/alexpantyukhin/repos", "events_url": "https://api.github.com/users/alexpantyukhin/events{/privacy}", "received_events_url": "https://api.github.com/users/alexpantyukhin/received_events", "type": "User", "site_admin": false }

[]

[]

[ "But `model_to_dict` doesn't do any json serialization?\n", "Sorry. found the reason it was another\n", "alexpantyukhin , what was the reason? I am having the same problem.\n", "model_to_dict returns a dict, not a JSON object, so I'm not sure what the confusion is about.\n", "Sorry, model_to_dict is working as expected. I am making a confusion here.\nI am trying to use json.dumps in a dictionary returned by model_to_dict, and it is failing (as expected).\nThe solution is not related to peewee code. \nSorry for this unnecessary message!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/885/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "daoiqi", "id": 2141872, "node_id": "MDQ6VXNlcjIxNDE4NzI=", "avatar_url": "https://avatars.githubusercontent.com/u/2141872?v=4", "gravatar_id": "", "url": "https://api.github.com/users/daoiqi", "html_url": "https://github.com/daoiqi", "followers_url": "https://api.github.com/users/daoiqi/followers", "following_url": "https://api.github.com/users/daoiqi/following{/other_user}", "gists_url": "https://api.github.com/users/daoiqi/gists{/gist_id}", "starred_url": "https://api.github.com/users/daoiqi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/daoiqi/subscriptions", "organizations_url": "https://api.github.com/users/daoiqi/orgs", "repos_url": "https://api.github.com/users/daoiqi/repos", "events_url": "https://api.github.com/users/daoiqi/events{/privacy}", "received_events_url": "https://api.github.com/users/daoiqi/received_events", "type": "User", "site_admin": false }

[]

[]

[ "use `wrapped_count()`\n\nhttp://docs.peewee-orm.com/en/latest/peewee/api.html#SelectQuery.wrapped_count\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/884/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "brijeshb42", "id": 717550, "node_id": "MDQ6VXNlcjcxNzU1MA==", "avatar_url": "https://avatars.githubusercontent.com/u/717550?v=4", "gravatar_id": "", "url": "https://api.github.com/users/brijeshb42", "html_url": "https://github.com/brijeshb42", "followers_url": "https://api.github.com/users/brijeshb42/followers", "following_url": "https://api.github.com/users/brijeshb42/following{/other_user}", "gists_url": "https://api.github.com/users/brijeshb42/gists{/gist_id}", "starred_url": "https://api.github.com/users/brijeshb42/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/brijeshb42/subscriptions", "organizations_url": "https://api.github.com/users/brijeshb42/orgs", "repos_url": "https://api.github.com/users/brijeshb42/repos", "events_url": "https://api.github.com/users/brijeshb42/events{/privacy}", "received_events_url": "https://api.github.com/users/brijeshb42/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This type of question is not really appropriate for the peewee issue tracker.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/883/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "samizdis", "id": 11559853, "node_id": "MDQ6VXNlcjExNTU5ODUz", "avatar_url": "https://avatars.githubusercontent.com/u/11559853?v=4", "gravatar_id": "", "url": "https://api.github.com/users/samizdis", "html_url": "https://github.com/samizdis", "followers_url": "https://api.github.com/users/samizdis/followers", "following_url": "https://api.github.com/users/samizdis/following{/other_user}", "gists_url": "https://api.github.com/users/samizdis/gists{/gist_id}", "starred_url": "https://api.github.com/users/samizdis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/samizdis/subscriptions", "organizations_url": "https://api.github.com/users/samizdis/orgs", "repos_url": "https://api.github.com/users/samizdis/repos", "events_url": "https://api.github.com/users/samizdis/events{/privacy}", "received_events_url": "https://api.github.com/users/samizdis/received_events", "type": "User", "site_admin": false }

[]

[]

[ "One way to accomplish the \"posts without badtag\" might be:\n\n``` python\n(Post\n .select()\n .where(~fn.EXISTS(\n Tag.select().where(\n (Tag.post == Post.id) & (Tag.name == 'BadTag'))))\n```\n\nAnother might be:\n\n``` python\n(Post\n .select(Post, fn.COUNT(Tag.id))\n .join(Tag, JOIN.LEFT_OUTER)\n .where(Tag.name == 'BadTag')\n .group_by(Post)\n .having(fn.COUNT(Tag.id) == 0))\n```\n\nI didn't test these examples, but hopefully you get the idea.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/882/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bukun", "id": 6925146, "node_id": "MDQ6VXNlcjY5MjUxNDY=", "avatar_url": "https://avatars.githubusercontent.com/u/6925146?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bukun", "html_url": "https://github.com/bukun", "followers_url": "https://api.github.com/users/bukun/followers", "following_url": "https://api.github.com/users/bukun/following{/other_user}", "gists_url": "https://api.github.com/users/bukun/gists{/gist_id}", "starred_url": "https://api.github.com/users/bukun/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bukun/subscriptions", "organizations_url": "https://api.github.com/users/bukun/orgs", "repos_url": "https://api.github.com/users/bukun/repos", "events_url": "https://api.github.com/users/bukun/events{/privacy}", "received_events_url": "https://api.github.com/users/bukun/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I have tried with Python 2.7 and Python 3.5.\n", "Are you absolutely positive that your model class is using `PostgresqlExtDatabase` as it's database class?\n", "Greate! thanks very much. I have tried several time, and could not find any information with google.\nshould be:\n\n```\nfrom playhouse.postgres_ext import PostgresqlExtDatabase\ndbconnect = PostgresqlExtDatabase(\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/881/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "poliquin", "id": 360123, "node_id": "MDQ6VXNlcjM2MDEyMw==", "avatar_url": "https://avatars.githubusercontent.com/u/360123?v=4", "gravatar_id": "", "url": "https://api.github.com/users/poliquin", "html_url": "https://github.com/poliquin", "followers_url": "https://api.github.com/users/poliquin/followers", "following_url": "https://api.github.com/users/poliquin/following{/other_user}", "gists_url": "https://api.github.com/users/poliquin/gists{/gist_id}", "starred_url": "https://api.github.com/users/poliquin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/poliquin/subscriptions", "organizations_url": "https://api.github.com/users/poliquin/orgs", "repos_url": "https://api.github.com/users/poliquin/repos", "events_url": "https://api.github.com/users/poliquin/events{/privacy}", "received_events_url": "https://api.github.com/users/poliquin/received_events", "type": "User", "site_admin": false }

[]

[]

[ "> Is there a reason for Model.create to ignore \"extra\" keyword arguments and for Model.insert to throw an error?\n\nIt's just an oversight on my part. At present, I am not inclined to change this as people may have code that relies on the behavior of `create()`. Additionally, `create()` is a bit semantically different than `insert()`....so I think I'm going to leave this as wontfix.\n", "> I prefer the behavior of ignoring keys without corresponding model fields\n\nOut of curiosity, @poliquin, what is your use case for that feature? I always thought I prefer the opposite and rather throw an error when trying to assign values to non-existent fields.\n", "@tuukkamustonen, I find it useful when processing messy CSV data with fields that change slightly from file to file and have many uninteresting columns. I frequently encounter data like this from government sources. I read all data with `csv.DictReader`, transform fields to have consistent names matching my schema (e.g. lowercase, no spaces, ....), then simply pass the keyword arguments to `Model.create` with the `**` syntax. The stuff I want gets loaded, and the junk is ignored.\n\nI definitely see the logic in throwing errors when encountering unexpected inputs, however, which is probably why the default `csv.DictWriter` behavior is `extrasaction='raise'`.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/880/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kramer65", "id": 596581, "node_id": "MDQ6VXNlcjU5NjU4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/596581?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kramer65", "html_url": "https://github.com/kramer65", "followers_url": "https://api.github.com/users/kramer65/followers", "following_url": "https://api.github.com/users/kramer65/following{/other_user}", "gists_url": "https://api.github.com/users/kramer65/gists{/gist_id}", "starred_url": "https://api.github.com/users/kramer65/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kramer65/subscriptions", "organizations_url": "https://api.github.com/users/kramer65/orgs", "repos_url": "https://api.github.com/users/kramer65/repos", "events_url": "https://api.github.com/users/kramer65/events{/privacy}", "received_events_url": "https://api.github.com/users/kramer65/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/879/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ameade", "id": 847570, "node_id": "MDQ6VXNlcjg0NzU3MA==", "avatar_url": "https://avatars.githubusercontent.com/u/847570?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ameade", "html_url": "https://github.com/ameade", "followers_url": "https://api.github.com/users/ameade/followers", "following_url": "https://api.github.com/users/ameade/following{/other_user}", "gists_url": "https://api.github.com/users/ameade/gists{/gist_id}", "starred_url": "https://api.github.com/users/ameade/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ameade/subscriptions", "organizations_url": "https://api.github.com/users/ameade/orgs", "repos_url": "https://api.github.com/users/ameade/repos", "events_url": "https://api.github.com/users/ameade/events{/privacy}", "received_events_url": "https://api.github.com/users/ameade/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/878/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "stanep", "id": 3240661, "node_id": "MDQ6VXNlcjMyNDA2NjE=", "avatar_url": "https://avatars.githubusercontent.com/u/3240661?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stanep", "html_url": "https://github.com/stanep", "followers_url": "https://api.github.com/users/stanep/followers", "following_url": "https://api.github.com/users/stanep/following{/other_user}", "gists_url": "https://api.github.com/users/stanep/gists{/gist_id}", "starred_url": "https://api.github.com/users/stanep/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stanep/subscriptions", "organizations_url": "https://api.github.com/users/stanep/orgs", "repos_url": "https://api.github.com/users/stanep/repos", "events_url": "https://api.github.com/users/stanep/events{/privacy}", "received_events_url": "https://api.github.com/users/stanep/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Just pass `use_speedups=False` when you are instantiating your Database object. That should address the issue. Peewee implements some cursor iteration helpers in Cython and expects the rows to be tuples, hence the issue you're seeing.\n\nLet me know if the above fix addresses the problem.\n", "Yes this fix the problem, thx\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/877/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "IxDay", "id": 2128384, "node_id": "MDQ6VXNlcjIxMjgzODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/2128384?v=4", "gravatar_id": "", "url": "https://api.github.com/users/IxDay", "html_url": "https://github.com/IxDay", "followers_url": "https://api.github.com/users/IxDay/followers", "following_url": "https://api.github.com/users/IxDay/following{/other_user}", "gists_url": "https://api.github.com/users/IxDay/gists{/gist_id}", "starred_url": "https://api.github.com/users/IxDay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/IxDay/subscriptions", "organizations_url": "https://api.github.com/users/IxDay/orgs", "repos_url": "https://api.github.com/users/IxDay/repos", "events_url": "https://api.github.com/users/IxDay/events{/privacy}", "received_events_url": "https://api.github.com/users/IxDay/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This is fixed by 2fca64c482f536f280303a77fe8e9c040a0c96b3\n\nTo indicate that there should be no index, simply specify `index=False` when instantiating your `ArrayField`.\n", "(the same goes for any other field that mixes in `IndexedFieldMixin`.)\n", "Great thanks !\n", "Thanks for reporting the issue, I appreciate it!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/876/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "IxDay", "id": 2128384, "node_id": "MDQ6VXNlcjIxMjgzODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/2128384?v=4", "gravatar_id": "", "url": "https://api.github.com/users/IxDay", "html_url": "https://github.com/IxDay", "followers_url": "https://api.github.com/users/IxDay/followers", "following_url": "https://api.github.com/users/IxDay/following{/other_user}", "gists_url": "https://api.github.com/users/IxDay/gists{/gist_id}", "starred_url": "https://api.github.com/users/IxDay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/IxDay/subscriptions", "organizations_url": "https://api.github.com/users/IxDay/orgs", "repos_url": "https://api.github.com/users/IxDay/repos", "events_url": "https://api.github.com/users/IxDay/events{/privacy}", "received_events_url": "https://api.github.com/users/IxDay/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Unfortunately, you'll need to call `register_fields` to use custom types:\n\n``` python\nclass DirectionField(...):\n db_type = 'direction'\n\nPostgresqlDatabase.register_fields({\n 'direction': 'direction',\n})\n```\n\nHope to get rid/clean-up that boiler plate in a later version of peewee but for now it is required.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/875/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "cryzed", "id": 1429103, "node_id": "MDQ6VXNlcjE0MjkxMDM=", "avatar_url": "https://avatars.githubusercontent.com/u/1429103?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cryzed", "html_url": "https://github.com/cryzed", "followers_url": "https://api.github.com/users/cryzed/followers", "following_url": "https://api.github.com/users/cryzed/following{/other_user}", "gists_url": "https://api.github.com/users/cryzed/gists{/gist_id}", "starred_url": "https://api.github.com/users/cryzed/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cryzed/subscriptions", "organizations_url": "https://api.github.com/users/cryzed/orgs", "repos_url": "https://api.github.com/users/cryzed/repos", "events_url": "https://api.github.com/users/cryzed/events{/privacy}", "received_events_url": "https://api.github.com/users/cryzed/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm almost sure I fixed the problem [here](https://github.com/cryzed/Feedbuffer/commit/3b29434de92c8d0c47b90761858239ee1df08cd8). I'm just speculating, but I think the problem arose because I created the CherryPy server object in a [different thread](https://github.com/cryzed/Feedbuffer/commit/3b29434de92c8d0c47b90761858239ee1df08cd8#diff-5bc02cefb3ea9e27f1a6776eabd1935dL20) (main thread) instead of within the spawned thread. I also had to change the generator expression [here](https://github.com/cryzed/Feedbuffer/commit/3b29434de92c8d0c47b90761858239ee1df08cd8#diff-91c7a2706bca60a3f59aefad6b396b0eL32).\n\nNow everything works without issues and it's reproducible -- reverting those changes leads to the aforementioned problems again and even slows everything down considerably. In the end I think it might be, because I am passing objects not local to the thread around, but I'd be lying if I said that I knew exactly what's going on. Maybe you have some input?\n\nThanks for peewee,\nChris\n", "I'm not sure about your application or anything specifically you may be encountering, but what I can tell you is:\n- sqlite enforces a _global database lock_ when you write to the db.\n- multi-threaded apps need to be careful about serializing writes or correctly handling \"busy\" errors.\n- using peewee with threadsafe=True is the default for a long time. all it means is you get a connection per thread, but those threads/connections can still contend for write locks.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/874/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Gagaro", "id": 3845486, "node_id": "MDQ6VXNlcjM4NDU0ODY=", "avatar_url": "https://avatars.githubusercontent.com/u/3845486?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Gagaro", "html_url": "https://github.com/Gagaro", "followers_url": "https://api.github.com/users/Gagaro/followers", "following_url": "https://api.github.com/users/Gagaro/following{/other_user}", "gists_url": "https://api.github.com/users/Gagaro/gists{/gist_id}", "starred_url": "https://api.github.com/users/Gagaro/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Gagaro/subscriptions", "organizations_url": "https://api.github.com/users/Gagaro/orgs", "repos_url": "https://api.github.com/users/Gagaro/repos", "events_url": "https://api.github.com/users/Gagaro/events{/privacy}", "received_events_url": "https://api.github.com/users/Gagaro/received_events", "type": "User", "site_admin": false }

[]

[]

[ "It creates an exception (or savepoint, if a transaction is present) to ensure the connection can be restored to a good state after an IntegrityError. Postgres, for instance, is rather unforgiving regarding this.\n\nI'll add something to the docs, but for now I don't really see this as a bug.\n", "In your example code, is there a reason you're not using the `atomic()` context manager / decorator? The `atomic()` helper will manage a stack of transactions/savepoints behind-the-scenes.\n", "> In your example code, is there a reason you're not using the atomic() context manager / decorator?\n\nI was reproducing my use case. It indeed works with atomic, but I can't use it for what I want to do.\n\nShouldn't atomic then also create a savepoint rather than create a new transaction when inside a begin ?\n", "So I was able to have something working with the following:\n\n``` python\nself._transaction = db.transaction()\nself._transaction.__enter__()\n# [...]\nself._transaction.__exit__(True, None, None)\n```\n\nIt isn't very intuitive though.\n", "Yeah, atomic will create a savepoint if there is a transaction in progress.\n\nYou can write your own `get_or_create()` that doesn't use a transaction/savepoint. Or you can use a decorator/context manager to manage your explicit transactions.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/873/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "mox1", "id": 6137131, "node_id": "MDQ6VXNlcjYxMzcxMzE=", "avatar_url": "https://avatars.githubusercontent.com/u/6137131?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mox1", "html_url": "https://github.com/mox1", "followers_url": "https://api.github.com/users/mox1/followers", "following_url": "https://api.github.com/users/mox1/following{/other_user}", "gists_url": "https://api.github.com/users/mox1/gists{/gist_id}", "starred_url": "https://api.github.com/users/mox1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mox1/subscriptions", "organizations_url": "https://api.github.com/users/mox1/orgs", "repos_url": "https://api.github.com/users/mox1/repos", "events_url": "https://api.github.com/users/mox1/events{/privacy}", "received_events_url": "https://api.github.com/users/mox1/received_events", "type": "User", "site_admin": false }

[]

[]

[ "0e055df5317e9966831b760a5a2aa8990f759207\n", "Thank you for the excellent bug report, this should now be fixed.\n", "You may need to update your apsw version, because in the latest versions it _does_ support `fetchone()`. I had to revert my commit that fixed the issue, due to MySQL python driver not implementing the iterator protocol on its cursor... Anyways, just try upgrading apsw and you should be set!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/872/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "foxx", "id": 651797, "node_id": "MDQ6VXNlcjY1MTc5Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/651797?v=4", "gravatar_id": "", "url": "https://api.github.com/users/foxx", "html_url": "https://github.com/foxx", "followers_url": "https://api.github.com/users/foxx/followers", "following_url": "https://api.github.com/users/foxx/following{/other_user}", "gists_url": "https://api.github.com/users/foxx/gists{/gist_id}", "starred_url": "https://api.github.com/users/foxx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/foxx/subscriptions", "organizations_url": "https://api.github.com/users/foxx/orgs", "repos_url": "https://api.github.com/users/foxx/repos", "events_url": "https://api.github.com/users/foxx/events{/privacy}", "received_events_url": "https://api.github.com/users/foxx/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm not quite sure I understand... what's going on here?\n", "Sorry here's an exact code snippet to reproduce the problem with `pymysql` and `python 2.7.11`.\n\nThe same code works as expected with `sqlite` and `postgres`.\n\n``` python\nfrom peewee import BlobField, Model\nfrom playhouse.db_url import connect\n\ndb = connect('mysql://[email protected]/peewee_test')\n\nclass ExampleModel(Model):\n class Meta:\n database = db\n value = BlobField()\n\nExampleModel.drop_table()\nExampleModel.create_table()\nExampleModel.create(value='1234')\n```\n\nResult;\n\n```\n$ python hello.py\nTraceback (most recent call last):\n File \"hello.py\", line 13, in <module>\n ExampleModel.create(value='1234')\n File \"/home/vagrant/.pyenv/versions/2.7.11/lib/python2.7/site-packages/peewee.py\", line 4494, in create\n inst.save(force_insert=True)\n File \"/home/vagrant/.pyenv/versions/2.7.11/lib/python2.7/site-packages/peewee.py\", line 4680, in save\n pk_from_cursor = self.insert(**field_dict).execute()\n File \"/home/vagrant/.pyenv/versions/2.7.11/lib/python2.7/site-packages/peewee.py\", line 3213, in execute\n cursor = self._execute()\n File \"/home/vagrant/.pyenv/versions/2.7.11/lib/python2.7/site-packages/peewee.py\", line 2628, in _execute\n return self.database.execute_sql(sql, params, self.require_commit)\n File \"/home/vagrant/.pyenv/versions/2.7.11/lib/python2.7/site-packages/peewee.py\", line 3454, in execute_sql\n cursor.execute(sql, params or ())\n File \"/home/vagrant/.pyenv/versions/2.7.11/lib/python2.7/site-packages/pymysql/cursors.py\", line 156, in execute\n query = self.mogrify(query, args)\n File \"/home/vagrant/.pyenv/versions/2.7.11/lib/python2.7/site-packages/pymysql/cursors.py\", line 135, in mogrify\n query = query % self._escape_args(args, conn)\n File \"/home/vagrant/.pyenv/versions/2.7.11/lib/python2.7/site-packages/pymysql/cursors.py\", line 110, in _escape_args\n return tuple(conn.escape(arg) for arg in args)\n File \"/home/vagrant/.pyenv/versions/2.7.11/lib/python2.7/site-packages/pymysql/cursors.py\", line 110, in <genexpr>\n return tuple(conn.escape(arg) for arg in args)\n File \"/home/vagrant/.pyenv/versions/2.7.11/lib/python2.7/site-packages/pymysql/connections.py\", line 781, in escape\n return escape_item(obj, self.charset, mapping=mapping)\n File \"/home/vagrant/.pyenv/versions/2.7.11/lib/python2.7/site-packages/pymysql/converters.py\", line 26, in escape_item\n val = encoder(val, mapping)\n File \"/home/vagrant/.pyenv/versions/2.7.11/lib/python2.7/site-packages/pymysql/converters.py\", line 109, in escape_unicode\n return u\"'%s'\" % _escape_unicode(value)\n File \"/home/vagrant/.pyenv/versions/2.7.11/lib/python2.7/site-packages/pymysql/converters.py\", line 72, in _escape_unicode\n return value.translate(_escape_table)\nAttributeError: 'buffer' object has no attribute 'translate'\n```\n", "This should be fixed. The `BlobField` will now use the database-drivers `Binary` column type.\n\nb32e967e933c0d9d029f3385a5a115c46beacd03\n", "Awesome, I'll let you know if I run into any problems, thanks for the quick response!\n", "I am getting a similar error:\n\n```\n/vagrant/data/ida_generate_trace.py: 'buffer' object has no attribute 'translate'\n\nFile \"/vagrant/data/trace_to_db.py\", line 59, in add_initial_memory_areas_to_trace\n peewee_memory_area.save()\n File \"/opt/Python2.7-32bit/lib/python2.7/site-packages/peewee.py\", line 4680, in save\n pk_from_cursor = self.insert(**field_dict).execute()\n File \"/opt/Python2.7-32bit/lib/python2.7/site-packages/peewee.py\", line 3213, in execute\n cursor = self._execute()\n File \"/opt/Python2.7-32bit/lib/python2.7/site-packages/peewee.py\", line 2628, in _execute\n return self.database.execute_sql(sql, params, self.require_commit)\n```\n\nThe memory area looks like this:\n\n```\nclass MemoryArea(Model):\n trace = ForeignKeyField(Trace, related_name='initial_memory_areas')\n start_addr = BigIntegerField()\n size = BigIntegerField()\n memory_content = BlobField(null=True)\n\n class Meta:\n database = db\n```\n\nI am using `MySQLDatabase`.\n\nIs this the same issue? I installed peewee via pip. It says version \n\n> 2.8.0\n", "BTW: If I change the db to `SqliteDatabase`, I am getting a different error\n\n```\n/vagrant/data/ida_generate_trace.py: Python int too large to convert to SQLite INTEGER\nTraceback (most recent call last):\n [...]\n peewee_memory_area.save()\n File \"/opt/Python2.7-32bit/lib/python2.7/site-packages/peewee.py\", line 4680, in save\n pk_from_cursor = self.insert(**field_dict).execute()\n File \"/opt/Python2.7-32bit/lib/python2.7/site-packages/peewee.py\", line 3213, in execute\n cursor = self._execute()\n File \"/opt/Python2.7-32bit/lib/python2.7/site-packages/peewee.py\", line 2628, in _execute\n return self.database.execute_sql(sql, params, self.require_commit)\n```\n", "Looks like the same problem, although you're getting a different error with Sqlite because it's passing the driver layer and actually executing the SQ (afaik), and I think the most recent patch in master might not resolve this issue (as that relates to blob fields only from what I can tell)\n\n/cc @coleifer Any update on that new release? :P\n", "The SQLite one may be related to the integer fields as far as I can tell from the traceback. SQLite doesn't have a big integer field, so you may need to store those as text.\n", "Prob need a new release to fix the blob thing, though, as @foxx said. I'll try and get one together soon\n", "Thank you. I would really appreciate it. I like peewee and would like to use it for my current project, and future ones.  For the moment, I am kind of stuck with this bug. \n\nSent from Outlook Mobile\n", "You can always point at master, but I understand what you're saying and will try and get this done tonight.\n", "@coleifer Happy to throw a pair of hands on this, if there's anything I can do to help (testing, docs or w/e)\n", "@gitttt If you're really stuck and not sure how to install from master, let me know and I'll post some instructions up for you.\n", "Oh, I did not understand you correctly. So you have fixed this problem already? I will try to point at master and check if it works.\n", "I re-installed peewee. This time from the github repo. The error is gone.\n", "I got the same error.\nI degraded PyMySQL from (0.7.2) to (0.6.6). It works for me.\nMy peewee version is 2.8.0\n", "I was having all sorts of problems like this with PyMySQL (0.7.2 and 0.6.6). I switched to MySQLdb and everything is good.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/871/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "MinchinWeb", "id": 1548809, "node_id": "MDQ6VXNlcjE1NDg4MDk=", "avatar_url": "https://avatars.githubusercontent.com/u/1548809?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MinchinWeb", "html_url": "https://github.com/MinchinWeb", "followers_url": "https://api.github.com/users/MinchinWeb/followers", "following_url": "https://api.github.com/users/MinchinWeb/following{/other_user}", "gists_url": "https://api.github.com/users/MinchinWeb/gists{/gist_id}", "starred_url": "https://api.github.com/users/MinchinWeb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MinchinWeb/subscriptions", "organizations_url": "https://api.github.com/users/MinchinWeb/orgs", "repos_url": "https://api.github.com/users/MinchinWeb/repos", "events_url": "https://api.github.com/users/MinchinWeb/events{/privacy}", "received_events_url": "https://api.github.com/users/MinchinWeb/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Awesome, thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/870/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "mazulo", "id": 1661112, "node_id": "MDQ6VXNlcjE2NjExMTI=", "avatar_url": "https://avatars.githubusercontent.com/u/1661112?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mazulo", "html_url": "https://github.com/mazulo", "followers_url": "https://api.github.com/users/mazulo/followers", "following_url": "https://api.github.com/users/mazulo/following{/other_user}", "gists_url": "https://api.github.com/users/mazulo/gists{/gist_id}", "starred_url": "https://api.github.com/users/mazulo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mazulo/subscriptions", "organizations_url": "https://api.github.com/users/mazulo/orgs", "repos_url": "https://api.github.com/users/mazulo/repos", "events_url": "https://api.github.com/users/mazulo/events{/privacy}", "received_events_url": "https://api.github.com/users/mazulo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you!\nOn Feb 24, 2016 10:19 PM, \"Patrick Mazulo\" [email protected] wrote:\n\n> ## Improve the read of the code\n> \n> You can view, comment on, or merge this pull request online at:\n> \n> https://github.com/coleifer/peewee/pull/869\n> Commit Summary\n> - Enable syntax highlight\n> - Merge pull request #1 from mazulo/mazulo-patch-1\n> \n> File Changes\n> - _M_ README.rst\n> https://github.com/coleifer/peewee/pull/869/files#diff-0 (16)\n> \n> Patch Links:\n> - https://github.com/coleifer/peewee/pull/869.patch\n> - https://github.com/coleifer/peewee/pull/869.diff\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/coleifer/peewee/pull/869.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/869/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/869", "html_url": "https://github.com/coleifer/peewee/pull/869", "diff_url": "https://github.com/coleifer/peewee/pull/869.diff", "patch_url": "https://github.com/coleifer/peewee/pull/869.patch", "merged_at": "2016-02-25T14:05:50" }

{ "login": "disarticulate", "id": 17464125, "node_id": "MDQ6VXNlcjE3NDY0MTI1", "avatar_url": "https://avatars.githubusercontent.com/u/17464125?v=4", "gravatar_id": "", "url": "https://api.github.com/users/disarticulate", "html_url": "https://github.com/disarticulate", "followers_url": "https://api.github.com/users/disarticulate/followers", "following_url": "https://api.github.com/users/disarticulate/following{/other_user}", "gists_url": "https://api.github.com/users/disarticulate/gists{/gist_id}", "starred_url": "https://api.github.com/users/disarticulate/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/disarticulate/subscriptions", "organizations_url": "https://api.github.com/users/disarticulate/orgs", "repos_url": "https://api.github.com/users/disarticulate/repos", "events_url": "https://api.github.com/users/disarticulate/events{/privacy}", "received_events_url": "https://api.github.com/users/disarticulate/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You need to load the extension every time you connect... Could that be the issue?\n", "```\ndatabase.connect()\ndatabase.load_extension('mod_spatialite')\nsql = 'SELECT sqlite_version(), spatialite_version()'\nprint(database.execute_sql(sql).fetchall())\nLocations.insert(geometry=geometryFromWKT('POINT(4 9 3 `2)')).execute()\n```\n\n```\n>>[('3.8.11', '4.3.0a')]\n> >---------------------------------------------------------------------------\n> OperationalError Traceback (most recent call last)\n> C:\\Users\\Tsai\\Anaconda3\\envs\\flask\\lib\\site-packages\\peewee.py in execute_sql(self, sql, params, require_commit)\n> 3453 try:\n> -> 3454 cursor.execute(sql, params or ())\n> 3455 except Exception:\n> \n> OperationalError: no such function: ST_GeomFromText\n> \n> During handling of the above exception, another exception occurred:\n> \n> OperationalError Traceback (most recent call last)\n> <ipython-input-13-03efd5976860> in <module>()\n> 1 database.connect()\n> 2 database.load_extension('mod_spatialite')\n> ----> 3 Locations.insert(geometry=geometryFromWKT('POINT(4 9 3 2)')).execute()\n> \n> C:\\Users\\Tsai\\Anaconda3\\envs\\flask\\lib\\site-packages\\peewee.py in execute(self)\n> 3211 return self._qr\n> 3212 else:\n> -> 3213 cursor = self._execute()\n> 3214 if not self._is_multi_row_insert:\n> 3215 if self.database.insert_returning:\n> \n> C:\\Users\\Tsai\\Anaconda3\\envs\\flask\\lib\\site-packages\\peewee.py in _execute(self)\n> 2626 def _execute(self):\n> 2627 sql, params = self.sql()\n> -> 2628 return self.database.execute_sql(sql, params, self.require_commit)\n> 2629 \n> 2630 def execute(self):\n> \n> C:\\Users\\Tsai\\Anaconda3\\envs\\flask\\lib\\site-packages\\peewee.py in execute_sql(self, sql, params, require_commit)\n> 3459 else:\n> 3460 if require_commit and self.get_autocommit():\n> -> 3461 self.commit()\n> 3462 return cursor\n> 3463 \n> \n> C:\\Users\\Tsai\\Anaconda3\\envs\\flask\\lib\\site-packages\\peewee.py in __exit__(self, exc_type, exc_value, traceback)\n> 3283 else:\n> 3284 exc_args = exc_value.args\n> -> 3285 reraise(new_type, new_type(*exc_args), traceback)\n> 3286 \n> 3287 class _BaseConnectionLocal(object):\n> \n> C:\\Users\\Tsai\\Anaconda3\\envs\\flask\\lib\\site-packages\\peewee.py in reraise(tp, value, tb)\n> 125 def reraise(tp, value, tb=None):\n> 126 if value.__traceback__ is not tb:\n> --> 127 raise value.with_traceback(tb)\n> 128 raise value\n> 129 elif PY2:\n> \n> C:\\Users\\Tsai\\Anaconda3\\envs\\flask\\lib\\site-packages\\peewee.py in execute_sql(self, sql, params, require_commit)\n> 3452 cursor = self.get_cursor()\n> 3453 try:\n> -> 3454 cursor.execute(sql, params or ())\n> 3455 except Exception:\n> 3456 if self.get_autocommit() and self.autorollback:\n> \n> OperationalError: no such function: ST_GeomFromText\n```\n", "I'm not at all sure what's going on there. Possibly your SQLite driver is not built with support for Spatialite, or is linked against a different SQLite library? At any rate, I don't believe this is a problem with peewee, which I use with extension modules regularly.\n", "Thanks for the help.\n\nOn Fri, Feb 26, 2016 at 12:07 PM, Charles Leifer [email protected]\nwrote:\n\n> Closed #868 https://github.com/coleifer/peewee/issues/868.\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/coleifer/peewee/issues/868#event-567934835.\n\n## \n\ndis·ar·tic·u·late Audio pronunciation of \"disarticulate\" ( P )\nPronunciation Key (dsär-tky-lt)\nv. dis·ar·tic·u·lat·ed, dis·ar·tic·u·lat·ing, dis·ar·tic·u·lates\nv. tr.\n\n```\nTo separate at the joints; disjoint.\n```\n\nv. intr.\n\n```\nTo become disjointed.\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/868/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kramer65", "id": 596581, "node_id": "MDQ6VXNlcjU5NjU4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/596581?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kramer65", "html_url": "https://github.com/kramer65", "followers_url": "https://api.github.com/users/kramer65/followers", "following_url": "https://api.github.com/users/kramer65/following{/other_user}", "gists_url": "https://api.github.com/users/kramer65/gists{/gist_id}", "starred_url": "https://api.github.com/users/kramer65/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kramer65/subscriptions", "organizations_url": "https://api.github.com/users/kramer65/orgs", "repos_url": "https://api.github.com/users/kramer65/repos", "events_url": "https://api.github.com/users/kramer65/events{/privacy}", "received_events_url": "https://api.github.com/users/kramer65/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Actually it used to do that so I was surprised by your note. I went in and looked at the nginx config and realized I hadn't updated it for when I removed Varnish from my site. The redirects should be working now. Thank you!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/867/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bcattle", "id": 620058, "node_id": "MDQ6VXNlcjYyMDA1OA==", "avatar_url": "https://avatars.githubusercontent.com/u/620058?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bcattle", "html_url": "https://github.com/bcattle", "followers_url": "https://api.github.com/users/bcattle/followers", "following_url": "https://api.github.com/users/bcattle/following{/other_user}", "gists_url": "https://api.github.com/users/bcattle/gists{/gist_id}", "starred_url": "https://api.github.com/users/bcattle/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bcattle/subscriptions", "organizations_url": "https://api.github.com/users/bcattle/orgs", "repos_url": "https://api.github.com/users/bcattle/repos", "events_url": "https://api.github.com/users/bcattle/events{/privacy}", "received_events_url": "https://api.github.com/users/bcattle/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/866/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/866", "html_url": "https://github.com/coleifer/peewee/pull/866", "diff_url": "https://github.com/coleifer/peewee/pull/866.diff", "patch_url": "https://github.com/coleifer/peewee/pull/866.patch", "merged_at": "2016-02-22T03:39:43" }

{ "login": "onel", "id": 1862405, "node_id": "MDQ6VXNlcjE4NjI0MDU=", "avatar_url": "https://avatars.githubusercontent.com/u/1862405?v=4", "gravatar_id": "", "url": "https://api.github.com/users/onel", "html_url": "https://github.com/onel", "followers_url": "https://api.github.com/users/onel/followers", "following_url": "https://api.github.com/users/onel/following{/other_user}", "gists_url": "https://api.github.com/users/onel/gists{/gist_id}", "starred_url": "https://api.github.com/users/onel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/onel/subscriptions", "organizations_url": "https://api.github.com/users/onel/orgs", "repos_url": "https://api.github.com/users/onel/repos", "events_url": "https://api.github.com/users/onel/events{/privacy}", "received_events_url": "https://api.github.com/users/onel/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Going to pass as this is a pretty obscure framework.\n", "We use this framework (webapp2) with peewee. We never call connect() or close(). Is that bad?", "@savraj -- Probably... I don't know webapp2, but my guess is that you aren't getting the concurrency you think you might be if you're running in certain types of environments.\r\n\r\nIf you're using a webapp, my opinion is that you should always open a conn upon receiving a connection and close it afterwards. You *can* use a connection pool if you get a lot of traffic, but that's how I would do things." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/865/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "sripathivenky", "id": 2147479, "node_id": "MDQ6VXNlcjIxNDc0Nzk=", "avatar_url": "https://avatars.githubusercontent.com/u/2147479?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sripathivenky", "html_url": "https://github.com/sripathivenky", "followers_url": "https://api.github.com/users/sripathivenky/followers", "following_url": "https://api.github.com/users/sripathivenky/following{/other_user}", "gists_url": "https://api.github.com/users/sripathivenky/gists{/gist_id}", "starred_url": "https://api.github.com/users/sripathivenky/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sripathivenky/subscriptions", "organizations_url": "https://api.github.com/users/sripathivenky/orgs", "repos_url": "https://api.github.com/users/sripathivenky/repos", "events_url": "https://api.github.com/users/sripathivenky/events{/privacy}", "received_events_url": "https://api.github.com/users/sripathivenky/received_events", "type": "User", "site_admin": false }

[]

[]

[ "No idea, but somehow your install isn't finding a python sqlite driver.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/864/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tgrant59", "id": 4661702, "node_id": "MDQ6VXNlcjQ2NjE3MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/4661702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tgrant59", "html_url": "https://github.com/tgrant59", "followers_url": "https://api.github.com/users/tgrant59/followers", "following_url": "https://api.github.com/users/tgrant59/following{/other_user}", "gists_url": "https://api.github.com/users/tgrant59/gists{/gist_id}", "starred_url": "https://api.github.com/users/tgrant59/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tgrant59/subscriptions", "organizations_url": "https://api.github.com/users/tgrant59/orgs", "repos_url": "https://api.github.com/users/tgrant59/repos", "events_url": "https://api.github.com/users/tgrant59/events{/privacy}", "received_events_url": "https://api.github.com/users/tgrant59/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Yeah, that's a limitation of MySQL -- you need to specify a length to index when you have a `TextField`.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/863/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "dev-zero", "id": 11307, "node_id": "MDQ6VXNlcjExMzA3", "avatar_url": "https://avatars.githubusercontent.com/u/11307?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dev-zero", "html_url": "https://github.com/dev-zero", "followers_url": "https://api.github.com/users/dev-zero/followers", "following_url": "https://api.github.com/users/dev-zero/following{/other_user}", "gists_url": "https://api.github.com/users/dev-zero/gists{/gist_id}", "starred_url": "https://api.github.com/users/dev-zero/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dev-zero/subscriptions", "organizations_url": "https://api.github.com/users/dev-zero/orgs", "repos_url": "https://api.github.com/users/dev-zero/repos", "events_url": "https://api.github.com/users/dev-zero/events{/privacy}", "received_events_url": "https://api.github.com/users/dev-zero/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Looks nice, add a couple tests and I'll merge.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/862/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/862", "html_url": "https://github.com/coleifer/peewee/pull/862", "diff_url": "https://github.com/coleifer/peewee/pull/862.diff", "patch_url": "https://github.com/coleifer/peewee/pull/862.patch", "merged_at": null }

{ "login": "josefdlange", "id": 1062835, "node_id": "MDQ6VXNlcjEwNjI4MzU=", "avatar_url": "https://avatars.githubusercontent.com/u/1062835?v=4", "gravatar_id": "", "url": "https://api.github.com/users/josefdlange", "html_url": "https://github.com/josefdlange", "followers_url": "https://api.github.com/users/josefdlange/followers", "following_url": "https://api.github.com/users/josefdlange/following{/other_user}", "gists_url": "https://api.github.com/users/josefdlange/gists{/gist_id}", "starred_url": "https://api.github.com/users/josefdlange/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/josefdlange/subscriptions", "organizations_url": "https://api.github.com/users/josefdlange/orgs", "repos_url": "https://api.github.com/users/josefdlange/repos", "events_url": "https://api.github.com/users/josefdlange/events{/privacy}", "received_events_url": "https://api.github.com/users/josefdlange/received_events", "type": "User", "site_admin": false }

[]

[]

[ "My best guess is that a DB value of `None` would, in prior versions, never get passed to the `Field` subclass's `python_value` method but instead short-circuit to just returning `None`.\n\nThis is kind of a breaking change that isn't noted in the `CHANGELOG` if it proves to be what I'm experiencing. Granted I should have `None`-checked anyway but Figured this is a good word of warning to anyone in the future.\n", "Might be related to #791 actually; perhaps my `python_value` method was bad all along and just never being called because of this bug! These fields are PKs of tables....\n", "I'm pretty sure it's been that way for a while. Not an issue, IMO.\n", "Fair enough. Moving from 2.7.4 --> 2.8.0 broke this for me, but so long as the solution is to fix my own f*cking code I can live with that :)\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/861/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Prillan", "id": 1675190, "node_id": "MDQ6VXNlcjE2NzUxOTA=", "avatar_url": "https://avatars.githubusercontent.com/u/1675190?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Prillan", "html_url": "https://github.com/Prillan", "followers_url": "https://api.github.com/users/Prillan/followers", "following_url": "https://api.github.com/users/Prillan/following{/other_user}", "gists_url": "https://api.github.com/users/Prillan/gists{/gist_id}", "starred_url": "https://api.github.com/users/Prillan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Prillan/subscriptions", "organizations_url": "https://api.github.com/users/Prillan/orgs", "repos_url": "https://api.github.com/users/Prillan/repos", "events_url": "https://api.github.com/users/Prillan/events{/privacy}", "received_events_url": "https://api.github.com/users/Prillan/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Rather than modify the SQL behind-the-scenes, you should check your list at run-time.\n", "I get that, I'm fine with checking if the list is empty. I'm just against creating an invalid query since it results in a syntax error. The error should be thrown before it gets to the database and not in it. To me this is like having a compiler generate invalid code, something that shouldn't be figured out when you try to run the code, but rather at compile time.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/860/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "RealSalmon", "id": 943086, "node_id": "MDQ6VXNlcjk0MzA4Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/943086?v=4", "gravatar_id": "", "url": "https://api.github.com/users/RealSalmon", "html_url": "https://github.com/RealSalmon", "followers_url": "https://api.github.com/users/RealSalmon/followers", "following_url": "https://api.github.com/users/RealSalmon/following{/other_user}", "gists_url": "https://api.github.com/users/RealSalmon/gists{/gist_id}", "starred_url": "https://api.github.com/users/RealSalmon/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RealSalmon/subscriptions", "organizations_url": "https://api.github.com/users/RealSalmon/orgs", "repos_url": "https://api.github.com/users/RealSalmon/repos", "events_url": "https://api.github.com/users/RealSalmon/events{/privacy}", "received_events_url": "https://api.github.com/users/RealSalmon/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Looks good, just one thing to change and I'll be happy to merge.\n", "Actually that dictionary comprehension breaks in Python 2.6 (forgot about that). I didn't notice it before because travis didn't pick up the PR initially.\n", "A few fixes were required for Python 2.6.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/859/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/859", "html_url": "https://github.com/coleifer/peewee/pull/859", "diff_url": "https://github.com/coleifer/peewee/pull/859.diff", "patch_url": "https://github.com/coleifer/peewee/pull/859.patch", "merged_at": "2016-02-18T16:12:37" }

{ "login": "RealSalmon", "id": 943086, "node_id": "MDQ6VXNlcjk0MzA4Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/943086?v=4", "gravatar_id": "", "url": "https://api.github.com/users/RealSalmon", "html_url": "https://github.com/RealSalmon", "followers_url": "https://api.github.com/users/RealSalmon/followers", "following_url": "https://api.github.com/users/RealSalmon/following{/other_user}", "gists_url": "https://api.github.com/users/RealSalmon/gists{/gist_id}", "starred_url": "https://api.github.com/users/RealSalmon/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RealSalmon/subscriptions", "organizations_url": "https://api.github.com/users/RealSalmon/orgs", "repos_url": "https://api.github.com/users/RealSalmon/repos", "events_url": "https://api.github.com/users/RealSalmon/events{/privacy}", "received_events_url": "https://api.github.com/users/RealSalmon/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Yes!\n", "Great, I'll start messing around with it this evening (real life permitting . . . ). \n", "That's cool but how could we set False (eg. register_hstore) via url? Should parse the query string with `keep_blank_values=True`, right?\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/858/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "dc258ae727620c01d300c67ab58a73c9d1a15b7e\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/857/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jrs65", "id": 695206, "node_id": "MDQ6VXNlcjY5NTIwNg==", "avatar_url": "https://avatars.githubusercontent.com/u/695206?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jrs65", "html_url": "https://github.com/jrs65", "followers_url": "https://api.github.com/users/jrs65/followers", "following_url": "https://api.github.com/users/jrs65/following{/other_user}", "gists_url": "https://api.github.com/users/jrs65/gists{/gist_id}", "starred_url": "https://api.github.com/users/jrs65/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jrs65/subscriptions", "organizations_url": "https://api.github.com/users/jrs65/orgs", "repos_url": "https://api.github.com/users/jrs65/repos", "events_url": "https://api.github.com/users/jrs65/events{/privacy}", "received_events_url": "https://api.github.com/users/jrs65/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Try modifying your `__init__` to:\n\n```\ndef __init__(self, a=2, **kwargs):\n pw.Model.__init__(self, a=a, **kwargs)\n```\n", "@lez is correct. Models that override `__init__()` should accept arbitrary kwargs and pass them to the parent constructor. Really, you should not be overriding `__init__()` in the first place though.\n", "Thanks. I guess my confusion came from the fact this used to work fine on earlier versions.\n\nMight be worth a mention in the documentation about not overriding `__init__` or how to do it if you must. It's quite a natural thing to want to do, and it breaks in places that are a little unexpected if you do it incorrectly. If I get time in the next few days, I'll do it myself and send in a PR. \n", "Same with me. I overrode __init__() and it used to work, but I believe I upgraded to a newer version of peewee and it now spits out the following error:\r\n\r\nTypeError: __init__() got an unexpected keyword argument 'database_column_name'", "@coleifer so what is the right way to init the data fields of peewee.Model descendant class?", "> so what is the right way to init the data fields of peewee.Model descendant class\r\n\r\nA `Model` class represents a row of data, which it is initialized with. What you mean by \"data fields\" is unclear to me. You can always override the init method, but with the caveat that it your implementation must accept arbitrary keyword arguments and also call the parent constructor.", "thanks @coleifer!\r\n\r\nsuppose I have a _Car_ class that inherits from _peewee.Model_. If I want to initialise an object of the _Car_ class with individual values, I can just use the constructor:\r\n\r\n```\r\ncar_object = Car(seats=6, cylinders=2)\r\n```\r\n\r\nSo far, so good! \r\n\r\nBut now suppose I want to initialise the _Car_ object, starting from another object, say some _CarConfig_ object and the initialisation requires some logic, more than just assigning fields 1-to-1.\r\n\r\nWithout peewee, I would simply define my \\_\\_init\\_\\_() method and put all the initialisation logic there\r\n\r\n```\r\nclass Car:\r\n\r\n def __init__(self, car_config_object):\r\n ... some complex initialisation logic here that uses the car_config_object ...\r\n```\r\n\r\nbut I can't define the \\_\\_init\\_\\_() method in _peewee.Model_ descendant classes anymore. \r\nSo where do I put all that complex initialisation logic?\r\n", "You can still put it in `__init__()` with the caveat that `__init__()` is going to be called not just when instantiating objects yourself, but also every time a `Car` instance is read from a database cursor. I think you probably could make a classmethod on your `Car` object and use that as a factory for complex logic?", "good idea - I think the factory method is the way to go!", "Could someone share an example of how would that factory method look like ?", "@mauriciogracia \r\n\r\n```\r\nclass Tweet:\r\n @classmethod\r\n def new(cls, *args, **kwargs):\r\n tweet = cls()\r\n # Do complicated logic\r\n return tweet\r\n```\r\n\r\nThis is just a way to avoid overriding `__init__`.", "Since `__new__` does not trigger `__init__` in Python, would there be anything wrong with implicitly using `__new__` instead of explicitly using `Tweet.new` ?", "I would not advise it unless you're quite familiar with all the differences between `__new__` and `__init__` (which I myself am not quite sure of). If you need a specialized constructor, my advice is to just write an explicit `@classmethod` **or** you can just make very cautious modifications to `__init__`, e.g.\r\n\r\n```python\r\nclass User(Model):\r\n username = TextField()\r\n def __init__(self, *args, **kwargs):\r\n super(User, self).__init__(*args, **kwargs) # Ensure parent init is called correctly.\r\n # do complicated stuff here.\r\n```\r\n\r\nBut my advice is to probably stick to a classmethod constructor if your logic is particularly complex." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/856/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "lez", "id": 203039, "node_id": "MDQ6VXNlcjIwMzAzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/203039?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lez", "html_url": "https://github.com/lez", "followers_url": "https://api.github.com/users/lez/followers", "following_url": "https://api.github.com/users/lez/following{/other_user}", "gists_url": "https://api.github.com/users/lez/gists{/gist_id}", "starred_url": "https://api.github.com/users/lez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lez/subscriptions", "organizations_url": "https://api.github.com/users/lez/orgs", "repos_url": "https://api.github.com/users/lez/repos", "events_url": "https://api.github.com/users/lez/events{/privacy}", "received_events_url": "https://api.github.com/users/lez/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/855/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/855", "html_url": "https://github.com/coleifer/peewee/pull/855", "diff_url": "https://github.com/coleifer/peewee/pull/855.diff", "patch_url": "https://github.com/coleifer/peewee/pull/855.patch", "merged_at": "2016-02-17T00:25:49" }

{ "login": "kramer65", "id": 596581, "node_id": "MDQ6VXNlcjU5NjU4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/596581?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kramer65", "html_url": "https://github.com/kramer65", "followers_url": "https://api.github.com/users/kramer65/followers", "following_url": "https://api.github.com/users/kramer65/following{/other_user}", "gists_url": "https://api.github.com/users/kramer65/gists{/gist_id}", "starred_url": "https://api.github.com/users/kramer65/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kramer65/subscriptions", "organizations_url": "https://api.github.com/users/kramer65/orgs", "repos_url": "https://api.github.com/users/kramer65/repos", "events_url": "https://api.github.com/users/kramer65/events{/privacy}", "received_events_url": "https://api.github.com/users/kramer65/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Well, peewee knows that you set attributes so those are stored in the `dirty_fields` attribute. But there's no checking to see if it differed from the previous value. Any additional logic will have to live in your app itself.\n", "You can do `model.save(only=model.dirty_fields)`, if you just want to save those that were \"set\", but it doesn't track actual changes to the underyling value.\n", "Alright thanks. In that case I will need to build something myself.\n\nThanks!\n", "Why wouldn't peewee check whether values have actually changed? Speed?\r\n\r\nAnd would this be a good way to implement it?\r\n\r\n```python\r\nclass BaseModel(Model):\r\n class Meta:\r\n database = database\r\n only_save_dirty = True\r\n\r\n def __setattr__(self, name, value):\r\n if not hasattr(self, name) or getattr(self, name) is not value:\r\n return super().__setattr__(name, value)\r\n```" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/854/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "dev-zero", "id": 11307, "node_id": "MDQ6VXNlcjExMzA3", "avatar_url": "https://avatars.githubusercontent.com/u/11307?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dev-zero", "html_url": "https://github.com/dev-zero", "followers_url": "https://api.github.com/users/dev-zero/followers", "following_url": "https://api.github.com/users/dev-zero/following{/other_user}", "gists_url": "https://api.github.com/users/dev-zero/gists{/gist_id}", "starred_url": "https://api.github.com/users/dev-zero/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dev-zero/subscriptions", "organizations_url": "https://api.github.com/users/dev-zero/orgs", "repos_url": "https://api.github.com/users/dev-zero/repos", "events_url": "https://api.github.com/users/dev-zero/events{/privacy}", "received_events_url": "https://api.github.com/users/dev-zero/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Here's an example of how to insert with a select query:\n\nhttp://docs.peewee-orm.com/en/latest/peewee/api.html#Model.insert_from\n\nFor postgres, you can use the on_conflict method:\n\nhttp://docs.peewee-orm.com/en/latest/peewee/api.html#InsertQuery.on_conflict\n\nI'll need to check if it works with postgres, as its only been tested on\nsqlite.\nOn Feb 12, 2016 5:39 AM, \"Tiziano Müller\" [email protected] wrote:\n\n> I couldn't figure out how to do an \"INSERT IF NOT EXISTS\" according to\n> http://stackoverflow.com/questions/15710162/conditional-insert-into-statement-in-postgres\n> in PostgreSQL. I am now using create_or_get instead, but it would be nice\n> if peewee would support the general \"exists/not exists\" in the when\n> function.\n> Likewise for the UPSERT function introduced in PostgreSQL-9.5\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/coleifer/peewee/issues/853.\n", "Ok, I tried the following:\n\n``` python\nmodels.TaskStatus.insert(name='done').on_conflict('IGNORE').execute()\n```\n\nwhich unfortunately generates a `INSERT OR IGNORE ...` which is not supported by PostgreSQL (I get a syntax error) instead of `sql INSERT ... ON CONFLICT` which is supposed to work with with PostgreSQL and MySQL.\n", "Hi, any word on `upsert` support for Postgres 9.5?\n", "I'm planning support for Postgres 9.5's new upsert functionality. Discussion has been consolidated into this ticket: #1307 . Please feel free to comment on that ticket with any thoughts or suggestions." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/853/reactions", "total_count": 5, "+1": 5, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "gilchris", "id": 6995188, "node_id": "MDQ6VXNlcjY5OTUxODg=", "avatar_url": "https://avatars.githubusercontent.com/u/6995188?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gilchris", "html_url": "https://github.com/gilchris", "followers_url": "https://api.github.com/users/gilchris/followers", "following_url": "https://api.github.com/users/gilchris/following{/other_user}", "gists_url": "https://api.github.com/users/gilchris/gists{/gist_id}", "starred_url": "https://api.github.com/users/gilchris/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gilchris/subscriptions", "organizations_url": "https://api.github.com/users/gilchris/orgs", "repos_url": "https://api.github.com/users/gilchris/repos", "events_url": "https://api.github.com/users/gilchris/events{/privacy}", "received_events_url": "https://api.github.com/users/gilchris/received_events", "type": "User", "site_admin": false }

[]

[]

[ "That's one old ass sqlite.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/852/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Hendler", "id": 144833, "node_id": "MDQ6VXNlcjE0NDgzMw==", "avatar_url": "https://avatars.githubusercontent.com/u/144833?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Hendler", "html_url": "https://github.com/Hendler", "followers_url": "https://api.github.com/users/Hendler/followers", "following_url": "https://api.github.com/users/Hendler/following{/other_user}", "gists_url": "https://api.github.com/users/Hendler/gists{/gist_id}", "starred_url": "https://api.github.com/users/Hendler/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Hendler/subscriptions", "organizations_url": "https://api.github.com/users/Hendler/orgs", "repos_url": "https://api.github.com/users/Hendler/repos", "events_url": "https://api.github.com/users/Hendler/events{/privacy}", "received_events_url": "https://api.github.com/users/Hendler/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Peewee uses the convention that foreign key columns end with \"_id\". No bug. Either change your migration to use user_id as the column, or in your field on the model specify db_column='user'\n", "Thanks I got confused by the create_table and column specific operations. \n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/851/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ptbrowne", "id": 465582, "node_id": "MDQ6VXNlcjQ2NTU4Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/465582?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ptbrowne", "html_url": "https://github.com/ptbrowne", "followers_url": "https://api.github.com/users/ptbrowne/followers", "following_url": "https://api.github.com/users/ptbrowne/following{/other_user}", "gists_url": "https://api.github.com/users/ptbrowne/gists{/gist_id}", "starred_url": "https://api.github.com/users/ptbrowne/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ptbrowne/subscriptions", "organizations_url": "https://api.github.com/users/ptbrowne/orgs", "repos_url": "https://api.github.com/users/ptbrowne/repos", "events_url": "https://api.github.com/users/ptbrowne/events{/privacy}", "received_events_url": "https://api.github.com/users/ptbrowne/received_events", "type": "User", "site_admin": false }

[]

[]

[ "That's odd, are you using the `MySQLMigrator`? The `add_not_null()` method appears to be using the \"MODIFY\" syntax.\n", "My bad... That was it, I was using PostgreSQLMigrator >< Thanks\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/850/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "purpurpur", "id": 7671808, "node_id": "MDQ6VXNlcjc2NzE4MDg=", "avatar_url": "https://avatars.githubusercontent.com/u/7671808?v=4", "gravatar_id": "", "url": "https://api.github.com/users/purpurpur", "html_url": "https://github.com/purpurpur", "followers_url": "https://api.github.com/users/purpurpur/followers", "following_url": "https://api.github.com/users/purpurpur/following{/other_user}", "gists_url": "https://api.github.com/users/purpurpur/gists{/gist_id}", "starred_url": "https://api.github.com/users/purpurpur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/purpurpur/subscriptions", "organizations_url": "https://api.github.com/users/purpurpur/orgs", "repos_url": "https://api.github.com/users/purpurpur/repos", "events_url": "https://api.github.com/users/purpurpur/events{/privacy}", "received_events_url": "https://api.github.com/users/purpurpur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@embali you should use [code formatting](https://guides.github.com/features/mastering-markdown/#GitHub-flavored-markdown) to make your issue more readable.\n", "Indeed, I'm confused why people expect me to spend time answering the question they were too lazy to write properly.\n", "Try changing the join on the subquery to:\n\n``` python\n .join(\n categories_,\n on=(models.Category.uid == categories_.c.uid).alias('xx'))\\\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/849/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "yohanboniface", "id": 146023, "node_id": "MDQ6VXNlcjE0NjAyMw==", "avatar_url": "https://avatars.githubusercontent.com/u/146023?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yohanboniface", "html_url": "https://github.com/yohanboniface", "followers_url": "https://api.github.com/users/yohanboniface/followers", "following_url": "https://api.github.com/users/yohanboniface/following{/other_user}", "gists_url": "https://api.github.com/users/yohanboniface/gists{/gist_id}", "starred_url": "https://api.github.com/users/yohanboniface/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yohanboniface/subscriptions", "organizations_url": "https://api.github.com/users/yohanboniface/orgs", "repos_url": "https://api.github.com/users/yohanboniface/repos", "events_url": "https://api.github.com/users/yohanboniface/events{/privacy}", "received_events_url": "https://api.github.com/users/yohanboniface/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Humm, why? :s\nThat does not seem to hurt anything while allowing more DRYer overriding of ManyToManyField.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/848/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/848", "html_url": "https://github.com/coleifer/peewee/pull/848", "diff_url": "https://github.com/coleifer/peewee/pull/848.diff", "patch_url": "https://github.com/coleifer/peewee/pull/848.patch", "merged_at": null }

{ "login": "startakovsky", "id": 689723, "node_id": "MDQ6VXNlcjY4OTcyMw==", "avatar_url": "https://avatars.githubusercontent.com/u/689723?v=4", "gravatar_id": "", "url": "https://api.github.com/users/startakovsky", "html_url": "https://github.com/startakovsky", "followers_url": "https://api.github.com/users/startakovsky/followers", "following_url": "https://api.github.com/users/startakovsky/following{/other_user}", "gists_url": "https://api.github.com/users/startakovsky/gists{/gist_id}", "starred_url": "https://api.github.com/users/startakovsky/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/startakovsky/subscriptions", "organizations_url": "https://api.github.com/users/startakovsky/orgs", "repos_url": "https://api.github.com/users/startakovsky/repos", "events_url": "https://api.github.com/users/startakovsky/events{/privacy}", "received_events_url": "https://api.github.com/users/startakovsky/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Peewee needs to know which database to connect to, so yes, this is a requirement.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/847/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "cledoux", "id": 573298, "node_id": "MDQ6VXNlcjU3MzI5OA==", "avatar_url": "https://avatars.githubusercontent.com/u/573298?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cledoux", "html_url": "https://github.com/cledoux", "followers_url": "https://api.github.com/users/cledoux/followers", "following_url": "https://api.github.com/users/cledoux/following{/other_user}", "gists_url": "https://api.github.com/users/cledoux/gists{/gist_id}", "starred_url": "https://api.github.com/users/cledoux/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cledoux/subscriptions", "organizations_url": "https://api.github.com/users/cledoux/orgs", "repos_url": "https://api.github.com/users/cledoux/repos", "events_url": "https://api.github.com/users/cledoux/events{/privacy}", "received_events_url": "https://api.github.com/users/cledoux/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Merged a slightly different fix. Thanks for bringing this to my attention.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/846/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/846", "html_url": "https://github.com/coleifer/peewee/pull/846", "diff_url": "https://github.com/coleifer/peewee/pull/846.diff", "patch_url": "https://github.com/coleifer/peewee/pull/846.patch", "merged_at": null }

{ "login": "cledoux", "id": 573298, "node_id": "MDQ6VXNlcjU3MzI5OA==", "avatar_url": "https://avatars.githubusercontent.com/u/573298?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cledoux", "html_url": "https://github.com/cledoux", "followers_url": "https://api.github.com/users/cledoux/followers", "following_url": "https://api.github.com/users/cledoux/following{/other_user}", "gists_url": "https://api.github.com/users/cledoux/gists{/gist_id}", "starred_url": "https://api.github.com/users/cledoux/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cledoux/subscriptions", "organizations_url": "https://api.github.com/users/cledoux/orgs", "repos_url": "https://api.github.com/users/cledoux/repos", "events_url": "https://api.github.com/users/cledoux/events{/privacy}", "received_events_url": "https://api.github.com/users/cledoux/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I've created a pull request with test cases that illustrate the issue along with a potential fix.\n\nAPSWDatabase overwrites _connect without calling _add_conn_hooks. I added this missing call.\n", "Thanks for the amazingly fast turnaround!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/845/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "yohanboniface", "id": 146023, "node_id": "MDQ6VXNlcjE0NjAyMw==", "avatar_url": "https://avatars.githubusercontent.com/u/146023?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yohanboniface", "html_url": "https://github.com/yohanboniface", "followers_url": "https://api.github.com/users/yohanboniface/followers", "following_url": "https://api.github.com/users/yohanboniface/following{/other_user}", "gists_url": "https://api.github.com/users/yohanboniface/gists{/gist_id}", "starred_url": "https://api.github.com/users/yohanboniface/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yohanboniface/subscriptions", "organizations_url": "https://api.github.com/users/yohanboniface/orgs", "repos_url": "https://api.github.com/users/yohanboniface/repos", "events_url": "https://api.github.com/users/yohanboniface/events{/privacy}", "received_events_url": "https://api.github.com/users/yohanboniface/received_events", "type": "User", "site_admin": false }

[]

[]

[ "What you have there is really no different from the current behavior. For instance:\n\n``` python\nIn [1]: from peewee import *\n\nIn [2]: class User(Model):\n ...: username = CharField()\n ...: \n\nIn [3]: class BaseTweet(Model):\n ...: user = ForeignKeyField(User)\n ...: \n\nIn [4]: class Tweet(BaseTweet):\n ...: pass\n ...: \n\nIn [5]: class PhotoTweet(BaseTweet):\n ...: pass\n ...: \nIn [6]: User.phototweet_set\nOut[6]: <peewee.ReverseRelationDescriptor at 0x7f42ac136710>\n\nIn [7]: User.tweet_set\nOut[7]: <peewee.ReverseRelationDescriptor at 0x7f42ac136490>\n```\n", "> What you have there is really no different from the current behavior.\n\nWell, I know that. But I want to take control over this naming…\n", "@coleifer can you reconsider this? In my point of view it does not hurt, while allowing user to customize easily related names.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/844/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/844", "html_url": "https://github.com/coleifer/peewee/pull/844", "diff_url": "https://github.com/coleifer/peewee/pull/844.diff", "patch_url": "https://github.com/coleifer/peewee/pull/844.patch", "merged_at": null }

{ "login": "alexanderad", "id": 888394, "node_id": "MDQ6VXNlcjg4ODM5NA==", "avatar_url": "https://avatars.githubusercontent.com/u/888394?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alexanderad", "html_url": "https://github.com/alexanderad", "followers_url": "https://api.github.com/users/alexanderad/followers", "following_url": "https://api.github.com/users/alexanderad/following{/other_user}", "gists_url": "https://api.github.com/users/alexanderad/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexanderad/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexanderad/subscriptions", "organizations_url": "https://api.github.com/users/alexanderad/orgs", "repos_url": "https://api.github.com/users/alexanderad/repos", "events_url": "https://api.github.com/users/alexanderad/events{/privacy}", "received_events_url": "https://api.github.com/users/alexanderad/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You can use `more_itertools` to flatten that.\n\n``` python\nIn [1]: import more_itertools\n\nIn [2]: l = [(1,), (2, ), (3, )]\n\nIn [3]: list(more_itertools.flatten(l))\nOut[3]: [1, 2, 3]\n```\n", "I can use `itertools` as well (which is part of stdlib contrary to `more_itertools`), but this is not a question _how_ to do that:\n\n``` python\nIn [4]: list(itertools.chain(*[(1,), (2, ), (3,)]))\nOut[4]: [1, 2, 3]\n```\n\nThis is rather a convenient shortcut.\n", "I'm going to pass on this feature, as it is fairly easy to implement on your own. If you really want, instead of a list of row tuples, a list of scalar values - then you can write either `map(query, operator.itemgetter(0))` or something similar.\n", "+1, programmers are lazy\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/843/reactions", "total_count": 3, "+1": 3, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "fmazan", "id": 12230333, "node_id": "MDQ6VXNlcjEyMjMwMzMz", "avatar_url": "https://avatars.githubusercontent.com/u/12230333?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fmazan", "html_url": "https://github.com/fmazan", "followers_url": "https://api.github.com/users/fmazan/followers", "following_url": "https://api.github.com/users/fmazan/following{/other_user}", "gists_url": "https://api.github.com/users/fmazan/gists{/gist_id}", "starred_url": "https://api.github.com/users/fmazan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fmazan/subscriptions", "organizations_url": "https://api.github.com/users/fmazan/orgs", "repos_url": "https://api.github.com/users/fmazan/repos", "events_url": "https://api.github.com/users/fmazan/events{/privacy}", "received_events_url": "https://api.github.com/users/fmazan/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Just do this:\n\n``` python\nfrom peewee import *\nJOIN['STRAIGHT'] = 'STRAIGHT'\n\nmy_query = SomeObj.select().join(SomeOther, JOIN.STRAIGHT)\n```\n", "This doesn't work anymore in version 3, due to:\r\n\r\n\r\n```\r\nclass Join(BaseTable):\r\n...\r\n def __sql__(self, ctx):\r\n (ctx\r\n .sql(self.lhs)\r\n .literal(' %s JOIN ' % self.join_type)\r\n .sql(self.rhs))\r\n if self._on is not None:\r\n ctx.literal(' ON ').sql(self._on)\r\n return ctx\r\n```", "Are you sure about that? Seems to work for me:\r\n\r\n```python\r\n\r\nIn [1]: from peewee import *\r\n\r\nIn [2]: JOIN['STRAIGHT'] = 'STRAIGHT'\r\n\r\nIn [3]: class Foo(Model):\r\n ...: pass\r\n ...: \r\n\r\nIn [4]: class Bar(Model):\r\n ...: foo = ForeignKeyField(Foo)\r\n ...: \r\n\r\nIn [5]: query = Bar.select().join(Foo, JOIN.STRAIGHT)\r\n\r\nIn [6]: query.sql()\r\nOut[6]: \r\n('SELECT \"t1\".\"id\", \"t1\".\"foo_id\" FROM \"bar\" AS \"t1\" STRAIGHT JOIN \"foo\" AS \"t2\" ON (\"t1\".\"foo_id\" = \"t2\".\"id\")',\r\n [])\r\n\r\n```", "The problem is that the STRAIGHT_JOIN is written with an underscore, it's not space separated. Oh well, those MySQL quirks...", "Ahh, thanks for the explanation. Let me look into it.", "Yeah, the code doesn't seem to support that very well...going to leave as wontfix for now." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/842/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }