package org.taverna.server.master.worker;

import java.security.NoSuchAlgorithmException;
import java.security.SecureRandom;

import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;

/**
 * A simple password issuing bean.
 * 
 * @author Donal Fellows
 */
public class PasswordIssuer {
	private static final char[] ALPHABET = { 'a', 'b', 'c', 'd', 'e', 'f', 'g',
			'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't',
			'u', 'v', 'w', 'x', 'y', 'z', 'A', 'B', 'C', 'D', 'E', 'F', 'G',
			'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T',
			'U', 'V', 'W', 'X', 'Y', 'Z', '1', '2', '3', '4', '5', '6', '7',
			'8', '9', '0', '!', '@', '#', '$', '%', '^', '&', '*', '(', ')',
			',', '.', '<', '>', '/', '?', ':', ';', '-', '_', '+', '[', ']',
			'{', '}', '`', '~' };
	private Log log = LogFactory.getLog("Taverna.Server.Worker");
	private SecureRandom r;
	private int length;

	public PasswordIssuer() {
		r = new SecureRandom();
		log.info("constructing passwords with " + r.getAlgorithm());
		setLength(8);
	}

	public PasswordIssuer(String algorithm) throws NoSuchAlgorithmException {
		r = SecureRandom.getInstance(algorithm);
		log.info("constructing passwords with " + r.getAlgorithm());
		setLength(8);
	}

	public void setLength(int length) {
		this.length = length;
		log.info("issued password will be " + this.length
				+ " symbols chosen from " + ALPHABET.length);
	}

	/**
	 * Issue a password.
	 * 
	 * @return The new password.
	 */
	public String issue() {
		StringBuilder sb = new StringBuilder();
		for (int i = 0; i < length; i++)
			sb.append(ALPHABET[r.nextInt(ALPHABET.length)]);
		log.info("issued new password of length " + sb.length());
		return sb.toString();
	}
}

package org.taverna.server.master.worker;

import java.security.NoSuchAlgorithmException;
import java.security.SecureRandom;

import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;

/**
 * A simple password issuing bean.
 * 
 * @author Donal Fellows
 */
public class PasswordIssuer {
	private static final char[] ALPHABET = { 'a', 'b', 'c', 'd', 'e', 'f', 'g',
			'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't',
			'u', 'v', 'w', 'x', 'y', 'z', 'A', 'B', 'C', 'D', 'E', 'F', 'G',
			'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T',
			'U', 'V', 'W', 'X', 'Y', 'Z', '1', '2', '3', '4', '5', '6', '7',
			'8', '9', '0', '_' };
	private Log log = LogFactory.getLog("Taverna.Server.Worker");
	private SecureRandom r;
	private int length;

	public PasswordIssuer() {
		r = new SecureRandom();
		log.info("constructing passwords with " + r.getAlgorithm());
		setLength(8);
	}

	public PasswordIssuer(String algorithm) throws NoSuchAlgorithmException {
		r = SecureRandom.getInstance(algorithm);
		log.info("constructing passwords with " + r.getAlgorithm());
		setLength(8);
	}

	public void setLength(int length) {
		this.length = length;
		log.info("issued password will be " + this.length
				+ " symbols chosen from " + ALPHABET.length);
	}

	/**
	 * Issue a password.
	 * 
	 * @return The new password.
	 */
	public String issue() {
		StringBuilder sb = new StringBuilder();
		for (int i = 0; i < length; i++)
			sb.append(ALPHABET[r.nextInt(ALPHABET.length)]);
		log.info("issued new password of length " + sb.length());
		return sb.toString();
	}
}

Reduce the size of the symbol set used for passwords to ensure that they cannot be misinterpreted by anything.