package com.kalessil.phpStorm.phpInspectionsEA.inspectors.strictOperators;

import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ProblemsHolder;
import com.intellij.psi.PsiElementVisitor;
import com.jetbrains.php.lang.psi.elements.ArrayAccessExpression;
import com.kalessil.phpStorm.phpInspectionsEA.openApi.BasePhpElementVisitor;
import com.kalessil.phpStorm.phpInspectionsEA.openApi.BasePhpInspection;
import org.jetbrains.annotations.NotNull;

public class StrictArrayAccessInspector extends BasePhpInspection {
    private static final String strProblemDescriptionArrayAccess = "Index-based access to not array (type is %t%).";
    private static final String strProblemDescriptionStringAccess = "Character offset access to not string (type is %t%).";

    @NotNull
    public String getShortName() {
        return "StrictArrayAccessInspection";
    }

    @Override
    public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
        return new BasePhpElementVisitor() {
            public void visitPhpArrayAccessExpression(final ArrayAccessExpression expr) {
                final PhpExpressionTypes type = new PhpExpressionTypes(expr.getValue(), holder);
                final String strWarning;

                if (expr.textContains('[')) {
                    if (type.isArray() || type.isString() || type.isArrayAccess()) {
                        return;
                    }
                    strWarning = strProblemDescriptionArrayAccess.replace("%t%", type.toString());
                } else {
                    if (type.isString()) {
                        return;
                    }
                    strWarning = strProblemDescriptionStringAccess.replace("%t%", type.toString());
                }

                holder.registerProblem(expr, strWarning, ProblemHighlightType.WEAK_WARNING);
            }
        };
    }
}

package com.kalessil.phpStorm.phpInspectionsEA.inspectors.strictOperators;

import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ProblemsHolder;
import com.intellij.psi.PsiElementVisitor;
import com.jetbrains.php.lang.psi.elements.ArrayAccessExpression;
import com.kalessil.phpStorm.phpInspectionsEA.openApi.BasePhpElementVisitor;
import com.kalessil.phpStorm.phpInspectionsEA.openApi.BasePhpInspection;
import org.jetbrains.annotations.NotNull;

public class StrictArrayAccessInspector extends BasePhpInspection {
    private static final String strProblemDescriptionArrayAccess = "Index-based access to not array (type is %t%).";
    private static final String strProblemDescriptionStringAccess = "Character offset access to not string (type is %t%).";

    @NotNull
    public String getShortName() {
        return "StrictArrayAccessInspection";
    }

    @Override
    public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
        return new BasePhpElementVisitor() {
            public void visitPhpArrayAccessExpression(final ArrayAccessExpression expr) {
                final PhpExpressionTypes type = new PhpExpressionTypes(expr.getValue(), holder);
                final String strWarning;

                if (expr.getLastChild().textMatches("]")) {
                    if (type.isArray() || type.isString() || type.isArrayAccess()) {
                        return;
                    }
                    strWarning = strProblemDescriptionArrayAccess.replace("%t%", type.toString());
                } else {
                    if (type.isString()) {
                        return;
                    }
                    strWarning = strProblemDescriptionStringAccess.replace("%t%", type.toString());
                }

                holder.registerProblem(expr, strWarning, ProblemHighlightType.WEAK_WARNING);
            }
        };
    }
}

fix and speed up check for array access (previously failed on string-offset expression $var[0]{0})