Datasets:

bug-localization

/

apache_bugs

like 0

Follow

BLAZE 1

Bug 84260 import static fails when importing a method

I got the following error: ============================================== MyClass2.java:3 [error] The import MyClass.myMethod cannot be resolved import static MyClass.myMethod; ============================================== other import static statements (Strings/Enums) appear to work.

resolved fixed

f747b82

["tests/bugs150/pr84260/A.java", "tests/bugs150/pr84260/I1.java", "tests/bugs150/pr84260/I2.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 98646 parser cannot parse varargs correctly

the following cannot be parsed: call(* *(int, Integer...)) see in modules/weaver/.../PointcutVisitorTest (uncomment the testTemp()) See "FIXME AV for Adrian" comments in PatternParser. Half fix but then fails for other tests. Adrian can you have a look at it ? Thanks

resolved fixed

743566f

["weaver/src/org/aspectj/weaver/patterns/BasicTokenSource.java", "weaver/src/org/aspectj/weaver/patterns/PatternParser.java", "weaver/testsrc/org/aspectj/weaver/patterns/VisitorTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 94167 NPE in reflect implementation

Proposed fix (I'd like input on how to best add test cases for this so I can submit a tested patch); I believe this will work because if you uncomment the work-around line, it works): Change line 63 from: method = declaringType.getDeclaredMethod (getName(),getParameterTypes()); to method = getDeclaringType().getDeclaredMethod (getName(),getParameterTypes()); Test source: package reflect; import org.aspectj.lang.*; import org.aspectj.lang.reflect.*; import java.lang.reflect.*; aspect Test { before() : call(* *(..)) && !within(Test) { MethodSignature sig = (MethodSignature)thisJoinPoint.getSignature(); //sig.getDeclaringType(); // uncomment to work-around Method method = sig.getMethod(); } } public class MinimalErr { public static void main(String args[]) { try { Inner.foo(); } catch (Throwable t) { t.printStackTrace(); } } public static class Inner { public static void foo() {} } }

resolved fixed

3824b1c

["runtime/src/org/aspectj/runtime/reflect/AdviceSignatureImpl.java", "runtime/src/org/aspectj/runtime/reflect/MethodSignatureImpl.java", "tests/bugs150/PR94167.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 81846 EclipseAdapterUtils.java:83

java.lang.ArrayIndexOutOfBoundsException: 3 Unfortunately I can't provide much more information, please see the attached compiler dump.

resolved fixed

a675b65

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/EclipseAdapterUtils.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 96371 Patch to support loading aop.xml properly

AspectJ 5 load-time weaving in CVS HEAD isn't loading aop.xml files properly from a jar file without specifying the global -D flag. The following patch fixes the problem for me so I can load aop.xml files from jars on the classpath without a global flag: ClassLoaderWeavingAdaptor.java:109: - Enumeration xmls = loader.getResources("/META-INF/aop.xml"); + Enumeration xmls = loader.getResources("META-INF/aop.xml"); I.e., getResources doesn't work with a leading separator, at least not on the Sun VM or JRockIt on Windows. Writing a unit test for this would require significant changes to the loadtime module, so I wrote a standalone test of the API: public class TestApi extends TestCase { public void testLoadResource() throws Exception { URL urlList[] = { new URL ("file:testsrc/org/aspectj/weaver/loadtime/test/sample.jar") }; ClassLoader loader = new URLClassLoader(urlList); Enumeration xmls = loader.getResources("META-INF/aop.xml"); //this version fails: //Enumeration xmls = loader.getResources("/META-INF/aop.xml"); assertTrue(xmls.hasMoreElements()); } }

resolved fixed

f14646f

["loadtime/src/org/aspectj/weaver/loadtime/ClassLoaderWeavingAdaptor.java", "loadtime5/java5-src/org/aspectj/weaver/loadtime/ClassPreProcessorAgentAdapter.java", "tests/java5/ataspectj/ataspectj/SingletonAspectBindingsTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 94086 Exploding compile time with if() statements in pointcut

Compile time explodes when adding if(...) statements to pointcuts. This is the same with ajc 1.2.1 and 1.5M2 although 1.5M2 is a little bit faster, but compile time still explodes. Example: pointcut pc2() : (execution(* Test.a(..)) && if(sl.isEnabled()) ) || (execution(* Test.a(..)) && if(sl.isEnabled()) ) compiled in about 1 second. Up to 7 such conditions , eg. pointcut Pc7() : (execution(* Test.a(..)) && if (sl.isEnabled())) || (execution(* Test.b(..)) && if (sl.isEnabled())) || (execution(* Test.c(..)) && if (sl.isEnabled())) || (execution(* Test.d(..)) && if (sl.isEnabled())) || (execution(* Test.e(..)) && if (sl.isEnabled())) || (execution(* Test.f(..)) && if (sl.isEnabled())) || (execution(* Test.g(..)) && if (sl.isEnabled())); are also compiled quite quickly (~ 3 seconds with both ajc 1.2.1 and 1.5M2). Now, adding another condition (8 lines) causes 6 seconds compile time. Adding yet another condition line (= 9 ex. lines) causes ~ 1 min compile time! (10 such lines even more than 8 minutes) Sample source code below ------------------------ // ########## Aspect.aj ############### public aspect Aspect { private static final SimpleLogger sl = new SimpleLogger(); pointcut PC() : (execution(* Test.a(..)) && if (sl.isEnabled())) || (execution(* Test.b(..)) && if (sl.isEnabled())) || (execution(* Test.c(..)) && if (sl.isEnabled())) || (execution(* Test.d(..)) && if (sl.isEnabled())) || (execution(* Test.e(..)) && if (sl.isEnabled())) || (execution(* Test.f(..)) && if (sl.isEnabled())) || (execution(* Test.g(..)) && if (sl.isEnabled())) || (execution(* Test.h(..)) && if (sl.isEnabled())) || (execution(* Test.i(..)) && if (sl.isEnabled())) || (execution(* Test.j(..)) && if (sl.isEnabled())) ; before() : PC() { sl.log("Before"); } after() : PC() { sl.log("After"); } } // ########## Test.java ###############

resolved fixed

88d477d

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/patterns/IfPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 84312 Finish implementation of *runtime* retention checking

See FIXME in BindingAnnotationTypePattern.resolveBinding() and EclipseSourceType.getAnnotationTypes()

resolved fixed

f9eebd4

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseSourceType.java", "weaver/src/org/aspectj/weaver/patterns/BindingAnnotationTypePattern.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 86832 Internal compiler error (generics?)

Attached is project that will generate an "Internal compiler error" for a single class that extends "ArrayList<Object>". If the class extends just "ArrayList" the compiler error does not occur. Note that the "extends ArrayList<Object>" class compiles successuflly without the aspectj nature. --- exception --- Severity Description Resource In Folder Location Creation Time 2 Internal compiler error java.lang.NullPointerException at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.ClassScope.detectHierarchyCycle(ClassScope.java:945) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.ParameterizedSingleTypeReference.internalResolveType(ParameterizedSingleTypeReference.java:143) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.ParameterizedSingleTypeReference.resolveType(ParameterizedSingleTypeReference.java:208) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeReference.resolveSuperType(TypeReference.java:112) at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.ClassScope.findSupertype(ClassScope.java:1092) at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.ClassScope.connectSuperclass(ClassScope.java:747) at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.ClassScope.connectTypeHierarchy(ClassScope.java:884) at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.CompilationUnitScope.connectTypeHierarchy(CompilationUnitScope.java:249) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.completeTypeBindings(AjLookupEnvironment.java:91) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.beginToCompile(Compiler.java:331) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:348) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:682) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild(AjBuildManager.java:168) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:102) at org.aspectj.ajde.internal.CompilerAdapter.compile(CompilerAdapter.java:122) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run(AspectJBuildManager.java:165) FlattenedListExtendsArrayListObject.java opentrader.infra/src/org/opentrader/infra/springframework February 28, 2005 9:59:42 AM

resolved fixed

0cb826c

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 82755 [ajdoc] update ajdoc to support Java 5 language features

Java 5 langauge features such as enums and annotations need to be supported by ajdoc.

resolved fixed

7b7c7b2

["ajdoc/src/org/aspectj/tools/ajdoc/Declaration.java", "ajdoc/src/org/aspectj/tools/ajdoc/StubFileGenerator.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmHierarchyBuilder.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 93345 unresolved joinpoint in cflow causes ClassCastException on BcelWeaver:933

I'm getting ClassCastException while compiling following code: ---- Test.java ---- class AClass { // void method() {} } aspect AnAspect { pointcut annt() : cflow( execution(* *(..)) ); before() : annt() { System.out.println("before annt"); } } ---- Here's output of the compiler: --- out --- java.lang.ClassCastException: org.aspectj.weaver.ResolvedMember at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:933) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.weave(AjCompilerAdapter.java:244) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.afterCompiling(AjCompilerAdapter.java:119) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:385) [cut] ------ The problem is caused by cflow on unresolved (not existing) jointpoint. When you uncomment the method() in AnClass, the problem disappears. I found this bug when I was introducing an aspect (which has pointcuts based on annotations) to fresh object-oriented system without annotated classes. When I started to annotate the classes problem disappeared. Following code illustates (simplified) situation: --- Test2.java --- import java.lang.annotation.*; @Target(ElementType.METHOD) @interface Ann {} class AClass { // @Ann void method() {} } aspect AnAspect { pointcut annt() : cflow( execution(@Ann * *(..)) ); before() : annt() { System.out.println("before annt"); } } ---- I'm attaching those sources and ajcore files. Best regards, Michal

resolved fixed

f603458

["tests/src/org/aspectj/systemtest/ajc150/AllTestsAspectJ150.java", "tests/src/org/aspectj/systemtest/ajc150/StaticImports.java", "tests/src/org/aspectj/systemtest/ajc150/SuppressedWarnings.java", "weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 87282 Compilation error on generic member introduction

The compiler aborts with the following introduction code: aspect introductionToA{ private ArrayList<B> A.m_Array = new ArrayList<B>(); public void A.addB(B tmp){ m_Array.add(tmp); } } The error message is "[error] The method add(E) in the type ArrayList<E> is not applicable for the arguments (B) m_Array.add(tmp)" Compiling with AspectJ Development version (2005/02/18).

resolved fixed

51c018d

["tests/src/org/aspectj/systemtest/ajc150/GenericsTests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 91053 Generics problem with Set - does not compile with AspectJ 5

I tried different things to remove compiler warnings about generics which you get when you switch to JDK 5 and use collections. At last I fall back to JDK 1.4. The following code compiles with AspectJ 5 and JDK compliance level 1.4: public aspect SubjectAspect { private Set Subject.observers = new HashSet(); public void Subject.addObserver(SubjectObserver observer) { observers.add(observer); } ... } After switching to compliance level 5.0 I get an error message "The method add(E) in the type Set<E> is not applicable for the arguments (SubjectObserver)". I don't know if it is a similar problem like #87550 but I means for older projects which use collections that they can't switch to JDK 1.5

resolved fixed

952dda9

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java", "tests/src/org/aspectj/systemtest/ajc150/GenericsTests.java", "weaver/src/org/aspectj/weaver/TypeX.java", "weaver/src/org/aspectj/weaver/World.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 91267 NPE at EclipseFactory.java:143 when using generic methods in aspects

When I compile any of these two aspects with ajc -1.5, an exception is thrown by the compiler: import java.util.*; public aspect TestBug1 { static <T> void addToEnv(Map<String,T> env, String key, T value) { env.put(key, value); } } import java.util.*; public aspect TestBug2 { static <T> T lookupEnv(Map<String,T> env, String key) { return env.get(key); } } If the methods are placed into classes instead of aspects, all works fine. The exception thrown is the following: java.lang.NullPointerException at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.getName(EclipseFactory.java:143) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.fromBinding(EclipseFactory.java:166) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.fromBindings(EclipseFactory.java:176) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.makeResolvedMember(EclipseFactory.java:254) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.makeResolvedMember(EclipseFactory.java:249) at org.aspectj.ajdt.internal.compiler.lookup.EclipseSourceType.fillDeclaredMembers(EclipseSourceType.java:115) at org.aspectj.ajdt.internal.compiler.lookup.EclipseSourceType.getDeclaredPointcuts(EclipseSourceType.java:146) at org.aspectj.ajdt.internal.compiler.ast.AspectDeclaration.buildInterTypeAndPerClause(AspectDeclaration.java:977) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.buildInterTypeAndPerClause(AjLookupEnvironment.java:303) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.completeTypeBindings(AjLookupEnvironment.java:119) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.beginToCompile(Compiler.java:331) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:348) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:683) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild(AjBuildManager.java:168) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:102) at org.aspectj.ajdt.ajc.AjdtCommand.doCommand(AjdtCommand.java:109) at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(AjdtCommand.java:60) at org.aspectj.tools.ajc.Main.run(Main.java:291) at org.aspectj.tools.ajc.Main.runMain(Main.java:227) at org.aspectj.tools.ajc.Main.main(Main.java:80)

resolved fixed

7389d9f

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java", "tests/src/org/aspectj/systemtest/ajc150/GenericsTests.java", "weaver/src/org/aspectj/weaver/TypeX.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 91719 Work with Oli B to pull in examples of generating all the LINT messages

resolved fixed

70b9ffd

["tests/bugs/seven/lint/Main.java", "tests/src/org/aspectj/systemtest/xlint/XLintTests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 92906 showWeaveInfo for declare annotations

declaring annotations (declare @type, @constructor, @method and @field) currently doesn't show a message when the -showWeaveInfo option is set in ajc. Appropriate messages should be displayed.

resolved fixed

abc9a58

["ajde/testsrc/org/aspectj/ajde/ShowWeaveMessagesTestCase.java", "bridge/src/org/aspectj/bridge/WeaveMessage.java", "weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java", "weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java", "weaver/src/org/aspectj/weaver/bcel/Utility.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 92630 Null Pointer Exception thrown by ajc compiler

resolved fixed

02f75ba

["weaver/src/org/aspectj/weaver/bcel/UnwovenClassFile.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 91912 Request for a new type of relationship in the structure model

Declare soft relationships are currently 'advises' and 'advised by' relationships. Would it be possible to add 'softens' and 'softened by' (or 'softens exception at' and 'exception softened by') relationships to the structure model?

resolved fixed

7a61380

["asm/src/org/aspectj/asm/IRelationship.java", "weaver/src/org/aspectj/weaver/AsmRelationshipProvider.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 92053 @args causes a VerifyError: Unable to pop operand off an empty stack

I'm getting a VerifyError exception when I try to use @args in following code: ------------------ Test3.java ------------------------- import java.lang.annotation.*; @Target(ElementType.TYPE) @Retention(RetentionPolicy.RUNTIME) @interface Ann {} @Ann class AClass{} public class Test3 { void abc(AClass y) {} public static void main(String[] args) { new Test3().abc(new AClass()); } } aspect Annotations { before(Ann ann) : call(* Test3.*(..)) && @args(ann) { System.out.println("Before: " + thisJoinPoint); } } ---- On JRockIt5 jre and AspectJ 1.5.0M2 I get following result: ----------- java.lang.VerifyError: (class: Test3, method: main signature: ([Ljava/lang/String;)V) Unable to pop operand off an empty stack ----------- I'm getting similar error with sun jre and with older versions of AspectJ5 (20050324155000 and from 10th feb).

resolved fixed

3f942a4

["tests/java5/annotations/binding/bugs/Test3.java", "tests/src/org/aspectj/systemtest/ajc150/AnnotationBinding.java", "weaver/src/org/aspectj/weaver/patterns/ArgsAnnotationPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 91858 NullPointerException when declare @type is spelt with capital letter

I have the following code in an AspectJ project: declare @Type: MainClass : @MyAnnotation; I believe the correct syntax should be: declare @type: MainClass : @MyAnnotation; However when I saved my aspect with the first version I got the following NullPointerException: java.lang.NullPointerException at org.aspectj.ajdt.internal.compiler.ast.DeclareAnnotationDeclaration.postParse (DeclareAnnotationDeclaration.java:83) at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.ClassScope.postParse (ClassScope.java:175) at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.ClassScope.buildFieldsAndM ethods(ClassScope.java:154) at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.CompilationUnitScope.build FieldsAndMethods(CompilationUnitScope.java:63) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.completeTypeBindi ngs(AjLookupEnvironment.java:104) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.beginToCompile (Compiler.java:331) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile (Compiler.java:348) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation (AjBuildManager.java:683) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild (AjBuildManager.java:191) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.incrementalBuild (AjBuildManager.java:109) at org.aspectj.ajde.internal.CompilerAdapter.compile (CompilerAdapter.java:117) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run (AspectJBuildManager.java:165)

resolved fixed

78abc76

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/DeclareAnnotationDeclaration.java", "tests/src/org/aspectj/systemtest/ajc150/DeclareAnnotationTests.java", "weaver/src/org/aspectj/weaver/patterns/PatternParser.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 82171 enable ASM interoperability with JavaCore via uniform element handles

resolved fixed

df7fff4

["asm/src/org/aspectj/asm/AsmManager.java", "asm/src/org/aspectj/asm/IElementHandleProvider.java", "asm/src/org/aspectj/asm/internal/AspectJElementHierarchy.java", "asm/src/org/aspectj/asm/internal/FullPathHandleProvider.java", "asm/src/org/aspectj/asm/internal/ProgramElement.java", "docs/sandbox/api-clients/org/aspectj/samples/AsmRelationshipMapExtensionTest.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/AsmInterTypeRelationshipProvider.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmHierarchyBuilder.java", "weaver/src/org/aspectj/weaver/AsmRelationshipProvider.java", "weaver/src/org/aspectj/weaver/ShadowMunger.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 90588 compiler verifyerror and an NPE

resolved fixed

d697649

["tests/bugs150/pr90588/AbstractClass.java", "tests/bugs150/pr90588/ConcreteClass.java", "tests/src/org/aspectj/systemtest/knownfailures/KnownfailuresTests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 85297 Improvements to incremental compilation

resolved fixed

e460b1e

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjState.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/IStateListener.java", "tests/src/org/aspectj/systemtest/incremental/IncrementalTests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 88862 Declare annotation on ITDs

I'll use this bug to capture info on the implementation...

resolved fixed

0d14ccf

["tests/src/org/aspectj/systemtest/ajc150/AnnotationBinding.java", "tests/src/org/aspectj/systemtest/ajc150/Annotations.java", "weaver/src/org/aspectj/weaver/NewFieldTypeMunger.java", "weaver/src/org/aspectj/weaver/ResolvedMember.java", "weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java", "weaver/src/org/aspectj/weaver/bcel/BcelShadow.java", "weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java", "weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java", "weaver/src/org/aspectj/weaver/patterns/AnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/SignaturePattern.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 84333 BCException: Bad type name: TypeX.nameToSignature(TypeX.java:635)

resolved fixed

fb01cad

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "tests/src/org/aspectj/systemtest/ajc150/GenericsTests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 84122 Allow aspectPath to contain directories

The -aspectpath option to the compiler only allows jar/zip files, not directories. But inpath and classpath allow directories. This capability would improve the handling of aspects spanning multiple projects in Eclipse. AJDT can currently only support jar/zip files on the aspect path, which requires one of the projects to create an outjar instead of writing to the bin directory as usual. The iajc ant task could then also be enhanced to support aspectpath directories.

resolved fixed

68f6350

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/BuildArgParser.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjState.java", "tests/options/aspectpath/MyClass.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 76055 Some Pointcut PatternNodes are missing getters to traverse syntax tree

In order to find out which other pointcuts are referenced by a pointcut definition i need to access the private members of the CflowPointcut, IfPointcut and NotPointcut PatternNodes found in the weaver module. Unlike the OrPointcut and AndPointcut classes, they are missing the appropriate getter methods.

resolved fixed

b0f270e

["weaver/src/org/aspectj/weaver/patterns/CflowPointcut.java", "weaver/src/org/aspectj/weaver/patterns/IfPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 88652 an array type as the last parameter in a signature does not match on the varargs declared method

I get this warning in my code, though I actually do not specify an array type. The signature I want to match is the following constructor signature: public Touple(Object formulaHandle, Object... propositions) {...} Touple implements IRelation The pointcut I use is the following: pointcut p(): call(Touple.new(..)); This should actually match the signature, shouldn't it? AspectJ however complains with this warning: an array type as the last parameter in a signature does not match on the varargs declared method: void ltlrv.Touple.<init>(java.lang.Object, java.lang.Object[]) [Xlint:cantMatchArrayTypeOnVarargs] Also, even if I *had* stated an array type, it should match even then IMHO, since arrays and varargs are actually the same in the Java implementation.

resolved fixed

b5f4d09

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/patterns/ExactTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/SignaturePattern.java", "weaver/src/org/aspectj/weaver/patterns/TypePattern.java", "weaver/src/org/aspectj/weaver/patterns/WildTypePattern.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 87376 NPE when unresolved type of a bound var in a pointcut expression (EclipseFactory.java:224)

see attached mini-project to reproduce

resolved fixed

85aa152

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmHierarchyBuilder.java", "tests/bugs150/pr87376/I.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 86789 annotations and "circularity in declare precedence"

resolved fixed

f90186c

["weaver/src/org/aspectj/weaver/patterns/WildTypePattern.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 83565 BCException "bad type name" thrown when compiling

I just downloaded AJDT version 1.2.0.20050124144759 and I am running Eclipse 3.1M4. I tried to use aspectJ on an existing Java 5 project. There are no aspects in it yet, just straight Java 5. The project runs just fine as a standard Java project. When add the AspectJ nature and I try to compile the project, no class files are generated and I get this error generated on a type that is parameterized: Internal compiler error org.aspectj.weaver.BCException: Bad type name: at org.aspectj.weaver.TypeX.nameToSignature(TypeX.java:634) at org.aspectj.weaver.TypeX.forName(TypeX.java:87) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.fromBinding(EclipseFactory.java:155) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.fromBindings(EclipseFactory.java:163) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.makeResolvedMember(EclipseFactory.java:229) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.makeResolvedMember(EclipseFactory.java:224) at org.aspectj.ajdt.internal.core.builder.AsmHierarchyBuilder.visit(AsmHierarchyBuilder.java:675) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.ConstructorDeclaration.traverse(ConstructorDeclaration.java:447) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.traverse(TypeDeclaration.java:1133) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.traverse(CompilationUnitDeclaration.java:314) at org.aspectj.ajdt.internal.core.builder.AsmHierarchyBuilder.internalBuild(AsmHierarchyBuilder.java:171) at org.aspectj.ajdt.internal.core.builder.AsmHierarchyBuilder.buildStructureForCompilationUnit(AsmHierarchyBuilder.java:111) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.finishedCompilationUnit(EclipseFactory.java:354) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.afterProcessing(AjCompilerAdapter.java:138) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:373) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:682) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild(AjBuildManager.java:168) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:102) at org.aspectj.ajde.internal.CompilerAdapter.compile(CompilerAdapter.java:122) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run(AspectJBuildManager.java:165) The source code of the file that generates this error is: package mj.compiler.ast; import java.util.Vector; import mj.compiler.Driver; import mj.compiler.Visitor; public class Sequence<T extends AST> extends AST { private Vector<T> elements = new Vector<T>(); public Sequence() { super(0, 0); } public Sequence(T element) { super(element); elements.add(element); } public int length() { return elements.size(); } public T elementAt(int i) { return elements.elementAt(i); } public Sequence add(T element) { elements.add(element); return this; } public Sequence add(int pos, T element) { elements.add(pos, element); return this; } public Sequence addAll(Sequence<T> others) { if( others == null ) return this; elements.addAll(others.elements); return this; } public void visitChildren(Visitor v) { for( AST element : elements ) { element.visit(v); } } public void replaceChild(AST old, AST gnu) { T NEW = (T)gnu; for(int i = 0; i < elements.size(); i++ ) { if( elements.get(i) == old ) { elements.set(i, NEW); return; } } throw new Driver.CompileError("Can't find child in replaceChild."); } /*** START GENERATED VISITOR PROTOCOL ***///TODO public void visit(mj.compiler.Visitor v) { v.visitSequence(this); } /*** END GENERATED VISITOR PROTOCOL ***/ } Hope this helps something. ps- I am able to create and run a very simple AspectJ project with an aspect, advice, and some Java 5 syntax.

resolved fixed

5765d53

["ajde/testdata/bug-83565/Bug.java", "ajde/testsrc/org/aspectj/ajde/AjdeTests.java", "ajde/testsrc/org/aspectj/ajde/GenericsTest.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmHierarchyBuilder.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 83626 @AJ

Andy wants a patch format + a bugzilla for @AJ work due to some funny license issue. Here it is as drafted

resolved fixed

7b4c7d7

["bcel-builder/src/org/aspectj/apache/bcel/generic/MethodGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 83563 pertypewithin() handing of inner classes

resolved fixed

1b01255

["tests/bugs150/PR83563_1.java", "tests/bugs150/PR83563_2.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150TestsNoHarness.java", "weaver/src/org/aspectj/weaver/PerTypeWithinTargetTypeMunger.java", "weaver/src/org/aspectj/weaver/patterns/PerTypeWithin.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 83303 complier error when mixing inheritance, overriding and polymorphism

Given this scenario: - class A define method m1 (with proteceted visibility) - class B extends class A and implements interface I and override method m1 (but with public visibility) - interface I define method m1 (with public visibility) The code is correct and compile using java 1.4 Let's modify the scenario: move the method B.m1 into a method introduction on aspect C, such that - class B extends class A - apsect C intosuces method m1 into B (with public visibility) and makes B implemts I (declare parents) - A and I as before The compiler reports this error: B.java:1 [error] The inherited method A.m1() cannot hide the public abstract method in I class B extends A {

resolved fixed

5d281fd

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/problem/AjProblemReporter.java", "tests/bugs150/PR83303.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150TestsNoHarness.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 82340 Visibility selector ignored for pointcuts

Using ajdoc under AJDT 1.1.12 or AspectJ 1.2.1 at the commandline has the following aspect has problems. public abstract aspect Aspect { private pointcut privatePointcut (); protected pointcut protectedPointcut (); public pointcut publicPointcut (); private void privateMethod () { } public void protectedMethod () { } public void publicMethod () { } } 1. Asking for "protected" gives all pointcuts (public, protected _and_ private) 2. The Aspect entry is wrong: "public abstract class Aspect" 3. The "Methods inherited ..." section has a leading comma: ", clone, equals, finalize, ..."

resolved fixed

b460597

["ajdoc/src/org/aspectj/tools/ajdoc/HtmlDecorator.java", "ajdoc/src/org/aspectj/tools/ajdoc/StubFileGenerator.java", "ajdoc/testdata/bug82340/Pointcuts.java", "ajdoc/testdata/coverage/foo/NoMembers.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/CoverageTestCase.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/PointcutVisibilityTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 82218 fails to doc spacewar using AJDT 1.2.0M2

Using AJDT 1.2.0M2 {with Java 5 JRE on XP SP2}, install Spacewar example and generate to Spacewar/docs. Result: output has no cross-references (and displays special AJDT tags), and stderr lists this exception: java.lang.StringIndexOutOfBoundsException: String index out of range: -1 at java.lang.AbstractStringBuilder.insert(AbstractStringBuilder.java:980) at java.lang.StringBuffer.insert(StringBuffer.java:447) at org.aspectj.tools.ajdoc.HtmlDecorator.insertDeclarationsDetails(HtmlDecorator.java:350) at org.aspectj.tools.ajdoc.HtmlDecorator.addAspectDocumentation(HtmlDecorator.java:234) at org.aspectj.tools.ajdoc.HtmlDecorator.decorateHTMLFile(HtmlDecorator.java:188) at org.aspectj.tools.ajdoc.HtmlDecorator.decorateHTMLFromDecl(HtmlDecorator.java:116) at org.aspectj.tools.ajdoc.HtmlDecorator.decorateHTMLFromDecls(HtmlDecorator.java:54) at org.aspectj.tools.ajdoc.HtmlDecorator.decorateHTMLFromInputFiles(HtmlDecorator.java:43) at org.aspectj.tools.ajdoc.Main.main(Main.java:210)

resolved fixed

f70b383

["ajdoc/src/org/aspectj/tools/ajdoc/HtmlDecorator.java", "ajdoc/src/org/aspectj/tools/ajdoc/Util.java", "ajdoc/testdata/coverage/foo/ModelCoverage.java", "ajdoc/testdata/coverage/foo/NoMembers.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/CoverageTestCase.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/JDKVersionTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 78021 Injecting exception into while loop with break statement causes catch block to be ignored

In order to test exception scenarios in an existing framework, I have created an aspect to inject an exception. The exception is injected into some code running within a try/catch/finally block. After the exception is thrown, I am expecting control to pass to the catch block. However, what is happening is that the catch block code is not executed, control passes through the finally block and the (undeclared) exception is thrown to the calling method. Here is a distilled test case: public class MainClass { protected Integer counter; private int j; public static void main(String[] args) { MainClass mh = new MainClass(); try { mh.doSomething(); } catch (Exception e) { System.out.println("Exception thrown by doSomething!!!!!"); e.printStackTrace(); } } public void doSomething() { int i = 0; while (i++ < 1) { counter=null; try { counter = getCounter(); if (counter == null) { break; } commit(); } catch (Throwable e) { System.out.println("Caught exception " + e); } finally { System.out.println("In finally block"); } } } protected Integer getCounter() { return new Integer(j++); } protected void commit() throws SQLException { System.out.println("Main.commit"); } } The following aspect injects the exception: public aspect SimpleExceptionThrowingAspect { pointcut commitOperation() : call (* MainClass+.commit(..)); before() throws SQLException : commitOperation() { throw new SQLException("Dummy SQL Exception", "55102"); } } Expected output is: Caught exception java.sql.SQLException: Dummy SQL Exception In finally block Actual output is: In finally block Exception thrown by doSomething!!!!! java.sql.SQLException: Dummy SQL Exception at nz.govt.moh.test.SimpleExceptionThrowingAspect.ajc$before$nz_govt_moh_test_SimpleExceptionThrowingAspect$1$292c82f1(SimpleExceptionThrowingAspect.aj:10) at nz.govt.moh.test.MainClass.doSomething(MainClass.java:32) at nz.govt.moh.test.MainClass.main(MainClass.java:14) Removing the "break;" statement from MainClass.java causes the expected output to be produced.

resolved fixed

603b063

["tests/bugs150/PR78021.java", "tests/bugs150/PR79554.java", "tests/src/org/aspectj/systemtest/AllTests.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150TestsNoHarness.java", "tests/src/org/aspectj/systemtest/ajc150/AllTestsAspectJ150.java", "tests/src/org/aspectj/systemtest/ajc150/AllTestsJava5_binaryWeaving.java", "tests/src/org/aspectj/systemtest/ajc150/TestUtils.java", "weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 82134 AspectJ 5 M2 should implement backwards compatibility for binary aspect form

resolved fixed

797b6a6

["tests/src/org/aspectj/systemtest/ajc150/AllTestsJava5_binaryWeaving.java", "tests/src/org/aspectj/systemtest/ajc150/MigrationTests.java", "weaver/src/org/aspectj/weaver/AdviceKind.java", "weaver/src/org/aspectj/weaver/AjAttribute.java", "weaver/src/org/aspectj/weaver/ResolvedPointcutDefinition.java", "weaver/src/org/aspectj/weaver/VersionedDataInputStream.java", "weaver/src/org/aspectj/weaver/WeaverStateInfo.java", "weaver/src/org/aspectj/weaver/bcel/BcelAttributes.java", "weaver/src/org/aspectj/weaver/bcel/BcelField.java", "weaver/src/org/aspectj/weaver/bcel/BcelMethod.java", "weaver/src/org/aspectj/weaver/bcel/BcelObjectType.java", "weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java", "weaver/src/org/aspectj/weaver/patterns/AndAnnotationTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/AndPointcut.java", "weaver/src/org/aspectj/weaver/patterns/AndTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/AnnotationPatternList.java", "weaver/src/org/aspectj/weaver/patterns/AnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/AnnotationTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/ArgsAnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ArgsPointcut.java", "weaver/src/org/aspectj/weaver/patterns/BindingAnnotationTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/BindingTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/CflowPointcut.java", "weaver/src/org/aspectj/weaver/patterns/Declare.java", "weaver/src/org/aspectj/weaver/patterns/DeclareErrorOrWarning.java", "weaver/src/org/aspectj/weaver/patterns/DeclareParents.java", "weaver/src/org/aspectj/weaver/patterns/DeclarePrecedence.java", "weaver/src/org/aspectj/weaver/patterns/DeclareSoft.java", "weaver/src/org/aspectj/weaver/patterns/ExactAnnotationTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/ExactTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/HandlerPointcut.java", "weaver/src/org/aspectj/weaver/patterns/IfPointcut.java", "weaver/src/org/aspectj/weaver/patterns/KindedPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ModifiersPattern.java", "weaver/src/org/aspectj/weaver/patterns/NamePattern.java", "weaver/src/org/aspectj/weaver/patterns/NotAnnotationTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/NotPointcut.java", "weaver/src/org/aspectj/weaver/patterns/NotTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/OrAnnotationTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/OrPointcut.java", "weaver/src/org/aspectj/weaver/patterns/OrTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/PerCflow.java", "weaver/src/org/aspectj/weaver/patterns/PerClause.java", "weaver/src/org/aspectj/weaver/patterns/PerFromSuper.java", "weaver/src/org/aspectj/weaver/patterns/PerObject.java", "weaver/src/org/aspectj/weaver/patterns/PerSingleton.java", "weaver/src/org/aspectj/weaver/patterns/Pointcut.java", "weaver/src/org/aspectj/weaver/patterns/ReferencePointcut.java", "weaver/src/org/aspectj/weaver/patterns/SignaturePattern.java", "weaver/src/org/aspectj/weaver/patterns/ThisOrTargetAnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ThisOrTargetPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ThrowsPattern.java", "weaver/src/org/aspectj/weaver/patterns/TypePattern.java", "weaver/src/org/aspectj/weaver/patterns/TypePatternList.java", "weaver/src/org/aspectj/weaver/patterns/WildAnnotationTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/WildTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/WithinAnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/WithinCodeAnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/WithinPointcut.java", "weaver/src/org/aspectj/weaver/patterns/WithincodePointcut.java", "weaver/testsrc/org/aspectj/weaver/bcel/PatternWeaveTestCase.java", "weaver/testsrc/org/aspectj/weaver/bcel/PointcutResidueTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/AndOrNotTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/DeclareErrorOrWarningTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/ModifiersPatternTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/NamePatternTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/SignaturePatternTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/TypePatternListTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/TypePatternTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/WithinTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 81863 Annotation matching using within() PCD doesn't appear to be working.

resolved fixed

8a8930f

["tests/java5/annotations/within/PlainWithin.java", "tests/src/org/aspectj/systemtest/ajc150/AnnotationPointcutsTests.java", "tests/src/org/aspectj/systemtest/ajc150/AnnotationRuntimeTests.java", "weaver/src/org/aspectj/weaver/patterns/AnnotationTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/ExactAnnotationTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/ExactTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/HandlerPointcut.java", "weaver/src/org/aspectj/weaver/patterns/TypePattern.java", "weaver/src/org/aspectj/weaver/patterns/WildTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/WithinPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 82062 WeaveMessage should provide more information

It would be wonderful if the WeaveMessage object would provide two additional things: - the affected class name - the aspect name I could use this to determine which aspect is woven into which class during load-time weaving (need this for dependency management).

resolved fixed

9897659

["bridge/src/org/aspectj/bridge/WeaveMessage.java", "weaver/src/org/aspectj/weaver/Advice.java", "weaver/src/org/aspectj/weaver/Shadow.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java", "weaver/src/org/aspectj/weaver/bcel/BcelWorld.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 80916 In some cases the structure model doesn't contain the "matches declare" relationship

With a project containing one class and one aspect: public class HelloClass { public static void main(String[] args) { new HelloClass().sayHello(); } public void sayHello() { System.out.println("Hello"); } } public aspect A1 { pointcut test() : get(* System.out); declare warning : test() && !within(A1) : "test warning"; pointcut anotherTest() : execution(void HelloClass.sayHello(..)); after() returning : anotherTest() { System.out.println("returning...."); } } The following is returned from the structure model: asmRelMap entry: HelloClass.sayHello(), relationship: advised by, target: A1.afterReturning(): anotherTest.. asmRelMap entry: A1.afterReturning(): anotherTest.., relationship: uses pointcut, target: A1.anotherTest() asmRelMap entry: A1.afterReturning(): anotherTest.., relationship: advises, target: HelloClass.sayHello() asmRelMap entry: HelloClass.sayHello(), relationship: advised by, target: A1.afterReturning(): anotherTest.. asmRelMap entry: A1.anotherTest(), relationship: pointcut used by, target: A1.afterReturning(): anotherTest.. asmRelMap entry: A1.declare warning: "test warning", relationship: matched by, target: HelloClass.sayHello() In other words, the model is saying that there are two entries the same: asmRelMap entry: HelloClass.sayHello(), relationship: advised by, target: A1.afterReturning(): anotherTest.. whereas one of these should be the "matches declare" relationship relating to the declare warning. Changing the aspect to be: public aspect A1 { pointcut test() : get(* System.out); declare warning : test() && !within(A1) : "test warning"; pointcut anotherTest() : execution(void HelloClass.sayHello(..)); after() returning : anotherTest() { System.out.println("returning...."); } after() returning : test() { System.out.println("returning again!"); } } means that the IRelationshipMap does now contain the "matches declare" relationship. This is all with AspectJ 5 M1.

resolved fixed

427c0d3

["weaver/src/org/aspectj/weaver/AsmRelationshipProvider.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 80249 Order of types passed to compiler determines weaving behavior

Currently, the order in which you specify types when passing them to the compiler can affect how they are woven: For example, if we have class A and class B extends A - Also, an aspect that 'declare parents: A+ implements Serializable' then depending on whether we see A first, we may or may not make B serializable. The fix is that when we weave a type, we first weave its supertype then its superinterfaces (if they were also passed to the compiler). The problematic construct is declare parents - so we only process the types in a special order if there are declare parents around. Also, because we can't currently do decp when binary weaving, the order processing logic is only being put into the source weaving pipeline.

resolved fixed

9052d5d

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/AjLookupEnvironment.java", "tests/decp/A.java", "tests/decp/AspectX.java", "tests/decp/B.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 77163 Load time weaver default verbose setting

The default setting for the load time weaver is (as of 1.2.1rc1) to produce weaving messages rather than ignore them. I think the default should be changed to ignore them. Also, I cannot override the default setting with -Daj.weaver.versose="False". This is the implied syntax from docs/examples/build.xml. If this has changed then build.xml should be updated. Otherwise, the weaver should be fixed to use it!

resolved fixed

edd6539

["weaver/src/org/aspectj/weaver/tools/WeavingAdaptor.java", "weaver/testsrc/org/aspectj/weaver/WeavingURLClassLoaderTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 77799 NullPointerException in StructureSearchManager

Calling Ajde.getDefault().getStructureSearchManager().findMatches(...) for an AspectJ project that has not been built results in a NullPointerException in StructureSearchManager.findMatchesHelper(...) (line 58) Simple patch is attached.

resolved fixed

aab9c2c

["ajde/src/org/aspectj/ajde/ui/StructureSearchManager.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 76798 Add versions to woven class files - enabling better backwards compatibility.

We don't currently include a version in the class files that come out of the weaver. This can cause problems. For example, if we add a new attribute to a class file in a future version of AspectJ, then that attribute will cause older versions of AspectJ to blow up if they encounter it. If we include a version in the class file we can rev the version number when we add attributes (or change the class file form in another way), and by checking that version number in the weaver we can better determine whether we should fail if we encounter a new attribute (or other change), or if it is safe to continue processing. I will add a new WeaverVersion attribute that includes 2 shorts. Major and Minor. Encountering a major version in a class file that is greater than the version a particular weaver is designed to understand will cause compilation to fail. Encountering a minor version in a class file that is greater than the minor version a particular weaver is designed to understand will not cause compilation to fail - we will assume it is safe to continue.

resolved fixed

6aa7516

["weaver/src/org/aspectj/weaver/AjAttribute.java", "weaver/src/org/aspectj/weaver/bcel/BcelAttributes.java", "weaver/src/org/aspectj/weaver/bcel/BcelField.java", "weaver/src/org/aspectj/weaver/bcel/BcelMethod.java", "weaver/src/org/aspectj/weaver/bcel/BcelObjectType.java", "weaver/src/org/aspectj/weaver/bcel/LazyClassGen.java", "weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 73895 unnecessary cast causing problems

class: org.aspectj.weaver.ResolvedTypeX$Name method: isCoerceableFrom(..) I am having trouble with the line: ResolvedMember[] b = ((Name)other).getDeclaredMethods(); //??? is this cast always safe As the comment suggests this cast is NOT always safe. In my case the cast is not safe because I have some additional implementations for ResolvedTypeX (some optimizations). Solution: just remove the cast since the method "getDeclaredMethods" is already defined abstract in the type of "other" (ResolvedTypeX). So the cast seems to be obsolete anyway.

resolved fixed

8a64fa2

["weaver/src/org/aspectj/weaver/ResolvedTypeX.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 74952 before,after !(cflow(within(Trace*))) prints nothing

Reference: "cflow(within(C)) vs (within(C)||cflowbelow(within(C)) in aspectj-users mailing list. The aspect TraceClass below doesn't print any message when the pointcut is defined to "!cflow(within(Trace*))". The other defintion "!(within(Trace*) || cflowbelow(within(Trace*)))" works fine. Wes Isberg in his reply explained that cflow should never be used alone but he thought "there is a bug or two in here" class SomeClass { static public void main (String [] args) { } } // SomeClass aspect TraceClass { // members static private int level = 0; static private void offset() { int i; for (i = 0; i < level; ++i) { System.out.print(" "); } } // offset pointcut pc() : !cflow(within(Trace*)) // !(within(Trace*) || cflowbelow(within(Trace*))) ; before () : pc() { offset(); System.out.println("-> " + thisJoinPoint); ++level; } after () : pc() { --level; offset(); System.out.println("<- " + thisJoinPoint); } } // TraceClass In order to try to figure out what is happening within TraceClass, I added a second aspect, TraceTrace, just to trace TraceClass. aspect TraceTrace { // members static private int level = 0; static private void offset() { int i; for (i = 0; i < level; ++i) { System.out.print(" "); } } // offset pointcut pc() : within(TraceClass); before () : pc() { offset(); System.out.println("=> " + thisJoinPoint); ++level; } after () : pc() { --level; offset(); System.out.println("<= " + thisJoinPoint); } } // TraceTrace Here is what TraceTrace prints when TraceClass uses "!cflow(within(Trace*))" => staticinitialization(TraceClass.<clinit>) => set(int TraceClass.level) <= set(int TraceClass.level) => preinitialization(TraceClass()) => initialization(TraceClass()) => execution(TraceClass()) <= execution(TraceClass()) <= initialization(TraceClass()) <= staticinitialization(TraceClass.<clinit>) The after advice is not executed for preinitialization.

resolved fixed

a303a09

["tests/bugs/WhatsGoingOn.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelShadow.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 76096 Anonymous classes unaware of introductions into abstract classes (error can't find type $Local$)

resolved fixed

6beb43f

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/problem/AjProblemReporter.java", "tests/bugs/pr76096/ConcreteClassA.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 75568 ajc changes classfile timestamps even if compilation fails (regression)

It appears that ajc 1.2 updates a classfile timestamps even if the compilation fails. This breaks the integration with the Ant build system. E.g. using the ant "javac" task with the Ajc11CompilerAdapter interface, the compilation may fail on the first attempt and succeed on the second attempt, - because ajc has touched the timestamp and Ant hence decides that nothing needs to be recompiled. This did not happen in ajc 1.1. To reproduce: 1. In the examples/observer folder, run a build: ajc -sourceroots . 2. Edit the "Demo.java" class and insert the line "DONT COMPILE" 3. Run the compilation again. The compiler displays the correct error message but the Demo.class file has been updated with the compile-time timestamp.

resolved fixed

0a77939

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/BuildArgParser.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/AjCompilerAdapter.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildConfig.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjCompilerOptions.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AspectJBuilder.java", "org.aspectj.ajdt.core/testdata/src1/C1.java", "org.aspectj.ajdt.core/testdata/src1/C2.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/AjdtBatchTests.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/ProceedOnErrorTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 74238 Applet which uses cflow pointcut gets AccessControlException

When I used cflow pointcut for my applet, I couldn't launch the Applet. java.lang.ExceptionInInitializerError at SandAspect.ajc$preClinit(SandAspect.aj) at SandAspect.<clinit>(SandAspect.aj) at SandApplet.init(SandApplet.java) at sun.applet.AppletPanel.run(AppletPanel.java:353) at java.lang.Thread.run(Thread.java:534) Caused by: java.security.AccessControlException: access denied (java.util.Proper tyPermission aspectj.runtime.cflowstack.usethreadlocal read) at java.security.AccessControlContext.checkPermission(AccessControlConte xt.java:269) at java.security.AccessController.checkPermission(AccessController.java: 401) at java.lang.SecurityManager.checkPermission(SecurityManager.java:524) at java.lang.SecurityManager.checkPropertyAccess(SecurityManager.java:12 76) at java.lang.System.getProperty(System.java:612) at org.aspectj.runtime.internal.CFlowStack.selectFactoryForVMVersion(CFl owStack.java:124) at org.aspectj.runtime.internal.CFlowStack.<clinit>(CFlowStack.java:59) ... 5 more It because CFlowStack uses System.getProperty method with no try..catch block. Applet doesn't have permission to read system property: "aspectj.runtime.cflowstack.usethreadlocal". workaround: modify CFlowStack.java(1.5) line 123,124 like this ----- private static String getSystemPropertyWithNoSecurityException( String aPropertyName, String aDefaultValue){ try{ return System.getProperty(aPropertyName, aDefaultValue); } catch(java.lang.SecurityException e){ return aDefaultValue; } } private static void selectFactoryForVMVersion() { String override = getSystemPropertyWithNoSecurityException( "aspectj.runtime.cflowstack.usethreadlocal" , "unspecified" ); ----- I think defining getSystemPropertyWithNoSecurityException(or more simple name :-)) method in some utility class and using it where you call System.getProperty are better way.

resolved fixed

6e155a6

["ajde/testdata/SecurityManagerTest/src/HelloWorld.java", "runtime/src/org/aspectj/runtime/internal/CFlowCounter.java", "runtime/src/org/aspectj/runtime/internal/CFlowStack.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 72157 declare soft can cause programs with invalid exception behaviour to be generated

Compiling the program below results in the constructor for the class SCE2 throwing Exception, which it is not declared to throw either in the source code or in the generated bytecode. If the 'declare soft' statement is removed, then the super() call in the SCE2 constructor is correctly reported as throwing an undeclared exception; it seems that the 'declare soft' statement turns off the exception checking of the super() call despite there being no join point which covers this call that would actually soften the exception. I'm using 'DEVELOPMENT built on Monday Aug 16, 2004 at 13:50:47 GMT'. public class SuperConsExc { public SuperConsExc() throws Exception { throw new Exception(); } public static void main(String[] args) { new SCE2(); } } class SCE2 extends SuperConsExc { public SCE2() { super(); } } aspect SCEAspect { declare soft: Exception: within(SCE2); }

resolved fixed

eca1429

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/problem/AjProblemReporter.java", "tests/bugs/ConvertToUnchecked.java", "tests/bugs/PR72157.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 73433 AspectJ does not correctly support -cp

Discovered by Andy Brodie. -cp is a shorthand for -classpath supported by the JDT compiler. AspectJ does not correctly support -cp option. Look at this example: C:\aspectj1.2>ajc -inpath injar.jar -outjar outjar.jar -cp lib\aspectjrt.jar [error] can't find type org.aspectj.lang.JoinPoint 1 error C:\aspectj1.2>ajc -inpath injar.jar -outjar outjar.jar -classpath lib\aspectjrt.jar This is due to the arg parser in AspectJ only recognizing -classpath. It doesn't fail when it encounters -cp, it just ignores it and passes it down to JDT for processing. The fix is to recognize -cp too.

resolved fixed

8e4d898

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/BuildArgParser.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 73334 Avoid clashes in the org.eclipse namespace by renaming our duplicates.

We have recently renamed our 'copy' of BCEL to use a different package prefix so that our version never clashes with another version that might be around on a users system. This enhancement is to do the same thing for our 'copy' of the org.eclipse.jdt code (in the shadows project). As part of packaging the shadows project to create the 'jdtcore' jar files (bin and src) we will rename the packages from: org.eclipse.jdt.*** to org.aspectj.org.eclipse.jdt.** This has a really nice side effect that we can make our version of the compiler accessible in the IDE. It should now be possible for AJDT to work more closely with it and get features like eager parsing to work. Care will be taken that we don't accidentally make the merge process a nightmare.

resolved fixed

b133299

["ajde/src/org/aspectj/ajde/internal/CompilerAdapter.java", "ajde/testsrc/org/aspectj/ajde/BuildConfigurationTests.java", "ajde/testsrc/org/aspectj/ajde/ExtensionTests.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/AjdtCommand.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/BuildArgParser.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/compiler/IAjTerminalSymbols.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/core/AspectJCore.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/AjClassFile.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/AjCompilerAdapter.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ClassFileBasedByteCodeProvider.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/IOutputClassFileNameProvider.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/InterimCompilationResult.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/WeaverAdapter.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/WeaverMessageHandler.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AccessForInlineVisitor.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AdviceDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AjConstructorDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AjMethodDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AspectClinit.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AspectDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AstUtil.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/DeclareDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/EclipseAttributeAdapter.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/IfMethodDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/IfPseudoToken.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterSuperFixerVisitor.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterSuperReference.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterTypeConstructorDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterTypeDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterTypeFieldDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterTypeMethodDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/KnownFieldReference.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/KnownMessageSend.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/MakeDeclsPublicVisitor.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/PointcutDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/PointcutDesignator.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/Proceed.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/ProceedVisitor.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/PseudoToken.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/PseudoTokens.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/SuperFixerVisitor.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/ThisJoinPointVisitor.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/AjLookupEnvironment.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/AjTypeConstants.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseScope.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseShadow.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseSourceLocation.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseSourceType.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseTypeMunger.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/HelperInterfaceBinding.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/InlineAccessFieldBinding.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/InterTypeFieldBinding.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/InterTypeMemberFinder.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/InterTypeMethodBinding.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/InterTypeScope.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/PointcutBinding.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/PrivilegedFieldBinding.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/PrivilegedHandler.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/SimpleSyntheticAccessMethodBinding.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/parser/DeclarationFactory.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/problem/AjProblemReporter.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBatchImageBuilder.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildNotifier.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjCompilerOptions.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjIncrementalImageBuilder.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjState.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmElementFormatter.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmHierarchyBuilder.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AspectJBuilder.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/EclipseAdapterUtils.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/EclipseClassPathManager.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/EclipseSourceContext.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/StatefulNameEnvironment.java", "org.aspectj.ajdt.core/testsrc/WeaveTests.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/ajc/AjdtCommandTestCase.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/ajc/BuildArgParserTestCase.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/core/builder/AjCompilerOptionsTest.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/core/builder/AsmBuilderTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 72671 Bootclasspath specification for compiling is not possible

I have following bug running eclipse 3.0 and ajdt 1.1.12 I have following class: import java.io.FileNotFoundException; import java.io.FileOutputStream; import org.w3c.dom.DOMConfiguration; import org.w3c.dom.DOMError; import org.w3c.dom.DOMErrorHandler; import org.w3c.dom.Document; import org.w3c.dom.DocumentFragment; import org.w3c.dom.NodeList; import org.w3c.dom.ls.DOMImplementationLS; import org.w3c.dom.ls.LSInput; import org.w3c.dom.ls.LSOutput; import org.w3c.dom.ls.LSParser; import com.dcbank.common.DOMImplementationLSSingleton; public class DOMHelper { public static final String CLASS_ID = "%full_filespec: DOMHelper.java~1:java:1 %"; public static void save(Document document, String filename) throws ClassNotFoundException, InstantiationException, IllegalAccessException, FileNotFoundException { document.normalizeDocument(); } } which compiles very fine with JDK 1.4.2_02 on Windows XP, as soon as the dom2-xml-apis.jar and dom3-xercesImpl.jar are added at the beginning of the jre container, or are included in the jar-library list before the system jar. As soon as I convert this project to an AspectJ project, the code does not compile anymore. The aspectJ compiler does not find the normalizeDocument, which is included in the one of the two additional jars. method any more. kind regards Arno Schmidmeier

resolved fixed

d1551bd

["ajde/src/org/aspectj/ajde/internal/CompilerAdapter.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/BuildArgParser.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildConfig.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/ajc/BuildArgParserTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 72528 around advice throws java.lang.VerifyError at runtime

I have an aspect that captures around() a pcd and returns an Object[], though the actual methods being instrumented might return any valid POJO array, i understand that AspectJ will take care of casting at assignment. I expected the following code to work properly, but at runtime i get a java.lang.VerifyError as shown below: F:\wd\Hello>ajbrowser HelloWorld.lst java.lang.VerifyError: (class: de/rohith/PrinterWorld, method: returnArrayWithCl oning signature: ()[Ljava/lang/Integer;) Incompatible argument to function at de.rohith.HelloWorld.main(HelloWorld.java:18) Exception in thread "main" I suspect the compiler fails to notice the return types of the methods being caught at compile time. I have tested this code with both ajbrowser as well as AJDT, both result in the same error output. -----------HelloWorldAspect.java--------------- package de.rohith; import java.lang.Object; public aspect HelloWorldAspect { private int callDepth = -1; public HelloWorldAspect() { } pointcut hello(): !within(HelloWorldAspect); pointcut method(): execution(public (*[]) de..*(..)); pointcut cloning(): call(* java.lang.Object.clone()); declare warning: method() && hello(): "*[] returning method called" ; Object[] around(): cflow(method()) && cloning() && hello() { print("", thisEnclosingJoinPointStaticPart); Object[] ret = proceed(); return (Object[])ret.clone(); } private void print(String prefix, Object message) { for (int i = 0, spaces = callDepth * 2; i < spaces; i++) { System.out.print(" "); } System.out.println(prefix + message); } } -----------PrinterWorld.java------------ package de.rohith; public class PrinterWorld { private Integer[] intArray = new Integer[2]; public PrinterWorld() { } public void print() { System.out.println("Hello World!"); } public Integer returnInt() { return new Integer(3); } public Integer[] returnArrayWithCloning() { for (int i = 0; i < intArray.length; i++) { intArray[i] = new Integer(i++); } return (Integer[])intArray.clone(); } public Integer[] returnArrayWithoutCloning() { return intArray; } } -----------HelloWorld.java------------ package de.rohith; public class HelloWorld { public static void main(String[] args) { PrinterWorld p = new PrinterWorld(); p.print(); Integer i = p.returnInt(); Integer[] intArray = p.returnArrayWithCloning(); Integer[] array2 = p.returnArrayWithoutCloning(); } }

resolved fixed

27d204c

["tests/bugs/ArrayCloning.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java", "weaver/src/org/aspectj/weaver/ResolvedTypeX.java", "weaver/src/org/aspectj/weaver/bcel/BcelShadow.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 46298 Aspectj generate code does not de-compile cleanly.

resolved fixed

4921f0c

["weaver/src/org/aspectj/weaver/bcel/BcelShadow.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 49743 performance improvements for runtime library

I am heavily using the runtime signature information from thisJoinPoint.getSignature() and the toString() method of it. This causes heavy String operations each time the toString method is called. Would it be possible to cache the resulting string for example in MethodSignatureImpl and similar classes for other signatures?

resolved fixed

438e61c

["runtime/src/org/aspectj/runtime/reflect/AdviceSignatureImpl.java", "runtime/src/org/aspectj/runtime/reflect/CatchClauseSignatureImpl.java", "runtime/src/org/aspectj/runtime/reflect/ConstructorSignatureImpl.java", "runtime/src/org/aspectj/runtime/reflect/Factory.java", "runtime/src/org/aspectj/runtime/reflect/FieldSignatureImpl.java", "runtime/src/org/aspectj/runtime/reflect/InitializerSignatureImpl.java", "runtime/src/org/aspectj/runtime/reflect/MethodSignatureImpl.java", "runtime/src/org/aspectj/runtime/reflect/SignatureImpl.java", "runtime/src/org/aspectj/runtime/reflect/SourceLocationImpl.java", "runtime/src/org/aspectj/runtime/reflect/StringMaker.java", "runtime/testsrc/RuntimeModuleTests.java", "runtime/testsrc/org/aspectj/runtime/reflect/RuntimePerformanceTest.java", "runtime/testsrc/org/aspectj/runtime/reflect/SignatureTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 72699 Bogus error message: The abstract method ajc$pointcut$$tracingScope$a2 in type Tracing can only be defined by an abstract class

When attempting to compile the following aspect the resulting error message should say something like "The abstract method pointcut tracingScope in type Tracing can only be defined by an abstract aspect" public aspect Tracing { public abstract pointcut tracingScope(); }

resolved fixed

5e08765

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/PointcutDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/problem/AjProblemReporter.java", "tests/bugs/BogusMessage.java", "tests/bugs/BogusMessage2.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 72150 AJC possible bug with static nested classes

resolved fixed

b5e6307

["tests/bugs/java5/arrayCloning/A.java", "tests/bugs/java5/arrayCloning/C.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java", "weaver/src/org/aspectj/weaver/TypeX.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 72531 declare warning warns at wrong points

resolved fixed

82eae55

["tests/bugs/pr72531/de/rohith/HelloWorld.java", "tests/bugs/pr72531/de/rohith/HelloWorldAspect.java", "tests/bugs/pr72531/de/rohith/PrinterWorld.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java", "weaver/src/org/aspectj/weaver/patterns/WildTypePattern.java", "weaver/testsrc/org/aspectj/weaver/patterns/TypePatternTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 72154 Support for simple dump file

When the compiler terminates abnormally (exception) or behaves unexpectedly (warning/error/abort) a simple dump of the compiler state should be produced to aid problem diagnosis. The content and conditions under which the dump is produced should be configurable by the user but the facility should be enabled by default for exceptions. Consequently its inclusion should have negligible impact on compiler performance and footprint. The file should be attached to bug reports to give a complete and objective description of the users environment and support problem resolution where a testcase cannot be provided. One approach is to write a uniquely name file (using date & time) in the current directory e.g ajcore.20040818.105200.txt which should be human readable (it can be zipped if large) to allow the user to potentially diagnose their own problems or remove potentially sensitive data before submission. It should contain basic information such as AspectJ version, system properties and command line as well as failure information such as _full_ exception stack trace, compiler messages and internal compiler state.

resolved fixed

f503523

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/AjdtCommand.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/BuildArgParser.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "org.aspectj.ajdt.core/src/org/aspectj/tools/ajc/Main.java", "org.aspectj.ajdt.core/testdata/DumpTestCase/src/HelloWorld.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/AjdtBatchTests.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/CompilerDumpTestCase.java", "weaver/src/org/aspectj/weaver/Dump.java", "weaver/src/org/aspectj/weaver/World.java", "weaver/testsrc/org/aspectj/weaver/BcweaverTests.java", "weaver/testsrc/org/aspectj/weaver/DumpTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 71811 AJDoc: should be able to set encoding like javadoc

ajdoc doesn't support the -encoding -docencoding and -charset options of javadoc. Especially, it doesn't pass on the -encoding to ajc. If your project uses a source file encoding (e.g. UTF-8) differing form the platform standard, and some java identifiers use characters byond the standard ASCII range, you won't be able to use ajdoc at all.

resolved fixed

5f80c8c

["ajdoc/src/org/aspectj/tools/ajdoc/Main.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/CoverageTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 49657 Weaver results in rt error if affected base class not exposed

I was weaving a 3rd party library and wrote an aspect that should affect both a base class and a derived class, but inadvertently wove only the derived class. This resulted in the following error. I would like the weaver to catch this kind of error at weave (link) time, rather than creating code that results in a rt error... I get this error in 1.1.1 final and in a fairly recent version from CVS HEAD: java.lang.AbstractMethodError at ajee.logging.LogManager.ajc$interMethodDispatch1 $ajee_logging_LogManager$ajee_logging_Loggable$getLogger(LogManager.java) at ajee.tracing.ExecutionTracer.ajc$before$ajee_tracing_ExecutionTracer$926 (ExecutionTracer.java:62) at library.Derived.<init>(Derived.java:46) This line is a call to super(); I've attached a small example that reproduces another error that I think is related: C:\devel\test\ctors\twoPass>build C:\devel\test\ctors\twoPass>call ajc -outjar fullBase.jar sample\Base.java sampl e\Derived.java Exception in thread "main" java.lang.ExceptionInInitializerError at sample.Derived.<init>(Derived.java:6) at sample.Derived.main(Derived.java:13) Caused by: org.aspectj.lang.NoAspectBoundException at sample.Trace.aspectOf(Trace.aj) at sample.Trace.<init>(Trace.aj:5) at sample.Trace.ajc$postClinit(Trace.aj) at sample.Trace.<clinit>(Trace.aj:5) ... 2 more

resolved fixed

dbe1024

["org.aspectj.ajdt.core/testdata/partialHierarchy/sample/Base.java", "org.aspectj.ajdt.core/testdata/partialHierarchy/sample/Derived.java", "org.aspectj.ajdt.core/testdata/partialHierarchy/sample/Iface.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/AjdtBatchTests.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/PartiallyExposedHierarchyTestCase.java", "weaver/src/org/aspectj/weaver/ResolvedTypeX.java", "weaver/src/org/aspectj/weaver/WeaverMessages.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 71723 Inconsistency in scoping of protected members in ITDs

When introducing new member functions to existing classes via inter-type declarations, the scoping rules that apply to the ITD bodies are the same as for the aspect - for example, private members of the target class cannot be accessed unless the aspect is privileged. Similarly, protected members of classes in different packages should not be visible in ITDs unless the aspect is privileged. This rule is only enforced for protected members declared in the target class - protected members that are inherited are visible from ITDs in aspects in different packages. The following is an example of this: ---------------------- package foo; public class Foo extends AncientFoo { protected int i() { return 42; } public static void main(String[] args) { new Foo().doStuff(); } public void doStuff() { } protected int ancientI() { return 42; } } class AncientFoo { protected int ancientI() { return -42; } protected int ancientJ() { return 0; } } ---------- package bar; import foo.Foo; aspect Bar { public void Foo.doing() { try { System.out.println(i()); // fails in ajc System.out.println(ancientI()); // fails in ajc System.out.println(ancientJ()); // succeeds System.out.println(clone()); // succeeds } catch(Throwable t) { } } before(Foo f) : call(* doStuff(..)) && target(f) { f.doing(); } } ------------------- All four calls in Foo.doing() should fail, as they refer to protected members of foo.Foo from package bar. However, only the first 2 - the ones directly declared/overridden in foo.Foo - are detected as errors, and removing them makes the rest compile and execute. Best wishes, Pavel

resolved fixed

dfb15c1

["tests/bugs/pr71723/foo/Foo.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 71076 Missing Javadoc comments that aren't missing

Reported in the AJDT newsgroup: Go to Preferences > Java > Compiler > Javadoc and set "Missing javadoc comments" to "Warning". You then get warnings against things you wouldn't expect, such as after advice. /** * A comment */ public aspect World { pointcut greeting() : execution(* Hello.sayHello(..)); /** * A comment */ after() returning : greeting() { System.out.println("world"); } } This gives two warnings, one for the aspect itself, and one for the after returning advice. The warnings occur both with and without the existence of Javadoc comments!

resolved fixed

5b90224

["org.aspectj.ajdt.core/testdata/javadoc/World.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/AjdtBatchTests.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/JavadocTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 62642 proper handling of ExceptionInIntializer inside <clinit> in presence of after throwing advice

When a <clinit> of a class contains after throwing advice that may catch ExceptionInInitializer errors due to an embedded advice aspectOf() that fails, the ExceptionInIntializer error does not get properly reported. For the example below: public class Main { static int x = 13; int y; public Main() { y= 14; } public static void main(String args[]) { Main m = new Main(); m.y = 3; System.out.println("hi"); } } aspect Aspect { before () : within(*) { System.out.println("BEFORE " + thisJoinPointStaticPart.getKind() + " at " + thisJoinPointStaticPart.getSourceLocation()); } after () : within(*) { System.out.println("AFTER " + thisJoinPointStaticPart.getKind() + " at " + thisJoinPointStaticPart.getSourceLocation()); } } .... when compiled with ajc, and then run, the following exception is given, Exception in thread "main" java.lang.NoClassDefFoundError at Main.<clinit>(Main.java:1) when really one wants the following: Exception in thread "main" java.lang.ExceptionInInitializerError at Main. ... Caused by: org.aspectj.lang.NoAspectBoundException: Aspect at Aspect.aspectOf .. ------------- Here is a fix ... I give the decompiled <clinit> for Main.java and indicate with comments, look for ***LJH ****, what can be woven to fix it. Basically, the catch block for after throwing, when in <clinit>, should first check if the caught exception if a ExceptionInInitializerError, and if so just throw it. ----------- static { org.aspectj.runtime.reflect.Factory r1; java.lang.Throwable r2, r31; int $i0; r1 = new Factory("Main.java", Class.forName("Main")); ajc$tjp_0 = r1.makeSJP("field-set", r1.makeFieldSig("8-x-Main-int-"), 2); ajc$tjp_1 = r1.makeSJP("staticinitialization", r1.makeInitializerSig("8--Main-"), 2); ajc$tjp_10 = r1.makeSJP("preinitialization", r1.makeConstructorSig("1--Main----"), 5); ajc$tjp_2 = r1.makeSJP("field-set", r1.makeFieldSig("0-y-Main-int-"), 6); ajc$tjp_3 = r1.makeSJP("constructor-execution", r1.makeConstructorSig("1--Main----"), 6); ajc$tjp_4 = r1.makeSJP("constructor-call", r1.makeConstructorSig("1--Main----"), 10); ajc$tjp_5 = r1.makeSJP("field-set", r1.makeFieldSig("0-y-Main-int-"), 11); ajc$tjp_6 = r1.makeSJP("field-get", r1.makeFieldSig("19-out-java.lang.System-java.io.PrintStream-"), 12); ajc$tjp_7 = r1.makeSJP("method-call", r1.makeMethodSig("1-println-java.io.PrintStream-java.lang.String:-arg0:--void-"), 12); ajc$tjp_8 = r1.makeSJP("method-execution", r1.makeMethodSig("9-main-Main-[Ljava.lang.String;:-args:--void-"), 10); ajc$tjp_9 = r1.makeSJP("initialization", r1.makeConstructorSig("1--Main----"), 6); try { Aspect.aspectOf().ajc$before$Aspect$1$36f01b1c(ajc$tjp_1); $i0 = 13; try { Aspect.aspectOf().ajc$before$Aspect$1$36f01b1c(ajc$tjp_0); x = $i0; } catch (Throwable $r30) { /*** LJH insert here *****/ if ($r30 instanceof ExceptionInIntializerError) //*** throw($r30); //*** /***********/ r31 = $r30; Aspect.aspectOf().ajc$after$Aspect$2$36f01b1c(ajc$tjp_0); throw r31; } Aspect.aspectOf().ajc$after$Aspect$2$36f01b1c(ajc$tjp_0); } catch (Throwable $r36) { /*** LJH insert here *****/ if ($r36 instanceof ExceptionInIntializerError) //*** throw($r36); //*** /***********/ r2 = $r36; Aspect.aspectOf().ajc$after$Aspect$2$36f01b1c(ajc$tjp_1); throw r2; } Aspect.aspectOf().ajc$after$Aspect$2$36f01b1c(ajc$tjp_1); }

resolved fixed

84e4e53

["tests/bugs/pr62642.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelShadow.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 70241 outline view shows anonymous inner classes in different way than jdt outline

See screenshots.

resolved fixed

a2469c7

["ajde/testdata/extensions/InnerClasses.java", "ajde/testsrc/org/aspectj/ajde/ExtensionTests.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmHierarchyBuilder.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 67578 Privileged Aspect Access Problem Across Packages

From Irum Godil's aspectj-users posting: package a; public class ITD { private void returnNothing(Object a) { } } package b; import a.*; privileged aspect B { public void ITD.newFun() { returnNothing("a"); } } returns: C:\devel\test\priv\b\B.aj:8 error The method returnNothing(Object) from the type ITD is not visible returnNothing("a"); ^^^^^^ 1 error Which it should not (and AspectJ 1.0.6 does not give an error) Work around: use this.returnNothing("a");

resolved fixed

6b1ef0f

["tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 71878 Bad injar aspect name on Linux

If you checkout the "JarUsingProject" project from "org.eclipse.ajdt.test/manual testing" in the AJDT 1.1.12 tree, and look at the advised-by entries in the outline view and the context menu of the gutter annotation, on Windows you get "injar aspect: AbstractAspect.aj", but on Linux you get "injar aspect: C:\eclipse30AJDTPluginTest\eclipse\workspace\JarGeneratingProject\src\p1\AbstractAspect.aj". The Windows-style path indicates the location of the original class files in the JAR file, which was clearly built on Windows.

resolved fixed

2dfc738

["asm/src/org/aspectj/asm/internal/AspectJElementHierarchy.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 61374 Version the BCEL libraries to allow graceful failure when the wrong version is found.

resolved fixed

228fc8d

["weaver/src/org/aspectj/weaver/bcel/BcelAdvice.java", "weaver/src/org/aspectj/weaver/bcel/BcelAttributes.java", "weaver/src/org/aspectj/weaver/bcel/BcelCflowAccessVar.java", "weaver/src/org/aspectj/weaver/bcel/BcelCflowStackFieldAdder.java", "weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java", "weaver/src/org/aspectj/weaver/bcel/BcelField.java", "weaver/src/org/aspectj/weaver/bcel/BcelFieldRef.java", "weaver/src/org/aspectj/weaver/bcel/BcelMethod.java", "weaver/src/org/aspectj/weaver/bcel/BcelObjectType.java", "weaver/src/org/aspectj/weaver/bcel/BcelRenderer.java", "weaver/src/org/aspectj/weaver/bcel/BcelShadow.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java", "weaver/src/org/aspectj/weaver/bcel/BcelVar.java", "weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java", "weaver/src/org/aspectj/weaver/bcel/BcelWorld.java", "weaver/src/org/aspectj/weaver/bcel/ExceptionRange.java", "weaver/src/org/aspectj/weaver/bcel/LazyClassGen.java", "weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java", "weaver/src/org/aspectj/weaver/bcel/Range.java", "weaver/src/org/aspectj/weaver/bcel/ShadowRange.java", "weaver/src/org/aspectj/weaver/bcel/Tag.java", "weaver/src/org/aspectj/weaver/bcel/UnwovenClassFile.java", "weaver/src/org/aspectj/weaver/bcel/Utility.java", "weaver/testsrc/org/aspectj/weaver/bcel/ArgsWeaveTestCase.java", "weaver/testsrc/org/aspectj/weaver/bcel/MoveInstructionsWeaveTestCase.java", "weaver/testsrc/org/aspectj/weaver/bcel/WeaveTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 61768 scope for intertype methods

/* According to the documentation, the scope rules for intertype method declarations are interpreted from the originating aspect. The only exceptions (I thought) are the use of "this" and "super" which refer to the target type. According to that interpretation, the program below is type correct, but ajc generates two error messages, shown in comments at the relevant lines. Note that it's ok to access private static fields of the aspect, but not to use private classes of the aspect. If this is a feature and not a bug, what are the precise scope rules for intertype method declarations? */ aspect Aspect { private static int y = 5; private class A { int x = 3; } private static void B.happy() { System.out.println(y); // happy accessing private field y } private static void B.foo(A z) { System.out.println(z.x); // ERROR: The type Aspect.A is not visible } public void B.bar() { B.foo(new A()); // ERROR: The type A is not visible } } class B { } public class IT { public static void main(String[] args) { new B().bar(); } }

resolved fixed

8c5d743

["tests/bugs/oxford/PR61768.java", "tests/bugs/oxford/PR62475.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 54421 Compile time declarations (warning and error) do not accept string concatenation (with +)

The following code does not compile because the message uses string concatenation (the + operator). public class WarningSample { public void method() {} public void anotherMethod() { this.method(); } } aspect WarningAspect { pointcut illegalCall(): call(* WarningSample.method()) && within(WarningSample); // the same thing happens with declare error declare warning: illegalCall() : "Hey, don't " + "do that, that is not nice. You should do something else"; }

resolved fixed

d43a391

["tests/bugs/decwStrings.java", "tests/bugs/decwStringsErroneous.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java", "weaver/src/org/aspectj/weaver/patterns/PatternParser.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 68991 intertype initialisers should match field set pointcuts

/* initialisers of intertype fields should match field set pointcuts. In the example below, the output should be set field set(int C.n) set field set(int C.m) get field get(int C.n) set field set(int C.n) but the first field set (of C.n) is not picked up. */ aspect Aspect { private int C.n = 13; before() : get(* C.*) { System.out.println("get field "+thisJoinPointStaticPart); } before() : set(* C.*) { System.out.println("set field "+thisJoinPointStaticPart); } public void C.foo() { n++; } } class C { int m = 20; } public class ITFieldsAdvice { public static void main(String[] args) { C c = new C(); c.foo(); } }

resolved fixed

64183c3

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterTypeFieldDeclaration.java", "tests/bugs/PR68991/Oxford.java", "tests/bugs/PR68991/Simple.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 65319 ajc crashes when compiling the following program (binding this() and target())

class Test { public static void main(String args[]) { new Test().method(); } public void method() { new Test2().method2(); } } class Test2 { public void method2() {} } aspect Plain { before(Test x): call(void *.* (..)) && (this(x) || target(x)) { } }

resolved fixed

b75cd93

["tests/bugs/oxford/PR65319.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelAdvice.java", "weaver/src/org/aspectj/weaver/patterns/ArgsPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ExposedState.java", "weaver/src/org/aspectj/weaver/patterns/ThisOrTargetPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 53981 proceed used as method name in around advice

Using a method named proceed(..) in around advice confuses the compiler (in at least the 2-3 ways shown below). True of the current tree (untested in 1.1.1). Workaround for now is to rename the method. ---- first problem: NPE in compiler java.lang.NullPointerException at org.aspectj.ajdt.internal.compiler.ast.MakeDeclsPublicVisitor.endVisit(MakeDeclsPublicVisitor.java:44) public class Proceeding { public static void main(String[] args) { } static aspect A { interface IProceed { void proceed(Runnable next); } IProceed decorator; void around() : execution(void main(String[])) { decorator.proceed(new Runnable() { public void run() { proceed(); } }); } } } ---- second problem: incorrect error wrt number of arguments public class Proceeding { public static void main(String[] args) { } static aspect A { void around() : execution(void main(String[])) { Proceeding.proceed(null); // BUG: treated as proceed(Object); } } static void proceed(Object o) {} } ---- third hypothetical: we should document how ambiguity is resolved public class Proceeding { public static void main(String[] args) { } static aspect A { void around() : execution(void main(String[])) { proceed(); // special form or Proceeding.proceed()? } } void proceed() {} }

resolved fixed

05dabd1

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/Proceed.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 59208 Weaver fails in BCEL for large classes

resolved fixed

44a92e1

["tests/bugs/pr59208/Foo.java", "tests/bugs/pr59208/FooProducer.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java", "weaver/src/org/aspectj/weaver/WeaverMessages.java", "weaver/src/org/aspectj/weaver/bcel/LazyClassGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 67592 value in the args[] array of thisjoinpoint can be changed by one advice decl and updated values seen in another advice decl

In ajc a use of thisJoinPoint corresponds to an object of type JoinPoint, where a JoinPoint object has four components, which can be retrieved using accessor methods. this getThis() target getTarget() args getArgs() staticJoinPoint getStaticPart() In the case of args, the object returned is an Object array. This means that an advice decl can overwrite the args, and then another advice which shares the same JoinPoint will see the changed args. Here is a small example. In this aspect the before advice changes arg[0] to always be "Laurie" and then the after advice will always say that "Laurie won a million pounds". Is this the behaviour that is intended? I would have thought that the interface to args[] should be such that the values can only be read. Otherwise very strange interactions between advice decls could occur. --------------------------------------------------------------------- public class Main { public static Main v = new Main(); void lottery ( String arg ) { System.out.println("The arg in lottery is " + arg); } public static void main (String args[]) { v.lottery("Oege"); v.lottery("Ganesh"); } } --------------------------------------------------------------------- public aspect Aspect { // This pair of advice decls demonstrates that an advice can change to // the args of a join point. before () : call(* lottery(java.lang.String)) && !within(Aspect) { System.out.println("BEFORE " + thisJoinPoint + " at " + thisJoinPointStaticPart.getSourceLocation()); Object args[] = thisJoinPoint.getArgs(); System.out.println("arg[0] is " + args[0]); args[0] = "Laurie"; System.out.println("... now it is " + thisJoinPoint.getArgs()[0]); } after () : call(* lottery(java.lang.String)) && !within(Aspect) { System.out.println("AFTER " + thisJoinPoint + " at " + thisJoinPointStaticPart.getSourceLocation()); if (thisJoinPoint.getArgs()[0].equals("Laurie")) System.out.println("Laurie wins 1 million pounds!"); } }

resolved fixed

f6436e3

["runtime/src/org/aspectj/runtime/reflect/JoinPointImpl.java", "runtime/testsrc/RuntimeModuleTests.java", "runtime/testsrc/org/aspectj/runtime/reflect/JoinPointImplTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 71377 Cannot advise private method call in around advice

Pointcuts should match call joint points in advice. However AspectJ does not match calls to _private_ methods in around advice. The same applies to get/set pointcuts for _private fields. This is probably because in the testcase below a call to "privateMethod()" in the body of the around advice is a call to an accessor method: ajc$inlineAccessMethod$bug_nnnn_JoinPointInAroundAdvice$bug_nnnn_JoinPointInAro undAdvice$privateMethod("around"); public aspect JoinPointInAroundAdvice { private static Set privateCalls = new HashSet(); private static Set publicCalls = new HashSet(); pointcut internalCall () : call(* JoinPointInAroundAdvice.privateMethod(..)); before () : internalCall () { privateCalls.add(thisJoinPoint); } pointcut externalCall () : call(* JoinPointInAroundAdvice.publicMethod(..)); before () : externalCall () { publicCalls.add(thisJoinPoint); } pointcut execTest () : execution(* JoinPointInAroundAdvice.test()); before () : execTest () { privateMethod("before"); publicMethod("before"); } void around () : execTest () { privateMethod("around"); publicMethod("around"); proceed(); } // void around () : execTest () { // Runnable runnable = new Runnable () { // public void run () { // privateMethod("around closure"); // publicMethod; // proceed(); // } // }; // runnable.run(); // } after () : execTest () { privateMethod("after"); publicMethod("after"); } private static void privateMethod (String from) { System.out.println("? privateMethod() " + from); } public static void publicMethod (String from) { System.out.println("? publicMethod() " + from); } public static void test () { System.out.println("? test()"); privateMethod("test"); publicMethod("test"); } public static void main (String[] args) { test(); if (privateCalls.size() != publicCalls.size()) { throw new RuntimeException("Missing join point"); } else { System.out.println("Success."); } } }

resolved fixed

851da68

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AspectDeclaration.java", "tests/bugs/AroundAdviceJPs/FieldGetJoinPointsInAroundAdvice.java", "tests/bugs/AroundAdviceJPs/FieldJoinPointsInAroundAdvice.java", "tests/bugs/AroundAdviceJPs/JoinPointInAroundAdvice.java", "tests/src/org/aspectj/systemtest/ajc121/Ajc121Tests.java", "weaver/src/org/aspectj/weaver/bcel/LazyClassGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 44191 Need better error message for "can't find type"

I have experienced situations where IAJC outputs a message like this at the end of compilation. [iajc] can't find type org.xxx.SomeTest In my case this was one time highly confusing since I did not expect the class in question to be referred anywhere in the project (I have to date still not located the reference). For such cases, it would be extremely nice if the error message would display WHY it need the class (i.e. the name of the refering class(es) or aspect(es) possibly with a reasonable cutoff as there is seldom need to list all referals). So I would like a message like this: [iajc] can't find type org.xxx.SomeTest referred by org.yyy.SomeClass,org.yy.SomeOtherClass ...

resolved fixed

061395c

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AspectDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseSourceType.java", "weaver/src/org/aspectj/weaver/ResolvedTypeX.java", "weaver/src/org/aspectj/weaver/bcel/BcelAdvice.java", "weaver/src/org/aspectj/weaver/bcel/BcelShadow.java", "weaver/src/org/aspectj/weaver/patterns/DeclareParents.java", "weaver/src/org/aspectj/weaver/patterns/DeclareSoft.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 42573 .lst file entries not resolved relative to list file: {boot}classpath, extdirs,

My -classpath entry in a config/.lst file was resolved relative to the working directory rather than to the config/.lst file. BuildArgParser.java looks like this would also be true for bootclasspath and extdirs, but not for injars, aspectpath, or sourceroots.

resolved fixed

648c0f4

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/BuildArgParser.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/ajc/BuildArgParserTestCase.java", "util/src/org/aspectj/util/ConfigParser.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 60015 NPE, Incorrect XLint:unmatchedSuperTypeInCall warning

(This is an incomplete bug report -- sorry no time not to further isolate.) Running AJDT 1.1.6, I get dozens of these warnings: ---------- Warning does not match because declaring type is java.lang.Object, if match desired use target(st.ata.mc.exim.DatastoreReader) [Xlint:unmatchedSuperTypeInCall] Blah.aj project/src/package/dir line 22 ---------- for something like this code: ---------- import pack.Interface; ... pointcut dsrCall() : call(* Interface.*(..)); // WARNING HERE ... ---------- Each warning points to the pointcut (not the join point shadow). NPE running from the command-line with the latest tree (will attach).

resolved fixed

ef7885f

["tests/bugs/IncorrectXlintOnInterface.java", "weaver/src/org/aspectj/weaver/patterns/KindedPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 57666 duplicate manifests cause resource-copying to gack

(Ah, the joy of build infrastructure...) Mostly self-explanatory trace, from a build Monday Apr 5, 2004 at 08:46:01 GMT: duplicate entry: META-INF/MANIFEST.MF duplicate entry: META-INF/MANIFEST.MF java.util.zip.ZipException: duplicate entry: META-INF/MANIFEST.MF at java.util.zip.ZipOutputStream.putNextEntry(ZipOutputStream.java:163) at java.util.jar.JarOutputStream.putNextEntry(JarOutputStream.java:90) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.writeResource(AjBuildManager.java:344) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.copyResourcesFromJarFile(AjBuildManager.java:288) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.copyResourcesToDestination(AjBuildManager.java:253) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild(AjBuildManager.java:195) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:94) at org.aspectj.ajdt.ajc.AjdtCommand.doCommand(AjdtCommand.java:102) at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(AjdtCommand.java:53) at org.aspectj.tools.ajc.Main.run(Main.java:280) at org.aspectj.tools.ajc.Main.runMain(Main.java:217) at org.aspectj.tools.ajc.Main.main(Main.java:79)

resolved fixed

2b8fa31

["ajde/testsrc/org/aspectj/ajde/AjdeTests.java", "ajde/testsrc/org/aspectj/ajde/DuplicateManifestTest.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/BcweaverJarMaker.java", "weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 67774 Nullpointer-exception in pointcuts using withincode() clause

Hi, I am getting null-pointer-exceptions whenever I try to specify a pointcut with a "withincode(Signature)" clause. E.g.: public aspect DetectSystemOutErrorUsage { pointcut allSystemOutAndSystemErrAccesses(): (get(* System.out) || get(* System.err)) ; declare warning: allSystemOutAndSystemErrAccesses() && !adviceexecution() && !within(com.tivoli.act..Test*) && !within(com.tivoli.act.log..*) && !execution(* com.tivoli.act..*.main(..)) && !execution(* com.tivoli.act..*.usage()) // && !withincode(* com.tivoli.act..*.main(..)) // && !withincode(* com.tivoli.act..*.usage()) : "Warning: use of System.out or System.err - consider logging instead!"; } In the above example excluding main() and usage() methods from the pointcut using an execution(...)-clause (shows) works but using a withincode()-clause (as commented) always yields an NPE: trouble in: null java.lang.NullPointerException at org.aspectj.weaver.patterns.SignaturePattern.matches (SignaturePattern.java:87) at org.aspectj.weaver.patterns.WithincodePointcut.match (WithincodePointcut.java:42) at org.aspectj.weaver.patterns.NotPointcut.match(NotPointcut.java:45) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:42) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:42) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:42) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:42) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:42) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:42) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:42) at org.aspectj.weaver.ShadowMunger.match(ShadowMunger.java:62) at org.aspectj.weaver.Checker.match(Checker.java:48) at org.aspectj.weaver.bcel.BcelClassWeaver.match (BcelClassWeaver.java:1121) at org.aspectj.weaver.bcel.BcelClassWeaver.matchInit (BcelClassWeaver.java:895) at org.aspectj.weaver.bcel.BcelClassWeaver.match (BcelClassWeaver.java:793) at org.aspectj.weaver.bcel.BcelClassWeaver.weave (BcelClassWeaver.java:343) at org.aspectj.weaver.bcel.BcelClassWeaver.weave (BcelClassWeaver.java:80) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:724) at org.aspectj.weaver.bcel.BcelWeaver.weaveWithoutDump (BcelWeaver.java:689) at org.aspectj.weaver.bcel.BcelWeaver.weaveAndNotify (BcelWeaver.java:615) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:563) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.weave (AjCompilerAdapter.java:239) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.afterCompiling (AjCompilerAdapter.java:114) at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:376) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation (AjBuildManager.java:601) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild (AjBuildManager.java:160) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild (AjBuildManager.java:94) at org.aspectj.ajde.internal.CompilerAdapter.compile (CompilerAdapter.java:108) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run (AspectJBuildManager.java:165) !SESSION Jun 18, 2004 10:49:48.666 --------------------------------------------- eclipse.buildId=I200406110010 java.version=1.4.2_03 java.vendor=Sun Microsystems Inc. BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=de_CH !ENTRY org.eclipse.ajdt.ui 4 0 Jun 18, 2004 10:49:48.666 !MESSAGE NullPointerException thrown: null !STACK 0 java.lang.NullPointerException at org.aspectj.weaver.patterns.SignaturePattern.matches (SignaturePattern.java:87) at org.aspectj.weaver.patterns.WithincodePointcut.match (WithincodePointcut.java:42) at org.aspectj.weaver.patterns.NotPointcut.match(NotPointcut.java:45) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:42) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:42) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:42) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:42) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:42) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:42) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:42) at org.aspectj.weaver.ShadowMunger.match(ShadowMunger.java:62) at org.aspectj.weaver.Checker.match(Checker.java:48) at org.aspectj.weaver.bcel.BcelClassWeaver.match (BcelClassWeaver.java:1121) at org.aspectj.weaver.bcel.BcelClassWeaver.matchInit (BcelClassWeaver.java:895) at org.aspectj.weaver.bcel.BcelClassWeaver.match (BcelClassWeaver.java:793) at org.aspectj.weaver.bcel.BcelClassWeaver.weave (BcelClassWeaver.java:343) at org.aspectj.weaver.bcel.BcelClassWeaver.weave (BcelClassWeaver.java:80) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:724) at org.aspectj.weaver.bcel.BcelWeaver.weaveWithoutDump (BcelWeaver.java:689) at org.aspectj.weaver.bcel.BcelWeaver.weaveAndNotify (BcelWeaver.java:615) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:563) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.weave (AjCompilerAdapter.java:239) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.afterCompiling (AjCompilerAdapter.java:114) at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:376) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation (AjBuildManager.java:601) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild (AjBuildManager.java:160) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild (AjBuildManager.java:94) at org.aspectj.ajde.internal.CompilerAdapter.compile (CompilerAdapter.java:108) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run (AspectJBuildManager.java:165) Michael

resolved fixed

7f19ab4

["tests/bugs/WithincodeNPE01.java", "weaver/src/org/aspectj/weaver/bcel/BcelShadow.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 70773 AspectJ Error: ConncurrentModificationException thrown: null

In AspectJ 1.1.11 for Eclipse, build ID 1.2.0 (and also in the previous 1.1.10) on Eclipse version 3.0.0, build ID 200406351208: If I enable incremental compilation and make a change to a file (typing a space and deleting it, or editing a comment), I get a "ConncurrentModificationException thrown: null" error.

resolved fixed

9aed31d

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/AjLookupEnvironment.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 30439 spurious "circular dependency" error

AspectJ Compiler 1.1beta4 This program: aspect Foo { pointcut p1(): execution(void f()) && cflow(execution(void f1())); pointcut p2(): execution(void f()) && cflow(execution(void f2())); before(): p1() { } after(): p1() { } before(): p2() { } after(): p2() { } } class A { void f1() { f(); } void f2() { f(); } void f() { } } results in these errors: circular dependency at method-execution(void A.f()) circular dependency at method-execution(void A.f()) circular dependency at method-execution(void A.f()) circular dependency at method-execution(void A.f()) 4 errors If I comment out any one of the four pieces of advice, all the errors go away. Also, assuming that there is a valid reason for printing this error sometimes, how come there's no line number? --Doug

resolved fixed

4feb835

["weaver/src/org/aspectj/weaver/Advice.java", "weaver/src/org/aspectj/weaver/Lint.java", "weaver/src/org/aspectj/weaver/NewConstructorTypeMunger.java", "weaver/src/org/aspectj/weaver/ResolvedTypeX.java", "weaver/src/org/aspectj/weaver/Shadow.java", "weaver/src/org/aspectj/weaver/WeaverMessages.java", "weaver/src/org/aspectj/weaver/WeaverStateInfo.java", "weaver/src/org/aspectj/weaver/World.java", "weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java", "weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java", "weaver/src/org/aspectj/weaver/bcel/ClassPathManager.java", "weaver/src/org/aspectj/weaver/bcel/LazyClassGen.java", "weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java", "weaver/src/org/aspectj/weaver/patterns/ArgsPointcut.java", "weaver/src/org/aspectj/weaver/patterns/CflowPointcut.java", "weaver/src/org/aspectj/weaver/patterns/DeclareParents.java", "weaver/src/org/aspectj/weaver/patterns/DeclarePrecedence.java", "weaver/src/org/aspectj/weaver/patterns/DeclareSoft.java", "weaver/src/org/aspectj/weaver/patterns/IfPointcut.java", "weaver/src/org/aspectj/weaver/patterns/PerFromSuper.java", "weaver/src/org/aspectj/weaver/patterns/ReferencePointcut.java", "weaver/src/org/aspectj/weaver/patterns/ThisOrTargetPointcut.java", "weaver/src/org/aspectj/weaver/patterns/TypePattern.java", "weaver/src/org/aspectj/weaver/patterns/WildTypePattern.java", "weaver/testsrc/org/aspectj/weaver/BcweaverTests.java", "weaver/testsrc/org/aspectj/weaver/WeaverMessagesTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 61536 Front-end bug, shouldn't allow patterns of the form foo.., should be foo..*

See following code: public class Test2 { public static void main(String args[]) { System.out.println("Hi"); } } aspect Aspect2 { // shouldn't one have to say, java..* instead of java.. in the following?? // Note that the first advice (incorrect one) passes the front-end, but does // not match, whereas the second one does match. I believe the front-end // should reject the first one. before () : call( * java..(..)) && within(Test2) { System.out.println( "Incorrect One: Before a call of method in a java package "); } before () : call( * java..*(..)) && within(Test2) { System.out.println( "Correct One: Before a call of method in a java package "); } }

resolved fixed

45bce91

["tests/bugs/EllipsesStar.java", "weaver/src/org/aspectj/weaver/patterns/PatternParser.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 48990 Special case if(false) to not require a dynamic test

FastMatch, the efficient pattern matching for pointcuts on the constant pool, is currrently only implemented for the within pointcut. I am planning to provide further oimplementations for other pointcuts by release 1.2.

resolved fixed

10c6de6

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/IfPseudoToken.java", "weaver/src/org/aspectj/weaver/patterns/IfPointcut.java", "weaver/src/org/aspectj/weaver/patterns/Pointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 64331 java.lang.NullPointerException in WeaverMessageHandler class

resolved fixed

573741c

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/WeaverMessageHandler.java", "tests/bugs/abstractITDs/A.java", "tests/bugs/abstractITDs/C.java", "weaver/src/org/aspectj/weaver/ResolvedTypeX.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 58681 -X should output available -X options

ajc should emit the available -X options on -help or -X request (the latter like java) to get more traffic and feedback on the experimental options.

resolved fixed

6ea8300

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/AjdtCommand.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/BuildArgParser.java", "org.aspectj.ajdt.core/src/org/aspectj/tools/ajc/Main.java", "org.aspectj.ajdt.core/testsrc/EajcModuleTests.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/tools/ajc/MainTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 69459 Hiding of Instance Methods by static methods

Using Introduction it is possible to hide instance methods by static methods. Example: class Super { public void m(){}; } class Sub {} aspect A { public static void Sub.m(){} } Acccording to the Java Language Specification this is not allowed. Is this behaviour desired ?? It is also possible to override static methods by instance methods, wich causes a compile time error in java.

resolved fixed

b184363

["tests/bugs/intertypeOverrides/Aspect1.java", "tests/bugs/intertypeOverrides/Aspect2.java", "tests/bugs/intertypeOverrides/IntertypeOverrides.java", "tests/bugs/intertypeOverrides/IntertypeOverrides2.java", "tests/bugs/intertypeOverrides/Subclass.java", "tests/bugs/intertypeOverrides/Superclass.java", "weaver/src/org/aspectj/weaver/ResolvedTypeX.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 53999 "can't bind type" message has $ for . in type name for declare soft

cosmetic mistake in error message... expected: can't bind type name 'unknown.Error' actual: can't bind type name 'unknown$Error' (not sure why it would ever be munged with $) public class Test { public static void main(String[] args) { test(); } static void test() { throw new Error("hello"); } static aspect A { declare soft : unknown.Error : call(void test()); // CE } }

resolved fixed

936459c

["tests/bugs/Cosmetic.java", "weaver/src/org/aspectj/weaver/patterns/WildTypePattern.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 70619 compiler aborts with "conflicting dominates orders" with circular declare precedences

The following program causes ajc 1.2 to abort: public class Conflict { public static void main(String[] args) { } } aspect Conflict1 { declare precedence: Conflict1, Conflict2; before(): execution(* *(..)) { } } aspect Conflict2 { declare precedence: Conflict2, Conflict1; after(): execution(* *(..)) { } }

resolved fixed

75852d7

["tests/bugs/bug70619/Conflict.java", "tests/bugs/bug70619/Precedence.java", "weaver/src/org/aspectj/weaver/World.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 70008 problem with ajdoc -public

resolved fixed

8dc0845

["ajdoc/src/org/aspectj/tools/ajdoc/HtmlDecorator.java", "ajdoc/testdata/coverage/foo/PkgVisibleClass.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/CoverageTestCase.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/SpacewarTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 69011 ajdoc fails when using default package

resolved fixed

2cc4826

["ajdoc/src/org/aspectj/tools/ajdoc/StubFileGenerator.java", "ajdoc/testdata/coverage/InDefaultPackage.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/CoverageTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 68494 ajdoc does not support .aj files

In addition to accepting .java source files ajdoc needs to accept .aj files.

resolved fixed

3707411

["ajdoc/src/org/aspectj/tools/ajdoc/Main.java", "ajdoc/src/org/aspectj/tools/ajdoc/StructureUtil.java", "ajdoc/src/org/aspectj/tools/ajdoc/StubFileGenerator.java", "ajdoc/testdata/coverage/foo/UseThisAspectForLinkCheck.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/CoverageTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 61411 AJDoc launch script on Windows can lose arguments

Using AspectJ 1.2rc1 on Windows XP This report highlights a problem that I've seen using ajdoc.bat on Windows but the issue applies equally to the ajc.bat and ajbrowser.bat files as well. The %ASPECTJ_HOME%\bin\ajdoc.bat file that users run to launch the ajdoc tool imposes a limit of only 9 command line arguments that may be passed to the class org.aspectj.tools.ajdoc.Main. In scenarios where there the -sourcepath, -classpath, -d etc options are used it is easy for these to "eat up" the list of arguments that are passed into the JVM. A long list of packages entered at the end of the ajdoc.bat command can be truncated or possibly even ignored (in which case an error message will be output telling the user that no classes or packages have been specified). In order to prevent a limit being put on the number of arguments passed to the launched JVM, the invocation line needs to end with %* rather than the %1 %2 %3 %4 %5 %6 %7 %8 %9 list it currently uses. The proposed fix also *seems* (could somebody else confirm this ?) to sort out another problem regarding the ajdoc.bat file which is this : long semi- colon delimited paths supplied as the arguments for the -sourcepath and -classpath options seem to get split apart and passed into the JVM as separate arguments unless the entire path list is supplied inside quotes. This should not be necessary. It seems that the batch file processor interprets the semi-colons in a path list as delimiters between arguments. Consequently each element in the path list is treated as a separate argument instead of being part of one big string representing the sourcepath or classpath.

resolved fixed

39c3a3b

["build/src/$installer$/org/aspectj/Main.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 62227 Load Time Weaving aborts on any kind of warning (declare/xlint)

The message handler in the weaving adapter for load time weaving says: public boolean handleMessage(IMessage message) throws AbortException { if (!isIgnoring(message.getKind())) { if (verbose) System.err.println(message.getMessage()); throw new AbortException(message); } return true; } This means for warnings it goes bang. So, even a declare warning that is meant to tell the user something informational during a LTW will cause the code to blow up. The fix is straightforward and simply to log warning messages and only fail for error messages. I am waiting for a testcase from Matthew before checking in the fix.

resolved fixed

9ebfc84

["org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/BcweaverJarMaker.java", "weaver/src/org/aspectj/weaver/WeavingURLClassLoader.java", "weaver/src/org/aspectj/weaver/tools/WeavingAdaptor.java", "weaver/testsrc/org/aspectj/weaver/WeavingURLClassLoaderTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 59599 Race condition in test suite for incremental

On faster machines (my linux desktop, andy's home pc) several of the tests in ajcTests.xml are failing (suite attached). This appears to be due to a race condition between checking directory contents and waiting for the compilation to complete. I have an environment in which I can test candidate fixes if you can give me a pointer for what to tweak...

resolved fixed

bd16033

["testing/src/org/aspectj/testing/harness/bridge/DirChanges.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 59909 CFlowStack removesThreads to late

Problem: The current implementation of CFlowStack (Version 1.1-till 1.2 rc1) stores all threads in a hashtable. These Threads are removes after several calls to the methods getThreadStack(). (In our cases >70 calls.) In our project, this cycle is much to long. We have soveral long running threads, which grap quite a lot of lot of memory. This memory can only be freed after the threads have been removed from the CFlowStack. In our production code we sum up to more than 300 Threads stored in different CFlowStack Varaibles. Often this results in out of memory Errors. Added patch provides an improved freeing scheme. It checks if the size of the table has grown, if it has, it checks if it can remove some threads.

resolved fixed

5f6b18b

["runtime/src/org/aspectj/runtime/internal/CFlowStack.java", "runtime/src/org/aspectj/runtime/internal/cflowstack/ThreadStack.java", "runtime/src/org/aspectj/runtime/internal/cflowstack/ThreadStackFactory.java", "runtime/src/org/aspectj/runtime/internal/cflowstack/ThreadStackFactoryImpl.java", "runtime/src/org/aspectj/runtime/internal/cflowstack/ThreadStackFactoryImpl11.java", "runtime/src/org/aspectj/runtime/internal/cflowstack/ThreadStackImpl11.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 54238 Restore build cancelling to Swing-based IDEs

Core compiler implementation changes have resulted in an incompatability with AJDE's build cancelling mechanism. Once the core canceling behavior stabilizes this needs to be restored.

resolved fixed

a17b51b

["ajbrowser/src/org/aspectj/tools/ajbrowser/BasicEditor.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 59596 Null pointer exception while weaving java.awt.Label

I tried to add an Aspect to java.awt.Label. I compile the aspect via: ajc -inpath /usr/local/j2sdk_nb/j2sdk1.4.2/jre/lib/rt.jar Timestamp.java Here is the aspect Timestamp.java: aspect Timestamp { private int java.awt.Label._ts_read = 0; private int java.awt.Label._ts_write = 0; pointcut writeOp(): call (void java.awt.Label.setText (String)); pointcut readOp(): call (String java.awt.Label.getText()); after (java.awt.Label b) returning: readOp() && target (b) { b._ts_read++; } after (java.awt.Label b) returning: writeOp() && target (b) { b._ts_write++; System.out.println (b._ts_write); } public static void main (String[] args) { java.awt.Label b1 = new java.awt.Label(); b1.setText ("abc"); } } Here is the error message I get from ajc: null java.lang.NullPointerException at org.aspectj.ajdt.internal.core.builder.EclipseAdapterUtils.makeLocationContext(EclipseAdapterUtils.java:50) at org.aspectj.ajdt.internal.core.builder.EclipseAdapterUtils.makeSourceLocation(EclipseAdapterUtils.java:120) at org.aspectj.ajdt.internal.core.builder.EclipseAdapterUtils.makeMessage(EclipseAdapterUtils.java:129) at org.aspectj.ajdt.internal.core.builder.AjBuildManager$4.acceptResult(AjBuildManager.java:663) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.acceptResult(AjCompilerAdapter.java:178) at org.aspectj.ajdt.internal.compiler.WeaverAdapter.finishedWith(WeaverAdapter.java:203) at org.aspectj.ajdt.internal.compiler.WeaverAdapter.weaveCompleted(WeaverAdapter.java:167) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:570) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.weave(AjCompilerAdapter.java:239) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.afterCompiling(AjCompilerAdapter.java:114) at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:376) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:600) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild(AjBuildManager.java:160) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:94) at org.aspectj.ajdt.ajc.AjdtCommand.doCommand(AjdtCommand.java:102) at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(AjdtCommand.java:53) at org.aspectj.tools.ajc.Main.run(Main.java:280) at org.aspectj.tools.ajc.Main.runMain(Main.java:217) at org.aspectj.tools.ajc.Main.main(Main.java:79) 1 fail|abort

resolved fixed

a97f3b6

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/EclipseAdapterUtils.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java