Ambiguous documentation
{'login': 'theo-m', 'id': 17948980, 'node_id': 'MDQ6VXNlcjE3OTQ4OTgw', 'avatar_url': 'https://avatars.githubusercontent.com/u/17948980?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/theo-m', 'html_url': 'https://github.com/theo-m', 'followers_url': 'https://api.github.com/users/theo-m/followers', 'following_url': 'https://api.github.com/users/theo-m/following{/other_user}', 'gists_url': 'https://api.github.com/users/theo-m/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/theo-m/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/theo-m/subscriptions', 'organizations_url': 'https://api.github.com/users/theo-m/orgs', 'repos_url': 'https://api.github.com/users/theo-m/repos', 'events_url': 'https://api.github.com/users/theo-m/events{/privacy}', 'received_events_url': 'https://api.github.com/users/theo-m/received_events', 'type': 'User', 'site_admin': False}
[{'id': 1935892861, 'node_id': 'MDU6TGFiZWwxOTM1ODkyODYx', 'url': 'https://api.github.com/repos/huggingface/datasets/labels/documentation', 'name': 'documentation', 'color': '0075ca', 'default': True, 'description': 'Improvements or additions to documentation'}]
{'login': 'theo-m', 'id': 17948980, 'node_id': 'MDQ6VXNlcjE3OTQ4OTgw', 'avatar_url': 'https://avatars.githubusercontent.com/u/17948980?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/theo-m', 'html_url': 'https://github.com/theo-m', 'followers_url': 'https://api.github.com/users/theo-m/followers', 'following_url': 'https://api.github.com/users/theo-m/following{/other_user}', 'gists_url': 'https://api.github.com/users/theo-m/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/theo-m/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/theo-m/subscriptions', 'organizations_url': 'https://api.github.com/users/theo-m/orgs', 'repos_url': 'https://api.github.com/users/theo-m/repos', 'events_url': 'https://api.github.com/users/theo-m/events{/privacy}', 'received_events_url': 'https://api.github.com/users/theo-m/received_events', 'type': 'User', 'site_admin': False}
[{'login': 'theo-m', 'id': 17948980, 'node_id': 'MDQ6VXNlcjE3OTQ4OTgw', 'avatar_url': 'https://avatars.githubusercontent.com/u/17948980?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/theo-m', 'html_url': 'https://github.com/theo-m', 'followers_url': 'https://api.github.com/users/theo-m/followers', 'following_url': 'https://api.github.com/users/theo-m/following{/other_user}', 'gists_url': 'https://api.github.com/users/theo-m/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/theo-m/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/theo-m/subscriptions', 'organizations_url': 'https://api.github.com/users/theo-m/orgs', 'repos_url': 'https://api.github.com/users/theo-m/repos', 'events_url': 'https://api.github.com/users/theo-m/events{/privacy}', 'received_events_url': 'https://api.github.com/users/theo-m/received_events', 'type': 'User', 'site_admin': False}]
Hi @theo-m !

A few lines above this line, you'll find that the `_split_generators` method returns a list of `SplitGenerator`s objects:

```python
datasets.SplitGenerator(
    name=datasets.Split.VALIDATION,
    # These kwargs will be passed to _generate_examples
    gen_kwargs={
        "filepath": os.path.join(data_dir, "dev.jsonl"),
        "split": "dev",
    },
),
```

Notice the `gen_kwargs` argument passed to the constructor of `SplitGenerator`: this dict will be unpacked as keyword arguments to pass to the `_generat_examples` method (in this case the `filepath` and `split` arguments).

Let me know if that helps! Oh ok I hadn't made the connection between those two, will offer a tweak to the comment and the template then - thanks!
https://github.com/huggingface/datasets/blob/2ac9a0d24a091989f869af55f9f6411b37ff5188/templates/new_dataset_script.py#L156-L158

Looking at the template, I find this documentation line to be confusing, the method parameters don't include the `gen_kwargs` so I'm unclear where they're coming from.

Happy to push a PR with a clearer statement when I understand the meaning.
{'url': 'https://api.github.com/repos/huggingface/datasets/issues/2009/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}