Updated OPUS Open Subtitles Dataset with metadata information
{'login': 'Valahaar', 'id': 19476123, 'node_id': 'MDQ6VXNlcjE5NDc2MTIz', 'avatar_url': 'https://avatars.githubusercontent.com/u/19476123?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Valahaar', 'html_url': 'https://github.com/Valahaar', 'followers_url': 'https://api.github.com/users/Valahaar/followers', 'following_url': 'https://api.github.com/users/Valahaar/following{/other_user}', 'gists_url': 'https://api.github.com/users/Valahaar/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Valahaar/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Valahaar/subscriptions', 'organizations_url': 'https://api.github.com/users/Valahaar/orgs', 'repos_url': 'https://api.github.com/users/Valahaar/repos', 'events_url': 'https://api.github.com/users/Valahaar/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Valahaar/received_events', 'type': 'User', 'site_admin': False}
[]
[]
Hi !
About the problems you mentioned:
- Saving the infos is only done for the configurations inside the BUILDER_CONFIGS. Otherwise you would need to run the scripts on ALL language pairs, which is not what we want.
- Moreover when you're on your branch, please specify the path to your local version of the dataset script, like "./datasets/open_subtitles". Otherwise the dataset is loaded from the master branch on github.
Hope that clarifies things a bit

And of course feel free to add methods or classmethods to your builder.
 Great! Thank you :)
I'll close the issue as well.
Close #1844 

Problems:
- I ran `python datasets-cli test datasets/open_subtitles --save_infos --all_configs`, hence the change in `dataset_infos.json`, but it appears that the metadata features have not been added for all pairs. Any idea why that might be?
- Possibly related to the above, I tried doing `pip uninstall datasets && pip install -e ".[dev]"` after the changes, and loading the dataset via `load_dataset("open_subtitles", lang1='hi', lang2='it')` to check if the update worked, but the loaded dataset did not contain the metadata fields (neither in the features nor doing `next(iter(dataset['train']))`). What step(s) did I miss?

Questions:
- Is it ok to have a `classmethod` in there? I have not seen any in the few other datasets I have checked. I could make it a local method of the `_generate_examples` method, but I'd rather not duplicate the logic...
{'url': 'https://api.github.com/repos/huggingface/datasets/issues/1865/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}
{'url': 'https://api.github.com/repos/huggingface/datasets/pulls/1865', 'html_url': 'https://github.com/huggingface/datasets/pull/1865', 'diff_url': 'https://github.com/huggingface/datasets/pull/1865.diff', 'patch_url': 'https://github.com/huggingface/datasets/pull/1865.patch', 'merged_at': '2021-02-12T16:59:44Z'}