Add ReFreSD dataset
{'login': 'mpariente', 'id': 18496796, 'node_id': 'MDQ6VXNlcjE4NDk2Nzk2', 'avatar_url': 'https://avatars.githubusercontent.com/u/18496796?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mpariente', 'html_url': 'https://github.com/mpariente', 'followers_url': 'https://api.github.com/users/mpariente/followers', 'following_url': 'https://api.github.com/users/mpariente/following{/other_user}', 'gists_url': 'https://api.github.com/users/mpariente/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/mpariente/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/mpariente/subscriptions', 'organizations_url': 'https://api.github.com/users/mpariente/orgs', 'repos_url': 'https://api.github.com/users/mpariente/repos', 'events_url': 'https://api.github.com/users/mpariente/events{/privacy}', 'received_events_url': 'https://api.github.com/users/mpariente/received_events', 'type': 'User', 'site_admin': False}
[]
[]
Cool dataset! Replying in-line:

> This PR adds the **ReFreSD dataset**.
> The original data is hosted [on this github repo](https://github.com/Elbria/xling-SemDiv) and we use the `REFreSD_rationale` to expose all the data.
> 
> Need feedback on:
> 
> * I couldn't generate the dummy data. The file we download is a tsv file, but without extension, I suppose this is the problem. I'm sure there is a simple trick to make this work.

you can use `--match_text_files` in the dummy data generation:
`python datasets-cli dummy_data datasets/refresd --auto_generate --match_text_files "REFreSD_rationale"`

> * The feature names.
>   
>   * I don't know if it's better to stick to the classic `sentence1`, `sentence2` or to `sentence_en`, `sentence_fr` to be more explicit.

It would actually be even better to use the `Translation` feature here to replace best:
`"sentence_pair": datasets.Translation(languages=['en', 'fr']),`

Then during `_generate_examples` this filed should look like"
`{"sentence_pair": {"fr": french, "en": english}}`

>   * There is a binary label (called `label`, no problem here), and a 3-class label called `#3_labels` in the original tsv. I changed it to `all_labels` but I'm sure there is better.
Looks good!

> * The rationales are lists of integers, extracted as a string at first. I wonder what's the best way to treat them, any idea? Also, I couldn't manage to make a `Sequence` of `int8` but I'm sure I've missed something simple.

Having the feature declared as `"rationale_en": datasets.Sequence(datasets.Value("int32"))` should work

> 
> Thanks in advance

Hope that helps you out! Don't forget to `make style`, rebase from master, and run all the tests before pushing again! You will also need to add a `README.md` as described in the guide:
https://github.com/huggingface/datasets/blob/master/ADD_NEW_DATASET.md#tag-the-dataset-and-write-the-dataset-card Thanks a lot for the answer, that does help a lot !
I opened a PR for a License in the original repo so I was waiting for that for the model card. If there is no news on Monday, I'll add it without License.  Looks good! It looks like it might need a rebase to pass the tests. Once you do that, should be good to go!
This PR adds the **ReFreSD dataset**. 
The original data is hosted [on this github repo](https://github.com/Elbria/xling-SemDiv) and we use the `REFreSD_rationale` to expose all the data. 


Need feedback on:
- I couldn't generate the dummy data. The file we download is a tsv file, but without extension, I suppose this is the problem. I'm sure there is a simple trick to make this work. 
- The feature names. 
  - I don't know if it's better to stick to the classic `sentence1`, `sentence2` or to `sentence_en`, `sentence_fr` to be more explicit. 
  - There is a binary label (called `label`, no problem here), and a 3-class label called `#3_labels` in the original tsv. I changed it to `all_labels` but I'm sure there is better. 
- The rationales are lists of integers, extracted as a string at first. I wonder what's the best way to treat them, any idea? Also, I couldn't manage to make a `Sequence` of `int8` but I'm sure I've missed something simple. 

Thanks in advance 
{'url': 'https://api.github.com/repos/huggingface/datasets/issues/1139/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 1, 'eyes': 0}
{'url': 'https://api.github.com/repos/huggingface/datasets/pulls/1139', 'html_url': 'https://github.com/huggingface/datasets/pull/1139', 'diff_url': 'https://github.com/huggingface/datasets/pull/1139.diff', 'patch_url': 'https://github.com/huggingface/datasets/pull/1139.patch', 'merged_at': '2020-12-16T16:01:18Z'}