Fix save_to_disk issue
{'login': 'M-Salti', 'id': 9285264, 'node_id': 'MDQ6VXNlcjkyODUyNjQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9285264?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/M-Salti', 'html_url': 'https://github.com/M-Salti', 'followers_url': 'https://api.github.com/users/M-Salti/followers', 'following_url': 'https://api.github.com/users/M-Salti/following{/other_user}', 'gists_url': 'https://api.github.com/users/M-Salti/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/M-Salti/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/M-Salti/subscriptions', 'organizations_url': 'https://api.github.com/users/M-Salti/orgs', 'repos_url': 'https://api.github.com/users/M-Salti/repos', 'events_url': 'https://api.github.com/users/M-Salti/events{/privacy}', 'received_events_url': 'https://api.github.com/users/M-Salti/received_events', 'type': 'User', 'site_admin': False}
[]
[]
So I was curious why the issue reported at #1919 wasn't caught in [this test](https://github.com/huggingface/datasets/blob/248104c4bdb2e01c036b7578867199191fbff181/tests/test_arrow_dataset.py#L209), so I did some digging.
I tried to save to a temporary directory (just like in the test), like this:
```python
with tempfile.TemporaryDirectory() as requested_tempdir:
    squad.save_to_disk(requested_tempdir)     # no error
```
and it executes succesfuly without problems.
So why does it work, but this doesn't?
```python
squad.save_to_disk("./squad")   # error
```
It's because `save_to_disk` also creates a temporary directory (let's call it `tempdir`), and since `tempdir` and `requested_tempdir` share the same parents, the `Path.joinpath` method [(here)](https://github.com/huggingface/datasets/blob/248104c4bdb2e01c036b7578867199191fbff181/src/datasets/arrow_dataset.py#L469) will keep `requested_tempdir` as it is and the *train* directory will be created under `requested_tempdir` and hence no errors will arise.

But in the second case (where we are saving to a local dir), the *train* directory is created under *squad* which in turn is created under `tempdir`, not under `.` (current dir).

So, all of this probably doesn't help solving the issue but it might help creating a better test, and it also makes me wonder why are we saving to a temporary dir in `save_to_disk` anyway? I mean, won't it be removed with all its contents upon execution completion? what's the point then?  CLosing in favor of #1923
Fixes #1919 

{'url': 'https://api.github.com/repos/huggingface/datasets/issues/1920/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}
{'url': 'https://api.github.com/repos/huggingface/datasets/pulls/1920', 'html_url': 'https://github.com/huggingface/datasets/pull/1920', 'diff_url': 'https://github.com/huggingface/datasets/pull/1920.diff', 'patch_url': 'https://github.com/huggingface/datasets/pull/1920.patch', 'merged_at': None}