break statement not required
{'login': 'mayurnewase', 'id': 12967587, 'node_id': 'MDQ6VXNlcjEyOTY3NTg3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12967587?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mayurnewase', 'html_url': 'https://github.com/mayurnewase', 'followers_url': 'https://api.github.com/users/mayurnewase/followers', 'following_url': 'https://api.github.com/users/mayurnewase/following{/other_user}', 'gists_url': 'https://api.github.com/users/mayurnewase/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/mayurnewase/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/mayurnewase/subscriptions', 'organizations_url': 'https://api.github.com/users/mayurnewase/orgs', 'repos_url': 'https://api.github.com/users/mayurnewase/repos', 'events_url': 'https://api.github.com/users/mayurnewase/events{/privacy}', 'received_events_url': 'https://api.github.com/users/mayurnewase/received_events', 'type': 'User', 'site_admin': False}
[]
[]
I guess,test failing due to connection error? We just fixed the other dataset on master. Could you rebase from master and push to rerun the CI ? If I'm not wrong this function returns None if no main class was found.
I think it makes things less clear not to have a return at the end of the function.
I guess we can have one return in the for loop instead of the break statement, AND one return at the end to explicitly return None.
What do you think ?
{'url': 'https://api.github.com/repos/huggingface/datasets/issues/291/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}
{'url': 'https://api.github.com/repos/huggingface/datasets/pulls/291', 'html_url': 'https://github.com/huggingface/datasets/pull/291', 'diff_url': 'https://github.com/huggingface/datasets/pull/291.diff', 'patch_url': 'https://github.com/huggingface/datasets/pull/291.patch', 'merged_at': None}