ethos first commit
{'login': 'iamollas', 'id': 22838900, 'node_id': 'MDQ6VXNlcjIyODM4OTAw', 'avatar_url': 'https://avatars.githubusercontent.com/u/22838900?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/iamollas', 'html_url': 'https://github.com/iamollas', 'followers_url': 'https://api.github.com/users/iamollas/followers', 'following_url': 'https://api.github.com/users/iamollas/following{/other_user}', 'gists_url': 'https://api.github.com/users/iamollas/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/iamollas/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/iamollas/subscriptions', 'organizations_url': 'https://api.github.com/users/iamollas/orgs', 'repos_url': 'https://api.github.com/users/iamollas/repos', 'events_url': 'https://api.github.com/users/iamollas/events{/privacy}', 'received_events_url': 'https://api.github.com/users/iamollas/received_events', 'type': 'User', 'site_admin': False}
[]
[]
> Nice thanks !
> 
> I left a few comments
> 
> Also it looks like this PR includes changes about other files than the ones for ethos
> 
> Can you create another branch and another PR please ?

@lhoestq Should I close this PR? The new one is the: #1453 You can create another PR and close this one if you don't mind > You can create another PR and close this one if you don't mind

Perfect! You should see the #1453 PR for the fixed version! Thanks
Ethos passed all the tests except from this one: 
RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_<your-dataset-name>

with this error: 
E               OSError: Cannot find data file. 
E               Original error:
E               [Errno 2] No such file or directory: 
{'url': 'https://api.github.com/repos/huggingface/datasets/issues/1318/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}
{'url': 'https://api.github.com/repos/huggingface/datasets/pulls/1318', 'html_url': 'https://github.com/huggingface/datasets/pull/1318', 'diff_url': 'https://github.com/huggingface/datasets/pull/1318.diff', 'patch_url': 'https://github.com/huggingface/datasets/pull/1318.patch', 'merged_at': None}