Enable streaming dataset to use the "all" split
{'login': 'cakiki', 'id': 3664563, 'node_id': 'MDQ6VXNlcjM2NjQ1NjM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3664563?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cakiki', 'html_url': 'https://github.com/cakiki', 'followers_url': 'https://api.github.com/users/cakiki/followers', 'following_url': 'https://api.github.com/users/cakiki/following{/other_user}', 'gists_url': 'https://api.github.com/users/cakiki/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/cakiki/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/cakiki/subscriptions', 'organizations_url': 'https://api.github.com/users/cakiki/orgs', 'repos_url': 'https://api.github.com/users/cakiki/repos', 'events_url': 'https://api.github.com/users/cakiki/events{/privacy}', 'received_events_url': 'https://api.github.com/users/cakiki/received_events', 'type': 'User', 'site_admin': False}
[]
[]
The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_4698). All of your documentation changes will be reflected on that endpoint. @albertvillanova 
Adding the validation split causes these two `assert_called_once` assertions to fail with `AssertionError: Expected 'ArrowWriter' to have been called once. Called 2 times`:

https://github.com/huggingface/datasets/blob/main/tests/test_builder.py#L548-L562

It might be better to create a new dummy generator for the streaming tests, WDYT? Alternatively we could test for `self.call_count` equalling 2. @cakiki have you read my comment in the issue page?
https://github.com/huggingface/datasets/issues/4637#issuecomment-1175984812 Streaming with `split=all` seems to be working, will fix the failing test next Not sure if marking the PR as "ready for review" actually notified you, so tagging @albertvillanova just in case :smiley_cat:  cc @lhoestq  Hi @cakiki, still interested in working on this? :)  @albertvillanova So sorry; I have no idea how this slipped through the cracks. Yes, I'd still like to work on this. Is it okay if I DM you on slack? Sure!! And nevermind!
Fixes #4637
{'url': 'https://api.github.com/repos/huggingface/datasets/issues/4698/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}
{'url': 'https://api.github.com/repos/huggingface/datasets/pulls/4698', 'html_url': 'https://github.com/huggingface/datasets/pull/4698', 'diff_url': 'https://github.com/huggingface/datasets/pull/4698.diff', 'patch_url': 'https://github.com/huggingface/datasets/pull/4698.patch', 'merged_at': None}