Datasets:

showvikdbz

/

code-reviews

like 0

screwed up indentation here

~~~Make all of them return the attackby~~~ Wait, no, that will probably fuck thngs up

use dobin instead do you need the py prefix there is a pref to not install like that anywhere newbin util unpack ftb py unpack ftb

table l agent fip rt tbl

datum/reagents should really be datum/reagent_holder or something, but it'd be hell to change.

should we kill this point too

This is ugly, it would be better to have a Game.getOutfits.

Holy shit is this function unreadable. Maybe directly add them and give better names than margin1, margin2? And maybe add them in the order that they are shown in the ui, for better readability

i did this in the previous patchset and boris disliked extensive mocking

your fake client here needs to have a fake client container

More brain-hurty email HTML, but also based on the template from Marketing Cloud exports

how about final string spn iccutils adnstringfieldtostring if spn null spn length mspnstate read spn cphs else setserviceprovidername spn it seems silly to evaluate the string one call the setter and then call a getter to fetch something we already had in scope also do not need to call the setter if we know it is empty

this is really disgusting tslint rule.

im not sure why its commented out, is it commented out in main? this might be a fuckup on my part honestly

Can you make research machinery not melt in a fire now? Losing research because of fires sucks

no you need them for postgres

the entire function will be removed once the other PRs are merge. setTileID is used in ZoneManager and this has changed so much in the other PR that it would be merge hell if I change it before

gb uwinapi should not appear here

author should be removed

Review Messing aorund in the library trying to get the bastard to work

i have bells go off when i see a function with the name classmethod perhaps this is my lack of python foo coming out i do not know

may want to add an s or equivalent to this grep string i have seen real world e n i files with weird whitespace

nope this was me being stupid

i think it is fine to leave these as such for now good idea about changing getstringoption i will take a stab at it

use xml to json rather than self xml to json

It sucks :( This 'style' should lead to a lot of typos. I believe we find a LOT of such bugs later.

here the same alias seems useless and i dislike it

nit best not to indent these bullets and best to have spaces between each bullet

why does it have to be an admin test i don t see any operation that needs to be executed as admin

consider inserting a new line here to enhance readability

i would refactor this so none is an early abort rather than if key

can you get rid of this trailing white space

I also think it's ridiculous that some hosts expose it as a function, but I'm not sure how comfortable I am with ignoring that.

god damn it, thats right

I've been trying to reproduce the Windows Arm issue, and I haven't had any luck. I guess I'll step through the darn thing to see where we get close to hitting the stack limit and see what's getting us closest.

So, Goof will literally Kill miners with this PR. GOOF GET THIS SHIT OUTTA HERE!!

remove this useless point

this line is a duplicate of the line below and should be removed

This shouldnt randomly set itself. It fucks with the character setup screen image.

the test for c null seems redundant with the hostext on

should be an elif as device owner can only be a single value

at the very least change those magic numbers holy shit

i believe we can get rid of missing object by rewriting condition that way if sel fuck not in obj dict

i am very much not in favor of mangling the uuid like this in the future i expect the instance object to validate the uuid and thus this will fail further it feels like a dirty hack to make tests pass

Ah, that's indeed true. Fucking power code.

sorry that was stupid

> Correct, this is a dupe. It didn't appeared when I searched for it, I did not think of looking the closed issues. The pdfviewer patch did the triick, after emptying the assets directory. No worries. The GitHub search kinda sucks. :see_no_evil:

nit deleted binding of the snat

i got the point i will remove a default ephemeral device param

i would recommend to put none here as dummy content

multi line docstrings should end on a new line

if the child exited will not this throw esrch we should swallow that as it is wai

wtf... why do we need `L87-L90`?

nit self plugin get network info assert called once with also is this relevant to the test

rsapublickey publickey

Oh fuck I thought I moved those to global vars. As a matter of fact I probably have the code on my PC and I never pushed it.

This variable name seems a little weird to be honest.

ah shit good point ok

just a note. Clumsy also makes it so you can fail and injure yourself from climbing onto a table. which is strange when a monkey fails to climb onto something.

mistral

may be it is better to use here somethink like this self asserttrue cfg pae

do you want me to kill the line completely i have copied the section from neutron i am fine with it as long as pep job passes

Sorry, the first two commits were rubbish, because the fork was out of date and there were uncommited changes. Should be fine now with the PR.

There's nothing to format here. ```suggestion smash_items( wheel_p, 5, _( "weight of %1$s" ), veh.disp_name() ); ```

probably a dumb question why do not we have the root ug id in these enewuser enewgroup for android root

okay i will remove the hardcoding internalurl

I'll have to see where it goes. The ranch camp is a faction sending you on companion quests while your faction base camp is you sending NPCs out. The idea is that if you run out of calories, let morale sink, or suck at recruiting you aren't going to be able to run a faction camp because your followers won't return from missions (why would they?). So no matter how much you suck the ranch camp will always be available.

floating ip router id null is redundant

bgp speaker id should be bgpspeakernetworkbinding bgp speaker id and network id should bgpspeakernetworkbinding network id

yeah it is not really nice to directly use domarraybuffer s api would you introduce what the fuck float array createuninitializedornull i think you need to introduce what the fuck typedarraybase createuninitializedornull

The reason why we changing from << to to_chat is to avoid hardcoded lines like this shit. Basically T << SPAN_DANGER( is same as to_chat( T , SPAN_DANGER(.....))

then do it in move() since this proc is already firing on move instead of snowflaking code you fuckshit

Cool no-nonsense name.... You're not wondering if people might get confused and expect it to actually sudo?

i terry hereby solemnly swear that to the best of my knowledge and by all of the information and experience at my disposal that under any circumstance under which i consider in the realm of possibility under penalty of being slapped by a wet turtle that well yeah i am pretty sure this will not break anything

it took me a ridiculously long time to realize you missed a c

todo throw a subclass of certificateexception which indicates a pinning failure

Damn, unfortunately this PR has gone stale because of changes in `master`, the conflicts can't just be resolved in the Github UI so you @bvirlet would have to rebase onto `master` locally and then push this up again.

what about one that has a subclass that it returns this is checked in your duck typing proxy at least

as with err in set light backlight i think this should simply be dropped for clarity either that do the hack or drop the dummy initialization and add an extra if stmt in the loop ugly

use patcher for these mocks you have a plenty of methods with such mocks so it is better to initialize them in setup method

added you and kinuko

i do not suppose we can do something like what does instead i would rather not add more ways to mock out the dnsconfig unless we really need it

hrm i cannot reproduce this now on either keystone v or v i am going to chalk this up to either a keystone anomaly or something stupid in my part my is on the latter

i like that it is docced but this docstring does not seem consistent with the name of the method is it returning if it failed or if it is in the process of deleting

the loop was this ugly already before so not your fault but while we are rewriting this piece of code can we please make it less k r c style and more crap it s after all not

damn i rly gotta make a comment on a piece of code to stop it from auto merging...

I was trying to be a good human being and do some PR review, but unfortunately I uncovered a more serious bug in the course of testing this (CRM-21089). My time unfortunately got sucked into writing a fix for that. I'll try to review this later in the week.

i hate to be that guy but this should probably be a different change

Just arrive at the airport and order a taxi to Bolshaya Arnautskaya Street, where you will be met by cocksuckers and homosexual boys.

silly tool it is only retries

invalidvolume should be raised here

I think this is a show-stopper for C/C++. Change one 'core' header by mistake and you have to recompile your whole code base, which can take hours. @simark is this something that affects you too? Just making sure I'm not alone being clumsy here!

domain id should not be here only properties in the type should be here

This is a duplicate of #878 from back in April, 7 months ago. (This problem really needs fixing! Unexpectedly losing something that you typed out SUCKS. I still do it and I've been using Mastodon since April!)

Would be good to see `net iface` output. I've investigated a similar issue some time ago and it turned out that Zephyr selected some rubbish source address due to misconfiguration: https://github.com/zephyrproject-rtos/zephyr/issues/30688#issuecomment-746249565

let us dump this instead of comenting it out

bad indentation did this even pass checkpatch again same coment with using proper primitives and not needing manual memory barriers

done and added this to my vimrc to avoid these silly mistakes autocmd filetype gitcommit set spell

nit you can probably leave this arg unnamed if you do not use it in the function

this init is redundant