When I added unpack_buffer_archive, in code review people said
it was redundant with unpack_buffer and they should be merged.
I said merging was too annoying. They were right. This merges
the functions together into a function with a 38 line docstring
and a 18 line implementation.
Merge together unpack_buffer and unpack_buffer_archive. When I added unpack_buffer_archive, in code review people said
it was redundant with unpack_buffer and they should be merged.
I said merging was too annoying. They were right. This merges
the functions together into a function with a 38 line docstring
and a 18 line implementation.
This patch is to avoid adding macros which will build lapack-lite in  64 bit integer mode, which is not compatible with wasm's 32 bit pointers.

diff --git a/numpy/linalg/setup.py b/numpy/linalg/setup.py
index 94536bb2c..df6c61b9f 100644
--- a/numpy/linalg/setup.py
+++ b/numpy/linalg/setup.py
@@ -37,14 +37,14 @@ def configuration(parent_package='', top_path=None):
         class numpy_linalg_lapack_lite(system_info):
             def calc_info(self):
                 info = {'language': 'c'}
-                if sys.maxsize > 2**32:
+                # if sys.maxsize > 2**32:
                     # Build lapack-lite in 64-bit integer mode.
                     # The suffix is arbitrary (lapack_lite symbols follow it),
                     # but use the "64_" convention here.
-                    info['define_macros'] = [
-                        ('HAVE_BLAS_ILP64', None),
-                        ('BLAS_SYMBOL_SUFFIX', '64_')
-                    ]
+                    # info['define_macros'] = [
+                    #     ('HAVE_BLAS_ILP64', None),
+                    #     ('BLAS_SYMBOL_SUFFIX', '64_')
+                    # ]
                 self.set_info(**info)
 
         lapack_info = numpy_linalg_lapack_lite().get_info(2)

This patch is to avoid adding macros which will build lapack-lite in  64 bit integer mode, which is not compatible with wasm's 32 bit pointers.

diff --git a/numpy/linalg/setup.py b/numpy/linalg/setup.py
index 94536bb2c..df6c61b9f 100644
--- a/numpy/linalg/setup.py
+++ b/numpy/linalg/setup.py
@@ -37,14 +37,14 @@ def configuration(parent_package='', top_path=None):
         class numpy_linalg_lapack_lite(system_info):
             def calc_info(self):
                 info = {'language': 'c'}
-                if sys.maxsize > 2**32:
+                # if sys.maxsize > 2**32:
                     # Build lapack-lite in 64-bit integer mode.
                     # The suffix is arbitrary (lapack_lite symbols follow it),
                     # but use the "64_" convention here.
-                    info['define_macros'] = [
-                        ('HAVE_BLAS_ILP64', None),
-                        ('BLAS_SYMBOL_SUFFIX', '64_')
-                    ]
+                    # info['define_macros'] = [
+                    #     ('HAVE_BLAS_ILP64', None),
+                    #     ('BLAS_SYMBOL_SUFFIX', '64_')
+                    # ]
                 self.set_info(**info)
 
         lapack_info = numpy_linalg_lapack_lite().get_info(2)
