Datasets:

tiginamaria

/

bug-localization

like 2

quarkusio/quarkus/25666/25580

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25580

https://github.com/quarkusio/quarkus/pull/25666

https://github.com/quarkusio/quarkus/pull/25666

fix

Commas in Headers with AWS Lambda

### Describe the bug When you are dealing with headers that can have commas in their value, such as Access-Control-Request-Headers, the Lambda Handler seems to interpret them as different header values which causes CORS to not work correctly. ### Expected behavior When executing the curl ``` curl http://localhost:8080/hello -X OPTIONS -H 'Origin: http://example.com' -H 'Access-Control-Request-Headers: bar,foo' -v ``` the following header is returned ``` access-control-allow-headers: bar,foo ``` ### Actual behavior The following header is returned ``` access-control-allow-headers: bar ``` ### How to Reproduce? 1. Generate a new quarkus project with "AWS Lambda HTTP" and "RestEasy Classic Jackson" extension 2. Add the following lines to the application.properties: ``` quarkus.http.cors=true quarkus.http.cors.origins=http://example.com ``` 3. Run ./mvnw quarkus:dev 4. Execute the curls given above 5. Uncomment the "quarkus-amazon-lambda-http" in the `pom.xml` to see the expected behaviour ### Output of `uname -a` or `ver` Linux [REMOVED] 5.13.0-40-generic #45~20.04.1-Ubuntu SMP Mon Apr 4 09:38:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux ### Output of `java -version` openjdk version "14.0.2" 2020-07-14 ### GraalVM version (if different from Java) N/A, the issue can be reproduced without GraalVM ### Quarkus version or git rev 2.9.0.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Apache Maven 3.8.4 ### Additional information Event though the reproduction steps do not include deployment to Lambda, I have observed the same behavior with a different project also when it was deployed to AWS Lambda In the `io.quarkus.vertx.http.runtime.cors.CORSFilter` class, only the first header value is retrieved in this line: ``` final String requestedHeaders = request.getHeader(HttpHeaders.ACCESS_CONTROL_REQUEST_HEADERS); ``` But in the `io.quarkus.amazon.lambda.http.LambdaHttpHandler`, the string parts separated by comma are stored as different header values: ``` for (String val : header.getValue().split(",")) nettyRequest.headers().add(header.getKey(), val); ``` This is probably necessary because the API Gateway will send multiple header values separated with comma and there is no way to reconstruct the original request from the API Gateway's event. Maybe it would be an acceptable solution to have the CORSFilter expect multiple header values

d417333d7c55000d0d3988810457e71b0bb6d09f

bf1ff79002189d148ff1e0631cf1efec834aa152

https://github.com/quarkusio/quarkus/compare/d417333d7c55000d0d3988810457e71b0bb6d09f...bf1ff79002189d148ff1e0631cf1efec834aa152

diff --git a/extensions/amazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java b/extensions/amazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java index dea92dbf76d..d407f0c3747 100644 --- a/extensions/amazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java +++ b/extensions/amazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java @@ -9,10 +9,12 @@ import java.nio.charset.StandardCharsets; import java.util.Base64; import java.util.HashMap; +import java.util.HashSet; import java.util.Iterator; import java.util.List; import java.util.Locale; import java.util.Map; +import java.util.Set; import java.util.concurrent.CompletableFuture; import org.jboss.logging.Logger; @@ -47,8 +49,13 @@ public class LambdaHttpHandler implements RequestHandler<APIGatewayV2HTTPEvent, private static final int BUFFER_SIZE = 8096; private static final Headers errorHeaders = new Headers(); + + // comma headers for headers that have comma in value and we don't want to split it up into + // multiple headers + private static final Set<String> commaHeaders = new HashSet(); static { errorHeaders.putSingle("Content-Type", "application/json"); + commaHeaders.add("access-control-request-headers"); } public APIGatewayV2HTTPResponse handleRequest(APIGatewayV2HTTPEvent request, Context context) { @@ -182,8 +189,14 @@ httpMethod, ofNullable(request.getRawQueryString()) if (request.getHeaders() != null) { //apparently this can be null if no headers are sent for (Map.Entry<String, String> header : request.getHeaders().entrySet()) { if (header.getValue() != null) { - for (String val : header.getValue().split(",")) - nettyRequest.headers().add(header.getKey(), val); + // Some header values have commas in them and we don't want to + // split them up into multiple header values. + if (commaHeaders.contains(header.getKey().toLowerCase(Locale.ROOT))) { + nettyRequest.headers().add(header.getKey(), header.getValue()); + } else { + for (String val : header.getValue().split(",")) + nettyRequest.headers().add(header.getKey(), val); + } } } } diff --git a/integration-tests/amazon-lambda-http/src/main/java/io/quarkus/it/amazon/lambda/GreetingResource.java b/integration-tests/amazon-lambda-http/src/main/java/io/quarkus/it/amazon/lambda/GreetingResource.java index 754f52d36f4..36a740f406d 100644 --- a/integration-tests/amazon-lambda-http/src/main/java/io/quarkus/it/amazon/lambda/GreetingResource.java +++ b/integration-tests/amazon-lambda-http/src/main/java/io/quarkus/it/amazon/lambda/GreetingResource.java @@ -3,6 +3,7 @@ import javax.inject.Inject; import javax.ws.rs.Consumes; import javax.ws.rs.GET; +import javax.ws.rs.HeaderParam; import javax.ws.rs.POST; import javax.ws.rs.Path; import javax.ws.rs.Produces; @@ -14,6 +15,15 @@ @Path("/hello") public class GreetingResource { + @GET + @Produces(MediaType.TEXT_PLAIN) + @Path("comma") + public String comma(@HeaderParam("Access-Control-Request-Headers") String access) { + if (access == null || !access.contains(",")) + throw new RuntimeException("should have comma"); + return "ok"; + } + @GET @Produces(MediaType.TEXT_PLAIN) public String hello() { diff --git a/integration-tests/amazon-lambda-http/src/test/java/io/quarkus/it/amazon/lambda/AmazonLambdaSimpleTestCase.java b/integration-tests/amazon-lambda-http/src/test/java/io/quarkus/it/amazon/lambda/AmazonLambdaSimpleTestCase.java index dfc91d8cb9c..7fa451af996 100644 --- a/integration-tests/amazon-lambda-http/src/test/java/io/quarkus/it/amazon/lambda/AmazonLambdaSimpleTestCase.java +++ b/integration-tests/amazon-lambda-http/src/test/java/io/quarkus/it/amazon/lambda/AmazonLambdaSimpleTestCase.java @@ -22,6 +22,16 @@ @QuarkusTest public class AmazonLambdaSimpleTestCase { + @Test + public void testComma() throws Exception { + given() + .when() + .header("Access-Control-Request-Headers", "foo, bar, yello") + .get("/hello/comma") + .then() + .statusCode(200); + } + @Test public void testContext() throws Exception { given()

['integration-tests/amazon-lambda-http/src/main/java/io/quarkus/it/amazon/lambda/GreetingResource.java', 'extensions/amazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java', 'integration-tests/amazon-lambda-http/src/test/java/io/quarkus/it/amazon/lambda/AmazonLambdaSimpleTestCase.java']

{'.java': 3}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25790/25788

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25788

https://github.com/quarkusio/quarkus/pull/25790

https://github.com/quarkusio/quarkus/pull/25790

fixes

Gradle `quarkusBuild` fails with `ZipFile invalid LOC header` in `SmallRyeOpenApiProcessor`

### Describe the bug A repeated `./gradlew quarkusBuild` runs into the following exception from the `SmallRyeOpenApiProcessor`. In this case, the openapi classes and spec files are pulled from a dependency and are not located in the Gradle project. ``` > io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.smallrye.openapi.deployment.SmallRyeOpenApiProcessor#build threw an exception: java.io.UncheckedIOException: java.util.zip.ZipException: ZipFile invalid LOC header (bad signature) at io.quarkus.smallrye.openapi.deployment.SmallRyeOpenApiProcessor.addStaticModelIfExist(SmallRyeOpenApiProcessor.java:893) at io.quarkus.smallrye.openapi.deployment.SmallRyeOpenApiProcessor.findStaticModels(SmallRyeOpenApiProcessor.java:840) at io.quarkus.smallrye.openapi.deployment.SmallRyeOpenApiProcessor.generateStaticModel(SmallRyeOpenApiProcessor.java:774) at io.quarkus.smallrye.openapi.deployment.SmallRyeOpenApiProcessor.build(SmallRyeOpenApiProcessor.java:671) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:925) at io.quarkus.builder.BuildContext.run(BuildContext.java:277) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:829) at org.jboss.threads.JBossThread.run(JBossThread.java:501) Caused by: java.util.zip.ZipException: ZipFile invalid LOC header (bad signature) at java.base/java.util.zip.ZipFile$ZipFileInputStream.initDataOffset(ZipFile.java:1023) at java.base/java.util.zip.ZipFile$ZipFileInputStream.read(ZipFile.java:1033) at java.base/java.util.zip.ZipFile$ZipFileInflaterInputStream.fill(ZipFile.java:483) at java.base/java.util.zip.InflaterInputStream.read(InflaterInputStream.java:159) at java.base/java.io.FilterInputStream.read(FilterInputStream.java:133) at java.base/java.io.InputStream.readNBytes(InputStream.java:396) at java.base/java.io.InputStream.readAllBytes(InputStream.java:333) at io.quarkus.deployment.util.IoUtil.readBytes(IoUtil.java:18) at io.quarkus.smallrye.openapi.deployment.SmallRyeOpenApiProcessor.addStaticModelIfExist(SmallRyeOpenApiProcessor.java:888) ... 14 more ``` This consistently happens in [this PR](https://github.com/projectnessie/nessie/pull/4274), which can serve as a reproducer: ``` $ ./gradlew :ser:quar-ser:quarkusBuild $ echo "" > model/src/main/resources/META-INF/openapi.yaml $ ./gradlew :ser:quar-ser:quarkusBuild ``` ### Expected behavior _No response_ ### Actual behavior _No response_ ### How to Reproduce? _No response_ ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` _No response_ ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.9.1 ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Gradle 7.4.2 ### Additional information _No response_

976ffa21392105954a1314a9835ad5b2887b9996

633647848a286c0d0933d7f263ce4f13dc953030

https://github.com/quarkusio/quarkus/compare/976ffa21392105954a1314a9835ad5b2887b9996...633647848a286c0d0933d7f263ce4f13dc953030

diff --git a/extensions/smallrye-openapi/deployment/src/main/java/io/quarkus/smallrye/openapi/deployment/SmallRyeOpenApiProcessor.java b/extensions/smallrye-openapi/deployment/src/main/java/io/quarkus/smallrye/openapi/deployment/SmallRyeOpenApiProcessor.java index c87ed39582d..25122586b01 100644 --- a/extensions/smallrye-openapi/deployment/src/main/java/io/quarkus/smallrye/openapi/deployment/SmallRyeOpenApiProcessor.java +++ b/extensions/smallrye-openapi/deployment/src/main/java/io/quarkus/smallrye/openapi/deployment/SmallRyeOpenApiProcessor.java @@ -8,6 +8,7 @@ import java.io.UncheckedIOException; import java.lang.reflect.Modifier; import java.net.URL; +import java.net.URLConnection; import java.nio.charset.StandardCharsets; import java.nio.file.Files; import java.nio.file.Path; @@ -855,7 +856,7 @@ private List<Result> findStaticModels(SmallRyeOpenApiConfig openApiConfig, List< addStaticModelIfExist(results, ignorePatterns, possibleModelFile); } } catch (IOException ioe) { - ioe.printStackTrace(); + throw new UncheckedIOException("An error occured while processing " + path, ioe); } } } @@ -881,16 +882,19 @@ private void addStaticModelIfExist(List<Result> results, List<Pattern> ignorePat while (urls.hasMoreElements()) { URL url = urls.nextElement(); // Check if we should ignore - if (!shouldIgnore(ignorePatterns, url.toString())) { + String urlAsString = url.toString(); + if (!shouldIgnore(ignorePatterns, urlAsString)) { // Add as static model - try (InputStream inputStream = url.openStream()) { + URLConnection con = url.openConnection(); + con.setUseCaches(false); + try (InputStream inputStream = con.getInputStream()) { if (inputStream != null) { byte[] contents = IoUtil.readBytes(inputStream); results.add(new Result(format, new ByteArrayInputStream(contents))); } } catch (IOException ex) { - throw new UncheckedIOException(ex); + throw new UncheckedIOException("An error occured while processing " + urlAsString + " for " + path, ex); } } }

['extensions/smallrye-openapi/deployment/src/main/java/io/quarkus/smallrye/openapi/deployment/SmallRyeOpenApiProcessor.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25858/25847

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25847

https://github.com/quarkusio/quarkus/pull/25858

https://github.com/quarkusio/quarkus/pull/25858

fix

quarkus ext add io.quarkiverse.ngrok:quarkus-ngrok does not include version info

### Describe the bug running: `quarkus ext add io.quarkiverse.ngrok:quarkus-ngrok` adds only this: ``` <dependency> <groupId>io.quarkiverse.ngrok</groupId> <artifactId>quarkus-ngrok</artifactId> </dependency> ``` ### Expected behavior it should have added: ``` <dependency> <groupId>io.quarkiverse.ngrok</groupId> <artifactId>quarkus-ngrok</artifactId> <version>0.1.3</version> </dependency> ``` ### Actual behavior _No response_ ### How to Reproduce? using quarkus 2.9.0 cli ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` _No response_ ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev _No response_ ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) _No response_ ### Additional information _No response_

6df44678d6c64b01c5d5b827672fc27803b29fd2

70c00e9ffd6b688c2139ab8f79ab1bc64bda13d1

https://github.com/quarkusio/quarkus/compare/6df44678d6c64b01c5d5b827672fc27803b29fd2...70c00e9ffd6b688c2139ab8f79ab1bc64bda13d1

diff --git a/independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/commands/handlers/AddExtensionsCommandHandler.java b/independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/commands/handlers/AddExtensionsCommandHandler.java index 179e5c30221..c40a36d03b1 100644 --- a/independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/commands/handlers/AddExtensionsCommandHandler.java +++ b/independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/commands/handlers/AddExtensionsCommandHandler.java @@ -103,17 +103,26 @@ public ExtensionInstallPlan planInstallation(QuarkusCommandInvocation invocation ExtensionInstallPlan.Builder builder = ExtensionInstallPlan.builder(); for (String keyword : keywords) { int countColons = StringUtils.countMatches(keyword, ":"); - // Check if it's just groupId:artifactId - if (countColons == 1) { - ArtifactKey artifactKey = ArtifactKey.fromString(keyword); - builder.addManagedExtension(new ArtifactCoords(artifactKey, null)); - continue; - } else if (countColons > 1) { + if (countColons > 1) { // it's a gav builder.addIndependentExtension(ArtifactCoords.fromString(keyword)); continue; } - List<Extension> listed = listInternalExtensions(quarkusCore, keyword, catalog.getExtensions()); + List<Extension> listed = List.of(); + // Check if it's just groupId:artifactId + if (countColons == 1) { + ArtifactKey artifactKey = ArtifactKey.fromString(keyword); + for (Extension e : invocation.getExtensionsCatalog().getExtensions()) { + if (e.getArtifact().getKey().equals(artifactKey)) { + listed = List.of(e); + break; + } + } + + //builder.addManagedExtension(new ArtifactCoords(artifactKey, null)); + } else { + listed = listInternalExtensions(quarkusCore, keyword, catalog.getExtensions()); + } if (listed.isEmpty()) { // No extension found for this keyword. builder.addUnmatchedKeyword(keyword); @@ -125,7 +134,6 @@ else if (listed.size() > 1 && !ExtensionPredicate.isPattern(keyword)) { } for (Extension e : listed) { final ArtifactCoords extensionCoords = e.getArtifact(); - boolean managed = false; ExtensionOrigin firstPlatform = null; ExtensionOrigin preferredOrigin = null; diff --git a/independent-projects/tools/devtools-testing/src/test/java/io/quarkus/devtools/project/create/ExtensionsAppearingInPlatformAndNonPlatformCatalogsTest.java b/independent-projects/tools/devtools-testing/src/test/java/io/quarkus/devtools/project/create/ExtensionsAppearingInPlatformAndNonPlatformCatalogsTest.java index 8ac8580def2..ea848b69967 100644 --- a/independent-projects/tools/devtools-testing/src/test/java/io/quarkus/devtools/project/create/ExtensionsAppearingInPlatformAndNonPlatformCatalogsTest.java +++ b/independent-projects/tools/devtools-testing/src/test/java/io/quarkus/devtools/project/create/ExtensionsAppearingInPlatformAndNonPlatformCatalogsTest.java @@ -203,6 +203,20 @@ public void addExtensionAndImportMemberBom() throws Exception { assertModel(projectDir, toPlatformBomCoords("acme-baz-bom"), expectedExtensions, "1.0.1"); } + @Test + public void addNonPlatformExtensionWithGA() throws Exception { + final Path projectDir = newProjectDir("add-non-platform-extension-with-ga"); + createProject(projectDir, Arrays.asList("acme-foo")); + + assertModel(projectDir, toPlatformBomCoords("acme-foo-bom"), toPlatformExtensionCoords("acme-foo"), "2.0.4"); + + addExtensions(projectDir, Arrays.asList("org.other:other-six-zero")); + + final List<ArtifactCoords> expectedExtensions = toPlatformExtensionCoords("acme-foo"); + expectedExtensions.add(ArtifactCoords.fromString("org.other:other-six-zero:6.0")); + assertModel(projectDir, toPlatformBomCoords("acme-foo-bom"), expectedExtensions, "2.0.4"); + } + @Test public void attemptCreateWithIncompatibleExtensions() throws Exception { final Path projectDir = newProjectDir("create-with-incompatible-extensions");

['independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/commands/handlers/AddExtensionsCommandHandler.java', 'independent-projects/tools/devtools-testing/src/test/java/io/quarkus/devtools/project/create/ExtensionsAppearingInPlatformAndNonPlatformCatalogsTest.java']

{'.java': 2}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25888/25884

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25884

https://github.com/quarkusio/quarkus/pull/25888

https://github.com/quarkusio/quarkus/pull/25888

fixes

Media type `text/xml` not working with REST Client Reactive

### Describe the bug I tried updating our project to use the REST Client Reactive from RESTEasy Reactive, however I can't get it to work with one of our REST Clients that uses `text/xml`. It does work fine for others that use JSON for example. ### Expected behavior The XML in the body of the response gets successfully processed with both media type `text/xml` and `application/xml`. ### Actual behavior The REST client fails with an exception when using `text/xml` ``` javax.ws.rs.ProcessingException: Response could not be mapped to type class org.acme.SimpleJaxbTest$Dto at org.jboss.resteasy.reactive.client.impl.ClientReaderInterceptorContextImpl.proceed(ClientReaderInterceptorContextImpl.java:62) at org.jboss.resteasy.reactive.client.impl.ClientSerialisers.invokeClientReader(ClientSerialisers.java:146) at org.jboss.resteasy.reactive.client.impl.RestClientRequestContext.readEntity(RestClientRequestContext.java:182) at org.jboss.resteasy.reactive.client.handlers.ClientResponseCompleteRestHandler.mapToResponse(ClientResponseCompleteRestHandler.java:101) at org.jboss.resteasy.reactive.client.handlers.ClientResponseCompleteRestHandler.handle(ClientResponseCompleteRestHandler.java:32) at org.jboss.resteasy.reactive.client.handlers.ClientResponseCompleteRestHandler.handle(ClientResponseCompleteRestHandler.java:28) at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.invokeHandler(AbstractResteasyReactiveContext.java:219) at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.run(AbstractResteasyReactiveContext.java:141) at org.jboss.resteasy.reactive.client.impl.RestClientRequestContext$1.lambda$execute$0(RestClientRequestContext.java:276) at io.vertx.core.impl.AbstractContext.dispatch(AbstractContext.java:100) at io.vertx.core.impl.AbstractContext.dispatch(AbstractContext.java:63) at io.vertx.core.impl.EventLoopContext.lambda$runOnContext$0(EventLoopContext.java:38) at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164) at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:469) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:500) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:833) ``` It does work fine when you create an endpoint that uses `application/xml` or when you switch back to the REST Client from RESTEasy Classic with JAXB. ### How to Reproduce? Based on the tests I found here: https://github.com/quarkusio/quarkus/blob/main/extensions/resteasy-reactive/rest-client-reactive-jaxb/deployment/src/test/java/io/quarkus/rest/client/reactive/jaxb/test/SimpleJaxbTest.java I made a small reproducer: ```java package org.acme; import io.quarkus.test.common.http.TestHTTPResource; import io.quarkus.test.junit.QuarkusTest; import org.eclipse.microprofile.rest.client.RestClientBuilder; import org.junit.jupiter.api.Test; import javax.ws.rs.GET; import javax.ws.rs.Path; import javax.ws.rs.Produces; import javax.ws.rs.core.MediaType; import javax.xml.bind.annotation.XmlRootElement; import java.net.URI; import java.util.Objects; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.equalTo; @QuarkusTest public class SimpleJaxbTest { @TestHTTPResource URI uri; @Test void shouldConsumeXMLEntity() { var dto = RestClientBuilder.newBuilder().baseUri(uri).build(XmlClient.class).dto(); assertThat(dto, equalTo(new Dto("foo", "bar"))); } @Path("/xml") public interface XmlClient { @GET @Path("/dto") @Produces(MediaType.TEXT_XML) Dto dto(); } @Path("/xml") public static class XmlResource { @GET @Produces(MediaType.TEXT_XML) @Path("/dto") public Dto dto() { return new Dto("foo", "bar"); } } @XmlRootElement(name = "Dto") public static class Dto { public String name; public String value; public Dto(String name, String value) { this.name = name; this.value = value; } public Dto() { } @Override public boolean equals(Object o) { if (this == o) return true; if (o == null || getClass() != o.getClass()) return false; Dto dto = (Dto) o; return Objects.equals(name, dto.name) && Objects.equals(value, dto.value); } @Override public int hashCode() { return Objects.hash(name, value); } } } ``` Extensions used: ```xml <dependency> <groupId>io.quarkus</groupId> <artifactId>quarkus-rest-client-reactive-jaxb</artifactId> </dependency> <dependency> <groupId>io.quarkus</groupId> <artifactId>quarkus-resteasy-reactive-jaxb</artifactId> </dependency> ``` Reproducer: [Archive.zip](https://github.com/quarkusio/quarkus/files/8805564/Archive.zip) ### Output of `uname -a` or `ver` ``` Darwin Willems-MBP.i.btp34.nl 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22 PDT 2022; root:xnu-8020.121.3~4/RELEASE_X86_64 x86_64 ``` ### Output of `java -version` ``` openjdk version "17.0.3" 2022-04-19 OpenJDK Runtime Environment Temurin-17.0.3+7 (build 17.0.3+7) OpenJDK 64-Bit Server VM Temurin-17.0.3+7 (build 17.0.3+7, mixed mode, sharing) ``` ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev `2.9.2.Final` ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) ``` Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) Maven home: /Users/wjglerum/.m2/wrapper/dists/apache-maven-3.8.4-bin/52ccbt68d252mdldqsfsn03jlf/apache-maven-3.8.4 Java version: 17.0.3, vendor: Eclipse Adoptium, runtime: /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home Default locale: en_NL, platform encoding: US-ASCII OS name: "mac os x", version: "12.4", arch: "x86_64", family: "mac" ``` ### Additional information Did I miss any documentation here? Or is there something else needed to make this work?

c564a99a88c71d5b43feac708416705bfff9cf57

d3b36235103675439d385f4973bb94165fc5f296

https://github.com/quarkusio/quarkus/compare/c564a99a88c71d5b43feac708416705bfff9cf57...d3b36235103675439d385f4973bb94165fc5f296

diff --git a/extensions/hibernate-validator/runtime/src/main/java/io/quarkus/hibernate/validator/runtime/jaxrs/ValidatorMediaTypeUtil.java b/extensions/hibernate-validator/runtime/src/main/java/io/quarkus/hibernate/validator/runtime/jaxrs/ValidatorMediaTypeUtil.java index 63b90e93270..8eeede84b21 100644 --- a/extensions/hibernate-validator/runtime/src/main/java/io/quarkus/hibernate/validator/runtime/jaxrs/ValidatorMediaTypeUtil.java +++ b/extensions/hibernate-validator/runtime/src/main/java/io/quarkus/hibernate/validator/runtime/jaxrs/ValidatorMediaTypeUtil.java @@ -10,8 +10,10 @@ */ public final class ValidatorMediaTypeUtil { - private static final List<MediaType> SUPPORTED_MEDIA_TYPES = Arrays.asList(MediaType.APPLICATION_JSON_TYPE, + private static final List<MediaType> SUPPORTED_MEDIA_TYPES = Arrays.asList( + MediaType.APPLICATION_JSON_TYPE, MediaType.APPLICATION_XML_TYPE, + MediaType.TEXT_XML_TYPE, MediaType.TEXT_PLAIN_TYPE); private ValidatorMediaTypeUtil() { diff --git a/extensions/resteasy-reactive/quarkus-resteasy-reactive-jaxb-common/deployment/src/main/java/io/quarkus/resteasy/reactive/jaxb/common/deployment/ResteasyReactiveJaxbCommonProcessor.java b/extensions/resteasy-reactive/quarkus-resteasy-reactive-jaxb-common/deployment/src/main/java/io/quarkus/resteasy/reactive/jaxb/common/deployment/ResteasyReactiveJaxbCommonProcessor.java index 4d9d1311fb9..1f73e94c562 100644 --- a/extensions/resteasy-reactive/quarkus-resteasy-reactive-jaxb-common/deployment/src/main/java/io/quarkus/resteasy/reactive/jaxb/common/deployment/ResteasyReactiveJaxbCommonProcessor.java +++ b/extensions/resteasy-reactive/quarkus-resteasy-reactive-jaxb-common/deployment/src/main/java/io/quarkus/resteasy/reactive/jaxb/common/deployment/ResteasyReactiveJaxbCommonProcessor.java @@ -1,6 +1,6 @@ package io.quarkus.resteasy.reactive.jaxb.common.deployment; -import java.util.Collections; +import java.util.List; import javax.ws.rs.core.MediaType; @@ -25,8 +25,8 @@ void additionalProviders(BuildProducer<AdditionalBeanBuildItem> additionalBean, .setUnremovable().build()); additionalReaders.produce(new MessageBodyReaderBuildItem(JaxbMessageBodyReader.class.getName(), Object.class.getName(), - Collections.singletonList(MediaType.APPLICATION_XML))); + List.of(MediaType.APPLICATION_XML, MediaType.TEXT_XML))); additionalWriters.produce(new MessageBodyWriterBuildItem(JaxbMessageBodyWriter.class.getName(), Object.class.getName(), - Collections.singletonList(MediaType.APPLICATION_XML))); + List.of(MediaType.APPLICATION_XML, MediaType.TEXT_XML))); } } diff --git a/extensions/resteasy-reactive/quarkus-resteasy-reactive-jaxb-common/runtime/src/main/java/io/quarkus/resteasy/reactive/jaxb/common/runtime/serialisers/JaxbMessageBodyReader.java b/extensions/resteasy-reactive/quarkus-resteasy-reactive-jaxb-common/runtime/src/main/java/io/quarkus/resteasy/reactive/jaxb/common/runtime/serialisers/JaxbMessageBodyReader.java index cfcf2102893..f78d995fb46 100644 --- a/extensions/resteasy-reactive/quarkus-resteasy-reactive-jaxb-common/runtime/src/main/java/io/quarkus/resteasy/reactive/jaxb/common/runtime/serialisers/JaxbMessageBodyReader.java +++ b/extensions/resteasy-reactive/quarkus-resteasy-reactive-jaxb-common/runtime/src/main/java/io/quarkus/resteasy/reactive/jaxb/common/runtime/serialisers/JaxbMessageBodyReader.java @@ -47,9 +47,9 @@ protected boolean isReadable(MediaType mediaType, Class<?> type) { return false; } String subtype = mediaType.getSubtype(); - boolean isApplicationMediaType = "application".equals(mediaType.getType()); - return (isApplicationMediaType && "xml".equalsIgnoreCase(subtype) || subtype.endsWith("+xml")) - || (mediaType.isWildcardSubtype() && (mediaType.isWildcardType() || isApplicationMediaType)); + boolean isCorrectMediaType = "application".equals(mediaType.getType()) || "text".equals(mediaType.getType()); + return (isCorrectMediaType && "xml".equalsIgnoreCase(subtype) || subtype.endsWith("+xml")) + || (mediaType.isWildcardSubtype() && (mediaType.isWildcardType() || isCorrectMediaType)); } private Object doReadFrom(Class<Object> type, Type genericType, InputStream entityStream) throws IOException { diff --git a/extensions/resteasy-reactive/rest-client-reactive-jaxb/deployment/src/test/java/io/quarkus/rest/client/reactive/jaxb/test/SimpleJaxbTest.java b/extensions/resteasy-reactive/rest-client-reactive-jaxb/deployment/src/test/java/io/quarkus/rest/client/reactive/jaxb/test/SimpleJaxbTest.java index 54bd22dd372..5f1b32e2a05 100644 --- a/extensions/resteasy-reactive/rest-client-reactive-jaxb/deployment/src/test/java/io/quarkus/rest/client/reactive/jaxb/test/SimpleJaxbTest.java +++ b/extensions/resteasy-reactive/rest-client-reactive-jaxb/deployment/src/test/java/io/quarkus/rest/client/reactive/jaxb/test/SimpleJaxbTest.java @@ -9,6 +9,7 @@ import javax.ws.rs.Path; import javax.ws.rs.Produces; import javax.ws.rs.core.MediaType; +import javax.xml.bind.annotation.XmlRootElement; import org.eclipse.microprofile.rest.client.RestClientBuilder; import org.junit.jupiter.api.Test; @@ -26,12 +27,19 @@ public class SimpleJaxbTest { URI uri; @Test - void shouldConsumeJsonEntity() { + void shouldConsumeXMLEntity() { var dto = RestClientBuilder.newBuilder().baseUri(uri).build(XmlClient.class) .dto(); assertThat(dto).isEqualTo(new Dto("foo", "bar")); } + @Test + void shouldConsumePlainXMLEntity() { + var dto = RestClientBuilder.newBuilder().baseUri(uri).build(XmlClient.class) + .plain(); + assertThat(dto).isEqualTo(new Dto("foo", "bar")); + } + @Path("/xml") public interface XmlClient { @@ -39,6 +47,11 @@ public interface XmlClient { @Path("/dto") @Produces(MediaType.APPLICATION_XML) Dto dto(); + + @GET + @Path("/plain") + @Produces(MediaType.TEXT_XML) + Dto plain(); } @Path("/xml") @@ -50,8 +63,16 @@ public static class XmlResource { public Dto dto() { return new Dto("foo", "bar"); } + + @GET + @Produces(MediaType.TEXT_XML) + @Path("/plain") + public Dto plain() { + return new Dto("foo", "bar"); + } } + @XmlRootElement(name = "Dto") public static class Dto { public String name; public String value;

['extensions/resteasy-reactive/quarkus-resteasy-reactive-jaxb-common/deployment/src/main/java/io/quarkus/resteasy/reactive/jaxb/common/deployment/ResteasyReactiveJaxbCommonProcessor.java', 'extensions/resteasy-reactive/rest-client-reactive-jaxb/deployment/src/test/java/io/quarkus/rest/client/reactive/jaxb/test/SimpleJaxbTest.java', 'extensions/resteasy-reactive/quarkus-resteasy-reactive-jaxb-common/runtime/src/main/java/io/quarkus/resteasy/reactive/jaxb/common/runtime/serialisers/JaxbMessageBodyReader.java', 'extensions/hibernate-validator/runtime/src/main/java/io/quarkus/hibernate/validator/runtime/jaxrs/ValidatorMediaTypeUtil.java']

{'.java': 4}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25896/25894

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25894

https://github.com/quarkusio/quarkus/pull/25896

https://github.com/quarkusio/quarkus/pull/25896

fix

Panache MongoDB extension not working for multiple collections inside same transaction

### Describe the bug When a method annotated with @Transactional doing multiple updates or persists using different repositories, only first is using client session others are direct commit. ### Expected behavior Should commit all changes after leave transaction method, not in middle of method ### Actual behavior Only work for first repository, others are not using same client session. ### How to Reproduce? 1- Create 2 repositories for different entities. 2- Create a Transactional method 3- Persist both entities 4 - Check result after first persist (not persisted) 5- Check result after second persist been executed (persisted) ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` 11 ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.9 ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) _No response_ ### Additional information _No response_

ba1107fe72237da1e16822afcf2dfb0cbf0c86e8

b42aeb4ead534f0b97e1a523e303c28911fd1394

https://github.com/quarkusio/quarkus/compare/ba1107fe72237da1e16822afcf2dfb0cbf0c86e8...b42aeb4ead534f0b97e1a523e303c28911fd1394

diff --git a/extensions/panache/mongodb-panache-common/runtime/src/main/java/io/quarkus/mongodb/panache/common/runtime/MongoOperations.java b/extensions/panache/mongodb-panache-common/runtime/src/main/java/io/quarkus/mongodb/panache/common/runtime/MongoOperations.java index ba8f60efe70..d6f446e8844 100644 --- a/extensions/panache/mongodb-panache-common/runtime/src/main/java/io/quarkus/mongodb/panache/common/runtime/MongoOperations.java +++ b/extensions/panache/mongodb-panache-common/runtime/src/main/java/io/quarkus/mongodb/panache/common/runtime/MongoOperations.java @@ -321,19 +321,20 @@ ClientSession getSession(Object entity) { } ClientSession getSession(Class<?> entityClass) { + ClientSession clientSession = null; MongoEntity mongoEntity = entityClass.getAnnotation(MongoEntity.class); InstanceHandle<TransactionSynchronizationRegistry> instance = Arc.container() .instance(TransactionSynchronizationRegistry.class); if (instance.isAvailable()) { TransactionSynchronizationRegistry registry = instance.get(); if (registry.getTransactionStatus() == Status.STATUS_ACTIVE) { - ClientSession clientSession = (ClientSession) registry.getResource(SESSION_KEY); + clientSession = (ClientSession) registry.getResource(SESSION_KEY); if (clientSession == null) { return registerClientSession(mongoEntity, registry); } } } - return null; + return clientSession; } private ClientSession registerClientSession(MongoEntity mongoEntity,

['extensions/panache/mongodb-panache-common/runtime/src/main/java/io/quarkus/mongodb/panache/common/runtime/MongoOperations.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25910/25909

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25909

https://github.com/quarkusio/quarkus/pull/25910

https://github.com/quarkusio/quarkus/pull/25910

fixes

Misleading error for multipart non-blocking method in resteasy-reactive

### Describe the bug Current implementation requires, that endpoint, which returns multipart, should be *blocking*. User is notified about it via build-time error, which says `Endpoints that produce a Multipart result can only be used on non blocking methods`. ### Expected behavior Error message should describe behavior properly. ### Actual behavior If endpoint annotated with both `@Produces(MediaType.MULTIPART_FORM_DATA)` and `@NonBlocking`, build fails with `Endpoints that produce a Multipart result can only be used on non blocking methods` error. ### How to Reproduce? Add two endpoints to class: ```java @GET @Produces(MediaType.MULTIPART_FORM_DATA) @Path("/download-multipart") @Blocking //this will compile public Uni<FileWrapper> downloadMultipartBlocking() { FileWrapper wrapper = new FileWrapper(); wrapper.file = file; wrapper.name = file.getName(); return Uni.createFrom().item(() -> wrapper); } ``` and ```java @GET @Produces(MediaType.MULTIPART_FORM_DATA) @Path("/download-multipart") @NonBlocking //this will not public Uni<FileWrapper> downloadMultipartNonBlocking() { FileWrapper wrapper = new FileWrapper(); wrapper.file = file; wrapper.name = file.getName(); return Uni.createFrom().item(() -> wrapper); } ``` Build fails with the following error: ``` [ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:2.7.6.Final:build (build) on project http-rest-client-reactive: Failed to build quarkus application: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [ERROR] [error]: Build step io.quarkus.resteasy.reactive.server.deployment.ResteasyReactiveProcessor#setupEndpoints threw an exception: java.lang.RuntimeException: java.lang.RuntimeException: Failed to process method 'io.quarkus.ts.http.restclient.reactive.files.FileResource#downloadMultipartNonBlocking' [ERROR] at org.jboss.resteasy.reactive.common.processor.EndpointIndexer.createEndpoints(EndpointIndexer.java:294) <...> [ERROR] at org.jboss.threads.JBossThread.run(JBossThread.java:501) [ERROR] Caused by: java.lang.RuntimeException: Failed to process method 'io.quarkus.ts.http.restclient.reactive.files.FileResource#downloadMultipartNonBlocking' [ERROR] at org.jboss.resteasy.reactive.common.processor.EndpointIndexer.createResourceMethod(EndpointIndexer.java:666) [ERROR] at org.jboss.resteasy.reactive.common.processor.EndpointIndexer.createEndpoints(EndpointIndexer.java:382) [ERROR] at org.jboss.resteasy.reactive.common.processor.EndpointIndexer.createEndpoints(EndpointIndexer.java:265) [ERROR] ... 12 more [ERROR] Caused by: javax.enterprise.inject.spi.DeploymentException: Endpoints that produce a Multipart result can only be used on non blocking methods. Offending method is 'io.quarkus.ts.http.restclient.reactive.files.FileResource#io.smallrye.mutiny.Uni<io.quarkus.ts.http.restclient.reactive.files.FileWrapper> downloadMultipartNonBlocking()' [ERROR] at org.jboss.resteasy.reactive.common.processor.EndpointIndexer.createResourceMethod(EndpointIndexer.java:630) [ERROR] ... 14 more [ERROR] -> [Help 1] ``` ### Output of `uname -a` or `ver` 5.17.11-300.fc36.x86_64 ### Output of `java -version` 11.0.12, vendor: GraalVM Community ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.7.6.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) ### Additional information _No response_

cf1864cc212668116e56c47949635254e60915e4

febcd16b095c81f2885ea8d37282e924b222420b

https://github.com/quarkusio/quarkus/compare/cf1864cc212668116e56c47949635254e60915e4...febcd16b095c81f2885ea8d37282e924b222420b

diff --git a/independent-projects/resteasy-reactive/common/processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java b/independent-projects/resteasy-reactive/common/processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java index caa4e997d08..739fb79bb11 100644 --- a/independent-projects/resteasy-reactive/common/processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java +++ b/independent-projects/resteasy-reactive/common/processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java @@ -645,7 +645,7 @@ private ResourceMethod createResourceMethod(ClassInfo currentClassInfo, ClassInf if (returnsMultipart && !blocking) { throw new DeploymentException( - "Endpoints that produce a Multipart result can only be used on non blocking methods. Offending method is '" + "Endpoints that produce a Multipart result can only be used on blocking methods. Offending method is '" + currentMethodInfo.declaringClass().name() + "#" + currentMethodInfo + "'"); }

['independent-projects/resteasy-reactive/common/processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25913/25751

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25751

https://github.com/quarkusio/quarkus/pull/25913

https://github.com/quarkusio/quarkus/pull/25913

fixes

io.quarkus.qute.deployment.QuteProcessor#collectTemplates threw exception

### Describe the bug Sometimes I'm getting this issue when launching tests in Eclipse IDE. I can't reproduce when running tests from Maven. ``` java.lang.RuntimeException: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.qute.deployment.QuteProcessor#collectTemplates threw an exception: java.lang.IllegalArgumentException at jdk.zipfs/jdk.nio.zipfs.ZipPath.relativize(ZipPath.java:230) at io.quarkus.qute.deployment.QuteProcessor.scan(QuteProcessor.java:2301) at io.quarkus.qute.deployment.QuteProcessor.scan(QuteProcessor.java:2313) at io.quarkus.qute.deployment.QuteProcessor.collectTemplates(QuteProcessor.java:1291) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:925) at io.quarkus.builder.BuildContext.run(BuildContext.java:277) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:834) at org.jboss.threads.JBossThread.run(JBossThread.java:501) at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:632) at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:703) at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105) at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106) at org.junit.jupiter.api.extension.InvocationInterceptor.interceptTestClassConstructor(InvocationInterceptor.java:73) at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105) at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106) at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64) at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45) at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37) at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104) at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:77) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeTestClassConstructor(ClassBasedTestDescriptor.java:355) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.instantiateTestClass(ClassBasedTestDescriptor.java:302) at org.junit.jupiter.engine.descriptor.ClassTestDescriptor.instantiateTestClass(ClassTestDescriptor.java:79) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.instantiateAndPostProcessTestInstance(ClassBasedTestDescriptor.java:280) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$testInstancesProvider$4(ClassBasedTestDescriptor.java:272) at java.base/java.util.Optional.orElseGet(Optional.java:369) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$testInstancesProvider$5(ClassBasedTestDescriptor.java:271) at org.junit.jupiter.engine.execution.TestInstancesProvider.getTestInstances(TestInstancesProvider.java:31) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$prepare$0(TestMethodTestDescriptor.java:102) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.prepare(TestMethodTestDescriptor.java:101) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.prepare(TestMethodTestDescriptor.java:66) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$prepare$2(NodeTestTask.java:123) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.prepare(NodeTestTask.java:123) at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:90) at java.base/java.util.ArrayList.forEach(ArrayList.java:1540) at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138) at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95) at java.base/java.util.ArrayList.forEach(ArrayList.java:1540) at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138) at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95) at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35) at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57) at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52) at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114) at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:95) at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:91) at org.junit.platform.launcher.core.SessionPerRequestLauncher.execute(SessionPerRequestLauncher.java:60) at org.eclipse.jdt.internal.junit5.runner.JUnit5TestReference.run(JUnit5TestReference.java:98) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:40) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:529) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:756) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:452) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:210) Caused by: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.qute.deployment.QuteProcessor#collectTemplates threw an exception: java.lang.IllegalArgumentException at jdk.zipfs/jdk.nio.zipfs.ZipPath.relativize(ZipPath.java:230) at io.quarkus.qute.deployment.QuteProcessor.scan(QuteProcessor.java:2301) at io.quarkus.qute.deployment.QuteProcessor.scan(QuteProcessor.java:2313) at io.quarkus.qute.deployment.QuteProcessor.collectTemplates(QuteProcessor.java:1291) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:925) at io.quarkus.builder.BuildContext.run(BuildContext.java:277) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:834) at org.jboss.threads.JBossThread.run(JBossThread.java:501) at io.quarkus.runner.bootstrap.AugmentActionImpl.runAugment(AugmentActionImpl.java:330) at io.quarkus.runner.bootstrap.AugmentActionImpl.createInitialRuntimeApplication(AugmentActionImpl.java:252) at io.quarkus.runner.bootstrap.AugmentActionImpl.createInitialRuntimeApplication(AugmentActionImpl.java:60) at io.quarkus.test.junit.QuarkusTestExtension.doJavaStart(QuarkusTestExtension.java:225) at io.quarkus.test.junit.QuarkusTestExtension.ensureStarted(QuarkusTestExtension.java:609) at io.quarkus.test.junit.QuarkusTestExtension.beforeAll(QuarkusTestExtension.java:647) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$10(ClassBasedTestDescriptor.java:381) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeBeforeAllCallbacks(ClassBasedTestDescriptor.java:381) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.before(ClassBasedTestDescriptor.java:205) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.before(ClassBasedTestDescriptor.java:80) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:148) ... 35 more Caused by: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.qute.deployment.QuteProcessor#collectTemplates threw an exception: java.lang.IllegalArgumentException at jdk.zipfs/jdk.nio.zipfs.ZipPath.relativize(ZipPath.java:230) at io.quarkus.qute.deployment.QuteProcessor.scan(QuteProcessor.java:2301) at io.quarkus.qute.deployment.QuteProcessor.scan(QuteProcessor.java:2313) at io.quarkus.qute.deployment.QuteProcessor.collectTemplates(QuteProcessor.java:1291) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:925) at io.quarkus.builder.BuildContext.run(BuildContext.java:277) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:834) at org.jboss.threads.JBossThread.run(JBossThread.java:501) at io.quarkus.builder.Execution.run(Execution.java:116) at io.quarkus.builder.BuildExecutionBuilder.execute(BuildExecutionBuilder.java:79) at io.quarkus.deployment.QuarkusAugmentor.run(QuarkusAugmentor.java:157) at io.quarkus.runner.bootstrap.AugmentActionImpl.runAugment(AugmentActionImpl.java:328) ... 46 more Caused by: java.lang.IllegalArgumentException at jdk.zipfs/jdk.nio.zipfs.ZipPath.relativize(ZipPath.java:230) at io.quarkus.qute.deployment.QuteProcessor.scan(QuteProcessor.java:2301) at io.quarkus.qute.deployment.QuteProcessor.scan(QuteProcessor.java:2313) at io.quarkus.qute.deployment.QuteProcessor.collectTemplates(QuteProcessor.java:1291) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:925) at io.quarkus.builder.BuildContext.run(BuildContext.java:277) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:834) at org.jboss.threads.JBossThread.run(JBossThread.java:501) ``` I'll attach a debugger to figure it out. ### Expected behavior _No response_ ### Actual behavior _No response_ ### How to Reproduce? _No response_ ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` _No response_ ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev _No response_ ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) _No response_ ### Additional information _No response_

3ff5a163633af6fc076f7ddf700a3c7c285f7b44

7765433c9269b43ae709760888ab8141b9a649e3

https://github.com/quarkusio/quarkus/compare/3ff5a163633af6fc076f7ddf700a3c7c285f7b44...7765433c9269b43ae709760888ab8141b9a649e3

diff --git a/extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/QuteProcessor.java b/extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/QuteProcessor.java index b330cc40c94..ce114af8a5e 100644 --- a/extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/QuteProcessor.java +++ b/extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/QuteProcessor.java @@ -2492,6 +2492,16 @@ private void scan(Path root, Path directory, String basePath, BuildProducer<HotD Iterator<Path> iter = files.iterator(); while (iter.hasNext()) { Path filePath = iter.next(); + /* + * Fix for https://github.com/quarkusio/quarkus/issues/25751 where running tests in Eclipse + * sometimes produces `/templates/tags` (absolute) files listed for `templates` (relative) + * directories, so we work around this + */ + if (!directory.isAbsolute() + && filePath.isAbsolute() + && filePath.getRoot() != null) { + filePath = filePath.getRoot().relativize(filePath); + } if (Files.isRegularFile(filePath)) { LOGGER.debugf("Found template: %s", filePath); String templatePath = root.relativize(filePath).toString();

['extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/QuteProcessor.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/26132/26083

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/26083

https://github.com/quarkusio/quarkus/pull/26132

https://github.com/quarkusio/quarkus/pull/26132

fix

`java.lang.NoSuchMethodException: io.grpc.netty.UdsNettyChannelProvider.<init>()` on Quarkus main after grpc update

### Describe the bug `java.lang.NoSuchMethodException: io.grpc.netty.UdsNettyChannelProvider.<init>()` on Quarkus main after grpc update Did some bisection locally and the PR where the troubles start is https://github.com/quarkusio/quarkus/pull/26047 CC @cescoffier ``` Jun 13, 2022 12:22:43 PM io.quarkus.runtime.ApplicationLifecycleManager run ERROR: Failed to start application (with profile test) java.lang.NoSuchMethodException: io.grpc.netty.UdsNettyChannelProvider.<init>() at java.lang.Class.getConstructor0(DynamicHub.java:3585) at java.lang.Class.getConstructor(DynamicHub.java:2271) at io.grpc.ServiceProviders.createForHardCoded(ServiceProviders.java:136) at io.grpc.ServiceProviders.getCandidatesViaHardCoded(ServiceProviders.java:125) at io.grpc.InternalServiceProviders.getCandidatesViaHardCoded(InternalServiceProviders.java:63) at io.grpc.ServiceProviders.loadAll(ServiceProviders.java:28) at io.grpc.ManagedChannelRegistry.getDefaultRegistry(ManagedChannelRegistry.java:101) at io.grpc.ManagedChannelProvider.provider(ManagedChannelProvider.java:43) at io.grpc.ManagedChannelBuilder.forTarget(ManagedChannelBuilder.java:76) at io.opentelemetry.exporter.internal.grpc.DefaultGrpcExporterBuilder.build(DefaultGrpcExporterBuilder.java:134) at io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporterBuilder.build(JaegerGrpcSpanExporterBuilder.java:111) at io.quarkus.opentelemetry.exporter.jaeger.runtime.JaegerRecorder.installBatchSpanProcessorForJaeger(JaegerRecorder.java:29) at io.quarkus.deployment.steps.JaegerExporterProcessor$installBatchSpanProcessorForJaeger1237208624.deploy_0(Unknown Source) at io.quarkus.deployment.steps.JaegerExporterProcessor$installBatchSpanProcessorForJaeger1237208624.deploy(Unknown Source) at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source) at io.quarkus.runtime.Application.start(Application.java:101) at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:103) at io.quarkus.runtime.Quarkus.run(Quarkus.java:67) at io.quarkus.runtime.Quarkus.run(Quarkus.java:41) at io.quarkus.runtime.Quarkus.run(Quarkus.java:120) at io.quarkus.runner.GeneratedMain.main(Unknown Source) ``` ### Expected behavior Application starts ### Actual behavior Application start fails ### How to Reproduce? - build latest Quarkus main - clone https://github.com/quarkus-qe/beefy-scenarios - run `mvn clean verify -pl 300-quarkus-vertx-webClient -Dnative` ### Output of `uname -a` or `ver` macOS Monterey ### Output of `java -version` _No response_ ### GraalVM version (if different from Java) GraalVM 22.0 Java17 / GraalVM 22.1 Java17 / GraalVM 21.3 Java11 ### Quarkus version or git rev Quarkus main ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) _No response_ ### Additional information _No response_

e644ded521df7299514d233540db97476ba702c7

38ce61dbef4148157e8f1a5f1f7c11656f7f202f

https://github.com/quarkusio/quarkus/compare/e644ded521df7299514d233540db97476ba702c7...38ce61dbef4148157e8f1a5f1f7c11656f7f202f

diff --git a/extensions/grpc-common/runtime/src/main/java/io/quarkus/grpc/common/runtime/graal/GrpcSubstitutions.java b/extensions/grpc-common/runtime/src/main/java/io/quarkus/grpc/common/runtime/graal/GrpcSubstitutions.java index cc41a3a9ac4..349eb09e264 100644 --- a/extensions/grpc-common/runtime/src/main/java/io/quarkus/grpc/common/runtime/graal/GrpcSubstitutions.java +++ b/extensions/grpc-common/runtime/src/main/java/io/quarkus/grpc/common/runtime/graal/GrpcSubstitutions.java @@ -6,6 +6,7 @@ import java.util.Collections; import java.util.Comparator; import java.util.List; +import java.util.ServiceConfigurationError; import com.oracle.svm.core.annotate.Alias; import com.oracle.svm.core.annotate.Substitute; @@ -15,6 +16,23 @@ @TargetClass(className = "io.grpc.ServiceProviders") final class Target_io_grpc_ServiceProviders { // NOSONAR + @Substitute + static boolean isAndroid(ClassLoader cl) { + return false; + } + + @Substitute + private static <T> T createForHardCoded(Class<T> klass, Class<?> rawClass) { + try { + return rawClass.asSubclass(klass).getConstructor().newInstance(); + } catch (NoSuchMethodException | ClassCastException e) { + return null; + } catch (Throwable t) { + throw new ServiceConfigurationError( + String.format("Provider %s could not be instantiated %s", rawClass.getName(), t), t); + } + } + @Substitute public static <T> List<T> loadAll( Class<T> klass,

['extensions/grpc-common/runtime/src/main/java/io/quarkus/grpc/common/runtime/graal/GrpcSubstitutions.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/26357/25954

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25954

https://github.com/quarkusio/quarkus/pull/26357

https://github.com/quarkusio/quarkus/pull/26357

fixes

Image generation failed. Exit code: 255 in windows 10

### Describe the bug I can't do native build with graalvm I'm execute ./mvnw package -Pnative I try to compile native using jdbc and specifying the DB credentials in the properties file but I get an error, however this only happens when I add the dependencies ```xml <dependency> <groupId>io.quarkus</groupId> <artifactId>quarkus-hibernate-orm</artifactId> </dependency> <dependency> <groupId>io.quarkus</groupId> <artifactId>quarkus-jdbc-oracle</artifactId> </dependency> ``` If I try to make the native compilation without these dependencies I can execute it without any problem ### Expected behavior Run a native executable. ### Actual behavior I'm execute ./mvnw package -Pnative and my log return this error: ```bash C:\\Users\\andre\\IdeaProjects\\code-with-quarkus>mvnw package -Pnative [INFO] Scanning for projects... [INFO] [INFO] ---------------------< com.tmve:code-with-quarkus >--------------------- [INFO] Building code-with-quarkus 1.0.0-SNAPSHOT [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ code-with-quarkus --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] [INFO] --- quarkus-maven-plugin:2.9.2.Final:generate-code (default) @ code-with-quarkus --- [INFO] [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ code-with-quarkus --- [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] --- quarkus-maven-plugin:2.9.2.Final:generate-code-tests (default) @ code-with-quarkus --- [INFO] [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ code-with-quarkus --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory C:\\Users\\andre\\IdeaProjects\\code-with-quarkus\\src\\test\\resources [INFO] [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ code-with-quarkus --- [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ code-with-quarkus --- [INFO] [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running com.tmve.GreetingResourceTest 2022-06-03 10:15:06,888 INFO [org.jbo.threads] (main) JBoss Threads version 3.4.2.Final 2022-06-03 10:15:07,527 WARN [io.qua.hib.orm.dep.HibernateOrmProcessor] (build-34) Hibernate ORM is disabled because no JPA entities were found 2022-06-03 10:15:10,435 INFO [io.quarkus] (main) code-with-quarkus 1.0.0-SNAPSHOT on JVM (powered by Quarkus 2.9.2.Final) started in 4.712s. Listening on: http://localhost:8081 2022-06-03 10:15:10,435 INFO [io.quarkus] (main) Profile test activated. 2022-06-03 10:15:10,436 INFO [io.quarkus] (main) Installed features: [agroal, cdi, hibernate-orm, jdbc-oracle, narayana-jta, resteasy, resteasy-jackson, smallrye-context-propagation, vertx] [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.616 s - in com.tmve.GreetingResourceTest 2022-06-03 10:15:12,938 INFO [io.quarkus] (main) code-with-quarkus stopped in 0.056s [INFO] [INFO] Results: [INFO] [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ code-with-quarkus --- [INFO] [INFO] --- quarkus-maven-plugin:2.9.2.Final:build (default) @ code-with-quarkus --- [WARNING] [io.quarkus.deployment.steps.NativeImageAllowIncompleteClasspathAggregateStep] The following extensions have required native-image to allow run-time resolution of classes: {quarkus-jdbc-oracle}. This is a global requirement which might have unexpected effects on other extensions as well, and is a hint of the library needing some additional refactoring to better support GraalVM native-image. In the case of 3rd party dependencies and/or proprietary code there is not much we can do - please ask for support to your library vendor. If you incur in any problem with other Quarkus extensions, please try reproducing the problem without these extensions first. [WARNING] [io.quarkus.hibernate.orm.deployment.HibernateOrmProcessor] Hibernate ORM is disabled because no JPA entities were found [INFO] [org.hibernate.Version] HHH000412: Hibernate ORM core version 5.6.9.Final [WARNING] [io.quarkus.deployment.pkg.steps.JarResultBuildStep] Uber JAR strategy is used for native image source JAR generation on Windows. This is done for the time being to work around a current GraalVM limitation on Windows concerning the maximum command length (see https://github.com/oracle/graal/issues/2387). [INFO] [io.quarkus.deployment.pkg.steps.JarResultBuildStep] Building uber jar: C:\\Users\\andre\\IdeaProjects\\code-with-quarkus\\target\\code-with-quarkus-1.0.0-SNAPSHOT-native-image-source-jar\\code-with-quarkus-1.0.0-SNAPSHOT-runner.jar [INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] Building native image from C:\\Users\\andre\\IdeaProjects\\code-with-quarkus\\target\\code-with-quarkus-1.0.0-SNAPSHOT-native-image-source-jar\\code-with-quarkus-1.0.0-SNAPSHOT-runner.jar [INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] Running Quarkus native-image plugin on GraalVM 22.0.0.2 Java 17 CE (Java Version 17.0.2+8-jvmci-22.0-b05) [INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildRunner] C:\\Program Files (x86)\\graalvm-ce-java17-22.0.0.2\\bin\\native-image.cmd -J-DCoordinatorEnvironmentBean.transactionStatusManagerEnable=false -J-Djava.util.logging.manager=org.jboss.logmanager.LogManager -J-Dsun.nio.ch.maxUpdateArraySize=100 -J-Dvertx.logger-delegate-factory-class-name=io.quarkus.vertx.core.runtime.VertxLogDelegateFactory -J-Dvertx.disableDnsResolver=true -J-Dio.netty.leakDetection.level=DISABLED -J-Dio.netty.allocator.maxOrder=3 -J-Duser.language=en -J-Duser.country=US -J-Dfile.encoding=UTF-8 -H:-ParseOnce -J--add-exports=java.security.jgss/sun.security.krb5=ALL-UNNAMED -J--add-opens=java.base/java.text=ALL-UNNAMED -H:InitialCollectionPolicy=com.oracle.svm.core.genscavenge.CollectionPolicy\\$BySpaceAndTime -H:+JNI -H:+AllowFoldMethods -J-Djava.awt.headless=true -H:FallbackThreshold=0 --allow-incomplete-classpath -H:+ReportExceptionStackTraces -H:-AddAllCharsets -H:EnableURLProtocols=http,https -H:-UseServiceLoaderFeature -H:+StackTrace --exclude-config .*com\\.oracle\\.database\\.jdbc.* /META-INF/native-image/(?:native-image\\.properties|reflect-config\\.json) code-with-quarkus-1.0.0-SNAPSHOT-runner -jar code-with-quarkus-1.0.0-SNAPSHOT-runner.jar The system cannot find the path specified. [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 37.312 s [INFO] Finished at: 2022-06-03T10:15:29-04:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal io.quarkus.platform:quarkus-maven-plugin:2.9.2.Final:build (default) on project code-with-quarkus: Failed to build quarkus application: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [ERROR] [error]: Build step io.quarkus.deployment.pkg.steps.NativeImageBuildStep#build threw an exception: io.quarkus.deployment.pkg.steps.NativeImageBuildStep$ImageGenerationFailureException: Image generation failed. Exit code: 255[ERROR] at io.quarkus.deployment.pkg.steps.NativeImageBuildStep.imageGenerationFailed(NativeImageBuildStep.java:400) [ERROR] at io.quarkus.deployment.pkg.steps.NativeImageBuildStep.build(NativeImageBuildStep.java:240) [ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) [ERROR] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [ERROR] at java.base/java.lang.reflect.Method.invoke(Method.java:568) [ERROR] at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:925) [ERROR] at io.quarkus.builder.BuildContext.run(BuildContext.java:277) [ERROR] at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) [ERROR] at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) [ERROR] at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) [ERROR] at java.base/java.lang.Thread.run(Thread.java:833) [ERROR] at org.jboss.threads.JBossThread.run(JBossThread.java:501) [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException ``` ### How to Reproduce? adding the jdbc and hibernate dependencies and then running mvnw package -Pnative ### Output of `uname -a` or `ver` Windows 10 ### Output of `java -version` java version "11.0.13" 2021-10-19 LTS Java(TM) SE Runtime Environment 18.9 (build 11.0.13+10-LTS-370) Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.13+10-LTS-370, mixed mode) ### GraalVM version (if different from Java) GraalVM Updater 22.0.0.2 ### Quarkus version or git rev 2.9.1.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) Maven home: C:\\Users\\andre\\.m2\\wrapper\\dists\\apache-maven-3.8.4-bin\\52ccbt68d252mdldqsfsn03jlf\\apache-maven-3.8.4 Java version: 17.0.2, vendor: Oracle Corporation, runtime: C:\\Program Files\\Java\\jdk-17.0.2 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" ### Additional information The project used is the base one created from https://code.quarkus.io/

93a30172e0cdfae111bf85dbd4e1c109bc625e43

23f43c3d3be6f479f86f697888856a8c65d8136d

https://github.com/quarkusio/quarkus/compare/93a30172e0cdfae111bf85dbd4e1c109bc625e43...23f43c3d3be6f479f86f697888856a8c65d8136d

diff --git a/extensions/jdbc/jdbc-oracle/deployment/src/main/java/io/quarkus/jdbc/oracle/deployment/OracleMetadataOverrides.java b/extensions/jdbc/jdbc-oracle/deployment/src/main/java/io/quarkus/jdbc/oracle/deployment/OracleMetadataOverrides.java index 632df697aec..494d9ed1fec 100644 --- a/extensions/jdbc/jdbc-oracle/deployment/src/main/java/io/quarkus/jdbc/oracle/deployment/OracleMetadataOverrides.java +++ b/extensions/jdbc/jdbc-oracle/deployment/src/main/java/io/quarkus/jdbc/oracle/deployment/OracleMetadataOverrides.java @@ -35,7 +35,8 @@ public final class OracleMetadataOverrides { static final String DRIVER_JAR_MATCH_REGEX = ".*com\\\\.oracle\\\\.database\\\\.jdbc.*"; - static final String NATIVE_IMAGE_RESOURCE_MATCH_REGEX = "/META-INF/native-image/(?:native-image\\\\.properties|reflect-config\\\\.json)"; + static final String NATIVE_IMAGE_RESOURCE_MATCH_REGEX = "/META-INF/native-image/native-image\\\\.properties"; + static final String NATIVE_IMAGE_REFLECT_CONFIG_MATCH_REGEX = "/META-INF/native-image/reflect-config\\\\.json"; /** * Should match the contents of {@literal reflect-config.json} @@ -106,9 +107,13 @@ void runtimeInitializeDriver(BuildProducer<RuntimeInitializedClassBuildItem> run } @BuildStep - ExcludeConfigBuildItem excludeOracleDirectives() { - // Excludes both native-image.properties and reflect-config.json, which are reimplemented above - return new ExcludeConfigBuildItem(DRIVER_JAR_MATCH_REGEX, NATIVE_IMAGE_RESOURCE_MATCH_REGEX); + void excludeOracleDirectives(BuildProducer<ExcludeConfigBuildItem> nativeImageExclusions) { + // Excludes both native-image.properties and reflect-config.json, which are reimplemented above. + // N.B. this could be expressed by using a single regex to match both resources, + // but such a regex would include a ? char, which breaks arguments parsing on Windows. + nativeImageExclusions.produce(new ExcludeConfigBuildItem(DRIVER_JAR_MATCH_REGEX, NATIVE_IMAGE_RESOURCE_MATCH_REGEX)); + nativeImageExclusions + .produce(new ExcludeConfigBuildItem(DRIVER_JAR_MATCH_REGEX, NATIVE_IMAGE_REFLECT_CONFIG_MATCH_REGEX)); } @BuildStep diff --git a/extensions/jdbc/jdbc-oracle/deployment/src/test/java/io/quarkus/jdbc/oracle/deployment/RegexMatchTest.java b/extensions/jdbc/jdbc-oracle/deployment/src/test/java/io/quarkus/jdbc/oracle/deployment/RegexMatchTest.java index 5a66b4d51b2..8bef768890a 100644 --- a/extensions/jdbc/jdbc-oracle/deployment/src/test/java/io/quarkus/jdbc/oracle/deployment/RegexMatchTest.java +++ b/extensions/jdbc/jdbc-oracle/deployment/src/test/java/io/quarkus/jdbc/oracle/deployment/RegexMatchTest.java @@ -26,20 +26,33 @@ public void jarRegexIsMatching() { } @Test - public void resourceRegexIsMatching() { - //We need to exclude both of these: + public void nativeImageResourceRegexIsMatching() { + //We need to exclude this one: final String RES1 = "/META-INF/native-image/native-image.properties"; - final String RES2 = "/META-INF/native-image/reflect-config.json"; final Pattern pattern = Pattern.compile(OracleMetadataOverrides.NATIVE_IMAGE_RESOURCE_MATCH_REGEX); Assert.assertTrue(pattern.matcher(RES1).find()); - Assert.assertTrue(pattern.matcher(RES2).find()); - //While this one should NOT be ignored: - final String RES3 = "/META-INF/native-image/resource-config.json"; - final String RES4 = "/META-INF/native-image/jni-config.json"; + //While these should NOT be ignored: + final String RES2 = "/META-INF/native-image/resource-config.json"; + final String RES3 = "/META-INF/native-image/jni-config.json"; + Assert.assertFalse(pattern.matcher(RES2).find()); + Assert.assertFalse(pattern.matcher(RES3).find()); + } + + @Test + public void nativeImageReflectConfigRegexIsMatching() { + //We need to exclude this one: + final String RES1 = "/META-INF/native-image/reflect-config.json"; + final Pattern pattern = Pattern.compile(OracleMetadataOverrides.NATIVE_IMAGE_REFLECT_CONFIG_MATCH_REGEX); + + Assert.assertTrue(pattern.matcher(RES1).find()); + + //While these should NOT be ignored: + final String RES2 = "/META-INF/native-image/resource-config.json"; + final String RES3 = "/META-INF/native-image/jni-config.json"; + Assert.assertFalse(pattern.matcher(RES2).find()); Assert.assertFalse(pattern.matcher(RES3).find()); - Assert.assertFalse(pattern.matcher(RES4).find()); } }

['extensions/jdbc/jdbc-oracle/deployment/src/test/java/io/quarkus/jdbc/oracle/deployment/RegexMatchTest.java', 'extensions/jdbc/jdbc-oracle/deployment/src/main/java/io/quarkus/jdbc/oracle/deployment/OracleMetadataOverrides.java']

{'.java': 2}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/26358/26222

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/26222

https://github.com/quarkusio/quarkus/pull/26358

https://github.com/quarkusio/quarkus/pull/26358

fixes

gRPC Context propagation does not work

### Describe the bug We use OpenTelemetry with Quarkus version of 2.9.2 that already has a support for gRPC. We has a gRPC server that get a request with OpenTelemetry's context and the context isn't propagated to the service's handler. In addition, I used the `GrpcTracingServerInterceptor` interceptor and saw that the interceptor gets the context. I think the problem is that this interceptor close the scope `scope.close()` and doesn't pass any contextual data to the handler level. ### Expected behavior I expect to be able to use `Context.current()` inside the gRPC service's handler and get the context. ### Actual behavior `Context.current()` returns an empty context. ### How to Reproduce? 1. Setup a gRPC service 2. Send a request with context to the service 3. Debug and look on the value of `Context.current()` inside the service's handler ### Output of `uname -a` or `ver` Darwin ShakharArad 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22 PDT 2022; root:xnu-8020.121.3~4/RELEASE_X86_64 x86_64 ### Output of `java -version` openjdk 14.0.2 2020-07-14 OpenJDK Runtime Environment AdoptOpenJDK (build 14.0.2+12) OpenJDK 64-Bit Server VM AdoptOpenJDK (build 14.0.2+12, mixed mode, sharing) ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.9.2 ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) ------------------------------------------------------------ Gradle 7.3.3 ------------------------------------------------------------ Build time: 2021-12-22 12:37:54 UTC Revision: 6f556c80f945dc54b50e0be633da6c62dbe8dc71 Kotlin: 1.5.31 Groovy: 3.0.9 Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021 JVM: 14.0.2 (AdoptOpenJDK 14.0.2+12) OS: Mac OS X 10.16 x86_64 ### Additional information _No response_

0435097fbea3f3a543b42ad4b8c0f63c7ad6ebc4

207504610c33f17b34a543576e78b1dc356223f4

https://github.com/quarkusio/quarkus/compare/0435097fbea3f3a543b42ad4b8c0f63c7ad6ebc4...207504610c33f17b34a543576e78b1dc356223f4

diff --git a/extensions/opentelemetry/opentelemetry/deployment/src/test/java/io/quarkus/opentelemetry/deployment/GrpcOpenTelemetryTest.java b/extensions/opentelemetry/opentelemetry/deployment/src/test/java/io/quarkus/opentelemetry/deployment/GrpcOpenTelemetryTest.java index d615bcc31e0..696a27bc90f 100644 --- a/extensions/opentelemetry/opentelemetry/deployment/src/test/java/io/quarkus/opentelemetry/deployment/GrpcOpenTelemetryTest.java +++ b/extensions/opentelemetry/opentelemetry/deployment/src/test/java/io/quarkus/opentelemetry/deployment/GrpcOpenTelemetryTest.java @@ -1,5 +1,6 @@ package io.quarkus.opentelemetry.deployment; +import static io.opentelemetry.api.trace.SpanKind.INTERNAL; import static io.opentelemetry.semconv.trace.attributes.SemanticAttributes.NET_PEER_IP; import static io.opentelemetry.semconv.trace.attributes.SemanticAttributes.NET_PEER_PORT; import static io.opentelemetry.semconv.trace.attributes.SemanticAttributes.NET_TRANSPORT; @@ -7,6 +8,7 @@ import static io.opentelemetry.semconv.trace.attributes.SemanticAttributes.RPC_METHOD; import static io.opentelemetry.semconv.trace.attributes.SemanticAttributes.RPC_SERVICE; import static io.opentelemetry.semconv.trace.attributes.SemanticAttributes.RPC_SYSTEM; +import static io.quarkus.opentelemetry.runtime.OpenTelemetryConfig.INSTRUMENTATION_NAME; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertTrue; @@ -24,7 +26,11 @@ import io.grpc.Status; import io.grpc.stub.StreamObserver; +import io.opentelemetry.api.GlobalOpenTelemetry; +import io.opentelemetry.api.common.AttributeKey; +import io.opentelemetry.api.trace.Span; import io.opentelemetry.api.trace.SpanKind; +import io.opentelemetry.api.trace.Tracer; import io.opentelemetry.extension.annotations.WithSpan; import io.opentelemetry.sdk.trace.data.SpanData; import io.quarkus.grpc.GrpcClient; @@ -67,10 +73,15 @@ void grpc() { .await().atMost(Duration.ofSeconds(5)); assertEquals("Hello Naruto", response); - List<SpanData> spans = spanExporter.getFinishedSpanItems(2); - assertEquals(2, spans.size()); + List<SpanData> spans = spanExporter.getFinishedSpanItems(3); + assertEquals(3, spans.size()); - SpanData server = spans.get(0); + SpanData internal = spans.get(0); + assertEquals("span.internal", internal.getName()); + assertEquals(INTERNAL, internal.getKind()); + assertEquals("value", internal.getAttributes().get(AttributeKey.stringKey("grpc.internal"))); + + SpanData server = spans.get(1); assertEquals("helloworld.Greeter/SayHello", server.getName()); assertEquals(SpanKind.SERVER, server.getKind()); assertEquals("grpc", server.getAttributes().get(RPC_SYSTEM)); @@ -81,7 +92,7 @@ void grpc() { assertNotNull(server.getAttributes().get(NET_PEER_PORT)); assertEquals("ip_tcp", server.getAttributes().get(NET_TRANSPORT)); - SpanData client = spans.get(1); + SpanData client = spans.get(2); assertEquals("helloworld.Greeter/SayHello", client.getName()); assertEquals(SpanKind.CLIENT, client.getKind()); assertEquals("grpc", client.getAttributes().get(RPC_SYSTEM)); @@ -89,6 +100,7 @@ void grpc() { assertEquals("SayHello", client.getAttributes().get(RPC_METHOD)); assertEquals(Status.Code.OK.value(), client.getAttributes().get(RPC_GRPC_STATUS_CODE)); + assertEquals(internal.getTraceId(), server.getTraceId()); assertEquals(server.getTraceId(), client.getTraceId()); } @@ -133,11 +145,12 @@ void error() { void withCdi() { assertEquals("Hello Naruto", helloBean.hello("Naruto")); - List<SpanData> spans = spanExporter.getFinishedSpanItems(3); - assertEquals(3, spans.size()); + List<SpanData> spans = spanExporter.getFinishedSpanItems(4); + assertEquals(4, spans.size()); assertEquals(spans.get(0).getTraceId(), spans.get(1).getTraceId()); assertEquals(spans.get(0).getTraceId(), spans.get(2).getTraceId()); + assertEquals(spans.get(0).getTraceId(), spans.get(3).getTraceId()); } @GrpcService @@ -149,6 +162,13 @@ public void sayHello(final HelloRequest request, final StreamObserver<HelloReply return; } + Tracer tracer = GlobalOpenTelemetry.getTracer(INSTRUMENTATION_NAME); + Span span = tracer.spanBuilder("span.internal") + .setSpanKind(INTERNAL) + .setAttribute("grpc.internal", "value") + .startSpan(); + span.end(); + responseObserver.onNext(HelloReply.newBuilder().setMessage("Hello " + request.getName()).build()); responseObserver.onCompleted(); } diff --git a/extensions/opentelemetry/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/tracing/grpc/GrpcTracingClientInterceptor.java b/extensions/opentelemetry/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/tracing/grpc/GrpcTracingClientInterceptor.java index 6b054906ee8..aa63e542a40 100644 --- a/extensions/opentelemetry/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/tracing/grpc/GrpcTracingClientInterceptor.java +++ b/extensions/opentelemetry/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/tracing/grpc/GrpcTracingClientInterceptor.java @@ -49,22 +49,16 @@ public <ReqT, RespT> ClientCall<ReqT, RespT> interceptCall( GrpcRequest grpcRequest = GrpcRequest.client(method); Context parentContext = Context.current(); - Context spanContext = null; - Scope scope = null; boolean shouldStart = instrumenter.shouldStart(parentContext, grpcRequest); if (shouldStart) { - spanContext = instrumenter.start(parentContext, grpcRequest); - scope = spanContext.makeCurrent(); - } - - try { - ClientCall<ReqT, RespT> clientCall = next.newCall(method, callOptions); - return new TracingClientCall<>(clientCall, spanContext, grpcRequest); - } finally { - if (scope != null) { - scope.close(); + Context spanContext = instrumenter.start(parentContext, grpcRequest); + try (Scope ignored = spanContext.makeCurrent()) { + ClientCall<ReqT, RespT> clientCall = next.newCall(method, callOptions); + return new TracingClientCall<>(clientCall, spanContext, grpcRequest); } } + + return next.newCall(method, callOptions); } private enum GrpcTextMapSetter implements TextMapSetter<GrpcRequest> { diff --git a/extensions/opentelemetry/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/tracing/grpc/GrpcTracingServerInterceptor.java b/extensions/opentelemetry/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/tracing/grpc/GrpcTracingServerInterceptor.java index 959188539fe..9166bd10329 100644 --- a/extensions/opentelemetry/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/tracing/grpc/GrpcTracingServerInterceptor.java +++ b/extensions/opentelemetry/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/tracing/grpc/GrpcTracingServerInterceptor.java @@ -53,22 +53,16 @@ public <ReqT, RespT> ServerCall.Listener<ReqT> interceptCall( GrpcRequest grpcRequest = GrpcRequest.server(call.getMethodDescriptor(), headers, call.getAttributes()); Context parentContext = Context.current(); - Context spanContext = null; - Scope scope = null; boolean shouldStart = instrumenter.shouldStart(parentContext, grpcRequest); if (shouldStart) { - spanContext = instrumenter.start(parentContext, grpcRequest); - scope = spanContext.makeCurrent(); - } - - try { - TracingServerCall<ReqT, RespT> tracingServerCall = new TracingServerCall<>(call, spanContext, grpcRequest); - return new TracingServerCallListener<>(next.startCall(tracingServerCall, headers), spanContext, grpcRequest); - } finally { - if (scope != null) { - scope.close(); + Context spanContext = instrumenter.start(parentContext, grpcRequest); + try (Scope ignored = spanContext.makeCurrent()) { + TracingServerCall<ReqT, RespT> tracingServerCall = new TracingServerCall<>(call, spanContext, grpcRequest); + return new TracingServerCallListener<>(next.startCall(tracingServerCall, headers), spanContext, grpcRequest); } } + + return next.startCall(call, headers); } private static class GrpcServerNetServerAttributesGetter extends InetSocketAddressNetServerAttributesGetter<GrpcRequest> { @@ -116,7 +110,7 @@ protected TracingServerCallListener(final ServerCall.Listener<ReqT> delegate, fi @Override public void onHalfClose() { - try { + try (Scope ignored = spanContext.makeCurrent()) { super.onHalfClose(); } catch (Exception e) { instrumenter.end(spanContext, grpcRequest, null, e); @@ -126,18 +120,18 @@ public void onHalfClose() { @Override public void onCancel() { - try { + try (Scope ignored = spanContext.makeCurrent()) { super.onCancel(); + instrumenter.end(spanContext, grpcRequest, Status.CANCELLED, null); } catch (Exception e) { instrumenter.end(spanContext, grpcRequest, null, e); throw e; } - instrumenter.end(spanContext, grpcRequest, Status.CANCELLED, null); } @Override public void onComplete() { - try { + try (Scope ignored = spanContext.makeCurrent()) { super.onComplete(); } catch (Exception e) { instrumenter.end(spanContext, grpcRequest, null, e); @@ -147,7 +141,7 @@ public void onComplete() { @Override public void onReady() { - try { + try (Scope ignored = spanContext.makeCurrent()) { super.onReady(); } catch (Exception e) { instrumenter.end(spanContext, grpcRequest, null, e);

['extensions/opentelemetry/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/tracing/grpc/GrpcTracingClientInterceptor.java', 'extensions/opentelemetry/opentelemetry/deployment/src/test/java/io/quarkus/opentelemetry/deployment/GrpcOpenTelemetryTest.java', 'extensions/opentelemetry/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/tracing/grpc/GrpcTracingServerInterceptor.java']

{'.java': 3}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/26373/26318

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/26318

https://github.com/quarkusio/quarkus/pull/26373

https://github.com/quarkusio/quarkus/pull/26373

fix

Combination of quarkus-resteasy,quarkus-spring-data-rest ends with "Cannot generate HAL endpoints"

### Describe the bug Combination of `quarkus-resteasy,quarkus-spring-data-rest` ends with "Cannot generate HAL endpoints" HAL was introduced in https://github.com/quarkusio/quarkus/pull/25396/files by @Sgitario ``` 2022-06-23 15:16:56,114 INFO [org.jbo.threads] (main) JBoss Threads version 3.4.2.Final 2022-06-23 15:16:56,160 WARN [io.qua.agr.dep.AgroalProcessor] (build-32) The Agroal dependency is present but no JDBC datasources have been defined. 2022-06-23 15:16:56,320 INFO [io.qua.dep.dev.IsolatedDevModeMain] (main) Attempting to start live reload endpoint to recover from previous Quarkus startup failure 2022-06-23 15:16:56,487 INFO [org.jbo.threads] (main) JBoss Threads version 3.4.2.Final 2022-06-23 15:16:56,678 ERROR [io.qua.dep.dev.IsolatedDevModeMain] (main) Failed to start quarkus: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.resteasy.links.deployment.LinksProcessor#addHalSupport threw an exception: java.lang.IllegalStateException: Cannot generate HAL endpoints without either 'quarkus-resteasy-jsonb' or 'quarkus-resteasy-jackson' at io.quarkus.resteasy.links.deployment.LinksProcessor.addHalSupport(LinksProcessor.java:20) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:944) at io.quarkus.builder.BuildContext.run(BuildContext.java:277) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:829) at org.jboss.threads.JBossThread.run(JBossThread.java:501) at io.quarkus.runner.bootstrap.AugmentActionImpl.runAugment(AugmentActionImpl.java:330) at io.quarkus.runner.bootstrap.AugmentActionImpl.createInitialRuntimeApplication(AugmentActionImpl.java:252) at io.quarkus.runner.bootstrap.AugmentActionImpl.createInitialRuntimeApplication(AugmentActionImpl.java:60) at io.quarkus.deployment.dev.IsolatedDevModeMain.firstStart(IsolatedDevModeMain.java:95) at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:485) at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:68) at io.quarkus.bootstrap.app.CuratedApplication.runInCl(CuratedApplication.java:147) at io.quarkus.bootstrap.app.CuratedApplication.runInAugmentClassLoader(CuratedApplication.java:102) at io.quarkus.deployment.dev.DevModeMain.start(DevModeMain.java:131) at io.quarkus.deployment.dev.DevModeMain.main(DevModeMain.java:62) Caused by: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.resteasy.links.deployment.LinksProcessor#addHalSupport threw an exception: java.lang.IllegalStateException: Cannot generate HAL endpoints without either 'quarkus-resteasy-jsonb' or 'quarkus-resteasy-jackson' at io.quarkus.resteasy.links.deployment.LinksProcessor.addHalSupport(LinksProcessor.java:20) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:944) at io.quarkus.builder.BuildContext.run(BuildContext.java:277) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:829) at org.jboss.threads.JBossThread.run(JBossThread.java:501) at io.quarkus.builder.Execution.run(Execution.java:116) at io.quarkus.builder.BuildExecutionBuilder.execute(BuildExecutionBuilder.java:79) at io.quarkus.deployment.QuarkusAugmentor.run(QuarkusAugmentor.java:157) at io.quarkus.runner.bootstrap.AugmentActionImpl.runAugment(AugmentActionImpl.java:328) ... 9 more Caused by: java.lang.IllegalStateException: Cannot generate HAL endpoints without either 'quarkus-resteasy-jsonb' or 'quarkus-resteasy-jackson' at io.quarkus.resteasy.links.deployment.LinksProcessor.addHalSupport(LinksProcessor.java:20) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:944) at io.quarkus.builder.BuildContext.run(BuildContext.java:277) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:829) at org.jboss.threads.JBossThread.run(JBossThread.java:501) ``` ### Expected behavior No error is thrown, I'm not using HAL at all. ### Actual behavior Error when building the app ### How to Reproduce? quarkus create app app -x quarkus-resteasy,quarkus-spring-data-rest cd app quarkus dev ### Output of `uname -a` or `ver` macOS Monterey ### Output of `java -version` Java 17 ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.10.0.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) _No response_ ### Additional information _No response_

f94a8d042cc4e90bd83addefaed9401e929307e5

30790783c1800401399a4faa07e6e7d7cf922491

https://github.com/quarkusio/quarkus/compare/f94a8d042cc4e90bd83addefaed9401e929307e5...30790783c1800401399a4faa07e6e7d7cf922491

diff --git a/extensions/resteasy-classic/resteasy-common/deployment/src/main/java/io/quarkus/resteasy/common/deployment/ResteasyCommonProcessor.java b/extensions/resteasy-classic/resteasy-common/deployment/src/main/java/io/quarkus/resteasy/common/deployment/ResteasyCommonProcessor.java index 4473273519d..0d44455ea08 100644 --- a/extensions/resteasy-classic/resteasy-common/deployment/src/main/java/io/quarkus/resteasy/common/deployment/ResteasyCommonProcessor.java +++ b/extensions/resteasy-classic/resteasy-common/deployment/src/main/java/io/quarkus/resteasy/common/deployment/ResteasyCommonProcessor.java @@ -96,6 +96,8 @@ public class ResteasyCommonProcessor { private static final DotName QUARKUS_JSONB_SERIALIZER = DotName .createSimple("io.quarkus.resteasy.common.runtime.jsonb.QuarkusJsonbSerializer"); + private static final String APPLICATION_HAL_JSON = "application/hal+json"; + private static final String[] WILDCARD_MEDIA_TYPE_ARRAY = { MediaType.WILDCARD }; private ResteasyCommonConfig resteasyCommonConfig; @@ -217,7 +219,8 @@ JaxrsProvidersToRegisterBuildItem setupProviders(BuildProducer<ReflectiveClassBu boolean needJsonSupport = restJsonSupportNeeded(indexBuildItem, ResteasyDotNames.CONSUMES) || restJsonSupportNeeded(indexBuildItem, ResteasyDotNames.PRODUCES) || restJsonSupportNeeded(indexBuildItem, ResteasyDotNames.RESTEASY_SSE_ELEMENT_TYPE) - || restJsonSupportNeeded(indexBuildItem, ResteasyDotNames.RESTEASY_PART_TYPE); + || restJsonSupportNeeded(indexBuildItem, ResteasyDotNames.RESTEASY_PART_TYPE) + || restJsonSupportNeededForHalCapability(capabilities, indexBuildItem); if (needJsonSupport) { LOGGER.warn( "Quarkus detected the need of REST JSON support but you have not provided the necessary JSON " + @@ -390,21 +393,36 @@ private void checkProperConfigAccessInProvider(AnnotationInstance instance) { } } + private boolean restJsonSupportNeededForHalCapability(Capabilities capabilities, CombinedIndexBuildItem indexBuildItem) { + return capabilities.isPresent(Capability.HAL) + && isMediaTypeFoundInAnnotation(indexBuildItem, ResteasyDotNames.PRODUCES, APPLICATION_HAL_JSON); + } + private boolean restJsonSupportNeeded(CombinedIndexBuildItem indexBuildItem, DotName mediaTypeAnnotation) { + return isMediaTypeFoundInAnnotation(indexBuildItem, mediaTypeAnnotation, + MediaType.APPLICATION_JSON, MediaType.APPLICATION_JSON_PATCH_JSON); + } + + private boolean isMediaTypeFoundInAnnotation(CombinedIndexBuildItem indexBuildItem, DotName mediaTypeAnnotation, + String... mediaTypes) { for (AnnotationInstance annotationInstance : indexBuildItem.getIndex().getAnnotations(mediaTypeAnnotation)) { final AnnotationValue annotationValue = annotationInstance.value(); if (annotationValue == null) { continue; } - List<String> mediaTypes = Collections.emptyList(); + List<String> foundMediaTypes = Collections.emptyList(); if (annotationValue.kind() == Kind.ARRAY) { - mediaTypes = Arrays.asList(annotationValue.asStringArray()); + foundMediaTypes = Arrays.asList(annotationValue.asStringArray()); } else if (annotationValue.kind() == Kind.STRING) { - mediaTypes = Collections.singletonList(annotationValue.asString()); + foundMediaTypes = Collections.singletonList(annotationValue.asString()); + } + + for (int i = 0; i < mediaTypes.length; i++) { + if (foundMediaTypes.contains(mediaTypes[i])) { + return true; + } } - return mediaTypes.contains(MediaType.APPLICATION_JSON) - || mediaTypes.contains(MediaType.APPLICATION_JSON_PATCH_JSON); } return false; diff --git a/extensions/resteasy-classic/resteasy-links/deployment/src/main/java/io/quarkus/resteasy/links/deployment/LinksProcessor.java b/extensions/resteasy-classic/resteasy-links/deployment/src/main/java/io/quarkus/resteasy/links/deployment/LinksProcessor.java index f972525e283..7829b37caae 100644 --- a/extensions/resteasy-classic/resteasy-links/deployment/src/main/java/io/quarkus/resteasy/links/deployment/LinksProcessor.java +++ b/extensions/resteasy-classic/resteasy-links/deployment/src/main/java/io/quarkus/resteasy/links/deployment/LinksProcessor.java @@ -15,12 +15,6 @@ void addHalSupport(Capabilities capabilities, BuildProducer<ResteasyJaxrsProvide BuildProducer<AdditionalBeanBuildItem> additionalBeans) { boolean isHalSupported = capabilities.isPresent(Capability.HAL); if (isHalSupported) { - if (!capabilities.isPresent(Capability.RESTEASY_JSON_JSONB) - && !capabilities.isPresent(Capability.RESTEASY_JSON_JACKSON)) { - throw new IllegalStateException("Cannot generate HAL endpoints without " - + "either 'quarkus-resteasy-jsonb' or 'quarkus-resteasy-jackson'"); - } - jaxRsProviders.produce( new ResteasyJaxrsProviderBuildItem(HalServerResponseFilter.class.getName())); diff --git a/extensions/resteasy-reactive/quarkus-resteasy-reactive-links/deployment/src/main/java/io/quarkus/resteasy/reactive/links/deployment/LinksProcessor.java b/extensions/resteasy-reactive/quarkus-resteasy-reactive-links/deployment/src/main/java/io/quarkus/resteasy/reactive/links/deployment/LinksProcessor.java index 939dfdb14d2..2cdbfff1adc 100644 --- a/extensions/resteasy-reactive/quarkus-resteasy-reactive-links/deployment/src/main/java/io/quarkus/resteasy/reactive/links/deployment/LinksProcessor.java +++ b/extensions/resteasy-reactive/quarkus-resteasy-reactive-links/deployment/src/main/java/io/quarkus/resteasy/reactive/links/deployment/LinksProcessor.java @@ -14,6 +14,7 @@ import org.jboss.jandex.DotName; import org.jboss.jandex.FieldInfo; import org.jboss.jandex.IndexView; +import org.jboss.resteasy.reactive.common.util.RestMediaType; import io.quarkus.arc.deployment.AdditionalBeanBuildItem; import io.quarkus.deployment.Capabilities; @@ -82,16 +83,25 @@ AdditionalBeanBuildItem registerRestLinksProviderProducer() { } @BuildStep - void addHalSupport(Capabilities capabilities, BuildProducer<CustomContainerResponseFilterBuildItem> customResponseFilters, - BuildProducer<AdditionalBeanBuildItem> additionalBeans) { + void validateJsonNeededForHal(Capabilities capabilities, + ResteasyReactiveResourceMethodEntriesBuildItem resourceMethodEntriesBuildItem) { boolean isHalSupported = capabilities.isPresent(Capability.HAL); - if (isHalSupported) { + if (isHalSupported && isHalMediaTypeUsedInAnyResource(resourceMethodEntriesBuildItem.getEntries())) { + if (!capabilities.isPresent(Capability.RESTEASY_REACTIVE_JSON_JSONB) && !capabilities.isPresent( Capability.RESTEASY_REACTIVE_JSON_JACKSON)) { throw new IllegalStateException("Cannot generate HAL endpoints without " + "either 'quarkus-resteasy-reactive-jsonb' or 'quarkus-resteasy-reactive-jackson'"); } + } + } + @BuildStep + void addHalSupport(Capabilities capabilities, + BuildProducer<CustomContainerResponseFilterBuildItem> customResponseFilters, + BuildProducer<AdditionalBeanBuildItem> additionalBeans) { + boolean isHalSupported = capabilities.isPresent(Capability.HAL); + if (isHalSupported) { customResponseFilters.produce( new CustomContainerResponseFilterBuildItem(HalServerResponseFilter.class.getName())); @@ -99,6 +109,18 @@ void addHalSupport(Capabilities capabilities, BuildProducer<CustomContainerRespo } } + private boolean isHalMediaTypeUsedInAnyResource(List<ResteasyReactiveResourceMethodEntriesBuildItem.Entry> entries) { + for (ResteasyReactiveResourceMethodEntriesBuildItem.Entry entry : entries) { + for (String mediaType : entry.getResourceMethod().getProduces()) { + if (RestMediaType.APPLICATION_HAL_JSON.equals(mediaType)) { + return true; + } + } + } + + return false; + } + private LinksContainer getLinksContainer(ResteasyReactiveResourceMethodEntriesBuildItem resourceMethodEntriesBuildItem, IndexView index) { LinksContainerFactory linksContainerFactory = new LinksContainerFactory();

['extensions/resteasy-reactive/quarkus-resteasy-reactive-links/deployment/src/main/java/io/quarkus/resteasy/reactive/links/deployment/LinksProcessor.java', 'extensions/resteasy-classic/resteasy-common/deployment/src/main/java/io/quarkus/resteasy/common/deployment/ResteasyCommonProcessor.java', 'extensions/resteasy-classic/resteasy-links/deployment/src/main/java/io/quarkus/resteasy/links/deployment/LinksProcessor.java']

{'.java': 3}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/26412/26392

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/26392

https://github.com/quarkusio/quarkus/pull/26412

https://github.com/quarkusio/quarkus/pull/26412

close

Gradle plugin incorrectly requires Gradle 6.1

### Describe the bug The Gradle plugin checks Gradle version when starting, checking for minimum 6.1 but 7.4 is required since 2.10.0.Final ### Expected behavior Update the test so that 7.4 is required ### Actual behavior Test is wrong ### How to Reproduce? _No response_ ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` _No response_ ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.10.0.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) _No response_ ### Additional information _No response_

617d484bc6827cec6c01b16f300ccacc0e798b05

56d7655a1298a5db71aa0c53c2c9294ed77f25d5

https://github.com/quarkusio/quarkus/compare/617d484bc6827cec6c01b16f300ccacc0e798b05...56d7655a1298a5db71aa0c53c2c9294ed77f25d5

diff --git a/devtools/gradle/gradle-model/src/main/java/io/quarkus/gradle/dependency/ApplicationDeploymentClasspathBuilder.java b/devtools/gradle/gradle-model/src/main/java/io/quarkus/gradle/dependency/ApplicationDeploymentClasspathBuilder.java index c456a82b2aa..b463445777c 100644 --- a/devtools/gradle/gradle-model/src/main/java/io/quarkus/gradle/dependency/ApplicationDeploymentClasspathBuilder.java +++ b/devtools/gradle/gradle-model/src/main/java/io/quarkus/gradle/dependency/ApplicationDeploymentClasspathBuilder.java @@ -22,6 +22,7 @@ import org.gradle.api.internal.artifacts.dependencies.DefaultDependencyArtifact; import org.gradle.api.internal.artifacts.dependencies.DefaultExternalModuleDependency; import org.gradle.api.plugins.JavaPlugin; +import org.gradle.api.provider.ListProperty; import io.quarkus.bootstrap.BootstrapConstants; import io.quarkus.bootstrap.model.PlatformImports; @@ -135,13 +136,15 @@ private void setUpPlatformConfiguration() { project.getConfigurations().create(this.platformConfigurationName, configuration -> { // Platform configuration is just implementation, filtered to platform dependencies - configuration.getDependencies().addAllLater(project.provider(() -> project.getConfigurations() - .getByName(JavaPlugin.IMPLEMENTATION_CONFIGURATION_NAME) - .getAllDependencies() - .stream() - .filter(dependency -> dependency instanceof ModuleDependency && - ToolingUtils.isEnforcedPlatform((ModuleDependency) dependency)) - .collect(Collectors.toList()))); + ListProperty<Dependency> dependencyListProperty = project.getObjects().listProperty(Dependency.class); + configuration.getDependencies() + .addAllLater(dependencyListProperty.value(project.provider(() -> project.getConfigurations() + .getByName(JavaPlugin.IMPLEMENTATION_CONFIGURATION_NAME) + .getAllDependencies() + .stream() + .filter(dependency -> dependency instanceof ModuleDependency && + ToolingUtils.isEnforcedPlatform((ModuleDependency) dependency)) + .collect(Collectors.toList())))); // Configures PlatformImportsImpl once the platform configuration is resolved configuration.getResolutionStrategy().eachDependency(d -> { ModuleIdentifier identifier = d.getTarget().getModule(); @@ -192,7 +195,8 @@ private void setUpDeploymentConfiguration() { project.getConfigurations().create(this.deploymentConfigurationName, configuration -> { Configuration enforcedPlatforms = this.getPlatformConfiguration(); configuration.extendsFrom(enforcedPlatforms); - configuration.getDependencies().addAllLater(project.provider(() -> { + ListProperty<Dependency> dependencyListProperty = project.getObjects().listProperty(Dependency.class); + configuration.getDependencies().addAllLater(dependencyListProperty.value(project.provider(() -> { ConditionalDependenciesEnabler cdEnabler = new ConditionalDependenciesEnabler(project, mode, enforcedPlatforms); final Collection<ExtensionDependency> allExtensions = cdEnabler.getAllExtensions(); @@ -225,7 +229,7 @@ private void setUpDeploymentConfiguration() { } } return deploymentDependencies; - })); + }))); }); } }

['devtools/gradle/gradle-model/src/main/java/io/quarkus/gradle/dependency/ApplicationDeploymentClasspathBuilder.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/26449/26304

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/26304

https://github.com/quarkusio/quarkus/pull/26449

https://github.com/quarkusio/quarkus/pull/26449

fixes

Can't run OpenTelemetry JDBC instrumentation with Quarkus integration tests

### Describe the bug I'm following the [JDBC example from the OpenTelemetry guide](https://quarkus.io/guides/opentelemetry#jdbc). When I try to integrate it and then run tests using `@QuarkusIntegrationTest` it does not work. Dev services does not adjust the jdbc URL to include the `otel` part. It seems to do that fine when running `@QuarkusTest`s. ### Expected behavior I would expect to be able to run `@QuarkusIntegrationTests` with OpenTelemetry configured. ### Actual behavior When running `./mvnw clean verify` with integration tests enabled & the OpenTelemetry JDBC, the Quarkus tests fail. Here is the console output. You can clearly see from ` Executing "/Users/edeandre/.sdkman/candidates/java/17.0.3-tem/bin/java -Dquarkus.http.port=8081 -Dquarkus.http.ssl-port=8444 -Dtest.url=http://localhost:8081 -Dquarkus.log.file.path=/Users/edeandre/Desktop/temp/opentelemetry-quickstart/target/quarkus.log -Dquarkus.log.file.enable=true -Dquarkus.datasource.password=quarkus -Dquarkus.datasource.db-kind=postgresql -Dquarkus.datasource.jdbc.url=jdbc:postgresql://localhost:51217/default?loggerLevel=OFF -Dquarkus.datasource.username=quarkus -jar /Users/edeandre/Desktop/temp/opentelemetry-quickstart/target/quarkus-app/quarkus-run.jar"` that the `quarkus.datasource.jdbc.url` does not include the `otel` part: ``` [INFO] --- maven-failsafe-plugin:3.0.0-M7:integration-test (default) @ opentelemetry-quickstart --- [INFO] Using auto detected provider org.apache.maven.surefire.junitplatform.JUnitPlatformProvider [INFO] [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.acme.opentelemetry.TracedResourceIT 15:27:48 INFO traceId=, parentId=, spanId=, sampled= [or.jb.threads] (main) JBoss Threads version 3.4.2.Final 15:27:49 INFO traceId=, parentId=, spanId=, sampled= [or.te.do.DockerClientProviderStrategy] (build-11) Loaded org.testcontainers.dockerclient.UnixSocketClientProviderStrategy from ~/.testcontainers.properties, will try it first 15:27:49 WARN traceId=, parentId=, spanId=, sampled= [or.te.do.DockerClientProviderStrategy] (build-11) DOCKER_HOST tcp://127.0.0.1:49951 is not listening 15:27:49 INFO traceId=, parentId=, spanId=, sampled= [or.te.do.DockerClientProviderStrategy] (build-11) Found Docker environment with local Unix socket (unix:///var/run/docker.sock) 15:27:49 INFO traceId=, parentId=, spanId=, sampled= [or.te.DockerClientFactory] (build-11) Docker host IP address is localhost 15:27:49 INFO traceId=, parentId=, spanId=, sampled= [or.te.DockerClientFactory] (build-11) Connected to docker: Server Version: 20.10.16 API Version: 1.41 Operating System: Docker Desktop Total Memory: 5939 MB 15:27:49 INFO traceId=, parentId=, spanId=, sampled= [or.te.DockerClientFactory] (build-11) Checking the system... 15:27:49 INFO traceId=, parentId=, spanId=, sampled= [or.te.DockerClientFactory] (build-11) ✔︎ Docker server version should be at least 1.6.0 15:27:49 INFO traceId=, parentId=, spanId=, sampled= [or.te.ut.ImageNameSubstitutor] (build-11) Image name substitution will be performed by: DefaultImageNameSubstitutor (composite of 'ConfigurationFileImageNameSubstitutor' and 'PrefixingImageNameSubstitutor') 15:27:49 INFO traceId=, parentId=, spanId=, sampled= [🐳.io.2]] (build-11) Creating container for image: docker.io/postgres:14.2 15:27:49 INFO traceId=, parentId=, spanId=, sampled= [or.te.ut.RegistryAuthLocator] (build-11) Credential helper/store (docker-credential-desktop) does not have credentials for docker.io 15:27:49 WARN traceId=, parentId=, spanId=, sampled= [🐳.io.2]] (build-11) Reuse was requested but the environment does not support the reuse of containers To enable reuse of containers, you must set 'testcontainers.reuse.enable=true' in a file located at /Users/edeandre/.testcontainers.properties 15:27:49 INFO traceId=, parentId=, spanId=, sampled= [🐳.io.2]] (build-11) Container docker.io/postgres:14.2 is starting: 9268e329708f5772c844eee81a31de1e24857bfadb7061e4813a26450360c444 15:27:50 INFO traceId=, parentId=, spanId=, sampled= [🐳.io.2]] (build-11) Container docker.io/postgres:14.2 started in PT1.258444S 15:27:50 INFO traceId=, parentId=, spanId=, sampled= [io.qu.de.po.de.PostgresqlDevServicesProcessor] (build-11) Dev Services for PostgreSQL started. 15:27:50 INFO traceId=, parentId=, spanId=, sampled= [io.qu.da.de.de.DevServicesDatasourceProcessor] (build-11) Dev Services for the default datasource (postgresql) started. Executing "/Users/edeandre/.sdkman/candidates/java/17.0.3-tem/bin/java -Dquarkus.http.port=8081 -Dquarkus.http.ssl-port=8444 -Dtest.url=http://localhost:8081 -Dquarkus.log.file.path=/Users/edeandre/Desktop/temp/opentelemetry-quickstart/target/quarkus.log -Dquarkus.log.file.enable=true -Dquarkus.datasource.password=quarkus -Dquarkus.datasource.db-kind=postgresql -Dquarkus.datasource.jdbc.url=jdbc:postgresql://localhost:51217/default?loggerLevel=OFF -Dquarkus.datasource.username=quarkus -jar /Users/edeandre/Desktop/temp/opentelemetry-quickstart/target/quarkus-app/quarkus-run.jar" __ ____ __ _____ ___ __ ____ ______ --/ __ \\/ / / / _ | / _ \\/ //_/ / / / __/ -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\\ \\ --\\___\\_\\____/_/ |_/_/|_/_/|_|\\____/___/ 15:27:51 WARN traceId=, parentId=, spanId=, sampled= [io.ag.pool] (main) Datasource '<default>': Driver does not support the provided URL: jdbc:postgresql://localhost:51217/default?loggerLevel=OFF 15:27:51 WARN traceId=, parentId=, spanId=, sampled= [io.ag.pool] (agroal-11) Datasource '<default>': Driver does not support the provided URL: jdbc:postgresql://localhost:51217/default?loggerLevel=OFF 15:27:51 WARN traceId=, parentId=, spanId=, sampled= [or.hi.en.jd.en.in.JdbcEnvironmentInitiator] (JPA Startup Thread: <default>) HHH000342: Could not obtain connection to query metadata: java.sql.SQLException: Driver does not support the provided URL: jdbc:postgresql://localhost:51217/default?loggerLevel=OFF at io.agroal.pool.ConnectionFactory.connectionSetup(ConnectionFactory.java:242) at io.agroal.pool.ConnectionFactory.createConnection(ConnectionFactory.java:226) at io.agroal.pool.ConnectionPool$CreateConnectionTask.call(ConnectionPool.java:535) at io.agroal.pool.ConnectionPool$CreateConnectionTask.call(ConnectionPool.java:516) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at io.agroal.pool.util.PriorityScheduledExecutor.beforeExecute(PriorityScheduledExecutor.java:75) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:833) 15:27:51 WARN traceId=, parentId=, spanId=, sampled= [io.ag.pool] (agroal-11) Datasource '<default>': Driver does not support the provided URL: jdbc:postgresql://localhost:51217/default?loggerLevel=OFF 15:27:51 WARN traceId=, parentId=, spanId=, sampled= [or.hi.en.jd.sp.SqlExceptionHelper] (JPA Startup Thread: <default>) SQL Error: 0, SQLState: null 15:27:51 ERROR traceId=, parentId=, spanId=, sampled= [or.hi.en.jd.sp.SqlExceptionHelper] (JPA Startup Thread: <default>) Driver does not support the provided URL: jdbc:postgresql://localhost:51217/default?loggerLevel=OFF 15:27:51 ERROR traceId=, parentId=, spanId=, sampled= [io.qu.ru.Application] (main) Failed to start application (with profile prod): java.sql.SQLException: Driver does not support the provided URL: jdbc:postgresql://localhost:51217/default?loggerLevel=OFF at io.agroal.pool.ConnectionFactory.connectionSetup(ConnectionFactory.java:242) at io.agroal.pool.ConnectionFactory.createConnection(ConnectionFactory.java:226) at io.agroal.pool.ConnectionPool$CreateConnectionTask.call(ConnectionPool.java:535) at io.agroal.pool.ConnectionPool$CreateConnectionTask.call(ConnectionPool.java:516) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at io.agroal.pool.util.PriorityScheduledExecutor.beforeExecute(PriorityScheduledExecutor.java:75) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:833) Application was not started: 2022-06-22 15:27:51,354 edeandrea-m1pro quarkus-run.jar[4225] ERROR [io.qua.run.Application] (main) Failed to start application (with profile prod): java.sql.SQLException: Driver does not support the provided URL: jdbc:postgresql://localhost:51217/default?loggerLevel=OFF ``` ### How to Reproduce? Reproducer: [opentelemetry-quickstart.zip](https://github.com/quarkusio/quarkus/files/8961164/opentelemetry-quickstart.zip) 1. Unzip 2. `cd opentelemetry-quickstart` 3. `./mvnw clean verify` ### Output of `uname -a` or `ver` Darwin edeandrea-m1pro 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:37 PDT 2022; root:xnu-8020.121.3~4/RELEASE_ARM64_T6000 arm64 ### Output of `java -version` ``` openjdk version "17.0.3" 2022-04-19 OpenJDK Runtime Environment Temurin-17.0.3+7 (build 17.0.3+7) OpenJDK 64-Bit Server VM Temurin-17.0.3+7 (build 17.0.3+7, mixed mode) ``` ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.10.0.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) ``` Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) Maven home: /Users/edeandre/.m2/wrapper/dists/apache-maven-3.8.4-bin/52ccbt68d252mdldqsfsn03jlf/apache-maven-3.8.4 Java version: 17.0.3, vendor: Eclipse Adoptium, runtime: /Users/edeandre/.sdkman/candidates/java/17.0.3-tem Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "12.4", arch: "aarch64", family: "mac" ``` ### Additional information _No response_

2ef790ccdcd04ff5c366aec17470eff16e7872dd

f61c64a40b52cef6063994465e4f21f998fe6240

https://github.com/quarkusio/quarkus/compare/2ef790ccdcd04ff5c366aec17470eff16e7872dd...f61c64a40b52cef6063994465e4f21f998fe6240

diff --git a/extensions/opentelemetry/opentelemetry/deployment/src/main/java/io/quarkus/opentelemetry/deployment/dev/DevServicesOpenTelemetryProcessor.java b/extensions/opentelemetry/opentelemetry/deployment/src/main/java/io/quarkus/opentelemetry/deployment/dev/DevServicesOpenTelemetryProcessor.java index 8ac7144a4f9..4ce75156be6 100644 --- a/extensions/opentelemetry/opentelemetry/deployment/src/main/java/io/quarkus/opentelemetry/deployment/dev/DevServicesOpenTelemetryProcessor.java +++ b/extensions/opentelemetry/opentelemetry/deployment/src/main/java/io/quarkus/opentelemetry/deployment/dev/DevServicesOpenTelemetryProcessor.java @@ -1,11 +1,8 @@ package io.quarkus.opentelemetry.deployment.dev; -import static io.quarkus.opentelemetry.runtime.dev.OpenTelemetryDevServicesConfigBuilder.OPENTELEMETRY_DEVSERVICES_CONFIG; - -import java.io.ByteArrayOutputStream; +import java.util.HashMap; import java.util.Map; import java.util.Optional; -import java.util.Properties; import org.eclipse.microprofile.config.ConfigProvider; import org.eclipse.microprofile.config.ConfigValue; @@ -14,22 +11,19 @@ import io.quarkus.deployment.IsNormal; import io.quarkus.deployment.annotations.BuildProducer; import io.quarkus.deployment.annotations.BuildStep; -import io.quarkus.deployment.builditem.GeneratedResourceBuildItem; -import io.quarkus.deployment.builditem.RunTimeConfigBuilderBuildItem; +import io.quarkus.deployment.builditem.DevServicesAdditionalConfigBuildItem; import io.quarkus.deployment.dev.devservices.GlobalDevServicesConfig; import io.quarkus.opentelemetry.deployment.OpenTelemetryEnabled; -import io.quarkus.opentelemetry.runtime.dev.OpenTelemetryDevServicesConfigBuilder; public class DevServicesOpenTelemetryProcessor { @BuildStep(onlyIfNot = IsNormal.class, onlyIf = { OpenTelemetryEnabled.class, GlobalDevServicesConfig.Enabled.class }) void devServicesDatasources( Optional<DevServicesDatasourceResultBuildItem> devServicesDatasources, - BuildProducer<GeneratedResourceBuildItem> generatedResource, - BuildProducer<RunTimeConfigBuilderBuildItem> runtimeConfigBuilder) throws Exception { + BuildProducer<DevServicesAdditionalConfigBuildItem> devServicesAdditionalConfig) { if (devServicesDatasources.isPresent()) { - Properties properties = new Properties(); + Map<String, String> properties = new HashMap<>(); DevServicesDatasourceResultBuildItem.DbResult defaultDatasource = devServicesDatasources.get() .getDefaultDatasource(); if (defaultDatasource != null) { @@ -47,28 +41,20 @@ void devServicesDatasources( } // if we find a dev service datasource and the OTel driver, we rewrite the jdbc url to add the otel prefix - for (Map.Entry<Object, Object> property : properties.entrySet()) { - String key = (String) property.getKey(); - String value = (String) property.getValue(); + for (Map.Entry<String, String> property : properties.entrySet()) { + String key = property.getKey(); + String value = property.getValue(); if (key.endsWith(".url") && value.startsWith("jdbc:")) { String driverKey = key.substring(0, key.length() - 4) + ".driver"; ConfigValue driverValue = ConfigProvider.getConfig().getConfigValue(driverKey); if (driverValue.getValue() != null && driverValue.getValue().equals("io.opentelemetry.instrumentation.jdbc.OpenTelemetryDriver")) { - properties.put(key, value.replaceFirst("jdbc:", "jdbc:otel:")); + devServicesAdditionalConfig.produce(new DevServicesAdditionalConfigBuildItem(key, key, + value.replaceFirst("jdbc:", "jdbc:otel:"), () -> { + })); } } } - - ByteArrayOutputStream out = new ByteArrayOutputStream(); - properties.store(out, null); - - // write the config with a slightly higher priority then runtime defaults - // see io.quarkus.deployment.steps.ConfigGenerationBuildStep#runtimeDefaultsConfig - generatedResource - .produce(new GeneratedResourceBuildItem(OPENTELEMETRY_DEVSERVICES_CONFIG, out.toByteArray())); - runtimeConfigBuilder - .produce(new RunTimeConfigBuilderBuildItem(OpenTelemetryDevServicesConfigBuilder.class.getName())); } } } diff --git a/extensions/opentelemetry/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/dev/OpenTelemetryDevServicesConfigBuilder.java b/extensions/opentelemetry/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/dev/OpenTelemetryDevServicesConfigBuilder.java deleted file mode 100644 index 0895c73fdc9..00000000000 --- a/extensions/opentelemetry/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/dev/OpenTelemetryDevServicesConfigBuilder.java +++ /dev/null @@ -1,40 +0,0 @@ -package io.quarkus.opentelemetry.runtime.dev; - -import java.io.IOException; -import java.net.URL; - -import org.eclipse.microprofile.config.spi.ConfigSource; -import org.eclipse.microprofile.config.spi.ConfigSourceProvider; - -import io.quarkus.runtime.configuration.ConfigBuilder; -import io.smallrye.config.AbstractLocationConfigSourceLoader; -import io.smallrye.config.PropertiesConfigSource; -import io.smallrye.config.SmallRyeConfigBuilder; - -public class OpenTelemetryDevServicesConfigBuilder implements ConfigBuilder { - public static final String OPENTELEMETRY_DEVSERVICES_CONFIG = "opentelemetry-devservices-config.properties"; - - @Override - public SmallRyeConfigBuilder configBuilder(final SmallRyeConfigBuilder builder) { - builder.withSources(new DevServicesConfigSourceFactory()); - return builder; - } - - private static class DevServicesConfigSourceFactory extends AbstractLocationConfigSourceLoader - implements ConfigSourceProvider { - @Override - protected String[] getFileExtensions() { - return new String[] { "properties" }; - } - - @Override - protected ConfigSource loadConfigSource(final URL url, final int ordinal) throws IOException { - return new PropertiesConfigSource(url, ordinal); - } - - @Override - public Iterable<ConfigSource> getConfigSources(final ClassLoader forClassLoader) { - return loadConfigSources(OPENTELEMETRY_DEVSERVICES_CONFIG, Integer.MIN_VALUE + 500); - } - } -}

['extensions/opentelemetry/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/dev/OpenTelemetryDevServicesConfigBuilder.java', 'extensions/opentelemetry/opentelemetry/deployment/src/main/java/io/quarkus/opentelemetry/deployment/dev/DevServicesOpenTelemetryProcessor.java']

{'.java': 2}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/26456/26386

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/26386

https://github.com/quarkusio/quarkus/pull/26456

https://github.com/quarkusio/quarkus/pull/26456

fix

Quarkus 2.10.0 doesn't work for Simulate Amazon Lambda Deployment with SAM CLI

### Describe the bug With a simple app (e.g. Hello world REST API), Quarkus 2.9.2 allows me to simulate an AWS Lambda app using SAM CLI locally as below: sam local start-api --template target/sam.jvm.yaml But Quarkus 2.10.0 doesn't work with the error as the actual behavior. I know that Quarkus dev mode is good enough to test the function since Quarkus dev mode starts a mock AWS Lambda event server that will convert HTTP requests. But as long as we provide the sam CLI guide in our doc(https://quarkus.io/guides/amazon-lambda-http), sam local test should work too. ### Expected behavior Start a Quarkus dev mode without an error then a developer can access the REST API to invoke the function. ### Actual behavior I have the following error: ``` 2022-06-27 17:18:36,102 ERROR [qua.ama.lam.http] (main) Request Failure: java.lang.ClassCastException: class lambdainternal.api.LambdaContext cannot be cast to class io.quarkus.amazon.lambda.runtime.AmazonLambdaContext (lambdainternal.api.LambdaContext is in unnamed module of loader 'app'; io.quarkus.amazon.lambda.runtime.AmazonLambdaContext is in unnamed module of loader lambdainternal.CustomerClassLoader @1a6c5a9e) at io.quarkus.amazon.lambda.http.LambdaHttpHandler.handleRequest(LambdaHttpHandler.java:70) at io.quarkus.amazon.lambda.http.LambdaHttpHandler.handleRequest(LambdaHttpHandler.java:47) at io.quarkus.amazon.lambda.runtime.AmazonLambdaRecorder.handle(AmazonLambdaRecorder.java:85) at io.quarkus.amazon.lambda.runtime.QuarkusStreamHandler.handleRequest(QuarkusStreamHandler.java:58) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.base/java.lang.reflect.Method.invoke(Unknown Source) at lambdainternal.EventHandlerLoader$StreamMethodRequestHandler.handleRequest(EventHandlerLoader.java:375) at lambdainternal.EventHandlerLoader$2.call(EventHandlerLoader.java:899) at lambdainternal.AWSLambda.startRuntime(AWSLambda.java:268) at lambdainternal.AWSLambda.startRuntime(AWSLambda.java:206) at lambdainternal.AWSLambda.main(AWSLambda.java:200) END RequestId: 11f8a8d0-2db1-48b2-a39d-5e15caea30c9 REPORT RequestId: 11f8a8d0-2db1-48b2-a39d-5e15caea30c9 Init Duration: 0.16 ms Duration: 3012.45 ms Billed Duration: 3013 ms Memory Size: 512 MB Max Memory Used: 512 MB No Content-Type given. Defaulting to 'application/json'. 2022-06-27 13:18:36 127.0.0.1 - - [27/Jun/2022 13:18:36] "GET /hello/greeting/awslocal HTTP/1.1" 500 - ``` ### How to Reproduce? _No response_ ### Output of `uname -a` or `ver` Darwin Daniels-MacBook-Pro 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22 PDT 2022; root:xnu-8020.121.3~4/RELEASE_X86_64 x86_64 ### Output of `java -version` openjdk version "11.0.10" 2021-01-19 OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.10+9) OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.10+9, mixed mode) ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.10.0.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Apache Maven 3.8.4 ### Additional information _No response_

cc52692e75dbad784eeb53fd7da135c2292e135c

21306dbabe2e77bd99c5f71b440d9699e24d9c65

https://github.com/quarkusio/quarkus/compare/cc52692e75dbad784eeb53fd7da135c2292e135c...21306dbabe2e77bd99c5f71b440d9699e24d9c65

diff --git a/extensions/amazon-lambda-http/http-event-server/src/main/java/io/quarkus/amazon/lambda/runtime/MockHttpEventServer.java b/extensions/amazon-lambda-http/http-event-server/src/main/java/io/quarkus/amazon/lambda/runtime/MockHttpEventServer.java index 9ee81290fab..cd6bfb7308c 100644 --- a/extensions/amazon-lambda-http/http-event-server/src/main/java/io/quarkus/amazon/lambda/runtime/MockHttpEventServer.java +++ b/extensions/amazon-lambda-http/http-event-server/src/main/java/io/quarkus/amazon/lambda/runtime/MockHttpEventServer.java @@ -56,6 +56,7 @@ public void handleHttpRequests(RoutingContext ctx) { event.setRequestContext(new APIGatewayV2HTTPEvent.RequestContext()); event.getRequestContext().setHttp(new APIGatewayV2HTTPEvent.RequestContext.Http()); event.getRequestContext().getHttp().setMethod(ctx.request().method().name()); + event.getRequestContext().getHttp().setSourceIp(ctx.request().connection().remoteAddress().hostAddress()); event.setRawPath(ctx.request().path()); event.setRawQueryString(ctx.request().query()); for (String header : ctx.request().headers().names()) { diff --git a/extensions/amazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java b/extensions/amazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java index 765e31a7e29..53294384a01 100644 --- a/extensions/amazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java +++ b/extensions/amazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java @@ -4,7 +4,6 @@ import java.io.ByteArrayOutputStream; import java.net.InetSocketAddress; -import java.net.URL; import java.nio.channels.Channels; import java.nio.channels.WritableByteChannel; import java.nio.charset.StandardCharsets; @@ -36,7 +35,6 @@ import io.netty.handler.codec.http.HttpVersion; import io.netty.handler.codec.http.LastHttpContent; import io.netty.util.ReferenceCountUtil; -import io.quarkus.amazon.lambda.runtime.AmazonLambdaContext; import io.quarkus.netty.runtime.virtual.VirtualClientConnection; import io.quarkus.netty.runtime.virtual.VirtualResponseHandler; import io.quarkus.vertx.http.runtime.QuarkusHttpHeaders; @@ -67,7 +65,7 @@ public APIGatewayV2HTTPResponse handleRequest(APIGatewayV2HTTPEvent request, Con } try { - return nettyDispatch(clientAddress, request, (AmazonLambdaContext) context); + return nettyDispatch(clientAddress, request, context); } catch (Exception e) { log.error("Request Failure", e); APIGatewayV2HTTPResponse res = new APIGatewayV2HTTPResponse(); @@ -168,7 +166,7 @@ public void close() { } private APIGatewayV2HTTPResponse nettyDispatch(InetSocketAddress clientAddress, APIGatewayV2HTTPEvent request, - AmazonLambdaContext context) + Context context) throws Exception { QuarkusHttpHeaders quarkusHeaders = new QuarkusHttpHeaders(); quarkusHeaders.setContextObject(Context.class, context); @@ -223,12 +221,19 @@ httpMethod, ofNullable(request.getRawQueryString()) NettyResponseHandler handler = new NettyResponseHandler(request); VirtualClientConnection connection = VirtualClientConnection.connect(handler, VertxHttpRecorder.VIRTUAL_HTTP, clientAddress); - if (connection.peer().remoteAddress().equals(VertxHttpRecorder.VIRTUAL_HTTP)) { - URL requestURL = context.getRequestURL(); + if (request.getRequestContext() != null + && request.getRequestContext().getHttp() != null + && request.getRequestContext().getHttp().getSourceIp() != null + && request.getRequestContext().getHttp().getSourceIp().length() > 0) { + int port = 443; // todo, may be bad to assume 443? + if (request.getHeaders() != null && + request.getHeaders().get("X-Forwarded-Port") != null) { + port = Integer.parseInt(request.getHeaders().get("X-Forwarded-Port")); + } connection.peer().attr(ConnectionBase.REMOTE_ADDRESS_OVERRIDE).set( - SocketAddress.inetSocketAddress(requestURL.getPort(), requestURL.getHost())); + SocketAddress.inetSocketAddress(port, + request.getRequestContext().getHttp().getSourceIp())); } - connection.sendMessage(nettyRequest); connection.sendMessage(requestContent); try { diff --git a/extensions/amazon-lambda-rest/rest-event-server/src/main/java/io/quarkus/amazon/lambda/runtime/MockRestEventServer.java b/extensions/amazon-lambda-rest/rest-event-server/src/main/java/io/quarkus/amazon/lambda/runtime/MockRestEventServer.java index b19ed5d533b..9b2a6e684b6 100644 --- a/extensions/amazon-lambda-rest/rest-event-server/src/main/java/io/quarkus/amazon/lambda/runtime/MockRestEventServer.java +++ b/extensions/amazon-lambda-rest/rest-event-server/src/main/java/io/quarkus/amazon/lambda/runtime/MockRestEventServer.java @@ -16,6 +16,7 @@ import com.fasterxml.jackson.databind.ObjectReader; import com.fasterxml.jackson.databind.ObjectWriter; +import io.quarkus.amazon.lambda.http.model.ApiGatewayRequestIdentity; import io.quarkus.amazon.lambda.http.model.AwsProxyRequest; import io.quarkus.amazon.lambda.http.model.AwsProxyRequestContext; import io.quarkus.amazon.lambda.http.model.AwsProxyResponse; @@ -61,6 +62,8 @@ public void handleHttpRequests(RoutingContext ctx) { event.setRequestContext(new AwsProxyRequestContext()); event.getRequestContext().setRequestId(requestId); event.getRequestContext().setHttpMethod(ctx.request().method().name()); + event.getRequestContext().setIdentity(new ApiGatewayRequestIdentity()); + event.getRequestContext().getIdentity().setSourceIp(ctx.request().connection().remoteAddress().hostAddress()); event.setHttpMethod(ctx.request().method().name()); event.setPath(ctx.request().path()); if (ctx.request().query() != null) { diff --git a/extensions/amazon-lambda-rest/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java b/extensions/amazon-lambda-rest/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java index 9a3fe62c13d..bb8c1b576e4 100644 --- a/extensions/amazon-lambda-rest/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java +++ b/extensions/amazon-lambda-rest/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java @@ -2,7 +2,6 @@ import java.io.ByteArrayOutputStream; import java.net.InetSocketAddress; -import java.net.URL; import java.net.URLEncoder; import java.nio.channels.Channels; import java.nio.channels.WritableByteChannel; @@ -34,7 +33,6 @@ import io.quarkus.amazon.lambda.http.model.AwsProxyRequestContext; import io.quarkus.amazon.lambda.http.model.AwsProxyResponse; import io.quarkus.amazon.lambda.http.model.Headers; -import io.quarkus.amazon.lambda.runtime.AmazonLambdaContext; import io.quarkus.netty.runtime.virtual.VirtualClientConnection; import io.quarkus.netty.runtime.virtual.VirtualResponseHandler; import io.quarkus.vertx.http.runtime.QuarkusHttpHeaders; @@ -62,7 +60,7 @@ public AwsProxyResponse handleRequest(AwsProxyRequest request, Context context) } try { - return nettyDispatch(clientAddress, request, (AmazonLambdaContext) context); + return nettyDispatch(clientAddress, request, context); } catch (Exception e) { log.error("Request Failure", e); return new AwsProxyResponse(500, errorHeaders, "{ \\"message\\": \\"Internal Server Error\\" }"); @@ -152,7 +150,7 @@ public void close() { } private AwsProxyResponse nettyDispatch(InetSocketAddress clientAddress, AwsProxyRequest request, - AmazonLambdaContext context) + Context context) throws Exception { String path = request.getPath(); //log.info("---- Got lambda request: " + path); @@ -210,10 +208,17 @@ private AwsProxyResponse nettyDispatch(InetSocketAddress clientAddress, AwsProxy NettyResponseHandler handler = new NettyResponseHandler(request); VirtualClientConnection connection = VirtualClientConnection.connect(handler, VertxHttpRecorder.VIRTUAL_HTTP, clientAddress); - if (connection.peer().remoteAddress().equals(VertxHttpRecorder.VIRTUAL_HTTP)) { - URL requestURL = context.getRequestURL(); + if (request.getRequestContext() != null + && request.getRequestContext().getIdentity() != null + && request.getRequestContext().getIdentity().getSourceIp() != null + && request.getRequestContext().getIdentity().getSourceIp().length() > 0) { + int port = 443; // todo, may be bad to assume 443? + if (request.getMultiValueHeaders() != null && + request.getMultiValueHeaders().getFirst("X-Forwarded-Port") != null) { + port = Integer.parseInt(request.getMultiValueHeaders().getFirst("X-Forwarded-Port")); + } connection.peer().attr(ConnectionBase.REMOTE_ADDRESS_OVERRIDE).set( - SocketAddress.inetSocketAddress(requestURL.getPort(), requestURL.getHost())); + SocketAddress.inetSocketAddress(port, request.getRequestContext().getIdentity().getSourceIp())); } connection.sendMessage(nettyRequest); diff --git a/extensions/amazon-lambda/common-runtime/src/main/java/io/quarkus/amazon/lambda/runtime/AmazonLambdaContext.java b/extensions/amazon-lambda/common-runtime/src/main/java/io/quarkus/amazon/lambda/runtime/AmazonLambdaContext.java index 02b006d9024..946bcb46f3a 100644 --- a/extensions/amazon-lambda/common-runtime/src/main/java/io/quarkus/amazon/lambda/runtime/AmazonLambdaContext.java +++ b/extensions/amazon-lambda/common-runtime/src/main/java/io/quarkus/amazon/lambda/runtime/AmazonLambdaContext.java @@ -13,7 +13,6 @@ import java.io.IOException; import java.net.HttpURLConnection; -import java.net.URL; import com.amazonaws.services.lambda.runtime.ClientContext; import com.amazonaws.services.lambda.runtime.CognitoIdentity; @@ -35,7 +34,6 @@ public class AmazonLambdaContext implements Context { private long runtimeDeadlineMs = 0; private final int memoryLimitInMB; private final LambdaLogger logger; - private final URL requestURL; public AmazonLambdaContext(HttpURLConnection request, ObjectReader cognitoReader, ObjectReader clientCtxReader) throws IOException { @@ -64,7 +62,6 @@ public AmazonLambdaContext(HttpURLConnection request, ObjectReader cognitoReader runtimeDeadlineMs = Long.valueOf(runtimeDeadline); } logger = LambdaRuntime.getLogger(); - requestURL = request.getURL(); } @Override @@ -121,8 +118,4 @@ public int getMemoryLimitInMB() { public LambdaLogger getLogger() { return logger; } - - public URL getRequestURL() { - return requestURL; - } }

['extensions/amazon-lambda/common-runtime/src/main/java/io/quarkus/amazon/lambda/runtime/AmazonLambdaContext.java', 'extensions/amazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java', 'extensions/amazon-lambda-http/http-event-server/src/main/java/io/quarkus/amazon/lambda/runtime/MockHttpEventServer.java', 'extensions/amazon-lambda-rest/rest-event-server/src/main/java/io/quarkus/amazon/lambda/runtime/MockRestEventServer.java', 'extensions/amazon-lambda-rest/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java']

{'.java': 5}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/26465/26455

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/26455

https://github.com/quarkusio/quarkus/pull/26465

https://github.com/quarkusio/quarkus/pull/26465

fix

[reactive-pg-client] NullPointerException in PgPoolRecorder.java

### Describe the bug When migrating from `2.9.2.Final` to `2.10.1.Final` the tests for one of my applications started failing due to a NullPointerException: ``` java.lang.RuntimeException: Failed to start quarkus at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source) at io.quarkus.runtime.Application.start(Application.java:101) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.runner.bootstrap.StartupActionImpl.run(StartupActionImpl.java:237) at io.quarkus.test.junit.QuarkusTestExtension.doJavaStart(QuarkusTestExtension.java:250) at io.quarkus.test.junit.QuarkusTestExtension.ensureStarted(QuarkusTestExtension.java:609) at io.quarkus.test.junit.QuarkusTestExtension.beforeAll(QuarkusTestExtension.java:647) ... 35 more Caused by: java.lang.NullPointerException at io.quarkus.reactive.pg.client.runtime.PgPoolRecorder.toPgConnectOptions(PgPoolRecorder.java:193) at io.quarkus.reactive.pg.client.runtime.PgPoolRecorder.initialize(PgPoolRecorder.java:68) at io.quarkus.reactive.pg.client.runtime.PgPoolRecorder.configurePgPool(PgPoolRecorder.java:47) at io.quarkus.deployment.steps.ReactivePgClientProcessor$build897843755.deploy_0(Unknown Source) at io.quarkus.deployment.steps.ReactivePgClientProcessor$build897843755.deploy(Unknown Source) ... 51 more ``` The cause seems to be that `dataSourceReactiveRuntimeConfig.additionalProperties` can be null, so when it hits this line it fails: https://github.com/quarkusio/quarkus/blob/3ad7cd0ec6a2297ccda5759b5acb22741d147d37/extensions/reactive-pg-client/runtime/src/main/java/io/quarkus/reactive/pg/client/runtime/PgPoolRecorder.java#L193 ### Expected behavior The application starts up successfully. ### Actual behavior The application fails. ### How to Reproduce? I cannot share a reproducer at this time because the code belongs to my company and it would be difficult to recreate. However, based on my troubleshooting the issue seems to triggered with this configuration: ```yaml "%test": quarkus: datasource: app: db-kind: postgresql devservices: enabled: true image-name: postgres:14 username: "quarkus" password: "quarkus" migration: db-kind: postgresql # This is an awkward workaround to prevent multiple instances of DevServices running. jdbc: url: "${quarkus.datasource.\\"app\\".jdbc.url}" username: "quarkus" password: "quarkus" flyway: migration: # settings ``` > **Aside**: Having two separate datasources is an awkward workaround run Flyway migrations as a separate user from the standard application operations. For tests it doesn't matter. > > Ideally, it'd be possible to specify different credentials in the URL for reactive and JDBC, or make it so reactive/jdbc can be disabled per data source. I'll probably make a separate issue about this...) When `PgPoolRecorder.configurePgPool` is called for the "app" datasource, `dataSourceReactiveRuntimeConfig.additionalProperties` is empty. However, when it's called for the `migration` datasource,`dataSourceReactiveRuntimeConfig.additionalProperties` is null. The straightforward solution would be to surround this with a null check. But the fact that it's `null` in the first place may be a bug. _Edit:_ if it's expected that `additionalProperties` can be null, the null check would need to be added to all pool recorders. https://github.com/quarkusio/quarkus/commit/dccb8d968a1ba9e387439de187e91aca7d2053c8 ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` 11.0.12 ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.10.1.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) 3.8.5 ### Additional information _No response_

b0ba511c5ff55652f2e3f1e55635ded6d83d2d73

7891b61b18e12d5a5ffaa246b87fcff81927f817

https://github.com/quarkusio/quarkus/compare/b0ba511c5ff55652f2e3f1e55635ded6d83d2d73...7891b61b18e12d5a5ffaa246b87fcff81927f817

diff --git a/extensions/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/DataSourceJdbcRuntimeConfig.java b/extensions/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/DataSourceJdbcRuntimeConfig.java index 9d6601482a5..1c07a501cf7 100644 --- a/extensions/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/DataSourceJdbcRuntimeConfig.java +++ b/extensions/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/DataSourceJdbcRuntimeConfig.java @@ -1,6 +1,7 @@ package io.quarkus.agroal.runtime; import java.time.Duration; +import java.util.Collections; import java.util.Map; import java.util.Optional; import java.util.OptionalInt; @@ -130,18 +131,18 @@ public class DataSourceJdbcRuntimeConfig { * validation. Setting this setting to STRICT may lead to failures in those cases. */ @ConfigItem - public Optional<AgroalConnectionPoolConfiguration.TransactionRequirement> transactionRequirement; + public Optional<AgroalConnectionPoolConfiguration.TransactionRequirement> transactionRequirement = Optional.empty(); /** * Other unspecified properties to be passed to the JDBC driver when creating new connections. */ @ConfigItem - public Map<String, String> additionalJdbcProperties; + public Map<String, String> additionalJdbcProperties = Collections.emptyMap(); /** * Enable JDBC tracing. */ @ConfigItem - public DataSourceJdbcTracingRuntimeConfig tracing; + public DataSourceJdbcTracingRuntimeConfig tracing = new DataSourceJdbcTracingRuntimeConfig(); } diff --git a/extensions/reactive-datasource/runtime/src/main/java/io/quarkus/reactive/datasource/runtime/DataSourceReactiveRuntimeConfig.java b/extensions/reactive-datasource/runtime/src/main/java/io/quarkus/reactive/datasource/runtime/DataSourceReactiveRuntimeConfig.java index 831a2bf172e..5a8b6480203 100644 --- a/extensions/reactive-datasource/runtime/src/main/java/io/quarkus/reactive/datasource/runtime/DataSourceReactiveRuntimeConfig.java +++ b/extensions/reactive-datasource/runtime/src/main/java/io/quarkus/reactive/datasource/runtime/DataSourceReactiveRuntimeConfig.java @@ -1,6 +1,7 @@ package io.quarkus.reactive.datasource.runtime; import java.time.Duration; +import java.util.Collections; import java.util.Map; import java.util.Optional; import java.util.OptionalInt; @@ -145,12 +146,12 @@ public class DataSourceReactiveRuntimeConfig { * Set the pool name, used when the pool is shared among datasources, otherwise ignored. */ @ConfigItem - public Optional<String> name; + public Optional<String> name = Optional.empty(); /** * Other unspecified properties to be passed through the Reactive SQL Client directly to the database when new connections * are initiated. */ @ConfigItem - public Map<String, String> additionalProperties; + public Map<String, String> additionalProperties = Collections.emptyMap(); }

['extensions/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/DataSourceJdbcRuntimeConfig.java', 'extensions/reactive-datasource/runtime/src/main/java/io/quarkus/reactive/datasource/runtime/DataSourceReactiveRuntimeConfig.java']

{'.java': 2}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/26477/26476

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/26476

https://github.com/quarkusio/quarkus/pull/26477

https://github.com/quarkusio/quarkus/pull/26477

closes

Using "mvn install" a second time throws "FileAlreadyExistsException: .../target/lib/../providers/.keep"

### Describe the bug When I run `mvn install` a second time on my project ([keycloak](https://github.com/keycloak/keycloak)), complains that the `.keep` file exists. ### Expected behavior Run should continue. ### Actual behavior Exception being thrown. ``` [ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:2.7.6.Final:build (default) on project keycloak-quarkus-server-app: Failed to build quarkus application: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [ERROR] [error]: Build step io.quarkus.deployment.pkg.steps.JarResultBuildStep#buildRunnerJar threw an exception: java.lang.IllegalStateException: java.nio.file.FileAlreadyExistsException: /***/keycloak/quarkus/server/target/lib/../providers/.keep [ERROR] at io.quarkus.deployment.ExtensionLoader$2.execute(ExtensionLoader.java:891) [ERROR] at io.quarkus.builder.BuildContext.run(BuildContext.java:277) [ERROR] at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) [ERROR] at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) [ERROR] at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) [ERROR] at java.base/java.lang.Thread.run(Thread.java:829) [ERROR] at org.jboss.threads.JBossThread.run(JBossThread.java:501) [ERROR] Caused by: java.nio.file.FileAlreadyExistsException: /home/aschwart/redhat/workspace/keycloak-pr-2/quarkus/server/target/lib/../providers/.keep [ERROR] at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:94) [ERROR] at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111) [ERROR] at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:116) [ERROR] at java.base/sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:219) [ERROR] at java.base/java.nio.file.Files.newByteChannel(Files.java:371) [ERROR] at java.base/java.nio.file.Files.createFile(Files.java:648) [ERROR] at io.quarkus.deployment.pkg.steps.JarResultBuildStep.buildThinJar(JarResultBuildStep.java:571) [ERROR] at io.quarkus.deployment.pkg.steps.JarResultBuildStep.buildRunnerJar(JarResultBuildStep.java:218) [ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [ERROR] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [ERROR] at java.base/java.lang.reflect.Method.invoke(Method.java:566) [ERROR] at io.quarkus.deployment.ExtensionLoader$2.execute(ExtensionLoader.java:882) [ERROR] ... 6 more ``` ### How to Reproduce? 1. checkout project 2. run `mvn install` 3. run `mvn install` again -> Exception appears ### Output of `uname -a` or `ver` Linux fedora 5.18.7-100.fc35.x86_64 #1 SMP PREEMPT_DYNAMIC Sat Jun 25 20:05:19 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux ### Output of `java -version` openjdk 11.0.13 2021-10-19 LTS OpenJDK Runtime Environment Corretto-11.0.13.8.1 (build 11.0.13+8-LTS) OpenJDK 64-Bit Server VM Corretto-11.0.13.8.1 (build 11.0.13+8-LTS, mixed mode) ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.7.6.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) Maven home: /home/aschwart/apache-maven-3.8.4 Java version: 11.0.13, vendor: Amazon.com Inc., runtime: /home/aschwart/.jdks/corretto-11.0.13 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.18.7-100.fc35.x86_64", arch: "amd64", family: "unix" ### Additional information PR available as a fix #26477

0025aff6418a09d1ae91fcfdb9d4d9c16685ac78

65270ab04074d0957b10c6f1db92833680344e79

https://github.com/quarkusio/quarkus/compare/0025aff6418a09d1ae91fcfdb9d4d9c16685ac78...65270ab04074d0957b10c6f1db92833680344e79

diff --git a/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/JarResultBuildStep.java b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/JarResultBuildStep.java index 9486104637b..a1c9d0dbeb2 100644 --- a/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/JarResultBuildStep.java +++ b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/JarResultBuildStep.java @@ -567,7 +567,11 @@ private JarBuildItem buildThinJar(CurateOutcomeBuildItem curateOutcomeBuildItem, Files.createDirectories(userProviders); //we add this dir so that it can be copied into container images if required //and will still be copied even if empty - Files.createFile(userProviders.resolve(".keep")); + Path keepFile = userProviders.resolve(".keep"); + if (!keepFile.toFile().exists()) { + // check if the file exists to avoid a FileAlreadyExistsException + Files.createFile(keepFile); + } } } else { IoUtils.createOrEmptyDir(quarkus);

['core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/JarResultBuildStep.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25407/24931

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/24931

https://github.com/quarkusio/quarkus/pull/25407

https://github.com/quarkusio/quarkus/pull/25407

fixes

NullPointerException with Quartz and Quarkus 2.8.0.Final when a job identity is changed

### Describe the bug After updating to Quarkus 2.8.0.Final, one of our scheduled tasks failed with an exception I've not seen before and that seems to be coming from Quarkus: ``` org.quartz.SchedulerException: Job threw an unhandled exception. [See nested exception: java.lang.NullPointerException: Cannot read field "invoker" because "this.trigger" is null] at org.quartz.core.JobRunShell.run(JobRunShell.java:213) at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:573) Caused by: java.lang.NullPointerException: Cannot read field "invoker" because "this.trigger" is null at io.quarkus.quartz.runtime.QuartzScheduler$InvokerJob.execute(QuartzScheduler.java:553) at org.quartz.core.JobRunShell.run(JobRunShell.java:202) at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:573) ``` Application is deployed as an uber-jar. ### Expected behavior No NullPointerException is thrown when scheduling jobs ### Actual behavior _No response_ ### How to Reproduce? _No response_ ### Output of `uname -a` or `ver` RHEL 8 Linux ### Output of `java -version` 17.0.2 ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.8.0.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Gradle 7.4.1 ### Additional information _No response_

4df39b60a0b3d132713e6d60087a1054588d4a5f

c4aa8948da8bc78aa7560a7596b1898961aea0cc

https://github.com/quarkusio/quarkus/compare/4df39b60a0b3d132713e6d60087a1054588d4a5f...c4aa8948da8bc78aa7560a7596b1898961aea0cc

diff --git a/extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java b/extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java index ec68f58ae00..22e65c5c55b 100644 --- a/extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java +++ b/extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java @@ -277,8 +277,8 @@ public QuartzScheduler(SchedulerContext context, QuartzSupport quartzSupport, Sc org.quartz.Trigger trigger = triggerBuilder.build(); org.quartz.Trigger oldTrigger = scheduler.getTrigger(trigger.getKey()); if (oldTrigger != null) { - scheduler.rescheduleJob(trigger.getKey(), - triggerBuilder.startAt(oldTrigger.getNextFireTime()).build()); + trigger = triggerBuilder.startAt(oldTrigger.getNextFireTime()).build(); + scheduler.rescheduleJob(trigger.getKey(), trigger); LOGGER.debugf("Rescheduled business method %s with config %s", method.getMethodDescription(), scheduled); } else if (!scheduler.checkExists(jobDetail.getKey())) { @@ -292,7 +292,8 @@ public QuartzScheduler(SchedulerContext context, QuartzSupport quartzSupport, Sc oldTrigger = scheduler.getTrigger(new TriggerKey(identity + "_trigger", Scheduler.class.getName())); if (oldTrigger != null) { scheduler.deleteJob(jobDetail.getKey()); - scheduler.scheduleJob(jobDetail, triggerBuilder.startAt(oldTrigger.getNextFireTime()).build()); + trigger = triggerBuilder.startAt(oldTrigger.getNextFireTime()).build(); + scheduler.scheduleJob(jobDetail, trigger); LOGGER.debugf( "Rescheduled business method %s with config %s due to Trigger '%s' record being renamed after removal of '_trigger' suffix", method.getMethodDescription(), @@ -558,7 +559,7 @@ static class InvokerJob implements Job { @Override public void execute(JobExecutionContext jobExecutionContext) throws JobExecutionException { - if (trigger.invoker != null) { // could be null from previous runs + if (trigger != null && trigger.invoker != null) { // could be null from previous runs if (trigger.invoker.isBlocking()) { try { trigger.invoker.invoke(new QuartzScheduledExecution(trigger, jobExecutionContext)); @@ -579,6 +580,11 @@ public void handle(Void event) { } }); } + } else { + String jobName = jobExecutionContext.getJobDetail().getKey().getName(); + LOGGER.warnf("Unable to find corresponding Quartz trigger for job %s. " + + "Update your Quartz table by removing all phantom jobs or make sure that there is a " + + "Scheduled method with the identity matching the job's name", jobName); } } }

['extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25401/25186

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25186

https://github.com/quarkusio/quarkus/pull/25401

https://github.com/quarkusio/quarkus/pull/25401

fixes

Config quarkus.config.locations is evaluated before applying profile

### Describe the bug Hello, the config `quarkus.config.locations` is evaluated before applying the profile. ~~~ quarkus.config.locations=file1.properties %test.quarkus.config.locations=file1.properties,file2.properties ~~~ Launching tests, the "Test" profile is activated AFTER the `quarkus.config.locations` property being read. Thus `file2.properties` is not getting loaded. But if you read the property via `@ConfigProperty(name = "quarkus.config.locations")`, the value is correct. ### Expected behavior `%test.quarkus.config.locations` should be evaluated during tests ### Actual behavior the default `quarkus.config.locations` property is evaluated ### How to Reproduce? The bug is not reproducible using `@ConfigProperty(name = "quarkus.config.locations")`, that way the property is correctly read. In order to reproduce you need to read a property declared in the not-loaded-config-file. ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` 17.0.1 ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.8.0 ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) 3.8.4 ### Additional information _No response_

56db32ea9fd6deba7a3a7b03877971b70b85efda

dca684fff7497d27ebd53a8fcbcae35ad2b523a3

https://github.com/quarkusio/quarkus/compare/56db32ea9fd6deba7a3a7b03877971b70b85efda...dca684fff7497d27ebd53a8fcbcae35ad2b523a3

diff --git a/core/runtime/src/main/java/io/quarkus/runtime/configuration/ConfigUtils.java b/core/runtime/src/main/java/io/quarkus/runtime/configuration/ConfigUtils.java index 890376d39b1..5923c5c8492 100644 --- a/core/runtime/src/main/java/io/quarkus/runtime/configuration/ConfigUtils.java +++ b/core/runtime/src/main/java/io/quarkus/runtime/configuration/ConfigUtils.java @@ -142,6 +142,8 @@ public ConfigSourceInterceptor getInterceptor(final ConfigSourceInterceptorConte if (profileValue != null) { List<String> profiles = ProfileConfigSourceInterceptor.convertProfile(profileValue.getValue()); for (String profile : profiles) { + relocations.put("%" + profile + "." + SMALLRYE_CONFIG_LOCATIONS, + "%" + profile + "." + "quarkus.config.locations"); relocations.put("%" + profile + "." + SMALLRYE_CONFIG_PROFILE_PARENT, "%" + profile + "." + "quarkus.config.profile.parent"); }

['core/runtime/src/main/java/io/quarkus/runtime/configuration/ConfigUtils.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/30976/30965

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/30965

https://github.com/quarkusio/quarkus/pull/30976

https://github.com/quarkusio/quarkus/pull/30976

fixes

JandexBeanInfoAdapter.getMetricAnnotationsThroughStereotype is not null safe

### Describe the bug We have a problem during the build process of our project. This problem appeared trying to bump quarkus.version from 2.13.3.Final to 2.16.1.Final. After some debugging we found the real problem. We have a class that uses the `@gauge` annotation, this is what triggered the `JandexBeanInfoAdapter.convert`. During the annotation mapping process, there are other annotations found on the same class, and the annotation causing this NullPointerExpection is `edu.umd.cs.findbugs.annotations.SuppressFBWarnings`. The NullPointer happens in this line of code: https://github.com/quarkusio/quarkus/blob/e48aace483cf24d24b566b5786731e98351a7027/extensions/smallrye-metrics/deployment/src/main/java/io/quarkus/smallrye/metrics/deployment/jandex/JandexBeanInfoAdapter.java#L71 Shouldn't it be null safe ? ``` Caused by: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.smallrye.metrics.deployment.SmallRyeMetricsProcessor#registerMetricsFromAnnotatedMethods threw an exception: java.lang.NullPointerException: Cannot invoke "org.jboss.jandex.ClassInfo.classAnnotation(org.jboss.jandex.DotName)" because "annotationType" is null at io.quarkus.smallrye.metrics.deployment.jandex.JandexBeanInfoAdapter.getMetricAnnotationsThroughStereotype(JandexBeanInfoAdapter.java:71) at io.quarkus.smallrye.metrics.deployment.jandex.JandexBeanInfoAdapter.lambda$convert$0(JandexBeanInfoAdapter.java:55) at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:273) at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) at io.quarkus.smallrye.metrics.deployment.jandex.JandexBeanInfoAdapter.convert(JandexBeanInfoAdapter.java:56) at io.quarkus.smallrye.metrics.deployment.SmallRyeMetricsProcessor.registerMetricsFromAnnotatedMethods(SmallRyeMetricsProcessor.java:404) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909) at io.quarkus.builder.BuildContext.run(BuildContext.java:281) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:833) at org.jboss.threads.JBossThread.run(JBossThread.java:501) at io.quarkus.builder.Execution.run (Execution.java:123) at io.quarkus.builder.BuildExecutionBuilder.execute (BuildExecutionBuilder.java:79) at io.quarkus.deployment.QuarkusAugmentor.run (QuarkusAugmentor.java:160) at io.quarkus.runner.bootstrap.AugmentActionImpl.runAugment (AugmentActionImpl.java:331) at io.quarkus.runner.bootstrap.AugmentActionImpl.createProductionApplication (AugmentActionImpl.java:175) at io.quarkus.maven.BuildMojo.doExecute (BuildMojo.java:133) at io.quarkus.maven.QuarkusBootstrapMojo.execute (QuarkusBootstrapMojo.java:154) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289) at org.apache.maven.cli.MavenCli.main (MavenCli.java:193) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:568) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) Caused by: java.lang.NullPointerException: Cannot invoke "org.jboss.jandex.ClassInfo.classAnnotation(org.jboss.jandex.DotName)" because "annotationType" is null at io.quarkus.smallrye.metrics.deployment.jandex.JandexBeanInfoAdapter.getMetricAnnotationsThroughStereotype (JandexBeanInfoAdapter.java:71) at io.quarkus.smallrye.metrics.deployment.jandex.JandexBeanInfoAdapter.lambda$convert$0 (JandexBeanInfoAdapter.java:55) at java.util.stream.ReferencePipeline$7$1.accept (ReferencePipeline.java:273) at java.util.ArrayList$ArrayListSpliterator.forEachRemaining (ArrayList.java:1625) at java.util.stream.AbstractPipeline.copyInto (AbstractPipeline.java:509) at java.util.stream.AbstractPipeline.wrapAndCopyInto (AbstractPipeline.java:499) at java.util.stream.ReduceOps$ReduceOp.evaluateSequential (ReduceOps.java:921) at java.util.stream.AbstractPipeline.evaluate (AbstractPipeline.java:234) at java.util.stream.ReferencePipeline.collect (ReferencePipeline.java:682) at io.quarkus.smallrye.metrics.deployment.jandex.JandexBeanInfoAdapter.convert (JandexBeanInfoAdapter.java:56) at io.quarkus.smallrye.metrics.deployment.SmallRyeMetricsProcessor.registerMetricsFromAnnotatedMethods (SmallRyeMetricsProcessor.java:404) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:568) at io.quarkus.deployment.ExtensionLoader$3.execute (ExtensionLoader.java:909) at io.quarkus.builder.BuildContext.run (BuildContext.java:281) at org.jboss.threads.ContextHandler$1.runWith (ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run (EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run (EnhancedQueueExecutor.java:1478) at java.lang.Thread.run (Thread.java:833) at org.jboss.threads.JBossThread.run (JBossThread.java:501) ``` ### Expected behavior Build succeeds. ### Actual behavior ``` Caused by: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.smallrye.metrics.deployment.SmallRyeMetricsProcessor#registerMetricsFromAnnotatedMethods threw an exception: java.lang.NullPointerException: Cannot invoke "org.jboss.jandex.ClassInfo.classAnnotation(org.jboss.jandex.DotName)" because "annotationType" is null at io.quarkus.smallrye.metrics.deployment.jandex.JandexBeanInfoAdapter.getMetricAnnotationsThroughStereotype(JandexBeanInfoAdapter.java:71) at io.quarkus.smallrye.metrics.deployment.jandex.JandexBeanInfoAdapter.lambda$convert$0(JandexBeanInfoAdapter.java:55) at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:273) at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) at io.quarkus.smallrye.metrics.deployment.jandex.JandexBeanInfoAdapter.convert(JandexBeanInfoAdapter.java:56) at io.quarkus.smallrye.metrics.deployment.SmallRyeMetricsProcessor.registerMetricsFromAnnotatedMethods(SmallRyeMetricsProcessor.java:404) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909) at io.quarkus.builder.BuildContext.run(BuildContext.java:281) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:833) at org.jboss.threads.JBossThread.run(JBossThread.java:501) at io.quarkus.builder.Execution.run (Execution.java:123) at io.quarkus.builder.BuildExecutionBuilder.execute (BuildExecutionBuilder.java:79) at io.quarkus.deployment.QuarkusAugmentor.run (QuarkusAugmentor.java:160) at io.quarkus.runner.bootstrap.AugmentActionImpl.runAugment (AugmentActionImpl.java:331) at io.quarkus.runner.bootstrap.AugmentActionImpl.createProductionApplication (AugmentActionImpl.java:175) at io.quarkus.maven.BuildMojo.doExecute (BuildMojo.java:133) at io.quarkus.maven.QuarkusBootstrapMojo.execute (QuarkusBootstrapMojo.java:154) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289) at org.apache.maven.cli.MavenCli.main (MavenCli.java:193) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:568) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) Caused by: java.lang.NullPointerException: Cannot invoke "org.jboss.jandex.ClassInfo.classAnnotation(org.jboss.jandex.DotName)" because "annotationType" is null at io.quarkus.smallrye.metrics.deployment.jandex.JandexBeanInfoAdapter.getMetricAnnotationsThroughStereotype (JandexBeanInfoAdapter.java:71) at io.quarkus.smallrye.metrics.deployment.jandex.JandexBeanInfoAdapter.lambda$convert$0 (JandexBeanInfoAdapter.java:55) at java.util.stream.ReferencePipeline$7$1.accept (ReferencePipeline.java:273) at java.util.ArrayList$ArrayListSpliterator.forEachRemaining (ArrayList.java:1625) at java.util.stream.AbstractPipeline.copyInto (AbstractPipeline.java:509) at java.util.stream.AbstractPipeline.wrapAndCopyInto (AbstractPipeline.java:499) at java.util.stream.ReduceOps$ReduceOp.evaluateSequential (ReduceOps.java:921) at java.util.stream.AbstractPipeline.evaluate (AbstractPipeline.java:234) at java.util.stream.ReferencePipeline.collect (ReferencePipeline.java:682) at io.quarkus.smallrye.metrics.deployment.jandex.JandexBeanInfoAdapter.convert (JandexBeanInfoAdapter.java:56) at io.quarkus.smallrye.metrics.deployment.SmallRyeMetricsProcessor.registerMetricsFromAnnotatedMethods (SmallRyeMetricsProcessor.java:404) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:568) at io.quarkus.deployment.ExtensionLoader$3.execute (ExtensionLoader.java:909) at io.quarkus.builder.BuildContext.run (BuildContext.java:281) at org.jboss.threads.ContextHandler$1.runWith (ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run (EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run (EnhancedQueueExecutor.java:1478) at java.lang.Thread.run (Thread.java:833) at org.jboss.threads.JBossThread.run (JBossThread.java:501) ``` ### How to Reproduce? _No response_ ### Output of `uname -a` or `ver` Linux nb1099 5.15.0-58-generic #64-Ubuntu SMP Thu Jan 5 11:43:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux ### Output of `java -version` openjdk 17 2021-09-14 OpenJDK Runtime Environment (build 17+35-2724) OpenJDK 64-Bit Server VM (build 17+35-2724, mixed mode, sharing) ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.16.1.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Maven home: /home/gprado/Development/apache-maven-3.6.3 Java version: 17, vendor: Oracle Corporation, runtime: /usr/java/jdk-17 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.15.0-58-generic", arch: "amd64", family: "unix" ### Additional information _No response_

f39380f6aa7ad111bfcbe892a3391f8b5a40dc29

3cb61b796b06df8971d10915163c34376a338ba6

https://github.com/quarkusio/quarkus/compare/f39380f6aa7ad111bfcbe892a3391f8b5a40dc29...3cb61b796b06df8971d10915163c34376a338ba6

diff --git a/extensions/smallrye-metrics/deployment/src/main/java/io/quarkus/smallrye/metrics/deployment/jandex/JandexBeanInfoAdapter.java b/extensions/smallrye-metrics/deployment/src/main/java/io/quarkus/smallrye/metrics/deployment/jandex/JandexBeanInfoAdapter.java index 0b4ff51813a..e33ffaf1142 100644 --- a/extensions/smallrye-metrics/deployment/src/main/java/io/quarkus/smallrye/metrics/deployment/jandex/JandexBeanInfoAdapter.java +++ b/extensions/smallrye-metrics/deployment/src/main/java/io/quarkus/smallrye/metrics/deployment/jandex/JandexBeanInfoAdapter.java @@ -68,7 +68,7 @@ public BeanInfo convert(ClassInfo input) { private Stream<AnnotationInfo> getMetricAnnotationsThroughStereotype(AnnotationInstance stereotypeInstance, IndexView indexView) { ClassInfo annotationType = indexView.getClassByName(stereotypeInstance.name()); - if (annotationType.classAnnotation(DotNames.STEREOTYPE) != null) { + if (annotationType != null && annotationType.declaredAnnotation(DotNames.STEREOTYPE) != null) { JandexAnnotationInfoAdapter adapter = new JandexAnnotationInfoAdapter(indexView); return transformedAnnotations.getAnnotations(annotationType) .stream()

['extensions/smallrye-metrics/deployment/src/main/java/io/quarkus/smallrye/metrics/deployment/jandex/JandexBeanInfoAdapter.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/24908/24739

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/24739

https://github.com/quarkusio/quarkus/pull/24908

https://github.com/quarkusio/quarkus/pull/24908

fix

Quarkus unix domain socket path no longer used but placed onto 0.0.0.0 instead

### Describe the bug Quarkus supports listening on a unix domain socket instead of a TCP socket for the HTTP server. The path for the socket is no longer correctly used. Config sample: https://quarkus.io/guides/vertx-reference#listening-to-a-unix-domain-socket https://quarkus.io/guides/all-config#quarkus-vertx-http_quarkus.http.domain-socket ```yaml quarkus.http.host-enabled = false quarkus.http.domain-socket = /var/run/io.quarkus.app.socket quarkus.http.domain-socket-enabled = true quarkus.vertx.prefer-native-transport = true ``` After upgrading to Quarkus 2.7.5 the unix domain socket is no longer correctly placed on the selected path location. Also the default path is not used. Quarkus startup log message prints: `(...) Listening on: unix:0.0.0.0` Also `netstat` shows that the domain socket is now placed on "0.0.0.0" instead of the proper path: `unix 2 [ ACC ] STREAM LISTENING 28944 1/java 0.0.0.0` ### Expected behavior The unix domain socket should be placed onto the correct path e.g. `/var/run/io.quarkus.app.socket`. ### Actual behavior The unix domain socket is always placed onto `0.0.0.0`. ### How to Reproduce? Reproducer: Generate a fresh Quarkus project and configure it to use a unix domain socket instead of TCP for the HTTP server. https://quarkus.io/guides/vertx-reference#listening-to-a-unix-domain-socket ### Output of `uname -a` or `ver` Linux 6832a73e6fed 5.10.104-linuxkit #1 SMP Wed Mar 9 19:05:23 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux ### Output of `java -version` openjdk 17.0.2 2022-01-18 LTS ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev Quarkus 2.7.5.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Apache Maven 3.8.5 ### Additional information _No response_

56879dde70ca4efaf65dd958392afeab9156f47f

161be3f3f56d5a43a26499e4c95576f32ed365bd

https://github.com/quarkusio/quarkus/compare/56879dde70ca4efaf65dd958392afeab9156f47f...161be3f3f56d5a43a26499e4c95576f32ed365bd

diff --git a/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java b/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java index 4736fb1e47e..8a043ce9bc0 100644 --- a/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java +++ b/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java @@ -906,6 +906,8 @@ private static HttpServerOptions createDomainSocketOptions(HttpConfiguration htt HttpServerOptions options = new HttpServerOptions(); applyCommonOptions(options, httpConfiguration, websocketSubProtocols); + // Override the host (0.0.0.0 by default) with the configured domain socket. + options.setHost(httpConfiguration.domainSocket); return options; } @@ -916,14 +918,6 @@ private static void setIdleTimeout(HttpConfiguration httpConfiguration, HttpServ options.setIdleTimeoutUnit(TimeUnit.MILLISECONDS); } - public void warnIfPortChanged(HttpConfiguration config, int port) { - if (config.port != port) { - LOGGER.errorf( - "quarkus.http.port was specified at build time as %s however run time value is %s, Kubernetes metadata will be incorrect.", - port, config.port); - } - } - public void addRoute(RuntimeValue<Router> router, Function<Router, Route> route, Handler<RoutingContext> handler, HandlerType blocking) {

['extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25004/24878

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/24878

https://github.com/quarkusio/quarkus/pull/25004

https://github.com/quarkusio/quarkus/pull/25004

fixes

`Unrecognized configuration key` warnings since 2.8.0.Final if using config property with list values in YAML

### Describe the bug ```yaml quarkus: arc: ignored-split-packages: - foo.bar ``` results in a build warning in 2.8.0.Final, but not in 2.7.5.Final: ``` [INFO] --- quarkus-maven-plugin:2.8.0.Final:build (default) @ code-with-quarkus --- [WARNING] [io.quarkus.config] Unrecognized configuration key "quarkus.arc.ignored-split-packages[0]" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo [INFO] [io.quarkus.deployment.QuarkusAugmentor] Quarkus augmentation completed in 1443ms ``` ### Expected behavior No warning, the key is valid. ### Actual behavior `Unrecognized configuration key` warning ### How to Reproduce? [q_build-warnings.zip](https://github.com/quarkusio/quarkus/files/8466095/q_build-warnings.zip) `mvn clean package -DskipTests` ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` 17.0.2, vendor: BellSoft ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.8.0.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Apache Maven 3.8.4 ### Additional information Also happens with e.g. `quarkus.qute.suffixes`. Does not happen when using `application.properties`.

7a246200f6987416ad741f4c70c56a575eba8794

c6679c27a4cd54ac34bc2c56a6f5b2aa176fc071

https://github.com/quarkusio/quarkus/compare/7a246200f6987416ad741f4c70c56a575eba8794...c6679c27a4cd54ac34bc2c56a6f5b2aa176fc071

diff --git a/core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java b/core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java index 167849ed1c3..be3f6406bce 100644 --- a/core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java +++ b/core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java @@ -200,9 +200,7 @@ private static void reportUnknownBuildProperties(LaunchMode launchMode, Set<Stri // So it only reports during the build, because it is very likely that the property is available in runtime // and, it will be caught by the RuntimeConfig and log double warnings if (!launchMode.isDevOrTest()) { - for (String unknownProperty : unknownBuildProperties) { - ConfigDiagnostic.unknown(unknownProperty); - } + ConfigDiagnostic.unknownProperties(new ArrayList<>(unknownBuildProperties)); } }

['core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25009/24939

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/24939

https://github.com/quarkusio/quarkus/pull/25009

https://github.com/quarkusio/quarkus/pull/25009

fix

Oracle Devservice fails to launch on hosts with over 100 CPU cores

### Describe the bug This is essentially the same issue as https://github.com/gvenzl/oci-oracle-xe/issues/64 but with _even more_ CPU cores. Since using that many cores is unreasonable anyway, and the upstream dockerfile seems to rely on an `if`-case for every CPU count, it might be better to implement a workaround along the lines of this: https://github.com/gvenzl/oci-oracle-xe/issues/64#issuecomment-1099107397 > Wouldn't docker run --cpus=2 option do the trick? https://docs.docker.com/config/containers/resource_constraints/#configure-the-default-cfs-scheduler Unless you really want to use more. ### Quarkus version or git rev 2.8.0 ### Additional information see https://github.com/gvenzl/oci-oracle-xe/issues/64#issuecomment-1087261618 for the error message that is currently happening on a 128 core machine.

027fa6424dc832106696137c8f1f34407be25a24

ce8391e557825b5139d0ee4057dc892538c3083d

https://github.com/quarkusio/quarkus/compare/027fa6424dc832106696137c8f1f34407be25a24...ce8391e557825b5139d0ee4057dc892538c3083d

diff --git a/extensions/devservices/oracle/src/main/java/io/quarkus/devservices/oracle/deployment/OracleDevServicesProcessor.java b/extensions/devservices/oracle/src/main/java/io/quarkus/devservices/oracle/deployment/OracleDevServicesProcessor.java index 3062fe714ba..80889956024 100644 --- a/extensions/devservices/oracle/src/main/java/io/quarkus/devservices/oracle/deployment/OracleDevServicesProcessor.java +++ b/extensions/devservices/oracle/src/main/java/io/quarkus/devservices/oracle/deployment/OracleDevServicesProcessor.java @@ -45,6 +45,14 @@ public RunningDevServicesDatasource startDatabase(Optional<String> username, Opt container.withUsername(username.orElse(DEFAULT_DATABASE_USER)) .withPassword(password.orElse(DEFAULT_DATABASE_PASSWORD)) .withDatabaseName(datasourceName.orElse(DEFAULT_DATABASE_NAME)); + + // We need to limit the maximum amount of CPUs being used by the container; + // otherwise the hardcoded memory configuration of the DB might not be enough to successfully boot it. + // See https://github.com/gvenzl/oci-oracle-xe/issues/64 + // I choose to limit it to "2 cpus": should be more than enough for any local testing needs, + // and keeps things simple. + container.withCreateContainerCmdModifier(cmd -> cmd.getHostConfig().withNanoCPUs(2_000_000_000l)); + additionalJdbcUrlProperties.forEach(container::withUrlParam); container.start();

['extensions/devservices/oracle/src/main/java/io/quarkus/devservices/oracle/deployment/OracleDevServicesProcessor.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25019/24943

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/24943

https://github.com/quarkusio/quarkus/pull/25019

https://github.com/quarkusio/quarkus/pull/25019

fixes

Continuous testing fails when a dependency brings in an optional dependency and a Jandex index

### Describe the bug When in a multi-module maven project, with a quarkus module `A` depending on a regular java module `B`. If module `B` contains both an optional dependecy (not declared by `A` too) and a Jandex index, then continuous testing fails with a `BuildException`. It makes no difference whether the classes in `B` using the optional dependencies are used by the quarkus module or its tests. Regular testing via maven still works correctly, though. ### Expected behavior Continuous testing should build and execute the tests. ### Actual behavior A `BuildException` is thrown: ``` [INFO] --- quarkus-maven-plugin:2.8.0.Final:test (default-cli) @ code-with-quarkus --- [INFO] Invoking org.apache.maven.plugins:maven-resources-plugin:2.6:resources) @ code-with-quarkus [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Invoking io.quarkus.platform:quarkus-maven-plugin:2.8.0.Final:generate-code) @ code-with-quarkus [INFO] Invoking org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile) @ code-with-quarkus [INFO] Changes detected - recompiling the module! [INFO] Compiling 1 source file to /home/bnazare/Projects/quarkus-21226-reproducer/code-with-quarkus/target/classes [INFO] Invoking org.apache.maven.plugins:maven-resources-plugin:2.6:testResources) @ code-with-quarkus [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory /home/bnazare/Projects/quarkus-21226-reproducer/code-with-quarkus/src/test/resources [INFO] Invoking io.quarkus.platform:quarkus-maven-plugin:2.8.0.Final:generate-code-tests) @ code-with-quarkus [INFO] Invoking org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile) @ code-with-quarkus [INFO] Changes detected - recompiling the module! [INFO] Compiling 2 source files to /home/bnazare/Projects/quarkus-21226-reproducer/code-with-quarkus/target/test-classes [INFO] /home/bnazare/Projects/quarkus-21226-reproducer/code-with-quarkus/src/test/java/org/acme/NativeGreetingResourceIT.java: /home/bnazare/Projects/quarkus-21226-reproducer/code-with-quarkus/src/test/java/org/acme/NativeGreetingResourceIT.java uses or overrides a deprecated API that is marked for removal. [INFO] /home/bnazare/Projects/quarkus-21226-reproducer/code-with-quarkus/src/test/java/org/acme/NativeGreetingResourceIT.java: Recompile with -Xlint:removal for details. Listening for transport dt_socket at address: 5005 __ ____ __ _____ ___ __ ____ ______ --/ __ \\/ / / / _ | / _ \\/ //_/ / / / __/ -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\\ \\ --\\___\\_\\____/_/ |_/_/|_/_/|_|\\____/___/ 2022-04-14 16:59:51,823 INFO [io.qua.test] (main) Quarkus continuous testing mode started 2022-04-14 16:59:52,032 INFO [io.qua.test] (Test runner thread) Running 1/1. Running: #JUnit Jupiter 2022-04-14 16:59:52,041 INFO [io.qua.test] (Test runner thread) Running 1/1. Running: #JUnit Jupiter 2022-04-14 16:59:52,051 INFO [io.qua.test] (Test runner thread) Running 1/1. Running: org.acme.GreetingResourceTest#GreetingResourceTest 2022-04-14 16:59:52,220 INFO [org.jbo.threads] (Test runner thread) JBoss Threads version 3.4.2.Final 2022-04-14 16:59:52,684 INFO [io.qua.test] (Test runner thread) Running 1/1. Running: org.acme.GreetingResourceTest#testHelloEndpoint() 2022-04-14 16:59:52,690 ERROR [io.qua.test] (Test runner thread) ==================== TEST REPORT #1 ==================== 2022-04-14 16:59:52,691 ERROR [io.qua.test] (Test runner thread) Test GreetingResourceTest#testHelloEndpoint() failed : java.lang.RuntimeException: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.deployment.steps.ClassTransformingBuildStep#handleClassTransformation threw an exception: java.lang.IllegalStateException: java.util.concurrent.ExecutionException: java.lang.TypeNotPresentException: Type com/itextpdf/text/DocumentException not present at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:934) at io.quarkus.builder.BuildContext.run(BuildContext.java:277) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:829) at org.jboss.threads.JBossThread.run(JBossThread.java:501) Caused by: java.util.concurrent.ExecutionException: java.lang.TypeNotPresentException: Type com/itextpdf/text/DocumentException not present at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191) at io.quarkus.deployment.steps.ClassTransformingBuildStep.handleClassTransformation(ClassTransformingBuildStep.java:234) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:925) ... 6 more ``` (the stack trace goes on for around 300 lines, but this is the most relevant part) ### How to Reproduce? Reproducer: https://github.com/linkareti/quarkus-optional-dep-test-issue-reproducer Steps to reproduce the behaviour: 1. run `mvn clean install` in the project's root 2. change to folder `code-with-quarkus` 3. run `mvn clean quarkus:test` ### Output of `uname -a` or `ver` Linux [...] 5.16.18-200.fc35.x86_64 #1 SMP PREEMPT Mon Mar 28 14:10:07 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux ### Output of `java -version` openjdk version "11.0.14.1" 2022-02-08 OpenJDK Runtime Environment 18.9 (build 11.0.14.1+1) OpenJDK 64-Bit Server VM 18.9 (build 11.0.14.1+1, mixed mode, sharing) ### GraalVM version (if different from Java) n/a ### Quarkus version or git rev 2.8.0.Final, but I've seen the issue since 2.6.3.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) Maven home: /home/bnazare/tools/apache-maven-3.8.1 Java version: 11.0.14.1, vendor: Red Hat, Inc., runtime: /usr/lib/jvm/java-11-openjdk-11.0.14.1.1-5.fc35.x86_64 Default locale: pt_PT, platform encoding: UTF-8 OS name: "linux", version: "5.16.18-200.fc35.x86_64", arch: "amd64", family: "unix" ### Additional information _No response_

122467f990ec87979f6bf56493f72291366499d0

af5949b8f4f94ee9846388443390d92461890366

https://github.com/quarkusio/quarkus/compare/122467f990ec87979f6bf56493f72291366499d0...af5949b8f4f94ee9846388443390d92461890366

diff --git a/core/deployment/src/main/java/io/quarkus/deployment/builditem/BytecodeTransformerBuildItem.java b/core/deployment/src/main/java/io/quarkus/deployment/builditem/BytecodeTransformerBuildItem.java index 80a9a321498..ca5eba39618 100644 --- a/core/deployment/src/main/java/io/quarkus/deployment/builditem/BytecodeTransformerBuildItem.java +++ b/core/deployment/src/main/java/io/quarkus/deployment/builditem/BytecodeTransformerBuildItem.java @@ -42,6 +42,8 @@ public final class BytecodeTransformerBuildItem extends MultiBuildItem { final int classReaderOptions; + final boolean continueOnFailure; + public BytecodeTransformerBuildItem(String classToTransform, BiFunction<String, ClassVisitor, ClassVisitor> visitorFunction) { this(classToTransform, visitorFunction, null); @@ -78,6 +80,7 @@ public BytecodeTransformerBuildItem(boolean eager, String classToTransform, this.cacheable = cacheable; this.inputTransformer = null; this.classReaderOptions = 0; + this.continueOnFailure = false; } public BytecodeTransformerBuildItem(Builder builder) { @@ -88,6 +91,7 @@ public BytecodeTransformerBuildItem(Builder builder) { this.cacheable = builder.cacheable; this.inputTransformer = builder.inputTransformer; this.classReaderOptions = builder.classReaderOptions; + this.continueOnFailure = builder.continueOnFailure; if (visitorFunction == null && inputTransformer == null) { throw new IllegalArgumentException("One of either visitorFunction or inputTransformer must be set"); } @@ -121,8 +125,13 @@ public BiFunction<String, byte[], byte[]> getInputTransformer() { return inputTransformer; } + public boolean isContinueOnFailure() { + return continueOnFailure; + } + public static class Builder { public BiFunction<String, byte[], byte[]> inputTransformer; + public boolean continueOnFailure; private String classToTransform; private BiFunction<String, ClassVisitor, ClassVisitor> visitorFunction; private Set<String> requireConstPoolEntry = null; @@ -130,6 +139,11 @@ public static class Builder { private boolean cacheable = false; private int classReaderOptions = 0; + public Builder setContinueOnFailure(boolean continueOnFailure) { + this.continueOnFailure = continueOnFailure; + return this; + } + public Builder setInputTransformer(BiFunction<String, byte[], byte[]> inputTransformer) { this.inputTransformer = inputTransformer; return this; diff --git a/core/deployment/src/main/java/io/quarkus/deployment/dev/testing/TestTracingProcessor.java b/core/deployment/src/main/java/io/quarkus/deployment/dev/testing/TestTracingProcessor.java index e64c13d3d67..0d72f7a3b04 100644 --- a/core/deployment/src/main/java/io/quarkus/deployment/dev/testing/TestTracingProcessor.java +++ b/core/deployment/src/main/java/io/quarkus/deployment/dev/testing/TestTracingProcessor.java @@ -122,13 +122,18 @@ public void instrumentTestClasses(CombinedIndexBuildItem combinedIndexBuildItem, for (ClassInfo clazz : combinedIndexBuildItem.getIndex().getKnownClasses()) { String theClassName = clazz.name().toString(); if (isAppClass(theClassName)) { - transformerProducer.produce(new BytecodeTransformerBuildItem(false, theClassName, - new BiFunction<String, ClassVisitor, ClassVisitor>() { - @Override - public ClassVisitor apply(String s, ClassVisitor classVisitor) { - return new TracingClassVisitor(classVisitor, theClassName); - } - }, true)); + transformerProducer.produce(new BytecodeTransformerBuildItem.Builder().setEager(false) + .setClassToTransform(theClassName) + .setVisitorFunction( + new BiFunction<String, ClassVisitor, ClassVisitor>() { + @Override + public ClassVisitor apply(String s, ClassVisitor classVisitor) { + return new TracingClassVisitor(classVisitor, theClassName); + } + }) + .setCacheable(true) + .setContinueOnFailure(true) + .build()); } } diff --git a/core/deployment/src/main/java/io/quarkus/deployment/steps/ClassTransformingBuildStep.java b/core/deployment/src/main/java/io/quarkus/deployment/steps/ClassTransformingBuildStep.java index d9ab5a0d55f..95517d41d08 100644 --- a/core/deployment/src/main/java/io/quarkus/deployment/steps/ClassTransformingBuildStep.java +++ b/core/deployment/src/main/java/io/quarkus/deployment/steps/ClassTransformingBuildStep.java @@ -125,6 +125,9 @@ public byte[] apply(String className, byte[] originalBytes) { if (classTransformers == null) { return originalBytes; } + boolean continueOnFailure = classTransformers.stream() + .filter(a -> !a.isContinueOnFailure()) + .findAny().isEmpty(); List<BiFunction<String, ClassVisitor, ClassVisitor>> visitors = classTransformers.stream() .map(BytecodeTransformerBuildItem::getVisitorFunction).filter(Objects::nonNull) .collect(Collectors.toList()); @@ -154,6 +157,17 @@ public byte[] apply(String className, byte[] originalBytes) { } else { return originalBytes; } + } catch (Throwable e) { + if (continueOnFailure) { + if (log.isDebugEnabled()) { + log.errorf(e, "Failed to transform %s", className); + } else { + log.errorf("Failed to transform %s", className); + } + return originalBytes; + } else { + throw e; + } } finally { Thread.currentThread().setContextClassLoader(old); } @@ -184,6 +198,10 @@ public byte[] apply(String className, byte[] originalBytes) { entry.getKey()); continue; } + + boolean continueOnFailure = entry.getValue().stream() + .filter(a -> !a.isContinueOnFailure()) + .findAny().isEmpty(); List<BiFunction<String, ClassVisitor, ClassVisitor>> visitors = entry.getValue().stream() .map(BytecodeTransformerBuildItem::getVisitorFunction).filter(Objects::nonNull) .collect(Collectors.toList()); @@ -196,9 +214,9 @@ public byte[] apply(String className, byte[] originalBytes) { public TransformedClassesBuildItem.TransformedClass call() throws Exception { ClassLoader old = Thread.currentThread().getContextClassLoader(); try { + byte[] classData = classPathElement.getResource(classFileName).getData(); Thread.currentThread().setContextClassLoader(transformCl); Set<String> constValues = constScanning.get(className); - byte[] classData = classPathElement.getResource(classFileName).getData(); if (constValues != null && !noConstScanning.contains(className)) { if (!ConstPoolScanner.constPoolEntryPresent(classData, constValues)) { return null; @@ -214,6 +232,17 @@ public TransformedClassesBuildItem.TransformedClass call() throws Exception { transformedClassesCache.put(className, transformedClass); } return transformedClass; + } catch (Throwable e) { + if (continueOnFailure) { + if (log.isDebugEnabled()) { + log.errorf(e, "Failed to transform %s", className); + } else { + log.errorf("Failed to transform %s", className); + } + return null; + } else { + throw e; + } } finally { Thread.currentThread().setContextClassLoader(old); }

['core/deployment/src/main/java/io/quarkus/deployment/dev/testing/TestTracingProcessor.java', 'core/deployment/src/main/java/io/quarkus/deployment/steps/ClassTransformingBuildStep.java', 'core/deployment/src/main/java/io/quarkus/deployment/builditem/BytecodeTransformerBuildItem.java']

{'.java': 3}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/31260/29427

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/29427

https://github.com/quarkusio/quarkus/pull/31260

https://github.com/quarkusio/quarkus/pull/31260

fixes

quarkus.oidc.auth-server-url causing weird start-up failure

### Describe the bug adding this line makes all the difference: `%ecom-dev.quarkus.oidc.auth-server-url=http://ecom-portal-keycloak:8080/realms/quarkus` makes the application crash without much explanation on DEBUG log level: ```posh exec java -Dquarkus.http.host=0.0.0.0 -Djava.util.logging.manager=org.jboss.logmanager.LogManager -XX:+UseG1GC -XX:+UseStringDeduplication -XX:InitialRAMPercentage=50.0 -XX:MaxRAMPercentage=50.0 -Xss256k -Xmx512m -cp . -jar /deployments/quarkus-run.jar Nov 22, 2022 11:04:30 PM org.hibernate.validator.internal.util.Version INFO: HV000001: Hibernate Validator %s Nov 22, 2022 11:04:38 PM io.quarkus.opentelemetry.runtime.tracing.LateBoundSampler WARN: No Sampler delegate specified, no action taken. Nov 22, 2022 11:04:48 PM io.vertx.core.net.impl.ConnectionBase ERROR: Connection reset java.net.SocketException: Connection reset at java.base/sun.nio.ch.SocketChannelImpl.throwConnectionReset(SocketChannelImpl.java:394) at java.base/sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:426) at io.netty.buffer.PooledByteBuf.setBytes(PooledByteBuf.java:258) at io.netty.buffer.AbstractByteBuf.writeBytes(AbstractByteBuf.java:1132) at io.netty.channel.socket.nio.NioSocketChannel.doReadBytes(NioSocketChannel.java:357) at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:151) at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788) at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724) at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:831) Nov 22, 2022 11:04:48 PM io.quarkus.runtime.ApplicationLifecycleManager run ERROR: Failed to start application (with profile ecom-dev) java.net.SocketException: Connection reset at java.base/sun.nio.ch.SocketChannelImpl.throwConnectionReset(SocketChannelImpl.java:394) at java.base/sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:426) at io.netty.buffer.PooledByteBuf.setBytes(PooledByteBuf.java:258) at io.netty.buffer.AbstractByteBuf.writeBytes(AbstractByteBuf.java:1132) at io.netty.channel.socket.nio.NioSocketChannel.doReadBytes(NioSocketChannel.java:357) at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:151) at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788) at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724) at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:831) ``` The keycloak server 19.0.3 is ready and reachable: ``` / $ curl -kv http://ecom-portal-keycloak:8080/realms/quarkus * Trying 172.20.93.10:8080... * Connected to ecom-portal-keycloak (172.20.93.10) port 8080 (#0) > GET /realms/quarkus HTTP/1.1 > Host: ecom-portal-keycloak:8080 > User-Agent: curl/7.79.1 > Accept: */* > * Mark bundle as not supporting multiuse < HTTP/1.1 200 OK < referrer-policy: no-referrer < x-frame-options: SAMEORIGIN < strict-transport-security: max-age=31536000; includeSubDomains < cache-control: no-cache < x-content-type-options: nosniff < x-xss-protection: 1; mode=block < content-type: application/json < content-length: 655 < x-envoy-upstream-service-time: 92 < date: Tue, 22 Nov 2022 23:08:14 GMT < server: envoy < * Connection #0 to host ecom-portal-keycloak left intact {"realm":"quarkus","public_key":"MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAzNMrtvYNG/QBFl+wH+89/asjb+PFU5I+8c+7y1qVgR88NoG53vGKM6GJMnu22nEf24AxXiRLR6SNgiKXhYISNlONREoDJcz9J5Fupm+5MkujHyMn7wLrBTDlFVWwMyVdCTcbmSddM8CkNqMpc8M49HroxxlJLlyaQZNiUKjQVKIsxVMzP5jXfthUtR2eMLLxSyLb6TOZfVrIRouQcDdSdn4q4Oj5eaEWHUg9EH6Q3nGmbL/JnWcvTlb1wDV/LMd4AvOZYKXEuf2RrOdkmNrZ0yXGT0dCzjjRDr+GvH7xUqAw8yAkw6/LegaN8+MPb0Qd9sEnGbkAh2iNrEg+LYDnnQIDAQAB","token-service":"https://portal.ecom-dev.app.whirlpool.aws.fisv.cloud/realms/quarkus/protocol/openid-connect","account-service":"https://portal.ecom-dev.app.whirlpool.aws.fisv.cloud/realms/quarkus/account","tokens-not-before":0}/ $ ``` Any ideas why such a configuration would make the application not start-up anymore? ### Expected behavior some meaningful error log, or for it to just work. ### Actual behavior quarkus dead, sad developer. ### How to Reproduce? _No response_ ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` _No response_ ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev _No response_ ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) _No response_ ### Additional information _No response_

82f63512c081eb378a69de8f5564ee7d29827ac1

3b578363ddae786b1e9bb57365258017ad784a3a

https://github.com/quarkusio/quarkus/compare/82f63512c081eb378a69de8f5564ee7d29827ac1...3b578363ddae786b1e9bb57365258017ad784a3a

diff --git a/extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonUtils.java b/extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonUtils.java index 8c66e1a5a3d..c81938e0794 100644 --- a/extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonUtils.java +++ b/extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonUtils.java @@ -417,7 +417,7 @@ public static Uni<JsonObject> discoverMetadata(WebClient client, String authServ if (resp.statusCode() == 200) { return resp.bodyAsJsonObject(); } else { - LOG.tracef("Discovery has failed, status code: %d", resp.statusCode()); + LOG.warnf("Discovery has failed, status code: %d", resp.statusCode()); throw new OidcEndpointAccessException(resp.statusCode()); } }).onFailure(oidcEndpointNotAvailable()) diff --git a/extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/OidcRecorder.java b/extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/OidcRecorder.java index 1d809ccd5cb..f35e423cba8 100644 --- a/extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/OidcRecorder.java +++ b/extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/OidcRecorder.java @@ -109,8 +109,8 @@ private TenantConfigContext createStaticTenantContext(Vertx vertx, @Override public TenantConfigContext apply(Throwable t) { if (t instanceof OIDCException) { - // OIDC server is not available yet - try to create the connection when the first request arrives - LOG.debugf("Tenant '%s': '%s'." + LOG.warnf("Tenant '%s': '%s'." + + " OIDC server is not available yet, an attempt to connect will be made duiring the first request." + " Access to resources protected by this tenant may fail" + " if OIDC server will not become available", tenantId, t.getMessage()); @@ -257,7 +257,7 @@ public static Optional<ProxyOptions> toProxyOptions(OidcCommonConfig.Proxy proxy protected static OIDCException toOidcException(Throwable cause, String authServerUrl) { final String message = OidcCommonUtils.formatConnectionErrorMessage(authServerUrl); - LOG.debug(message); + LOG.warn(message); return new OIDCException("OIDC Server is not available", cause); }

['extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonUtils.java', 'extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/OidcRecorder.java']

{'.java': 2}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/31016/17839

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/17839

https://github.com/quarkusio/quarkus/pull/31016

https://github.com/quarkusio/quarkus/pull/31016

fixes

Invalid memory configuration for netty maxDirectMemory in native image

I thinks this only concerns native image builds. Setting either -XX:MaxDirectMemorySize or -Dio.netty.maxDirectMemory does not work at runtime and runtime memory is incorrectly reflected in io.netty.util.internal.PlatformDependent.DIRECT_MEMORY_LIMIT at runtime. i think the problem is that io.netty.buffer.PooledByteBufAllocator uses io.netty.util.internal.PlatformDependent which is not initialized during runtime but build time. I tested this with Quarkus 1.10.5.Final, but looking at the current code of NettyProcessor shows that PlatformDependent is still not initialized at runtime, only PooledByteBufAllocator is.

2381d19831104ca0ff2b8946cb13afdac5c02832

ca155cae76c7caf7d6c4bbf27e9ac22305d2dbf0

https://github.com/quarkusio/quarkus/compare/2381d19831104ca0ff2b8946cb13afdac5c02832...ca155cae76c7caf7d6c4bbf27e9ac22305d2dbf0

diff --git a/extensions/netty/deployment/src/main/java/io/quarkus/netty/deployment/NettyProcessor.java b/extensions/netty/deployment/src/main/java/io/quarkus/netty/deployment/NettyProcessor.java index 069fb756162..de1471c3ae4 100644 --- a/extensions/netty/deployment/src/main/java/io/quarkus/netty/deployment/NettyProcessor.java +++ b/extensions/netty/deployment/src/main/java/io/quarkus/netty/deployment/NettyProcessor.java @@ -93,7 +93,8 @@ NativeImageConfigBuildItem build( String maxOrder = calculateMaxOrder(config.allocatorMaxOrder, minMaxOrderBuildItems, false); NativeImageConfigBuildItem.Builder builder = NativeImageConfigBuildItem.builder() - //.addNativeImageSystemProperty("io.netty.noUnsafe", "true") + // disable unsafe usage to allow io.netty.internal.PlarformDependent0 to be reinitialized without issues + .addNativeImageSystemProperty("io.netty.noUnsafe", "true") // Use small chunks to avoid a lot of wasted space. Default is 16mb * arenas (derived from core count) // Since buffers are cached to threads, the malloc overhead is temporary anyway .addNativeImageSystemProperty("io.netty.allocator.maxOrder", maxOrder) @@ -109,6 +110,9 @@ NativeImageConfigBuildItem build( .addRuntimeInitializedClass("io.netty.buffer.ByteBufUtil") // The default channel id uses the process id, it should not be cached in the native image. .addRuntimeInitializedClass("io.netty.channel.DefaultChannelId") + // Make sure to re-initialize platform dependent classes/values at runtime + .addRuntimeReinitializedClass("io.netty.util.internal.PlatformDependent") + .addRuntimeReinitializedClass("io.netty.util.internal.PlatformDependent0") .addNativeImageSystemProperty("io.netty.leakDetection.level", "DISABLED"); if (QuarkusClassLoader.isClassPresentAtRuntime("io.netty.handler.codec.http.HttpObjectEncoder")) {

['extensions/netty/deployment/src/main/java/io/quarkus/netty/deployment/NettyProcessor.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/30992/30850

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/30850

https://github.com/quarkusio/quarkus/pull/30992

https://github.com/quarkusio/quarkus/pull/30992

fix

java.lang.ClassCastException when upgrading from 2.16.0.Final to 2.16.1.Final

### Describe the bug After upgrading to Quarkus 2.16.1 this issue started to happen: ``` Caused by: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.kubernetes.deployment.KubernetesProcessor#build threw an exception: java.lang.ClassCastException: class java.util.HashMap cannot be cast to class java.lang.String (java.util.HashMap and java.lang.String are in module java.base of loader 'bootstrap') at io.dekorate.docker.adapter.DockerBuildConfigAdapter.newBuilder(DockerBuildConfigAdapter.java:58) at io.dekorate.docker.config.DockerBuildConfigGenerator.addPropertyConfiguration(DockerBuildConfigGenerator.java:48) at io.dekorate.Session.lambda$addPropertyConfiguration$1(Session.java:167) at io.dekorate.Session.addConfiguration(Session.java:183) at io.dekorate.Session.addPropertyConfiguration(Session.java:167) at io.quarkus.kubernetes.deployment.KubernetesProcessor.lambda$build$2(KubernetesProcessor.java:164) at java.base/java.util.Optional.ifPresent(Optional.java:183) at io.quarkus.kubernetes.deployment.KubernetesProcessor.build(KubernetesProcessor.java:141) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909) at io.quarkus.builder.BuildContext.run(BuildContext.java:281) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:829) at org.jboss.threads.JBossThread.run(JBossThread.java:501) ``` ### Expected behavior No issues when upgrading from 2.16.0.Final to 2.16.1.Final ### Actual behavior This seems to be a breaking change that we would not expect to see in a minor release. ### How to Reproduce? _No response_ ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` _No response_ ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev _No response_ ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) _No response_ ### Additional information _No response_

4cd3e4d71111a93aecdec700a63c5b169ba396de

0446821feb72f5e10dc583583423cb85d449673d

https://github.com/quarkusio/quarkus/compare/4cd3e4d71111a93aecdec700a63c5b169ba396de...0446821feb72f5e10dc583583423cb85d449673d

diff --git a/extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesConfigUtil.java b/extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesConfigUtil.java index 085ac6b982b..e7eb1862def 100644 --- a/extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesConfigUtil.java +++ b/extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesConfigUtil.java @@ -29,6 +29,8 @@ import org.jboss.logging.Logger; import io.dekorate.utils.Strings; +import io.quarkus.deployment.Capabilities; +import io.quarkus.deployment.Capability; public class KubernetesConfigUtil { @@ -36,8 +38,10 @@ public class KubernetesConfigUtil { private static final String QUARKUS_PREFIX = "quarkus."; private static final Pattern QUARKUS_DEPLOY_PATTERN = Pattern.compile("quarkus\\\\.([^\\\\.]+)\\\\.deploy"); - private static final Set<String> ALLOWED_GENERATORS = new HashSet<>( - Arrays.asList(KUBERNETES, OPENSHIFT, KNATIVE, DOCKER, S2I)); + private static final Set<String> ALLOWED_GENERATORS = Set.of(KUBERNETES, KNATIVE, OPENSHIFT); + private static final Map<String, String> ALLOWED_GENERATORS_BY_CAPABILITY = Map.of( + DOCKER, Capability.CONTAINER_IMAGE_DOCKER, + S2I, Capability.CONTAINER_IMAGE_S2I); private static final String EXPOSE_PROPERTY_NAME = "expose"; private static final String[] EXPOSABLE_GENERATORS = { OPENSHIFT, KUBERNETES }; @@ -133,7 +137,7 @@ public static boolean isDeploymentEnabled() { * * @return A map containing the properties. */ - public static Map<String, Object> toMap(PlatformConfiguration... platformConfigurations) { + public static Map<String, Object> toMap(Capabilities capabilities, PlatformConfiguration... platformConfigurations) { Config config = ConfigProvider.getConfig(); Map<String, Object> result = new HashMap<>(); @@ -149,12 +153,13 @@ public static Map<String, Object> toMap(PlatformConfiguration... platformConfigu .ifPresent(v -> quarkusPrefixed.put(DEKORATE_PREFIX + p.getConfigName() + ".version", v)); }); + Set<String> allowedGenerators = allowedGenerators(capabilities); Map<String, Object> unPrefixed = StreamSupport.stream(config.getPropertyNames().spliterator(), false) - .filter(k -> ALLOWED_GENERATORS.contains(generatorName(k))) + .filter(k -> allowedGenerators.contains(generatorName(k))) .filter(k -> config.getOptionalValue(k, String.class).isPresent()) .collect(Collectors.toMap(k -> DEKORATE_PREFIX + k, k -> config.getValue(k, String.class))); - for (String generator : ALLOWED_GENERATORS) { + for (String generator : allowedGenerators) { String oldKey = DEKORATE_PREFIX + generator + ".group"; String newKey = DEKORATE_PREFIX + generator + ".part-of"; if (unPrefixed.containsKey(oldKey)) { @@ -206,6 +211,17 @@ private static void handleExpose(Config config, Map<String, Object> unPrefixed, } } + private static Set<String> allowedGenerators(Capabilities capabilities) { + Set<String> generators = new HashSet<>(ALLOWED_GENERATORS); + for (Map.Entry<String, String> generatorByCapability : ALLOWED_GENERATORS_BY_CAPABILITY.entrySet()) { + if (capabilities.isPresent(generatorByCapability.getValue())) { + generators.add(generatorByCapability.getKey()); + } + } + + return generators; + } + /** * Returns the name of the generators that can handle the specified key. * diff --git a/extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesProcessor.java b/extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesProcessor.java index ec65140a974..cf174966c66 100644 --- a/extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesProcessor.java +++ b/extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesProcessor.java @@ -127,7 +127,7 @@ public void build(ApplicationInfoBuildItem applicationInfo, throw new RuntimeException("Unable to setup environment for generating Kubernetes resources", e); } - Map<String, Object> config = KubernetesConfigUtil.toMap(kubernetesConfig, openshiftConfig, knativeConfig); + Map<String, Object> config = KubernetesConfigUtil.toMap(capabilities, kubernetesConfig, openshiftConfig, knativeConfig); Set<String> deploymentTargets = kubernetesDeploymentTargets.getEntriesSortedByPriority().stream() .map(DeploymentTargetEntry::getName) .collect(Collectors.toSet());

['extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesConfigUtil.java', 'extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesProcessor.java']

{'.java': 2}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/30964/29630

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/29630

https://github.com/quarkusio/quarkus/pull/30964

https://github.com/quarkusio/quarkus/pull/30964

fixes

Changes to configmappings not being applied during hot reload

### Describe the bug Newly added configmappings are only available for injection after a full restart. A hot reload is not enough. Removed configmappings result in class not found exceptions. ### Expected behavior Configmappings work directly after a hot reload, and do not require a full restart. ### Actual behavior Startet without the mapping, and adding it. After hot reload this exception happens: ``` __ ____ __ _____ ___ __ ____ ______ --/ __ \\/ / / / _ | / _ \\/ //_/ / / / __/ -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\\ \\ --\\___\\_\\____/_/ |_/_/|_/_/|_|\\____/___/ 2022-12-02 06:39:52,101 INFO [io.quarkus] (Quarkus Main Thread) unremovable-configmapping 1.0.0-SNAPSHOT on JVM (powered by Quarkus 2.14.2.Final) started in 0.405s. Listening on: http://localhost:8080 2022-12-02 06:39:52,102 INFO [io.quarkus] (Quarkus Main Thread) Profile dev activated. Live Coding activated. 2022-12-02 06:39:52,102 INFO [io.quarkus] (Quarkus Main Thread) Installed features: [cdi, resteasy-reactive, smallrye-context-propagation, vertx] 2022-12-02 06:39:52,102 INFO [io.qua.dep.dev.RuntimeUpdatesProcessor] (vert.x-worker-thread-0) Live reload total time: 1.175s 2022-12-02 06:39:52,108 ERROR [io.qua.ver.htt.run.QuarkusErrorHandler] (executor-thread-0) HTTP Request to /hello failed, error id: aa2f8dcb-6516-4407-84ff-02d755799c76-1: java.lang.RuntimeException: Error injecting org.acme.AppConfig org.acme.GreetingResource.config at org.acme.GreetingResource_Bean.create(Unknown Source) at org.acme.GreetingResource_Bean.create(Unknown Source) at io.quarkus.arc.impl.AbstractSharedContext.createInstanceHandle(AbstractSharedContext.java:113) at io.quarkus.arc.impl.AbstractSharedContext$1.get(AbstractSharedContext.java:37) at io.quarkus.arc.impl.AbstractSharedContext$1.get(AbstractSharedContext.java:34) at io.quarkus.arc.impl.LazyValue.get(LazyValue.java:26) at io.quarkus.arc.impl.ComputingCache.computeIfAbsent(ComputingCache.java:69) at io.quarkus.arc.impl.AbstractSharedContext.get(AbstractSharedContext.java:34) at org.acme.GreetingResource_Bean.get(Unknown Source) at org.acme.GreetingResource_Bean.get(Unknown Source) at io.quarkus.arc.impl.ArcContainerImpl.beanInstanceHandle(ArcContainerImpl.java:476) at io.quarkus.arc.impl.ArcContainerImpl.beanInstanceHandle(ArcContainerImpl.java:489) at io.quarkus.arc.impl.ArcContainerImpl$2.get(ArcContainerImpl.java:279) at io.quarkus.arc.impl.ArcContainerImpl$2.get(ArcContainerImpl.java:276) at io.quarkus.arc.runtime.BeanContainerImpl$1.create(BeanContainerImpl.java:46) at io.quarkus.resteasy.reactive.common.runtime.ArcBeanFactory.createInstance(ArcBeanFactory.java:27) at org.jboss.resteasy.reactive.server.handlers.InstanceHandler.handle(InstanceHandler.java:26) at io.quarkus.resteasy.reactive.server.runtime.QuarkusResteasyReactiveRequestContext.invokeHandler(QuarkusResteasyReactiveRequestContext.java:112) at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.run(AbstractResteasyReactiveContext.java:145) at io.quarkus.vertx.core.runtime.VertxCoreRecorder$14.runWith(VertxCoreRecorder.java:576) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29) at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:29) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:1589) Caused by: java.util.NoSuchElementException: SRCFG00027: Could not find a mapping for org.acme.AppConfig at io.smallrye.config.ConfigMappings.getConfigMapping(ConfigMappings.java:101) at io.smallrye.config.SmallRyeConfig.getConfigMapping(SmallRyeConfig.java:415) at io.quarkus.arc.runtime.ConfigMappingCreator.create(ConfigMappingCreator.java:31) at org.acme.AppConfig_3b122e7acaecf984e5d14008b48492761a901be1_Synthetic_Bean.create(Unknown Source) at org.acme.AppConfig_3b122e7acaecf984e5d14008b48492761a901be1_Synthetic_Bean.get(Unknown Source) at org.acme.AppConfig_3b122e7acaecf984e5d14008b48492761a901be1_Synthetic_Bean.get(Unknown Source) at io.quarkus.arc.impl.CurrentInjectionPointProvider.get(CurrentInjectionPointProvider.java:62) ... 26 more 2022-12-02 06:39:52,110 ERROR [org.jbo.res.rea.com.cor.AbstractResteasyReactiveContext] (executor-thread-0) Request failed: java.lang.RuntimeException: Error injecting org.acme.AppConfig org.acme.GreetingResource.config at org.acme.GreetingResource_Bean.create(Unknown Source) at org.acme.GreetingResource_Bean.create(Unknown Source) at io.quarkus.arc.impl.AbstractSharedContext.createInstanceHandle(AbstractSharedContext.java:113) at io.quarkus.arc.impl.AbstractSharedContext$1.get(AbstractSharedContext.java:37) at io.quarkus.arc.impl.AbstractSharedContext$1.get(AbstractSharedContext.java:34) at io.quarkus.arc.impl.LazyValue.get(LazyValue.java:26) at io.quarkus.arc.impl.ComputingCache.computeIfAbsent(ComputingCache.java:69) at io.quarkus.arc.impl.AbstractSharedContext.get(AbstractSharedContext.java:34) at org.acme.GreetingResource_Bean.get(Unknown Source) at org.acme.GreetingResource_Bean.get(Unknown Source) at io.quarkus.arc.impl.ArcContainerImpl.beanInstanceHandle(ArcContainerImpl.java:476) at io.quarkus.arc.impl.ArcContainerImpl.beanInstanceHandle(ArcContainerImpl.java:489) at io.quarkus.arc.impl.ArcContainerImpl$2.get(ArcContainerImpl.java:279) at io.quarkus.arc.impl.ArcContainerImpl$2.get(ArcContainerImpl.java:276) at io.quarkus.arc.runtime.BeanContainerImpl$1.create(BeanContainerImpl.java:46) at io.quarkus.resteasy.reactive.common.runtime.ArcBeanFactory.createInstance(ArcBeanFactory.java:27) at org.jboss.resteasy.reactive.server.handlers.InstanceHandler.handle(InstanceHandler.java:26) at io.quarkus.resteasy.reactive.server.runtime.QuarkusResteasyReactiveRequestContext.invokeHandler(QuarkusResteasyReactiveRequestContext.java:112) at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.run(AbstractResteasyReactiveContext.java:145) at io.quarkus.vertx.core.runtime.VertxCoreRecorder$14.runWith(VertxCoreRecorder.java:576) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29) at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:29) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:1589) Caused by: java.util.NoSuchElementException: SRCFG00027: Could not find a mapping for org.acme.AppConfig at io.smallrye.config.ConfigMappings.getConfigMapping(ConfigMappings.java:101) at io.smallrye.config.SmallRyeConfig.getConfigMapping(SmallRyeConfig.java:415) at io.quarkus.arc.runtime.ConfigMappingCreator.create(ConfigMappingCreator.java:31) at org.acme.AppConfig_3b122e7acaecf984e5d14008b48492761a901be1_Synthetic_Bean.create(Unknown Source) at org.acme.AppConfig_3b122e7acaecf984e5d14008b48492761a901be1_Synthetic_Bean.get(Unknown Source) at org.acme.AppConfig_3b122e7acaecf984e5d14008b48492761a901be1_Synthetic_Bean.get(Unknown Source) at io.quarkus.arc.impl.CurrentInjectionPointProvider.get(CurrentInjectionPointProvider.java:62) ... 26 more ``` Starting with mapping, and removing it. After hot reload this exception happens: ``` java.lang.ClassNotFoundException: org.acme.AppConfig at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:479) at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:455) at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:505) at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:455) at io.quarkus.runtime.configuration.ConfigUtils.addMapping(ConfigUtils.java:257) at io.quarkus.runtime.generated.Config.readConfig(Unknown Source) at io.quarkus.deployment.steps.RuntimeConfigSetup.deploy(Unknown Source) at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source) at io.quarkus.runtime.Application.start(Application.java:101) at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:110) at io.quarkus.runtime.Quarkus.run(Quarkus.java:70) at io.quarkus.runtime.Quarkus.run(Quarkus.java:43) at io.quarkus.runtime.Quarkus.run(Quarkus.java:123) at io.quarkus.runner.GeneratedMain.main(Unknown Source) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) at java.base/java.lang.reflect.Method.invoke(Method.java:578) at io.quarkus.runner.bootstrap.StartupActionImpl$1.run(StartupActionImpl.java:104) at java.base/java.lang.Thread.run(Thread.java:1589) Resulted in: java.lang.RuntimeException: java.lang.ClassNotFoundException: org.acme.AppConfig at io.quarkus.runtime.configuration.ConfigUtils.addMapping(ConfigUtils.java:259) ... 13 more Resulted in: java.lang.RuntimeException: Failed to start quarkus ... 11 more Resulted in: io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58) at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:123) at io.quarkus.deployment.dev.IsolatedDevModeMain.restartApp(IsolatedDevModeMain.java:222) at io.quarkus.deployment.dev.IsolatedDevModeMain.restartCallback(IsolatedDevModeMain.java:203) at io.quarkus.deployment.dev.RuntimeUpdatesProcessor.doScan(RuntimeUpdatesProcessor.java:537) at io.quarkus.deployment.dev.RuntimeUpdatesProcessor.doScan(RuntimeUpdatesProcessor.java:437) at io.quarkus.vertx.http.runtime.devmode.VertxHttpHotReplacementSetup$4.handle(VertxHttpHotReplacementSetup.java:152) at io.quarkus.vertx.http.runtime.devmode.VertxHttpHotReplacementSetup$4.handle(VertxHttpHotReplacementSetup.java:139) at io.vertx.core.impl.ContextBase.lambda$null$0(ContextBase.java:137) at io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:264) at io.vertx.core.impl.ContextBase.lambda$executeBlocking$1(ContextBase.java:135) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29) at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:29) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ... 1 more ``` ### How to Reproduce? Reproducer: [unremovable-configmapping.zip](https://github.com/quarkusio/quarkus/files/10138391/unremovable-configmapping.zip) 1. mvn quarkus:dev 2. Go to http://localhost:8080/hello -> no exception 3. Add a ConfigMapping Class like: ``` @ConfigMapping(prefix = "appconfig") public interface AppConfig { String defaultLanguage(); } ``` 4. In GreetingResource, switch the commented out lines around so that the configmapping is used, and defaultLanguage() is returned in the resource 5. Go to http://localhost:8080/hello -> first exception from above 6. shut down quarkus 7. mvn quarkus:dev 8. Go to http://localhost:8080/hello -> no exception 9. Completly remove the configmapping -> Class Not found Exception ### Output of `uname -a` or `ver` Microsoft Windows [Version 10.0.19044.2251] ### Output of `java -version` openjdk 19 2022-09-20 OpenJDK Runtime Environment Temurin-19+36 (build 19+36) OpenJDK 64-Bit Server VM Temurin-19+36 (build 19+36, mixed mode, sharing) ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.14.2.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) Maven home: C:\\eclipse\\tools\\java\\maven Java version: 17.0.4, vendor: Eclipse Adoptium, runtime: C:\\eclipse\\tools\\java\\17 Default locale: de_DE, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" ### Additional information _No response_

e48aace483cf24d24b566b5786731e98351a7027

4cf5e3b589d6780c221a684dc1cb95e0c0354572

https://github.com/quarkusio/quarkus/compare/e48aace483cf24d24b566b5786731e98351a7027...4cf5e3b589d6780c221a684dc1cb95e0c0354572

diff --git a/core/deployment/src/main/java/io/quarkus/deployment/configuration/RunTimeConfigurationGenerator.java b/core/deployment/src/main/java/io/quarkus/deployment/configuration/RunTimeConfigurationGenerator.java index b841edc24ee..111b6171fdb 100644 --- a/core/deployment/src/main/java/io/quarkus/deployment/configuration/RunTimeConfigurationGenerator.java +++ b/core/deployment/src/main/java/io/quarkus/deployment/configuration/RunTimeConfigurationGenerator.java @@ -403,11 +403,6 @@ public static final class GenerateOperation implements AutoCloseable { clinit.invokeStaticMethod(CU_ADD_SOURCE_FACTORY_PROVIDER, buildTimeBuilder, clinit.newInstance(RCSF_NEW, clinit.load(discoveredConfigSourceFactory))); } - // add mappings - for (ConfigClassWithPrefix configMapping : staticConfigMappings) { - clinit.invokeStaticMethod(CU_WITH_MAPPING, buildTimeBuilder, - clinit.load(configMapping.getKlass().getName()), clinit.load(configMapping.getPrefix())); - } // additional config builders ResultHandle configBuilders = clinit.newInstance(AL_NEW); @@ -468,11 +463,12 @@ public void run() { reinit.invokeStaticMethod(CU_ADD_SOURCE_FACTORY_PROVIDER, buildTimeBuilder, reinit.newInstance(RCSF_NEW, reinit.load(discoveredConfigSourceFactory))); } - // add mappings - for (ConfigClassWithPrefix configMapping : staticConfigMappings) { - reinit.invokeStaticMethod(CU_WITH_MAPPING, buildTimeBuilder, - reinit.load(configMapping.getKlass().getName()), reinit.load(configMapping.getPrefix())); + // additional config builders + ResultHandle configBuilders = reinit.newInstance(AL_NEW); + for (String configBuilder : staticConfigBuilders) { + reinit.invokeVirtualMethod(AL_ADD, configBuilders, reinit.load(configBuilder)); } + reinit.invokeStaticMethod(CU_CONFIG_BUILDER_LIST, buildTimeBuilder, configBuilders); ResultHandle clinitConfig = reinit.checkCast(reinit.invokeVirtualMethod(SRCB_BUILD, buildTimeBuilder), SmallRyeConfig.class); @@ -555,12 +551,6 @@ public void run() { readBootstrapConfig.invokeStaticMethod(CU_ADD_SOURCE_FACTORY_PROVIDER, bootstrapBuilder, readBootstrapConfig.newInstance(RCSF_NEW, readBootstrapConfig.load(discoveredConfigSourceFactory))); } - // add bootstrap mappings - for (ConfigClassWithPrefix configMapping : staticConfigMappings) { - readBootstrapConfig.invokeStaticMethod(CU_WITH_MAPPING, bootstrapBuilder, - readBootstrapConfig.load(configMapping.getKlass().getName()), - readBootstrapConfig.load(configMapping.getPrefix())); - } // add bootstrap config builders ResultHandle bootstrapConfigBuilders = readBootstrapConfig.newInstance(AL_NEW); @@ -649,12 +639,6 @@ public void run() { readConfig.newInstance(RCSF_NEW, readConfig.load(discoveredConfigSourceFactory))); } - // add mappings - for (ConfigClassWithPrefix configMapping : runtimeConfigMappings) { - readConfig.invokeStaticMethod(CU_WITH_MAPPING, runTimeBuilder, - readConfig.load(configMapping.getKlass().getName()), readConfig.load(configMapping.getPrefix())); - } - // additional config builders ResultHandle configBuilders = readConfig.newInstance(AL_NEW); for (String configBuilder : runtimeConfigBuilders) { diff --git a/core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java b/core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java index 111a05329b9..4a9aa31c796 100644 --- a/core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java +++ b/core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java @@ -88,6 +88,10 @@ public class ConfigGenerationBuildStep { SmallRyeConfigBuilder.class, "withSources", SmallRyeConfigBuilder.class, ConfigSource[].class); + private static final MethodDescriptor WITH_MAPPING = MethodDescriptor.ofMethod( + SmallRyeConfigBuilder.class, "withMapping", + SmallRyeConfigBuilder.class, Class.class, String.class); + @BuildStep void staticInitSources( BuildProducer<StaticInitConfigSourceProviderBuildItem> staticInitConfigSourceProviderBuildItem, @@ -217,6 +221,33 @@ void extensionMappings(ConfigurationBuildItem configItem, } } + @BuildStep + void builderMappings( + ConfigurationBuildItem configItem, + List<ConfigMappingBuildItem> configMappings, + BuildProducer<GeneratedClassBuildItem> generatedClass, + BuildProducer<ReflectiveClassBuildItem> reflectiveClass, + BuildProducer<StaticInitConfigBuilderBuildItem> staticInitConfigBuilder, + BuildProducer<RunTimeConfigBuilderBuildItem> runTimeConfigBuilder) { + + // For Static Init Config + Set<ConfigClassWithPrefix> staticMappings = new HashSet<>(); + staticMappings.addAll(staticSafeConfigMappings(configMappings)); + staticMappings.addAll(configItem.getReadResult().getBuildTimeRunTimeMappings()); + String staticInitMappingsConfigBuilder = "io.quarkus.runtime.generated.StaticInitMappingsConfigBuilder"; + generateMappingsConfigBuilder(generatedClass, reflectiveClass, staticInitMappingsConfigBuilder, staticMappings); + staticInitConfigBuilder.produce(new StaticInitConfigBuilderBuildItem(staticInitMappingsConfigBuilder)); + + // For RunTime Config + Set<ConfigClassWithPrefix> runTimeMappings = new HashSet<>(); + runTimeMappings.addAll(runtimeConfigMappings(configMappings)); + runTimeMappings.addAll(configItem.getReadResult().getBuildTimeRunTimeMappings()); + runTimeMappings.addAll(configItem.getReadResult().getRunTimeMappings()); + String runTimeMappingsConfigBuilder = "io.quarkus.runtime.generated.RunTimeMappingsConfigBuilder"; + generateMappingsConfigBuilder(generatedClass, reflectiveClass, runTimeMappingsConfigBuilder, runTimeMappings); + runTimeConfigBuilder.produce(new RunTimeConfigBuilderBuildItem(runTimeMappingsConfigBuilder)); + } + /** * Generate the Config class that instantiates MP Config and holds all the config objects */ @@ -256,6 +287,7 @@ void generateConfigClass( staticConfigSourceFactories.addAll(staticInitConfigSourceFactories.stream() .map(StaticInitConfigSourceFactoryBuildItem::getFactoryClassName).collect(Collectors.toSet())); + // TODO - duplicated now builderMappings. Still required to filter the unknown properties Set<ConfigClassWithPrefix> staticMappings = new HashSet<>(); staticMappings.addAll(staticSafeConfigMappings(configMappings)); staticMappings.addAll(configItem.getReadResult().getBuildTimeRunTimeMappings()); @@ -484,6 +516,34 @@ private static void generateDefaultsConfigSource( reflectiveClass.produce(new ReflectiveClassBuildItem(true, false, false, className)); } + private static void generateMappingsConfigBuilder( + BuildProducer<GeneratedClassBuildItem> generatedClass, + BuildProducer<ReflectiveClassBuildItem> reflectiveClass, + String className, + Set<ConfigClassWithPrefix> mappings) { + + try (ClassCreator classCreator = ClassCreator.builder() + .classOutput(new GeneratedClassGizmoAdaptor(generatedClass, true)) + .className(className) + .interfaces(ConfigBuilder.class) + .setFinal(true) + .build()) { + + MethodCreator method = classCreator.getMethodCreator(CONFIG_BUILDER); + ResultHandle configBuilder = method.getMethodParam(0); + + for (ConfigClassWithPrefix mapping : mappings) { + method.invokeVirtualMethod(WITH_MAPPING, configBuilder, + method.loadClass(mapping.getKlass()), + method.load(mapping.getPrefix())); + } + + method.returnValue(configBuilder); + } + + reflectiveClass.produce(new ReflectiveClassBuildItem(true, false, false, className)); + } + private static Set<String> discoverService( Class<?> serviceClass, BuildProducer<ReflectiveClassBuildItem> reflectiveClass) throws IOException { diff --git a/integration-tests/test-extension/extension/deployment/src/test/java/io/quarkus/config/SecretKeysConfigTest.java b/integration-tests/test-extension/extension/deployment/src/test/java/io/quarkus/config/SecretKeysConfigTest.java index 120c4c6da57..c299b5b3de4 100644 --- a/integration-tests/test-extension/extension/deployment/src/test/java/io/quarkus/config/SecretKeysConfigTest.java +++ b/integration-tests/test-extension/extension/deployment/src/test/java/io/quarkus/config/SecretKeysConfigTest.java @@ -39,7 +39,7 @@ void secrets() { } @ConfigMapping(prefix = "secrets.my") - interface MappingSecret { + public interface MappingSecret { String secret(); } }

['core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java', 'core/deployment/src/main/java/io/quarkus/deployment/configuration/RunTimeConfigurationGenerator.java', 'integration-tests/test-extension/extension/deployment/src/test/java/io/quarkus/config/SecretKeysConfigTest.java']

{'.java': 3}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25285/25258

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25258

https://github.com/quarkusio/quarkus/pull/25285

https://github.com/quarkusio/quarkus/pull/25285

fixes

RESTEasy reactive illegally restricts JAX-RSpath parameter names

### Describe the bug Consider the following JAX-RS resource: ``` @Produces(MediaType.APPLICATION_JSON) @Path("/") public class ContextNotWorking { @GET @Path("foo/{something-with-dash:[^a]*}") public Response doSomething(@PathParam("something-with-dash") String param) { return Response.noContent().build(); } } ``` Note that path parameter _something-with-dash_. According to the Javadoc of @Path the dash is an allowed character in a parameter name. However, if you try to run this with resteasy-reactive startup fails with ``` Caused by: java.lang.IllegalArgumentException: Path '/foo/{something-with-dash:[^a]*}' of method 'org.knime.xxx.ContextNotWorking#doSomething' is not a valid expression at org.jboss.resteasy.reactive.server.processor.ServerEndpointIndexer.validateMethodPath(ServerEndpointIndexer.java:226) at org.jboss.resteasy.reactive.server.processor.ServerEndpointIndexer.handleAdditionalMethodProcessing(ServerEndpointIndexer.java:218) at io.quarkus.resteasy.reactive.server.deployment.QuarkusServerEndpointIndexer.handleAdditionalMethodProcessing(QuarkusServerEndpointIndexer.java:164) at io.quarkus.resteasy.reactive.server.deployment.QuarkusServerEndpointIndexer.handleAdditionalMethodProcessing(QuarkusServerEndpointIndexer.java:32) at org.jboss.resteasy.reactive.common.processor.EndpointIndexer.createResourceMethod(EndpointIndexer.java:657) ... 14 more Caused by: java.util.regex.PatternSyntaxException: named capturing group is missing trailing '>' near index 12 (?<something-with-dash>[^a]*)$ ^ at java.base/java.util.regex.Pattern.error(Pattern.java:2027) at java.base/java.util.regex.Pattern.groupname(Pattern.java:2949) at java.base/java.util.regex.Pattern.group0(Pattern.java:2995) at java.base/java.util.regex.Pattern.sequence(Pattern.java:2123) at java.base/java.util.regex.Pattern.expr(Pattern.java:2068) at java.base/java.util.regex.Pattern.compile(Pattern.java:1782) at java.base/java.util.regex.Pattern.<init>(Pattern.java:1428) at java.base/java.util.regex.Pattern.compile(Pattern.java:1068) at org.jboss.resteasy.reactive.server.mapping.URITemplate.<init>(URITemplate.java:157) at org.jboss.resteasy.reactive.server.processor.ServerEndpointIndexer.validateMethodPath(ServerEndpointIndexer.java:223) ... 18 more ``` It seems he reactive extension does not comply with the JAX-RS specification. The same class works fine with the non-reactive version of RESTEasy. Patterns in Java indeed do *not* allow dashes in capture group names. ### Expected behavior Code that is legal according to the JAX-RS specification should work in Quarkus. ### Actual behavior Quarkus startup fails with the error above. ### How to Reproduce? Try to run the provided JAX-RS resource class with _quarkus-resteasy-reactive_. ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` 17 ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.8.2.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) _No response_ ### Additional information _No response_

813a88bbbd12687e178789f9de41df95bf253db5

ea6206a6c48e12db5e8f781c1f0737fe06efc3e6

https://github.com/quarkusio/quarkus/compare/813a88bbbd12687e178789f9de41df95bf253db5...ea6206a6c48e12db5e8f781c1f0737fe06efc3e6

diff --git a/independent-projects/resteasy-reactive/common/processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java b/independent-projects/resteasy-reactive/common/processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java index a48cd45b766..18167fbeeb3 100644 --- a/independent-projects/resteasy-reactive/common/processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java +++ b/independent-projects/resteasy-reactive/common/processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java @@ -303,11 +303,12 @@ public Optional<ResourceClass> createEndpoints(ClassInfo classInfo, boolean cons private String sanitizePath(String path) { // this simply replaces the whitespace characters (not part of a path variable) with %20 // TODO: this might have to be more complex, URL encoding maybe? - boolean inVariable = false; + // zero braces indicates we are outside of a variable + int bracesCount = 0; StringBuilder replaced = null; for (int i = 0; i < path.length(); i++) { char c = path.charAt(i); - if ((c == ' ') && (!inVariable)) { + if ((c == ' ') && (bracesCount == 0)) { if (replaced == null) { replaced = new StringBuilder(path.length() + 2); replaced.append(path, 0, i); @@ -319,9 +320,9 @@ private String sanitizePath(String path) { replaced.append(c); } if (c == '{') { - inVariable = true; + bracesCount++; } else if (c == '}') { - inVariable = false; + bracesCount--; } } if (replaced == null) { diff --git a/independent-projects/resteasy-reactive/server/runtime/src/main/java/org/jboss/resteasy/reactive/server/mapping/RequestMapper.java b/independent-projects/resteasy-reactive/server/runtime/src/main/java/org/jboss/resteasy/reactive/server/mapping/RequestMapper.java index 90d61fb86c7..d291f4ad179 100644 --- a/independent-projects/resteasy-reactive/server/runtime/src/main/java/org/jboss/resteasy/reactive/server/mapping/RequestMapper.java +++ b/independent-projects/resteasy-reactive/server/runtime/src/main/java/org/jboss/resteasy/reactive/server/mapping/RequestMapper.java @@ -75,8 +75,8 @@ public RequestMatch<T> map(String path) { break; } matchPos = matcher.end(); - for (String name : segment.names) { - params[paramCount++] = URIDecoder.decodeURIComponent(matcher.group(name), false); + for (String group : segment.groups) { + params[paramCount++] = URIDecoder.decodeURIComponent(matcher.group(group), false); } } else if (segment.type == URITemplate.Type.LITERAL) { //make sure the literal text is the same diff --git a/independent-projects/resteasy-reactive/server/runtime/src/main/java/org/jboss/resteasy/reactive/server/mapping/URITemplate.java b/independent-projects/resteasy-reactive/server/runtime/src/main/java/org/jboss/resteasy/reactive/server/mapping/URITemplate.java index f46fcab7f4c..09e45a3c97b 100644 --- a/independent-projects/resteasy-reactive/server/runtime/src/main/java/org/jboss/resteasy/reactive/server/mapping/URITemplate.java +++ b/independent-projects/resteasy-reactive/server/runtime/src/main/java/org/jboss/resteasy/reactive/server/mapping/URITemplate.java @@ -8,6 +8,8 @@ public class URITemplate implements Dumpable, Comparable<URITemplate> { + private static final Pattern GROUP_NAME_PATTERN = Pattern.compile("^[A-Za-z][A-Za-z\\\\d]*$"); + public final String template; public final String stem; @@ -65,17 +67,19 @@ public URITemplate(String template, boolean prefixMatch) { if (sb.length() > 0) { capGroups++; if (i + 1 == template.length() || template.charAt(i + 1) == '/') { - components.add(new TemplateComponent(Type.DEFAULT_REGEX, null, sb.toString(), null, null)); + components + .add(new TemplateComponent(Type.DEFAULT_REGEX, null, sb.toString().trim(), null, null, + null)); } else { - components.add(new TemplateComponent(Type.CUSTOM_REGEX, "[^/]+?", sb.toString(), - null, null)); + components.add(new TemplateComponent(Type.CUSTOM_REGEX, "[^/]+?", sb.toString().trim(), + null, null, null)); } } else { throw new IllegalArgumentException("Invalid template " + template); } sb.setLength(0); } else if (c == ':') { - name = sb.toString(); + name = sb.toString().trim(); sb.setLength(0); state = 2; } else { @@ -89,8 +93,8 @@ public URITemplate(String template, boolean prefixMatch) { capGroups++; complexGroups++; components - .add(new TemplateComponent(Type.CUSTOM_REGEX, sb.toString(), name, null, - null)); + .add(new TemplateComponent(Type.CUSTOM_REGEX, sb.toString().trim(), name, null, + null, null)); } else { throw new IllegalArgumentException("Invalid template " + template); } @@ -124,30 +128,43 @@ public URITemplate(String template, boolean prefixMatch) { //coalesce the components //once we have a CUSTOM_REGEX everything goes out the window, so we need to turn the remainder of the //template into a single CUSTOM_REGEX + List<String> groupAggregator = null; List<String> nameAggregator = null; StringBuilder regexAggregator = null; Iterator<TemplateComponent> it = components.iterator(); while (it.hasNext()) { TemplateComponent component = it.next(); + + if (component.type == Type.CUSTOM_REGEX && nameAggregator == null) { + regexAggregator = new StringBuilder(); + groupAggregator = new ArrayList<>(); + nameAggregator = new ArrayList<>(); + } + if (nameAggregator != null) { it.remove(); if (component.type == Type.LITERAL) { regexAggregator.append(Pattern.quote(component.literalText)); - } else if (component.type == Type.DEFAULT_REGEX) { - regexAggregator.append("(?<").append(component.name).append(">[^/]+?)"); - nameAggregator.add(component.name); - } else if (component.type == Type.CUSTOM_REGEX) { - regexAggregator.append("(?<").append(component.name).append(">").append(component.literalText.trim()) + } else if (component.type == Type.DEFAULT_REGEX || component.type == Type.CUSTOM_REGEX) { + String groupName = component.name; + // test if the component name is a valid java groupname according to the rules outlined in java.util.Pattern#groupName + // Paths allow for parameter names with characters not allowed in group names. Generate a custom one in the form group + running number when the component name alone would be invalid. + if (!GROUP_NAME_PATTERN.matcher(component.name).matches()) { + groupName = "group" + groupAggregator.size(); + } + + String regex = "[^/]+?"; + + if (component.type == Type.CUSTOM_REGEX) { + regex = component.literalText.trim(); + } + + groupAggregator.add(groupName + ""); + regexAggregator.append("(?<").append(groupName).append(">") + .append(regex) .append(")"); nameAggregator.add(component.name); } - } else if (component.type == Type.CUSTOM_REGEX) { - it.remove(); - regexAggregator = new StringBuilder(); - nameAggregator = new ArrayList<>(); - regexAggregator.append("(?<").append(component.name).append(">").append(component.literalText.trim()) - .append(")"); - nameAggregator.add(component.name); } } if (nameAggregator != null) { @@ -155,7 +172,7 @@ public URITemplate(String template, boolean prefixMatch) { regexAggregator.append("$"); } components.add(new TemplateComponent(Type.CUSTOM_REGEX, null, null, Pattern.compile(regexAggregator.toString()), - nameAggregator.toArray(new String[0]))); + nameAggregator.toArray(new String[0]), groupAggregator.toArray(new String[0]))); } this.stem = stem; this.literalCharacterCount = litChars; @@ -174,13 +191,13 @@ private String handlePossibleStem(List<TemplateComponent> components, String ste //all JAX-RS paths have an implicit (/.*)? at the end of them //to technically every path has an optional implicit slash stem = stem.substring(0, stem.length() - 1); - components.add(new TemplateComponent(Type.LITERAL, stem, null, null, null)); - components.add(new TemplateComponent(Type.LITERAL, "/", null, null, null)); + components.add(new TemplateComponent(Type.LITERAL, stem, null, null, null, null)); + components.add(new TemplateComponent(Type.LITERAL, "/", null, null, null, null)); } else { - components.add(new TemplateComponent(Type.LITERAL, literal, null, null, null)); + components.add(new TemplateComponent(Type.LITERAL, literal, null, null, null, null)); } } else { - components.add(new TemplateComponent(Type.LITERAL, literal, null, null, null)); + components.add(new TemplateComponent(Type.LITERAL, literal, null, null, null, null)); } return stem; } @@ -269,14 +286,20 @@ public static class TemplateComponent implements Dumpable { /** * The names of all the capturing groups. Only used for CUSTOM_REGEX */ + public final String[] groups; + + /** + * The names of all the components. Only used for CUSTOM_REGEX + */ public final String[] names; - public TemplateComponent(Type type, String literalText, String name, Pattern pattern, String[] names) { + public TemplateComponent(Type type, String literalText, String name, Pattern pattern, String[] names, String[] groups) { this.type = type; this.literalText = literalText; this.name = name; this.pattern = pattern; this.names = names; + this.groups = groups; } @Override diff --git a/independent-projects/resteasy-reactive/server/vertx/src/test/java/org/jboss/resteasy/reactive/server/vertx/test/matching/RegexResource.java b/independent-projects/resteasy-reactive/server/vertx/src/test/java/org/jboss/resteasy/reactive/server/vertx/test/matching/RegexResource.java index 179200a5597..f633fc44b24 100644 --- a/independent-projects/resteasy-reactive/server/vertx/src/test/java/org/jboss/resteasy/reactive/server/vertx/test/matching/RegexResource.java +++ b/independent-projects/resteasy-reactive/server/vertx/src/test/java/org/jboss/resteasy/reactive/server/vertx/test/matching/RegexResource.java @@ -8,8 +8,8 @@ public class RegexResource { @GET - @Path("/{pin:[A-Z0-9]{4}}") - public String hello(@PathParam("pin") String name) { + @Path("/{ 1p-_in. : [A-Z0-9]{4} }") + public String hello(@PathParam("1p-_in.") String name) { return "pin " + name; }

['independent-projects/resteasy-reactive/server/runtime/src/main/java/org/jboss/resteasy/reactive/server/mapping/URITemplate.java', 'independent-projects/resteasy-reactive/server/runtime/src/main/java/org/jboss/resteasy/reactive/server/mapping/RequestMapper.java', 'independent-projects/resteasy-reactive/server/vertx/src/test/java/org/jboss/resteasy/reactive/server/vertx/test/matching/RegexResource.java', 'independent-projects/resteasy-reactive/common/processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java']

{'.java': 4}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/30955/30682

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/30682

https://github.com/quarkusio/quarkus/pull/30955

https://github.com/quarkusio/quarkus/pull/30955

fix

PostgreSQL service binding does not get recognised by Quarkus app

### Describe the bug Since Quarkus 2.15, Quarkus application is unable to bind to PostgreSQL service provided by CrunchyDB. PostgresCluster used: ``` apiVersion: postgres-operator.crunchydata.com/v1beta1 kind: PostgresCluster metadata: name: hippo spec: openshift: true image: registry.developers.crunchydata.com/crunchydata/crunchy-postgres:ubi8-14.2-1 postgresVersion: 14 instances: - name: instance1 dataVolumeClaimSpec: accessModes: - "ReadWriteOnce" resources: requests: storage: 150Mi backups: pgbackrest: image: registry.developers.crunchydata.com/crunchydata/crunchy-pgbackrest:ubi8-2.38-0 repos: - name: repo1 volume: volumeClaimSpec: accessModes: - "ReadWriteOnce" resources: requests: storage: 150Mi ``` `application.properties`: ``` quarkus.kubernetes-service-binding.services.postgresql.api-version=postgres-operator.crunchydata.com/v1beta1 quarkus.kubernetes-service-binding.services.postgresql.kind=PostgresCluster quarkus.kubernetes-service-binding.services.postgresql.name=hippo quarkus.datasource.db-kind=postgresql quarkus.hibernate-orm.database.generation=drop-and-create quarkus.hibernate-orm.sql-load-script=import.sql quarkus.openshift.route.expose=true quarkus.kubernetes.deployment-target=openshift ``` These settings have worked since Quarkus 2.2. ### Expected behavior Service is bound to Quarkus application and the application launches ### Actual behavior Quarkus fails the service binding, application misses datasource configuration and thus fails to start with ``` Model classes are defined for the default persistence unit <default> but configured datasource <default> not found: the default EntityManagerFactory will not be created. To solve this, configure the default datasource. Refer to https://quarkus.io/guides/datasource for guidance. ``` ### How to Reproduce? Reproducer is available at https://github.com/quarkus-qe/quarkus-test-suite 1. Login to OpenShift with SBO and CrunchyDB operator 2. check out https://github.com/quarkus-qe/quarkus-test-suite 3. `cd service-binding/postrgres-crunchy-classic` 4. Run the test to create the `PostgresCluster`, deploy the application and run crud operations on it: `mvn clean verify -Dopenshift` To run with Quarkus that worked with this SB, you can run `mvn clean verify -Dopenshift -Dquarkus.platform.version=2.14.3.Final` To manually deploy the `PostgresCluster` and the application, run the following: ``` oc apply -f ./src/test/resources/pg-cluster.yml # wait for PostgresCluster oc -n ${YOUR_NAMESPACE} wait --for condition=Ready --timeout=300s pods --all # build + deploy app in OCP mvn clean install -Dquarkus.kubernetes-client.trust-certs=true -Dquarkus.kubernetes.deploy=true ``` ### Output of `uname -a` or `ver` Linux tigris 6.1.7-200.fc37.x86_64 #1 SMP PREEMPT_DYNAMIC Wed Jan 18 17:11:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux ### Output of `java -version` openjdk version "17.0.5" 2022-10-18 ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev since 2.15.0 ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Apache Maven 3.8.5 (Red Hat 3.8.5-3) ### Additional information This also fails for reactive Hibernate - for the reproducer, see https://github.com/quarkus-qe/quarkus-test-suite/tree/main/service-binding/postgresql-crunchy-reactive. The application manages to boot there, but it fails when it tries to access the datasource with bogus URL: ``` 18:29:46,010 INFO [app] 17:29:40,998 HR000057: Failed to execute statement [select todo0_.id as id1_0_0_, todo0_.completed as complete2_0_0_, todo0_.title as title3_0_0_ from Todo todo0_ where todo0_.id=$1]: could not load an entity: [io.quarkus.ts.sb.reactive.Todo#1]: java.util.concurrent.CompletionException: io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/127.0.0.1:5432 ```

97ca0febe9ba88736e46e856f69d6320a4ab9b2c

7db652b12c65c9da64cdc954bf45fb9d3d31f849

https://github.com/quarkusio/quarkus/compare/97ca0febe9ba88736e46e856f69d6320a4ab9b2c...7db652b12c65c9da64cdc954bf45fb9d3d31f849

diff --git a/extensions/kubernetes-service-binding/runtime/src/main/java/io/quarkus/kubernetes/service/binding/runtime/DatasourceServiceBindingConfigSourceFactory.java b/extensions/kubernetes-service-binding/runtime/src/main/java/io/quarkus/kubernetes/service/binding/runtime/DatasourceServiceBindingConfigSourceFactory.java index 26f6f31dd35..c1285724923 100644 --- a/extensions/kubernetes-service-binding/runtime/src/main/java/io/quarkus/kubernetes/service/binding/runtime/DatasourceServiceBindingConfigSourceFactory.java +++ b/extensions/kubernetes-service-binding/runtime/src/main/java/io/quarkus/kubernetes/service/binding/runtime/DatasourceServiceBindingConfigSourceFactory.java @@ -8,18 +8,19 @@ public abstract class DatasourceServiceBindingConfigSourceFactory implements Function<ServiceBinding, ServiceBindingConfigSource> { - private static final Logger log = Logger.getLogger(DatasourceServiceBindingConfigSourceFactory.class); private final String configSourceNamePrefix; private final String urlPropertyName; + private final String prefix; private final String urlFormat; protected ServiceBinding serviceBinding; private DatasourceServiceBindingConfigSourceFactory(String configSourceNamePrefix, String urlPropertyName, - String urlFormat) { + String prefix, String urlFormat) { this.configSourceNamePrefix = configSourceNamePrefix; this.urlPropertyName = urlPropertyName; + this.prefix = prefix; this.urlFormat = urlFormat; } @@ -47,14 +48,13 @@ private Map<String, String> getServiceBindingProperties() { log.debugf("Property 'password' was not found for datasource of type %s", serviceBinding.getType()); } - String jdbcURL = bindingProperties.get("jdbc-url"); - if (jdbcURL != null) { - properties.put(urlPropertyName, jdbcURL); + if (configureUrlPropertyUsingKey(properties, "jdbc-url")) { + return properties; + } + if (configureUrlPropertyUsingKey(properties, "jdbc-uri")) { return properties; } - String uri = bindingProperties.get("uri"); - if (uri != null) { - properties.put(urlPropertyName, uri); + if (configureUrlPropertyUsingKey(properties, "uri")) { return properties; } @@ -79,23 +79,37 @@ protected String formatUrl(String urlFormat, String type, String host, String da return String.format(urlFormat, type, host, portPart, database); } + private boolean configureUrlPropertyUsingKey(Map<String, String> properties, String key) { + String value = serviceBinding.getProperties().get(key); + if (value == null) { + return false; + } else if (value.startsWith(prefix)) { + properties.put(urlPropertyName, value); + return true; + } + + log.warnf("The value '%s' from the property '%s' does not start with '%s'. It will be ignored.", + value, key, prefix); + return false; + } + public static class Jdbc extends DatasourceServiceBindingConfigSourceFactory { public Jdbc() { - super("jdbc", "quarkus.datasource.jdbc.url", "jdbc:%s://%s%s/%s"); + this("jdbc:%s://%s%s/%s"); } public Jdbc(String urlFormat) { - super("jdbc", "quarkus.datasource.jdbc.url", urlFormat); + super("jdbc", "quarkus.datasource.jdbc.url", "jdbc:", urlFormat); } } public static class Reactive extends DatasourceServiceBindingConfigSourceFactory { public Reactive() { - super("reactive", "quarkus.datasource.reactive.url", "%s://%s%s/%s"); + this("%s://%s%s/%s"); } public Reactive(String urlFormat) { - super("reactive", "quarkus.datasource.reactive.url", urlFormat); + super("reactive", "quarkus.datasource.reactive.url", "", urlFormat); } } }

['extensions/kubernetes-service-binding/runtime/src/main/java/io/quarkus/kubernetes/service/binding/runtime/DatasourceServiceBindingConfigSourceFactory.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/30940/30919

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/30919

https://github.com/quarkusio/quarkus/pull/30940

https://github.com/quarkusio/quarkus/pull/30940

fix

Compilation to native fails, when quarkus-smallrye-openapi is included

### Describe the bug I have an application, which uses `quarkus-smallrye-openapi` dependency. The application works flawlessly in JVM mode, but fails during `Performing analysis` phase in Native mode. Experimenting shows, that the app fails simply when that dependency is included in pom. ### Expected behavior App should work in both JVM and Native modes ### Actual behavior ``` [2/7] Performing analysis... [] (43.2s @ 1.13GB) 11,264 (91.32%) of 12,334 classes reachable 14,775 (57.48%) of 25,705 fields reachable 47,410 (80.62%) of 58,807 methods reachable 541 classes, 0 fields, and 0 methods registered for reflection Error: java.util.concurrent.ExecutionException: com.oracle.svm.core.util.VMError$HostedError: java.lang.reflect.InvocationTargetException com.oracle.graal.pointsto.util.AnalysisError: java.util.concurrent.ExecutionException: com.oracle.svm.core.util.VMError$HostedError: java.lang.reflect.InvocationTargetException at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.AnalysisError.shouldNotReachHere(AnalysisError.java:173) at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.AnalysisFuture.ensureDone(AnalysisFuture.java:66) at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.heap.ImageHeapScanner.lambda$postTask$12(ImageHeapScanner.java:663) at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.CompletionExecutor.executeCommand(CompletionExecutor.java:193) at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.CompletionExecutor.lambda$executeService$0(CompletionExecutor.java:177) at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1395) at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) Caused by: java.util.concurrent.ExecutionException: com.oracle.svm.core.util.VMError$HostedError: java.lang.reflect.InvocationTargetException at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191) at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.AnalysisFuture.ensureDone(AnalysisFuture.java:64) ... 9 more Caused by: com.oracle.svm.core.util.VMError$HostedError: java.lang.reflect.InvocationTargetException at org.graalvm.nativeimage.builder/com.oracle.svm.core.util.VMError.shouldNotReachHere(VMError.java:72) at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.annotation.AnnotationSubstitutionField.readValue(AnnotationSubstitutionField.java:131) at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.ameta.AnalysisConstantReflectionProvider.readHostedFieldValue(AnalysisConstantReflectionProvider.java:123) at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.heap.SVMImageHeapScanner.readHostedFieldValue(SVMImageHeapScanner.java:122) at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.heap.ImageHeapScanner.createImageHeapObject(ImageHeapScanner.java:277) at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.heap.ImageHeapScanner.lambda$getOrCreateConstantReachableTask$2(ImageHeapScanner.java:203) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.AnalysisFuture.ensureDone(AnalysisFuture.java:63) at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.heap.ImageHeapScanner.getOrCreateConstantReachableTask(ImageHeapScanner.java:215) at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.heap.SVMImageHeapScanner.getOrCreateConstantReachableTask(SVMImageHeapScanner.java:95) at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.heap.ImageHeapScanner.markConstantReachable(ImageHeapScanner.java:179) at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.heap.ImageHeapScanner.onFieldValueReachable(ImageHeapScanner.java:357) at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.heap.ImageHeapScanner.lambda$createImageHeapObject$3(ImageHeapScanner.java:284) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.AnalysisFuture.ensureDone(AnalysisFuture.java:63) ... 9 more Caused by: java.lang.reflect.InvocationTargetException at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.annotation.AnnotationSubstitutionField.readValue(AnnotationSubstitutionField.java:114) ... 22 more Caused by: java.lang.annotation.AnnotationTypeMismatchException: Incorrectly typed data found for annotation element public abstract org.eclipse.microprofile.openapi.annotations.enums.SchemaType org.eclipse.microprofile.openapi.annotations.media.Schema.type() (Found data of type java.lang.String[ARRAY]) at java.base/sun.reflect.annotation.AnnotationTypeMismatchExceptionProxy.generateException(AnnotationTypeMismatchExceptionProxy.java:59) at java.base/sun.reflect.annotation.AnnotationInvocationHandler.invoke(AnnotationInvocationHandler.java:89) at org.graalvm.nativeimage.builder/com.oracle.svm.core.SubstrateAnnotationInvocationHandler.invoke(SubstrateAnnotationInvocationHandler.java:52) at jdk.proxy4/jdk.proxy4.$Proxy141.type(Unknown Source) ... 27 more ``` ### How to Reproduce? 1. `git clone [email protected]:fedinskiy/quarkus-test-suite.git -b reproducer/openapi-failure` 2. `cd quarkus-test-suite/spring/spring-data` 3. `mvn clean verify -Dnative -Dquarkus.platform.version=2.16.1.Final -Pfail` 4. `mvn clean verify -Dnative -Dquarkus.platform.version=2.16.1.Final` — this compiles, but expectedly fails during test phase due to lack of `q/openapi` endpoint ### Output of `uname -a` or `ver` 6.0.18-300.fc37.x86_64 ### Output of `java -version` 17.0.6, vendor: GraalVM Community ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.16.1.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) ### Additional information _No response_

25470b6decca9b6e8689d964bdba8bb4452d582a

0bc09e788b4f40341b98e90b89c051df1e9d936c

https://github.com/quarkusio/quarkus/compare/25470b6decca9b6e8689d964bdba8bb4452d582a...0bc09e788b4f40341b98e90b89c051df1e9d936c

diff --git a/extensions/panache/rest-data-panache/deployment/src/main/java/io/quarkus/rest/data/panache/deployment/methods/StandardMethodImplementor.java b/extensions/panache/rest-data-panache/deployment/src/main/java/io/quarkus/rest/data/panache/deployment/methods/StandardMethodImplementor.java index c46aadc3c26..d12d3a9eb27 100644 --- a/extensions/panache/rest-data-panache/deployment/src/main/java/io/quarkus/rest/data/panache/deployment/methods/StandardMethodImplementor.java +++ b/extensions/panache/rest-data-panache/deployment/src/main/java/io/quarkus/rest/data/panache/deployment/methods/StandardMethodImplementor.java @@ -41,6 +41,7 @@ public abstract class StandardMethodImplementor implements MethodImplementor { private static final String OPENAPI_RESPONSE_ANNOTATION = OPENAPI_PACKAGE + ".responses.APIResponse"; private static final String OPENAPI_CONTENT_ANNOTATION = OPENAPI_PACKAGE + ".media.Content"; private static final String OPENAPI_SCHEMA_ANNOTATION = OPENAPI_PACKAGE + ".media.Schema"; + private static final String SCHEMA_TYPE_CLASS_NAME = "org.eclipse.microprofile.openapi.annotations.enums.SchemaType"; private static final String SCHEMA_TYPE_ARRAY = "ARRAY"; private static final String ROLES_ALLOWED_ANNOTATION = "jakarta.annotation.security.RolesAllowed"; private static final Logger LOGGER = Logger.getLogger(StandardMethodImplementor.class); @@ -197,7 +198,7 @@ protected void addOpenApiResponseAnnotation(AnnotatedElement element, Response.S .add("implementation", clazz); if (isList) { - schemaAnnotation.add("type", SCHEMA_TYPE_ARRAY); + schemaAnnotation.add("type", schemaTypeArray()); } element.addAnnotation(OPENAPI_RESPONSE_ANNOTATION) @@ -235,6 +236,11 @@ protected boolean isNotReactivePanache() { return !capabilities.isPresent(Capability.HIBERNATE_REACTIVE); } + private static Enum schemaTypeArray() { + Class<?> schemaTypeClass = toClass(SCHEMA_TYPE_CLASS_NAME); + return Enum.valueOf((Class<Enum>) schemaTypeClass, SCHEMA_TYPE_ARRAY); + } + private static Class<?> toClass(String className) { ClassLoader classLoader = Thread.currentThread().getContextClassLoader(); try {

['extensions/panache/rest-data-panache/deployment/src/main/java/io/quarkus/rest/data/panache/deployment/methods/StandardMethodImplementor.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/30839/30806

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/30806

https://github.com/quarkusio/quarkus/pull/30839

https://github.com/quarkusio/quarkus/pull/30839

closes

*/* in Accept header is ignored if not listed as the first item

### Describe the bug see https://github.com/quarkusio/quarkus/discussions/30759#discussioncomment-4839300 for description of the bug ### Expected behavior An `*/*` type is always recognized if present in an `Accept` header of GraphQL requests, and the request be handled normally with the default response content type (which is `application/graphql+json`) ### Actual behavior An `*/*` type is recognized only if it's the first item in the `Accept` header, else the GraphQL endpoint returns a 406 Unacceptable response. ### How to Reproduce? _No response_ ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` _No response_ ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev _No response_ ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) _No response_ ### Additional information _No response_

ea3d95daed88f1b2e1d07100117f5fcfb902ce95

4c48dec9dc7dc466aed96fb35fcc263edc619ef5

https://github.com/quarkusio/quarkus/compare/ea3d95daed88f1b2e1d07100117f5fcfb902ce95...4c48dec9dc7dc466aed96fb35fcc263edc619ef5

diff --git a/extensions/smallrye-graphql/runtime/src/main/java/io/quarkus/smallrye/graphql/runtime/SmallRyeGraphQLExecutionHandler.java b/extensions/smallrye-graphql/runtime/src/main/java/io/quarkus/smallrye/graphql/runtime/SmallRyeGraphQLExecutionHandler.java index 127e1ed8cc7..6f8787beebb 100644 --- a/extensions/smallrye-graphql/runtime/src/main/java/io/quarkus/smallrye/graphql/runtime/SmallRyeGraphQLExecutionHandler.java +++ b/extensions/smallrye-graphql/runtime/src/main/java/io/quarkus/smallrye/graphql/runtime/SmallRyeGraphQLExecutionHandler.java @@ -223,10 +223,14 @@ private String getRequestAccept(RoutingContext ctx) { if (isValidAcceptRequest(a.rawValue())) { return a.rawValue(); } + + if (a.rawValue().startsWith("*/*")) { + return DEFAULT_RESPONSE_CONTENT_TYPE; + } } // Seems like an unknown accept is passed in String accept = ctx.request().getHeader("Accept"); - if (accept != null && !accept.isEmpty() && !accept.startsWith("*/*")) { + if (accept != null && !accept.isEmpty()) { return accept; } }

['extensions/smallrye-graphql/runtime/src/main/java/io/quarkus/smallrye/graphql/runtime/SmallRyeGraphQLExecutionHandler.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25035/25029

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25029

https://github.com/quarkusio/quarkus/pull/25035

https://github.com/quarkusio/quarkus/pull/25035

fixes

REST Reactive Client when retried, Authorization header is multiplied by OidcClientRequestReactiveFilter

### Describe the bug When we have a REST Reactive Client with OidcClientRequestReactiveFilter, and we retry the requests through Mutiny, the Authorization header gets multiplied with each new retry. This results in AWS API Gateway to immediately reject the requests with Bad Request. Is there a configuration or something we can do to change this behaviour or is this something that needs to be fixed ? ### Expected behavior Only a single Authorization header in the retried requests. ### Actual behavior Authorization headers keep increasing with each retry request. ### How to Reproduce? Given the rest client; ``` @RegisterRestClient(configKey = "my-api") @RegisterProvider(OidcClientRequestReactiveFilter.class) @Path("/api/v1") public interface MyApi { @POST @Path("/something") Uni<SomethingResponse> postSomething(Something body); } ``` When; ``` myApi.postSomething(body).onFailure().retry().indefinitely(); ``` Then each retry keeps appending a new Authorization header to the request. ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` Java 11 ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.8.1 ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) _No response_ ### Additional information _No response_

731abc35ccad9851c8a2e8a4c3d4e6adfed5e602

aeb39f1797b78dcee969972de240fdc2e8f1d2be

https://github.com/quarkusio/quarkus/compare/731abc35ccad9851c8a2e8a4c3d4e6adfed5e602...aeb39f1797b78dcee969972de240fdc2e8f1d2be

diff --git a/extensions/oidc-client-reactive-filter/runtime/src/main/java/io/quarkus/oidc/client/reactive/filter/OidcClientRequestReactiveFilter.java b/extensions/oidc-client-reactive-filter/runtime/src/main/java/io/quarkus/oidc/client/reactive/filter/OidcClientRequestReactiveFilter.java index 7508e906ecb..f7c12963d77 100644 --- a/extensions/oidc-client-reactive-filter/runtime/src/main/java/io/quarkus/oidc/client/reactive/filter/OidcClientRequestReactiveFilter.java +++ b/extensions/oidc-client-reactive-filter/runtime/src/main/java/io/quarkus/oidc/client/reactive/filter/OidcClientRequestReactiveFilter.java @@ -41,7 +41,8 @@ public void filter(ResteasyReactiveClientRequestContext requestContext) { super.getTokens().subscribe().with(new Consumer<Tokens>() { @Override public void accept(Tokens tokens) { - requestContext.getHeaders().add(HttpHeaders.AUTHORIZATION, BEARER_SCHEME_WITH_SPACE + tokens.getAccessToken()); + requestContext.getHeaders().putSingle(HttpHeaders.AUTHORIZATION, + BEARER_SCHEME_WITH_SPACE + tokens.getAccessToken()); requestContext.resume(); } }, new Consumer<Throwable>() {

['extensions/oidc-client-reactive-filter/runtime/src/main/java/io/quarkus/oidc/client/reactive/filter/OidcClientRequestReactiveFilter.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25127/25123

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25123

https://github.com/quarkusio/quarkus/pull/25127

https://github.com/quarkusio/quarkus/pull/25127

resolves

MP Config - programmatic lookup of "custom" type config property fails

### Describe the bug If there's a `Provider/Instance` injection point whose required type is not handled by the `ConfigProducer` (aka "custom type") then a synthetic bean with a wrong set of bean types is generated. The bean has the type `Provider<Foo>/Instance<Foo>` instead of `Foo`. As a result, if there's an injection point like `@ConfigProperty(name = "foo.val") Provider<Foo> foo` then `foo.get()` results in an `UnsatisfiedResolutionException`. Note that this error only occurs if there is no regular injection point for the given custom type, i.e. no exception is thrown if there's also `@ConfigProperty(name = "foo.val") Foo foo`. ### Quarkus version or git rev 999-SNAPSHOT

cdf0738a1892c89bf8d1ef687cc46b204dfe3b4d

0274b7a5e1502fae2bc6c1b865cc68980ff82924

https://github.com/quarkusio/quarkus/compare/cdf0738a1892c89bf8d1ef687cc46b204dfe3b4d...0274b7a5e1502fae2bc6c1b865cc68980ff82924

diff --git a/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ConfigBuildStep.java b/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ConfigBuildStep.java index e442f72837c..53808672a5a 100644 --- a/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ConfigBuildStep.java +++ b/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ConfigBuildStep.java @@ -106,7 +106,7 @@ void registerCustomConfigBeanTypes(BeanDiscoveryFinishedBuildItem beanDiscovery, AnnotationInstance configProperty = injectionPoint.getRequiredQualifier(MP_CONFIG_PROPERTY_NAME); if (configProperty != null) { // Register a custom bean for injection points that are not handled by ConfigProducer - Type injectedType = injectionPoint.getType(); + Type injectedType = injectionPoint.getRequiredType(); if (!isHandledByProducers(injectedType)) { customBeanTypes.add(injectedType); } diff --git a/extensions/arc/deployment/src/test/java/io/quarkus/arc/test/config/ConfigImplicitConverterTest.java b/extensions/arc/deployment/src/test/java/io/quarkus/arc/test/config/ConfigImplicitConverterTest.java index 0ddcf2d264d..1762af06bdf 100644 --- a/extensions/arc/deployment/src/test/java/io/quarkus/arc/test/config/ConfigImplicitConverterTest.java +++ b/extensions/arc/deployment/src/test/java/io/quarkus/arc/test/config/ConfigImplicitConverterTest.java @@ -4,6 +4,7 @@ import javax.enterprise.context.ApplicationScoped; import javax.inject.Inject; +import javax.inject.Provider; import org.eclipse.microprofile.config.inject.ConfigProperty; import org.jboss.shrinkwrap.api.asset.StringAsset; @@ -17,8 +18,8 @@ public class ConfigImplicitConverterTest { @RegisterExtension static final QuarkusUnitTest config = new QuarkusUnitTest() .withApplicationRoot((jar) -> jar - .addClasses(Configured.class) - .addAsResource(new StringAsset("foo=1"), "application.properties")); + .addClasses(Configured.class, Foo.class, Bar.class) + .addAsResource(new StringAsset("foo=1\\nbar=1"), "application.properties")); @Inject Configured configured; @@ -26,6 +27,7 @@ public class ConfigImplicitConverterTest { @Test public void testFoo() { assertEquals("1", configured.getFooValue()); + assertEquals("1", configured.getBarProviderValue()); } @ApplicationScoped @@ -35,9 +37,17 @@ static class Configured { @ConfigProperty(name = "foo") Foo foo; + @ConfigProperty(name = "bar") + Provider<Bar> barProvider; + String getFooValue() { return foo != null ? foo.value : null; } + + String getBarProviderValue() { + return barProvider.get().value; + } + } public static class Foo { @@ -50,4 +60,14 @@ public Foo(String value) { } + public static class Bar { + + String value; + + public Bar(String value) { + this.value = value; + } + + } + }

['extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ConfigBuildStep.java', 'extensions/arc/deployment/src/test/java/io/quarkus/arc/test/config/ConfigImplicitConverterTest.java']

{'.java': 2}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25166/25016

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25016

https://github.com/quarkusio/quarkus/pull/25166

https://github.com/quarkusio/quarkus/pull/25166

close

CLI creates kotlin project even with explicit `--java 11 --gradle-kotlin-dsl`

### Describe the bug `quarkus create app --java 11 --gradle-kotlin-dsl` creates Kotlin project instead of java one: ```kotlin plugins { kotlin("jvm") version "1.6.10" kotlin("plugin.allopen") version "1.6.10" id("io.quarkus") } ``` ### Expected behavior Gradle scripts use Kotlin DSL but java project. ### Actual behavior Gradle scripts use Kotlin DSL with kotlin project. ### How to Reproduce? Run `quarkus create app --java 11 --gradle-kotlin-dsl` ### Output of `uname -a` or `ver` Linux unterwelt 5.17.1-arch1-1 #1 SMP PREEMPT Mon, 28 Mar 2022 20:55:33 +0000 x86_64 GNU/Linux ### Output of `java -version` OpenJDK 64-Bit Server VM Temurin-17.0.2+8 (build 17.0.2+8, mixed mode, sharing) ### GraalVM version (if different from Java) N/A ### Quarkus version or git rev 2.8.0.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) N/A ### Additional information _No response_

316e5a0906c1a9c1a532c1eb02aa7540a354dffc

d95a373ea91f895f55cff04c5cc966c19782b35e

https://github.com/quarkusio/quarkus/compare/316e5a0906c1a9c1a532c1eb02aa7540a354dffc...d95a373ea91f895f55cff04c5cc966c19782b35e

diff --git a/devtools/cli/src/main/java/io/quarkus/cli/create/TargetLanguageGroup.java b/devtools/cli/src/main/java/io/quarkus/cli/create/TargetLanguageGroup.java index 2ac56d3063b..4248ba04c6c 100644 --- a/devtools/cli/src/main/java/io/quarkus/cli/create/TargetLanguageGroup.java +++ b/devtools/cli/src/main/java/io/quarkus/cli/create/TargetLanguageGroup.java @@ -44,7 +44,7 @@ public SourceType getSourceType(CommandSpec spec, BuildTool buildTool, Set<Strin if (kotlin || scala) { output.warn("JBang only supports Java. Using Java as the target language."); } - } else if (kotlin || BuildTool.GRADLE_KOTLIN_DSL == buildTool) { + } else if (kotlin) { sourceType = SourceType.KOTLIN; } else if (scala) { sourceType = SourceType.SCALA; diff --git a/devtools/cli/src/test/java/io/quarkus/cli/CliProjectGradleTest.java b/devtools/cli/src/test/java/io/quarkus/cli/CliProjectGradleTest.java index ec4fe18daf7..37d84327b3f 100644 --- a/devtools/cli/src/test/java/io/quarkus/cli/CliProjectGradleTest.java +++ b/devtools/cli/src/test/java/io/quarkus/cli/CliProjectGradleTest.java @@ -106,7 +106,7 @@ public void testCreateAppDefaults() throws Exception { Assertions.assertTrue(project.resolve("gradlew").toFile().exists(), "Wrapper should exist by default"); - String buildGradleContent = validateBasicIdentifiers(project, CreateProjectHelper.DEFAULT_GROUP_ID, + String buildGradleContent = validateBasicGradleGroovyIdentifiers(project, CreateProjectHelper.DEFAULT_GROUP_ID, CreateProjectHelper.DEFAULT_ARTIFACT_ID, CreateProjectHelper.DEFAULT_VERSION); Assertions.assertTrue(buildGradleContent.contains("quarkus-resteasy"), @@ -117,6 +117,31 @@ public void testCreateAppDefaults() throws Exception { CliDriver.invokeValidateBuild(project); } + @Test + public void testCreateAppDefaultsWithKotlinDSL() throws Exception { + CliDriver.Result result = CliDriver.execute(workspaceRoot, "create", "app", "--gradle-kotlin-dsl", "--verbose", "-e", + "-B"); + Assertions.assertEquals(CommandLine.ExitCode.OK, result.exitCode, "Expected OK return code." + result); + Assertions.assertTrue(result.stdout.contains("SUCCESS"), + "Expected confirmation that the project has been created." + result); + + Assertions.assertTrue(project.resolve("gradlew").toFile().exists(), + "Wrapper should exist by default"); + String buildGradleContent = validateBasicGradleKotlinIdentifiers(project, CreateProjectHelper.DEFAULT_GROUP_ID, + CreateProjectHelper.DEFAULT_ARTIFACT_ID, + CreateProjectHelper.DEFAULT_VERSION); + Assertions.assertTrue(buildGradleContent.contains("quarkus-resteasy"), + "build/gradle should contain quarkus-resteasy:\\n" + buildGradleContent); + + Path packagePath = wrapperRoot.resolve("src/main/java/"); + Assertions.assertTrue(packagePath.toFile().isDirectory(), + "Java Source directory should exist: " + packagePath.toAbsolutePath()); + + CliDriver.valdiateGeneratedSourcePackage(project, "org/acme"); + + CliDriver.invokeValidateBuild(project); + } + @Test public void testCreateAppOverrides() throws Exception { Path nested = workspaceRoot.resolve("cli-nested"); @@ -140,7 +165,7 @@ public void testCreateAppOverrides() throws Exception { Assertions.assertTrue(project.resolve("gradlew").toFile().exists(), "Wrapper should exist by default"); - String buildGradleContent = validateBasicIdentifiers(project, "silly", "my-project", "0.1.0"); + String buildGradleContent = validateBasicGradleGroovyIdentifiers(project, "silly", "my-project", "0.1.0"); Assertions.assertTrue(buildGradleContent.contains("quarkus-resteasy-reactive"), "build.gradle should contain quarkus-resteasy-reactive:\\n" + buildGradleContent); @@ -163,7 +188,7 @@ public void testCreateCliDefaults() throws Exception { Assertions.assertTrue(project.resolve("gradlew").toFile().exists(), "Wrapper should exist by default"); - String buildGradleContent = validateBasicIdentifiers(project, CreateProjectHelper.DEFAULT_GROUP_ID, + String buildGradleContent = validateBasicGradleGroovyIdentifiers(project, CreateProjectHelper.DEFAULT_GROUP_ID, CreateProjectHelper.DEFAULT_ARTIFACT_ID, CreateProjectHelper.DEFAULT_VERSION); Assertions.assertFalse(buildGradleContent.contains("quarkus-resteasy"), @@ -374,7 +399,7 @@ public void testCreateArgJava17() throws Exception { "Java 17 should be used when specified. Found:\\n" + buildGradleContent); } - String validateBasicIdentifiers(Path project, String group, String artifact, String version) throws Exception { + String validateBasicGradleGroovyIdentifiers(Path project, String group, String artifact, String version) throws Exception { Path buildGradle = project.resolve("build.gradle"); Assertions.assertTrue(buildGradle.toFile().exists(), "build.gradle should exist: " + buildGradle.toAbsolutePath().toString()); @@ -394,4 +419,25 @@ String validateBasicIdentifiers(Path project, String group, String artifact, Str return buildContent; } + + String validateBasicGradleKotlinIdentifiers(Path project, String group, String artifact, String version) throws Exception { + Path buildGradle = project.resolve("build.gradle.kts"); + Assertions.assertTrue(buildGradle.toFile().exists(), + "build.gradle.kts should exist: " + buildGradle.toAbsolutePath().toString()); + + String buildContent = CliDriver.readFileAsString(project, buildGradle); + Assertions.assertTrue(buildContent.contains("group = \\"" + group + "\\""), + "build.gradle.kts should include the group id:\\n" + buildContent); + Assertions.assertTrue(buildContent.contains("version = \\"" + version + "\\""), + "build.gradle.kts should include the version:\\n" + buildContent); + + Path settings = project.resolve("settings.gradle.kts"); + Assertions.assertTrue(settings.toFile().exists(), + "settings.gradle.kts should exist: " + settings.toAbsolutePath().toString()); + String settingsContent = CliDriver.readFileAsString(project, settings); + Assertions.assertTrue(settingsContent.contains(artifact), + "settings.gradle.kts should include the artifact id:\\n" + settingsContent); + + return buildContent; + } }

['devtools/cli/src/main/java/io/quarkus/cli/create/TargetLanguageGroup.java', 'devtools/cli/src/test/java/io/quarkus/cli/CliProjectGradleTest.java']

{'.java': 2}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25182/25178

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25178

https://github.com/quarkusio/quarkus/pull/25182

https://github.com/quarkusio/quarkus/pull/25182

fixes

Log when creating cache entry on synchronous calls

### Describe the bug Currently there is no way to know when the cache entry is created using synchronous calls, the only log seen for synchronous calls are during the loading phase from the cache. ### Expected behavior It would be better to log before creating cache entries in quarkus ### Actual behavior Show "Adding entry with key [%s] into cache [%s]" msg when adding cache entry through synchronous calls ### How to Reproduce? Use quarkus cache and hit the call for the first time, no logs are seen on cache creation. ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` _No response_ ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev _No response_ ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) _No response_ ### Additional information _No response_

6907d73a6011abff9e2da9972ab3f5fde8e24727

6fc6c85321a8db21bfa7c10a2c2b0f7a09569669

https://github.com/quarkusio/quarkus/compare/6907d73a6011abff9e2da9972ab3f5fde8e24727...6fc6c85321a8db21bfa7c10a2c2b0f7a09569669

diff --git a/extensions/cache/runtime/src/main/java/io/quarkus/cache/runtime/CacheResultInterceptor.java b/extensions/cache/runtime/src/main/java/io/quarkus/cache/runtime/CacheResultInterceptor.java index d048be69f93..722595d0f19 100644 --- a/extensions/cache/runtime/src/main/java/io/quarkus/cache/runtime/CacheResultInterceptor.java +++ b/extensions/cache/runtime/src/main/java/io/quarkus/cache/runtime/CacheResultInterceptor.java @@ -103,6 +103,8 @@ public Uni<?> get() { @Override public Object apply(Object k) { try { + LOGGER.debugf("Adding entry with key [%s] into cache [%s]", + key, binding.cacheName()); return invocationContext.proceed(); } catch (CacheException e) { throw e;

['extensions/cache/runtime/src/main/java/io/quarkus/cache/runtime/CacheResultInterceptor.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25203/25184

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25184

https://github.com/quarkusio/quarkus/pull/25203

https://github.com/quarkusio/quarkus/pull/25203

fix

`-Dquarkus.platform.version` is not honored during reload of dev mode

### Describe the bug Custom `-Dquarkus.platform.version` is not honored during reload of dev mode, version defined in pom.xml gets picked I have triggered the reload by removal of `quarkus-arc` dependency from pom.xml Dev mode was started using `mvn quarkus:dev -Dquarkus.platform.version=2.7.5.Final` Once the change of `pom.xml` was detected I had seen a lot of downloads of 2.8.2.Final bits and then the dev mode exited saying that the version of Quarkus was changed. ``` ... Downloaded from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-core-deployment/2.8.2.Final/quarkus-core-deployment-2.8.2.Final.jar (1.2 MB at 959 kB/s) Downloaded from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-vertx-http-deployment/2.8.2.Final/quarkus-vertx-http-deployment-2.8.2.Final.jar (2.2 MB at 1.4 MB/s) Downloaded from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-bootstrap-gradle-resolver/2.8.2.Final/quarkus-bootstrap-gradle-resolver-2.8.2.Final.jar (2.4 MB at 1.5 MB/s) Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/platform/quarkus-bom-quarkus-platform-properties/2.8.2.Final/quarkus-bom-quarkus-platform-properties-2.8.2.Final.properties Downloaded from central: https://repo.maven.apache.org/maven2/io/quarkus/platform/quarkus-bom-quarkus-platform-properties/2.8.2.Final/quarkus-bom-quarkus-platform-properties-2.2022-04-26 22:28:55,037 INFO [io.quarkus] (Shutdown thread) code-with-quarkus stopped in 0.024s -- Press [:] for the terminal, [h] for more options> Exception in thread "main" java.lang.RuntimeException: java.lang.RuntimeException: java.lang.IllegalStateException: Hot deployment of the application is not supported when updating the Quarkus version. The application needs to be stopped and dev mode started up again at io.quarkus.deployment.dev.DevModeMain.start(DevModeMain.java:138) at io.quarkus.deployment.dev.DevModeMain.main(DevModeMain.java:62) Caused by: java.lang.RuntimeException: java.lang.IllegalStateException: Hot deployment of the application is not supported when updating the Quarkus version. The application needs to be stopped and dev mode started up again at io.quarkus.bootstrap.app.CuratedApplication.runInCl(CuratedApplication.java:143) at io.quarkus.bootstrap.app.CuratedApplication.runInAugmentClassLoader(CuratedApplication.java:96) at io.quarkus.deployment.dev.DevModeMain.start(DevModeMain.java:132) ... 1 more Caused by: java.lang.IllegalStateException: Hot deployment of the application is not supported when updating the Quarkus version. The application needs to be stopped and dev mode started up again at io.quarkus.deployment.dev.IsolatedDevModeMain.close(IsolatedDevModeMain.java:367) at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:512) at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:68) at io.quarkus.bootstrap.app.CuratedApplication.runInCl(CuratedApplication.java:140) ... 3 more ``` As the application in the dev mode runs using the version specified using `-Dquarkus.platform.version=` property I would expect the same version to be used after reload ### Expected behavior Custom `-Dquarkus.platform.version` is honored during reload of dev mode ### Actual behavior Custom `-Dquarkus.platform.version` is not honored during reload of dev mode, version defined in pom.xml gets picked ### How to Reproduce? - download app from https://code.quarkus.io/?e=resteasy-reactive - open pom.xml - run `mvn quarkus:dev -Dquarkus.platform.version=2.7.5.Final` - remove `quarkus-arc` dependency - check the console ### Output of `uname -a` or `ver` macOS Monterey ### Output of `java -version` Java 17 ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.8.2.Final ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) _No response_ ### Additional information _No response_

871675fb8b8d0d5db4b2ba624be000760a419b41

f900e2a726c428e983caff419446eb08f9f556c9

https://github.com/quarkusio/quarkus/compare/871675fb8b8d0d5db4b2ba624be000760a419b41...f900e2a726c428e983caff419446eb08f9f556c9

diff --git a/devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java b/devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java index 82601628f75..212bef2d92d 100644 --- a/devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java +++ b/devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java @@ -990,7 +990,6 @@ private QuarkusDevModeLauncher newLauncher() throws Exception { bootstrapProvider.close(); } else { final MavenArtifactResolver.Builder resolverBuilder = MavenArtifactResolver.builder() - .setRepositorySystem(repoSystem) .setRemoteRepositories(repos) .setRemoteRepositoryManager(remoteRepositoryManager) .setWorkspaceDiscovery(true) @@ -1002,16 +1001,18 @@ private QuarkusDevModeLauncher newLauncher() throws Exception { boolean reinitializeMavenSession = Files.exists(appModelLocation); if (reinitializeMavenSession) { Files.delete(appModelLocation); + // we can't re-use the repo system because we want to use our interpolating model builder + // a use-case where it fails with the original repo system is when dev mode is launched with -Dquarkus.platform.version=xxx + // overriding the version of the quarkus-bom in the pom.xml } else { // we can re-use the original Maven session - resolverBuilder.setRepositorySystemSession(repoSession); + resolverBuilder.setRepositorySystemSession(repoSession).setRepositorySystem(repoSystem); } appModel = new BootstrapAppModelResolver(resolverBuilder.build()) .setDevMode(true) .setCollectReloadableDependencies(!noDeps) - .resolveModel(new GACTV(project.getGroupId(), project.getArtifactId(), null, ArtifactCoords.TYPE_JAR, - project.getVersion())); + .resolveModel(GACTV.jar(project.getGroupId(), project.getArtifactId(), project.getVersion())); } // serialize the app model to avoid re-resolving it in the dev process diff --git a/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/BootstrapAppModelResolver.java b/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/BootstrapAppModelResolver.java index 31f965bafee..fd0475a0811 100644 --- a/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/BootstrapAppModelResolver.java +++ b/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/BootstrapAppModelResolver.java @@ -259,8 +259,8 @@ private ApplicationModel doResolveModel(ArtifactCoords coords, } final Artifact mvnArtifact = toAetherArtifact(coords); - List<Dependency> managedDeps = Collections.emptyList(); - List<RemoteRepository> managedRepos = Collections.emptyList(); + List<Dependency> managedDeps = List.of(); + List<RemoteRepository> managedRepos = List.of(); if (managingProject != null) { final ArtifactDescriptorResult managingDescr = mvn.resolveDescriptor(toAetherArtifact(managingProject)); managedDeps = managingDescr.getManagedDependencies(); @@ -271,14 +271,14 @@ private ApplicationModel doResolveModel(ArtifactCoords coords, final List<String> excludedScopes; if (test) { - excludedScopes = Collections.emptyList(); + excludedScopes = List.of(); } else if (devmode) { - excludedScopes = Collections.singletonList("test"); + excludedScopes = List.of("test"); } else { excludedScopes = List.of("provided", "test"); } - DependencyNode resolvedDeps = mvn.resolveManagedDependencies(mvnArtifact, + final DependencyNode resolvedDeps = mvn.resolveManagedDependencies(mvnArtifact, directMvnDeps, managedDeps, managedRepos, excludedScopes.toArray(new String[0])).getRoot(); ArtifactDescriptorResult appArtifactDescr = mvn.resolveDescriptor(toAetherArtifact(appArtifact)); diff --git a/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/BootstrapModelResolver.java b/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/BootstrapModelResolver.java index 979ad84c416..086c8e5a278 100644 --- a/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/BootstrapModelResolver.java +++ b/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/BootstrapModelResolver.java @@ -1,6 +1,7 @@ package io.quarkus.bootstrap.resolver.maven; import io.quarkus.bootstrap.resolver.maven.workspace.LocalWorkspace; +import io.quarkus.maven.dependency.ArtifactCoords; import java.io.File; import java.util.ArrayList; import java.util.Collection; @@ -203,7 +204,7 @@ public ModelSource resolveModel(final Dependency dependency) throws UnresolvableModelException { try { final Artifact artifact = new DefaultArtifact(dependency.getGroupId(), dependency.getArtifactId(), "", - "pom", dependency.getVersion()); + ArtifactCoords.TYPE_POM, dependency.getVersion()); final VersionRangeRequest versionRangeRequest = new VersionRangeRequest(artifact, repositories, context); versionRangeRequest.setTrace(trace); diff --git a/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/MavenModelBuilder.java b/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/MavenModelBuilder.java index 3a3d39bc40d..2b25e09de8b 100644 --- a/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/MavenModelBuilder.java +++ b/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/MavenModelBuilder.java @@ -3,6 +3,7 @@ import io.quarkus.bootstrap.resolver.maven.options.BootstrapMavenOptions; import io.quarkus.bootstrap.resolver.maven.workspace.LocalWorkspace; import io.quarkus.bootstrap.resolver.maven.workspace.ModelUtils; +import io.quarkus.maven.dependency.ArtifactCoords; import java.io.File; import java.io.IOException; import java.util.HashSet; @@ -40,7 +41,7 @@ public ModelBuildingResult build(ModelBuildingRequest request) throws ModelBuild final Model requestModel = getModel(request); if (requestModel != null) { final Artifact artifact = new DefaultArtifact(ModelUtils.getGroupId(requestModel), requestModel.getArtifactId(), - null, "pom", + null, ArtifactCoords.TYPE_POM, ModelUtils.getVersion(requestModel)); if (workspace.findArtifact(artifact) != null) { final ModelBuildingResult result = workspace diff --git a/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/workspace/LocalProject.java b/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/workspace/LocalProject.java index f425202e472..ff9825075ef 100644 --- a/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/workspace/LocalProject.java +++ b/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/workspace/LocalProject.java @@ -408,7 +408,9 @@ private String resolveElementValue(String elementValue) { if (elementValue == null || elementValue.isEmpty() || !(elementValue.startsWith("${") && elementValue.endsWith("}"))) { return elementValue; } - return rawModel.getProperties().getProperty(elementValue.substring(2, elementValue.length() - 1), elementValue); + final String propName = elementValue.substring(2, elementValue.length() - 1); + String v = System.getProperty(propName); + return v == null ? rawModel.getProperties().getProperty(propName, elementValue) : v; } private DefaultArtifactSources processJarPluginExecutionConfig(Object config, boolean test) { diff --git a/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/workspace/LocalWorkspace.java b/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/workspace/LocalWorkspace.java index 3b38e304b43..94522979413 100644 --- a/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/workspace/LocalWorkspace.java +++ b/independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/workspace/LocalWorkspace.java @@ -109,7 +109,7 @@ public File findArtifact(Artifact artifact) { if (ArtifactCoords.TYPE_POM.equals(artifact.getExtension())) { final File pom = lp.getRawModel().getPomFile(); // if the pom exists we should also check whether the main artifact can also be resolved from the workspace - if (pom.exists() && ("pom".equals(lp.getRawModel().getPackaging()) + if (pom.exists() && (ArtifactCoords.TYPE_POM.equals(lp.getRawModel().getPackaging()) || mvnCtx != null && mvnCtx.isPreferPomsFromWorkspace() || Files.exists(lp.getOutputDir()) || emptyJarOutput(lp, artifact) != null)) {

['independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/workspace/LocalProject.java', 'independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/BootstrapModelResolver.java', 'independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/MavenModelBuilder.java', 'independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/workspace/LocalWorkspace.java', 'independent-projects/bootstrap/maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/BootstrapAppModelResolver.java', 'devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java']

{'.java': 6}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25226/25225

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25225

https://github.com/quarkusio/quarkus/pull/25226

https://github.com/quarkusio/quarkus/pull/25226

fixes

`Forwarded` header is not parsed as expected

### Describe the bug According to [RFC7239](https://www.rfc-editor.org/rfc/rfc7239#section-4), the `Forwarded` header can have a comma-separated list of values. It is used to indicate the string of proxies (including the client that initiated the request). The ForwardedParser class splits this header by comma and later considers only the first element. This element will be the one that will determine each property of the request (protocol, host, etc). This is not the expected behavior as it will discard the remaining information in the header, as you will see in the next sections. ### Expected behavior When a client does a HTTP request with the following header, `Forwarded: by=proxy;for=backend:4444,for=backend2:5555;host=somehost;proto=https`, the quarkus server must consider `host` and `proto` properties defined by the header. ### Actual behavior The properties `host` and `proto` are not considered, and eventually discarded. ### How to Reproduce? ``` @Test public void testForwardedForWithSequenceOfProxies() { assertThat(RestAssured.get("/forward").asString()).startsWith("http|"); RestAssured.given() .header("Forwarded", "by=proxy;for=backend:4444,for=backend2:5555;host=somehost;proto=https") .get("/forward") .then() .body(Matchers.equalTo("https|somehost|backend:4444")); } ``` ### Output of `uname -a` or `ver` Darwin dibss-MacBook-Pro.local 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:45:05 PDT 2022; root:xnu-8020.101.4~15/RELEASE_X86_64 x86_64 ### Output of `java -version` openjdk version "11.0.15" 2022-04-19 OpenJDK Runtime Environment Temurin-11.0.15+10 (build 11.0.15+10) OpenJDK 64-Bit Server VM Temurin-11.0.15+10 (build 11.0.15+10, mixed mode) ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev _No response_ ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) ### Additional information _No response_

ad1a40dd4520bfe94249b094c43f1147d5d00224

b67f5bfca37f7295fdfe8168293f7c9604192d16

https://github.com/quarkusio/quarkus/compare/ad1a40dd4520bfe94249b094c43f1147d5d00224...b67f5bfca37f7295fdfe8168293f7c9604192d16

diff --git a/extensions/vertx-http/deployment/src/test/java/io/quarkus/vertx/http/ForwardedHeaderTest.java b/extensions/vertx-http/deployment/src/test/java/io/quarkus/vertx/http/ForwardedHeaderTest.java index eab3ac1503c..9fc8a8b841d 100644 --- a/extensions/vertx-http/deployment/src/test/java/io/quarkus/vertx/http/ForwardedHeaderTest.java +++ b/extensions/vertx-http/deployment/src/test/java/io/quarkus/vertx/http/ForwardedHeaderTest.java @@ -30,4 +30,36 @@ public void test() { .body(Matchers.equalTo("https|somehost|backend:4444")); } + @Test + public void testForwardedForWithSequenceOfProxies() { + assertThat(RestAssured.get("/forward").asString()).startsWith("http|"); + + RestAssured.given() + .header("Forwarded", "by=proxy;for=backend:4444,for=backend2:5555;host=somehost;proto=https") + .get("/forward") + .then() + .body(Matchers.equalTo("https|somehost|backend:4444")); + } + + @Test + public void testForwardedWithSequenceOfProxiesIncludingIpv6Address() { + assertThat(RestAssured.get("/forward").asString()).startsWith("http|"); + + RestAssured.given() + .header("Forwarded", "by=proxy;for=\\"[2001:db8:cafe::17]:47011\\",for=backend:4444;host=somehost;proto=https") + .get("/forward") + .then() + .body(Matchers.equalTo("https|somehost|[2001:db8:cafe::17]:47011")); + } + + @Test + public void testForwardedForWithIpv6Address2() { + assertThat(RestAssured.get("/forward").asString()).startsWith("http|"); + + RestAssured.given() + .header("Forwarded", "by=proxy;for=\\"[2001:db8:cafe::17]:47011\\",for=backend:4444;host=somehost;proto=https") + .get("/forward") + .then() + .body(Matchers.equalTo("https|somehost|[2001:db8:cafe::17]:47011")); + } } diff --git a/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/ForwardedParser.java b/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/ForwardedParser.java index aab3cabcb6d..3755c618715 100644 --- a/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/ForwardedParser.java +++ b/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/ForwardedParser.java @@ -110,19 +110,18 @@ private void calculate() { String forwarded = delegate.getHeader(FORWARDED); if (forwardingProxyOptions.allowForwarded && forwarded != null) { - String forwardedToUse = forwarded.split(",")[0]; - Matcher matcher = FORWARDED_PROTO_PATTERN.matcher(forwardedToUse); + Matcher matcher = FORWARDED_PROTO_PATTERN.matcher(forwarded); if (matcher.find()) { scheme = (matcher.group(1).trim()); port = -1; } - matcher = FORWARDED_HOST_PATTERN.matcher(forwardedToUse); + matcher = FORWARDED_HOST_PATTERN.matcher(forwarded); if (matcher.find()) { setHostAndPort(matcher.group(1).trim(), port); } - matcher = FORWARDED_FOR_PATTERN.matcher(forwardedToUse); + matcher = FORWARDED_FOR_PATTERN.matcher(forwarded); if (matcher.find()) { remoteAddress = parseFor(matcher.group(1).trim(), remoteAddress.port()); }

['extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/ForwardedParser.java', 'extensions/vertx-http/deployment/src/test/java/io/quarkus/vertx/http/ForwardedHeaderTest.java']

{'.java': 2}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25234/25221

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25221

https://github.com/quarkusio/quarkus/pull/25234

https://github.com/quarkusio/quarkus/pull/25234

fixes

Missing `quarkus.oidc.tls.key-store-provider` and `quarkus.oidc.tls.trust-store-provider` properties on OIDC extension

### Describe the bug I would like to use OIDC with mtls over FIPS. The certificates that I am thinking to use are `BCFIPSJSSE` (BouncyCastleJsseProvider) as we do in other [modules](https://quarkus.io/guides/security-customization#bouncy-castle-jsse-fips). The problem that I have is that there is no `quarkus.oidc.tls.key-store-provider` / `quarkus.oidc.tls.trust-store-provider`. application.properties ``` quarkus.http.auth.permission.authenticated.paths=/* quarkus.http.auth.permission.authenticated.policy=authenticated quarkus.oidc.token.lifespan-grace=5 quarkus.oidc.token.principal-claim=email quarkus.oidc.token.issuer=${quarkus.oidc.auth-server-url} quarkus.oidc.tls.verification=certificate-validation quarkus.oidc.tls.key-store-file=client-bcfips-keystore.jks #quarkus.oidc.tls.key-store-file=client-keystore.jks quarkus.oidc.tls.key-store-file-type=BCFKS quarkus.oidc.tls.key-store-password=password quarkus.oidc.tls.trust-store-file=client-bcfips-truststore.jks #quarkus.oidc.tls.trust-store-file=client-truststore.jks quarkus.oidc.tls.trust-store-file-type=BCFKS quarkus.oidc.tls.trust-store-password=password ``` OIDC configuration doc ref: https://quarkus.io/guides/all-config#quarkus-oidc_quarkus-oidc-openid-connect The issue that I am trying to avoid is something like: ``` Caused by: java.security.KeyStoreException: BCFKS not found ```

6037ecb413810d545309aea07ffd678ee253cc3e

d6edfd558851785cd987d1fd9073b0cbd88f6ad6

https://github.com/quarkusio/quarkus/compare/6037ecb413810d545309aea07ffd678ee253cc3e...d6edfd558851785cd987d1fd9073b0cbd88f6ad6

diff --git a/extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java b/extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java index c8512c4ae35..12a109c3e9f 100644 --- a/extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java +++ b/extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java @@ -439,6 +439,14 @@ public enum Verification { @ConfigItem public Optional<String> keyStoreFileType = Optional.empty(); + /** + * An optional parameter to specify a provider of the key store file. If not given, the provider is automatically + * detected + * based on the key store file type. + */ + @ConfigItem + public Optional<String> keyStoreProvider; + /** * A parameter to specify the password of the key store file. If not given, the default ("password") is used. */ @@ -484,6 +492,14 @@ public enum Verification { @ConfigItem public Optional<String> trustStoreFileType = Optional.empty(); + /** + * An optional parameter to specify a provider of the trust store file. If not given, the provider is automatically + * detected + * based on the trust store file type. + */ + @ConfigItem + public Optional<String> trustStoreProvider; + public Optional<Verification> getVerification() { return verification; } @@ -516,6 +532,22 @@ public void setTrustStoreCertAlias(String trustStoreCertAlias) { this.trustStoreCertAlias = Optional.of(trustStoreCertAlias); } + public Optional<String> getKeyStoreProvider() { + return keyStoreProvider; + } + + public void setKeyStoreProvider(String keyStoreProvider) { + this.keyStoreProvider = Optional.of(keyStoreProvider); + } + + public Optional<String> getTrustStoreProvider() { + return trustStoreProvider; + } + + public void setTrustStoreProvider(String trustStoreProvider) { + this.trustStoreProvider = Optional.of(trustStoreProvider); + } + } @ConfigGroup diff --git a/extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonUtils.java b/extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonUtils.java index 744dcc9e6e1..5ad51f3bc1e 100644 --- a/extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonUtils.java +++ b/extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonUtils.java @@ -131,7 +131,8 @@ public static void setHttpClientOptions(OidcCommonConfig oidcConfig, TlsConfig t .setPassword(oidcConfig.tls.getTrustStorePassword().orElse("password")) .setAlias(oidcConfig.tls.getTrustStoreCertAlias().orElse(null)) .setValue(io.vertx.core.buffer.Buffer.buffer(trustStoreData)) - .setType(getStoreType(oidcConfig.tls.trustStoreFileType, oidcConfig.tls.trustStoreFile.get())); + .setType(getStoreType(oidcConfig.tls.trustStoreFileType, oidcConfig.tls.trustStoreFile.get())) + .setProvider(oidcConfig.tls.trustStoreProvider.orElse(null)); options.setTrustOptions(trustStoreOptions); if (Verification.CERTIFICATE_VALIDATION == oidcConfig.tls.verification.orElse(Verification.REQUIRED)) { options.setVerifyHost(false); @@ -150,7 +151,8 @@ public static void setHttpClientOptions(OidcCommonConfig oidcConfig, TlsConfig t .setAlias(oidcConfig.tls.keyStoreKeyAlias.orElse(null)) .setAliasPassword(oidcConfig.tls.keyStoreKeyPassword.orElse(null)) .setValue(io.vertx.core.buffer.Buffer.buffer(keyStoreData)) - .setType(getStoreType(oidcConfig.tls.keyStoreFileType, oidcConfig.tls.keyStoreFile.get())); + .setType(getStoreType(oidcConfig.tls.keyStoreFileType, oidcConfig.tls.keyStoreFile.get())) + .setProvider(oidcConfig.tls.keyStoreProvider.orElse(null)); options.setKeyCertOptions(keyStoreOptions); } catch (IOException ex) {

['extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonUtils.java', 'extensions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java']

{'.java': 2}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/25260/25257

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/25257

https://github.com/quarkusio/quarkus/pull/25260

https://github.com/quarkusio/quarkus/pull/25260

fixes

Quarkus 2.9.0.CR1: Async Scheduled methods have unsafe sub-context

### Describe the bug When using an async `@Scheduled` method returning a void or using Kotlin coroutines, the provided sub-context seems to be unsafe and throws an error when e.g. using hibernate reactive with it. E.g. using a code like ``` class TestScheduler(private val testDao: TestDao) { @Scheduled(every = "5s") fun every5s(): Uni<Void> { return testDao.getEntity(UUID.randomUUID()).replaceWithVoid() } } @ApplicationScoped class TestDao(private val sessionFactory: Mutiny.SessionFactory) { fun getEntity(id: UUID): Uni<TestEntity?> = sessionFactory.withTransaction { s, _ -> s.find(TestEntity::class.java, id) } } ``` ends in a crash like ``` 2022-04-29 15:32:05,016 ERROR [io.qua.sch.com.run.StatusEmitterInvoker] (vert.x-eventloop-thread-0) Error occured while executing task for trigger IntervalTrigger [id=1_org.acme.TestScheduler_ScheduledInvoker_every5s_c56c24f01b03a432de6e9b18de0f5a7dfbc05db8, interval=5000]: java.lang.IllegalStateException: The current operation requires a safe (isolated) Vert.x sub-context, but the current context hasn't been flagged as such. You can still use Hibernate Reactive, you just need to avoid using the methods which implicitly require accessing the stateful context, such as MutinySessionFactory#withTransaction and #withSession. at io.quarkus.vertx.core.runtime.context.VertxContextSafetyToggle.checkIsSafe(VertxContextSafetyToggle.java:80) at io.quarkus.vertx.core.runtime.context.VertxContextSafetyToggle.validateContextIfExists(VertxContextSafetyToggle.java:63) at io.quarkus.hibernate.reactive.runtime.customized.CheckingVertxContext.get(CheckingVertxContext.java:46) at org.hibernate.reactive.mutiny.impl.MutinySessionFactoryImpl.withSession(MutinySessionFactoryImpl.java:189) at org.hibernate.reactive.mutiny.impl.MutinySessionFactoryImpl.withTransaction(MutinySessionFactoryImpl.java:261) at org.acme.db.TestDao.getEntity(TestDao.kt:12) at org.acme.db.TestDao_Subclass.getEntity$$superforward1(Unknown Source) at org.acme.db.TestDao_Subclass$$function$$1.apply(Unknown Source) at io.quarkus.arc.impl.AroundInvokeInvocationContext.proceed(AroundInvokeInvocationContext.java:54) at io.quarkus.arc.runtime.devconsole.InvocationInterceptor.proceed(InvocationInterceptor.java:62) ``` ### Expected behavior @Scheduled should have a safe context that can be used with hibernate reactive. ### Actual behavior It crashes ### How to Reproduce? 1. Download reproducer project and unzip: [2022-04-29_scheduler-unsafe.zip](https://github.com/quarkusio/quarkus/files/8591125/2022-04-29_scheduler-unsafe.zip) 2. run the included `docker-compose.yml` to set up a local postgres container. 3. run with `./gradlew quarkusDev` 4. check the log for the crash ### Output of `uname -a` or `ver` _No response_ ### Output of `java -version` _No response_ ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 2.9.0.CR1 ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) gradle ### Additional information _No response_

55521fb0253744239c11557d23dd575533d8fe42

cc4aef5dd9eb7a451f5488568fe62dc70fa575bc

https://github.com/quarkusio/quarkus/compare/55521fb0253744239c11557d23dd575533d8fe42...cc4aef5dd9eb7a451f5488568fe62dc70fa575bc

diff --git a/extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java b/extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java index d04ae8ab00a..ec68f58ae00 100644 --- a/extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java +++ b/extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java @@ -73,7 +73,9 @@ import io.quarkus.scheduler.common.runtime.StatusEmitterInvoker; import io.quarkus.scheduler.common.runtime.util.SchedulerUtils; import io.quarkus.scheduler.runtime.SchedulerRuntimeConfig; +import io.quarkus.vertx.core.runtime.context.VertxContextSafetyToggle; import io.smallrye.common.vertx.VertxContext; +import io.vertx.core.Context; import io.vertx.core.Handler; import io.vertx.core.Vertx; @@ -555,20 +557,22 @@ static class InvokerJob implements Job { } @Override - public void execute(JobExecutionContext context) throws JobExecutionException { + public void execute(JobExecutionContext jobExecutionContext) throws JobExecutionException { if (trigger.invoker != null) { // could be null from previous runs if (trigger.invoker.isBlocking()) { try { - trigger.invoker.invoke(new QuartzScheduledExecution(trigger, context)); + trigger.invoker.invoke(new QuartzScheduledExecution(trigger, jobExecutionContext)); } catch (Exception e) { throw new JobExecutionException(e); } } else { - VertxContext.getOrCreateDuplicatedContext(vertx).runOnContext(new Handler<Void>() { + Context context = VertxContext.getOrCreateDuplicatedContext(vertx); + VertxContextSafetyToggle.setContextSafe(context, true); + context.runOnContext(new Handler<Void>() { @Override public void handle(Void event) { try { - trigger.invoker.invoke(new QuartzScheduledExecution(trigger, context)); + trigger.invoker.invoke(new QuartzScheduledExecution(trigger, jobExecutionContext)); } catch (Exception e) { // already logged by the StatusEmitterInvoker } diff --git a/extensions/scheduler/runtime/src/main/java/io/quarkus/scheduler/runtime/SimpleScheduler.java b/extensions/scheduler/runtime/src/main/java/io/quarkus/scheduler/runtime/SimpleScheduler.java index 15adc72b52b..40a2bf2af9d 100644 --- a/extensions/scheduler/runtime/src/main/java/io/quarkus/scheduler/runtime/SimpleScheduler.java +++ b/extensions/scheduler/runtime/src/main/java/io/quarkus/scheduler/runtime/SimpleScheduler.java @@ -51,6 +51,7 @@ import io.quarkus.scheduler.common.runtime.SkipPredicateInvoker; import io.quarkus.scheduler.common.runtime.StatusEmitterInvoker; import io.quarkus.scheduler.common.runtime.util.SchedulerUtils; +import io.quarkus.vertx.core.runtime.context.VertxContextSafetyToggle; import io.smallrye.common.vertx.VertxContext; import io.vertx.core.Context; import io.vertx.core.Handler; @@ -319,6 +320,7 @@ public void run() { } } else { Context context = VertxContext.getOrCreateDuplicatedContext(vertx); + VertxContextSafetyToggle.setContextSafe(context, true); context.runOnContext(new Handler<Void>() { @Override public void handle(Void event) {

['extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java', 'extensions/scheduler/runtime/src/main/java/io/quarkus/scheduler/runtime/SimpleScheduler.java']

{'.java': 2}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/32679/32663

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/32663

https://github.com/quarkusio/quarkus/pull/32679

https://github.com/quarkusio/quarkus/pull/32679

fixes

infov impacts local variable type

### Describe the bug I propose here a very specific problem, but, unfortunately, during a POC of a team to see if Quarkus could replace Spring Boot, the trust of the team on Quarkus is impacted. **Log.infov with more than 1 variable related to a Kafka record, seems to change the type of a local variable in specific context.** The specific context is: - the first line is a Uni not initialized explicitly (no = null for example), but the result would be the same with a CompletionStage. - a Log.infov is used with 2 variables related to a Kafka record It means: ``` @Incoming("prices") public Uni<Void> consume(ConsumerRecord<String, String> msg) { Uni<Void> result; // result = null will work, or even if Instant now = Instant.now(); if before this line Instant now = Instant.now(); Log.infov("infov seems changing now into a long, {0} - {1}", msg.topic(), msg.offset()); // Log.infov("infov seems changing now into a long, {0}", msg.topic()); will work methodThatGetAnInstant(now); result = Uni.createFrom().voidItem(); return result; } private void methodThatGetAnInstant(Instant instant) { Log.info("What a wonderfull method."); } ``` ### Expected behavior We would expect mvn quarkus:dev starts the service without errors. ### Actual behavior We have an error on mvn quarkus:dev ``` 2023-04-15 11:16:11,240 ERROR [io.qua.dep.dev.IsolatedDevModeMain] (Aesh InputStream Reader) Failed to start quarkus: io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58) at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:123) at io.quarkus.deployment.dev.IsolatedDevModeMain.restartApp(IsolatedDevModeMain.java:222) at io.quarkus.deployment.dev.IsolatedDevModeMain.restartCallback(IsolatedDevModeMain.java:203) at io.quarkus.deployment.dev.RuntimeUpdatesProcessor.doScan(RuntimeUpdatesProcessor.java:543) at io.quarkus.deployment.console.ConsoleStateManager.forceRestart(ConsoleStateManager.java:141) at io.quarkus.deployment.console.ConsoleStateManager.lambda$installBuiltins$0(ConsoleStateManager.java:98) at io.quarkus.deployment.console.ConsoleStateManager$1.accept(ConsoleStateManager.java:73) at io.quarkus.deployment.console.ConsoleStateManager$1.accept(ConsoleStateManager.java:46) at io.quarkus.deployment.console.AeshConsole.lambda$setup$1(AeshConsole.java:275) at org.aesh.terminal.EventDecoder.accept(EventDecoder.java:118) at org.aesh.terminal.EventDecoder.accept(EventDecoder.java:31) at org.aesh.terminal.io.Decoder.write(Decoder.java:133) at org.aesh.readline.tty.terminal.TerminalConnection.openBlocking(TerminalConnection.java:216) at org.aesh.readline.tty.terminal.TerminalConnection.openBlocking(TerminalConnection.java:203) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:833) Caused by: java.lang.RuntimeException: Failed to start quarkus at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source) at io.quarkus.runtime.Application.start(Application.java:101) at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:111) at io.quarkus.runtime.Quarkus.run(Quarkus.java:71) at io.quarkus.runtime.Quarkus.run(Quarkus.java:44) at io.quarkus.runtime.Quarkus.run(Quarkus.java:124) at io.quarkus.runner.GeneratedMain.main(Unknown Source) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at io.quarkus.runner.bootstrap.StartupActionImpl$1.run(StartupActionImpl.java:104) ... 1 more Caused by: jakarta.enterprise.inject.spi.DefinitionException: java.lang.VerifyError: Bad type on operand stack Exception Details: Location: legros/emmanuel/KafkaConsumer.consume(Lorg/apache/kafka/clients/consumer/ConsumerRecord;)Lio/smallrye/mutiny/Uni; @52: invokevirtual Reason: Type 'java/lang/Long' (current frame, stack[1]) is not assignable to 'java/time/Instant' Current Frame: bci: @52 flags: { } locals: { 'legros/emmanuel/KafkaConsumer', 'org/apache/kafka/clients/consumer/ConsumerRecord', 'java/lang/Long', top, top, 'java/lang/String', top, 'java/lang/String' } stack: { 'legros/emmanuel/KafkaConsumer', 'java/lang/Long' } Bytecode: 0000000: b800 074d 120d 2bb6 000f b800 15b2 005f 0000010: 5b57 b600 6212 212b b600 232b b600 0fb8 0000020: 0015 4d3a 053a 07b2 005f 1907 1905 2cb6 0000030: 0063 2a2c b600 2ab8 0030 b600 363a 0819 0000040: 08b0 at io.smallrye.reactive.messaging.providers.extension.MediatorManager.createMediator(MediatorManager.java:199) at io.smallrye.reactive.messaging.providers.extension.MediatorManager_ClientProxy.createMediator(Unknown Source) at io.smallrye.reactive.messaging.providers.wiring.Wiring$SubscriberMediatorComponent.materialize(Wiring.java:626) at io.smallrye.reactive.messaging.providers.wiring.Graph.lambda$materialize$10(Graph.java:100) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at io.smallrye.reactive.messaging.providers.wiring.Graph.materialize(Graph.java:99) at io.smallrye.reactive.messaging.providers.extension.MediatorManager.start(MediatorManager.java:219) at io.smallrye.reactive.messaging.providers.extension.MediatorManager_ClientProxy.start(Unknown Source) at io.quarkus.smallrye.reactivemessaging.runtime.SmallRyeReactiveMessagingLifecycle.onApplicationStart(SmallRyeReactiveMessagingLifecycle.java:52) at io.quarkus.smallrye.reactivemessaging.runtime.SmallRyeReactiveMessagingLifecycle_Observer_onApplicationStart_68e7b57eb97cb75d597c5b816682366e888d0d9b.notify(Unknown Source) at io.quarkus.arc.impl.EventImpl$Notifier.notifyObservers(EventImpl.java:344) at io.quarkus.arc.impl.EventImpl$Notifier.notify(EventImpl.java:326) at io.quarkus.arc.impl.EventImpl.fire(EventImpl.java:82) at io.quarkus.arc.runtime.ArcRecorder.fireLifecycleEvent(ArcRecorder.java:151) at io.quarkus.arc.runtime.ArcRecorder.handleLifecycleEvents(ArcRecorder.java:102) at io.quarkus.deployment.steps.LifecycleEventsBuildStep$startupEvent1144526294.deploy_0(Unknown Source) at io.quarkus.deployment.steps.LifecycleEventsBuildStep$startupEvent1144526294.deploy(Unknown Source) ... 13 more Caused by: java.lang.VerifyError: Bad type on operand stack Exception Details: Location: legros/emmanuel/KafkaConsumer.consume(Lorg/apache/kafka/clients/consumer/ConsumerRecord;)Lio/smallrye/mutiny/Uni; @52: invokevirtual Reason: Type 'java/lang/Long' (current frame, stack[1]) is not assignable to 'java/time/Instant' Current Frame: bci: @52 flags: { } locals: { 'legros/emmanuel/KafkaConsumer', 'org/apache/kafka/clients/consumer/ConsumerRecord', 'java/lang/Long', top, top, 'java/lang/String', top, 'java/lang/String' } stack: { 'legros/emmanuel/KafkaConsumer', 'java/lang/Long' } Bytecode: 0000000: b800 074d 120d 2bb6 000f b800 15b2 005f 0000010: 5b57 b600 6212 212b b600 232b b600 0fb8 0000020: 0015 4d3a 053a 07b2 005f 1907 1905 2cb6 0000030: 0063 2a2c b600 2ab8 0030 b600 363a 0819 0000040: 08b0 at legros.emmanuel.KafkaConsumer_Bean.proxy(Unknown Source) at legros.emmanuel.KafkaConsumer_Bean.get(Unknown Source) at legros.emmanuel.KafkaConsumer_Bean.get(Unknown Source) at io.quarkus.arc.impl.ArcContainerImpl.beanInstanceHandle(ArcContainerImpl.java:477) at io.quarkus.arc.impl.ArcContainerImpl.beanInstanceHandle(ArcContainerImpl.java:490) at io.quarkus.arc.impl.BeanManagerImpl.getReference(BeanManagerImpl.java:63) at io.smallrye.reactive.messaging.providers.extension.MediatorManager.createMediator(MediatorManager.java:176) ... 29 more ``` ### How to Reproduce? I think that the description of the bug already explains how to reproduce it, but to make it simple, I propose you more comments on the following code -> https://github.com/legrosmanu/quarkus-infov-issue/blob/main/src/main/java/legros/emmanuel/KafkaConsumer.java On this project, you can do a mvn:quarkus to get the error. You'll have the same issue with Quarkus 2.6 or 3.0 ### Output of `uname -a` or `ver` Darwin **** 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar 6 21:00:17 PST 2023; root:xnu-8796.101.5~3/RELEASE_X86_64 x86_64 ### Output of `java -version` OpenJDK Runtime Environment Temurin-17.0.6+10 (build 17.0.6+10) OpenJDK 64-Bit Server VM Temurin-17.0.6+10 (build 17.0.6+10, mixed mode, sharing) ### GraalVM version (if different from Java) _No response_ ### Quarkus version or git rev 3.0.0.CR2 ### Build tool (ie. output of `mvnw --version` or `gradlew --version`) Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8) Maven home: /usr/local/Cellar/maven/3.9.1/libexec Java version: 17.0.6, vendor: Eclipse Adoptium, runtime: /Users/manu/.sdkman/candidates/java/17.0.6-tem Default locale: fr_FR, platform encoding: UTF-8 OS name: "mac os x", version: "13.3", arch: "x86_64", family: "mac" ### Additional information _No response_

c5be7ba7efbce88b86097bbcbaf1fedad44259eb

f7fb2411d467dfbc1d2afae4f4472f9702146f27

https://github.com/quarkusio/quarkus/compare/c5be7ba7efbce88b86097bbcbaf1fedad44259eb...f7fb2411d467dfbc1d2afae4f4472f9702146f27

diff --git a/core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingWithPanacheProcessor.java b/core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingWithPanacheProcessor.java index 897a6ae01de..3aa4d051272 100644 --- a/core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingWithPanacheProcessor.java +++ b/core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingWithPanacheProcessor.java @@ -137,7 +137,7 @@ public void visitMethodInsn(int opcode, String owner, String name, String descri locals = new int[numArgs]; for (int i = numArgs - 1; i >= 0; i--) { locals[i] = newLocal(argTypes[i]); - super.visitVarInsn(argTypes[i].getOpcode(Opcodes.ISTORE), locals[i]); + visitor.visitVarInsn(argTypes[i].getOpcode(Opcodes.ISTORE), locals[i]); } } @@ -162,7 +162,7 @@ public void visitMethodInsn(int opcode, String owner, String name, String descri // stack: [logger arg1 arg2 arg3] locals: {l1 = arg4} // stack: [logger arg1 arg2 arg3 arg4] locals: {} for (int i = 0; i < numArgs; i++) { - super.visitVarInsn(argTypes[i].getOpcode(Opcodes.ILOAD), locals[i]); + visitor.visitVarInsn(argTypes[i].getOpcode(Opcodes.ILOAD), locals[i]); } } diff --git a/integration-tests/logging-panache/src/test/java/io/quarkus/logging/LoggingBean.java b/integration-tests/logging-panache/src/test/java/io/quarkus/logging/LoggingBean.java index a3bed8f6723..13d7133aafb 100644 --- a/integration-tests/logging-panache/src/test/java/io/quarkus/logging/LoggingBean.java +++ b/integration-tests/logging-panache/src/test/java/io/quarkus/logging/LoggingBean.java @@ -40,4 +40,12 @@ public void doSomething() { Log.error("Hello Error", error); } + // https://github.com/quarkusio/quarkus/issues/32663 + public void reproduceStackDisciplineIssue() { + String result; + String now = "now"; + + Log.infov("{0} {1}", "number", 42); + Log.info("string " + now); + } } diff --git a/integration-tests/logging-panache/src/test/java/io/quarkus/logging/LoggingWithPanacheTest.java b/integration-tests/logging-panache/src/test/java/io/quarkus/logging/LoggingWithPanacheTest.java index 075b1dec002..7e6ee43c4f3 100644 --- a/integration-tests/logging-panache/src/test/java/io/quarkus/logging/LoggingWithPanacheTest.java +++ b/integration-tests/logging-panache/src/test/java/io/quarkus/logging/LoggingWithPanacheTest.java @@ -40,7 +40,9 @@ public class LoggingWithPanacheTest { "[ERROR] four: foo | bar | baz | quux", "[WARN] foo | bar | baz | quux: io.quarkus.logging.NoStackTraceTestException", "[ERROR] Hello Error: io.quarkus.logging.NoStackTraceTestException", - "[INFO] Hi!"); + "[INFO] Hi!", + "[INFO] number 42", + "[INFO] string now"); }); @Inject @@ -50,5 +52,7 @@ public class LoggingWithPanacheTest { public void test() { bean.doSomething(); new LoggingEntity().something(); + + bean.reproduceStackDisciplineIssue(); } }

['integration-tests/logging-panache/src/test/java/io/quarkus/logging/LoggingWithPanacheTest.java', 'core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingWithPanacheProcessor.java', 'integration-tests/logging-panache/src/test/java/io/quarkus/logging/LoggingBean.java']

{'.java': 3}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/9019/8984

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/8984

https://github.com/quarkusio/quarkus/pull/9019

https://github.com/quarkusio/quarkus/pull/9019

fixes

Liquibase still detects multiple changelogs despite upgrade to 1.4.1

**Describe the bug** Copied from previous ticket #8400 : During startup of quarkus dev mode, Liquibase tries to parse the configured (yaml) file containing the changeLog, this fails due to 2 such files being found in the classpath. This error does not occur in normal mode (running the runner jar). **Expected behavior** Liquibase only finds one changeLog file and parses it. **Actual behavior** ``` File: Found 2 files that match db/changeLog.xml at io.quarkus.liquibase.runtime.LiquibaseRecorder.doStartActions(LiquibaseRecorder.java:82) at io.quarkus.deployment.steps.LiquibaseProcessor$configureRuntimeProperties31.deploy_0(LiquibaseProcessor$configureRuntimeProperties31.zig:98) at io.quarkus.deployment.steps.LiquibaseProcessor$configureRuntimeProperties31.deploy(LiquibaseProcessor$configureRuntimeProperties31.zig:36) at io.quarkus.runner.ApplicationImpl.doStart(ApplicationImpl.zig:182) at io.quarkus.runtime.Application.start(Application.java:89) at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:90) at io.quarkus.runtime.Quarkus.run(Quarkus.java:61) at io.quarkus.runtime.Quarkus.run(Quarkus.java:38) at io.quarkus.runtime.Quarkus.run(Quarkus.java:106) at io.quarkus.runner.GeneratedMain.main(GeneratedMain.zig:29) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.runner.bootstrap.StartupActionImpl$1.run(StartupActionImpl.java:99) at java.base/java.lang.Thread.run(Thread.java:834) Caused by: liquibase.exception.ChangeLogParseException: Error Reading Migration File: Found 2 files that match db/changeLog.xml at liquibase.parser.core.xml.XMLChangeLogSAXParser.parseToNode(XMLChangeLogSAXParser.java:118) at liquibase.parser.core.xml.AbstractChangeLogParser.parse(AbstractChangeLogParser.java:15) at liquibase.Liquibase.getDatabaseChangeLog(Liquibase.java:217) at liquibase.Liquibase.validate(Liquibase.java:1559) at io.quarkus.liquibase.runtime.LiquibaseRecorder.validate(LiquibaseRecorder.java:124) at io.quarkus.liquibase.runtime.LiquibaseRecorder.doStartActions(LiquibaseRecorder.java:66) ... 15 more Caused by: java.io.IOException: Found 2 files that match db/changeLog.xml at liquibase.util.StreamUtil.singleInputStream(StreamUtil.java:206) at liquibase.parser.core.xml.XMLChangeLogSAXParser.parseToNode(XMLChangeLogSAXParser.java:71) ... 20 more ``` **To Reproduce** Steps to reproduce the behavior: 1. clone https://github.com/gastaldi/liquibase-gradle-bug 2. change gradle.properties from 999-snapshot to 1.4.1.Final 3. ./gradlew quarkusDev **Configuration** ```properties # Add your application.properties here, if applicable. #Gradle properties #Mon Apr 06 13:51:25 GMT 2020 quarkusPluginVersion=1.4.1.Final quarkusPlatformArtifactId=quarkus-bom quarkusPlatformGroupId=io.quarkus quarkusPlatformVersion=1.4.1.Final #application.properties quarkus.liquibase.change-log=db/changeLog.xml quarkus.liquibase.migrate-at-start=true quarkus.liquibase.validate-on-migrate=true quarkus.datasource.db-kind=h2 quarkus.datasource.jdbc.url=jdbc:h2:mem:test quarkus.datasource.jdbc.max-size=8 quarkus.datasource.jdbc.min-size=2 ``` **Screenshots** (If applicable, add screenshots to help explain your problem.) **Environment (please complete the following information):** - Output of `uname -a` or `ver`: `Darwin kaluza.broadband 19.0.0 Darwin Kernel Version 19.0.0: Thu Oct 17 16:17:15 PDT 2019; root:xnu-6153.41.3~29/RELEASE_X86_64 x86_64` - Output of `java -version`: `openjdk version "11.0.6" 2020-01-14 OpenJDK Runtime Environment GraalVM CE 19.3.1 (build 11.0.6+9-jvmci-19.3-b07) OpenJDK 64-Bit Server VM GraalVM CE 19.3.1 (build 11.0.6+9-jvmci-19.3-b07, mixed mode, sharing)` - GraalVM version (if different from Java): - Quarkus version or git rev: 1.4.1.Final - Build tool (ie. output of `mvnw --version` or `gradlew --version`): ``` ------------------------------------------------------------ Gradle 6.3 ------------------------------------------------------------ Build time: 2020-03-24 19:52:07 UTC Revision: bacd40b727b0130eeac8855ae3f9fd9a0b207c60 Kotlin: 1.3.70 Groovy: 2.5.10 Ant: Apache Ant(TM) version 1.10.7 compiled on September 1 2019 JVM: 11.0.6 (Oracle Corporation 11.0.6+9-jvmci-19.3-b07) OS: Mac OS X 10.15.1 x86_64 ``` **Additional context** (Add any other context about the problem here.)

ba698f2476f4117e00a16e8d8201e252cb1b08f3

258fccc5ea48dc63de9df732de06de44c66d903e

https://github.com/quarkusio/quarkus/compare/ba698f2476f4117e00a16e8d8201e252cb1b08f3...258fccc5ea48dc63de9df732de06de44c66d903e

diff --git a/core/deployment/src/main/java/io/quarkus/deployment/dev/DevModeContext.java b/core/deployment/src/main/java/io/quarkus/deployment/dev/DevModeContext.java index b391fd6b164..fbdbb315a04 100644 --- a/core/deployment/src/main/java/io/quarkus/deployment/dev/DevModeContext.java +++ b/core/deployment/src/main/java/io/quarkus/deployment/dev/DevModeContext.java @@ -193,6 +193,7 @@ public static class ModuleInfo implements Serializable { private final Set<String> sourcePaths; private final String classesPath; private final String resourcePath; + private final String resourcesOutputPath; public ModuleInfo( String name, @@ -200,11 +201,22 @@ public ModuleInfo( Set<String> sourcePaths, String classesPath, String resourcePath) { + this(name, projectDirectory, sourcePaths, classesPath, resourcePath, classesPath); + } + + public ModuleInfo( + String name, + String projectDirectory, + Set<String> sourcePaths, + String classesPath, + String resourcePath, + String resourceOutputPath) { this.name = name; this.projectDirectory = projectDirectory; this.sourcePaths = sourcePaths == null ? new HashSet<>() : new HashSet<>(sourcePaths); this.classesPath = classesPath; this.resourcePath = resourcePath; + this.resourcesOutputPath = resourceOutputPath; } public String getName() { @@ -230,6 +242,10 @@ public String getClassesPath() { public String getResourcePath() { return resourcePath; } + + public String getResourcesOutputPath() { + return resourcesOutputPath; + } } public boolean isEnablePreview() { diff --git a/core/deployment/src/main/java/io/quarkus/deployment/dev/DevModeMain.java b/core/deployment/src/main/java/io/quarkus/deployment/dev/DevModeMain.java index bd012f6f83a..c35479ee3a0 100644 --- a/core/deployment/src/main/java/io/quarkus/deployment/dev/DevModeMain.java +++ b/core/deployment/src/main/java/io/quarkus/deployment/dev/DevModeMain.java @@ -103,7 +103,10 @@ public void start() throws Exception { if (i.getClassesPath() != null) { Path classesPath = Paths.get(i.getClassesPath()); bootstrapBuilder.addAdditionalApplicationArchive(new AdditionalDependency(classesPath, true, false)); - + } + if (i.getResourcesOutputPath() != null && !i.getResourcesOutputPath().equals(i.getClassesPath())) { + Path resourceOutputPath = Paths.get(i.getResourcesOutputPath()); + bootstrapBuilder.addAdditionalApplicationArchive(new AdditionalDependency(resourceOutputPath, true, false)); } } diff --git a/core/deployment/src/main/java/io/quarkus/deployment/dev/RuntimeUpdatesProcessor.java b/core/deployment/src/main/java/io/quarkus/deployment/dev/RuntimeUpdatesProcessor.java index d56d4cd767f..6f3c4dba583 100644 --- a/core/deployment/src/main/java/io/quarkus/deployment/dev/RuntimeUpdatesProcessor.java +++ b/core/deployment/src/main/java/io/quarkus/deployment/dev/RuntimeUpdatesProcessor.java @@ -302,8 +302,10 @@ Set<String> checkForFileChange() { m -> Collections.newSetFromMap(new ConcurrentHashMap<>())); boolean doCopy = true; String rootPath = module.getResourcePath(); + String outputPath = module.getResourcesOutputPath(); if (rootPath == null) { rootPath = module.getClassesPath(); + outputPath = rootPath; doCopy = false; } if (rootPath == null) { @@ -313,7 +315,7 @@ Set<String> checkForFileChange() { if (!Files.exists(root) || !Files.isReadable(root)) { continue; } - Path classesDir = Paths.get(module.getClassesPath()); + Path outputDir = Paths.get(outputPath); //copy all modified non hot deployment files over if (doCopy) { try { @@ -323,7 +325,7 @@ Set<String> checkForFileChange() { walk.forEach(path -> { try { Path relative = root.relativize(path); - Path target = classesDir.resolve(relative); + Path target = outputDir.resolve(relative); seen.remove(target); if (!watchedFileTimestamps.containsKey(path)) { moduleResources.add(target); @@ -366,7 +368,7 @@ Set<String> checkForFileChange() { ret.add(path); log.infof("File change detected: %s", file); if (doCopy && !Files.isDirectory(file)) { - Path target = classesDir.resolve(path); + Path target = outputDir.resolve(path); byte[] data = Files.readAllBytes(file); try (FileOutputStream out = new FileOutputStream(target.toFile())) { out.write(data); @@ -379,7 +381,7 @@ Set<String> checkForFileChange() { } } else { watchedFileTimestamps.put(file, 0L); - Path target = classesDir.resolve(path); + Path target = outputDir.resolve(path); try { FileUtil.deleteDirectory(target); } catch (IOException e) { diff --git a/devtools/gradle/src/main/java/io/quarkus/gradle/tasks/QuarkusDev.java b/devtools/gradle/src/main/java/io/quarkus/gradle/tasks/QuarkusDev.java index e0a821c223b..be20f6db36c 100644 --- a/devtools/gradle/src/main/java/io/quarkus/gradle/tasks/QuarkusDev.java +++ b/devtools/gradle/src/main/java/io/quarkus/gradle/tasks/QuarkusDev.java @@ -13,6 +13,7 @@ import java.net.URL; import java.nio.file.Files; import java.nio.file.Path; +import java.nio.file.Paths; import java.util.ArrayList; import java.util.Arrays; import java.util.HashSet; @@ -259,14 +260,6 @@ public void startDev() { wiringClassesDirectory.mkdirs(); addToClassPaths(classPathManifest, context, wiringClassesDirectory); - StringBuilder resources = new StringBuilder(); - for (File file : extension.resourcesDir()) { - if (resources.length() > 0) { - resources.append(File.pathSeparator); - } - resources.append(file.getAbsolutePath()); - } - final Set<AppArtifactKey> projectDependencies = new HashSet<>(); addSelfWithLocalDeps(project, context, new HashSet<>(), projectDependencies); @@ -390,12 +383,18 @@ private void addLocalProject(Project project, DevModeContext context, Set<AppArt } String resourcePaths = mainSourceSet.getResources().getSourceDirectories().getSingleFile().getAbsolutePath(); //TODO: multiple resource directories + final String classesDir = QuarkusGradleUtils.getClassesDir(mainSourceSet, project.getBuildDir()); + final String resourcesOutputPath = Files.exists(Paths.get(resourcePaths)) + ? mainSourceSet.getOutput().getResourcesDir().getAbsolutePath() + : classesDir; + DevModeContext.ModuleInfo wsModuleInfo = new DevModeContext.ModuleInfo( project.getName(), project.getProjectDir().getAbsolutePath(), sourcePaths, - QuarkusGradleUtils.getClassesDir(mainSourceSet, project.getBuildDir()), - resourcePaths); + classesDir, + resourcePaths, + resourcesOutputPath); context.getModules().add(wsModuleInfo);

['devtools/gradle/src/main/java/io/quarkus/gradle/tasks/QuarkusDev.java', 'core/deployment/src/main/java/io/quarkus/deployment/dev/DevModeContext.java', 'core/deployment/src/main/java/io/quarkus/deployment/dev/RuntimeUpdatesProcessor.java', 'core/deployment/src/main/java/io/quarkus/deployment/dev/DevModeMain.java']

{'.java': 4}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/9229/9227

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/9227

https://github.com/quarkusio/quarkus/pull/9229

https://github.com/quarkusio/quarkus/pull/9229

fixes

@Inject with @Named causing the AWS Lambda bootstrap failure

**Describe the bug** I am getting Lambda Bootstrap Error when using **@Inject and @Named** on RequestHandler **Expected behavior** The CDI injection & Lambda functionality should work as described in the documentation. **Actual behavior** Bootstrap error and Lambda function doesn't work ```text { "errorMessage": "Quarkus bootstrap failed.\\njava.lang.RuntimeException: Failed to start quarkus\\n\\tat io.quarkus.runner.ApplicationImpl.doStart(ApplicationImpl.zig:208)\\n\\tat io.quarkus.runtime.Application.start(Application.java:89)\\n\\tat io.quarkus.amazon.lambda.runtime.QuarkusStreamHandler.<clinit>(QuarkusStreamHandler.java:39)\\n\\tat java.base/java.lang.Class.forName0(Native Method)\\n\\tat java.base/java.lang.Class.forName(Unknown Source)\\n\\tat lambdainternal.HandlerInfo.fromString(HandlerInfo.java:31)\\n\\tat lambdainternal.AWSLambda.findUserMethods(AWSLambda.java:77)\\n\\tat lambdainternal.AWSLambda.startRuntime(AWSLambda.java:196)\\n\\tat lambdainternal.AWSLambda.startRuntime(AWSLambda.java:162)\\n\\tat lambdainternal.AWSLambda.main(AWSLambda.java:157)\\nCaused by: java.lang.RuntimeException: Unable to find handler class with name test make sure there is a handler class in the deployment with the correct @Named annotation\\n\\tat io.quarkus.amazon.lambda.runtime.AmazonLambdaRecorder.chooseHandlerClass(AmazonLambdaRecorder.java:105)\\n\\tat io.quarkus.deployment.steps.AmazonLambdaProcessor$recordHandlerClass16.deploy_0(AmazonLambdaProcessor$recordHandlerClass16.zig:210)\\n\\tat io.quarkus.deployment.steps.AmazonLambdaProcessor$recordHandlerClass16.deploy(AmazonLambdaProcessor$recordHandlerClass16.zig:229)\\n\\tat io.quarkus.runner.ApplicationImpl.doStart(ApplicationImpl.zig:139)\\n\\t... 9 more\\n", "errorType": "java.io.IOException", "stackTrace": [ "io.quarkus.amazon.lambda.runtime.QuarkusStreamHandler.handleRequest(QuarkusStreamHandler.java:56)", "java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)", "java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)", "java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)", "java.base/java.lang.reflect.Method.invoke(Unknown Source)" ] } ``` **To Reproduce** Steps to reproduce the behavior: 1. Create a AWS lambda project using Quakus maven architype 2. Create two classes like below ```java @ApplicationScoped @Slf4j public class CDIConfig { private final String prop1; @Inject public CDIConfig( @ConfigProperty(name = "test.prop1") final String prop1) { this.prop1 = prop1; } @Produces @Singleton @Named("prop1") public String prop1() { log.info("Bean Creation:{}", prop1); return prop1; } } ``` ```java @Named("test") @Slf4j public class TestLambda implements RequestHandler<InputObject, OutputObject> { @Inject ProcessingService service; @Inject @Named("prop1") String prop1; @Override public OutputObject handleRequest(final InputObject input, final Context context) { log.info("Prop1 in lambda:{}", prop1); return service.process(input).setRequestId(context.getAwsRequestId()); } } ``` 3. mvn clean package and deploy the function to aws and run the test to see the error **Configuration** ```properties quarkus.lambda.handler=test test.prop1=${GREETINGS:Hello} ``` **Screenshots** (If applicable, add screenshots to help explain your problem.) **Environment (please complete the following information):** - Output of `uname -a` or `ver`: macos - Output of `java -version`: openjdk version "11.0.6" 2020-01-14 - GraalVM version (if different from Java): OpenJDK 64-Bit Server VM GraalVM CE 19.3.1 (build 11.0.6+9-jvmci-19.3-b07, mixed mode, sharing) - Quarkus version or git rev: OpenJDK 64-Bit Server VM GraalVM CE 19.3.1 (build 11.0.6+9-jvmci-19.3-b07, mixed mode, sharing) - Build tool (ie. output of `mvnw --version` or `gradlew --version`): mvn **Additional context** (Add any other context about the problem here.)

d273ad73add077e7a3529b0a8900a8fdf391b979

033908064ba544dd6064436f6d6f6010e4f1c777

https://github.com/quarkusio/quarkus/compare/d273ad73add077e7a3529b0a8900a8fdf391b979...033908064ba544dd6064436f6d6f6010e4f1c777

diff --git a/extensions/amazon-lambda/deployment/src/main/java/io/quarkus/amazon/lambda/deployment/AmazonLambdaProcessor.java b/extensions/amazon-lambda/deployment/src/main/java/io/quarkus/amazon/lambda/deployment/AmazonLambdaProcessor.java index 1ddd2c0db2f..b45b49f7104 100644 --- a/extensions/amazon-lambda/deployment/src/main/java/io/quarkus/amazon/lambda/deployment/AmazonLambdaProcessor.java +++ b/extensions/amazon-lambda/deployment/src/main/java/io/quarkus/amazon/lambda/deployment/AmazonLambdaProcessor.java @@ -102,9 +102,9 @@ List<AmazonLambdaBuildItem> discover(CombinedIndexBuildItem combinedIndexBuildIt reflectiveClassBuildItemBuildProducer.produce(new ReflectiveClassBuildItem(true, false, lambda)); String cdiName = null; - List<AnnotationInstance> named = info.annotations().get(NAMED); - if (named != null && !named.isEmpty()) { - cdiName = named.get(0).value().asString(); + AnnotationInstance named = info.classAnnotation(NAMED); + if (named != null) { + cdiName = named.value().asString(); } ClassInfo current = info;

['extensions/amazon-lambda/deployment/src/main/java/io/quarkus/amazon/lambda/deployment/AmazonLambdaProcessor.java']

{'.java': 1}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/9215/9196

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/9196

https://github.com/quarkusio/quarkus/pull/9215

https://github.com/quarkusio/quarkus/pull/9215

fixes

Gelf handler chunking messages

**Describe the bug** The gelf handler chunking the messages exceeding 8192 bytes, any meaning full java stack trace exceed this limits. Once messages are chunked Fluentd gelf input plugin rejects the chunked message because of unknown format and log statement never reach elasticsearch **Expected behavior** Allow users to configure the maximumMessageSize ```quarkus.log.handler.gelf.maximumMessageSize=2000000``` **Actual behavior** Message chunking and loss of log statements **To Reproduce** Steps to reproduce the behavior: 1. Configure Gelf logging in quarkus 2. Create a log message size greater than 8192 bytes 3. Notice the log statement chunking and underlying log aggregation rejecting the chunked messages (In this case EFK) **Configuration** ```properties # Add your application.properties here, if applicable. quarkus.log.handler.gelf.enabled=true quarkus.log.handler.gelf.host=${GELF_HOST:localhost} quarkus.log.handler.gelf.port=${GELF_PORT:12201} ``` **Screenshots** (If applicable, add screenshots to help explain your problem.) **Environment (please complete the following information):** - Output of `uname -a` or `ver`: amazon linux 2 - Output of `java -version`: 11.0.6" 2020-01-14 - GraalVM version (if different from Java): GraalVM CE 19.3.1 - Quarkus version or git rev: 1.4.2-Final - Build tool (ie. output of `mvnw --version` or `gradlew --version`): mvn **Additional context** JBOSS logmanager JSON logging is outstanding, please support socket appender in addition to existing console, file. So that we can push the logs directly to fluentd tcp source.

574bdfb887547a7967e7f896903ec1181ea51b6a

5f6eeaf8b57529efcedf09f67b46cc506fb14757

https://github.com/quarkusio/quarkus/compare/574bdfb887547a7967e7f896903ec1181ea51b6a...5f6eeaf8b57529efcedf09f67b46cc506fb14757

diff --git a/extensions/logging-gelf/runtime/src/main/java/io/quarkus/logging/gelf/GelfConfig.java b/extensions/logging-gelf/runtime/src/main/java/io/quarkus/logging/gelf/GelfConfig.java index c1b329d0399..acd10968d4a 100644 --- a/extensions/logging-gelf/runtime/src/main/java/io/quarkus/logging/gelf/GelfConfig.java +++ b/extensions/logging-gelf/runtime/src/main/java/io/quarkus/logging/gelf/GelfConfig.java @@ -98,4 +98,11 @@ public class GelfConfig { */ @ConfigItem public boolean includeFullMdc; + + /** + * Maximum message size (in bytes). + * If the message size is exceeded, the appender will submit the message in multiple chunks. + */ + @ConfigItem(defaultValue = "8192") + public int maximumMessageSize; } diff --git a/extensions/logging-gelf/runtime/src/main/java/io/quarkus/logging/gelf/GelfLogHandlerRecorder.java b/extensions/logging-gelf/runtime/src/main/java/io/quarkus/logging/gelf/GelfLogHandlerRecorder.java index 0c845cb03eb..97c1ac6e3cf 100644 --- a/extensions/logging-gelf/runtime/src/main/java/io/quarkus/logging/gelf/GelfLogHandlerRecorder.java +++ b/extensions/logging-gelf/runtime/src/main/java/io/quarkus/logging/gelf/GelfLogHandlerRecorder.java @@ -29,6 +29,7 @@ public RuntimeValue<Optional<Handler>> initializeHandler(final GelfConfig config handler.setHost(config.host); handler.setPort(config.port); handler.setLevel(config.level); + handler.setMaximumMessageSize(config.maximumMessageSize); // handle additional fields if (!config.additionalField.isEmpty()) {

['extensions/logging-gelf/runtime/src/main/java/io/quarkus/logging/gelf/GelfConfig.java', 'extensions/logging-gelf/runtime/src/main/java/io/quarkus/logging/gelf/GelfLogHandlerRecorder.java']

{'.java': 2}

Java

{'Java': 45174846, 'HTML': 1260641, 'Kotlin': 726044, 'JavaScript': 519044, 'Shell': 51146, 'Groovy': 25140, 'ANTLR': 23342, 'Batchfile': 13971, 'Mustache': 13199, 'Scala': 9778, 'FreeMarker': 8106, 'CSS': 5346, 'Dockerfile': 660, 'PLpgSQL': 109}

Apache License 2.0

quarkusio/quarkus/9199/9188

quarkusio

quarkus

https://github.com/quarkusio/quarkus/issues/9188

https://github.com/quarkusio/quarkus/pull/9199

https://github.com/quarkusio/quarkus/pull/9199

fixes

Check whether or not a thread is already blocking before submiting tasks to Quarkus executor

**Describe the bug** When a Vert.x route is already executing blocking code, some extensions that use Quarkus executor (e.g.: `quarkus-resteasy`) dispatch tasks without checking whether or not the thread is already blocking. **Expected behavior** When not running in the event loop, the Quarkus executor (and extensions) should just execute code without starting a new worker thread. **Actual behavior** Quarkus executor (and extensions) is starting new worker threads to execute code that is already blocking. **To Reproduce** Steps to reproduce the behavior: 1. Create a Vert.x `io.quarkus.vertx.http.runtime.filters.Filter` and make this filter execute the next handler as blocking (e.g.: `context.vertx().executeBlocking`) 2. Create a JAX-RS resource 3. Send a request to the JAX-Resource and check that the current thread is a worker thread from Quarkus executor and not a Vert.x worker thread **Environment (please complete the following information):** - Quarkus version or git rev: 999-SNAPSHOT

69bb79d2530b3a193a206329cc3dd5c482874898

94416b5e054199a1b343cb10ab6a4fd3f5800fbc

https://github.com/quarkusio/quarkus/compare/69bb79d2530b3a193a206329cc3dd5c482874898...94416b5e054199a1b343cb10ab6a4fd3f5800fbc

diff --git a/extensions/resteasy/runtime/src/main/java/io/quarkus/resteasy/runtime/standalone/VertxRequestHandler.java b/extensions/resteasy/runtime/src/main/java/io/quarkus/resteasy/runtime/standalone/VertxRequestHandler.java index 5c4fbc9ce6b..6f3b6ffd96e 100644 --- a/extensions/resteasy/runtime/src/main/java/io/quarkus/resteasy/runtime/standalone/VertxRequestHandler.java +++ b/extensions/resteasy/runtime/src/main/java/io/quarkus/resteasy/runtime/standalone/VertxRequestHandler.java @@ -19,6 +19,7 @@ import io.quarkus.arc.ManagedContext; import io.quarkus.arc.runtime.BeanContainer; +import io.quarkus.runtime.BlockingOperationControl; import io.quarkus.security.identity.CurrentIdentityAssociation; import io.quarkus.vertx.http.runtime.CurrentVertxRequest; import io.quarkus.vertx.http.runtime.VertxInputStream; @@ -79,17 +80,25 @@ public void handle(RoutingContext request) { request.fail(e); return; } - - executor.execute(new Runnable() { - @Override - public void run() { - try { - dispatch(request, is, new VertxBlockingOutput(request.request())); - } catch (Throwable e) { - request.fail(e); - } + if (BlockingOperationControl.isBlockingAllowed()) { + try { + dispatch(request, is, new VertxBlockingOutput(request.request())); + } catch (Throwable e) { + request.fail(e); } - }); + } else { + executor.execute(new Runnable() { + @Override + public void run() { + try { + dispatch(request, is, new VertxBlockingOutput(request.request())); + } catch (Throwable e) { + request.fail(e); + } + } + }); + } + } private void dispatch(RoutingContext routingContext, InputStream is, VertxOutput output) {

['extensions/resteasy/runtime/src/main/java/io/quarkus/resteasy/runtime/standalone/VertxRequestHandler.java']

{'.java': 1}