Request for Model Update: Inheriting GenerationMixin for Future Compatibility

#39
by YMZH - opened

Hi,

I am using your model and encountered the following warning:

PhiForCausalLM has generative capabilities, as `prepare_inputs_for_generation` is explicitly overwritten. However, it doesn't directly inherit from `GenerationMixin`. From πŸ‘‰v4.50πŸ‘ˆ onwards, `PreTrainedModel` will NOT inherit from `GenerationMixin`, and this model will lose the ability to call `generate` and other related functions.
  - If you're using `trust_remote_code=True`, you can get rid of this warning by loading the model with an auto class. See https://huggingface.co/docs/transformers/en/model_doc/auto#auto-classes
  - If you are the owner of the model architecture code, please modify your model class such that it inherits from `GenerationMixin` (after `PreTrainedModel`, otherwise you'll get an exception).
  - If you are not the owner of the model architecture class, please contact the model code owner to update it.

It seems that to avoid issues in future versions of Transformers, the model class should inherit from GenerationMixin to maintain generative functionality. Could you kindly look into updating the model architecture?

Thank you!

Added to the backlog, will get it added shortly. Thanks!

I do have the same error here, any chance this can be corrected ?

Actually not an error (yet), only a warning...

Sign up or log in to comment