Datasets:

akumoth

/

peewee-issues

like 0

{ "login": "bndr", "id": 1145456, "node_id": "MDQ6VXNlcjExNDU0NTY=", "avatar_url": "https://avatars.githubusercontent.com/u/1145456?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bndr", "html_url": "https://github.com/bndr", "followers_url": "https://api.github.com/users/bndr/followers", "following_url": "https://api.github.com/users/bndr/following{/other_user}", "gists_url": "https://api.github.com/users/bndr/gists{/gist_id}", "starred_url": "https://api.github.com/users/bndr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bndr/subscriptions", "organizations_url": "https://api.github.com/users/bndr/orgs", "repos_url": "https://api.github.com/users/bndr/repos", "events_url": "https://api.github.com/users/bndr/events{/privacy}", "received_events_url": "https://api.github.com/users/bndr/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Works for me, thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/314/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/314", "html_url": "https://github.com/coleifer/peewee/pull/314", "diff_url": "https://github.com/coleifer/peewee/pull/314.diff", "patch_url": "https://github.com/coleifer/peewee/pull/314.patch", "merged_at": "2014-03-03T15:02:55" }

{ "login": "thibaultmeyer", "id": 1005086, "node_id": "MDQ6VXNlcjEwMDUwODY=", "avatar_url": "https://avatars.githubusercontent.com/u/1005086?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thibaultmeyer", "html_url": "https://github.com/thibaultmeyer", "followers_url": "https://api.github.com/users/thibaultmeyer/followers", "following_url": "https://api.github.com/users/thibaultmeyer/following{/other_user}", "gists_url": "https://api.github.com/users/thibaultmeyer/gists{/gist_id}", "starred_url": "https://api.github.com/users/thibaultmeyer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thibaultmeyer/subscriptions", "organizations_url": "https://api.github.com/users/thibaultmeyer/orgs", "repos_url": "https://api.github.com/users/thibaultmeyer/repos", "events_url": "https://api.github.com/users/thibaultmeyer/events{/privacy}", "received_events_url": "https://api.github.com/users/thibaultmeyer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks, looking.\n", "The attribute error shouldn't occur, but I will also add that unfortunately you cannot query GFK's like that.\n\nYour query:\n\n``` python\nTag.select().where(Tag.object << Photo.select().where(Photo.published==True))\n```\n\nTo accomplish what you're going for, you'll want to:\n\n``` python\n published_photos = Photo.select().where(Photo.published == True)\n Tag.select().where(\n (Tag.object_id << published_photos.select(Photo.id)) &\n (Tag.object_type == Photo._meta.db_table))\n```\n", "I have the following model using GFK:\n\n``` python\n\nclass Subscription(GFKModel):\n subscriber_type = CharField(null=True)\n subscriber_id = IntegerField(null=True)\n subscriber = GFKField('subscriber_type', 'subscriber_id')\n\n resource_type = CharField(null=True)\n resource_id = IntegerField(null=True)\n resource = GFKField('resource_type', 'resource_id')\n\n class Meta:\n indexes = (\n ((\n 'subscriber_type',\n 'subscriber_id',\n 'resource_type',\n 'resource_id',\n ), True),\n )\n```\n\nAnd I use this helper for a get_or_create (notice the double workaround, because each simpler alternative doesn't work):\n\n``` python\n\n\ndef subscribe(subscriber, resource):\n # HACK workaround for using get_or_create / create_or_get with GFKFields.\n try:\n # HACK workaround for querying equality of GFKField. I'd love to do the following:\n # Subscription.get(\n # (Subscription.subscriber == subscriber) &\n # (Subscription.resource == resource))\n\n sub = Subscription.get(\n (Subscription.subscriber_id == subscriber._get_pk_value()) &\n (Subscription.subscriber_type == subscriber._meta.db_table) &\n (Subscription.resource_id == resource._get_pk_value()) &\n (Subscription.resource_type == resource._meta.db_table))\n\n created = False\n\n except Subscription.DoesNotExist:\n sub = Subscription.create(\n subscriber=subscriber,\n resource=resource,\n )\n\n created = True\n\n return sub, created\n\n```\n\nIs this limitation by design? (@coleifer earlier said \"you cannot query GFKs like that\")\n\nWould peewee accept a PR that promotes the GFKField class to something else than just 'object' to be more friendly to querying? Is this extremely difficult?\n", "It is not difficult, but semantics other than equality and inequality would\nbe weird. I'll look at implementing this.\nOn Jan 20, 2016 12:32 AM, \"Francisco Demartino\" [email protected]\nwrote:\n\n> I have the following model using GFK:\n> \n> class Subscription(GFKModel):\n> subscriber_type = CharField(null=True)\n> subscriber_id = IntegerField(null=True)\n> subscriber = GFKField('subscriber_type', 'subscriber_id')\n> \n> ```\n> resource_type = CharField(null=True)\n> resource_id = IntegerField(null=True)\n> resource = GFKField('resource_type', 'resource_id')\n> \n> class Meta:\n> indexes = (\n> ((\n> 'subscriber_type',\n> 'subscriber_id',\n> 'resource_type',\n> 'resource_id',\n> ), True),\n> )\n> ```\n> \n> And I use this helper for a get_or_create (notice the double workaround,\n> because each simpler alternative doesn't work):\n> \n> def subscribe(subscriber, resource):\n> # HACK workaround for using get_or_create / create_or_get with GFKFields.\n> try:\n> # HACK workaround for querying equality of GFKField. I'd love to do the following:\n> # Subscription.get(\n> # (Subscription.subscriber == subscriber) &\n> # (Subscription.resource == resource))\n> \n> ```\n> sub = Subscription.get(\n> (Subscription.subscriber_id == subscriber._get_pk_value()) &\n> (Subscription.subscriber_type == subscriber._meta.db_table) &\n> (Subscription.resource_id == resource._get_pk_value()) &\n> (Subscription.resource_type == resource._meta.db_table))\n> \n> created = False\n> \n> except Subscription.DoesNotExist:\n> sub = Subscription.create(\n> subscriber=subscriber,\n> resource=resource,\n> )\n> \n> created = True\n> \n> return sub, created\n> ```\n> \n> Is this limitation by design? (@coleifer https://github.com/coleifer\n> earlier said \"you cannot query GFKs like that\")\n> \n> Would peewee accept a PR that promotes the GFKField class to something\n> else than just 'object' to be more friendly to querying? Is this extremely\n> difficult?\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/coleifer/peewee/issues/313#issuecomment-173108828.\n", "Thank you, Charles!\n\nFor an example of \"real-world\" code look here:\nhttps://github.com/franciscod/telegram-universal-forwarder-bot/blob/master/models.py\nhttps://github.com/franciscod/telegram-universal-forwarder-bot/blob/master/resources/util.py\n", "nice, thanks!\n", "@coleifer Does the new GFK API impact `create_or_get()`?\n", "It should, but I will add a test-case.\n", "Turns out it did not, but it does with the latest commit referenced.\n", "woohoo! thank you so much!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/313/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "pydeveloper94", "id": 6692874, "node_id": "MDQ6VXNlcjY2OTI4NzQ=", "avatar_url": "https://avatars.githubusercontent.com/u/6692874?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pydeveloper94", "html_url": "https://github.com/pydeveloper94", "followers_url": "https://api.github.com/users/pydeveloper94/followers", "following_url": "https://api.github.com/users/pydeveloper94/following{/other_user}", "gists_url": "https://api.github.com/users/pydeveloper94/gists{/gist_id}", "starred_url": "https://api.github.com/users/pydeveloper94/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pydeveloper94/subscriptions", "organizations_url": "https://api.github.com/users/pydeveloper94/orgs", "repos_url": "https://api.github.com/users/pydeveloper94/repos", "events_url": "https://api.github.com/users/pydeveloper94/events{/privacy}", "received_events_url": "https://api.github.com/users/pydeveloper94/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm not sure I understand these changes.\n", "http://peewee.readthedocs.org/en/latest/peewee/cookbook.html#logging-queries\n", "The developer is not able to choose whether or not they want to disable the logger providing debug output. You gave a solution here, https://github.com/coleifer/peewee/issues/254, to write\n\n```\nimport logging\nlogger = logging.getLogger('peewee')\nlogger.addHandler(logging.NullHandler())\n```\n\nbut the person who raised this issue stated that the code provided did not work. When I added these lines to my code base, it did not fix the logger problem.\n\nI think it would be favorable to enable logging while instantiating the database object by changing the debug keyword argument, which I added.\n\nWhen I first came across the log message being printed into the console, I thought there was an error with my code, but it was just because logging is not disabled by default.\n", "> You might try then peewee_logger.handlers = []. The logging docs are pretty helpful.\n\nFrom my final comment in the issue you referenced.\n", "The log framework has multiple log levels so you can subscribe to the ones you care about. Adding another layer of API in-between seems redundant, so I'm going to close this.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/312/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/312", "html_url": "https://github.com/coleifer/peewee/pull/312", "diff_url": "https://github.com/coleifer/peewee/pull/312.diff", "patch_url": "https://github.com/coleifer/peewee/pull/312.patch", "merged_at": null }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "http://peewee.readthedocs.org/en/latest/peewee/cookbook.html#bulk-inserts\n", "Hey, did you ever finish the page for bulk inserts? I'm having very poor performance inserting bulk data with `atomic` and `insert_many` on my model?\n", "http://docs.peewee-orm.com/en/latest/peewee/querying.html#bulk-inserts\n\nWhat database? Poor compared to what? \n", "I'm using a sqlite database. Even for a relatively simple insert of about 2000 rows of 5 ints (per row) it takes about 5 seconds for peewee to insert.\n", "I upgraded my sqlite version. Before I was only able to insert about 200 rows per transaction due to that version of sqlite's SQLITE_MAX_VARIABLE_NUMBER. I can now insert over 40,000 rows in one `with db.atomic():` block, however it can take as long as 80 seconds to complete the insert. Any ideas on what I can do with peewee to speed this up? I have millions of rows that I would like to insert.\n", "I'm really sorry to bother you, @coleifer , but I have one more question. Based on what I've been reading, it seems that for doing large bulk inserts it's better to insert the data into a table without an index and then build the index for the table later. Is this possible to do with peewee? If this isn't the correct place for this question let me know and I'll post it elsewhere. I wasn't able to find anything on SO regarding the topic for peewee.\n", "There's a great StackOverflow thread on speeding up SQLite inserts. Summary of tips:\n- Create your indexes afterwards.\n- Use PRAGMA synchronous=0; when inserting\n- Use bulk insert syntax\n- Use transactions\n- Batch it up.\n\nFor peewee, you can create the tables and indexes separately by running:\n\n``` python\ndb = SqliteDatabase(...)\n\ndb.create_table(ModelClass)\ndb.create_table(Model2)\n\n# do insert\n\nModelClass.create_indexes()\nModel2.create_indexes()\n```\n", "Sorry to get back to you so late, I didn't see this email. Thanks for the\nresponse, I really appreciate it. I was able to speed up the insert by\nturning off auto-indexing and doing the other things you mentioned from SO\ndiscussions. I may be doing another large insert again this week and I'll\ntry your suggestions regarding peewee's `create_indexes` method. Thanks again for your input!\n\nOn Mon, May 30, 2016 at 6:35 PM, Charles Leifer [email protected]\nwrote:\n\n> There's a great StackOverflow thread on speeding up SQLite inserts.\n> Summary of tips:\n> - Create your indexes afterwards.\n> - Use PRAGMA synchronous=0; when inserting\n> - Use bulk insert syntax\n> - Use transactions\n> - Batch it up.\n> \n> For peewee, you can create the tables and indexes separately by running:\n> \n> db = SqliteDatabase(...)\n> \n> db.create_table(ModelClass)\n> db.create_table(Model2)\n> \n> # do insert\n> \n> ModelClass.create_indexes()\n> Model2.create_indexes()\n> \n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> https://github.com/coleifer/peewee/issues/311#issuecomment-222565897,\n> or mute the thread\n> https://github.com/notifications/unsubscribe/AHP3Bx0A1GZZlqlCNTZnmZLztVwkmCoYks5qG3Q-gaJpZM4BilCr\n> .\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/311/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "g3rv4", "id": 6250774, "node_id": "MDQ6VXNlcjYyNTA3NzQ=", "avatar_url": "https://avatars.githubusercontent.com/u/6250774?v=4", "gravatar_id": "", "url": "https://api.github.com/users/g3rv4", "html_url": "https://github.com/g3rv4", "followers_url": "https://api.github.com/users/g3rv4/followers", "following_url": "https://api.github.com/users/g3rv4/following{/other_user}", "gists_url": "https://api.github.com/users/g3rv4/gists{/gist_id}", "starred_url": "https://api.github.com/users/g3rv4/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/g3rv4/subscriptions", "organizations_url": "https://api.github.com/users/g3rv4/orgs", "repos_url": "https://api.github.com/users/g3rv4/repos", "events_url": "https://api.github.com/users/g3rv4/events{/privacy}", "received_events_url": "https://api.github.com/users/g3rv4/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Are you sure the problem is the foreign key to `servers`? Can you create a test-case?\n", "I'd love to. Do you have an example of a test case? I'm just getting started with python\n", "I don't see `servers` listed in mysql's reserved words list: https://dev.mysql.com/doc/refman/5.5/en/reserved-words.html\n", "I don't think that's a reserved word in mysql, sorry if I gave you that impression. I think it's something in pwiz.py that doesn't let it work with a table named `servers`. In order to replicate, I created a new database with this table\n\n```\nCREATE TABLE `servers` (\n `id` INT NOT NULL AUTO_INCREMENT,\n `ip` VARCHAR(50) NULL,\n PRIMARY KEY (`id`));\n```\n\nCreated a new project and installed\n\n```\nPyMySQL==0.6.1\npeewee==2.2.1\n```\n\nThen, I ran `python env\\Scripts\\pwiz.py -e mysql -u user -P pass peewee` inside the virtualenv, and this is what it returned\n\n```\nfrom peewee import *\n\ndatabase = MySQLDatabase('peewee', **{'user': 'user', 'passwd': 'pass'})\n\nclass UnknownFieldType(object):\n pass\n\nclass BaseModel(Model):\n class Meta:\n database = database\n\nclass Servers(BaseModel):\n db = CharField(max_length=64, db_column='Db')\n host = CharField(max_length=64, db_column='Host')\n server_name = IntegerField(db_column='Server_name')\n\n class Meta:\n db_table = 'servers'\n```\n\nYou can see that pwiz created a class named Servers, but it doesn't have the `ip` field that's on the table `servers`.\n\nIf you also have a FK to your `servers` table, pwiz just breaks... to show this, I created another table and added a FK to `servers` running this query\n\n```\nCREATE TABLE `accounts` (\n `id` INT NOT NULL AUTO_INCREMENT,\n `server_id` INT NULL,\n `name` VARCHAR(45) NULL,\n `password` VARCHAR(45) NULL,\n PRIMARY KEY (`id`),\n INDEX `server` (`server_id` ASC),\n CONSTRAINT `server`\n FOREIGN KEY (`server_id`)\n REFERENCES `servers` (`id`)\n ON DELETE NO ACTION\n ON UPDATE NO ACTION);\n```\n\nNow, when I execute `python env\\Scripts\\pwiz.py -e mysql -u user -P pass peewee` I get\n\n```\nTraceback (most recent call last):\n File \"env\\Scripts\\pwiz.py\", line 540, in <module>\n print_models(options.engine, database, tables, **connect)\n File \"env\\Scripts\\pwiz.py\", line 444, in print_models\n models, table_to_model, table_fks, col_meta = introspect(db, schema)\n File \"env\\Scripts\\pwiz.py\", line 419, in introspect\n table_columns[rel_table][rel_pk].field_class = PrimaryKeyField\nKeyError: 'id'\n```\n\nI was able to replicate this in an Ubuntu as well.\n", "I spent some time messing around with this and you're totally right. Apologies -- I never use MySQL and needed to install it and test to see what exactly was going on.\n", "No need to apologize at all :) let me know if I can give you a hand. I'm totally new at Python but your project has helped me a lot already\n", "There was a bug in the introspection of primary keys w/mysql. Fixed in 20329564fc740bc94e0751a94cd6def88b36da5b\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/310/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "wcbeard", "id": 379413, "node_id": "MDQ6VXNlcjM3OTQxMw==", "avatar_url": "https://avatars.githubusercontent.com/u/379413?v=4", "gravatar_id": "", "url": "https://api.github.com/users/wcbeard", "html_url": "https://github.com/wcbeard", "followers_url": "https://api.github.com/users/wcbeard/followers", "following_url": "https://api.github.com/users/wcbeard/following{/other_user}", "gists_url": "https://api.github.com/users/wcbeard/gists{/gist_id}", "starred_url": "https://api.github.com/users/wcbeard/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/wcbeard/subscriptions", "organizations_url": "https://api.github.com/users/wcbeard/orgs", "repos_url": "https://api.github.com/users/wcbeard/repos", "events_url": "https://api.github.com/users/wcbeard/events{/privacy}", "received_events_url": "https://api.github.com/users/wcbeard/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I've got a commit or two towards making this work, almost there.\n", "Added. http://peewee.readthedocs.org/en/latest/peewee/api.html#ForeignKeyField\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/309/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "danthedeckie", "id": 1070206, "node_id": "MDQ6VXNlcjEwNzAyMDY=", "avatar_url": "https://avatars.githubusercontent.com/u/1070206?v=4", "gravatar_id": "", "url": "https://api.github.com/users/danthedeckie", "html_url": "https://github.com/danthedeckie", "followers_url": "https://api.github.com/users/danthedeckie/followers", "following_url": "https://api.github.com/users/danthedeckie/following{/other_user}", "gists_url": "https://api.github.com/users/danthedeckie/gists{/gist_id}", "starred_url": "https://api.github.com/users/danthedeckie/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/danthedeckie/subscriptions", "organizations_url": "https://api.github.com/users/danthedeckie/orgs", "repos_url": "https://api.github.com/users/danthedeckie/repos", "events_url": "https://api.github.com/users/danthedeckie/events{/privacy}", "received_events_url": "https://api.github.com/users/danthedeckie/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I had shied away from this previously because I didn't want to tangle up `Node` objects with their SQL representations, but this has actually caused some pain when wanting to add new Node types (i.e. the `unknown` grossness). Maybe this is a good path forward, I certainly have been aware that the recent refactorings would hurt performance a bit, but figured it would be negligible since most time is spent in the DB anyways... but I always like fast.\n\nThank you very much for this work, I think it's a good start and I'll investigate a similar approach.\n", "Cool! :-) I really like peewee, I love how simple the whole thing is for library users, and only being one file, etc. Thanks very much for your work on it.\n", "I did some profiling (ran the benchmark suite with cProfile). Here are some baseline results:\n\nhttps://gist.github.com/coleifer/9da9e7683530342b7de2\n", "Closing this and have marked it as a to-do item.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/308/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/308", "html_url": "https://github.com/coleifer/peewee/pull/308", "diff_url": "https://github.com/coleifer/peewee/pull/308.diff", "patch_url": "https://github.com/coleifer/peewee/pull/308.patch", "merged_at": null }

{ "login": "pitchforks", "id": 4378791, "node_id": "MDQ6VXNlcjQzNzg3OTE=", "avatar_url": "https://avatars.githubusercontent.com/u/4378791?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pitchforks", "html_url": "https://github.com/pitchforks", "followers_url": "https://api.github.com/users/pitchforks/followers", "following_url": "https://api.github.com/users/pitchforks/following{/other_user}", "gists_url": "https://api.github.com/users/pitchforks/gists{/gist_id}", "starred_url": "https://api.github.com/users/pitchforks/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pitchforks/subscriptions", "organizations_url": "https://api.github.com/users/pitchforks/orgs", "repos_url": "https://api.github.com/users/pitchforks/repos", "events_url": "https://api.github.com/users/pitchforks/events{/privacy}", "received_events_url": "https://api.github.com/users/pitchforks/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This was an oversight on my part. I re-pushed the 2.2.1 release so hopefully that fixes things. Thank you for bringing this to my attention.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/307/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "matrixise", "id": 38737, "node_id": "MDQ6VXNlcjM4NzM3", "avatar_url": "https://avatars.githubusercontent.com/u/38737?v=4", "gravatar_id": "", "url": "https://api.github.com/users/matrixise", "html_url": "https://github.com/matrixise", "followers_url": "https://api.github.com/users/matrixise/followers", "following_url": "https://api.github.com/users/matrixise/following{/other_user}", "gists_url": "https://api.github.com/users/matrixise/gists{/gist_id}", "starred_url": "https://api.github.com/users/matrixise/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/matrixise/subscriptions", "organizations_url": "https://api.github.com/users/matrixise/orgs", "repos_url": "https://api.github.com/users/matrixise/repos", "events_url": "https://api.github.com/users/matrixise/events{/privacy}", "received_events_url": "https://api.github.com/users/matrixise/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Whoops, thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/306/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/306", "html_url": "https://github.com/coleifer/peewee/pull/306", "diff_url": "https://github.com/coleifer/peewee/pull/306.diff", "patch_url": "https://github.com/coleifer/peewee/pull/306.patch", "merged_at": "2014-02-11T16:12:19" }

{ "login": "soasme", "id": 369081, "node_id": "MDQ6VXNlcjM2OTA4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/369081?v=4", "gravatar_id": "", "url": "https://api.github.com/users/soasme", "html_url": "https://github.com/soasme", "followers_url": "https://api.github.com/users/soasme/followers", "following_url": "https://api.github.com/users/soasme/following{/other_user}", "gists_url": "https://api.github.com/users/soasme/gists{/gist_id}", "starred_url": "https://api.github.com/users/soasme/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/soasme/subscriptions", "organizations_url": "https://api.github.com/users/soasme/orgs", "repos_url": "https://api.github.com/users/soasme/repos", "events_url": "https://api.github.com/users/soasme/events{/privacy}", "received_events_url": "https://api.github.com/users/soasme/received_events", "type": "User", "site_admin": false }

[]

[]

[ "it's more of a python problem rather than a peewee one.\n\nI think letting `UserMeta` inherit `BaseModel` should resolve this issue\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/305/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "giohappy", "id": 571129, "node_id": "MDQ6VXNlcjU3MTEyOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/571129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/giohappy", "html_url": "https://github.com/giohappy", "followers_url": "https://api.github.com/users/giohappy/followers", "following_url": "https://api.github.com/users/giohappy/following{/other_user}", "gists_url": "https://api.github.com/users/giohappy/gists{/gist_id}", "starred_url": "https://api.github.com/users/giohappy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/giohappy/subscriptions", "organizations_url": "https://api.github.com/users/giohappy/orgs", "repos_url": "https://api.github.com/users/giohappy/repos", "events_url": "https://api.github.com/users/giohappy/events{/privacy}", "received_events_url": "https://api.github.com/users/giohappy/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/304/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/304", "html_url": "https://github.com/coleifer/peewee/pull/304", "diff_url": "https://github.com/coleifer/peewee/pull/304.diff", "patch_url": "https://github.com/coleifer/peewee/pull/304.patch", "merged_at": "2014-02-06T23:58:48" }

{ "login": "giohappy", "id": 571129, "node_id": "MDQ6VXNlcjU3MTEyOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/571129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/giohappy", "html_url": "https://github.com/giohappy", "followers_url": "https://api.github.com/users/giohappy/followers", "following_url": "https://api.github.com/users/giohappy/following{/other_user}", "gists_url": "https://api.github.com/users/giohappy/gists{/gist_id}", "starred_url": "https://api.github.com/users/giohappy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/giohappy/subscriptions", "organizations_url": "https://api.github.com/users/giohappy/orgs", "repos_url": "https://api.github.com/users/giohappy/repos", "events_url": "https://api.github.com/users/giohappy/events{/privacy}", "received_events_url": "https://api.github.com/users/giohappy/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Fix https://github.com/coleifer/peewee/pull/304\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/303/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bndr", "id": 1145456, "node_id": "MDQ6VXNlcjExNDU0NTY=", "avatar_url": "https://avatars.githubusercontent.com/u/1145456?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bndr", "html_url": "https://github.com/bndr", "followers_url": "https://api.github.com/users/bndr/followers", "following_url": "https://api.github.com/users/bndr/following{/other_user}", "gists_url": "https://api.github.com/users/bndr/gists{/gist_id}", "starred_url": "https://api.github.com/users/bndr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bndr/subscriptions", "organizations_url": "https://api.github.com/users/bndr/orgs", "repos_url": "https://api.github.com/users/bndr/repos", "events_url": "https://api.github.com/users/bndr/events{/privacy}", "received_events_url": "https://api.github.com/users/bndr/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This would be a great feature but if you take a look at some of the existing schema migration tools you might be surprised how tricky this is.\n\nCurrently peewee has a helper in `playhouse.migrate` but i've only tested it with postgres. Schema migrations in sqlite are tricky because it only supports adding columns. For now these are the best options.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/302/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kramer65", "id": 596581, "node_id": "MDQ6VXNlcjU5NjU4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/596581?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kramer65", "html_url": "https://github.com/kramer65", "followers_url": "https://api.github.com/users/kramer65/followers", "following_url": "https://api.github.com/users/kramer65/following{/other_user}", "gists_url": "https://api.github.com/users/kramer65/gists{/gist_id}", "starred_url": "https://api.github.com/users/kramer65/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kramer65/subscriptions", "organizations_url": "https://api.github.com/users/kramer65/orgs", "repos_url": "https://api.github.com/users/kramer65/repos", "events_url": "https://api.github.com/users/kramer65/events{/privacy}", "received_events_url": "https://api.github.com/users/kramer65/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This isn't really appropriate for GH issues. Try the [peewee mailing list](groups.google.com/group/peewee-orm) or irc (freenode #peewee).\n", "Since you're stuck, though, you might try something like this:\n\n``` python\n\n(User\n .select()\n .where(fn.Exists(\n Message.select().where(Message.user == User.id))))\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/301/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/300/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bahrunnur", "id": 2069852, "node_id": "MDQ6VXNlcjIwNjk4NTI=", "avatar_url": "https://avatars.githubusercontent.com/u/2069852?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bahrunnur", "html_url": "https://github.com/bahrunnur", "followers_url": "https://api.github.com/users/bahrunnur/followers", "following_url": "https://api.github.com/users/bahrunnur/following{/other_user}", "gists_url": "https://api.github.com/users/bahrunnur/gists{/gist_id}", "starred_url": "https://api.github.com/users/bahrunnur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bahrunnur/subscriptions", "organizations_url": "https://api.github.com/users/bahrunnur/orgs", "repos_url": "https://api.github.com/users/bahrunnur/repos", "events_url": "https://api.github.com/users/bahrunnur/events{/privacy}", "received_events_url": "https://api.github.com/users/bahrunnur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I think I'm going to pass on merging, thank you though.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/299/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/299", "html_url": "https://github.com/coleifer/peewee/pull/299", "diff_url": "https://github.com/coleifer/peewee/pull/299.diff", "patch_url": "https://github.com/coleifer/peewee/pull/299.patch", "merged_at": null }

{ "login": "b1naryth1ef", "id": 599433, "node_id": "MDQ6VXNlcjU5OTQzMw==", "avatar_url": "https://avatars.githubusercontent.com/u/599433?v=4", "gravatar_id": "", "url": "https://api.github.com/users/b1naryth1ef", "html_url": "https://github.com/b1naryth1ef", "followers_url": "https://api.github.com/users/b1naryth1ef/followers", "following_url": "https://api.github.com/users/b1naryth1ef/following{/other_user}", "gists_url": "https://api.github.com/users/b1naryth1ef/gists{/gist_id}", "starred_url": "https://api.github.com/users/b1naryth1ef/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/b1naryth1ef/subscriptions", "organizations_url": "https://api.github.com/users/b1naryth1ef/orgs", "repos_url": "https://api.github.com/users/b1naryth1ef/repos", "events_url": "https://api.github.com/users/b1naryth1ef/events{/privacy}", "received_events_url": "https://api.github.com/users/b1naryth1ef/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Well you're right, that arg is replaced with `on_delete` and `on_update`. I need to push a documentation update. Neither is responsible for dropping a table with the cascade option. I think you're right that, while I see the code for this the important part is unreachable. I'll have two fixes coming.\n", "This should now be fixed. To drop a table w/cascade you can call:\n\n``` python\nModelClass.drop_table(cascade=True)\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/298/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "c4urself", "id": 391030, "node_id": "MDQ6VXNlcjM5MTAzMA==", "avatar_url": "https://avatars.githubusercontent.com/u/391030?v=4", "gravatar_id": "", "url": "https://api.github.com/users/c4urself", "html_url": "https://github.com/c4urself", "followers_url": "https://api.github.com/users/c4urself/followers", "following_url": "https://api.github.com/users/c4urself/following{/other_user}", "gists_url": "https://api.github.com/users/c4urself/gists{/gist_id}", "starred_url": "https://api.github.com/users/c4urself/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/c4urself/subscriptions", "organizations_url": "https://api.github.com/users/c4urself/orgs", "repos_url": "https://api.github.com/users/c4urself/repos", "events_url": "https://api.github.com/users/c4urself/events{/privacy}", "received_events_url": "https://api.github.com/users/c4urself/received_events", "type": "User", "site_admin": false }

[]

[]

[ "OMG, this change is so amazing; please have my babies.\n", "`__version__` is better than `VERSION`, I think.\n", "**version** added. Thanks for bringing this up!\n", ":thumbsup: thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/297/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/297", "html_url": "https://github.com/coleifer/peewee/pull/297", "diff_url": "https://github.com/coleifer/peewee/pull/297.diff", "patch_url": "https://github.com/coleifer/peewee/pull/297.patch", "merged_at": null }

{ "login": "giohappy", "id": 571129, "node_id": "MDQ6VXNlcjU3MTEyOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/571129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/giohappy", "html_url": "https://github.com/giohappy", "followers_url": "https://api.github.com/users/giohappy/followers", "following_url": "https://api.github.com/users/giohappy/following{/other_user}", "gists_url": "https://api.github.com/users/giohappy/gists{/gist_id}", "starred_url": "https://api.github.com/users/giohappy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/giohappy/subscriptions", "organizations_url": "https://api.github.com/users/giohappy/orgs", "repos_url": "https://api.github.com/users/giohappy/repos", "events_url": "https://api.github.com/users/giohappy/events{/privacy}", "received_events_url": "https://api.github.com/users/giohappy/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Ok, I found it out:\n\nMyModel.select(fn.ST_AsText(MyModel.geom).alias('point'))\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/296/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "grimnight", "id": 1737541, "node_id": "MDQ6VXNlcjE3Mzc1NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1737541?v=4", "gravatar_id": "", "url": "https://api.github.com/users/grimnight", "html_url": "https://github.com/grimnight", "followers_url": "https://api.github.com/users/grimnight/followers", "following_url": "https://api.github.com/users/grimnight/following{/other_user}", "gists_url": "https://api.github.com/users/grimnight/gists{/gist_id}", "starred_url": "https://api.github.com/users/grimnight/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/grimnight/subscriptions", "organizations_url": "https://api.github.com/users/grimnight/orgs", "repos_url": "https://api.github.com/users/grimnight/repos", "events_url": "https://api.github.com/users/grimnight/events{/privacy}", "received_events_url": "https://api.github.com/users/grimnight/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I don't see any reason not to just use Git-ORM.\n\nIf someone wanted to build a dp-api 2.0 driver for git, then something like that would be possible with peewee, but until then just stuck w/git-orm. Cool project, btw, hadn't heard of it.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/295/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "giohappy", "id": 571129, "node_id": "MDQ6VXNlcjU3MTEyOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/571129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/giohappy", "html_url": "https://github.com/giohappy", "followers_url": "https://api.github.com/users/giohappy/followers", "following_url": "https://api.github.com/users/giohappy/following{/other_user}", "gists_url": "https://api.github.com/users/giohappy/gists{/gist_id}", "starred_url": "https://api.github.com/users/giohappy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/giohappy/subscriptions", "organizations_url": "https://api.github.com/users/giohappy/orgs", "repos_url": "https://api.github.com/users/giohappy/repos", "events_url": "https://api.github.com/users/giohappy/events{/privacy}", "received_events_url": "https://api.github.com/users/giohappy/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/294/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/294", "html_url": "https://github.com/coleifer/peewee/pull/294", "diff_url": "https://github.com/coleifer/peewee/pull/294.diff", "patch_url": "https://github.com/coleifer/peewee/pull/294.patch", "merged_at": "2014-01-29T19:19:09" }

{ "login": "zdxerr", "id": 368272, "node_id": "MDQ6VXNlcjM2ODI3Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/368272?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zdxerr", "html_url": "https://github.com/zdxerr", "followers_url": "https://api.github.com/users/zdxerr/followers", "following_url": "https://api.github.com/users/zdxerr/following{/other_user}", "gists_url": "https://api.github.com/users/zdxerr/gists{/gist_id}", "starred_url": "https://api.github.com/users/zdxerr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zdxerr/subscriptions", "organizations_url": "https://api.github.com/users/zdxerr/orgs", "repos_url": "https://api.github.com/users/zdxerr/repos", "events_url": "https://api.github.com/users/zdxerr/events{/privacy}", "received_events_url": "https://api.github.com/users/zdxerr/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Nice!! Thank you. Also thank you for the test case.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/293/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/293", "html_url": "https://github.com/coleifer/peewee/pull/293", "diff_url": "https://github.com/coleifer/peewee/pull/293.diff", "patch_url": "https://github.com/coleifer/peewee/pull/293.patch", "merged_at": "2014-01-29T14:16:31" }

{ "login": "giohappy", "id": 571129, "node_id": "MDQ6VXNlcjU3MTEyOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/571129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/giohappy", "html_url": "https://github.com/giohappy", "followers_url": "https://api.github.com/users/giohappy/followers", "following_url": "https://api.github.com/users/giohappy/following{/other_user}", "gists_url": "https://api.github.com/users/giohappy/gists{/gist_id}", "starred_url": "https://api.github.com/users/giohappy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/giohappy/subscriptions", "organizations_url": "https://api.github.com/users/giohappy/orgs", "repos_url": "https://api.github.com/users/giohappy/repos", "events_url": "https://api.github.com/users/giohappy/events{/privacy}", "received_events_url": "https://api.github.com/users/giohappy/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Yeah that's a bit tricky, but it should be possible. Did you try something like:\n\n``` python\nclass PointField(Field):\n db_field = 'point' # Assuming you would hook this up to a field type registered w/the db.\n\n def db_value(self, value):\n if value:\n return fn.St_PointFromText(value)\n```\n\n**EDIT** nevermind, that won't work as it's only called on parameters that are being 'interpolated' into the query.\n", "I'm not sure the best way to make this DRY, but you could try:\n\n``` python\nclass PointField(Field):\n db_field = 'point'\n\ndef pft(value):\n return fn.St_PointFromText(value)\n\nCoord.insert(point=pft('34.40032,10.1010101'))\nCoord.update(point=pft('35.303,10.101')).where(Coord.id == 3)\nCoord.select().where(\n Coord.point == pft('35.303,10.101'))\n```\n", "Here's something that hopefully helps:\n\n``` python\nfrom peewee import *\n\nclass PointField(Field):\n db_field = 'point'\n\ndb = SqliteDatabase(':memory:')\ndb.register_fields({'point': 'POINT'})\n\nclass Coord(Model):\n point = PointField()\n\n class Meta:\n database = db\n\ndef pft(v):\n return fn.St_PointFromText(v)\n\ncoords = '38.9717,95.2353'\nprint Coord.insert(point=pft(coords))\nprint Coord.update(point=pft(coords)).where(Coord.point == pft('39.0,96.0'))\nprint Coord.select().where(Coord.point == pft(coords))\n```\n\n---\n\n```\n<class '__main__.Coord'> INSERT INTO \"coord\" (\"point\") VALUES (St_PointFromText(?)) ['38.9717,95.2353']\n<class '__main__.Coord'> UPDATE \"coord\" SET \"point\" = St_PointFromText(?) WHERE (\"point\" = St_PointFromText(?)) ['38.9717,95.2353', '39.0,96.0']\n<class '__main__.Coord'> SELECT t1.\"id\", t1.\"point\" FROM \"coord\" AS t1 WHERE (t1.\"point\" = St_PointFromText(?)) ['38.9717,95.2353']\n```\n", "Thanks! I will give it a try asap. The trick was the use of the fn stuff ;)\n", "It works perfectly!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/292/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "giohappy", "id": 571129, "node_id": "MDQ6VXNlcjU3MTEyOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/571129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/giohappy", "html_url": "https://github.com/giohappy", "followers_url": "https://api.github.com/users/giohappy/followers", "following_url": "https://api.github.com/users/giohappy/following{/other_user}", "gists_url": "https://api.github.com/users/giohappy/gists{/gist_id}", "starred_url": "https://api.github.com/users/giohappy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/giohappy/subscriptions", "organizations_url": "https://api.github.com/users/giohappy/orgs", "repos_url": "https://api.github.com/users/giohappy/repos", "events_url": "https://api.github.com/users/giohappy/events{/privacy}", "received_events_url": "https://api.github.com/users/giohappy/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I opted for a slightly different refactoring which you can see in cfc7c3db6987cfe1ad087d645477bd1cb8c864e8 and 7a831badaa43347fa717718c9669f617bb5949e4. The end result should be the same as what you have here.\n\nI also chose `schema` instead of `db_schema`. `db_table` is a holdover from Django, but going forward I'd like to switch it to just `table`.\n\nThanks for your work. Additionally, if you'd like to submit code in the future, please shoot for pep8 and 79-char lines.\n", "I didn't receive your comment. I will try to follow the 79-char lines rule ;) (I already tend to respect PEP8)\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/291/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/291", "html_url": "https://github.com/coleifer/peewee/pull/291", "diff_url": "https://github.com/coleifer/peewee/pull/291.diff", "patch_url": "https://github.com/coleifer/peewee/pull/291.patch", "merged_at": null }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[ { "id": 191751, "node_id": "MDU6TGFiZWwxOTE3NTE=", "url": "https://api.github.com/repos/coleifer/peewee/labels/Feature", "name": "Feature", "color": "02e10c", "default": false, "description": null } ]

[]

[ "peewee's APIs are geared towards selecting from a table. `Model.select()` implies that you are selecting from the table represented by `Model` and want to be returned `Model` instances (excepting special cases like `.scalar()`, `.aggregate()`, `.tuples()`, `.dicts()`).\n\nI haven't really put much effort into making it work with a sub-select in the from clause, partially because it doesn't fit very well into the rubric of returning model instances. I see the value of sub-selects, just haven't built it out yet.\n\nI think it'd be a good feature so I'll look into how to handle this.\n", "I believe the commit I just pushed 22ce07c will make it possible to achieve the queries you've listed. Take a look at the included testcase. I'm still not sure this is going to be a flexible enough solution to handle some of the other cases that come to mind, though. Particularly to select from multiple tables and join in the where clause.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/290/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "leliel12", "id": 299010, "node_id": "MDQ6VXNlcjI5OTAxMA==", "avatar_url": "https://avatars.githubusercontent.com/u/299010?v=4", "gravatar_id": "", "url": "https://api.github.com/users/leliel12", "html_url": "https://github.com/leliel12", "followers_url": "https://api.github.com/users/leliel12/followers", "following_url": "https://api.github.com/users/leliel12/following{/other_user}", "gists_url": "https://api.github.com/users/leliel12/gists{/gist_id}", "starred_url": "https://api.github.com/users/leliel12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/leliel12/subscriptions", "organizations_url": "https://api.github.com/users/leliel12/orgs", "repos_url": "https://api.github.com/users/leliel12/repos", "events_url": "https://api.github.com/users/leliel12/events{/privacy}", "received_events_url": "https://api.github.com/users/leliel12/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for your interest in peewee and for sharing your code. I'm not sure this belongs as a github issue, as I use this to track bugs and new features, as opposed to snippets.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/289/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "soasme", "id": 369081, "node_id": "MDQ6VXNlcjM2OTA4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/369081?v=4", "gravatar_id": "", "url": "https://api.github.com/users/soasme", "html_url": "https://github.com/soasme", "followers_url": "https://api.github.com/users/soasme/followers", "following_url": "https://api.github.com/users/soasme/following{/other_user}", "gists_url": "https://api.github.com/users/soasme/gists{/gist_id}", "starred_url": "https://api.github.com/users/soasme/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/soasme/subscriptions", "organizations_url": "https://api.github.com/users/soasme/orgs", "repos_url": "https://api.github.com/users/soasme/repos", "events_url": "https://api.github.com/users/soasme/events{/privacy}", "received_events_url": "https://api.github.com/users/soasme/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I thought `Model` _was_ a new-style class?\n", "Oops, it seems that pyflake does not have enough intelligence to recognize these styles:\n\n``` python\ndef with_metaclass(meta, base=object):\n return meta(\"NewBase\", (base,), {})\n\nclass BaseModel(type):\n def __new__(cls, name, bases, attrs):\n return super(BaseModel, cls).__new__(cls, name, bases, attrs)\n\nclass Model(with_metaclass(BaseModel)):\n def save(self):\n pass\n\nclass MyModel(Model):\n def save(self): # [E1002, MyModel.save] Use of super on an old style class\n super(MyModel, self).save()\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/288/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "appetito", "id": 557573, "node_id": "MDQ6VXNlcjU1NzU3Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/557573?v=4", "gravatar_id": "", "url": "https://api.github.com/users/appetito", "html_url": "https://github.com/appetito", "followers_url": "https://api.github.com/users/appetito/followers", "following_url": "https://api.github.com/users/appetito/following{/other_user}", "gists_url": "https://api.github.com/users/appetito/gists{/gist_id}", "starred_url": "https://api.github.com/users/appetito/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/appetito/subscriptions", "organizations_url": "https://api.github.com/users/appetito/orgs", "repos_url": "https://api.github.com/users/appetito/repos", "events_url": "https://api.github.com/users/appetito/events{/privacy}", "received_events_url": "https://api.github.com/users/appetito/received_events", "type": "User", "site_admin": false }

[]

[]

[ "> may be we must use \"INSERT **\\* RETURNING id\"?\n\nThat is a postgres feature, unfortunately it won't work for Sqlite or MySQL... Setting an auto-incrementing ID manually is frowned on, but if you are bulk-loading data or for some reason need to control the ids, see these docs for some tips:\n\nhttp://peewee.readthedocs.org/en/latest/peewee/cookbook.html#bulk-loading-data-or-manually-specifying-primary-keys\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/287/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "appetito", "id": 557573, "node_id": "MDQ6VXNlcjU1NzU3Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/557573?v=4", "gravatar_id": "", "url": "https://api.github.com/users/appetito", "html_url": "https://github.com/appetito", "followers_url": "https://api.github.com/users/appetito/followers", "following_url": "https://api.github.com/users/appetito/following{/other_user}", "gists_url": "https://api.github.com/users/appetito/gists{/gist_id}", "starred_url": "https://api.github.com/users/appetito/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/appetito/subscriptions", "organizations_url": "https://api.github.com/users/appetito/orgs", "repos_url": "https://api.github.com/users/appetito/repos", "events_url": "https://api.github.com/users/appetito/events{/privacy}", "received_events_url": "https://api.github.com/users/appetito/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Fixed in 3b8048d. Nice work debugging, thanks for the fix!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/286/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/286", "html_url": "https://github.com/coleifer/peewee/pull/286", "diff_url": "https://github.com/coleifer/peewee/pull/286.diff", "patch_url": "https://github.com/coleifer/peewee/pull/286.patch", "merged_at": null }

{ "login": "soasme", "id": 369081, "node_id": "MDQ6VXNlcjM2OTA4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/369081?v=4", "gravatar_id": "", "url": "https://api.github.com/users/soasme", "html_url": "https://github.com/soasme", "followers_url": "https://api.github.com/users/soasme/followers", "following_url": "https://api.github.com/users/soasme/following{/other_user}", "gists_url": "https://api.github.com/users/soasme/gists{/gist_id}", "starred_url": "https://api.github.com/users/soasme/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/soasme/subscriptions", "organizations_url": "https://api.github.com/users/soasme/orgs", "repos_url": "https://api.github.com/users/soasme/repos", "events_url": "https://api.github.com/users/soasme/events{/privacy}", "received_events_url": "https://api.github.com/users/soasme/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/285/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/285", "html_url": "https://github.com/coleifer/peewee/pull/285", "diff_url": "https://github.com/coleifer/peewee/pull/285.diff", "patch_url": "https://github.com/coleifer/peewee/pull/285.patch", "merged_at": "2014-01-16T16:34:13" }

{ "login": "soasme", "id": 369081, "node_id": "MDQ6VXNlcjM2OTA4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/369081?v=4", "gravatar_id": "", "url": "https://api.github.com/users/soasme", "html_url": "https://github.com/soasme", "followers_url": "https://api.github.com/users/soasme/followers", "following_url": "https://api.github.com/users/soasme/following{/other_user}", "gists_url": "https://api.github.com/users/soasme/gists{/gist_id}", "starred_url": "https://api.github.com/users/soasme/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/soasme/subscriptions", "organizations_url": "https://api.github.com/users/soasme/orgs", "repos_url": "https://api.github.com/users/soasme/repos", "events_url": "https://api.github.com/users/soasme/events{/privacy}", "received_events_url": "https://api.github.com/users/soasme/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Good point, thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/284/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/284", "html_url": "https://github.com/coleifer/peewee/pull/284", "diff_url": "https://github.com/coleifer/peewee/pull/284.diff", "patch_url": "https://github.com/coleifer/peewee/pull/284.patch", "merged_at": "2014-01-16T04:20:25" }

{ "login": "soasme", "id": 369081, "node_id": "MDQ6VXNlcjM2OTA4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/369081?v=4", "gravatar_id": "", "url": "https://api.github.com/users/soasme", "html_url": "https://github.com/soasme", "followers_url": "https://api.github.com/users/soasme/followers", "following_url": "https://api.github.com/users/soasme/following{/other_user}", "gists_url": "https://api.github.com/users/soasme/gists{/gist_id}", "starred_url": "https://api.github.com/users/soasme/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/soasme/subscriptions", "organizations_url": "https://api.github.com/users/soasme/orgs", "repos_url": "https://api.github.com/users/soasme/repos", "events_url": "https://api.github.com/users/soasme/events{/privacy}", "received_events_url": "https://api.github.com/users/soasme/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Nice, thanks for this.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/283/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/283", "html_url": "https://github.com/coleifer/peewee/pull/283", "diff_url": "https://github.com/coleifer/peewee/pull/283.diff", "patch_url": "https://github.com/coleifer/peewee/pull/283.patch", "merged_at": "2014-01-16T04:21:41" }

{ "login": "extesy", "id": 65872, "node_id": "MDQ6VXNlcjY1ODcy", "avatar_url": "https://avatars.githubusercontent.com/u/65872?v=4", "gravatar_id": "", "url": "https://api.github.com/users/extesy", "html_url": "https://github.com/extesy", "followers_url": "https://api.github.com/users/extesy/followers", "following_url": "https://api.github.com/users/extesy/following{/other_user}", "gists_url": "https://api.github.com/users/extesy/gists{/gist_id}", "starred_url": "https://api.github.com/users/extesy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/extesy/subscriptions", "organizations_url": "https://api.github.com/users/extesy/orgs", "repos_url": "https://api.github.com/users/extesy/repos", "events_url": "https://api.github.com/users/extesy/events{/privacy}", "received_events_url": "https://api.github.com/users/extesy/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@extesy -- peewee does not currently come with a JSON field type (if it did, it would be part of `playhouse.postgres_ext`). It sounds like you may have started an implementation of one, otherwise I'm not sure how you have been using the field? Additionally, are you registering a json adapter or using any psycopg2 APIs?\n\nThe more information you can provide the better, thanks!\n", "The only thing I came up so far is to override default psycopg2's json handler by `psycopg2.extras.register_default_json(loads=lambda x: x)` but it looks like hack, not a normal approach to the problem. I've been using peewee only and this workaround is the only case where I use psycopg2 directly.\n\nI think you are right and new JsonField needs to be added to playhouse.postgres_ext, similar to existing HStoreField, etc.\n", "I've added a _very minimal_ Json field. I plan on adding support for the `->` and `->>` operators, but since these are chainable I'd like to think about the implementation a bit.\n", "633e5307d0fe19b3e299f2d6c5d7cd3ee1fd24ca\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/282/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "appetito", "id": 557573, "node_id": "MDQ6VXNlcjU1NzU3Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/557573?v=4", "gravatar_id": "", "url": "https://api.github.com/users/appetito", "html_url": "https://github.com/appetito", "followers_url": "https://api.github.com/users/appetito/followers", "following_url": "https://api.github.com/users/appetito/following{/other_user}", "gists_url": "https://api.github.com/users/appetito/gists{/gist_id}", "starred_url": "https://api.github.com/users/appetito/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/appetito/subscriptions", "organizations_url": "https://api.github.com/users/appetito/orgs", "repos_url": "https://api.github.com/users/appetito/repos", "events_url": "https://api.github.com/users/appetito/events{/privacy}", "received_events_url": "https://api.github.com/users/appetito/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I tested this by hand. I typed in some models to recreate your schema (what pwiz _should_ have generated), then created the tables and ran pwiz against them.\n\n``` python\n# Models I typed in by hand:\nclass Category(BaseModel):\n name = CharField(max_length=500)\n parent = ForeignKeyField('self', null=True)\n\n class Meta:\n db_table = 'categories'\n\nclass Product(BaseModel):\n name = CharField(max_length=500)\n category = ForeignKeyField(Category)\n type = CharField(max_length=10)\n price = IntegerField()\n bid = IntegerField()\n available = BooleanField()\n description = TextField()\n picture = CharField(max_length=500)\n author = CharField(max_length=500)\n publisher = CharField(max_length=500)\n year = IntegerField()\n isbn = CharField(max_length=50)\n binding = CharField(max_length=500)\n page_extent = IntegerField()\n\n class Meta:\n db_table = 'products'\n```\n\nHere is what postgres shows me:\n\n```\n Table \"public.categories\"\n Column | Type | Modifiers \n-----------+------------------------+---------------------------------------------------------\n id | integer | not null default nextval('categories_id_seq'::regclass)\n name | character varying(500) | not null\n parent_id | integer | \nIndexes:\n \"categories_pkey\" PRIMARY KEY, btree (id)\n \"categories_parent_id\" btree (parent_id)\nForeign-key constraints:\n \"categories_parent_id_fkey\" FOREIGN KEY (parent_id) REFERENCES categories(id)\nReferenced by:\n TABLE \"categories\" CONSTRAINT \"categories_parent_id_fkey\" FOREIGN KEY (parent_id) REFERENCES categories(id)\n TABLE \"products\" CONSTRAINT \"products_category_id_fkey\" FOREIGN KEY (category_id) REFERENCES categories(id)\n\n Table \"public.products\"\n Column | Type | Modifiers \n-------------+------------------------+-------------------------------------------------------\n id | integer | not null default nextval('products_id_seq'::regclass)\n name | character varying(500) | not null\n category_id | integer | not null\n type | character varying(10) | not null\n price | integer | not null\n bid | integer | not null\n available | boolean | not null\n description | text | not null\n picture | character varying(500) | not null\n author | character varying(500) | not null\n publisher | character varying(500) | not null\n year | integer | not null\n isbn | character varying(50) | not null\n binding | character varying(500) | not null\n page_extent | integer | not null\nIndexes:\n \"products_pkey\" PRIMARY KEY, btree (id)\n \"products_category_id\" btree (category_id)\nForeign-key constraints:\n \"products_category_id_fkey\" FOREIGN KEY (category_id) REFERENCES categories(id)\n```\n\nHere is what I get when I run pwiz against the generated tables:\n\n``` python\nclass Categories(BaseModel):\n name = CharField(max_length=500)\n parent = ForeignKeyField(null=True, db_column='parent_id', rel_model='self')\n\n class Meta:\n db_table = 'categories'\n\nclass Products(BaseModel):\n author = CharField(max_length=500)\n available = BooleanField()\n bid = IntegerField()\n binding = CharField(max_length=500)\n category = ForeignKeyField(db_column='category_id', rel_model=Categories)\n description = TextField()\n isbn = CharField(max_length=50)\n name = CharField(max_length=500)\n page_extent = IntegerField()\n picture = CharField(max_length=500)\n price = IntegerField()\n publisher = CharField(max_length=500)\n type = CharField(max_length=10)\n year = IntegerField()\n\n class Meta:\n db_table = 'products'\n```\n\nAs you can see, the generated code looks correct. Can you dump your schema? I'd like to see in more detail what CREATE statements were used to generate those models. Also could you include your postgres and psycopg2 versions?\n", "Also, could you run the following query and paste the output?\n\n``` sql\nselect oid, typname from pg_type where typname not like '\\_%' order by oid limit 50;\n```\n", "```\nCREATE TABLE categories(\n id SERIAL PRIMARY KEY,\n parent_id INTEGER,\n name VARCHAR(500),\n FOREIGN KEY (parent_id) REFERENCES categories\n);\n\n\nCREATE TABLE products(\n id BIGSERIAL PRIMARY KEY,\n name VARCHAR(500),\n category_id INTEGER,\n type VARCHAR(10),\n price INTEGER,\n bid INTEGER,\n available BOOLEAN DEFAULT false,\n description TEXT,\n picture VARCHAR(500),\n author VARCHAR(500),\n publisher VARCHAR(500),\n year INTEGER,\n isbn VARCHAR(50),\n binding VARCHAR(500),\n page_extent INTEGER,\n FOREIGN KEY (category_id) REFERENCES categories\n);\n```\n\n```\nselect oid, typname from pg_type where typname not like '\\_%' order by oid limit 50;\n\n oid | typname \n------+--------------\n 16 | bool\n 17 | bytea\n 18 | char\n 19 | name\n 20 | int8\n 21 | int2\n 22 | int2vector\n 23 | int4\n 24 | regproc\n 25 | text\n 26 | oid\n 27 | tid\n 28 | xid\n 29 | cid\n 30 | oidvector\n 71 | pg_type\n 75 | pg_attribute\n 81 | pg_proc\n 83 | pg_class\n 142 | xml\n 194 | pg_node_tree\n 210 | smgr\n 600 | point\n 601 | lseg\n 602 | path\n 603 | box\n 604 | polygon\n 628 | line\n 650 | cidr\n 700 | float4\n 701 | float8\n 702 | abstime\n 703 | reltime\n 704 | tinterval\n 705 | unknown\n 718 | circle\n 790 | money\n 829 | macaddr\n 869 | inet\n 1033 | aclitem\n 1042 | bpchar\n 1043 | varchar\n 1082 | date\n 1083 | time\n 1114 | timestamp\n 1184 | timestamptz\n 1186 | interval\n 1248 | pg_database\n 1266 | timetz\n 1560 | bit\n(50 rows)\n```\n\npsycopg2==2.5.2\npostgres (PostgreSQL) 9.1.11\n", "My list matches yours (with the exception of the JSON type since I'm using 9.3). Not sure, do you have any ideas what might be going on? It's extra strange that some of the varchar() columns are recognized correctly (products.name) while others are not (products.author).\n\nDo you have any other tables in this database? Is there any chance you could give me a dump of the schema only?\n", "Using the `CREATE TABLE` statements you provided, I created the tables locally and ran pwiz -- the output looked correct:\n\n``` python\nclass Categories(BaseModel):\n name = CharField(max_length=500, null=True)\n parent = ForeignKeyField(null=True, db_column='parent_id', rel_model='self')\n\n class Meta:\n db_table = 'categories'\n\nclass Products(BaseModel):\n author = CharField(max_length=500, null=True)\n available = BooleanField(null=True)\n bid = IntegerField(null=True)\n binding = CharField(max_length=500, null=True)\n category = ForeignKeyField(null=True, db_column='category_id', rel_model=Categories)\n description = TextField(null=True)\n isbn = CharField(max_length=50, null=True)\n name = CharField(max_length=500, null=True)\n page_extent = IntegerField(null=True)\n picture = CharField(max_length=500, null=True)\n price = IntegerField(null=True)\n publisher = CharField(max_length=500, null=True)\n type = CharField(max_length=10, null=True)\n year = IntegerField(null=True)\n\n class Meta:\n db_table = 'products'\n```\n", "i must look closer, thanks\n", "Please reopen if you find anything or have any new info.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/281/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bndr", "id": 1145456, "node_id": "MDQ6VXNlcjExNDU0NTY=", "avatar_url": "https://avatars.githubusercontent.com/u/1145456?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bndr", "html_url": "https://github.com/bndr", "followers_url": "https://api.github.com/users/bndr/followers", "following_url": "https://api.github.com/users/bndr/following{/other_user}", "gists_url": "https://api.github.com/users/bndr/gists{/gist_id}", "starred_url": "https://api.github.com/users/bndr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bndr/subscriptions", "organizations_url": "https://api.github.com/users/bndr/orgs", "repos_url": "https://api.github.com/users/bndr/repos", "events_url": "https://api.github.com/users/bndr/events{/privacy}", "received_events_url": "https://api.github.com/users/bndr/received_events", "type": "User", "site_admin": false }

[]

[]

[ "When you access the `lat` and `lon` attrs, you need to do so from the `Place` model. You need to wrap your comparisons in parens because of operator precedence. Lastly, the usage of the `math` module won't work at all the way you're trying to use it. You will need to use database functions.\n\nI did not test the code below, but hopefully this helps get you on the right track:\n\n``` python\nToPlace = Place.alias()\nFromPlace = Place.alias()\ntrips = (\n Trip\n .select()\n .join(ToPlace, on=(Trip.to_place == ToPlace.id))\n .switch(Trip)\n .join(FromPlace, on=(Trip.from_place == FromPlace.id))\n .where(\n (Trip.date >= date) &\n (Trip.status == 'active') &\n (fn.Acos(\n (fn.Cos(fn.Radians(FromPlace.lat)) * fn.Cos(rLat) * fn.Cos(fn.Radians(FromPlace.lon) - rLon)) +\n (fn.Sin(fn.Radians(FromPlace.lat)) * fn.Sin(rLat)) * earth_radius)) < radius))\n```\n", "Thanks! Your answer helped a lot! I finally got it working.\n\nI'll just write some keywords here, so that people looking for the same thing, could find it: peewee great circle distance haversine formula, two gps points\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/280/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You have multiple O(n) queries lurking in that loop. Every foreign key resolution (`row.test.name`, `row.component.n`) triggers as query.\n\nYou can accomplish this in O(1) queries (tested locally using sqlite). Try this:\n\n``` python\nrows = (\n Execution\n .select(\n Execution,\n Test,\n Component)\n .join(Test).switch(Execution)\n .join(Component))\n\nfor row in rows:\n print row.identifier, row.test.name, row.component.n, row.component.v\n```\n\nI tried to get it to \"pre-fetch\" the `kernel` and `tool` attributes, but this did not work as I intended...I'll look into that, but hopefully this should help speed up your query.\n", "Hey,\n\nhere is what I got:\n\n```\nIn [17]: data = db.Execution.select(db.Test,db.Result,db.Arch,db.Component,db.Phase,db.Tester).join(db.Test).switch(db.Execution).join(db.Result).switch(db.Execution).join(db.Arch).switch(db.Execution).join(db.Component).switch(db.Execution).join(db.Phase).switch(db.Execution).join(db.Tester).switch(db.Execution)\n\nIn [18]: for row in data:\n ....: print row.identifier, row.test.name, row.component.n, row.component.v\n ....: \n ....: \n---------------------------------------------------------------------------\nKeyError Traceback (most recent call last)\n\n/home/tpelka/workspace/desktopqe-resultsDB/<ipython console> in <module>()\n\n/usr/lib/python2.6/site-packages/peewee.pyc in next(self)\n 1190 return inst\n 1191 \n-> 1192 obj = self.iterate()\n 1193 self._result_cache.append(obj)\n 1194 self.__ct += 1\n\n/usr/lib/python2.6/site-packages/peewee.pyc in iterate(self)\n 1178 self.initialize(self.cursor.description)\n 1179 self._initialized = True\n-> 1180 return self.process_row(row)\n 1181 \n 1182 def iterator(self):\n\n/usr/lib/python2.6/site-packages/peewee.pyc in process_row(self, row)\n 1298 def process_row(self, row):\n 1299 collected = self.construct_instance(row)\n-> 1300 instances = self.follow_joins(collected)\n 1301 for i in instances:\n 1302 i.prepared()\n\n/usr/lib/python2.6/site-packages/peewee.pyc in follow_joins(self, collected)\n 1319 \n 1320 def follow_joins(self, collected):\n-> 1321 prepared = [collected[self.model]]\n 1322 for (lhs, attr, rhs) in self.join_map:\n 1323 inst = collected[lhs]\n\nKeyError: <class 'db.Execution'>\n```\n", "```\n<cleifer> i can't replicate b/c i don't have model definitions for phase, result or tester\n<cleifer> tpelka, ^^\n<tpelka> cleifer: let me send you the model and addtodb.py \n<tpelka> github?\n<tpelka> cleifer: can I attache files to github?\n<cleifer> make a gist then link it?\n<cleifer> that might b easiest\n<tpelka> grr Unfortunately we don't support that file type yet. Please use PNG, GIF, or JPG. \n<tpelka> https://gist.github.com/tompelka/8400960 = db.py\n<cleifer> thanks!\n<tpelka> https://gist.github.com/tompelka/8400976 = addtodb.py\n<tpelka> cleifer: in this case I should change memory to some sqlite file right?\n<cleifer> no worries\n```\n", "I modified your test code and was not able to replicate the error. The big change was to add `Execution` to the list of tables selected.\n\n``` python\nfrom peewee import *\nfrom peewee import create_model_tables\nfrom peewee import Expression\nimport datetime\nimport os\n\n# for\nOP_REGEXP = 'regexp'\n\n# server not defined, create it in memory\ndatabase = SqliteDatabase(':memory:')\n\n# model definitions -- the standard \"pattern\" is to define a base model class\n# that specifies which database to use. then, any subclasses will automatically\n# use the correct storage.\nclass BaseModel(Model):\n class Meta:\n database = database\n\n\n# test db table\nclass Test(BaseModel):\n parent = ForeignKeyField('self', related_name='children', null=True, cascade=True)\n name = TextField()\n\n\n# hw db table\nclass Hw(BaseModel):\n name = TextField()\n vendor = TextField()\n device = TextField()\n codec = TextField(default=\"\")\n\n\n# status db table\nclass Status(BaseModel):\n name = TextField()\n\n\n# result db table\nclass Result(BaseModel):\n status = ForeignKeyField(Status)\n num_passed = IntegerField()\n num_failed = IntegerField()\n num_skipped = IntegerField(null=True)\n\n\n# release db table\nclass Release(BaseModel):\n major = TextField()\n minor = TextField()\n is_zstream = BooleanField(default=False)\n\n\n# arch db table\nclass Arch(BaseModel):\n name = TextField()\n\n\n# component db table\nclass Component(BaseModel):\n n = TextField()\n v = TextField()\n r = TextField()\n rhel = ForeignKeyField(Release)\n\n\n# phase db table\nclass Phase(BaseModel):\n name = TextField()\n\n\n# tester db table\nclass Tester(BaseModel):\n login = TextField()\n full_name = TextField()\n\n\n# execution db table\nclass Execution(BaseModel):\n time = DateTimeField(default=datetime.datetime.now, help_text=\"Insert time\")\n log = TextField()\n identifier = TextField()\n tcmsID = TextField(null=True)\n beakerID = TextField(null=True)\n test = ForeignKeyField(Test)\n hw = ForeignKeyField(Hw, null=True)\n result = ForeignKeyField(Result)\n release = ForeignKeyField(Release)\n arch = ForeignKeyField(Arch)\n component = ForeignKeyField(Component, related_name='component_ver')\n kernel = ForeignKeyField(Component, related_name='kernel_ver', null=True)\n tool = ForeignKeyField(Component, related_name='tool_ver', null=True)\n phase = ForeignKeyField(Phase)\n tester = ForeignKeyField(Tester)\n note = TextField()\n is_valid = BooleanField(default=False)\n\n class Meta:\n order_by = ('time',)\n\ncreate_model_tables([Test, Hw, Result, Status, Release, Arch, Component, Phase, Tester, Execution])\n\nt1 = Test.create(name='t1')\nt2 = Test.create(name='t2')\nhw1 = Hw.create(name='hw1', vendor='', device='')\nhw2 = Hw.create(name='hw2', vendor='', device='')\nr1 = Release.create(major='1', minor='0')\nr2 = Release.create(major='2', minor='0')\na1 = Arch.create(name='a1')\na2 = Arch.create(name='a2')\nc1 = Component.create(n='c1', v='', r='', rhel=r1)\nc2 = Component.create(n='c2', v='', r='', rhel=r1)\nk1 = Component.create(n='k1', v='', r='', rhel=r1)\nk2 = Component.create(n='k2', v='', r='', rhel=r1)\no1 = Component.create(n='o1', v='', r='', rhel=r1)\no2 = Component.create(n='o2', v='', r='', rhel=r1)\np1 = Phase.create(name='p1')\np2 = Phase.create(name='p2')\nts1 = Tester.create(login='tester1', full_name='')\nts2 = Tester.create(login='tester2', full_name='')\ns1 = Status.create(name='s1')\ns2 = Status.create(name='s2')\nrs1 = Result.create(status=s1, num_passed=0, num_failed=0)\nrs2 = Result.create(status=s2, num_passed=0, num_failed=0)\n\nfor i in range(10):\n n1 = 'e%s' % i\n n2 = 'e%s' % (i + 10)\n Execution.create(\n log=n1,\n identifier=n1,\n test=t1,\n hw=hw1,\n result=rs1,\n arch=a1,\n release=r1,\n component=c1,\n kernel=k1,\n tool=o1,\n phase=p1,\n tester=ts1,\n note=n1)\n Execution.create(\n log=n2,\n identifier=n2,\n test=t2,\n hw=hw2,\n result=rs2,\n arch=a2,\n release=r2,\n component=c2,\n kernel=k2,\n tool=o2,\n phase=p2,\n tester=ts2,\n note=n2)\n\nimport logging\nlogger = logging.getLogger('peewee')\nlogger.setLevel(logging.DEBUG)\nlogger.addHandler(logging.StreamHandler())\n\nrows = (\n Execution\n .select(\n Execution,\n Test,\n Result,\n Arch,\n Component,\n Phase,\n Tester)\n .join(Test).switch(Execution)\n .join(Result).switch(Execution)\n .join(Arch).switch(Execution)\n .join(Component).switch(Execution)\n .join(Phase).switch(Execution)\n .join(Tester).switch(Execution))\n\nfor row in rows:\n print row.identifier, row.test.name, row.component.n, row.component.v\n```\n\nOutput:\n\n```\n('\nSELECT \n t1.\"id\", t1.\"time\", t1.\"log\", t1.\"identifier\", t1.\"tcmsID\", t1.\"beakerID\", t1.\"test_id\", t1.\"hw_id\", t1.\"result_id\", t1.\"release_id\", t1.\"arch_id\", t1.\"component_id\", t1.\"kernel_id\", t1.\"tool_id\", t1.\"phase_id\", t1.\"tester_id\", t1.\"note\", t1.\"is_valid\", \n t2.\"id\", t2.\"parent_id\", t2.\"name\", \n t3.\"id\", t3.\"status_id\", t3.\"num_passed\", t3.\"num_failed\", t3.\"num_skipped\", \n t4.\"id\", t4.\"name\", \n t5.\"id\", t5.\"n\", t5.\"v\", t5.\"r\", t5.\"rhel_id\", \n t6.\"id\", t6.\"name\", \n t7.\"id\", t7.\"login\", t7.\"full_name\" \nFROM \"execution\" AS t1 \nINNER JOIN \"test\" AS t2 ON (t1.\"test_id\" = t2.\"id\") \nINNER JOIN \"result\" AS t3 ON (t1.\"result_id\" = t3.\"id\") \nINNER JOIN \"arch\" AS t4 ON (t1.\"arch_id\" = t4.\"id\") \nINNER JOIN \"component\" AS t5 ON (t1.\"component_id\" = t5.\"id\") \nINNER JOIN \"phase\" AS t6 ON (t1.\"phase_id\" = t6.\"id\") \nINNER JOIN \"tester\" AS t7 ON (t1.\"tester_id\" = t7.\"id\") \nORDER BY t1.\"time\" ASC', [])\n\ne0 t1 c1 \ne10 t2 c2 \ne1 t1 c1 \ne11 t2 c2 \ne2 t1 c1 \ne12 t2 c2 \ne3 t1 c1 \ne13 t2 c2 \ne4 t1 c1 \ne14 t2 c2 \ne5 t1 c1 \ne15 t2 c2 \ne6 t1 c1 \ne16 t2 c2 \ne7 t1 c1 \ne17 t2 c2 \ne8 t1 c1 \ne18 t2 c2 \ne9 t1 c1 \ne19 t2 c2\n```\n", "@tompelka -- I added `Release` to the list of selected tables and joins it still works:\n\n``` python\nrows = (\n Execution\n .select(\n Execution,\n Test,\n Result,\n Release,\n Arch,\n Component,\n Phase,\n Tester)\n .join(Test).switch(Execution)\n .join(Result).switch(Execution)\n .join(Release).switch(Execution)\n .join(Arch).switch(Execution)\n .join(Component).switch(Execution)\n .join(Phase).switch(Execution)\n .join(Tester).switch(Execution))\n```\n\nYou mentioned in IRC that it was still slow...can you share the code you're using in the loop? Depending on what attributes you access you may be triggering more queries.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/279/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "lucasmarshall", "id": 885074, "node_id": "MDQ6VXNlcjg4NTA3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/885074?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lucasmarshall", "html_url": "https://github.com/lucasmarshall", "followers_url": "https://api.github.com/users/lucasmarshall/followers", "following_url": "https://api.github.com/users/lucasmarshall/following{/other_user}", "gists_url": "https://api.github.com/users/lucasmarshall/gists{/gist_id}", "starred_url": "https://api.github.com/users/lucasmarshall/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lucasmarshall/subscriptions", "organizations_url": "https://api.github.com/users/lucasmarshall/orgs", "repos_url": "https://api.github.com/users/lucasmarshall/repos", "events_url": "https://api.github.com/users/lucasmarshall/events{/privacy}", "received_events_url": "https://api.github.com/users/lucasmarshall/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks!\n", "Sure thing.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/278/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/278", "html_url": "https://github.com/coleifer/peewee/pull/278", "diff_url": "https://github.com/coleifer/peewee/pull/278.diff", "patch_url": "https://github.com/coleifer/peewee/pull/278.patch", "merged_at": "2014-01-02T23:24:53" }

{ "login": "grantcox", "id": 186808, "node_id": "MDQ6VXNlcjE4NjgwOA==", "avatar_url": "https://avatars.githubusercontent.com/u/186808?v=4", "gravatar_id": "", "url": "https://api.github.com/users/grantcox", "html_url": "https://github.com/grantcox", "followers_url": "https://api.github.com/users/grantcox/followers", "following_url": "https://api.github.com/users/grantcox/following{/other_user}", "gists_url": "https://api.github.com/users/grantcox/gists{/gist_id}", "starred_url": "https://api.github.com/users/grantcox/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/grantcox/subscriptions", "organizations_url": "https://api.github.com/users/grantcox/orgs", "repos_url": "https://api.github.com/users/grantcox/repos", "events_url": "https://api.github.com/users/grantcox/events{/privacy}", "received_events_url": "https://api.github.com/users/grantcox/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you so much for bringing this to my attention, you are absolutely right.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/277/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ghost", "id": 10137, "node_id": "MDQ6VXNlcjEwMTM3", "avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ghost", "html_url": "https://github.com/ghost", "followers_url": "https://api.github.com/users/ghost/followers", "following_url": "https://api.github.com/users/ghost/following{/other_user}", "gists_url": "https://api.github.com/users/ghost/gists{/gist_id}", "starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ghost/subscriptions", "organizations_url": "https://api.github.com/users/ghost/orgs", "repos_url": "https://api.github.com/users/ghost/repos", "events_url": "https://api.github.com/users/ghost/events{/privacy}", "received_events_url": "https://api.github.com/users/ghost/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Since `Schuelerkontakt` extends `Kontakt`, it also includes copies of the various foreign keys. For instance `typ = ForeignKeyField(Kontakttyp, related_name='typ_des_kontakts')`.\n\nThat sets up an attribute on `Kontakttyp` named `typ_des_kontakts` that initially points to `Kontakt`. When we get to `Schuelerkontakt` (which has the same `typ = ForeignKeyField(...)` because of inheritance) the related name collides with the existing one.\n\nMy suggestion would be to rewrite your models like so:\n\n``` python\nclass Kontakt(SqliteModel):\n typ = ForeignKeyField(Kontakttyp,\n related_name='typ_des_kontakts')\n bezeichner = CharField(max_length=40)\n kategorie = ForeignKeyField(Kontaktkategorie,\n null=True,\n related_name='kategorie_des_kontakts')\n\n def __unicode__(self):\n return u\"%s: %s \" % (self.typ, self.bezeichner)\n if self.kontaktkategorie:\n return out + \"[%s]\" % (self.kategorie,)\n\n\nclass Schuelerkontakt(Kontakt):\n typ = ForeignKeyField(Kontakttyp,\n related_name='typ_des_schueler_kontakts')\n schueler = ForeignKeyField(Schueler,\n related_name='kontakt_des_schuelers')\n kategorie = ForeignKeyField(Kontaktkategorie,\n null=True,\n related_name='kategorie_des_shuelerkontakts')\n\n\nclass Lehrerkontakt(Kontakt):\n typ = ForeignKeyField(Kontakttyp,\n related_name='typ_des_lehrer_kontakts')\n lehrer = ForeignKeyField(Lehrkraft,\n related_name='kontakt_der_lehrkraft')\n kategorie = ForeignKeyField(Kontaktkategorie,\n null=True,\n related_name='kategorie_des_lehrerkontakts')\n```\n\nPardon me if I butchered the names.\n\n---\n\nAs an aside, just wanted to make sure you understood how model inheritance works. It does not do anything clever as far as multi-table joins or polymorphism at the row-level.\n", "Thanks,\n\ni should have red your docs in detail - sorry. The document part [Inheriting model metadata](http://peewee.readthedocs.org/en/latest/peewee/models.html#inheriting-model-metadata) has gone unnoticed to my _/head/null_ :(\n", "No prob, the inheritance stuff can be very confusing.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/276/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ghost", "id": 10137, "node_id": "MDQ6VXNlcjEwMTM3", "avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ghost", "html_url": "https://github.com/ghost", "followers_url": "https://api.github.com/users/ghost/followers", "following_url": "https://api.github.com/users/ghost/following{/other_user}", "gists_url": "https://api.github.com/users/ghost/gists{/gist_id}", "starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ghost/subscriptions", "organizations_url": "https://api.github.com/users/ghost/orgs", "repos_url": "https://api.github.com/users/ghost/repos", "events_url": "https://api.github.com/users/ghost/events{/privacy}", "received_events_url": "https://api.github.com/users/ghost/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This error affected py3k, which I don't regularly test -- my fault. I've fixed and re-pushed to PYPI as 2.1.7.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/275/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "pitchforks", "id": 4378791, "node_id": "MDQ6VXNlcjQzNzg3OTE=", "avatar_url": "https://avatars.githubusercontent.com/u/4378791?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pitchforks", "html_url": "https://github.com/pitchforks", "followers_url": "https://api.github.com/users/pitchforks/followers", "following_url": "https://api.github.com/users/pitchforks/following{/other_user}", "gists_url": "https://api.github.com/users/pitchforks/gists{/gist_id}", "starred_url": "https://api.github.com/users/pitchforks/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pitchforks/subscriptions", "organizations_url": "https://api.github.com/users/pitchforks/orgs", "repos_url": "https://api.github.com/users/pitchforks/repos", "events_url": "https://api.github.com/users/pitchforks/events{/privacy}", "received_events_url": "https://api.github.com/users/pitchforks/received_events", "type": "User", "site_admin": false }

[]

[]

[ "That makes sense. I only recently started tracking changes between versions so I wasn't actually sure anyone even looked at the releases on GH.\n\nIs there a special way to do this, or just make a `CHANGELOG` file in the repo and bundle it with the package?\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/274/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This is partially fixed by d5a5a86a14b7d631ef8b8b3759bfd8345def9b56 which makes it possible to use `Proxy` with `ForeignKeyField`. Unfortunately, Postgresql will complain about the `create table` queries generated so I'll need to work around this.\n", "http://peewee.readthedocs.org/en/latest/peewee/cookbook.html#circular-foreign-key-dependencies\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/273/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "xiaq", "id": 582021, "node_id": "MDQ6VXNlcjU4MjAyMQ==", "avatar_url": "https://avatars.githubusercontent.com/u/582021?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xiaq", "html_url": "https://github.com/xiaq", "followers_url": "https://api.github.com/users/xiaq/followers", "following_url": "https://api.github.com/users/xiaq/following{/other_user}", "gists_url": "https://api.github.com/users/xiaq/gists{/gist_id}", "starred_url": "https://api.github.com/users/xiaq/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xiaq/subscriptions", "organizations_url": "https://api.github.com/users/xiaq/orgs", "repos_url": "https://api.github.com/users/xiaq/repos", "events_url": "https://api.github.com/users/xiaq/events{/privacy}", "received_events_url": "https://api.github.com/users/xiaq/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm not sure why this is missing but let's add it back. Thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/272/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/272", "html_url": "https://github.com/coleifer/peewee/pull/272", "diff_url": "https://github.com/coleifer/peewee/pull/272.diff", "patch_url": "https://github.com/coleifer/peewee/pull/272.patch", "merged_at": "2013-12-21T13:45:00" }

{ "login": "MichaelBlume", "id": 208853, "node_id": "MDQ6VXNlcjIwODg1Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/208853?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MichaelBlume", "html_url": "https://github.com/MichaelBlume", "followers_url": "https://api.github.com/users/MichaelBlume/followers", "following_url": "https://api.github.com/users/MichaelBlume/following{/other_user}", "gists_url": "https://api.github.com/users/MichaelBlume/gists{/gist_id}", "starred_url": "https://api.github.com/users/MichaelBlume/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MichaelBlume/subscriptions", "organizations_url": "https://api.github.com/users/MichaelBlume/orgs", "repos_url": "https://api.github.com/users/MichaelBlume/repos", "events_url": "https://api.github.com/users/MichaelBlume/events{/privacy}", "received_events_url": "https://api.github.com/users/MichaelBlume/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Can you provide more information? How can I replicate this?\n", "Here are some examples:\n\n``` python\nIn [1]: from peewee import *\n\nIn [2]: db = PostgresqlDatabase('doesnotexist')\n\nIn [3]: db.connect()\nOperationalError: FATAL: database \"doesnotexist\" does not exist\n\nIn [4]: db = PostgresqlDatabase('peewee_test', user='invalid_user')\n\nIn [5]: db.connect()\nOperationalError: FATAL: role \"invalid_user\" does not exist\n```\n", "```\nPython 2.7.3 (default, Aug 1 2012, 05:14:39) \n[GCC 4.6.3] on linux2\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n>>> from peewee import *\n>>> \n>>> db = SqliteDatabase('people.db')\n>>> \n>>> class Person(Model):\n... name = CharField()\n... birthday = DateField()\n... is_relative = BooleanField()\n... class Meta:\n... database = db\n... \n>>> def identity(x):\n... return x\n... \n>>> persons_named_bob = Person.select().where(Person.name == \"Bob\")\n>>> map(identity, persons_named_bob)\nNo handlers could be found for logger \"peewee\"\nTraceback (most recent call last):\n File \"<stdin>\", line 1, in <module>\nTypeError: argument 2 to map() must support iteration\n```\n", "Gotcha, thank you for the example. So there's an error which isn't caught until the query is evaluated.\n\nSee the note in the docs: http://peewee.readthedocs.org/en/latest/peewee/cookbook.html#creating-a-database-connection-and-tables\n\n> While it is not necessary to explicitly connect to the database before using it, managing connections explicitly is a good practice. This way if the connection fails, the exception can be caught during the “connect” step, rather than some arbitrary time later when a query is executed.\n\nSo putting `db.connect()` before your call to `map` will catch an error creating the connection.\n", "As for `map` swallowing exceptions, that does not appear to be a problem with peewee specifically:\n\n``` python\nIn [15]: map(identity, None)\n---------------------------------------------------------------------------\nTypeError Traceback (most recent call last)\n<ipython-input-15-7e3da6cfa2ca> in <module>()\n----> 1 map(identity, None)\n\nTypeError: argument 2 to map() must support iteration\n\nIn [16]: map(identity, 1.0)\n---------------------------------------------------------------------------\nTypeError Traceback (most recent call last)\n<ipython-input-16-df55ff2dd812> in <module>()\n----> 1 map(identity, 1.0)\n\nTypeError: argument 2 to map() must support iteration\n```\n", "Ah, I see the problem better now:\n\n```\nIn [10]: class BadIter(object):\n ....: def next(self):\n ....: raise Exception()\n ....: \n\nIn [13]: class BadIterable(object):\n ....: def __iter__(self):\n ....: return BadIter()\n ....: \n\nIn [19]: def identity(x):\n ....: return x\n ....: \n\nIn [20]: map(identity, BadIterable())\n---------------------------------------------------------------------------\nException Traceback (most recent call last)\n<ipython-input-20-f77dd3200d2b> in <module>()\n----> 1 map(identity, BadIterable())\n\n<ipython-input-10-d95eda570961> in next(self)\n 1 class BadIter(object):\n 2 def next(self):\n----> 3 raise Exception()\n 4 \n\nException: \n\nIn [21]: class WorseIterable(object):\n ....: def __iter__(self):\n ....: raise Exception()\n ....: \n\nIn [22]: map(identity, WorseIterable())\n---------------------------------------------------------------------------\nTypeError Traceback (most recent call last)\n<ipython-input-22-1cbe60ec7e3b> in <module>()\n----> 1 map(identity, WorseIterable())\n\nTypeError: argument 2 to map() must support iteration\n```\n\nSo an exception in `next()` will propagate, but an exception in `__iter__()` will be obscured _by python itself_. I'd just about call that a Python bug.\n", "Looks like it's fixed in Python 3 though, so there's another reason for us all to migrate =)\n\nThanks!\n", "Sure thing, thanks for the code -- I'm sure this will be useful if this crops up again!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/271/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "So on the model `B` somewhere we would need to have columns mapped to `A.id` and `A.description`. Then introduce a FK constraint and accessor that would do the right joins.\n", "Does it make sense to add a `CompositeForeignKey`, so you'd end up with something like:\n\n``` python\n\nclass A(ContextModel):\n id = IntegerField()\n another_thing = CharField()\n description = TextField()\n\n class Meta: \n primary_key = CompositeKey('id', 'description') \n\nclass B(ContextModel):\n a_id = IntegerField()\n a_description = TextField()\n a = CompositeForeignKey(A, 'a_id', 'a_description')\n```\n", "I think it does. If you think that's the best way to go. \nWhat's the difference between inspecting inside ForeignKey whether the target model's key is a CompositeKey against creating a new class for the CompositeForeignKey? \n\nBut again, I think the fix you propose does the job pretty well. thanks!\n", "> What's the difference between inspecting inside ForeignKey whether the target model's key is a CompositeKey against creating a new class for the CompositeForeignKey?\n\nIn a typical model the `ForeignKeyField` is a single column on a table (hence, it subclasses Field). When you want to foreign-key to a model with a composite pk, you would need multiple columns (to mirror the columns making up the primary key).\n", "What will happen in such case?\n\n```\nclass A(ContextModel):\n id = IntegerField()\n another_thing = CharField()\n description = TextField()\n\n class Meta:\n indexes = (( 'a_id', 'a_description'), True) ,\n\nclass B(ContextModel):\n a_id = IntegerField()\n a_description = TextField()\n a = CompositeForeignKey(A, 'a_id', 'a_description')\n```\n", "@akaRem -- what do you mean?\n", "I'm going to close this for now.\n", "@coleifer Any progress on this ? It still crashes with the same exception.\n\nIf it's not peewee goal, it would be worth to mention it in docs, because \n\n> Peewee has very basic support for composite keys\n\nIs not enough.\n", "I think I'm running into this too, I want to have a composite foreign key like so:\n\n``` python\n# coding=utf-8\nfrom peewee import *\n\ndb = SqliteDatabase('dump4.db')\n\nclass BaseModel(Model):\n\n class Meta:\n database = db\n\nclass table_A(BaseModel):\n tabA_id = IntegerField(primary_key=True, index=True)\n colA_data = IntegerField(index=True)\n\n\nclass table_C(BaseModel):\n tabA_id = ForeignKeyField(table_A, related_name='cs')\n tabC_id = IntegerField()\n colC_data = BooleanField()\n\n class Meta:\n primary_key = CompositeKey('tabA_id', 'tabC_id', 'colC_data')\n\n\nclass table_B(BaseModel):\n tabA_id = ForeignKeyField(table_A, related_name='bs')\n tabB_id = IntegerField()\n colB_data = BooleanField()\n\n class Meta:\n primary_key = CompositeKey('tabA_id', 'tabB_id', 'colB_data')\n\nclass table_D(BaseModel):\n tabA_id = ForeignKeyField(table_A, related_name='ds')\n tabD_id = IntegerField()\n tabB_id = ForeignKeyField(table_B, related_name='ds')\n colB_data = ForeignKeyField(table_B)\n colD_data = TextField()\n\n class Meta:\n primary_key = CompositeKey('tabA_id', 'tabD_id',\n 'colB_data')\n\n\ndef main():\n tables = [\n table_A, table_B,\n table_C, table_D,\n ]\n db.connect()\n db.drop_tables(tables, safe=True)\n db.create_tables(tables, safe=True)\n #populate_db(db)\n print('DB done')\n\n\nif __name__ == '__main__':\n main()\n```\n\nWith peewee 2.4.7 on python 3.4.3 I get:\n\n```\nTraceback (most recent call last):\n File \"test4.py\", line 58, in <module>\n main()\n File \"test4.py\", line 52, in main\n db.create_tables(tables, safe=True)\n File \"/Users/jimd/Desktop/p/sec/parse4/lib/python3.4/site-packages/peewee.py\", line 2959, in create_tables\n create_model_tables(models, fail_silently=safe)\n File \"/Users/jimd/Desktop/p/sec/parse4/lib/python3.4/site-packages/peewee.py\", line 4049, in create_model_tables\n m.create_table(**create_table_kwargs)\n File \"/Users/jimd/Desktop/p/sec/parse4/lib/python3.4/site-packages/peewee.py\", line 3798, in create_table\n db.create_table(cls)\n File \"/Users/jimd/Desktop/p/sec/parse4/lib/python3.4/site-packages/peewee.py\", line 2956, in create_table\n return self.execute_sql(*qc.create_table(model_class, safe))\n File \"/Users/jimd/Desktop/p/sec/parse4/lib/python3.4/site-packages/peewee.py\", line 1666, in inner\n return self.parse_node(fn(*args, **kwargs))\n File \"/Users/jimd/Desktop/p/sec/parse4/lib/python3.4/site-packages/peewee.py\", line 1694, in _create_table\n columns.append(self.field_definition(field))\n File \"/Users/jimd/Desktop/p/sec/parse4/lib/python3.4/site-packages/peewee.py\", line 1644, in field_definition\n column_type = self.get_column_type(field.get_db_field())\n File \"/Users/jimd/Desktop/p/sec/parse4/lib/python3.4/site-packages/peewee.py\", line 1119, in get_db_field\n return self.to_field.get_db_field()\nAttributeError: 'CompositeKey' object has no attribute 'get_db_field'\n```\n\nI can get around it by making the tabB_id field increment so it'll be independent of the colB_data Boolean, and create a second id field that will be equal across the true/false sides of the boolean, but that just feels a little ugly in my third normalised heart.\n", "Are there any plans to address this issue? Your `CompositeForeignKey` solution would put this into a better state than it is today.\n", "Yeah...I'm not sure what to do really and have been wavering about doing anything really. Adding `CompositeForeignKey` just seemed like a big hack, to be honest. It doesn't really do anything except provide a handy way of accessing a related object, but you could just as easily implement this using a simple property.\n\nWhat are the benefits of adding this to peewee?\n", "@coleifer Being able to reference a foreign composite key is pretty useful, and peewee doesn't have much support for it. For example, suppose we're representing all employees in a company, which is composed of many subsidiaries. Each subsidiary has its own method of allocating employee IDs, therefore it's possible that two different employees from two different subsidiaries have the same employee ID, and thus the natural key for a table of employees of the parent company is a composite key of the subsidiary and the employee ID. So we have:\n\n``` python\nfrom peewee import *\n\ndb = SqliteDatabase('example.db')\n\nclass BaseModel(Model):\n class Meta:\n database = db\n\nclass Subsidiary(BaseModel):\n name = CharField()\n\nclass Employee(BaseModel):\n subsidiary = ForeignKeyField(Subsidiary)\n employee = IntegerField()\n\n class Meta:\n primary_key = CompositeKey('subsidiary', 'employee')\n\nclass CompanyHierarchy(BaseModel):\n manager = ForeignKeyField(Employee, related_name='subordinates')\n subordinate = ForeignKeyField(Employee, related_name='managers')\n\nif __name__ == '__main__':\n Employee.create_table()\n CompanyHierarchy.create_table()\n```\n\nCreating the tables this way can make doing bulk updates much easier (e.g., using MySQL we could use `INSERT ... ON DUPLICATE KEY UPDATE ...` with the `employee` table), but peewee throws an exception when given this code.\n\nWhile this bit of code may seem fairly contrived, a coworker ran into a very similar situation and we had to work around it in a non-optimal way by enforcing desired constraints in code instead of the database and losing the ability to use the aforementioned `INSERT ... ON DUPLICATE KEY UPDATE ...`.\n", "Gotcha, I guess the weird thing there is that `CompanyHierarchy`, to match `Employee`, should really have two columns: `subsidiary_id` and `employee_id` instead of a single \"composite foreign key\". Then a unique constraint defined in the `CompanyHierarchy.Meta`.\n", "I really just can't bring myself to add a `CompositeForeignKey` object, it feels too hacky.\n", "Do you have anything new to add to this issue? I just came across it myself. :)\n", "Same here, would be great to have it implemented", "@coleifer I'd think the non-hacky thing to do would be to make foreign keys composite in general. So, even if it winds up being a bit hacky having foreign key fields as a child of fields and a separate CompositeForeignKey, it would still be a step in the right direction.", "I have this issue too, it's still a problem. Is there any news?", "I still dislike having some kind of a ForeignKeyField that points to a CompositePrimaryKey. You can always add a foreign key constraint and a handy property in-place of some kind of \"CompositeForeignKeyField\"." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/270/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ricardogithub", "id": 3900829, "node_id": "MDQ6VXNlcjM5MDA4Mjk=", "avatar_url": "https://avatars.githubusercontent.com/u/3900829?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ricardogithub", "html_url": "https://github.com/ricardogithub", "followers_url": "https://api.github.com/users/ricardogithub/followers", "following_url": "https://api.github.com/users/ricardogithub/following{/other_user}", "gists_url": "https://api.github.com/users/ricardogithub/gists{/gist_id}", "starred_url": "https://api.github.com/users/ricardogithub/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ricardogithub/subscriptions", "organizations_url": "https://api.github.com/users/ricardogithub/orgs", "repos_url": "https://api.github.com/users/ricardogithub/repos", "events_url": "https://api.github.com/users/ricardogithub/events{/privacy}", "received_events_url": "https://api.github.com/users/ricardogithub/received_events", "type": "User", "site_admin": false }

[]

[]

[ "> A second thing is: it is usually a good thing not to silently make assumptions, like emitting an UnknownFieldType as mentioned above.\n\npwiz emits `UnknownFieldType` because it is unknown...exactly because we don't want to be making assumptions. See: http://www.sqlite.org/datatype3.html .\n\nI don't see any problem with adding `long` -> `BigIntegerField`. I'm not sure about some others. Maybe it makes sense to put a comment after the `UnknownFieldType` indicating the column type in the table definition.\n", "In my particular case the three additions to the mapping array seem to work, but I have not tested it extensively. \n\nGood suggestion about the column type hint. \n\nBTW In general I agree with you about the assumptions, but..._places.sqlite_ happened to be the first database I tried to introspect. I can't believe I was the first one till now to pick places.sqlite :-> \n\nLuckily I stayed on board, but maybe others did not, and moved on to another ORM solution. And that is really too bad, because peewee deserves better than a first crappy experience with pwiz due to some non-standard, but very common database :-) Keep up the good work. \n", "I'm sorry you were disappointed with the generated code.\n", "I've added some logic to display the raw underlying data type. With sqlite you can enter in any garbage you want...this is perfectly valid:\n\n``` sql\ncreate table walrus (tusk ivory, whisker blubber);\n```\n\npwiz will now return:\n\n``` python\nclass Walrus(BaseModel):\n tusk = UnknownFieldType(null=True) # ivory\n whisker = UnknownFieldType(null=True) # blubber\n\n class Meta:\n db_table = 'walrus'\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/269/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jhorman", "id": 323697, "node_id": "MDQ6VXNlcjMyMzY5Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/323697?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jhorman", "html_url": "https://github.com/jhorman", "followers_url": "https://api.github.com/users/jhorman/followers", "following_url": "https://api.github.com/users/jhorman/following{/other_user}", "gists_url": "https://api.github.com/users/jhorman/gists{/gist_id}", "starred_url": "https://api.github.com/users/jhorman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jhorman/subscriptions", "organizations_url": "https://api.github.com/users/jhorman/orgs", "repos_url": "https://api.github.com/users/jhorman/repos", "events_url": "https://api.github.com/users/jhorman/events{/privacy}", "received_events_url": "https://api.github.com/users/jhorman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Interesting PR. I'm actually looking at refactoring the transaction code to use a stack for #265 , though I did not plan on implementing nested txns using savepoints.\n\nI'm not sure I like overloading `begin` to now mean \"create a savepoint\". Same for `rollback`. These should always mean either begin a transaction or roll it back.\n", "Ok, now I only will create a savepoint in `begin()` for the nested transactions.\n\nIn Postgres there is no notion of nested transactions via `BEGIN`. A 2nd call to `BEGIN` will just be ignored. Their recommendation is to create a save point if the intention is to support nesting. That is what the 2nd commit now does. Only nested rollback/commit now release/rollback the savepoints.\n\nThis change now supports #265 I believe, on Postgres at least. I think that MySQL would be the same basically, at least with InnoDB.\n\nI like this approach vs having to force the user to think about savepoints, and how nesting is supported across `Database` implementations. This just says that peewee will support nesting, and the details are up to the `Database` implementation.\n", "> I like this approach vs having to force the user to think about savepoints.\n\nThat's a valid point.\n", "It looks like MySQL and Sqlite support savepoints as well. Have you looking into how this PR works with those databases?\n", "Rather than expose savepoints as nested transactions, I've created a new method / context manager.\n\n``` python\n\nwith db.savepoint():\n do stuff\n```\n", "I like adding explicit savepoint support, but are you saying you don't want to support nested transactions in postgres like this?\n", "Well, I added support for nesting calls to `transaction`, but the transactions are not nested per-se. I will add support for savepoints as a separate API using an approach similar to the transaction context mgr.\n", "Added savepoint support:\n\n``` python\nwith db.transaction():\n # etc\n with db.savepoint():\n # etc\n with db.savepoint():\n # etc\n```\n", "Cool, I'll check it out.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/268/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/268", "html_url": "https://github.com/coleifer/peewee/pull/268", "diff_url": "https://github.com/coleifer/peewee/pull/268.diff", "patch_url": "https://github.com/coleifer/peewee/pull/268.patch", "merged_at": null }

{ "login": "shai126", "id": 5904710, "node_id": "MDQ6VXNlcjU5MDQ3MTA=", "avatar_url": "https://avatars.githubusercontent.com/u/5904710?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shai126", "html_url": "https://github.com/shai126", "followers_url": "https://api.github.com/users/shai126/followers", "following_url": "https://api.github.com/users/shai126/following{/other_user}", "gists_url": "https://api.github.com/users/shai126/gists{/gist_id}", "starred_url": "https://api.github.com/users/shai126/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shai126/subscriptions", "organizations_url": "https://api.github.com/users/shai126/orgs", "repos_url": "https://api.github.com/users/shai126/repos", "events_url": "https://api.github.com/users/shai126/events{/privacy}", "received_events_url": "https://api.github.com/users/shai126/received_events", "type": "User", "site_admin": false }

[]

[]

[ "If you're referencing the same table multiple times in the query you need to call `Model.alias()`.\n\n``` python\nclass Game(Model):\n some_fields\n\nG2 = Game.alias()\nGame.select(\n Game, \n G2.select(fn.Sum(G2.something)).where(G2.some_field == Game.another_field).alias('xxx'))\n```\n\nI haven't tried the above, so not 100% sure.\n", "I'm pretty sure this is one of the things I tried which didn't work, but\nI'm on the road just now so will take another look tomorrow and let you\nknow for sure - either that it does in fact work or exactly how it fails.\nCheers\nOn 4 Dec 2013 23:43, \"Charles Leifer\" [email protected] wrote:\n\n> If you're referencing the same table multiple times in the query you need\n> to call Model.alias().\n> \n> class Game(Model):\n> some_fields\n> G2 = Game.alias()Game.select(\n> Game,\n> G2.select(fn.Sum(G2.something)).where(G2.some_field == Game.another_field).alias('xxx'))\n> \n> I haven't tried the above, so not 100% sure.\n> \n> —\n> Reply to this email directly or view it on GitHubhttps://github.com/coleifer/peewee/issues/267#issuecomment-29858012\n> .\n", "One quirk of the implementation is that calling `G2.select()` doesn't work as you'd expect. With a bit of experimentation, I came up with this (and added a unit test to document it):\n\n``` python\n UA = User.alias()\n inner = SelectQuery(UA, fn.Sum(UA.id)).where(UA.id == User.id)\n query = User.select(User, inner.alias('xxx'))\n sql, params = query.sql()\n self.assertEqual(\n sql,\n 'SELECT t1.\"id\", t1.\"username\", (SELECT Sum(t2.\"id\") FROM \"users\" AS t2 WHERE (t2.\"id\" = t1.\"id\")) AS xxx FROM \"users\" AS t1')\n```\n\nMy previous example should be correct except that instead of `G2.select(...)` you should call `SelectQuery(G2, ...)`.\n", "All should be fixed in c530906878b45d7d2eede616a3cc10238a9118a1\n\nMakes it possible to write:\n\n``` python\nUA = User.alias()\ninner = UA.select(fn.Sum(UA.id)).where(UA.id == User.id)\nquery = User.select(User, inner.alias('xxx'))\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/267/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "vincentdavis", "id": 232564, "node_id": "MDQ6VXNlcjIzMjU2NA==", "avatar_url": "https://avatars.githubusercontent.com/u/232564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vincentdavis", "html_url": "https://github.com/vincentdavis", "followers_url": "https://api.github.com/users/vincentdavis/followers", "following_url": "https://api.github.com/users/vincentdavis/following{/other_user}", "gists_url": "https://api.github.com/users/vincentdavis/gists{/gist_id}", "starred_url": "https://api.github.com/users/vincentdavis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vincentdavis/subscriptions", "organizations_url": "https://api.github.com/users/vincentdavis/orgs", "repos_url": "https://api.github.com/users/vincentdavis/repos", "events_url": "https://api.github.com/users/vincentdavis/events{/privacy}", "received_events_url": "https://api.github.com/users/vincentdavis/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Can you share the table definition from whatever database engine you're using? i.e. the `CREATE TABLE` query.\n", "CREATE TABLE `jeffco_2009` (\n `_id` int(11) NOT NULL AUTO_INCREMENT,\n `lat` float NOT NULL,\n `lon` float NOT NULL,\n `altatd` varchar(100) DEFAULT NULL,\n `anxyr` varchar(100) DEFAULT NULL,\n `asmasdimp` varchar(100) DEFAULT NULL,\n `asmasdlnd` varchar(100) DEFAULT NULL,\n `asmasdprs` varchar(100) DEFAULT NULL,\n `asmasdtot` varchar(100) DEFAULT NULL,\n `asmbseimp` varchar(100) DEFAULT NULL,\n `asmbselnd` varchar(100) DEFAULT NULL,\n `asmbseprs` varchar(100) DEFAULT NULL,\n `asmbsetot` varchar(100) DEFAULT NULL,\n `asmdt` varchar(100) DEFAULT NULL,\n `atd` varchar(100) DEFAULT NULL,\n `bpctycd` varchar(100) DEFAULT NULL,\n `chgdt002` varchar(100) DEFAULT NULL,\n `cmnadrnbr` varchar(100) DEFAULT NULL,\n `comara` varchar(100) DEFAULT NULL,\n `dba` varchar(100) DEFAULT NULL,\n `dedtyp` varchar(100) DEFAULT NULL,\n `dedtyp2` varchar(100) DEFAULT NULL,\n `dedtyp3` varchar(100) DEFAULT NULL,\n `dedtyp4` varchar(100) DEFAULT NULL,\n `demyr` varchar(100) DEFAULT NULL,\n `excyr` varchar(100) DEFAULT NULL,\n `fi` varchar(100) DEFAULT NULL,\n `genbil` varchar(100) DEFAULT NULL,\n `genbil1` varchar(100) DEFAULT NULL,\n `genbil2` varchar(100) DEFAULT NULL,\n `genbil3` varchar(100) DEFAULT NULL,\n `genpd` varchar(100) DEFAULT NULL,\n `impara` varchar(100) DEFAULT NULL,\n `incyr` varchar(100) DEFAULT NULL,\n `lglblk` varchar(100) DEFAULT NULL,\n `lglblk2` varchar(100) DEFAULT NULL,\n `lglblk3` varchar(100) DEFAULT NULL,\n `lglblk4` varchar(100) DEFAULT NULL,\n `lglkey` varchar(100) DEFAULT NULL,\n `lglkey2` varchar(100) DEFAULT NULL,\n `lglkey3` varchar(100) DEFAULT NULL,\n `lglkey4` varchar(100) DEFAULT NULL,\n `lgllot` varchar(100) DEFAULT NULL,\n `lgllot2` varchar(100) DEFAULT NULL,\n `lgllot3` varchar(100) DEFAULT NULL,\n `lgllot4` varchar(100) DEFAULT NULL,\n `lglqtr` varchar(100) DEFAULT NULL,\n `lglqtr2` varchar(100) DEFAULT NULL,\n `lglqtr3` varchar(100) DEFAULT NULL,\n `lglqtr4` varchar(100) DEFAULT NULL,\n `lglrcp` varchar(100) DEFAULT NULL,\n `lglrcp2` varchar(100) DEFAULT NULL,\n `lglrcp3` varchar(100) DEFAULT NULL,\n `lglrcp4` varchar(100) DEFAULT NULL,\n `lglrng` varchar(100) DEFAULT NULL,\n `lglrng2` varchar(100) DEFAULT NULL,\n `lglrng3` varchar(100) DEFAULT NULL,\n `lglrng4` varchar(100) DEFAULT NULL,\n `lglsec` varchar(100) DEFAULT NULL,\n `lglsec2` varchar(100) DEFAULT NULL,\n `lglsec3` varchar(100) DEFAULT NULL,\n `lglsec4` varchar(100) DEFAULT NULL,\n `lglsqft` varchar(100) DEFAULT NULL,\n `lglsqft2` varchar(100) DEFAULT NULL,\n `lglsqft3` varchar(100) DEFAULT NULL,\n `lglsqft4` varchar(100) DEFAULT NULL,\n `lglsubcd` varchar(100) DEFAULT NULL,\n `lglsubcd2` varchar(100) DEFAULT NULL,\n `lglsubcd3` varchar(100) DEFAULT NULL,\n `lglsubcd4` varchar(100) DEFAULT NULL,\n `lgltwn` varchar(100) DEFAULT NULL,\n `lgltwn2` varchar(100) DEFAULT NULL,\n `lgltwn3` varchar(100) DEFAULT NULL,\n `lgltwn4` varchar(100) DEFAULT NULL,\n `lndara` varchar(100) DEFAULT NULL,\n `mailctynam` varchar(100) DEFAULT NULL,\n `mailstenam` varchar(100) DEFAULT NULL,\n `mailstrdir` varchar(100) DEFAULT NULL,\n `mailstrnam` varchar(100) DEFAULT NULL,\n `mailstrnbr` varchar(100) DEFAULT NULL,\n `mailstrsfx` varchar(100) DEFAULT NULL,\n `mailstrtyp` varchar(100) DEFAULT NULL,\n `mailstrunt` varchar(100) DEFAULT NULL,\n `mailzip4` varchar(100) DEFAULT NULL,\n `mailzip5` varchar(100) DEFAULT NULL,\n `morelgl` varchar(100) DEFAULT NULL,\n `moreown` varchar(100) DEFAULT NULL,\n `moresls` varchar(100) DEFAULT NULL,\n `morestt` varchar(100) DEFAULT NULL,\n `moreval` varchar(100) DEFAULT NULL,\n `nhdnam` varchar(100) DEFAULT NULL,\n `nhdnbr` varchar(100) DEFAULT NULL,\n `ownico` varchar(100) DEFAULT NULL,\n `ownnam` varchar(100) DEFAULT NULL,\n `ownnam2` varchar(100) DEFAULT NULL,\n `ownnam3` varchar(100) DEFAULT NULL,\n `parid` varchar(100) DEFAULT NULL,\n `paycd` varchar(100) DEFAULT NULL,\n `prpctynam` varchar(100) DEFAULT NULL,\n `prpstenam` varchar(100) DEFAULT NULL,\n `prpstrdir` varchar(100) DEFAULT NULL,\n `prpstrnam` varchar(100) DEFAULT NULL,\n `prpstrnum` varchar(100) DEFAULT NULL,\n `prpstrsfx` varchar(100) DEFAULT NULL,\n `prpstrtyp` varchar(100) DEFAULT NULL,\n `prpstrunt` varchar(100) DEFAULT NULL,\n `prpzip4` varchar(100) DEFAULT NULL,\n `prpzip5` varchar(100) DEFAULT NULL,\n `prsbuscd1` varchar(100) DEFAULT NULL,\n `prsbuscd2` varchar(100) DEFAULT NULL,\n `pyrtotval` varchar(100) DEFAULT NULL,\n `qual` varchar(100) DEFAULT NULL,\n `relsch` varchar(100) DEFAULT NULL,\n `sch` varchar(100) DEFAULT NULL,\n `sid` varchar(100) DEFAULT NULL,\n `sidasm` varchar(100) DEFAULT NULL,\n `siddst` varchar(100) DEFAULT NULL,\n `slsamt` varchar(100) DEFAULT NULL,\n `slsamt2` varchar(100) DEFAULT NULL,\n `slsamt3` varchar(100) DEFAULT NULL,\n `slsamt4` varchar(100) DEFAULT NULL,\n `slscd` varchar(100) DEFAULT NULL,\n `slscd2` varchar(100) DEFAULT NULL,\n `slscd3` varchar(100) DEFAULT NULL,\n `slscd4` varchar(100) DEFAULT NULL,\n `slsdt` varchar(100) DEFAULT NULL,\n `slsdt2` varchar(100) DEFAULT NULL,\n `slsdt3` varchar(100) DEFAULT NULL,\n `slsdt4` varchar(100) DEFAULT NULL,\n `sts` varchar(100) DEFAULT NULL,\n `sttbstare2` varchar(100) DEFAULT NULL,\n `sttbstare3` varchar(100) DEFAULT NULL,\n `sttbstare4` varchar(100) DEFAULT NULL,\n `sttbstarea` varchar(100) DEFAULT NULL,\n `sttbsttyp` varchar(100) DEFAULT NULL,\n `sttbsttyp2` varchar(100) DEFAULT NULL,\n `sttbsttyp3` varchar(100) DEFAULT NULL,\n `sttbsttyp4` varchar(100) DEFAULT NULL,\n `sttgartyp` varchar(100) DEFAULT NULL,\n `sttgartyp2` varchar(100) DEFAULT NULL,\n `sttgartyp3` varchar(100) DEFAULT NULL,\n `sttgartyp4` varchar(100) DEFAULT NULL,\n `sttgrsare2` varchar(100) DEFAULT NULL,\n `sttgrsare3` varchar(100) DEFAULT NULL,\n `sttgrsare4` varchar(100) DEFAULT NULL,\n `sttgrsarea` varchar(100) DEFAULT NULL,\n `sttnbrbld2` varchar(100) DEFAULT NULL,\n `sttnbrbld3` varchar(100) DEFAULT NULL,\n `sttnbrbld4` varchar(100) DEFAULT NULL,\n `sttnbrbldg` varchar(100) DEFAULT NULL,\n `sttnbrflr` varchar(100) DEFAULT NULL,\n `sttnbrflr2` varchar(100) DEFAULT NULL,\n `sttnbrflr3` varchar(100) DEFAULT NULL,\n `sttnbrflr4` varchar(100) DEFAULT NULL,\n `sttnbrunt` varchar(100) DEFAULT NULL,\n `sttnbrunt2` varchar(100) DEFAULT NULL,\n `sttnbrunt3` varchar(100) DEFAULT NULL,\n `sttnbrunt4` varchar(100) DEFAULT NULL,\n `sttstrc` varchar(100) DEFAULT NULL,\n `sttstrc2` varchar(100) DEFAULT NULL,\n `sttstrc3` varchar(100) DEFAULT NULL,\n `sttstrc4` varchar(100) DEFAULT NULL,\n `stttypcns` varchar(100) DEFAULT NULL,\n `stttypcns2` varchar(100) DEFAULT NULL,\n `stttypcns3` varchar(100) DEFAULT NULL,\n `stttypcns4` varchar(100) DEFAULT NULL,\n `stttypuse` varchar(100) DEFAULT NULL,\n `stttypuse2` varchar(100) DEFAULT NULL,\n `stttypuse3` varchar(100) DEFAULT NULL,\n `stttypuse4` varchar(100) DEFAULT NULL,\n `sttyrblt` varchar(100) DEFAULT NULL,\n `sttyrblt2` varchar(100) DEFAULT NULL,\n `sttyrblt3` varchar(100) DEFAULT NULL,\n `sttyrblt4` varchar(100) DEFAULT NULL,\n `subnam` varchar(100) DEFAULT NULL,\n `taxcls` varchar(100) DEFAULT NULL,\n `taxcls2` varchar(100) DEFAULT NULL,\n `taxcls3` varchar(100) DEFAULT NULL,\n `taxcls4` varchar(100) DEFAULT NULL,\n `taxcls5` varchar(100) DEFAULT NULL,\n `taxcls6` varchar(100) DEFAULT NULL,\n `totacr` varchar(100) DEFAULT NULL,\n `totactimpv` varchar(100) DEFAULT NULL,\n `totactlndv` varchar(100) DEFAULT NULL,\n `totactval` varchar(100) DEFAULT NULL,\n `totbsea` varchar(100) DEFAULT NULL,\n `totbseimpa` varchar(100) DEFAULT NULL,\n `totbselnda` varchar(100) DEFAULT NULL,\n `ttd` varchar(100) DEFAULT NULL,\n `usrflda` varchar(100) DEFAULT NULL,\n `usrfldb` varchar(100) DEFAULT NULL,\n `usrfldc` varchar(100) DEFAULT NULL,\n `usrfldd` varchar(100) DEFAULT NULL,\n `valacr` varchar(100) DEFAULT NULL,\n `valacr2` varchar(100) DEFAULT NULL,\n `valacr3` varchar(100) DEFAULT NULL,\n `valacr4` varchar(100) DEFAULT NULL,\n `valacr5` varchar(100) DEFAULT NULL,\n `valacr6` varchar(100) DEFAULT NULL,\n `valact` varchar(100) DEFAULT NULL,\n `valact2` varchar(100) DEFAULT NULL,\n `valact3` varchar(100) DEFAULT NULL,\n `valact4` varchar(100) DEFAULT NULL,\n `valact5` varchar(100) DEFAULT NULL,\n `valact6` varchar(100) DEFAULT NULL,\n `valactchg` varchar(100) DEFAULT NULL,\n `valactchg2` varchar(100) DEFAULT NULL,\n `valactchg3` varchar(100) DEFAULT NULL,\n `valactchg4` varchar(100) DEFAULT NULL,\n `valactchg5` varchar(100) DEFAULT NULL,\n `valactchg6` varchar(100) DEFAULT NULL,\n `valcomchg` varchar(100) DEFAULT NULL,\n `valflag` varchar(100) DEFAULT NULL,\n `valflag2` varchar(100) DEFAULT NULL,\n `valflag3` varchar(100) DEFAULT NULL,\n `valflag4` varchar(100) DEFAULT NULL,\n `valflag5` varchar(100) DEFAULT NULL,\n `valflag6` varchar(100) DEFAULT NULL,\n PRIMARY KEY (`_id`)\n) ENGINE=InnoDB DEFAULT CHARSET=utf8 AUTO_INCREMENT=234318 ;\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/266/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ricoboni", "id": 1664502, "node_id": "MDQ6VXNlcjE2NjQ1MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/1664502?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ricoboni", "html_url": "https://github.com/ricoboni", "followers_url": "https://api.github.com/users/ricoboni/followers", "following_url": "https://api.github.com/users/ricoboni/following{/other_user}", "gists_url": "https://api.github.com/users/ricoboni/gists{/gist_id}", "starred_url": "https://api.github.com/users/ricoboni/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ricoboni/subscriptions", "organizations_url": "https://api.github.com/users/ricoboni/orgs", "repos_url": "https://api.github.com/users/ricoboni/repos", "events_url": "https://api.github.com/users/ricoboni/events{/privacy}", "received_events_url": "https://api.github.com/users/ricoboni/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Great catch, I'm actually surprised this hasn't come up before!\n", "This has been fixed. See testcase: 54b655c8469fd0f22608ac55f681d99ffab72316\n", "Reopening.\n", "I didn't like my implementation and have re-written it. New code is in 727299c323f97fb3a5c82c2ca88b1a0adb9ad06f and tests in 318ff7b3ca9689a537999cb923845d6d54014514\n", "Seems very nice. Thank you!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/265/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "vincentdavis", "id": 232564, "node_id": "MDQ6VXNlcjIzMjU2NA==", "avatar_url": "https://avatars.githubusercontent.com/u/232564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vincentdavis", "html_url": "https://github.com/vincentdavis", "followers_url": "https://api.github.com/users/vincentdavis/followers", "following_url": "https://api.github.com/users/vincentdavis/following{/other_user}", "gists_url": "https://api.github.com/users/vincentdavis/gists{/gist_id}", "starred_url": "https://api.github.com/users/vincentdavis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vincentdavis/subscriptions", "organizations_url": "https://api.github.com/users/vincentdavis/orgs", "repos_url": "https://api.github.com/users/vincentdavis/repos", "events_url": "https://api.github.com/users/vincentdavis/events{/privacy}", "received_events_url": "https://api.github.com/users/vincentdavis/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/264/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "sametmax", "id": 1673950, "node_id": "MDQ6VXNlcjE2NzM5NTA=", "avatar_url": "https://avatars.githubusercontent.com/u/1673950?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sametmax", "html_url": "https://github.com/sametmax", "followers_url": "https://api.github.com/users/sametmax/followers", "following_url": "https://api.github.com/users/sametmax/following{/other_user}", "gists_url": "https://api.github.com/users/sametmax/gists{/gist_id}", "starred_url": "https://api.github.com/users/sametmax/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sametmax/subscriptions", "organizations_url": "https://api.github.com/users/sametmax/orgs", "repos_url": "https://api.github.com/users/sametmax/repos", "events_url": "https://api.github.com/users/sametmax/events{/privacy}", "received_events_url": "https://api.github.com/users/sametmax/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This is an interesting request, but it's so big I'm not sure how to address it. Since I intend to keep compatibility with 2.6 for quite some time, I think it's not really possible. Also, my experience with \"async\" in python has been limited to gevent and I don't feel very comfortable with the new APIs (`yield from`, `Task`, `coroutine`, etc).\n\nDo you have any more thoughts or information to add?\n", "I don't, and I'm not expecting peewee to change any time soon. I am \nvery aware that these things are hard and take time, therefor I'm \nopening this ticket now so the communuty can start the process slowly \nbut early.\n\nI am myself not yet comfortable with asyncio but since I'm forced to \nstart thinking about it in my own work, if I got any idea popping, I'll \ncome back here with a proposal.\n\nLe ven. 29 nov. 2013 05:42:40 CET, Charles Leifer a écrit :\n\n> This is an interesting request, but it's so big I'm not sure how to\n> address it. Since I intend to keep compatibility with 2.6 for quite\n> some time, I think it's not really possible. My experience with\n> \"async\" in python has been limited to gevent and I also don't feel\n> very comfortable with the new APIs (|yield from|, |Task|, |coroutine|,\n> etc).\n> \n> Do you have any more thoughts or information to add?\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/coleifer/peewee/issues/263#issuecomment-29496462.\n", "Thanks for the message @sametmax. Based on my understanding of the new asyncio library, I'm going to go out on a limb here and say that I don't think peewee will be adding support.\n- A new \"asyncio-aware\" driver would need to be written for each database.\n- All code that connects to the db and makes queries in peewee would need to be rewritten, i.e. `yield from db.connect(...)`, `yield from db.execute()` and `yield from cursor.fetchXXX()`.\n- Any application using peewee would need to be rewritten where it makes queries: `yield from Model.select().where(...)`\n\nHave a look at the [examples](https://code.google.com/p/tulip/source/browse/examples/fetch1.py) to see how the structure of the application changes when you start using the `yield from` syntax. Using callbacks is no better, IMO.\n", "I understand. Best solution would be to have the common code, such as \nthe query builder, in one module (well, wrapper, since peewee is a one \nfile lib), the sync API code in another module, and the async API code \nin a third module.\n\nAnd allow something like :\n\nfrom peewee import blabla # sync\nfrom peewee.async import blabla # async\n\nOr make peewee decoupled enough so that it's possible to build an async \nlib on top of it wall async_peewee.\n\nBut I get it, it's a lot of work, and when you already have coded the \nORM, how to have the time to do this ? I'm not even offering to do it \nbecause I'm well aware it's so huge.\n\nAnyway, thanks for answering.\n\nLe ven. 29 nov. 2013 17:20:19 CET, Charles Leifer a écrit :\n\n> Thanks for the message @sametmax https://github.com/sametmax. Based\n> on my understanding of the new asyncio library, I'm going to go out on\n> a limb here and say that I don't think peewee will be adding support.\n> - A new \"asyncio-aware\" driver would need to be written for each\n> database.\n> - All code that connects to the db and makes queries in peewee would\n> need to be rewritten, i.e. |yield from db.connect(...)|, |yield\n> from db.execute()| and |yield from cursor.fetchXXX()|.\n> - Any application using peewee would need to be rewritten where it\n> makes queries: |yield from Model.select().where(...)|\n> \n> Have a look at the examples\n> https://code.google.com/p/tulip/source/browse/examples/fetch1.py to\n> see how the structure of the application changes when you start using\n> the |yield from| syntax. Using callbacks is no better, IMO.\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/coleifer/peewee/issues/263#issuecomment-29525538.\n", "Just to add to this discussion, I've had positive experiences with the way Guido's NDB handles async operations.\n\nIf in the future you are ever in need of any ideas, here are the docs:\nhttps://developers.google.com/appengine/docs/python/ndb/async\n", "We can use [Trollius](http://trollius.readthedocs.org/) for Py2/3 when needed. Much like asyncio, but it has friendly grammer for Py2(`yield From(do_something())`, `raise Return(value)`).\n", "Thanks a bunch for the links - I will read up on them.\n", "I've just tried a flask+peewee app with uwsgi+gevent+psycogreen.gevent.patch_psycopg -- in theory, this should patch psycopg so that calling code (such as peewee) can use it as if it were still blocking, see https://bitbucket.org/dvarrazzo/psycogreen\n\nWhen I try this, peewee gives me:\n\n```\npeewee.ProgrammingError: execute cannot be used while an asynchronous query is underway\n```\n\nAm I expecting too much?\n", "Strange...I've used psycopg2 with gevent and not had any issues. The code I used was similar to the monkeypatch you linked up @cpbotha . One thing you might check is that the gevent monkeypatch needs to be the first thing that happens.\n\nSo the entry-point to your application would look like this:\n\n``` python\nfrom gevent import monkey\nmonkey.patch_all()\nfrom psycopg2_green_monkeypatch import whatever\nwhatever()\n\n# here begins your actual code...\n```\n", "Thanks for helping me with this!\n\nI already have in my wsgi.py (entry point for uwsgi):\n\n```\nimport gevent\nimport gevent.monkey\ngevent.monkey.patch_all()\n\nimport psycogreen.gevent\npsycogreen.gevent.patch_psycopg()\n\nimport main;main.init();from cnids.app import fapp\n```\n\nWith \"normal\" DB access (RESTful via browser), I see no issues. However, I do see the ProgrammingError exception when I do `ab -c 3 -n 10 URL` (3 concurrent requesters)\n\nAnything else I could look at? (this is with peewee 2.2.3)\n", "Strange... I'm not sure what might be happening.\n", "Seems it has happened before: https://bitbucket.org/dvarrazzo/psycogreen-hg/issue/1/databaseerror-execute-used-with\n\nThe explanation offered is issue would occur when two queries are done using two different cursors on the same database connection. Does that make sense?\n\nThe reporter of that bug then wrote a blog post with a solution http://www.manasupo.com/2012/03/geventpsycopg2-execute-cannot-be-used.html where the simply do the psycopg2 monkey-patching before the fork.\n\nI don't understand why that fixed the problem in their case. In my case, the monkey patching is done before forking, if I may judge by the uwsgi log file (my \"MONKEY PATCHING YEAH!\" output appears once, before the the three worker processes report for duty):\n\n```\nmapped 4368256 bytes (4265 KB) for 300 cores\n*** Operational MODE: preforking+async ***\nMONKEY PATCHING YEAH!\nDatabase migration not required.\nWSGI app 0 (mountpoint='') ready in 0 seconds on interpreter 0x10035d0 pid: 30745 (default app)\n*** uWSGI is running in multiple interpreter mode ***\nspawned uWSGI master process (pid: 30745)\nspawned uWSGI worker 1 (pid: 30751, cores: 100)\nspawned uWSGI worker 2 (pid: 30752, cores: 100)\nspawned uWSGI worker 3 (pid: 30753, cores: 100)\n*** running gevent loop engine [addr:0x485620] ***\n```\n\nI'm putting this here as a log for future travellers. Any tips would be welcome of course!\n", "In Momoko (Tornado wrapping of psycopg2), they had to build in more explicit handling of busy database connections to work around this issue: https://github.com/Tsumanga-Studios/momoko/commit/e4752c9cbb13e185ae996ce945faa646bd46508c\n\nThis was supposed to be a short experiment to benchmark multi-process uwsgi+flask-peewee against multi-process+asnyc+flask-peewee. I think I should let it go, as they say. :)\n\nThanks in any case!\n", "> The explanation offered is issue would occur when two queries are done using two different cursors on the same database connection. Does that make sense?\n\nAre you using `threadlocals=True` with your database connection? e.g.\n\n``` python\ndb = PostgresqlDatabase('foo', threadlocals=True)\n```\n", "If I could fly over there and buy you a beer I would!!\n\nYou even documented it: https://github.com/coleifer/flask-peewee/blob/master/docs/gevent.rst\n\nI don't understand why my searching didn't take me there, but I'm happy that you've solved it! (in my app.py, I added a 'threalocals' key to the DATABASE configuration dictionary.\n\nWhat impact does that setting have in a non-greened environment?\n\nThanks again,\nCharl\n", "In a non-greened environment if you were using a multi-threaded WSGI server, then your connections would be opened per-thread.\n", "I think we just need a separate package, let's say 'aiopeewee', providing asyncio interface. We're using peewee with Tornado+asyncio, so I think we'll start porting it shortly. Meanwhile we use 'run_in_executor' for performing slow requests asynchronously.\n", "And I'm not sure yet do we actually need porting or just a couple of wrappers and asyncio powered database backend classes.\n", "You will need more than that actually because the nature of the API\nitself is synchronous.\n\nE.G : when you access an attribute in peewee, it can fire an new query:\nproduct.shop.name will make a query to get the shop by default.\n\nYou'll probably need to return a promise for very thing that should\nreturn a an object or queryset.\n\nNow if you do that in a template :\n\n{{ product.shop.name }}\n\nThings get funny, because most template don't have a way to handle\npromises (no callback, no yield, etc).\n\nPlus, there are not just promises, but also deferred and futures,\ndepending of the framework. So you'll need a different backup for the\nasync event loop AND for the result wrapper.\n\nIt's a lot of work, it's hard. But if you do it, peewee will be actually\nthe ONLY Python ORM dealing with these issues properly. And hence, I\ngarantie i will be used much, much more. Technically, you'll be front\npage in python subreddit and hackernews the day of the release.\nEverybody is waiting for something like this, because right now,\neverybody uses hacks (defer to threads, mongodb motor, gevent monkey\npatching...) and big solutions like Django ORM or SQLAlchemy stated\nofficially they didn't want to do it in the current context.\n\nUnfortunatly, I don't know any way to do async with most DB without\nusing a compiled drivers for it. sqlite3 stdlib driver is syncronous if\nI recall, so you won't have the \"wow out of the box experience you\nshould have.\n\nI would make it something la peewee.async, instead of a separate lib. It\nwould make adoption much easier. But maybe that's just me.\n\nLe 26/09/2014 11:18, Alexey a écrit :\n\n> And I'm not sure yet do we actually need porting or just a couple of\n> wrappers and asyncio powered database backend classes.\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/coleifer/peewee/issues/263#issuecomment-56938305.\n", "Hi everyone :) I've just published a kind of working proto: https://github.com/05bit/peewee-async\n\nI think basic async support may also be useful, we can deal with related objects by sending explicit prefetch queries. And yes, async queries are difficult to support in templates (without rewriting template engine), so I think it's more suitable for API services where we generally just need to serialise to JSON.\n", "Just published alpha v0.0.2 on PyPi and here's the docs: https://python-aiopeewee.readthedocs.org Interface seems working and simple one and I think it's now rather close to stable version. But internals don't really shine, I've started issue to discuss better integration with peewee: https://github.com/05bit/python-aiopeewee/issues/1\n", "Has anything happened since then?", "Use gevent" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/263/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "twodayslate", "id": 1085707, "node_id": "MDQ6VXNlcjEwODU3MDc=", "avatar_url": "https://avatars.githubusercontent.com/u/1085707?v=4", "gravatar_id": "", "url": "https://api.github.com/users/twodayslate", "html_url": "https://github.com/twodayslate", "followers_url": "https://api.github.com/users/twodayslate/followers", "following_url": "https://api.github.com/users/twodayslate/following{/other_user}", "gists_url": "https://api.github.com/users/twodayslate/gists{/gist_id}", "starred_url": "https://api.github.com/users/twodayslate/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/twodayslate/subscriptions", "organizations_url": "https://api.github.com/users/twodayslate/orgs", "repos_url": "https://api.github.com/users/twodayslate/repos", "events_url": "https://api.github.com/users/twodayslate/events{/privacy}", "received_events_url": "https://api.github.com/users/twodayslate/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Depends on how you're saving that value. If you're calling `Model.save()` then just override the `save` method and add the check there. If you're calling `Model.insert()` you may have to implement it as a check constraint in your db.\n", "Does the option argument not do it?\n", "> Does the option argument not do it?\n\nCould you be more specific which option? Also, how did you plan on inserting these values -- using `Modelsave()` or `Model.insert()`?\n", "I use `Model.create()`\n\nI misspoke. I meant `choices` not `option`. Under the Fields argument list in the API there is a `choices` option. Other libraries I have used have used this as a range feature. `choices=range(1,5)`\n\nI'm in IRC now but I feel like this could help other people as well.\n", "Cool, well since you're using `create()` you can override save:\n\n``` python\nclass MyModel(Model):\n some_val = FloatField()\n\n def save(self, *args, **kwargs):\n if self.some_val < 1 or self.some_val > 5:\n raise ValueError('\"some_val\" must be between 1.0 and 5.0')\n return super(MyModel, self).save(*args, **kwargs)\n```\n\nThe `choices` argument exists solely as metadata and is not validated (either in python or in the database). So even if you used an integral range (which itself doesn't exactly mean \"any floating point between 1.0 and 5.0\") peewee will not complain.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/262/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[ { "id": 191751, "node_id": "MDU6TGFiZWwxOTE3NTE=", "url": "https://api.github.com/repos/coleifer/peewee/labels/Feature", "name": "Feature", "color": "02e10c", "default": false, "description": null } ]

[]

[ "I can finally close this!\n", "What do you mean?\n", "Sorry, blaming incorrectly. It worked fine. \n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/261/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ricardogithub", "id": 3900829, "node_id": "MDQ6VXNlcjM5MDA4Mjk=", "avatar_url": "https://avatars.githubusercontent.com/u/3900829?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ricardogithub", "html_url": "https://github.com/ricardogithub", "followers_url": "https://api.github.com/users/ricardogithub/followers", "following_url": "https://api.github.com/users/ricardogithub/following{/other_user}", "gists_url": "https://api.github.com/users/ricardogithub/gists{/gist_id}", "starred_url": "https://api.github.com/users/ricardogithub/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ricardogithub/subscriptions", "organizations_url": "https://api.github.com/users/ricardogithub/orgs", "repos_url": "https://api.github.com/users/ricardogithub/repos", "events_url": "https://api.github.com/users/ricardogithub/events{/privacy}", "received_events_url": "https://api.github.com/users/ricardogithub/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Won't the database raise an exception in the event you execute a bad query?\n", "I did not mean handling exceptions triggered by the RDBMS, that is working OK, seems. I meant strictness in the parsing and processing of model definitions, e.g. the following attribute definition: \n\n```\n field = CharField(unigue=True) # misspelled keyword unique\n```\n\nAt run-time I did not get a warning or exception from peewee, and peewee will 'just' generate code for the RDBMS. The created table is not as intended, since the unique index is missing. The program seems to work allright, at first glance, but duplicate records may (and in my case will) occur in the table. \n\nI like Peewee. Great job so far. It may be lightweight, but it should do a proper job :-)\n\nTo summarize: more strict parsing of the model is really useful and needed. \n", "The `kwargs` parameter of a field object's `__init__()` method is being used to populate arbitrary field attributes, so I'm not sure how to add protection against misspellings.\n", "To clarify, since _anything_ could be a valid keyword argument, I'm not sure how to fix this.\n", "A bit challenged by coleifer last remark, I decided to have a look at the peewee code myself. I was struck by the small size of the program, really. It looks good, and as such is a good display of the power of the Python language. \n\nI don't agree that anything could be a valid keyword. Just put all in a dict, and use that dict to check the passed keyword/value pairs. Just by adding a few lines of code to add to the **init** method of the Field class, just before the invocation of the super-method, enables me to signal my misspellings - at least:\n\n```\n for key in kwargs:\n if key not in ['null', 'index', 'unique' .... 'sequence']:\n print \"Error with passed key: \" + key\n```\n\nI left out a few keywords here in this pseudo-code fragment. Anyway, it should be referencing a constant list declared somewhere in top of the program. I think there are some more places in the code that could benefit of this little construct.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/260/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ricardogithub", "id": 3900829, "node_id": "MDQ6VXNlcjM5MDA4Mjk=", "avatar_url": "https://avatars.githubusercontent.com/u/3900829?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ricardogithub", "html_url": "https://github.com/ricardogithub", "followers_url": "https://api.github.com/users/ricardogithub/followers", "following_url": "https://api.github.com/users/ricardogithub/following{/other_user}", "gists_url": "https://api.github.com/users/ricardogithub/gists{/gist_id}", "starred_url": "https://api.github.com/users/ricardogithub/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ricardogithub/subscriptions", "organizations_url": "https://api.github.com/users/ricardogithub/orgs", "repos_url": "https://api.github.com/users/ricardogithub/repos", "events_url": "https://api.github.com/users/ricardogithub/events{/privacy}", "received_events_url": "https://api.github.com/users/ricardogithub/received_events", "type": "User", "site_admin": false }

[]

[]

[ "MySQL is very strange!\n", "I think this should probably be rolled into a larger issue to refactor the DDL generation code.\n", "Closing in favor of 261.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/259/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "gciding", "id": 769267, "node_id": "MDQ6VXNlcjc2OTI2Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/769267?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gciding", "html_url": "https://github.com/gciding", "followers_url": "https://api.github.com/users/gciding/followers", "following_url": "https://api.github.com/users/gciding/following{/other_user}", "gists_url": "https://api.github.com/users/gciding/gists{/gist_id}", "starred_url": "https://api.github.com/users/gciding/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gciding/subscriptions", "organizations_url": "https://api.github.com/users/gciding/orgs", "repos_url": "https://api.github.com/users/gciding/repos", "events_url": "https://api.github.com/users/gciding/events{/privacy}", "received_events_url": "https://api.github.com/users/gciding/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Yes, I agree.\n", "I've added standard exceptions and wrapped the connect / close / execute methods to ensure they raise the \"peewee\" version where possible:\n\n2d6f43358ebdacb12a6d7319f3fc2c699f22a053\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/258/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "gciding", "id": 769267, "node_id": "MDQ6VXNlcjc2OTI2Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/769267?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gciding", "html_url": "https://github.com/gciding", "followers_url": "https://api.github.com/users/gciding/followers", "following_url": "https://api.github.com/users/gciding/following{/other_user}", "gists_url": "https://api.github.com/users/gciding/gists{/gist_id}", "starred_url": "https://api.github.com/users/gciding/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gciding/subscriptions", "organizations_url": "https://api.github.com/users/gciding/orgs", "repos_url": "https://api.github.com/users/gciding/repos", "events_url": "https://api.github.com/users/gciding/events{/privacy}", "received_events_url": "https://api.github.com/users/gciding/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Agreed, good idea.\n", "Added in 04129b097ceaf0a7a8f93ddff072d8f4b3131348\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/257/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "akaRem", "id": 1472728, "node_id": "MDQ6VXNlcjE0NzI3Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/1472728?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akaRem", "html_url": "https://github.com/akaRem", "followers_url": "https://api.github.com/users/akaRem/followers", "following_url": "https://api.github.com/users/akaRem/following{/other_user}", "gists_url": "https://api.github.com/users/akaRem/gists{/gist_id}", "starred_url": "https://api.github.com/users/akaRem/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akaRem/subscriptions", "organizations_url": "https://api.github.com/users/akaRem/orgs", "repos_url": "https://api.github.com/users/akaRem/repos", "events_url": "https://api.github.com/users/akaRem/events{/privacy}", "received_events_url": "https://api.github.com/users/akaRem/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Noted, thank you!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/256/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "akaRem", "id": 1472728, "node_id": "MDQ6VXNlcjE0NzI3Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/1472728?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akaRem", "html_url": "https://github.com/akaRem", "followers_url": "https://api.github.com/users/akaRem/followers", "following_url": "https://api.github.com/users/akaRem/following{/other_user}", "gists_url": "https://api.github.com/users/akaRem/gists{/gist_id}", "starred_url": "https://api.github.com/users/akaRem/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akaRem/subscriptions", "organizations_url": "https://api.github.com/users/akaRem/orgs", "repos_url": "https://api.github.com/users/akaRem/repos", "events_url": "https://api.github.com/users/akaRem/events{/privacy}", "received_events_url": "https://api.github.com/users/akaRem/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm not sure I agree with this proposal. The \"cost\" of evaluating a SQL expression only occurs once, when the SQL is generated and handed off to the cursor, so I'm not sure I see the need to refactor this for performance. Additionally `isinstance()` is more flexible than calling `type()` because it understands derived classes.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/255/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "chrismatta", "id": 2523087, "node_id": "MDQ6VXNlcjI1MjMwODc=", "avatar_url": "https://avatars.githubusercontent.com/u/2523087?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chrismatta", "html_url": "https://github.com/chrismatta", "followers_url": "https://api.github.com/users/chrismatta/followers", "following_url": "https://api.github.com/users/chrismatta/following{/other_user}", "gists_url": "https://api.github.com/users/chrismatta/gists{/gist_id}", "starred_url": "https://api.github.com/users/chrismatta/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chrismatta/subscriptions", "organizations_url": "https://api.github.com/users/chrismatta/orgs", "repos_url": "https://api.github.com/users/chrismatta/repos", "events_url": "https://api.github.com/users/chrismatta/events{/privacy}", "received_events_url": "https://api.github.com/users/chrismatta/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The only things peewee logs are:\n- debug: log every query\n- error: log queries that result in errors\n\nSo if you do not want these errors, you can just add a null handler to the logger:\n\n``` python\nimport logging\nlogger = logging.getLogger('peewee')\nlogger.addHandler(logging.NullHandler()) # suppress logging\n```\n", "Thanks, do you have any insight in an alternative way to update a record on duplicate keys? \n", "I think the way you're doing it makes sense. Do I need to address anything else regarding the behavior of the logging?\n", "Adding a NullHandler() didn't seem to work, it's still logging every duplicate record insert error, here's my logging section definition in the module that calls the db stuff:\n\n```\nlogging.basicConfig()\npeewee_logger = logging.getLogger('peewee')\npeewee_logger.addHandler(logging.NullHandler())\nlogger = logging.getLogger(__name__)\nlogger.setLevel(logging.INFO)\n```\n", "I use this technique a lot and know that the save() may or may not succeed, that's the whole point of catching it, I don't need to know about the error. I would however like to know about OTHER SQL errors that I may or may not be catching. This seems like I may need to change my technique for updating existing records so as to not run afoul of all these errors.\n", "Turns out I use the other technique (check for existence catch DoesNotExist then create) a lot more, so I just switched over to that. This is fine now, sorry for the trouble.\n", "> Adding a NullHandler() didn't seem to work, it's still logging every duplicate record insert error, here's my logging section definition in the module that calls the db stuff:\n\nYou might try then `peewee_logger.handlers = []`. The logging docs are pretty helpful.\n\n> Turns out I use the other technique (check for existence catch DoesNotExist then create) a lot more, so I just switched over to that. This is fine now, sorry for the trouble.\n\nSounds good!\n", "Attempting to insert a record and relying on the referential integrity of the database to tell you if a row is present is a very common use case. Having peewee spam the logger with this information (especially when it is caught) is silly.\n\nImagine you are inserting 10 million rows into a database. About 10% of your records have duplicate keys in one table or another. Checking before every insert would double the amount of DB queries required to complete the task.\n\nTurning off logging for peewee is a nuclear solution to this issue since it will disable your ability to see any other useful messages. Also setting the level above error would essentially only permit critical messages to pass through.\n\nI really appreciate the detail which peewee uses for the logger and how easy it is to see what's going on. However sending an exception to the logger inside of the library doesn't allow your library user to properly handle the exception. Even though its caught, your logs would still be full of exceptions.\n", "I totally agree with the last comment. I'm fighting with the same issue. I don't want to lose all the error traces just to ignore something that is not an error. \n\nI don't want to miss the oportunity to tell you what a great framework. Good job. Thanks a lot.\n", "> I really appreciate the detail which peewee uses for the logger and how easy it is to see what's going on. However sending an exception to the logger inside of the library doesn't allow your library user to properly handle the exception. Even though its caught, your logs would still be full of exceptions.\n\nWhat would you like to see instead?\n", "I would prefer that peewee did not log the exception to the logger but instead allowed the project that includes peewee to handle and/or log the error.\n\nFrom the perspective of a library which is solely included in another project, peewee should not impair the ability of the project owner to appropriately catch and handle errors. I would expect the library to throw the exception and be done.\n", "> I would prefer that peewee did not log the exception to the logger but instead allowed the project that includes peewee to handle and/or log the error.\n\nThat makes sense to me.\n", "Thank you!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/254/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kramer65", "id": 596581, "node_id": "MDQ6VXNlcjU5NjU4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/596581?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kramer65", "html_url": "https://github.com/kramer65", "followers_url": "https://api.github.com/users/kramer65/followers", "following_url": "https://api.github.com/users/kramer65/following{/other_user}", "gists_url": "https://api.github.com/users/kramer65/gists{/gist_id}", "starred_url": "https://api.github.com/users/kramer65/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kramer65/subscriptions", "organizations_url": "https://api.github.com/users/kramer65/orgs", "repos_url": "https://api.github.com/users/kramer65/repos", "events_url": "https://api.github.com/users/kramer65/events{/privacy}", "received_events_url": "https://api.github.com/users/kramer65/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I think that's, oddly, correct. I ran this in postgresql:\n\n``` sql\n# select count(*) from entry limit 10;\n count \n-------\n 118\n(1 row)\n```\n\nIf you wrap the select you get what you expect:\n\n``` sql\nselect count(*) from (select 1 from entry limit 10) _;\n count \n-------\n 10\n(1 row)\n```\n\nI added a commit (304c054c99277) so you can accomplish this in peewee:\n\n``` python\nTicket.select().limit(1).wrapped_count(clear_limit=False)\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/253/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "cam-stitt", "id": 186643, "node_id": "MDQ6VXNlcjE4NjY0Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/186643?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cam-stitt", "html_url": "https://github.com/cam-stitt", "followers_url": "https://api.github.com/users/cam-stitt/followers", "following_url": "https://api.github.com/users/cam-stitt/following{/other_user}", "gists_url": "https://api.github.com/users/cam-stitt/gists{/gist_id}", "starred_url": "https://api.github.com/users/cam-stitt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cam-stitt/subscriptions", "organizations_url": "https://api.github.com/users/cam-stitt/orgs", "repos_url": "https://api.github.com/users/cam-stitt/repos", "events_url": "https://api.github.com/users/cam-stitt/events{/privacy}", "received_events_url": "https://api.github.com/users/cam-stitt/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm not sure I follow these changes.\n", "I think it can be closed. It was for a specific thing I had been working on but I don't think it is actually needed :)\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/252/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/252", "html_url": "https://github.com/coleifer/peewee/pull/252", "diff_url": "https://github.com/coleifer/peewee/pull/252.diff", "patch_url": "https://github.com/coleifer/peewee/pull/252.patch", "merged_at": null }

{ "login": "akaRem", "id": 1472728, "node_id": "MDQ6VXNlcjE0NzI3Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/1472728?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akaRem", "html_url": "https://github.com/akaRem", "followers_url": "https://api.github.com/users/akaRem/followers", "following_url": "https://api.github.com/users/akaRem/following{/other_user}", "gists_url": "https://api.github.com/users/akaRem/gists{/gist_id}", "starred_url": "https://api.github.com/users/akaRem/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akaRem/subscriptions", "organizations_url": "https://api.github.com/users/akaRem/orgs", "repos_url": "https://api.github.com/users/akaRem/repos", "events_url": "https://api.github.com/users/akaRem/events{/privacy}", "received_events_url": "https://api.github.com/users/akaRem/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Do you mind trying this out?\n\n``` python\nparam = Param([(1, 2), (3, 4)])\nprint MyModel.select().where(MyModel.some_tree == param).sql()\n```\n", "@coleifer \n\nThis does not convert param (1):\n\n```\np = peewee.Param([1,2])\nprint MyModel.select().where(MyModel.some_tree == p).sql()\n\n('SELECT t1.\"id\", t1.\"some_value\", t1.\"some_tree\" FROM \"mymodel\" AS t1 WHERE (t1.\"some_tree\" = %s)', [[1, 2]])\n```\n\nThis does convert param (2):\n\n```\np = peewee.Param(MyModel.some_tree.db_value([1,2]))\nprint MyModel.select().where(MyModel.some_tree == p).sql()\n\n('SELECT t1.\"id\", t1.\"some_value\", t1.\"some_tree\" FROM \"mymodel\" AS t1 WHERE (t1.\"some_tree\" = %s)', ['000001.000002'])\n```\n\nThis fails on trying to convert converted value (as expected) (3): \n\n```\np = MyModel.some_tree.db_value([1,2])\nprint MyModel.select().where(MyModel.some_tree == p).sql()\n```\n\nYes, I found the working way for this query (2), but it looks too verbose.\n`Param` is good and it works as expected in all cases (1-2).\n\nBut I still think that behavior of `.where(field == value)` is not evident. And this operator shall just cast `value` to `db_value` (and not iterate over it) as `.where(field << iterable)` shall iterate over `iterable` once and not recursive.\nWhat do you think?\n", "The reason why `.where(field << value)` is recursive is because it needs to handle the (fairly common) case of subqueries, i.e. `WHERE id IN (SELECT ...)`.\n\nI'll look into this some more and see if there's a better fix, though.\n", "@coleifer \nI think that the most sane way is to check types in every operator, which may (by design) handle pythonic value:\n- subclass of `Node` -> handle like `Node`\n- `iterable` in places where iterables are ok -> iterate\n- everything else -> cast to db_value\n", "Adding the context \"where iterables are ok\" is what concerns me about that plan.\n", "@coleifer \n\nIve made some monkey-patch draft for this problem.\n\n```\n# -*- coding: utf-8 -*-\nfrom psycopg2ct import compat\n\ncompat.register()\n\nimport peewee\n\n\ndef patch():\n list_to_cast = ['__eq__']\n list_to_map = ['__lshift__']\n\n patched = {}\n\n def mutate_with_cast(op):\n original = peewee.Node.__dict__[op]\n\n def mutated(self, rhs):\n if not isinstance(rhs, peewee.Node):\n rhs = peewee.Param(self.db_value(rhs))\n return original(self, rhs)\n\n patched[op] = mutated\n\n def mutate_with_map(op):\n original = peewee.Node.__dict__[op]\n\n def mutated(self, rhs):\n rhs = [i if isinstance(i, peewee.Node) else peewee.Param(self.db_value(i)) for i in rhs]\n return original(self, rhs)\n\n patched[op] = mutated\n\n map(mutate_with_cast, list_to_cast)\n map(mutate_with_map, list_to_map)\n\n peewee.Node.__dict__.update(patched)\n\n\npatch()\n\nimport playhouse.postgres_ext as pp\n\n\nclass IntLTreeField(peewee.Field):\n db_field = 'ltree'\n template = '%(column_type)s'\n\n def field_attributes(self):\n return {\n 'length': 6,\n }\n\n def db_value(self, value):\n formatter = \"{{:0{length:}}}\".format(**self.attributes)\n return '.'.join(map(formatter.format, value))\n\n def python_value(self, value):\n return map(int, value.split('.'))\n\n\npp.PostgresqlExtDatabase.register_fields({'ltree': 'LTREE'})\n\ndb = pp.PostgresqlExtDatabase('mydb')\n\n\nclass MyModel(peewee.Model):\n class Meta:\n database = db\n\n some_value = peewee.IntegerField()\n some_tree = IntLTreeField(length=6)\n\n\nprint MyModel.select().where(MyModel.some_tree == [1, 2]).sql()\nprint MyModel.select().where(MyModel.some_tree << [[1, 2], [2, 3]]).sql()\n```\n\nOutputs:\n\n```\n ('SELECT t1.\"id\", t1.\"some_value\", t1.\"some_tree\" FROM \"mymodel\" AS t1 WHERE (t1.\"some_tree\" = %s)', ['000001.000002'])\n ('SELECT t1.\"id\", t1.\"some_value\", t1.\"some_tree\" FROM \"mymodel\" AS t1 WHERE (t1.\"some_tree\" IN (%s, %s))', ['000001.000002', '000002.000003'])\n```\n\nLooks like it work. :)\n\n.. but it needs to add each op into corresponding list to patch. \n.. and to rewrite some mappings depending on import style. \n\nWhat do you think?\n", "That's definitely an approach I had not thought of. I do have a concern, though, about changing the data at the time the expression is evaluated in python. My preference w/the 2.0 rewrite has been to do these kinds of things in the `QueryCompiler`. I understand that the way the `QueryCompiler` handles lists is not ideal for situations where you're trying to pass the list to `db_value`, however I'd rather not change the data at expression evaluation time.\n", "Why not? If you compare 2 **complicated** values where one is a db-type, and other is a py-type, then one of them shall be casted to proper type (or at least to good type for query placeholders). \n\nThe questions are: which of them shall be casted (A), and who is responsible for that (B)?\n\nA. When we prepare query for db, it's obvious, that all shall be casted into db-values. When we getting something from db, we convert it into py-value. And not vice-versa.\n\nB. We have (as i suppose) 4 places, where these values can be converted:\n1) somewhere inside db or in query line;\n2) somewhere inside peewee, when query is about to execute;\n3) somewhere inside peewee, when query is building;\n4) manually.\n\nThe 1-st is bad.Because we use db as data-storage and we try not to move any business-logic into it. Also, unreasonable complicated queries are not good. Ex:\n\nTheese queries\n\n```\nSELECT * FROM my_table WHERE tree ~ \"%s.%s.%s\".%s\".%s.%s\" ::ltree\nSELECT * FROM my_table WHERE tree ~ \"%s.%s.%s\".%s\".%s\" ::ltree\nSELECT * FROM my_table WHERE tree ~ \"%s.%s\" ::ltree\n```\n\nare the same as this:\n\n```\nSELECT * FROM my_table WHERE tree ~ \"%s\" ::ltree \n```\n\nThe 2-nd is bad too, because we need to \"remember\" conversion functions for each field of each model involved into query. It complicates peewee's logic and brings lots of unnecessary overheads. \nThe 3-rd is better, because we convert and 'freeze' parameters right at the place and time, when and where we build query.\nThe 4-th - Manual operations - ? No. \n", "So the crux of the problem is that peewee handles lists differently than other values. You want to be able to pass the list unmodified into the `db_value()` method of the field. There is a mechanism for that (`Param`) but it isn't doing the right thing -- I think the fix is to make `Param` use `db_value()` when possible.\n\nWhat do you think?\n\n``` diff\ndiff --git a/peewee.py b/peewee.py\nindex 2386dab..8ab17c0 100644\n--- a/peewee.py\n+++ b/peewee.py\n@@ -45,6 +45,7 @@ __all__ = [\n 'JOIN_LEFT_OUTER',\n 'Model',\n 'MySQLDatabase',\n+ 'Param',\n 'PostgresqlDatabase',\n 'prefetch',\n 'PrimaryKeyField',\n@@ -838,6 +839,7 @@ class QueryCompiler(object):\n node.nodes, alias_map, conv, ' ')\n elif isinstance(node, Param):\n params = [node.value]\n+ unknown = True\n elif isinstance(node, R):\n sql = node.value\n params = []\n```\n\nThe way you would use it would be:\n\n``` python\nfrom peewee import *\n\nclass IntLTreeField(Field):\n db_field = 'ltree'\n template = '%(column_type)s'\n\n def field_attributes(self):\n return {'length': 6}\n\n def db_value(self, value):\n formatter = \"{{:0{length:}}}\".format(**self.attributes)\n return '.'.join(map(formatter.format, value))\n\n def python_value(self, value):\n return map(int, value.split('.'))\n\nclass MyModel(Model):\n some_tree = IntLTreeField()\n\nprint MyModel.select().where(MyModel.some_tree == Param([1, 2])).sql()\ntrees = [\n Param([1, 2]),\n Param([3, 4])]\nprint MyModel.select().where(MyModel.some_tree << trees).sql()\n```\n\nPrints:\n('SELECT t1.\"id\", t1.\"some_tree\" FROM \"mymodel\" AS t1 WHERE (t1.\"some_tree\" = ?)', ['000001.000002'])\n('SELECT t1.\"id\", t1.\"some_tree\" FROM \"mymodel\" AS t1 WHERE (t1.\"some_tree\" IN (?, ?))', ['000001.000002', '000003.000004'])\n", "Added in 51c949c7a7d5f8969ef77611c2c8016b692df00b\n", "I like it!\n", "Cool, thanks for talking this one through w/me!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/251/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "akaRem", "id": 1472728, "node_id": "MDQ6VXNlcjE0NzI3Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/1472728?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akaRem", "html_url": "https://github.com/akaRem", "followers_url": "https://api.github.com/users/akaRem/followers", "following_url": "https://api.github.com/users/akaRem/following{/other_user}", "gists_url": "https://api.github.com/users/akaRem/gists{/gist_id}", "starred_url": "https://api.github.com/users/akaRem/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akaRem/subscriptions", "organizations_url": "https://api.github.com/users/akaRem/orgs", "repos_url": "https://api.github.com/users/akaRem/repos", "events_url": "https://api.github.com/users/akaRem/events{/privacy}", "received_events_url": "https://api.github.com/users/akaRem/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The problem is in how you're instantiating the compiler. Try this instead, it will work:\n\n``` python\ncompiler = db.compiler()\nprint compiler.create_table(MyModel)\n```\n", "@coleifer Thanks! It works.\n", "Awesome!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/250/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kramer65", "id": 596581, "node_id": "MDQ6VXNlcjU5NjU4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/596581?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kramer65", "html_url": "https://github.com/kramer65", "followers_url": "https://api.github.com/users/kramer65/followers", "following_url": "https://api.github.com/users/kramer65/following{/other_user}", "gists_url": "https://api.github.com/users/kramer65/gists{/gist_id}", "starred_url": "https://api.github.com/users/kramer65/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kramer65/subscriptions", "organizations_url": "https://api.github.com/users/kramer65/orgs", "repos_url": "https://api.github.com/users/kramer65/repos", "events_url": "https://api.github.com/users/kramer65/events{/privacy}", "received_events_url": "https://api.github.com/users/kramer65/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Check out http://peewee.readthedocs.org/en/latest/peewee/models.html#self-referential-foreign-keys\n\ntl;dr\n\n``` python\nadded_by = ForeignKeyField('self', related_name='users_created')\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/249/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kerqicce", "id": 5898015, "node_id": "MDQ6VXNlcjU4OTgwMTU=", "avatar_url": "https://avatars.githubusercontent.com/u/5898015?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kerqicce", "html_url": "https://github.com/kerqicce", "followers_url": "https://api.github.com/users/kerqicce/followers", "following_url": "https://api.github.com/users/kerqicce/following{/other_user}", "gists_url": "https://api.github.com/users/kerqicce/gists{/gist_id}", "starred_url": "https://api.github.com/users/kerqicce/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kerqicce/subscriptions", "organizations_url": "https://api.github.com/users/kerqicce/orgs", "repos_url": "https://api.github.com/users/kerqicce/repos", "events_url": "https://api.github.com/users/kerqicce/events{/privacy}", "received_events_url": "https://api.github.com/users/kerqicce/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You're close, but you will need to perform a join. Check out the docs on joining: http://peewee.readthedocs.org/en/latest/peewee/querying.html#joining-tables\n\n``` python\nresult = Secondary.select().join(Primary).where(Primary.prim_attr == 'something')\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/248/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kerqicce", "id": 5898015, "node_id": "MDQ6VXNlcjU4OTgwMTU=", "avatar_url": "https://avatars.githubusercontent.com/u/5898015?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kerqicce", "html_url": "https://github.com/kerqicce", "followers_url": "https://api.github.com/users/kerqicce/followers", "following_url": "https://api.github.com/users/kerqicce/following{/other_user}", "gists_url": "https://api.github.com/users/kerqicce/gists{/gist_id}", "starred_url": "https://api.github.com/users/kerqicce/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kerqicce/subscriptions", "organizations_url": "https://api.github.com/users/kerqicce/orgs", "repos_url": "https://api.github.com/users/kerqicce/repos", "events_url": "https://api.github.com/users/kerqicce/events{/privacy}", "received_events_url": "https://api.github.com/users/kerqicce/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Typically I store my choices in a class-level constant so they are easier to access and compare against:\n\n``` python\n\nclass Something(Model):\n FOO_YES = 1\n FOO_NO = 2\n FOO_CHOICES = (\n (FOO_YES, 'Yes'),\n (FOO_NO, 'No'))\n foo = IntegerField(choices=FOO_CHOICES)\n\n def __unicode__(self):\n return dict(self.FOO_CHOICES)[self.foo]\n```\n", "Thanks to you. That is a super good tip! I am going to use it immediately!!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/247/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kerqicce", "id": 5898015, "node_id": "MDQ6VXNlcjU4OTgwMTU=", "avatar_url": "https://avatars.githubusercontent.com/u/5898015?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kerqicce", "html_url": "https://github.com/kerqicce", "followers_url": "https://api.github.com/users/kerqicce/followers", "following_url": "https://api.github.com/users/kerqicce/following{/other_user}", "gists_url": "https://api.github.com/users/kerqicce/gists{/gist_id}", "starred_url": "https://api.github.com/users/kerqicce/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kerqicce/subscriptions", "organizations_url": "https://api.github.com/users/kerqicce/orgs", "repos_url": "https://api.github.com/users/kerqicce/repos", "events_url": "https://api.github.com/users/kerqicce/events{/privacy}", "received_events_url": "https://api.github.com/users/kerqicce/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Check your database's documentation on `SELECT FOR UPDATE` ([link to peewee docs](http://peewee.readthedocs.org/en/latest/peewee/api.html#SelectQuery.for_update)).\n\nIf you're using postgres, here are some docs. http://www.postgresql.org/docs/9.0/static/sql-select.html#SQL-FOR-UPDATE-SHARE\n\nDoes this answer your question?\n", "Thank you very much for the information. This is a perfect answers to my question!\n\nI have never worked with FOR UPDATE before, but I will read in the PostgreSQL documentation about it. Do I need any addon to peewee for this, or will it work with PostgreSQL out of the box?\n\nDo you know if there is any peewee example code using for_update?\n", "It will work out of the box. The tests are the only place there is example code for this feature, around line 3085.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/246/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tyteen4a03", "id": 440015, "node_id": "MDQ6VXNlcjQ0MDAxNQ==", "avatar_url": "https://avatars.githubusercontent.com/u/440015?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tyteen4a03", "html_url": "https://github.com/tyteen4a03", "followers_url": "https://api.github.com/users/tyteen4a03/followers", "following_url": "https://api.github.com/users/tyteen4a03/following{/other_user}", "gists_url": "https://api.github.com/users/tyteen4a03/gists{/gist_id}", "starred_url": "https://api.github.com/users/tyteen4a03/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tyteen4a03/subscriptions", "organizations_url": "https://api.github.com/users/tyteen4a03/orgs", "repos_url": "https://api.github.com/users/tyteen4a03/repos", "events_url": "https://api.github.com/users/tyteen4a03/events{/privacy}", "received_events_url": "https://api.github.com/users/tyteen4a03/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This is not fixed in tests.py.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/245/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "pitchforks", "id": 4378791, "node_id": "MDQ6VXNlcjQzNzg3OTE=", "avatar_url": "https://avatars.githubusercontent.com/u/4378791?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pitchforks", "html_url": "https://github.com/pitchforks", "followers_url": "https://api.github.com/users/pitchforks/followers", "following_url": "https://api.github.com/users/pitchforks/following{/other_user}", "gists_url": "https://api.github.com/users/pitchforks/gists{/gist_id}", "starred_url": "https://api.github.com/users/pitchforks/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pitchforks/subscriptions", "organizations_url": "https://api.github.com/users/pitchforks/orgs", "repos_url": "https://api.github.com/users/pitchforks/repos", "events_url": "https://api.github.com/users/pitchforks/events{/privacy}", "received_events_url": "https://api.github.com/users/pitchforks/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Peewee supports logging using python's standard library logging module. The logger can help you debug queries and also supports logging exceptions executing queries. Python docs have you covered: \n\nhttp://docs.python.org/3.1/library/logging.html#configuring-logging-for-a-library\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/244/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ricoboni", "id": 1664502, "node_id": "MDQ6VXNlcjE2NjQ1MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/1664502?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ricoboni", "html_url": "https://github.com/ricoboni", "followers_url": "https://api.github.com/users/ricoboni/followers", "following_url": "https://api.github.com/users/ricoboni/following{/other_user}", "gists_url": "https://api.github.com/users/ricoboni/gists{/gist_id}", "starred_url": "https://api.github.com/users/ricoboni/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ricoboni/subscriptions", "organizations_url": "https://api.github.com/users/ricoboni/orgs", "repos_url": "https://api.github.com/users/ricoboni/repos", "events_url": "https://api.github.com/users/ricoboni/events{/privacy}", "received_events_url": "https://api.github.com/users/ricoboni/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/243/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "caelx", "id": 1686351, "node_id": "MDQ6VXNlcjE2ODYzNTE=", "avatar_url": "https://avatars.githubusercontent.com/u/1686351?v=4", "gravatar_id": "", "url": "https://api.github.com/users/caelx", "html_url": "https://github.com/caelx", "followers_url": "https://api.github.com/users/caelx/followers", "following_url": "https://api.github.com/users/caelx/following{/other_user}", "gists_url": "https://api.github.com/users/caelx/gists{/gist_id}", "starred_url": "https://api.github.com/users/caelx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/caelx/subscriptions", "organizations_url": "https://api.github.com/users/caelx/orgs", "repos_url": "https://api.github.com/users/caelx/repos", "events_url": "https://api.github.com/users/caelx/events{/privacy}", "received_events_url": "https://api.github.com/users/caelx/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Just out of curiosity have you tried messing with the encoding on the connection object?\n", "Thanks for getting back to me.\n\nYes, the database is set for client encoding USASCII but I tried changing it to UTF8. This did not help though because there were still unicode conversion errors for some of the characters which aren't valid UTF8 characters.\n\nThe invalid characters were \\x93 and \\x94\n", "OK, cool. Well it looks like I can register those converters on the connection, so this should be pretty straightforward to fix.\n", "Thanks!\n\nThis project is giving me a hell of a headache, appreciate this\n", "Should be fixed in f1607416474ae99ccc16b058172cbce9d0ebd230 .\n\nYou'll need to turn off the unicode converter registration code:\n\n``` python\ndb = PostgresqlDatabase('...')\ndb.register_unicode = False # disables registering the unicode handlers on a per-connection basis.\n```\n\nIf for some reason this doesn't solve your problem please reopen.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/242/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }