Datasets:

akumoth

/

peewee-issues

like 0

{ "login": "johnmave126", "id": 1661662, "node_id": "MDQ6VXNlcjE2NjE2NjI=", "avatar_url": "https://avatars.githubusercontent.com/u/1661662?v=4", "gravatar_id": "", "url": "https://api.github.com/users/johnmave126", "html_url": "https://github.com/johnmave126", "followers_url": "https://api.github.com/users/johnmave126/followers", "following_url": "https://api.github.com/users/johnmave126/following{/other_user}", "gists_url": "https://api.github.com/users/johnmave126/gists{/gist_id}", "starred_url": "https://api.github.com/users/johnmave126/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/johnmave126/subscriptions", "organizations_url": "https://api.github.com/users/johnmave126/orgs", "repos_url": "https://api.github.com/users/johnmave126/repos", "events_url": "https://api.github.com/users/johnmave126/events{/privacy}", "received_events_url": "https://api.github.com/users/johnmave126/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Please close this issue\nI found it duplicate to #212 \n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/214/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "SecurityForUs", "id": 1146703, "node_id": "MDQ6VXNlcjExNDY3MDM=", "avatar_url": "https://avatars.githubusercontent.com/u/1146703?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SecurityForUs", "html_url": "https://github.com/SecurityForUs", "followers_url": "https://api.github.com/users/SecurityForUs/followers", "following_url": "https://api.github.com/users/SecurityForUs/following{/other_user}", "gists_url": "https://api.github.com/users/SecurityForUs/gists{/gist_id}", "starred_url": "https://api.github.com/users/SecurityForUs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SecurityForUs/subscriptions", "organizations_url": "https://api.github.com/users/SecurityForUs/orgs", "repos_url": "https://api.github.com/users/SecurityForUs/repos", "events_url": "https://api.github.com/users/SecurityForUs/events{/privacy}", "received_events_url": "https://api.github.com/users/SecurityForUs/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Nevermind, I forgot in a join the joined table is in its own attribute. Closing.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/213/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "arnuschky", "id": 179920, "node_id": "MDQ6VXNlcjE3OTkyMA==", "avatar_url": "https://avatars.githubusercontent.com/u/179920?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arnuschky", "html_url": "https://github.com/arnuschky", "followers_url": "https://api.github.com/users/arnuschky/followers", "following_url": "https://api.github.com/users/arnuschky/following{/other_user}", "gists_url": "https://api.github.com/users/arnuschky/gists{/gist_id}", "starred_url": "https://api.github.com/users/arnuschky/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arnuschky/subscriptions", "organizations_url": "https://api.github.com/users/arnuschky/orgs", "repos_url": "https://api.github.com/users/arnuschky/repos", "events_url": "https://api.github.com/users/arnuschky/events{/privacy}", "received_events_url": "https://api.github.com/users/arnuschky/received_events", "type": "User", "site_admin": false }

[]

[]

[ "With SQLite the `%` operator (case-sensitive like) actually uses the `GLOB` operation which is why it requires you use `*` as the wildcard. The `**` operator (case-insensitive like) uses `LIKE`. Confusing, right?\n\nBased on this script, I believe the \"*\" character is matching zero or more. Does it work for you?\n\n``` python\nfrom peewee import *\n\ndb = SqliteDatabase(':memory:')\n\nclass TestModel(Model):\n name = CharField()\n\nnames = ['foo', 'bar', 'baz']\n\nTestModel.create_table()\nfor name in names:\n TestModel.create(name=name)\n\nassert TestModel.get(TestModel.name % '*foo*').name == 'foo'\nassert TestModel.get(TestModel.name % 'foo*').name == 'foo'\nassert TestModel.get(TestModel.name % '*ba*').name in ('bar', 'baz')\n```\n", "Try:\n\n```\n name = CharField(max_length=3)\n```\n\nPeeWee seems to strip the search string for (including the wildcard) according to the max_length attribute\n", "@arnuschky -- Ahhh, good catch.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/212/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jfmatth", "id": 289202, "node_id": "MDQ6VXNlcjI4OTIwMg==", "avatar_url": "https://avatars.githubusercontent.com/u/289202?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jfmatth", "html_url": "https://github.com/jfmatth", "followers_url": "https://api.github.com/users/jfmatth/followers", "following_url": "https://api.github.com/users/jfmatth/following{/other_user}", "gists_url": "https://api.github.com/users/jfmatth/gists{/gist_id}", "starred_url": "https://api.github.com/users/jfmatth/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jfmatth/subscriptions", "organizations_url": "https://api.github.com/users/jfmatth/orgs", "repos_url": "https://api.github.com/users/jfmatth/repos", "events_url": "https://api.github.com/users/jfmatth/events{/privacy}", "received_events_url": "https://api.github.com/users/jfmatth/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Call model.create_table instead. Db method just creates the table while model method creates indexes as well.\n", "thanks, worked great!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/211/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "panta", "id": 238501, "node_id": "MDQ6VXNlcjIzODUwMQ==", "avatar_url": "https://avatars.githubusercontent.com/u/238501?v=4", "gravatar_id": "", "url": "https://api.github.com/users/panta", "html_url": "https://github.com/panta", "followers_url": "https://api.github.com/users/panta/followers", "following_url": "https://api.github.com/users/panta/following{/other_user}", "gists_url": "https://api.github.com/users/panta/gists{/gist_id}", "starred_url": "https://api.github.com/users/panta/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/panta/subscriptions", "organizations_url": "https://api.github.com/users/panta/orgs", "repos_url": "https://api.github.com/users/panta/repos", "events_url": "https://api.github.com/users/panta/events{/privacy}", "received_events_url": "https://api.github.com/users/panta/received_events", "type": "User", "site_admin": false }

[]

[]

[ "From docstring:\n\n``` python\n from peewee import *\n from playhouse.proxy import Proxy\n\n database_proxy = Proxy() # Create a proxy for our db.\n\n class BaseModel(Model):\n class Meta:\n database = database_proxy # Use proxy for our DB.\n\n class User(BaseModel):\n username = CharField()\n\n # Based on configuration, use a different database.\n if app.config['DEBUG']:\n database = SqliteDatabase('local.db')\n elif app.config['TESTING']:\n database = SqliteDatabase(':memory:')\n else:\n database = PostgresqlDatabase('mega_production_db')\n\n # Configure our proxy to use the db we specified in config.\n database_proxy.initialize(database)\n```\n", "> From docstring:\r\n> \r\n> ```python\r\n> from peewee import *\r\n> from playhouse.proxy import Proxy\r\n> \r\n> database_proxy = Proxy() # Create a proxy for our db.\r\n> \r\n> class BaseModel(Model):\r\n> class Meta:\r\n> database = database_proxy # Use proxy for our DB.\r\n> \r\n> class User(BaseModel):\r\n> username = CharField()\r\n> \r\n> # Based on configuration, use a different database.\r\n> if app.config['DEBUG']:\r\n> database = SqliteDatabase('local.db')\r\n> elif app.config['TESTING']:\r\n> database = SqliteDatabase(':memory:')\r\n> else:\r\n> database = PostgresqlDatabase('mega_production_db')\r\n> \r\n> # Configure our proxy to use the db we specified in config.\r\n> database_proxy.initialize(database)\r\n> ```\r\n\r\n`from playhouse.proxy import Proxy` not found any more...", "It's moved into the peewee module: http://docs.peewee-orm.com/en/latest/peewee/api.html#Proxy\r\n\r\n```python\r\nfrom peewee import Proxy\r\n```\r\n\r\nAlthough you probably want to use instead the `DatabaseProxy`:\r\n\r\n```python\r\nfrom peewee import DatabaseProxy\r\n```" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/210/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "panta", "id": 238501, "node_id": "MDQ6VXNlcjIzODUwMQ==", "avatar_url": "https://avatars.githubusercontent.com/u/238501?v=4", "gravatar_id": "", "url": "https://api.github.com/users/panta", "html_url": "https://github.com/panta", "followers_url": "https://api.github.com/users/panta/followers", "following_url": "https://api.github.com/users/panta/following{/other_user}", "gists_url": "https://api.github.com/users/panta/gists{/gist_id}", "starred_url": "https://api.github.com/users/panta/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/panta/subscriptions", "organizations_url": "https://api.github.com/users/panta/orgs", "repos_url": "https://api.github.com/users/panta/repos", "events_url": "https://api.github.com/users/panta/events{/privacy}", "received_events_url": "https://api.github.com/users/panta/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Postgresql does not support this, and Sqlite does but only if compiled with `SQLITE_ENABLE_UPDATE_DELETE_LIMIT`. Because it is only MySQL that supports this feature, I am going to pass on fixing it for now.\n\nThere have been similar features requests, from which you might be able to get some ideas:\n- #146 , adds limit / order by to update queries\n- #153 , adds support for limit to update queries\n\nIn the future I may attempt to add a compatibility layer, but for now I am going to close this.\n", "Thank you, in the meantime I arrived at the same conclusions too.\nI've found multiple other ways to solve the same problem, thanks to peewee flexibility. In case anyone ends here with the same problem, they are:\n\nselect() + delete():\n\n``` python\nto_delete = Log.select().order_by(Log.when.asc()).limit(n_to_delete)\nn_deleted = Log.delete().where(Log.id << to_delete).execute()\n```\n\nselect() + DeleteQuery():\n\n``` python\ndq = DeleteQuery(Log).where(\n Log.id << Log.select().order_by(Log.when.asc()).limit(n_to_delete)\n)\nn_deleted = dq.execute()\n```\n\nraw SQL:\n\n``` python\ndb.execute_sql(\"DELETE FROM log WHERE `id` in ( SELECT `id` FROM log ORDER BY `when` DESC LIMIT ? OFFSET ? )\", (n_to_delete, max_logs))\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/209/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "passiomatic", "id": 56371, "node_id": "MDQ6VXNlcjU2Mzcx", "avatar_url": "https://avatars.githubusercontent.com/u/56371?v=4", "gravatar_id": "", "url": "https://api.github.com/users/passiomatic", "html_url": "https://github.com/passiomatic", "followers_url": "https://api.github.com/users/passiomatic/followers", "following_url": "https://api.github.com/users/passiomatic/following{/other_user}", "gists_url": "https://api.github.com/users/passiomatic/gists{/gist_id}", "starred_url": "https://api.github.com/users/passiomatic/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/passiomatic/subscriptions", "organizations_url": "https://api.github.com/users/passiomatic/orgs", "repos_url": "https://api.github.com/users/passiomatic/repos", "events_url": "https://api.github.com/users/passiomatic/events{/privacy}", "received_events_url": "https://api.github.com/users/passiomatic/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Unfortunately, I'm not sure there's a great solution for this without resorting to hacks. It would be possible to special-case flat aggregation / annotations by introspecting the field type and then passing the value from the cursor through the field's `python_value` method, but I'm not sure how clean the implementation would be and it might be fragile. The other thing I want to avoid is a performance penalty.\n\nFor now I am going to leave this open, but I'm not sure that I will be able to resolve it.\n\nNote: This problem only appears in Sqlite and not mysql / postgres.\n", "Partially fixed in d23619abeb0f78d46284658d012970a30c7e3186 . `annotate` works now, just `aggregate` / `scalar` fail.\n", "That's great, thank you. Do you plan to do a dot release soon?\n", "Within the next day or two.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/208/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jfmatth", "id": 289202, "node_id": "MDQ6VXNlcjI4OTIwMg==", "avatar_url": "https://avatars.githubusercontent.com/u/289202?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jfmatth", "html_url": "https://github.com/jfmatth", "followers_url": "https://api.github.com/users/jfmatth/followers", "following_url": "https://api.github.com/users/jfmatth/following{/other_user}", "gists_url": "https://api.github.com/users/jfmatth/gists{/gist_id}", "starred_url": "https://api.github.com/users/jfmatth/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jfmatth/subscriptions", "organizations_url": "https://api.github.com/users/jfmatth/orgs", "repos_url": "https://api.github.com/users/jfmatth/repos", "events_url": "https://api.github.com/users/jfmatth/events{/privacy}", "received_events_url": "https://api.github.com/users/jfmatth/received_events", "type": "User", "site_admin": false }

[]

[]

[ "edit: fixed formatting.\n", "Are you using MySQL?\n", "If you're using MySQL you might test out using this query, which is how pwiz finds foreign keys:\n\n``` sql\nSELECT column_name, referenced_table_name, referenced_column_name\nFROM information_schema.key_column_usage\nWHERE table_name = \"your table name here\"\n AND table_schema = DATABASE()\n AND referenced_table_name IS NOT NULL\n AND referenced_column_name IS NOT NULL\n```\n", "Yes we are.\n\nI'll run the query and show results. Thanks for the quick feedback\n\nJ\n---------- Forwarded message ----------\nFrom: \"Charles Leifer\" [email protected]\nDate: Jun 21, 2013 7:58 AM\nSubject: Re: [peewee] pwiz not generating foreign key fields? (#207)\nTo: \"coleifer/peewee\" [email protected]\nCc: \"John Matthew\" [email protected]\n\nAre you using MySQL?\n\n—\nReply to this email directly or view it on\nGitHubhttps://github.com/coleifer/peewee/issues/207#issuecomment-19820920\n.\n", "My associate at work says it may be the type of DB we are running, MyISAM, which doesn't understand true FK's.\n\nSee below:\n\n```\nmysql> SELECT column_name, referenced_table_name, referenced_column_name FROM information_schema.key_column_usage WHERE table_name = \"Tickets\" AND table_schema = DATABASE() AND referenced_table_name IS NOT NULL AND referenced_column_name IS NOT NULL;\nEmpty set (0.00 sec)\n\nmysql> show create table Tickets ;\n+---------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+\n| Table | Create Table |\n+---------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+\n| Tickets | CREATE TABLE `Tickets` (\n `id` int(11) NOT NULL auto_increment,\n `EffectiveId` int(11) NOT NULL default '0',\n `Queue` int(11) NOT NULL default '0',\n `Type` varchar(16) default NULL,\n `IssueStatement` int(11) NOT NULL default '0',\n `Resolution` int(11) NOT NULL default '0',\n `Owner` int(11) NOT NULL default '0',\n `Subject` varchar(200) default '[no subject]',\n `InitialPriority` int(11) NOT NULL default '0',\n `FinalPriority` int(11) NOT NULL default '0',\n `Priority` int(11) NOT NULL default '0',\n `TimeEstimated` int(11) NOT NULL default '0',\n `TimeWorked` int(11) NOT NULL default '0',\n `Status` varchar(10) default NULL,\n `TimeLeft` int(11) NOT NULL default '0',\n `Told` datetime default NULL,\n `Starts` datetime default NULL,\n `Started` datetime default NULL,\n `Due` datetime default NULL,\n `Resolved` datetime default NULL,\n `LastUpdatedBy` int(11) NOT NULL default '0',\n `LastUpdated` datetime default NULL,\n `Creator` int(11) NOT NULL default '0',\n `Created` datetime default NULL,\n `Disabled` smallint(6) NOT NULL default '0',\n PRIMARY KEY (`id`),\n KEY `Tickets1` (`Queue`,`Status`),\n KEY `Tickets2` (`Owner`),\n KEY `Tickets6` (`EffectiveId`,`Type`),\n KEY `Creator` (`Creator`),\n KEY `Subject` (`Subject`)\n) ENGINE=MyISAM AUTO_INCREMENT=73183 DEFAULT CHARSET=latin1 |\n+---------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+\n1 row in set (0.00 sec)\n\nmysql>\n```\n\nI hope this helps. \n\nJ\n", "Unfortunately, pwiz does not understand how to work with MyISAM. Currently I have no plans for adding this support.\n", "Charles, thank you for taking the time to look at this. I figured that would be the case.\n\nKeep up the excellent work on peewee, it's a great \"little\" product.\n\nJ\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/207/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/206/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "niedbalski", "id": 821670, "node_id": "MDQ6VXNlcjgyMTY3MA==", "avatar_url": "https://avatars.githubusercontent.com/u/821670?v=4", "gravatar_id": "", "url": "https://api.github.com/users/niedbalski", "html_url": "https://github.com/niedbalski", "followers_url": "https://api.github.com/users/niedbalski/followers", "following_url": "https://api.github.com/users/niedbalski/following{/other_user}", "gists_url": "https://api.github.com/users/niedbalski/gists{/gist_id}", "starred_url": "https://api.github.com/users/niedbalski/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/niedbalski/subscriptions", "organizations_url": "https://api.github.com/users/niedbalski/orgs", "repos_url": "https://api.github.com/users/niedbalski/repos", "events_url": "https://api.github.com/users/niedbalski/events{/privacy}", "received_events_url": "https://api.github.com/users/niedbalski/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I think I will pass on merging this as it consumes the choices iterable once upon field initialization. Rather, I will rely on the documentation.\n", "OK, perfect.I always prefer the code that dies descriptively\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/205/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/205", "html_url": "https://github.com/coleifer/peewee/pull/205", "diff_url": "https://github.com/coleifer/peewee/pull/205.diff", "patch_url": "https://github.com/coleifer/peewee/pull/205.patch", "merged_at": null }

{ "login": "rammie", "id": 554792, "node_id": "MDQ6VXNlcjU1NDc5Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/554792?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rammie", "html_url": "https://github.com/rammie", "followers_url": "https://api.github.com/users/rammie/followers", "following_url": "https://api.github.com/users/rammie/following{/other_user}", "gists_url": "https://api.github.com/users/rammie/gists{/gist_id}", "starred_url": "https://api.github.com/users/rammie/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rammie/subscriptions", "organizations_url": "https://api.github.com/users/rammie/orgs", "repos_url": "https://api.github.com/users/rammie/repos", "events_url": "https://api.github.com/users/rammie/events{/privacy}", "received_events_url": "https://api.github.com/users/rammie/received_events", "type": "User", "site_admin": false }

[]

[]

[ "If you would like to negate an expression and are using the \"django-style\" lookups, you will need to wrap it in a `DQ` object and use unary negation:\n\n``` python\n\n# this query\n.where(~DQ(foo__in=[list of stuff]))\n\n# translates into this\n-- where NOT foo IN [list of stuff]\n```\n\nUnfortunately, I don't think this helps with your use-case of the flask-peewee rest api. I'm not sure I like the idea of adding NOT IN, but I see your point about the difficulty. Will think about it.\n", "One possibility is to make the rest operators a superset of the django ones. This seems somewhat principaled. More so than adding it to the DJANGO_MAP.\n", "Out of interest, why doesn't peewee use Python's `in` operator (i.e., overload `__contains__`) to represent SQL \"x in (1, 2, 3)\" instead of the weird-looking `<<`? This would also work for SQL's NOT IN -- same as Python. Relatedly, it'd be nice if `x == None` (can't use `x is None` fo this) translated to SQL `x IS NULL` to avoid the extra `>>` operator.\n", "Using `in` and `__contains__` won't work (unfortunately) because python will always convert the return value of contains to a boolean. I'd rather not special-case `==` to handle `NULL` because semantically `IS NULL` is distinct.\n", "Huh, I didn't know that about `__contains__` -- pity. Fair enough about not special-case `==` -- seems a shame to use a whole operator for this though.\n", "Just an FYI: I asked about why `__contains__` was like that on Python-Dev, and got [this helpful answer](http://mail.python.org/pipermail/python-dev/2013-July/127297.html) from Nick Coghlan, a Python core dev.\n", "Thanks @benhoyt I was not aware of the rationale for this behavior.\n", "@rammie, if you pull the latest peewee and flask-peewee, I have added support for negating expressions in the REST api by prefixing the left-hand lookup with \"-\", so:\n\n```\n/api/user/?username=foo -- users named \"foo\"\n/api/user/?-username=foo -- users *not* named \"foo\"\n```\n\nGive it a try and let me know how it works for you.\n", "Thanks a lot. I really like the solution. Is legit. I'll play with it a\nlittle and let you know tomorrow. I hope a version bump follows soon.\nOn Jul 21, 2013 7:46 PM, \"Charles Leifer\" [email protected] wrote:\n\n> @rammie https://github.com/rammie, if you pull the latest peewee and\n> flask-peewee, I have added support for negating expressions in the REST api\n> by prefixing the left-hand lookup with \"-\", so:\n> \n> /api/user/?username=foo -- users named \"foo\"\n> /api/user/?-username=foo -- users _not_ named \"foo\"\n> \n> Give it a try and let me know how it works for you.\n> \n> —\n> Reply to this email directly or view it on GitHubhttps://github.com/coleifer/peewee/issues/204#issuecomment-21319460\n> .\n", "Tried it, works well for my use cases. Thanks!\n\nOn Sun, Jul 21, 2013 at 10:27 PM, Ram Mehta [email protected] wrote:\n\n> Thanks a lot. I really like the solution. Is legit. I'll play with it a\n> little and let you know tomorrow. I hope a version bump follows soon.\n> On Jul 21, 2013 7:46 PM, \"Charles Leifer\" [email protected]\n> wrote:\n> \n> > @rammie https://github.com/rammie, if you pull the latest peewee and\n> > flask-peewee, I have added support for negating expressions in the REST api\n> > by prefixing the left-hand lookup with \"-\", so:\n> > \n> > /api/user/?username=foo -- users named \"foo\"\n> > /api/user/?-username=foo -- users _not_ named \"foo\"\n> > \n> > Give it a try and let me know how it works for you.\n> > \n> > —\n> > Reply to this email directly or view it on GitHubhttps://github.com/coleifer/peewee/issues/204#issuecomment-21319460\n> > .\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/204/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "rcarmo", "id": 392683, "node_id": "MDQ6VXNlcjM5MjY4Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/392683?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rcarmo", "html_url": "https://github.com/rcarmo", "followers_url": "https://api.github.com/users/rcarmo/followers", "following_url": "https://api.github.com/users/rcarmo/following{/other_user}", "gists_url": "https://api.github.com/users/rcarmo/gists{/gist_id}", "starred_url": "https://api.github.com/users/rcarmo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rcarmo/subscriptions", "organizations_url": "https://api.github.com/users/rcarmo/orgs", "repos_url": "https://api.github.com/users/rcarmo/repos", "events_url": "https://api.github.com/users/rcarmo/events{/privacy}", "received_events_url": "https://api.github.com/users/rcarmo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks @rcarmo!\n", "Don't mention it. Tell you what, I'll see if I can add more surgical samples like this - I'm using Peewee for a lot of stuff lately, and have all sorts of little recipes... \n\nOn Jun 11, 2013, at 17:04 , Charles Leifer [email protected] wrote:\n\n> Thanks @rcarmo!\n> \n> —\n> Reply to this email directly or view it on GitHub.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/203/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/203", "html_url": "https://github.com/coleifer/peewee/pull/203", "diff_url": "https://github.com/coleifer/peewee/pull/203.diff", "patch_url": "https://github.com/coleifer/peewee/pull/203.patch", "merged_at": "2013-06-11T16:04:29" }

{ "login": "rcarmo", "id": 392683, "node_id": "MDQ6VXNlcjM5MjY4Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/392683?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rcarmo", "html_url": "https://github.com/rcarmo", "followers_url": "https://api.github.com/users/rcarmo/followers", "following_url": "https://api.github.com/users/rcarmo/following{/other_user}", "gists_url": "https://api.github.com/users/rcarmo/gists{/gist_id}", "starred_url": "https://api.github.com/users/rcarmo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rcarmo/subscriptions", "organizations_url": "https://api.github.com/users/rcarmo/orgs", "repos_url": "https://api.github.com/users/rcarmo/repos", "events_url": "https://api.github.com/users/rcarmo/events{/privacy}", "received_events_url": "https://api.github.com/users/rcarmo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "That's interesting... I know that there are some tests that cover unicode functionality. Can you create a testcase to reproduce this bug?\n", "Erm.. the snippet of code I posted reproduces it on all my machines. That is my testcase, so to speak :)\n\nOn Jun 11, 2013, at 03:48 , Charles Leifer [email protected] wrote:\n\n> That's interesting... I know that there are some tests that cover unicode functionality. Can you create a testcase to reproduce this bug?\n> \n> —\n> Reply to this email directly or view it on GitHub.\n", "I pushed a testcase and was unable to reproduce. From the traceback it looks like the issue might be happening inside psycopg2. What is the encoding of your connection?\n\n``` python\n\n# here is the encoding I have when running the tests\n>>> test_db.get_conn().encoding\n'UTF8'\n```\n", "Mine returns 'SQLASCII', which doesn't make sense - I've tried running my code with the psycopg2 unicode extensions enabled (like jokull added a year back in https://github.com/coleifer/peewee/commit/4a2ba5bd528c1ddd40d79cdd10438f3a5c270c4b) and it still fails.\n\nOn Jun 11, 2013, at 15:11 , Charles Leifer [email protected] wrote:\n\n> I pushed a testcase and was unable to reproduce. From the traceback it looks like the issue might be happening inside psycopg2. What is the encoding of your connection?\n> \n> # here is the encoding I have when running the tests\n> \n> > > > test_db.get_conn().encoding\n> > > > 'UTF8'\n> > > > —\n> > > > Reply to this email directly or view it on GitHub.\n", "Cool, take a look here: http://www.postgresql.org/docs/9.2/static/multibyte.html -- there are a couple solutions:\n- `initdb` when setting up your cluster\n- `createdb` when creating your database\n- `set client encoding`\n", "Hmm. Perhaps this should be added to the docs? The defaults in Ubuntu and Debian are to start with SQL_ASCII.\n\nAnd your tests probably ought to reflect that, since you're testing against a UTF8 cluster - and hence won't spot the general case... :)\n\nOn Jun 11, 2013, at 16:26 , Charles Leifer [email protected] wrote:\n\n> Cool, take a look here: http://www.postgresql.org/docs/9.2/static/multibyte.html -- there are a couple solutions:\n> \n> initdb when setting up your cluster\n> createdb when creating your database\n> set client encoding\n> —\n> Reply to this email directly or view it on GitHub.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/202/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ThomDietrich", "id": 2870104, "node_id": "MDQ6VXNlcjI4NzAxMDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/2870104?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ThomDietrich", "html_url": "https://github.com/ThomDietrich", "followers_url": "https://api.github.com/users/ThomDietrich/followers", "following_url": "https://api.github.com/users/ThomDietrich/following{/other_user}", "gists_url": "https://api.github.com/users/ThomDietrich/gists{/gist_id}", "starred_url": "https://api.github.com/users/ThomDietrich/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ThomDietrich/subscriptions", "organizations_url": "https://api.github.com/users/ThomDietrich/orgs", "repos_url": "https://api.github.com/users/ThomDietrich/repos", "events_url": "https://api.github.com/users/ThomDietrich/events{/privacy}", "received_events_url": "https://api.github.com/users/ThomDietrich/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You can explicitly set the database table name to use:\n\nclass trafficRemaining(MySQLModel):\n customerID = IntegerField(primary_key=True)\n abc = IntegerField()\n\n```\nclass Meta:\n db_table = 'trafficRemaining'\n```\n\nOn Fri, Jun 7, 2013 at 7:24 AM, ThomDietrich [email protected]:\n\n> Hey there,\n> I'm fresh to peewee and am trying to access existing mysql tables of mine.\n> It seems to me as peewee has problems with uppercase letters in table\n> names...\n> \n> My system: Ubuntu 12.04.2, mysql 14.14, python 2.7, peewee 2.1.2\n> \n> class ratelist(MySQLModel):\n> prefix = CharField(primary_key=True)\n> name = CharField()\n> \n> class trafficRemaining(MySQLModel):\n> customerID = IntegerField(primary_key=True)\n> abc = IntegerField()\n> \n> print ratelist.get()\n> <**main**.ratelist object at 0x8a1a56c>\n> \n> print trafficRemaining.get()\n> File \"/usr/local/lib/python2.7/dist-packages/peewee.py\", line 2299, in get\n> return sq.get()\n> File \"/usr/local/lib/python2.7/dist-packages/peewee.py\", line 1602, in get\n> return clone.execute().next()\n> File \"/usr/local/lib/python2.7/dist-packages/peewee.py\", line 1637, in execute\n> self._qr = ResultWrapper(self.model_class, self._execute(), query_meta)\n> File \"/usr/local/lib/python2.7/dist-packages/peewee.py\", line 1395, in _execute\n> return self.database.execute_sql(sql, params, self.require_commit)\n> File \"/usr/local/lib/python2.7/dist-packages/peewee.py\", line 1805, in execute_sql\n> res = cursor.execute(sql, params or ())\n> File \"/usr/lib/python2.7/dist-packages/MySQLdb/cursors.py\", line 174, in execute\n> self.errorhandler(self, exc, value)\n> File \"/usr/lib/python2.7/dist-packages/MySQLdb/connections.py\", line 36, in defaulterrorhandler\n> raise errorclass, errorvalue\n> _mysql_exceptions.ProgrammingError: (1146, \"Table 'mydatabase.trafficremaining' doesn't exist\")\n> \n> As you can see, \"ratelist\" is accessable but \"trafficRemaining\" is\n> converted to lowercase and not found by mysql.\n> \n> Thanks for your work! Greetings\n> \n> —\n> Reply to this email directly or view it on GitHubhttps://github.com/coleifer/peewee/issues/201\n> .\n", "Hey, thanks for your response.\nI think you understood me wrong. The database name is set correctly (in my case \"mydatabase\") and works with table \"ratelist\" but not with \"trafficRemaining\"...\nIn my previous message, pay attention to the last errorline: \"Table 'mydatabase.trafficremaining' doesn't exist\" - this seems to me like a uppercase/lowercase problem...\n-Thomas\n", "Try the code. It sets the db_table not the database.\nOn Jun 10, 2013 7:43 AM, \"ThomDietrich\" [email protected] wrote:\n\n> Hey, thanks for your response.\n> I think you understood me wrong. The database name is set correctly (in my\n> case \"mydatabase\") and works with table \"ratelist\" but not with\n> \"trafficRemaining\"...\n> In my previous message, pay attention to the last errorline: \"Table\n> 'mydatabase.trafficremaining' doesn't exist\" - this seems to me like a\n> uppercase/lowercase problem...\n> -Thomas\n> \n> —\n> Reply to this email directly or view it on GitHubhttps://github.com/coleifer/peewee/issues/201#issuecomment-19196087\n> .\n", "Ah now I see what you did there. Thanks! It works.\nHowever, this does seem like a workaround but not like a the real solution and should be fixed, right?\n\nBest wishes and thanks for your work, Thomas\n", "> However, this does seem like a workaround but not like a the real solution and should be fixed, right?\n\nI'm not sure what you mean \"the real solution\". Did you use `pwiz` to auto-generate your models and it did not create the correct models?\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/201/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kwellman", "id": 279549, "node_id": "MDQ6VXNlcjI3OTU0OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/279549?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kwellman", "html_url": "https://github.com/kwellman", "followers_url": "https://api.github.com/users/kwellman/followers", "following_url": "https://api.github.com/users/kwellman/following{/other_user}", "gists_url": "https://api.github.com/users/kwellman/gists{/gist_id}", "starred_url": "https://api.github.com/users/kwellman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kwellman/subscriptions", "organizations_url": "https://api.github.com/users/kwellman/orgs", "repos_url": "https://api.github.com/users/kwellman/repos", "events_url": "https://api.github.com/users/kwellman/events{/privacy}", "received_events_url": "https://api.github.com/users/kwellman/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/200/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "davidak", "id": 91113, "node_id": "MDQ6VXNlcjkxMTEz", "avatar_url": "https://avatars.githubusercontent.com/u/91113?v=4", "gravatar_id": "", "url": "https://api.github.com/users/davidak", "html_url": "https://github.com/davidak", "followers_url": "https://api.github.com/users/davidak/followers", "following_url": "https://api.github.com/users/davidak/following{/other_user}", "gists_url": "https://api.github.com/users/davidak/gists{/gist_id}", "starred_url": "https://api.github.com/users/davidak/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/davidak/subscriptions", "organizations_url": "https://api.github.com/users/davidak/orgs", "repos_url": "https://api.github.com/users/davidak/repos", "events_url": "https://api.github.com/users/davidak/events{/privacy}", "received_events_url": "https://api.github.com/users/davidak/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Sorry to hear you had trouble with mysqldb. I'm not familiar with the Oracle driver, but there is a python-3 compatible pure python driver which will work automatically with peewee:\n\nhttps://github.com/petehunt/PyMySQL\n\nThe MySQLdb project does not yet support python 3, and in fact peewee just got py3k support a month or two ago. I will add a note to the mysql section of the docs indicating this. To fix your error, uninstall the mysqldb package and try pymysql. Good luck!\n", "Ok, i tested it with pymysql, but get also an error.\nhttps://github.com/petehunt/PyMySQL/issues/151\n\ni have reported it to the developer, but don't get a reaction.\nin his blog he announced, that he will not maintain PyMySQL further.\nhttp://www.petehunt.net/blog/?p=49\n\ni tested SQLAlchemy with the MySQL Connector and it works.\ntheir SQL Expression Language is nice to write and i don't see the advantage of an orm in my small project.\n\nso im using that now and next time i test it on my server before programming 2 nights and it don't work.\nmaybe you can support MySQL Connector if you have the time, but i don't need it anymore.\n", "PyMySQL is under active development again and it supports Python 3:\n\nhttps://github.com/PyMySQL/PyMySQL\n\nI'm using it along with peewee and had no problems so far.\n", "@lecram great to hear and thanks for fixing that bug.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/199/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "rcarmo", "id": 392683, "node_id": "MDQ6VXNlcjM5MjY4Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/392683?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rcarmo", "html_url": "https://github.com/rcarmo", "followers_url": "https://api.github.com/users/rcarmo/followers", "following_url": "https://api.github.com/users/rcarmo/following{/other_user}", "gists_url": "https://api.github.com/users/rcarmo/gists{/gist_id}", "starred_url": "https://api.github.com/users/rcarmo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rcarmo/subscriptions", "organizations_url": "https://api.github.com/users/rcarmo/orgs", "repos_url": "https://api.github.com/users/rcarmo/repos", "events_url": "https://api.github.com/users/rcarmo/events{/privacy}", "received_events_url": "https://api.github.com/users/rcarmo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "It is fairly straightforward to add support for custom fields: http://peewee.readthedocs.org/en/latest/peewee/models.html#creating-a-custom-field\n\nI also added a `DateTimeTZField` to the `playhouse.postgres_ext` module.\n", "Awesome, thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/198/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "dstruck", "id": 2195318, "node_id": "MDQ6VXNlcjIxOTUzMTg=", "avatar_url": "https://avatars.githubusercontent.com/u/2195318?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dstruck", "html_url": "https://github.com/dstruck", "followers_url": "https://api.github.com/users/dstruck/followers", "following_url": "https://api.github.com/users/dstruck/following{/other_user}", "gists_url": "https://api.github.com/users/dstruck/gists{/gist_id}", "starred_url": "https://api.github.com/users/dstruck/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dstruck/subscriptions", "organizations_url": "https://api.github.com/users/dstruck/orgs", "repos_url": "https://api.github.com/users/dstruck/repos", "events_url": "https://api.github.com/users/dstruck/events{/privacy}", "received_events_url": "https://api.github.com/users/dstruck/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Unfortunately, Pwiz does not introspect the size the a VARCHAR field.\n\nAdditionally, in order to not break compatibility with older versions of peewee, the `max_length` attribute defaults to `255`. So the following are equivalent:\n\n``` python\n\nfoo = CharField()\nbar = CharField(max_length=255)\n```\n\nIf you would like to use 3000 characters:\n\n``` python\nbaz = CharField(max_length=3000)\n```\n\nOr even better,\n\n``` python\nbaz = TextField()\n```\n", "Yes, that's what I did finally (CharField to TextField).\n\nIt might be an idea to avert the user that the values have been cut off. Maybe raise an exception?\n", "> Maybe raise an exception?\n\nThat seems like a good plan. Thanks, and sorry for the confusion.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/197/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "wearpants", "id": 505344, "node_id": "MDQ6VXNlcjUwNTM0NA==", "avatar_url": "https://avatars.githubusercontent.com/u/505344?v=4", "gravatar_id": "", "url": "https://api.github.com/users/wearpants", "html_url": "https://github.com/wearpants", "followers_url": "https://api.github.com/users/wearpants/followers", "following_url": "https://api.github.com/users/wearpants/following{/other_user}", "gists_url": "https://api.github.com/users/wearpants/gists{/gist_id}", "starred_url": "https://api.github.com/users/wearpants/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/wearpants/subscriptions", "organizations_url": "https://api.github.com/users/wearpants/orgs", "repos_url": "https://api.github.com/users/wearpants/repos", "events_url": "https://api.github.com/users/wearpants/events{/privacy}", "received_events_url": "https://api.github.com/users/wearpants/received_events", "type": "User", "site_admin": false }

[]

[]

[ "It's back! 0519ac68246a3a73aca9e653c1841183642061fd\n\nI mostly upgraded this from the old code, and still have some cleanups planned so be warned, the API may change a bit!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/196/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "beanyoung", "id": 973789, "node_id": "MDQ6VXNlcjk3Mzc4OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/973789?v=4", "gravatar_id": "", "url": "https://api.github.com/users/beanyoung", "html_url": "https://github.com/beanyoung", "followers_url": "https://api.github.com/users/beanyoung/followers", "following_url": "https://api.github.com/users/beanyoung/following{/other_user}", "gists_url": "https://api.github.com/users/beanyoung/gists{/gist_id}", "starred_url": "https://api.github.com/users/beanyoung/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/beanyoung/subscriptions", "organizations_url": "https://api.github.com/users/beanyoung/orgs", "repos_url": "https://api.github.com/users/beanyoung/repos", "events_url": "https://api.github.com/users/beanyoung/events{/privacy}", "received_events_url": "https://api.github.com/users/beanyoung/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Interesting, I had not heard of dbutils. Thanks for sharing this!\n\nRegarding merging this, a third-party library dependency is not something I want to add to peewee. It might work better as a module in `playhouse`, though -- this is where I've been buliding little extensions to peewee. Another note, if you're wanting to merge in new functionality for peewee, I also like there to be tests and documentation.\n\nThanks again!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/195/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/195", "html_url": "https://github.com/coleifer/peewee/pull/195", "diff_url": "https://github.com/coleifer/peewee/pull/195.diff", "patch_url": "https://github.com/coleifer/peewee/pull/195.patch", "merged_at": null }

{ "login": "rudyryk", "id": 4500, "node_id": "MDQ6VXNlcjQ1MDA=", "avatar_url": "https://avatars.githubusercontent.com/u/4500?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rudyryk", "html_url": "https://github.com/rudyryk", "followers_url": "https://api.github.com/users/rudyryk/followers", "following_url": "https://api.github.com/users/rudyryk/following{/other_user}", "gists_url": "https://api.github.com/users/rudyryk/gists{/gist_id}", "starred_url": "https://api.github.com/users/rudyryk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rudyryk/subscriptions", "organizations_url": "https://api.github.com/users/rudyryk/orgs", "repos_url": "https://api.github.com/users/rudyryk/repos", "events_url": "https://api.github.com/users/rudyryk/events{/privacy}", "received_events_url": "https://api.github.com/users/rudyryk/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks glad you like the library!\n\nUnfortunately, peewee's `PrimaryKeyField` is the only field that will handle auto-incrementing primary keys. If you want to use the BigIntegerField as an auto-incrementing primary key you will need to create a custom field type (probably by subclassing `PrimaryKeyField`):\n\nhttp://peewee.readthedocs.org/en/latest/peewee/models.html#creating-a-custom-field\n\nHowever this technique will not work with SQLite, which looks for columns typed \"INTEGER PRIMARY KEY\" and will use these columns to replace the native `rowid`: http://www.sqlite.org/autoinc.html -- Since the column we'd be adding would be BIGINT PRIMARY KEY Sqlite does not seem to auto-generate the ID (tested this locally).\n\nAlso, I'm also pretty sure that SQLite does not actually treat bigint any different than a regular integer.\n\nThis looks like it has some info on the topic: http://sqlite.1065341.n5.nabble.com/Impossible-to-declare-field-type-BIGINT-PRIMARY-KEY-td44651.html\n\nIf you are using something like Postgresql, you _can_ use a bigint, but you will need to create and specify a sequence to use to auto-generate the IDs. Postgres will auto-create the sequence for `serial` columns, but if you use a bigint you will need to create the sequence by hand.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/194/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "hasenj", "id": 31078, "node_id": "MDQ6VXNlcjMxMDc4", "avatar_url": "https://avatars.githubusercontent.com/u/31078?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hasenj", "html_url": "https://github.com/hasenj", "followers_url": "https://api.github.com/users/hasenj/followers", "following_url": "https://api.github.com/users/hasenj/following{/other_user}", "gists_url": "https://api.github.com/users/hasenj/gists{/gist_id}", "starred_url": "https://api.github.com/users/hasenj/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hasenj/subscriptions", "organizations_url": "https://api.github.com/users/hasenj/orgs", "repos_url": "https://api.github.com/users/hasenj/repos", "events_url": "https://api.github.com/users/hasenj/events{/privacy}", "received_events_url": "https://api.github.com/users/hasenj/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The logic to open and close connections to the database does exactly that -- opens or closes a connection. That is a library operation and one that will not change or be special-cased. If in your application's request setup/teardown you are opening and closing connections, but would like to no-op while testing with an in-memory db, that seems to me like an application operation. It also sounds like your solution is clean, obvious and works well.\n\nLet me know if I'm not fully understanding the issue.\n", "> Let me know if I'm not fully understanding the issue.\n\nHm, well perhaps I'm the one not understanding the issue.\n\nI was expecting `db.connect` to _renew_ connection if it was lost/gone, but not really do anything if the connection is already active. With sqlite's in-memory db, the 'connection' so to speak is probably already active (I'm not sure if I really understand what a connection actually means in this case), hence I wasn't expecting it to restart anything.\n", "@hasenj -- `connect` will explicitly open a connection. If you want to check the state, call `db.is_closed`. Sqlite's in-memory database is unusual in that all data is stored per-connection, so if you want to use it you have to be careful w/your connection handling. I think that falls more under the scope of your application than the scope of peewee itself. Apologies if this was confusing.\n", "Thanks! That clears it up!\n\n> Apologies if this was confusing.\n\nNot at all!\n", "I've just run into this issue. I'm not explicitly calling connect() anywhere so I can't figure out why it's happening\n", "> I've just run into this issue. I'm not explicitly calling connect() anywhere so I can't figure out why it's happening\n\nA connection is opened the first time a query is run, if a connection is not opened already.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/193/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jamorton", "id": 18852, "node_id": "MDQ6VXNlcjE4ODUy", "avatar_url": "https://avatars.githubusercontent.com/u/18852?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jamorton", "html_url": "https://github.com/jamorton", "followers_url": "https://api.github.com/users/jamorton/followers", "following_url": "https://api.github.com/users/jamorton/following{/other_user}", "gists_url": "https://api.github.com/users/jamorton/gists{/gist_id}", "starred_url": "https://api.github.com/users/jamorton/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jamorton/subscriptions", "organizations_url": "https://api.github.com/users/jamorton/orgs", "repos_url": "https://api.github.com/users/jamorton/repos", "events_url": "https://api.github.com/users/jamorton/events{/privacy}", "received_events_url": "https://api.github.com/users/jamorton/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/192/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "haykinson", "id": 31075, "node_id": "MDQ6VXNlcjMxMDc1", "avatar_url": "https://avatars.githubusercontent.com/u/31075?v=4", "gravatar_id": "", "url": "https://api.github.com/users/haykinson", "html_url": "https://github.com/haykinson", "followers_url": "https://api.github.com/users/haykinson/followers", "following_url": "https://api.github.com/users/haykinson/following{/other_user}", "gists_url": "https://api.github.com/users/haykinson/gists{/gist_id}", "starred_url": "https://api.github.com/users/haykinson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/haykinson/subscriptions", "organizations_url": "https://api.github.com/users/haykinson/orgs", "repos_url": "https://api.github.com/users/haykinson/repos", "events_url": "https://api.github.com/users/haykinson/events{/privacy}", "received_events_url": "https://api.github.com/users/haykinson/received_events", "type": "User", "site_admin": false }

[]

[]

[ "If you are using MySQL first be sure you are using InnoDB, as MyISAM does not support transactions:\n\nhttp://dev.mysql.com/doc/refman/5.0/en/ansi-diff-transactions.html\n\nSecondly, peewee will not explicitly execute 'begin', 'commit' SQL -- rather it will call the appropriate methods on the db driver. For example `database.commit()`, `database.rollback()`.\n", "which is much better for peewee transaction:\ndatabase.begin, database.commit()\nvs\nwith database.transaction:\n", "It doesn't matter, whichever you prefer.\n", "Thanks! \nAnother question:\ndid peewee place objects into cache for later use?\nthat means get a object from database at the first time and put it into cache, later will get from cache if it exists in cache. \n", "Peewee will cache the results of select queries so that multiple iterations do not cause multiple queries, but other than that there is no caching.\n\n@bakerchen -- if you have questions, for future reference, please use either the [google group](http://groups.google.com/group/peewee-orm) or the #peewee channel on freenode.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/191/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "diffused", "id": 32428, "node_id": "MDQ6VXNlcjMyNDI4", "avatar_url": "https://avatars.githubusercontent.com/u/32428?v=4", "gravatar_id": "", "url": "https://api.github.com/users/diffused", "html_url": "https://github.com/diffused", "followers_url": "https://api.github.com/users/diffused/followers", "following_url": "https://api.github.com/users/diffused/following{/other_user}", "gists_url": "https://api.github.com/users/diffused/gists{/gist_id}", "starred_url": "https://api.github.com/users/diffused/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/diffused/subscriptions", "organizations_url": "https://api.github.com/users/diffused/orgs", "repos_url": "https://api.github.com/users/diffused/repos", "events_url": "https://api.github.com/users/diffused/events{/privacy}", "received_events_url": "https://api.github.com/users/diffused/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Dang, does that \"just work\" ?\n", "So you are missing code to register the field with the database class -- db_field should be \"textarray\" and then you register the type \"textarray\" with \"Text[]\".\n\nI tested this myself and got it working, but because peewee doesn't support (yet) any interesting array operations, I am not going to include this example for now as it might lead people to believe that peewee supports PG array operations.\n", "Cheers for the tip. Yeah was pretty neat it just worked. \nLooking forward to the updates. \n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/190/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/190", "html_url": "https://github.com/coleifer/peewee/pull/190", "diff_url": "https://github.com/coleifer/peewee/pull/190.diff", "patch_url": "https://github.com/coleifer/peewee/pull/190.patch", "merged_at": null }

{ "login": "erkurita", "id": 240697, "node_id": "MDQ6VXNlcjI0MDY5Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/240697?v=4", "gravatar_id": "", "url": "https://api.github.com/users/erkurita", "html_url": "https://github.com/erkurita", "followers_url": "https://api.github.com/users/erkurita/followers", "following_url": "https://api.github.com/users/erkurita/following{/other_user}", "gists_url": "https://api.github.com/users/erkurita/gists{/gist_id}", "starred_url": "https://api.github.com/users/erkurita/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/erkurita/subscriptions", "organizations_url": "https://api.github.com/users/erkurita/orgs", "repos_url": "https://api.github.com/users/erkurita/repos", "events_url": "https://api.github.com/users/erkurita/events{/privacy}", "received_events_url": "https://api.github.com/users/erkurita/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for reporting!\n", "@coleifer, I guess that's more elegant (and solves the problem too):\n\n```\ndiff --git a/pwiz.py b/pwiz.py\nindex d20ebf5..5c61d21 100755\n--- a/pwiz.py\n+++ b/pwiz.py\n@@ -308,8 +308,8 @@ def introspect(db, schema=None):\n for table in tables:\n col_meta[table] = {}\n for column, rel_table, rel_pk in table_fks[table]:\n- models[table][column][0] = ForeignKeyField\n- models[rel_table][rel_pk][0] = PrimaryKeyField\n+ models[table][column] = (ForeignKeyField, models[table][column][1])\n+ models[rel_table][rel_pk] = (PrimaryKeyField, models[rel_table][rel_pk][1])\n if rel_table == table:\n ttm = \"'self'\"\n else:\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/189/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bwghughes", "id": 7694, "node_id": "MDQ6VXNlcjc2OTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/7694?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bwghughes", "html_url": "https://github.com/bwghughes", "followers_url": "https://api.github.com/users/bwghughes/followers", "following_url": "https://api.github.com/users/bwghughes/following{/other_user}", "gists_url": "https://api.github.com/users/bwghughes/gists{/gist_id}", "starred_url": "https://api.github.com/users/bwghughes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bwghughes/subscriptions", "organizations_url": "https://api.github.com/users/bwghughes/orgs", "repos_url": "https://api.github.com/users/bwghughes/repos", "events_url": "https://api.github.com/users/bwghughes/events{/privacy}", "received_events_url": "https://api.github.com/users/bwghughes/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for the excellent bug report. I think I need to clarify the docs a bit -- `RawQuery` was meant to be used for expressing `SELECT` statements. RawQuery is there to give you a way to specify any select statement and _return model instances_.\n\nIf you just want to execute some plain old SQL, try:\n\n``` python\n\n# assume somewhere you have a db defined\ndatabase = PostgresqlDatabase('something')\n\n# ... later ...\nsql = \"COPY uk_towns FROM '{}' DELIMITERS ',' CSV HEADER\".format(towns_file)\nres = database.execute_sql(sql)\n```\n", "Grand - thanks for the clarification - its abit if an edge case. As I said before I lurrrrve Peewee Thanks !! :)) \n", "Thanks! So glad to hear that. I'm pushing an update to the docs in a few moments that should hopefully clear this up for the next person who runs into it.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/188/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "dmwyatt", "id": 163359, "node_id": "MDQ6VXNlcjE2MzM1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/163359?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dmwyatt", "html_url": "https://github.com/dmwyatt", "followers_url": "https://api.github.com/users/dmwyatt/followers", "following_url": "https://api.github.com/users/dmwyatt/following{/other_user}", "gists_url": "https://api.github.com/users/dmwyatt/gists{/gist_id}", "starred_url": "https://api.github.com/users/dmwyatt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dmwyatt/subscriptions", "organizations_url": "https://api.github.com/users/dmwyatt/orgs", "repos_url": "https://api.github.com/users/dmwyatt/repos", "events_url": "https://api.github.com/users/dmwyatt/events{/privacy}", "received_events_url": "https://api.github.com/users/dmwyatt/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I don't blame you for being a bit confused... SQLite's `LIKE` operator is case-insensitive by default. To get case-sensitive matching, peewee uses the SQLite `GLOB` operator instead, which uses \"*\" as wildcards.\n\nSo -- if you want case-insensitive matching, use ILIKE (peewee expresses this as `**`) with \"%\" wildcards. If you want case-sensitive, use LIKE (peewee expresses this as `%`) with \"*\" wildcards. Confusing, right?\n\nHopefully this will clarify things:\n\n```\nsqlite> create table movie (title varchar(255));\nsqlite> insert into movie (title) values ('Iron Man');\nsqlite> insert into movie (title) values ('Wreck-It Ralph');\nsqlite> select * from movie where title like '%i%';\nIron Man\nWreck-It Ralph\nsqlite> select * from movie where title like '%I%';\nIron Man\nWreck-It Ralph\nsqlite> select * from movie where title glob '*i*';\nsqlite> select * from movie where title glob '*I*';\nIron Man\nWreck-It Ralph\n```\n\nI will add a note to the documentation on this.\n", "Added note: http://peewee.readthedocs.org/en/latest/peewee/querying.html#column-lookups\n", "This behavior got me too (before I looked at the output, noticed it was using GLOB with SQLite, then saw the note in the docs). It seems quite surprising, and would mean if you change your code to use `field % 'whatever*'` to work with SQLite, then if you switch to PostgreSQL it'll break.\n\nI think it'd be more cross-database compatible and less surprising if the `%` operator on SQLite changed the `%`'s in your match string to `*` as well as using `GLOB`, so you didn't have to worry about which database you were on. Thoughts?\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/187/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "niedbalski", "id": 821670, "node_id": "MDQ6VXNlcjgyMTY3MA==", "avatar_url": "https://avatars.githubusercontent.com/u/821670?v=4", "gravatar_id": "", "url": "https://api.github.com/users/niedbalski", "html_url": "https://github.com/niedbalski", "followers_url": "https://api.github.com/users/niedbalski/followers", "following_url": "https://api.github.com/users/niedbalski/following{/other_user}", "gists_url": "https://api.github.com/users/niedbalski/gists{/gist_id}", "starred_url": "https://api.github.com/users/niedbalski/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/niedbalski/subscriptions", "organizations_url": "https://api.github.com/users/niedbalski/orgs", "repos_url": "https://api.github.com/users/niedbalski/repos", "events_url": "https://api.github.com/users/niedbalski/events{/privacy}", "received_events_url": "https://api.github.com/users/niedbalski/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You can actually use python's `reduce` function to generate dynamic lists of OR-ed together clauses.\n\n``` python\n\nimport operator\nor_conditions = reduce(operator.or_, conditions)\nq = q.where(or_conditions)\n```\n", "OK, But now you are forcing the AND operator on WHERE conditions. Why you cannot expose this as a parameter?\n", "Yes, this was a design decision that I made early on that multiple calls to `.where()` would be `AND-ed` together. That does not mean you cannot dynamically generate query trees that will `OR` things together, it just means you will use a different API than multiple calls to `.where()`.\n", "I can see that your solution looks more compact but less self explanatory . Maybe is a good idea to reflect on the documentation that multiple .where() conditions will be AND-ed by default. I had to debug the code before to understand why this happened. \n\nThanks you for your time!\n", "Cheers, yeah I did document this but it's buried in a note: http://peewee.readthedocs.org/en/latest/peewee/api.html#Query.where\n\nI will make it more clear and also present a way to \"OR\" parts together dynamically.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/186/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/186", "html_url": "https://github.com/coleifer/peewee/pull/186", "diff_url": "https://github.com/coleifer/peewee/pull/186.diff", "patch_url": "https://github.com/coleifer/peewee/pull/186.patch", "merged_at": null }

{ "login": "moraes", "id": 3164, "node_id": "MDQ6VXNlcjMxNjQ=", "avatar_url": "https://avatars.githubusercontent.com/u/3164?v=4", "gravatar_id": "", "url": "https://api.github.com/users/moraes", "html_url": "https://github.com/moraes", "followers_url": "https://api.github.com/users/moraes/followers", "following_url": "https://api.github.com/users/moraes/following{/other_user}", "gists_url": "https://api.github.com/users/moraes/gists{/gist_id}", "starred_url": "https://api.github.com/users/moraes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/moraes/subscriptions", "organizations_url": "https://api.github.com/users/moraes/orgs", "repos_url": "https://api.github.com/users/moraes/repos", "events_url": "https://api.github.com/users/moraes/events{/privacy}", "received_events_url": "https://api.github.com/users/moraes/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I must use PrimaryKeyField. Dooh. Sorry for being so stupid.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/185/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I believe this is fixed in 525f1ee884155d\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/184/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "moraes", "id": 3164, "node_id": "MDQ6VXNlcjMxNjQ=", "avatar_url": "https://avatars.githubusercontent.com/u/3164?v=4", "gravatar_id": "", "url": "https://api.github.com/users/moraes", "html_url": "https://github.com/moraes", "followers_url": "https://api.github.com/users/moraes/followers", "following_url": "https://api.github.com/users/moraes/following{/other_user}", "gists_url": "https://api.github.com/users/moraes/gists{/gist_id}", "starred_url": "https://api.github.com/users/moraes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/moraes/subscriptions", "organizations_url": "https://api.github.com/users/moraes/orgs", "repos_url": "https://api.github.com/users/moraes/repos", "events_url": "https://api.github.com/users/moraes/events{/privacy}", "received_events_url": "https://api.github.com/users/moraes/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hmm...I wonder where a good place would be to put this information? Having not tested cloud sql myself I'm reluctant to add something like this to \"playhouse\", but it does seem like useful information to put somewhere...Maybe I'll add a new section to the docs.\n", "http://peewee.readthedocs.org/en/latest/peewee/database.html#peewee-and-other-databases\n\nThanks @moraes \n", "Google recommends using MySQLdb over their rdms driver whenever possible. See this page of their documentation: https://developers.google.com/appengine/docs/python/cloud-sql/ Below is what I ended up doing to get peewee to work in both development and production. Along with the changes in my fork of peewee.\n\n```\nif (os.getenv('SERVER_SOFTWARE') and\n os.getenv('SERVER_SOFTWARE').startswith('Google App Engine/')):\n db = MySQLDatabase('<db_name>', unix_socket='/cloudsql/<instance_name>', user='root')\nelse:\n db = MySQLDatabase('<db_name>', user='user', passwd='password')\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/183/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "niedbalski", "id": 821670, "node_id": "MDQ6VXNlcjgyMTY3MA==", "avatar_url": "https://avatars.githubusercontent.com/u/821670?v=4", "gravatar_id": "", "url": "https://api.github.com/users/niedbalski", "html_url": "https://github.com/niedbalski", "followers_url": "https://api.github.com/users/niedbalski/followers", "following_url": "https://api.github.com/users/niedbalski/following{/other_user}", "gists_url": "https://api.github.com/users/niedbalski/gists{/gist_id}", "starred_url": "https://api.github.com/users/niedbalski/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/niedbalski/subscriptions", "organizations_url": "https://api.github.com/users/niedbalski/orgs", "repos_url": "https://api.github.com/users/niedbalski/repos", "events_url": "https://api.github.com/users/niedbalski/events{/privacy}", "received_events_url": "https://api.github.com/users/niedbalski/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I think the correct fix is to make the INSERT generation smarter, I've been aware of this issue for a while but it only crops up with models consisting of a single auto-incrementing primary key. I'm not sure why anyone would have a model like that, so I haven't bothered to fix it yet.\n", "Hello Coleifer,\n\nMy impression is that to have a forced incremental ID is not a good idea because you can have tables without primary keys.\n\nMy patch is just a cosmetic change that guarantees that an AttributeError is raised just in the case of no fields are modified before save the entity.\n", "To clarify, the autoincrement id is not forced but is just the default.\n\nI fixed the issue by making the insert statement generation a bit smarter, thanks for bringing this issue to my attention.\n", "Super, thanks you for your work!.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/182/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/182", "html_url": "https://github.com/coleifer/peewee/pull/182", "diff_url": "https://github.com/coleifer/peewee/pull/182.diff", "patch_url": "https://github.com/coleifer/peewee/pull/182.patch", "merged_at": null }

{ "login": "niedbalski", "id": 821670, "node_id": "MDQ6VXNlcjgyMTY3MA==", "avatar_url": "https://avatars.githubusercontent.com/u/821670?v=4", "gravatar_id": "", "url": "https://api.github.com/users/niedbalski", "html_url": "https://github.com/niedbalski", "followers_url": "https://api.github.com/users/niedbalski/followers", "following_url": "https://api.github.com/users/niedbalski/following{/other_user}", "gists_url": "https://api.github.com/users/niedbalski/gists{/gist_id}", "starred_url": "https://api.github.com/users/niedbalski/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/niedbalski/subscriptions", "organizations_url": "https://api.github.com/users/niedbalski/orgs", "repos_url": "https://api.github.com/users/niedbalski/repos", "events_url": "https://api.github.com/users/niedbalski/events{/privacy}", "received_events_url": "https://api.github.com/users/niedbalski/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/181/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/181", "html_url": "https://github.com/coleifer/peewee/pull/181", "diff_url": "https://github.com/coleifer/peewee/pull/181.diff", "patch_url": "https://github.com/coleifer/peewee/pull/181.patch", "merged_at": "2013-04-24T16:10:39" }

{ "login": "tax", "id": 97768, "node_id": "MDQ6VXNlcjk3NzY4", "avatar_url": "https://avatars.githubusercontent.com/u/97768?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tax", "html_url": "https://github.com/tax", "followers_url": "https://api.github.com/users/tax/followers", "following_url": "https://api.github.com/users/tax/following{/other_user}", "gists_url": "https://api.github.com/users/tax/gists{/gist_id}", "starred_url": "https://api.github.com/users/tax/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tax/subscriptions", "organizations_url": "https://api.github.com/users/tax/orgs", "repos_url": "https://api.github.com/users/tax/repos", "events_url": "https://api.github.com/users/tax/events{/privacy}", "received_events_url": "https://api.github.com/users/tax/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@tax, thank you for your message and the PR, I'm glad you're liking using \"peewee\".\n\nThe KeyError is intentional -- I think its better to raise an exception than not insert/update something because the user made a typo.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/180/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/180", "html_url": "https://github.com/coleifer/peewee/pull/180", "diff_url": "https://github.com/coleifer/peewee/pull/180.diff", "patch_url": "https://github.com/coleifer/peewee/pull/180.patch", "merged_at": null }

{ "login": "henrikstroem", "id": 907338, "node_id": "MDQ6VXNlcjkwNzMzOA==", "avatar_url": "https://avatars.githubusercontent.com/u/907338?v=4", "gravatar_id": "", "url": "https://api.github.com/users/henrikstroem", "html_url": "https://github.com/henrikstroem", "followers_url": "https://api.github.com/users/henrikstroem/followers", "following_url": "https://api.github.com/users/henrikstroem/following{/other_user}", "gists_url": "https://api.github.com/users/henrikstroem/gists{/gist_id}", "starred_url": "https://api.github.com/users/henrikstroem/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/henrikstroem/subscriptions", "organizations_url": "https://api.github.com/users/henrikstroem/orgs", "repos_url": "https://api.github.com/users/henrikstroem/repos", "events_url": "https://api.github.com/users/henrikstroem/events{/privacy}", "received_events_url": "https://api.github.com/users/henrikstroem/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Rather than implementing this as a part of peewee, feel free to subclass `Model` and implement it yourself.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/179/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ibraaaa", "id": 4008455, "node_id": "MDQ6VXNlcjQwMDg0NTU=", "avatar_url": "https://avatars.githubusercontent.com/u/4008455?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ibraaaa", "html_url": "https://github.com/ibraaaa", "followers_url": "https://api.github.com/users/ibraaaa/followers", "following_url": "https://api.github.com/users/ibraaaa/following{/other_user}", "gists_url": "https://api.github.com/users/ibraaaa/gists{/gist_id}", "starred_url": "https://api.github.com/users/ibraaaa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ibraaaa/subscriptions", "organizations_url": "https://api.github.com/users/ibraaaa/orgs", "repos_url": "https://api.github.com/users/ibraaaa/repos", "events_url": "https://api.github.com/users/ibraaaa/events{/privacy}", "received_events_url": "https://api.github.com/users/ibraaaa/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I can appreciate the confusion this problem may cause, but this is not within the scope of peewee which is just an ORM.\n\nCheck out http://dev.mysql.com/doc/refman/5.0/en/charset-database.html if you want to set the charset for your database.\n", "When the peewee create table it sets the charset as latin1_swedish_ci. so when data insert to table it scramble the data.\nso it need a way to change column charset\n", "You can also:\n\n```\ndb = MySQLDatabase(...)\ndb.execute_sql(\"SET NAMES utf8mb4 COLLATE utf8mb4_unicode_ci;\")\n```\n\nBeyond that I'm not familiar enough with MySQL to be able to advise you what parameters or settings to modify. Consult the docs or try stackoverflow if you are still stuck.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/178/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "andmart", "id": 303252, "node_id": "MDQ6VXNlcjMwMzI1Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/303252?v=4", "gravatar_id": "", "url": "https://api.github.com/users/andmart", "html_url": "https://github.com/andmart", "followers_url": "https://api.github.com/users/andmart/followers", "following_url": "https://api.github.com/users/andmart/following{/other_user}", "gists_url": "https://api.github.com/users/andmart/gists{/gist_id}", "starred_url": "https://api.github.com/users/andmart/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/andmart/subscriptions", "organizations_url": "https://api.github.com/users/andmart/orgs", "repos_url": "https://api.github.com/users/andmart/repos", "events_url": "https://api.github.com/users/andmart/events{/privacy}", "received_events_url": "https://api.github.com/users/andmart/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Unfortunately, peewee does not support modulo out of the box (because I ran out of operators to overload).\n\nYou can create your own operators, though...perhaps I should add this to the docs. There are some cool examples in `playhouse.postgresql_ext` where I add operators for various hstore functions. Here's how you do modulo and regexp:\n\n``` python\n\nfrom peewee import *\nfrom peewee import Expr\n\ndef mod(lhs, rhs):\n return Expr(lhs, 'mod', rhs)\n\ndef regexp(lhs, rhs):\n return Expr(lhs, 're', rhs)\n\n# tell sqlite what to do with these expressions\nSqliteDatabase.register_ops({'mod': '%', 're': 'REGEXP'})\n\nclass User(Model):\n username = CharField()\n\n# users whose username is all numbers\nUser.select().where(regexp(User.username, '[0-9]+')\n\n# users with even ids\nUser.select().where(mod(User.id, 2) == 0)\n```\n", "Docs: http://peewee.readthedocs.org/en/latest/peewee/querying.html#adding-user-defined-operators\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/177/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "farialima", "id": 1914172, "node_id": "MDQ6VXNlcjE5MTQxNzI=", "avatar_url": "https://avatars.githubusercontent.com/u/1914172?v=4", "gravatar_id": "", "url": "https://api.github.com/users/farialima", "html_url": "https://github.com/farialima", "followers_url": "https://api.github.com/users/farialima/followers", "following_url": "https://api.github.com/users/farialima/following{/other_user}", "gists_url": "https://api.github.com/users/farialima/gists{/gist_id}", "starred_url": "https://api.github.com/users/farialima/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/farialima/subscriptions", "organizations_url": "https://api.github.com/users/farialima/orgs", "repos_url": "https://api.github.com/users/farialima/repos", "events_url": "https://api.github.com/users/farialima/events{/privacy}", "received_events_url": "https://api.github.com/users/farialima/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Ah, thanks -- I will clarify that if statement!\n", "aren't there a few other places where a similar fix would be needed ?\n", "Curious, how would you use peewee to inherit from dict, and then use it as a dict?\n\nI tried farialima's model but standard dict features didn't work.\n\nI have a need to use the DB as a dict, and am not seeing it :)\n", "http://peewee.readthedocs.org/en/latest/peewee/playhouse.html#key-value-store\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/176/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "henrikstroem", "id": 907338, "node_id": "MDQ6VXNlcjkwNzMzOA==", "avatar_url": "https://avatars.githubusercontent.com/u/907338?v=4", "gravatar_id": "", "url": "https://api.github.com/users/henrikstroem", "html_url": "https://github.com/henrikstroem", "followers_url": "https://api.github.com/users/henrikstroem/followers", "following_url": "https://api.github.com/users/henrikstroem/following{/other_user}", "gists_url": "https://api.github.com/users/henrikstroem/gists{/gist_id}", "starred_url": "https://api.github.com/users/henrikstroem/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/henrikstroem/subscriptions", "organizations_url": "https://api.github.com/users/henrikstroem/orgs", "repos_url": "https://api.github.com/users/henrikstroem/repos", "events_url": "https://api.github.com/users/henrikstroem/events{/privacy}", "received_events_url": "https://api.github.com/users/henrikstroem/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Primary keys are not being inherited correctly -- I will look into it and thank you for the excellent bug report!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/175/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coryalder", "id": 135608, "node_id": "MDQ6VXNlcjEzNTYwOA==", "avatar_url": "https://avatars.githubusercontent.com/u/135608?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coryalder", "html_url": "https://github.com/coryalder", "followers_url": "https://api.github.com/users/coryalder/followers", "following_url": "https://api.github.com/users/coryalder/following{/other_user}", "gists_url": "https://api.github.com/users/coryalder/gists{/gist_id}", "starred_url": "https://api.github.com/users/coryalder/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coryalder/subscriptions", "organizations_url": "https://api.github.com/users/coryalder/orgs", "repos_url": "https://api.github.com/users/coryalder/repos", "events_url": "https://api.github.com/users/coryalder/events{/privacy}", "received_events_url": "https://api.github.com/users/coryalder/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Wow, thanks for reporting. I'll try and get a look at this tonight.\n", "Should be fixed in 92aec9da99f4fe8bf23ffed4cf9dc8b5971e4b4a\n", "Confirmed!\n\nThanks so much\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/174/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ghost", "id": 10137, "node_id": "MDQ6VXNlcjEwMTM3", "avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ghost", "html_url": "https://github.com/ghost", "followers_url": "https://api.github.com/users/ghost/followers", "following_url": "https://api.github.com/users/ghost/following{/other_user}", "gists_url": "https://api.github.com/users/ghost/gists{/gist_id}", "starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ghost/subscriptions", "organizations_url": "https://api.github.com/users/ghost/orgs", "repos_url": "https://api.github.com/users/ghost/repos", "events_url": "https://api.github.com/users/ghost/events{/privacy}", "received_events_url": "https://api.github.com/users/ghost/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Can you get into more detail? What kind of issues are you seeing.\n", "We were creating the DB connection object in the model.py class and then\nimporting it the same in the parent and child process. So it wasn't a\nconnection issue but rather a shared object/namespace issue in Python with\nmultiprocessing. We were hitting a 'commands out of sync' error from MySQL.\nWe ended up just making a model for the parent and a model for the child\nprocess. This is messy and not the proper way for a fix but it works.\nIdeally we would like to instantiate the model class instead of importing\nit and move the connection to the main class within model. For instance:\n\n#####\nImport model as dbm\n\nmodel_obj = dbm.MasterModel()\n#MasterModel would contain the connection obj\nuser = model_obj.User.get()\n#####\n\nHowever we had limited success building that. It's likely an issue with my\nunderstanding of class construction rather than an issue with Peewee.\n\nOn Friday, March 22, 2013, Charles Leifer wrote:\n\n> Can you get into more detail? What kind of issues are you seeing.\n> \n> —\n> Reply to this email directly or view it on GitHubhttps://github.com/coleifer/peewee/issues/173#issuecomment-15281333\n> .\n", "Unfortunately I still am not clear on what exactly happens. Can you give me some code to replicate it? Are you using the multiprocessing library and passing model instances around, or are you just calling fork?\n\nThe way that peewee handles the DB connection is pretty straightforward. It is stored in a threadlocal (or a dummy threadlocal) on the database instance. You can open a connection explicitly by calling `db.connect()` or you can open one implicitly when you execute a query.\n", "@zahlenofzahlen -- please update so I can resolve or close.\n", "Closing -- please reopen if you can provide me a bit more info!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/173/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "sYnfo", "id": 1011548, "node_id": "MDQ6VXNlcjEwMTE1NDg=", "avatar_url": "https://avatars.githubusercontent.com/u/1011548?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sYnfo", "html_url": "https://github.com/sYnfo", "followers_url": "https://api.github.com/users/sYnfo/followers", "following_url": "https://api.github.com/users/sYnfo/following{/other_user}", "gists_url": "https://api.github.com/users/sYnfo/gists{/gist_id}", "starred_url": "https://api.github.com/users/sYnfo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sYnfo/subscriptions", "organizations_url": "https://api.github.com/users/sYnfo/orgs", "repos_url": "https://api.github.com/users/sYnfo/repos", "events_url": "https://api.github.com/users/sYnfo/events{/privacy}", "received_events_url": "https://api.github.com/users/sYnfo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you! I was wondering, could you please update the pypi package with these? I would like to make a rpm package out of this and that would greatly simplify things for me.\n", "v2.0.9 pushed!\n", "Thank you :)\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/172/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/172", "html_url": "https://github.com/coleifer/peewee/pull/172", "diff_url": "https://github.com/coleifer/peewee/pull/172.diff", "patch_url": "https://github.com/coleifer/peewee/pull/172.patch", "merged_at": "2013-03-22T04:56:10" }

{ "login": "sYnfo", "id": 1011548, "node_id": "MDQ6VXNlcjEwMTE1NDg=", "avatar_url": "https://avatars.githubusercontent.com/u/1011548?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sYnfo", "html_url": "https://github.com/sYnfo", "followers_url": "https://api.github.com/users/sYnfo/followers", "following_url": "https://api.github.com/users/sYnfo/following{/other_user}", "gists_url": "https://api.github.com/users/sYnfo/gists{/gist_id}", "starred_url": "https://api.github.com/users/sYnfo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sYnfo/subscriptions", "organizations_url": "https://api.github.com/users/sYnfo/orgs", "repos_url": "https://api.github.com/users/sYnfo/repos", "events_url": "https://api.github.com/users/sYnfo/events{/privacy}", "received_events_url": "https://api.github.com/users/sYnfo/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/171/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/171", "html_url": "https://github.com/coleifer/peewee/pull/171", "diff_url": "https://github.com/coleifer/peewee/pull/171.diff", "patch_url": "https://github.com/coleifer/peewee/pull/171.patch", "merged_at": "2013-03-22T04:55:59" }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Fixed\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/170/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "beanyoung", "id": 973789, "node_id": "MDQ6VXNlcjk3Mzc4OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/973789?v=4", "gravatar_id": "", "url": "https://api.github.com/users/beanyoung", "html_url": "https://github.com/beanyoung", "followers_url": "https://api.github.com/users/beanyoung/followers", "following_url": "https://api.github.com/users/beanyoung/following{/other_user}", "gists_url": "https://api.github.com/users/beanyoung/gists{/gist_id}", "starred_url": "https://api.github.com/users/beanyoung/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/beanyoung/subscriptions", "organizations_url": "https://api.github.com/users/beanyoung/orgs", "repos_url": "https://api.github.com/users/beanyoung/repos", "events_url": "https://api.github.com/users/beanyoung/events{/privacy}", "received_events_url": "https://api.github.com/users/beanyoung/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for your question -- at this time I have no plans to include this as part of peewee. Typically I've seen connection pooling done upstream, e.g. pgpool/pgbouncer. To be completely honest, I have not done the research necessary to build a robust connection pool -- if at some point i did add this i'd probably put it in the playhouse module, though.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/169/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jhorman", "id": 323697, "node_id": "MDQ6VXNlcjMyMzY5Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/323697?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jhorman", "html_url": "https://github.com/jhorman", "followers_url": "https://api.github.com/users/jhorman/followers", "following_url": "https://api.github.com/users/jhorman/following{/other_user}", "gists_url": "https://api.github.com/users/jhorman/gists{/gist_id}", "starred_url": "https://api.github.com/users/jhorman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jhorman/subscriptions", "organizations_url": "https://api.github.com/users/jhorman/orgs", "repos_url": "https://api.github.com/users/jhorman/repos", "events_url": "https://api.github.com/users/jhorman/events{/privacy}", "received_events_url": "https://api.github.com/users/jhorman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I believe this is correct, if somewhat odd, behavior. I'm going to mark this as wontfix for now.\n", "To my understanding, the contract is that if you are going to populate a model, you will call \"prepared\" on it. The idea that sometimes a model I use will have prepared called, and sometimes not, sort of makes prepared broken/untrustworthy to use.\n", "Yeah... you're right. I'll look into it.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/168/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jhorman", "id": 323697, "node_id": "MDQ6VXNlcjMyMzY5Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/323697?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jhorman", "html_url": "https://github.com/jhorman", "followers_url": "https://api.github.com/users/jhorman/followers", "following_url": "https://api.github.com/users/jhorman/following{/other_user}", "gists_url": "https://api.github.com/users/jhorman/gists{/gist_id}", "starred_url": "https://api.github.com/users/jhorman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jhorman/subscriptions", "organizations_url": "https://api.github.com/users/jhorman/orgs", "repos_url": "https://api.github.com/users/jhorman/repos", "events_url": "https://api.github.com/users/jhorman/events{/privacy}", "received_events_url": "https://api.github.com/users/jhorman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you for pointing this out, I will address this\n", "You know, I tried to replicate this issue and was not seeing the same problem... can you give any more specifics?\n\n``` python\n\nusers = User.select().order_by(User.username.desc(), User.id.desc())\nipdb> users\n<class 'tests.User'> SELECT t1.\"id\", t1.\"username\" FROM \"users\" AS t1 ORDER BY t1.\"username\" DESC, t1.\"id\" DESC []\n```\n\nIf you have an example that is failing that might help me figure out where the problem is.\n", "You're right. My example wasn't exactly what I was doing but I assumed it was the same. I am doing\n\n```\nusers = User.select().order_by([User.username.desc(), User.id.desc()])\n```\n\nI am doing it this way b/c in my use case I am assembling a list of order bys.\n", "I could do \n\n```\nUser.select().order_by(*[User.username.desc(), User.id.desc()])\n```\n\nto expand the array into the parameter list I guess.\n", "FYI, I also in my journey tried\n\n```\nUser.select().order_by(User.username.desc() & User.id.desc())\n```\n\nWhich results in parens as well. \n\nThis is the wrong way to do it anyway since it is joined with an AND.\n\n```\nORDER BY (t1.\"username\" DESC AND t1.\"id\" DESC)\n```\n", "Yes, the examples you've provided can result in invalid SQL - peewee won't stop you from doing this, however I think the documentation is pretty clear:\n\nhttp://peewee.readthedocs.org/en/latest/peewee/api.html#SelectQuery.order_by\n\nI'm gonna go ahead and close this as it is working as I intended\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/167/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "rammie", "id": 554792, "node_id": "MDQ6VXNlcjU1NDc5Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/554792?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rammie", "html_url": "https://github.com/rammie", "followers_url": "https://api.github.com/users/rammie/followers", "following_url": "https://api.github.com/users/rammie/following{/other_user}", "gists_url": "https://api.github.com/users/rammie/gists{/gist_id}", "starred_url": "https://api.github.com/users/rammie/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rammie/subscriptions", "organizations_url": "https://api.github.com/users/rammie/orgs", "repos_url": "https://api.github.com/users/rammie/repos", "events_url": "https://api.github.com/users/rammie/events{/privacy}", "received_events_url": "https://api.github.com/users/rammie/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you :)\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/166/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "mgalgs", "id": 152014, "node_id": "MDQ6VXNlcjE1MjAxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/152014?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mgalgs", "html_url": "https://github.com/mgalgs", "followers_url": "https://api.github.com/users/mgalgs/followers", "following_url": "https://api.github.com/users/mgalgs/following{/other_user}", "gists_url": "https://api.github.com/users/mgalgs/gists{/gist_id}", "starred_url": "https://api.github.com/users/mgalgs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mgalgs/subscriptions", "organizations_url": "https://api.github.com/users/mgalgs/orgs", "repos_url": "https://api.github.com/users/mgalgs/repos", "events_url": "https://api.github.com/users/mgalgs/events{/privacy}", "received_events_url": "https://api.github.com/users/mgalgs/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you for catching this!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/165/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/165", "html_url": "https://github.com/coleifer/peewee/pull/165", "diff_url": "https://github.com/coleifer/peewee/pull/165.diff", "patch_url": "https://github.com/coleifer/peewee/pull/165.patch", "merged_at": "2013-02-21T15:05:56" }

{ "login": "Pacek", "id": 234758, "node_id": "MDQ6VXNlcjIzNDc1OA==", "avatar_url": "https://avatars.githubusercontent.com/u/234758?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Pacek", "html_url": "https://github.com/Pacek", "followers_url": "https://api.github.com/users/Pacek/followers", "following_url": "https://api.github.com/users/Pacek/following{/other_user}", "gists_url": "https://api.github.com/users/Pacek/gists{/gist_id}", "starred_url": "https://api.github.com/users/Pacek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Pacek/subscriptions", "organizations_url": "https://api.github.com/users/Pacek/orgs", "repos_url": "https://api.github.com/users/Pacek/repos", "events_url": "https://api.github.com/users/Pacek/events{/privacy}", "received_events_url": "https://api.github.com/users/Pacek/received_events", "type": "User", "site_admin": false }

[]

[]

[ "If the list of ids is ordered, then you can simply do:\n\n``` python\n\nMyModel.select().where(MyModel.id << list_of_ids).order_by(MyModel.id)\n```\n\nIf the ordering is arbitrary, then you could write a helper like this:\n\n``` python\n\ndef sort_by_id(query, id_list):\n # create a mapping\n mapping = dict((model.id, model) for model in query)\n\n for id in id_list:\n yield mapping[id]\n```\n", "Thanks for this. I found dirty but DB driven solution that works in MySQL:\n\n```\nlist_of_ids = [1,2,3,4,5,6]\nresult = MyModel.select().where(MyModel.id << list_of_ids).order_by(R(\"FIELD(t1.id, %s)\" % \", \".join(map(str, list_of_ids))))\n```\n", "interesting. another way you can do that is:\n\n``` python\n\nMyModel.select().where(MyModel.id << list_of_ids).order_by(\n fn.Field(MyModel.id, *[R(str(id)) for id in list_of_ids])\n)\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/164/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "zielmicha", "id": 364357, "node_id": "MDQ6VXNlcjM2NDM1Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/364357?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zielmicha", "html_url": "https://github.com/zielmicha", "followers_url": "https://api.github.com/users/zielmicha/followers", "following_url": "https://api.github.com/users/zielmicha/following{/other_user}", "gists_url": "https://api.github.com/users/zielmicha/gists{/gist_id}", "starred_url": "https://api.github.com/users/zielmicha/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zielmicha/subscriptions", "organizations_url": "https://api.github.com/users/zielmicha/orgs", "repos_url": "https://api.github.com/users/zielmicha/repos", "events_url": "https://api.github.com/users/zielmicha/events{/privacy}", "received_events_url": "https://api.github.com/users/zielmicha/received_events", "type": "User", "site_admin": false }

[]

[]

[ "No, there is _much_ more needed to make Peewee Python 3 compatible. `Model` uses a metaclass, and Python 3 changed how those were defined. Some judicious application of the `six` library would help there.\n", "I think I'm finally serious about py3 compatibility... I'll start a fix.\n", "With the release of 2.1.0, peewee's test suite and extra modules are working with 3.2 and 3.3!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/163/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "hobeone", "id": 3444588, "node_id": "MDQ6VXNlcjM0NDQ1ODg=", "avatar_url": "https://avatars.githubusercontent.com/u/3444588?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hobeone", "html_url": "https://github.com/hobeone", "followers_url": "https://api.github.com/users/hobeone/followers", "following_url": "https://api.github.com/users/hobeone/following{/other_user}", "gists_url": "https://api.github.com/users/hobeone/gists{/gist_id}", "starred_url": "https://api.github.com/users/hobeone/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hobeone/subscriptions", "organizations_url": "https://api.github.com/users/hobeone/orgs", "repos_url": "https://api.github.com/users/hobeone/repos", "events_url": "https://api.github.com/users/hobeone/events{/privacy}", "received_events_url": "https://api.github.com/users/hobeone/received_events", "type": "User", "site_admin": false }

[ { "id": 191751, "node_id": "MDU6TGFiZWwxOTE3NTE=", "url": "https://api.github.com/repos/coleifer/peewee/labels/Feature", "name": "Feature", "color": "02e10c", "default": false, "description": null } ]

[]

[ "Yep, I agree that would be nice. I'm working on refactoring the way DDL is generated currently -- would like to get that in place and probably build any schema changing stuff on top of it.\n", "Sweet.\n\nThanks for making peewee awesome!\n\nOn Fri, Feb 8, 2013 at 3:15 PM, Charles Leifer [email protected]:\n\n> Yep, I agree that would be nice. I'm working on refactoring the way DDL is\n> generated currently -- would like to get that in place and probably build\n> any schema changing stuff on top of it.\n> \n> —\n> Reply to this email directly or view it on GitHubhttps://github.com/coleifer/peewee/issues/162#issuecomment-13319239..\n\n## \n\nDaniel Hobe [email protected]\n", "I try! I will update this ticket with progress\n", "So I have made two or three attempts at creating a nice API for representing DDL and every time it feels more cumbersome and clunky than just writing the `create` statements by hand. I may have to scale back my goal and just try to provide a nice api for doing basic schema changes. Proposals are welcome\n", "Added some stuff in 180bf0b8e0dd22e87b216c59de4da68aa2ed1683 with some basic postgresql support.\n\nSQLite doesn't handle much more than adding columns, and MySQL uses a completely different syntax than Postgresql. Maybe this code could be refactored or retooled into something usable on different backends. For sqlite it will be necessary to create temp tables and rename rather than altering or dropping columns, since this is not supported.\n", "Cool, I'll take a look.\n\nI've looked into how a few other orms deal with this and it does seem like\neach db driver has to support their own thing.\n\nOn Sun, Mar 17, 2013 at 8:46 PM, Charles Leifer [email protected]:\n\n> Added some stuff in 180bf0bhttps://github.com/coleifer/peewee/commit/180bf0b8e0dd22e87b216c59de4da68aa2ed1683with some basic postgresql support.\n> \n> SQLite doesn't handle much more than adding columns, and MySQL uses a\n> completely different syntax than Postgresql. Maybe this code could be\n> refactored or retooled into something usable on different backends. For\n> sqlite it will be necessary to create temp tables and rename rather than\n> altering or dropping columns, since this is not supported.\n> \n> —\n> Reply to this email directly or view it on GitHubhttps://github.com/coleifer/peewee/issues/162#issuecomment-15037985\n> .\n\n## \n\nDaniel Hobe [email protected]\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/162/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "koblas", "id": 219934, "node_id": "MDQ6VXNlcjIxOTkzNA==", "avatar_url": "https://avatars.githubusercontent.com/u/219934?v=4", "gravatar_id": "", "url": "https://api.github.com/users/koblas", "html_url": "https://github.com/koblas", "followers_url": "https://api.github.com/users/koblas/followers", "following_url": "https://api.github.com/users/koblas/following{/other_user}", "gists_url": "https://api.github.com/users/koblas/gists{/gist_id}", "starred_url": "https://api.github.com/users/koblas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/koblas/subscriptions", "organizations_url": "https://api.github.com/users/koblas/orgs", "repos_url": "https://api.github.com/users/koblas/repos", "events_url": "https://api.github.com/users/koblas/events{/privacy}", "received_events_url": "https://api.github.com/users/koblas/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This is documented: http://peewee.readthedocs.org/en/latest/peewee/models.html#non-integer-primary-keys\n\nThe reason a model behaves this way is that it is much more simple and straightforward to simply look for a primary key than to try and track the state of a model.\n", "This bug would also apply if you sharded your ID space and used Snowflake to generate the IDs - which we are doing on some other tables. So it's not just limited to non-integer keys.\n", "Yes, this is somewhat discussed: http://peewee.readthedocs.org/en/latest/peewee/cookbook.html#bulk-loading-data-or-manually-specifying-primary-keys\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/161/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "andmart", "id": 303252, "node_id": "MDQ6VXNlcjMwMzI1Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/303252?v=4", "gravatar_id": "", "url": "https://api.github.com/users/andmart", "html_url": "https://github.com/andmart", "followers_url": "https://api.github.com/users/andmart/followers", "following_url": "https://api.github.com/users/andmart/following{/other_user}", "gists_url": "https://api.github.com/users/andmart/gists{/gist_id}", "starred_url": "https://api.github.com/users/andmart/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/andmart/subscriptions", "organizations_url": "https://api.github.com/users/andmart/orgs", "repos_url": "https://api.github.com/users/andmart/repos", "events_url": "https://api.github.com/users/andmart/events{/privacy}", "received_events_url": "https://api.github.com/users/andmart/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I replaced the line 786 by \n\n```\nparts.append('ORDER BY %s' % tuple(_)) \n```\n", "I can understnad your confusion. Peewee uses \"-<field name>\" to specify ordering in a models \"Meta\" attributes.\n\nHowever, when querying you will use a different syntax:\n\n``` python\n\nM.select().order_by(M.number.desc())\n```\n\nThis is covered in the docs: \n- http://peewee.readthedocs.org/en/latest/peewee/cookbook.html#sorting-records\n- http://peewee.readthedocs.org/en/latest/peewee/api.html#SelectQuery.order_by\n", "Thanks, man. Sorry about the false issue.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/160/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jharmn", "id": 1305160, "node_id": "MDQ6VXNlcjEzMDUxNjA=", "avatar_url": "https://avatars.githubusercontent.com/u/1305160?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jharmn", "html_url": "https://github.com/jharmn", "followers_url": "https://api.github.com/users/jharmn/followers", "following_url": "https://api.github.com/users/jharmn/following{/other_user}", "gists_url": "https://api.github.com/users/jharmn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jharmn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jharmn/subscriptions", "organizations_url": "https://api.github.com/users/jharmn/orgs", "repos_url": "https://api.github.com/users/jharmn/repos", "events_url": "https://api.github.com/users/jharmn/events{/privacy}", "received_events_url": "https://api.github.com/users/jharmn/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/159/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/159", "html_url": "https://github.com/coleifer/peewee/pull/159", "diff_url": "https://github.com/coleifer/peewee/pull/159.diff", "patch_url": "https://github.com/coleifer/peewee/pull/159.patch", "merged_at": null }

{ "login": "rosscdh", "id": 397106, "node_id": "MDQ6VXNlcjM5NzEwNg==", "avatar_url": "https://avatars.githubusercontent.com/u/397106?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rosscdh", "html_url": "https://github.com/rosscdh", "followers_url": "https://api.github.com/users/rosscdh/followers", "following_url": "https://api.github.com/users/rosscdh/following{/other_user}", "gists_url": "https://api.github.com/users/rosscdh/gists{/gist_id}", "starred_url": "https://api.github.com/users/rosscdh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rosscdh/subscriptions", "organizations_url": "https://api.github.com/users/rosscdh/orgs", "repos_url": "https://api.github.com/users/rosscdh/repos", "events_url": "https://api.github.com/users/rosscdh/events{/privacy}", "received_events_url": "https://api.github.com/users/rosscdh/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Even though your db may not use foreign key constraints, you can (and should) still use the `ForeignKeyField` to access them, unless I misunderstand the issue.\n\nPerhaps you could send me some models that you are using, or how you use this patch.\n", "HI Charles, Thanks for the Feedback.. let me try the FKField and Ill let\nyou know how it goes.. Apologies I dont know how, but I did miss this in\nthe documentation.\n\nAll the best\nRoss\n\nOn Sat, Feb 2, 2013 at 1:52 AM, Charles Leifer [email protected]:\n\n> Even though your db may not use foreign key constraints, you can (and\n> should) still use the ForeignKeyField to access them, unless I\n> misunderstand the issue.\n> \n> Perhaps you could send me some models that you are using, or how you use\n> this patch.\n> \n> —\n> Reply to this email directly or view it on GitHubhttps://github.com/coleifer/peewee/pull/158#issuecomment-13021749.\n", "I rewrote some of the join code to be a little more flexible in case you want to join on something that may not be a foreignkeyfield. Commit d1e5a4845383b4\n\nThe way you might do it is:\n\n``` python\n\nclass User(Model):\n username= CharField()\n\nclass Comment(Model):\n username = CharField()\n message = CharField()\n\n# Say you want to join comments with their user\nComment.select(Comment, User).join(User, on=(Comment.username == User.username))\n```\n", "Hi there!\n\nThat is perfect! and also more intuitive! Thank you very much.\n\nI must say Im quite enjoying using peewee. It feels a little ungainly on\nlarger queries but that is a symptom all ORMs suffer from I think.\n\nAll the best!\n\nRoss\n\nOn Sun, Feb 3, 2013 at 4:06 AM, Charles Leifer [email protected]:\n\n> I rewrote some of the join code to be a little more flexible in case you\n> want to join on something that may not be a foreignkeyfield. Commit\n> d1e5a48 https://github.com/coleifer/peewee/commit/d1e5a4845383b4\n> \n> The way you might do it is:\n> \n> class User(Model):\n> username= CharField()\n> class Comment(Model):\n> username = CharField()\n> message = CharField()\n> \n> # Say you want to join comments with their userComment.select(Comment, User).join(User, on=(Comment.username == User.username))\n> \n> —\n> Reply to this email directly or view it on GitHubhttps://github.com/coleifer/peewee/pull/158#issuecomment-13041552.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/158/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/158", "html_url": "https://github.com/coleifer/peewee/pull/158", "diff_url": "https://github.com/coleifer/peewee/pull/158.diff", "patch_url": "https://github.com/coleifer/peewee/pull/158.patch", "merged_at": null }

{ "login": "ivan-kleshnin", "id": 2128182, "node_id": "MDQ6VXNlcjIxMjgxODI=", "avatar_url": "https://avatars.githubusercontent.com/u/2128182?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ivan-kleshnin", "html_url": "https://github.com/ivan-kleshnin", "followers_url": "https://api.github.com/users/ivan-kleshnin/followers", "following_url": "https://api.github.com/users/ivan-kleshnin/following{/other_user}", "gists_url": "https://api.github.com/users/ivan-kleshnin/gists{/gist_id}", "starred_url": "https://api.github.com/users/ivan-kleshnin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ivan-kleshnin/subscriptions", "organizations_url": "https://api.github.com/users/ivan-kleshnin/orgs", "repos_url": "https://api.github.com/users/ivan-kleshnin/repos", "events_url": "https://api.github.com/users/ivan-kleshnin/events{/privacy}", "received_events_url": "https://api.github.com/users/ivan-kleshnin/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Do you mind putting an example of #1 -- particularly what you expect vs what you get.\n", "I also see that Postgresql does not support limit/order by on delete and update queries, and SQLite only supports them if it was compiled with `SQLITE_ENABLE_UPDATE_DELETE_LIMIT` -- what db do you use out of curiosity?\n\nAnother option is to do the delete and select the ids to remove in a subquery where you apply the limit and ordering.\n", "#1 nevermind, sorry. I forgot that peewee can preload with join only master-models.\n#2 I use MySQL. I didn't know that PgSQL does not support that. I'ts kinda disappointing when you DELETE without LIMIT and with mistyped WHERE clause\n\nThus close this thread, pls.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/157/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "nesizer", "id": 62032, "node_id": "MDQ6VXNlcjYyMDMy", "avatar_url": "https://avatars.githubusercontent.com/u/62032?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nesizer", "html_url": "https://github.com/nesizer", "followers_url": "https://api.github.com/users/nesizer/followers", "following_url": "https://api.github.com/users/nesizer/following{/other_user}", "gists_url": "https://api.github.com/users/nesizer/gists{/gist_id}", "starred_url": "https://api.github.com/users/nesizer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nesizer/subscriptions", "organizations_url": "https://api.github.com/users/nesizer/orgs", "repos_url": "https://api.github.com/users/nesizer/repos", "events_url": "https://api.github.com/users/nesizer/events{/privacy}", "received_events_url": "https://api.github.com/users/nesizer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "a workaround for now is\n\n```\nGame.select(Game, fn.Sum(Stat.viewers).alias('viewers')).join(Stat, JOIN_LEFT_OUTER).group_by(Game).order_by(R('viewers DESC')).limit(5) \n```\n\nbut that runs up to 10 times slower then the sub queries on\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/156/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "maebert", "id": 1047165, "node_id": "MDQ6VXNlcjEwNDcxNjU=", "avatar_url": "https://avatars.githubusercontent.com/u/1047165?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maebert", "html_url": "https://github.com/maebert", "followers_url": "https://api.github.com/users/maebert/followers", "following_url": "https://api.github.com/users/maebert/following{/other_user}", "gists_url": "https://api.github.com/users/maebert/gists{/gist_id}", "starred_url": "https://api.github.com/users/maebert/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maebert/subscriptions", "organizations_url": "https://api.github.com/users/maebert/orgs", "repos_url": "https://api.github.com/users/maebert/repos", "events_url": "https://api.github.com/users/maebert/events{/privacy}", "received_events_url": "https://api.github.com/users/maebert/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This is similar to what the `.get()` method does [link](http://peewee.readthedocs.org/en/latest/peewee/api.html#Model.get) / [src](https://github.com/coleifer/peewee/blob/master/peewee.py#L1328) except instead of raising an exception it returns `None`. I don't see how this is any better -- i assume you still have an if statement somewhere to see if you have a model or `None`.\n", "Sorry Charles, I wasn't very clear about this. This is not any better or worse than `.get()`, it's just an alternative that improves compatibility to and portability from SQLAlchemy based modules such as `flask-security`. So basically, when porting code that works with SQLAlchemy to work with peewee, whenever the code sats\n\n``` python\nreturn User.query.filter_by(name=\"admin\").first()\n```\n\nthe Peewee equivalent is \n\n``` python\ntry:\n return User.filter(name=\"admin\").get()\nexcept User.DoesNotExist:\n return None\n```\n\nor rather, since `filter` is deprecated in 2.0,\n\n``` python\ntry:\n return User.filter(User.name == \"admin\").get()\nexcept User.DoesNotExist:\n return None\n```\n\nworsening code ports in cases like this:\n\n``` python\n# code excerpt from flask-security working with SQLAlchemy\ndef find_role(self, **kwargs):\n return self.user_role.query.filter_by(**kwargs).first()\n```\n\nIntroducing short-hands like `.first()` (and maybe not deprecating the for shorter queries incredibly useful `filter` syntax) simply improves portability and thus greater support for peewee.\n", "OK, you convinced me on `first`: 486a08ce6c1592653fba196cee8f7cb523d28d19\n", "Cool, thanks a lot! After a quick and dirty test though I think the query is slightly faster if limiting to one result before executing (doing `res = self.limit(1).execute()`). My [test setup](https://gist.github.com/4638612) was a local SQLite db, 10000 rows, query matched 100 rows, I timed creating one object after the DB was set up and connected. It's not big, about 10ns per query (based on 1mio repetitions), but that's using a local DB already, so for requests over a network it might yield a little improvement.\n", "Yes .first() is not implemented as efficiently as .get() -- but that is on purpose. It's name is .first(), implying there might be a second. Additionally, multiple calls to first() will not result in the query being evaluated multiple times, which is _not_ the case with .get(). If you want, you can always put the limit before the call to first:\n\n``` python\n\nSomething.select().limit(1).first()\n```\n\nor just write a wrapper\n\n``` python\n\ndef first(query):\n return query.limit(1).first()\n```\n\nAs to filter(), yes I agree it is easy to use but it is not flexible. We have to add hacks like django's double-underscore to specify operations other than `eq`, and trying to biuld a query tree results in hacks like `DQ`.\n\nFor a bit more of my rationale, see http://charlesleifer.com/blog/shortcomings-in-the-django-orm-and-a-look-at-peewee-a-lightweight-alternative/\n", "Fair call. Thanks for implementing this!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/155/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/155", "html_url": "https://github.com/coleifer/peewee/pull/155", "diff_url": "https://github.com/coleifer/peewee/pull/155.diff", "patch_url": "https://github.com/coleifer/peewee/pull/155.patch", "merged_at": null }

{ "login": "Miserlou", "id": 139987, "node_id": "MDQ6VXNlcjEzOTk4Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/139987?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Miserlou", "html_url": "https://github.com/Miserlou", "followers_url": "https://api.github.com/users/Miserlou/followers", "following_url": "https://api.github.com/users/Miserlou/following{/other_user}", "gists_url": "https://api.github.com/users/Miserlou/gists{/gist_id}", "starred_url": "https://api.github.com/users/Miserlou/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Miserlou/subscriptions", "organizations_url": "https://api.github.com/users/Miserlou/orgs", "repos_url": "https://api.github.com/users/Miserlou/repos", "events_url": "https://api.github.com/users/Miserlou/events{/privacy}", "received_events_url": "https://api.github.com/users/Miserlou/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Not sure exactly what happened -- take a look here:\n\nhttp://stackoverflow.com/questions/151026/how-do-i-unlock-a-sqlite-database\n", "I love you. Sorry for bringing this up on GitHub, I couldn't get a response on IRC. This data is pretty important to me and I was having a mini panic attack. \n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/154/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "djt", "id": 145617, "node_id": "MDQ6VXNlcjE0NTYxNw==", "avatar_url": "https://avatars.githubusercontent.com/u/145617?v=4", "gravatar_id": "", "url": "https://api.github.com/users/djt", "html_url": "https://github.com/djt", "followers_url": "https://api.github.com/users/djt/followers", "following_url": "https://api.github.com/users/djt/following{/other_user}", "gists_url": "https://api.github.com/users/djt/gists{/gist_id}", "starred_url": "https://api.github.com/users/djt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/djt/subscriptions", "organizations_url": "https://api.github.com/users/djt/orgs", "repos_url": "https://api.github.com/users/djt/repos", "events_url": "https://api.github.com/users/djt/events{/privacy}", "received_events_url": "https://api.github.com/users/djt/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/153/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/153", "html_url": "https://github.com/coleifer/peewee/pull/153", "diff_url": "https://github.com/coleifer/peewee/pull/153.diff", "patch_url": "https://github.com/coleifer/peewee/pull/153.patch", "merged_at": null }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Fixed 821146b24b3e2c9376\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/152/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "rosscdh", "id": 397106, "node_id": "MDQ6VXNlcjM5NzEwNg==", "avatar_url": "https://avatars.githubusercontent.com/u/397106?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rosscdh", "html_url": "https://github.com/rosscdh", "followers_url": "https://api.github.com/users/rosscdh/followers", "following_url": "https://api.github.com/users/rosscdh/following{/other_user}", "gists_url": "https://api.github.com/users/rosscdh/gists{/gist_id}", "starred_url": "https://api.github.com/users/rosscdh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rosscdh/subscriptions", "organizations_url": "https://api.github.com/users/rosscdh/orgs", "repos_url": "https://api.github.com/users/rosscdh/repos", "events_url": "https://api.github.com/users/rosscdh/events{/privacy}", "received_events_url": "https://api.github.com/users/rosscdh/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you, I'm glad you're enjoying peewee!\n\nI hadn't heard of dbslayer so I took a look at it... I am pretty sure i would never recommend anyone use dbslayer... but of course if you wanted to build an adapter I think it would be possible.\n\nThis is a good place to start: http://peewee.readthedocs.org/en/latest/peewee/database.html#writing-a-database-driver\n\nYou would need to implement a subclass of database, probably `MySqlDatabase`. Since you're working with http you will need to implement or work around the various db-api 2.0 calls that peewee uses.\n\nThe apsw driver in \"playhouse\" has to wrap a number of db-api 2.0 functions, so that's a good place to look as well:\nhttps://github.com/coleifer/peewee/blob/master/playhouse/apsw_ext.py\n\nGood luck, let me know if you have any more questions.\n\n:monkey_face: :bear: :rabbit:\n", "Hi there,\n\nThanks for the great feedback. Id be interested in hearing your opinion on\nwhy not to use dbslayer? aside from the obvious security issues (which in\nour case are partially solved by a closed network and specific access\nroutes). Our main attraction for it being clean simply load-balancing\n(using cherokee).\n\nall the best\nRoss\n\nOn Fri, Jan 18, 2013 at 3:45 PM, Charles Leifer [email protected]:\n\n> Thank you, I'm glad you're enjoying peewee!\n> \n> I hadn't heard of dbslayer so I took a look at it... I am pretty sure i\n> would never recommend anyone use dbslayer... but of course if you wanted to\n> build an adapter I think it would be possible.\n> \n> This is a good place to start:\n> http://peewee.readthedocs.org/en/latest/peewee/database.html#writing-a-database-driver\n> \n> You would need to implement a subclass of database, probably MySqlDatabase.\n> Since you're working with http you will need to implement or work around\n> the various db-api 2.0 calls that peewee uses.\n> \n> The apsw driver in \"playhouse\" has to wrap a number of db-api 2.0\n> functions, so that's a good place to look as well:\n> https://github.com/coleifer/peewee/blob/master/playhouse/apsw_ext.py\n> \n> Good luck, let me know if you have any more questions.\n> \n> —\n> Reply to this email directly or view it on GitHubhttps://github.com/coleifer/peewee/issues/151#issuecomment-12424613.\n", "Sure thing! And i'm happy to provide help when you start implementing.\n\nThe biggest detractors i see are:\n- overhead of HTTP versus socket connections\n- overhead of serialization to JSON and having to implement conversion between json & native python types\n- limitations on response size or problems with large queries or responses\n\nIf it were me i would write a connection pool that also did load balancing. This would get rid of the Http request/response cycle overhead and serialization overhead.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/151/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This error was reported via google groups. The issue is on line 776 in `_parse_field_dictionary` which parses things like updates and inserts. It iterates the dictinary and hands off the value to `parse_expr` before sending it to db_value() and this is where the lists are getting mangled.\n", "Fixed in 1d4290784a1ae183c -- see commit message for details, the tl;dr is that we don't know if we should call db_value or parse_expr first -- we call parse_expr because it is more general and powerful, but there is special logic for handling lists (which are used primarily to build up IN clauses). This doesn't play nice w/the behavior we wanted for the csv field for instance. The fix was basically, if the expression is not a \"rich\" object, to pass it thru the parse_expr.\n", "Is this still fixed in the latest version?\r\n\r\nI have made a ListField, which is pretty much the same as here:\r\n\r\n```\r\nclass ListField(Field): \r\n \r\n def db_value(self, value):\r\n out = \"\"\r\n for val in value:\r\n out += val\r\n out += \" \"\r\n return out[:-1]\r\n\r\n def python_value(self, value):\r\n return value.split(\" \")\r\n```\r\n\r\nI get the same error: peewee.OperationalError: near \",\": syntax error\r\ndb_value doesnt get a list, but gets called for each item in the list", "Workaround:\r\n\r\nMade a class that contains the list. Made a ClassField for this class, that uses the list to create the output." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/150/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "rotated8", "id": 638392, "node_id": "MDQ6VXNlcjYzODM5Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/638392?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rotated8", "html_url": "https://github.com/rotated8", "followers_url": "https://api.github.com/users/rotated8/followers", "following_url": "https://api.github.com/users/rotated8/following{/other_user}", "gists_url": "https://api.github.com/users/rotated8/gists{/gist_id}", "starred_url": "https://api.github.com/users/rotated8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rotated8/subscriptions", "organizations_url": "https://api.github.com/users/rotated8/orgs", "repos_url": "https://api.github.com/users/rotated8/repos", "events_url": "https://api.github.com/users/rotated8/events{/privacy}", "received_events_url": "https://api.github.com/users/rotated8/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/149/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/149", "html_url": "https://github.com/coleifer/peewee/pull/149", "diff_url": "https://github.com/coleifer/peewee/pull/149.diff", "patch_url": "https://github.com/coleifer/peewee/pull/149.patch", "merged_at": "2013-01-14T15:26:00" }

{ "login": "Pacek", "id": 234758, "node_id": "MDQ6VXNlcjIzNDc1OA==", "avatar_url": "https://avatars.githubusercontent.com/u/234758?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Pacek", "html_url": "https://github.com/Pacek", "followers_url": "https://api.github.com/users/Pacek/followers", "following_url": "https://api.github.com/users/Pacek/following{/other_user}", "gists_url": "https://api.github.com/users/Pacek/gists{/gist_id}", "starred_url": "https://api.github.com/users/Pacek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Pacek/subscriptions", "organizations_url": "https://api.github.com/users/Pacek/orgs", "repos_url": "https://api.github.com/users/Pacek/repos", "events_url": "https://api.github.com/users/Pacek/events{/privacy}", "received_events_url": "https://api.github.com/users/Pacek/received_events", "type": "User", "site_admin": false }

[]

[]

[ "hmm...yeah it probably should...though its not really supposed to be \"perfect\" ya know? you will still probably want to edit it...but maybe it can drop a warning in there or something\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/148/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "markschl", "id": 783293, "node_id": "MDQ6VXNlcjc4MzI5Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/783293?v=4", "gravatar_id": "", "url": "https://api.github.com/users/markschl", "html_url": "https://github.com/markschl", "followers_url": "https://api.github.com/users/markschl/followers", "following_url": "https://api.github.com/users/markschl/following{/other_user}", "gists_url": "https://api.github.com/users/markschl/gists{/gist_id}", "starred_url": "https://api.github.com/users/markschl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/markschl/subscriptions", "organizations_url": "https://api.github.com/users/markschl/orgs", "repos_url": "https://api.github.com/users/markschl/repos", "events_url": "https://api.github.com/users/markschl/events{/privacy}", "received_events_url": "https://api.github.com/users/markschl/received_events", "type": "User", "site_admin": false }

[ { "id": 191750, "node_id": "MDU6TGFiZWwxOTE3NTA=", "url": "https://api.github.com/repos/coleifer/peewee/labels/Bug", "name": "Bug", "color": "e10c02", "default": false, "description": null } ]

[]

[ "http://www.sqlite.org/autoinc.html - i will see about a fix\n", "Because SQLite incurs additional overhead to guarantee monotonically incrementing PKs, I will keep the default behavior which simply guarantees they are unique.\n\nIf you would like to use an autoincrementing primary key, try this in your code:\n\n``` python\n\ndb = SqliteDatabase('mydb.db', fields={'primary_key': 'INTEGER AUTOINCREMENT'})\n```\n\nOr\n\n``` python\n\ndb.register_fields({'primary_key': 'INTEGER AUTOINCREMENT'})\n```\n", "I thought about that, too; unfortunately Sqlite complains about a syntax error. The \"invalid\" SQL looks like this:\n\nCREATE TABLE \"test\" (\"id\" INTEGER AUTOINCREMENT NOT NULL PRIMARY KEY, ...)\nI believe, the AUTOINCREMENT should be positioned after PRIMARY KEY.\n", "I'm thinking about trying to refactor all the DDL stuff. Hopefully that might make something like this change easier...currently the ordering of the clauses is somewhat hardcoded :goberserk: \n", "Still not work.\n\n1 `db = SqliteDatabase('mydb.db', fields={'primary_key': 'INTEGER AUTOINCREMENT'})` got below error:\n\n`peewee.OperationalError: near \"AUTOINCREMENT\": syntax error`\n\nSQL is:\n`u'CREATE TABLE \"customer\" (\"id\" INTEGER AUTOINCREMENT NOT NULL PRIMARY KEY, \"name\" VARCHAR(255) NOT NULL, \"upper_name\" VARCHAR(255) NOT NULL, \"remark\" VARCHAR(255) NOT NULL)'`\n\n2 `db.register_fields({'primary_key': 'INTEGER AUTOINCREMENT'})` has no effect at all\n", "This is for a much older version of Peewee. Check out http://docs.peewee-orm.com/en/latest/peewee/playhouse.html#PrimaryKeyAutoIncrementField\n", "So, I have to define id manually? And, `PrimaryKeyAutoIncrementField` is only for Sqlite, right?\n\n```\nClass User(Model):\n id = PrimaryKeyAutoIncrementField()\n name = CharField()\n```\n", "Peewee includes an autoincrement pk by default for all databases. For sqlite, there are different types, rowid and a special autoincrement type. See:\n\nhttp://www.sqlite.org/autoinc.html\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/147/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "beanyoung", "id": 973789, "node_id": "MDQ6VXNlcjk3Mzc4OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/973789?v=4", "gravatar_id": "", "url": "https://api.github.com/users/beanyoung", "html_url": "https://github.com/beanyoung", "followers_url": "https://api.github.com/users/beanyoung/followers", "following_url": "https://api.github.com/users/beanyoung/following{/other_user}", "gists_url": "https://api.github.com/users/beanyoung/gists{/gist_id}", "starred_url": "https://api.github.com/users/beanyoung/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/beanyoung/subscriptions", "organizations_url": "https://api.github.com/users/beanyoung/orgs", "repos_url": "https://api.github.com/users/beanyoung/repos", "events_url": "https://api.github.com/users/beanyoung/events{/privacy}", "received_events_url": "https://api.github.com/users/beanyoung/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I do not plan on merging this, however I am glad you were able to extend the mysql apis.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/146/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/146", "html_url": "https://github.com/coleifer/peewee/pull/146", "diff_url": "https://github.com/coleifer/peewee/pull/146.diff", "patch_url": "https://github.com/coleifer/peewee/pull/146.patch", "merged_at": null }

{ "login": "methane", "id": 199592, "node_id": "MDQ6VXNlcjE5OTU5Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/199592?v=4", "gravatar_id": "", "url": "https://api.github.com/users/methane", "html_url": "https://github.com/methane", "followers_url": "https://api.github.com/users/methane/followers", "following_url": "https://api.github.com/users/methane/following{/other_user}", "gists_url": "https://api.github.com/users/methane/gists{/gist_id}", "starred_url": "https://api.github.com/users/methane/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/methane/subscriptions", "organizations_url": "https://api.github.com/users/methane/orgs", "repos_url": "https://api.github.com/users/methane/repos", "events_url": "https://api.github.com/users/methane/events{/privacy}", "received_events_url": "https://api.github.com/users/methane/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/145/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/145", "html_url": "https://github.com/coleifer/peewee/pull/145", "diff_url": "https://github.com/coleifer/peewee/pull/145.diff", "patch_url": "https://github.com/coleifer/peewee/pull/145.patch", "merged_at": null }

{ "login": "methane", "id": 199592, "node_id": "MDQ6VXNlcjE5OTU5Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/199592?v=4", "gravatar_id": "", "url": "https://api.github.com/users/methane", "html_url": "https://github.com/methane", "followers_url": "https://api.github.com/users/methane/followers", "following_url": "https://api.github.com/users/methane/following{/other_user}", "gists_url": "https://api.github.com/users/methane/gists{/gist_id}", "starred_url": "https://api.github.com/users/methane/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/methane/subscriptions", "organizations_url": "https://api.github.com/users/methane/orgs", "repos_url": "https://api.github.com/users/methane/repos", "events_url": "https://api.github.com/users/methane/events{/privacy}", "received_events_url": "https://api.github.com/users/methane/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/144/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/144", "html_url": "https://github.com/coleifer/peewee/pull/144", "diff_url": "https://github.com/coleifer/peewee/pull/144.diff", "patch_url": "https://github.com/coleifer/peewee/pull/144.patch", "merged_at": "2012-12-26T15:13:26" }

{ "login": "methane", "id": 199592, "node_id": "MDQ6VXNlcjE5OTU5Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/199592?v=4", "gravatar_id": "", "url": "https://api.github.com/users/methane", "html_url": "https://github.com/methane", "followers_url": "https://api.github.com/users/methane/followers", "following_url": "https://api.github.com/users/methane/following{/other_user}", "gists_url": "https://api.github.com/users/methane/gists{/gist_id}", "starred_url": "https://api.github.com/users/methane/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/methane/subscriptions", "organizations_url": "https://api.github.com/users/methane/orgs", "repos_url": "https://api.github.com/users/methane/repos", "events_url": "https://api.github.com/users/methane/events{/privacy}", "received_events_url": "https://api.github.com/users/methane/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/143/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/143", "html_url": "https://github.com/coleifer/peewee/pull/143", "diff_url": "https://github.com/coleifer/peewee/pull/143.diff", "patch_url": "https://github.com/coleifer/peewee/pull/143.patch", "merged_at": "2012-12-26T15:14:36" }

{ "login": "arielrossanigo", "id": 2752109, "node_id": "MDQ6VXNlcjI3NTIxMDk=", "avatar_url": "https://avatars.githubusercontent.com/u/2752109?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arielrossanigo", "html_url": "https://github.com/arielrossanigo", "followers_url": "https://api.github.com/users/arielrossanigo/followers", "following_url": "https://api.github.com/users/arielrossanigo/following{/other_user}", "gists_url": "https://api.github.com/users/arielrossanigo/gists{/gist_id}", "starred_url": "https://api.github.com/users/arielrossanigo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arielrossanigo/subscriptions", "organizations_url": "https://api.github.com/users/arielrossanigo/orgs", "repos_url": "https://api.github.com/users/arielrossanigo/repos", "events_url": "https://api.github.com/users/arielrossanigo/events{/privacy}", "received_events_url": "https://api.github.com/users/arielrossanigo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I decided to fix this everywhere that a \"false-y\" value was used: 51328066c4c7b1d7c043c5e37fc06c519e9f168a\n", "Great! thanks\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/142/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }