Datasets:

showvikdbz

/

code-reviews

like 0

damnit, my speling is usully purfect

autospec false is redundant

this is ridiculous $$merge$$

these lines should be removed this is handled by updatepreferencesfromstate

whole string should be removed

so this shit does not become the size of the entire game

name is ridiculous lol

Wait what the hell I deleted that file.

i think it should be a dict

ok but the step does not say that this needs to be done on the node running the l agent

Half the reason we do our own lighting shit is to bypass that bit of bullshit Setting this above 6 used to make people grow dicks. (see #7510)

if you have full wordpress templates you do not need tuskar the point of tuskar is for the planning not just to be a place to shove templates go directly to glance if you have a kickass hacked wordpress template and want to store it somewhere we re also going down a tangent this spec has been going on for a while and we need to get started on actually implementing it so please try to keep the speculation of the future at a minimum

i think this code should just be put into the caller it is really not doing any extra work than calling utils execute

we should remove l to keep proper import order

we ll want to prefix these hiera vars with wiki

Yeah I fucking removed this expression, it was eating my right brackets and I don't know why. You want it back go fix it fucking nerds.

all noq ass hould be removed

To the rubbish pile!

i would put these inside is service enabled octavia

netaddr eui will handle validation for us i will add some negative tests

q in def update address pairs on port the main difference i can see from what was previously done here is to assign new pairs to the updated port address pairs is that the actual fix here i mean the reason this method was returning existing rather than updated port info

Ugh I think I fell victim to the new test framework. I definitely ran tests and they definitely worked.

And a disgusting one at that. Will fix.

Don't do this, it fucks up doc-comments and doesn't look good. Remove the comment entirely IMO--it provides nothing.

This is pretty good, but it's open to a DOS attack. I don't think there's anything stopping somebody from sending us a truly disgusting query with 10,000 terms. Can you put a limit on the length of the query and have it just do nothing if there are too many parts?

kill is checked

should this be bpf handle sockaddr type none rather than fs

what are you talking about this function has already been mocked

Ugh, how painful! (This is not a "no", just an "OMG why do we need to deal with such crap..)

I think c1439f7 misses the point. We definitely don't want to duplicate the config file (since its an abomination in the first place) and we don't want to create two separate sections in the config file that are tightly coupled. Superseded by #511

same here useless error in a console log

gotcha just wanted to clarify

fixed the silly spelling mistake thanks for pointing it out

Yeah plurals kinda suck in various languages. Gettext (and by extension NGettext) has a system for this including like an arbitrary expression parser to select plural forms.

you may end up having data null as per

please put a colon instead of the dot and i would write this requires the following commands to be executed

that was just sloppy i meant to change it before checking it in

have i mentioned that putting the tenant project in the uri is retard ed sigh

does the callback know what thread they are going to be executed on

I wondered where that sucker was...

my apologies for these silly errors

wrong should have just looked into connection start which is starting a daemon with while true loop and mocks

oh lol shit this convenience thing has started propagating into PRs

this seemed odd to me too but i was a coward i am pretty sure it is harmless though and ccross just pointed out that in the case the error message would be a lie anyway

To be honest, I'm confused by the idea of having 2 representations. Imo this "feature" should be dropped, especially since behind the scene it's the same crap. Anyway, you're right.

you are overwriting original filters it makes isequal below useless use deepcloning or flags to detect differences when overwriting values

I find it weird that the prox_sensor is getting qdel'd but not the fucking assembly

needs global static url

Yuck. This is horrible.

sshmanager does not contain implementation of remote execute commands like execute through host in os actions py

One other wacky idea....what if we were to leverage our devops public wiki? It's 100% public, and might have better functionality. https://uifabric.visualstudio.com/fabricpublic/_wiki

i wish we could get rid of that automagic thing but i guess we have to live with this forever

Damn, never clean up the code after it is tested :-(

the process does not need cleaning up the kill logic has been part of the script for a long time however when we pull the tar pid to kill via tar proc pid it is the pid that already exited but hangs indefinitely until the return code is read when we poll for the return code the process goes away and the pipe closes and the script exits and respawns under glance api retry logic the kill logic still exists for edge cases where tar may be stuck for other reasons

would not it be better to use the os kill function then execute a subshell

nameerror if url is none but is that possible

What would you like for me to add instead? I can make it cost plasteel or something, but I just hate recipes that require weird items since it ensures they will almost never be actually crafted

edit okay pylint just told me that i am an idiot and that you meant the error function in argparse instead

i would expect get by instance to take an instance object maybe a better name is get by instance uuid

you probably need to get rid of this one given that you have removed glib s spawn

Goofy, but most likely we won't get to this, ever.

as at line consider aborting if getproperties fails

this would be much easier to review if you left it below the testpersrc mutator

with the multiplier below is the dummy supposed to be decimal because x is which is potentially a valid dvfs avg lpf result

This is indeed for the resource center and other third party maps. It sucks to have these checks hardcoded in common code, but we can't fix that until we redo the upgrade rules plumbing.

This behaviour is also intentional: we moved to Generals style unloading because the earlier one at a time unloading sucked.

it works! damn nemvar thanks a lot

GOOF YOU LEFT OUT THE PICK YOU SHITBIRD

up to novez does it make sense to pull in security and block this i do not really think there is any security problem here

this stanza is not really needed according to bin kill kill ps oppid pid below a parent process mysqld sage will kill all it is chileds mysqld logger and xtrabackup as well

you should have a son of bitch

great catch let me just wipe that egg off my face

How about "excessive"? Absurd sounds a bit excessive a warning to me.

you may as well use javadoc comments for these methods

damn, i screwed this one up... going to amend outside of browser hell, sorry

Okay I fucked up, thats minutes not deciseconds so 20 HOURS wont work. Make a define thats 1200, and set it to that instead.

whitespace here is giga fucked

avoid overwriting rl src low reg by the kopmov below if rl result low reg rl src low reg std swap rl src rl src that should fix the obviously broken mov ebp ebx cmp ebx ebp cmovl nge ebp ebp

same as before we should probably remove user names and such from these files

we want to terminate the http server in order to force monitoring to fail which is initally running from script httpsrv sh just incase if the server is still running we are making sure to kill it

Cat ran over your keyboard, which is bad if you have allergies!

Shit. I did not think about that. Thanks.

That kind of sucks, but should be fine since this is a code generator for the GDJS platform exclusively.

not a big deal but too many levels of nested block may make people confused what about using if break and for loops ex if childnode i haschildnodes break for var iternode childnode i firstchild iternode null iternode iternode nextsibling if iternode nodename node continue

forgive me about the dumb question is this being commented out because it is content is now in extension wadl

This has nothing to do with vcpkg...... close this issue ..... please move your question to stackoverflow. (C#?) static methods don't act on the instance itself but on the class. As such the `this` pointer is not accessible although I don't know why the compiler lets you do such nonsense in whatever language you are using here

how about isprint in curses ascii

done

even if you set here infinite value granula has own timeout which will abort puppet

you could have mock fabric data self vmutils conn msps mspsfabricdata new return value fsk self vmutils conn msps msps fsk new return value

Fix what? It's completely correct, aside from the obvious tongue-in-cheek joke

to trigger buid py to pull

probably a dumb question but what does in use mean exactly bound drawing in flight

Ah, dammit. Thank you.

@marutosi [Your comment linking the issue](https://github.com/opf/openproject/pull/2066#issuecomment-110794301) to Debian's oldstable bundler release as an exhibit of a bundler version 1.5. out in the wild is just absurd: it depends on an unsupported ruby 1.8 package and whoever still tries to use OP with it will have a completely different set of problems. Nonetheless, given the vague error message, I don't see the harm in re-introducing that warning for the poor folks still stuck with an older bundler. Let @linki drop it again when bundler 2 is finally released ;)

It was defined twice? Weird.

those blasted patch requests are the worst this and the path info in resp environ check above are a bit overly defensive for my tastes it s just distracting why is this code here how does this happen is swob broken should i re read pep wait should i me wastes an mins nope must be present phew

Uh, no, bruise packs are something doctors rely on, fuck your goonchem being shoved into everything.

ah wasn't sure if this was hacktober rubbish or a genuine "targeted the wrong repo". but yeah, will do.

oh i realize it is what we do in other places and it is probably ok but sqlite makes me paranoid lately so if this transforms to a landing cl we might as well start from the right approach while it is still simple